summaryrefslogtreecommitdiff
path: root/java/com/android/dialer/app
AgeCommit message (Collapse)Author
2018-03-19Show spam blocking promo after block spam dialogAndroid Dialer
Test: SpamBlockingPromoHelperTest PiperOrigin-RevId: 189674918 Change-Id: I0b22eb9b8128125cc5b439674099820a01c3889f
2018-03-19Check null for getPhoneAccount()twyen
A phone account can be removed after calling getCallCapablePhoneAccounts(), so subsequent getPhoneAccount() can be null. Other usages already has the null check. Bug: 75598828 Test: N/A testing this involves getPhoneAccount() returning null on the nth call, which requires replacing the shadows with a mock and is highly coupled with the implementation. The is an edge case and is not worth the effort and brittleness it will cause. PiperOrigin-RevId: 189644833 Change-Id: Ie92dda2537befb5936ad734954b4eaf75964f465
2018-03-16Check if parent is null since fetch call can be called while Dialer is paused.calderwoodra
Bug: 73972084 Test: n/a PiperOrigin-RevId: 189418664 Change-Id: I3dadea08dad1f2a594f5a7e0daf055721c3222a3
2018-03-16Refactor VM Settings and add support for voicemail transcriptionuabdullah
This CL refactors the existing voicemail settings fragment and adds UI support for voicemail transcription. It mainly deals with the following: - ensuring that when the VVM toggle is turned off, transcription and donations are gone. - when transcription is off, donation preference is gone. - donation is only available when transcription is available and enabled - as part of the refactor, fixes existing logging bugs - breaks preferences and its associated methods into helper methods when possible - groups relevant preferences together when possible Bug: 74033229 Test: Unit tests PiperOrigin-RevId: 189418217 Change-Id: I3442cb5752a235cfca643ba55df3fb75171e3fe4
2018-03-16Make MainActivity the default activity for AOSP.calderwoodra
This also finishes moving all of the old tests over from Dialtacts to Main. The only 2 tests that fail are: - searchBoxClosedWhenHandlingNotificationIntent - openSearchFragment_fabGoneInRegularSearchAfterRotation I will fix these in a follow up CL. Bug: 72525887 Test: dialer_aosp build target launches MainActivity, TAP PiperOrigin-RevId: 189408987 Change-Id: Ice30191d95c19c62bcd89503e89f66440f30beac
2018-03-15Restore delete call log item logging in call details.calderwoodra
This was accidentally removed in cl/176677167. This change restores the logging in call details and also adds it to the call log menu. Bug: 73774284 Test: OldCallDetailsActivityIntegrationTest, CallLogActivityIntegrationTest PiperOrigin-RevId: 189279107 Change-Id: Iadda16d7f1e4d720f828b5a72f210bcb8029f939
2018-03-15Resolve all build resource conflicts.calderwoodra
For simplicity, instead of resolve the nui shortcut string, I deleted it since it isn't used anymore. Test: build log PiperOrigin-RevId: 189260472 Change-Id: I67d5a49d78916a8960e41ad1c7b7f59efad6d718
2018-03-15Add utility used to style content with learn more linksmaxwelb
Bug: 74017355 Test: ContentWithLearnMoreSpannerTest PiperOrigin-RevId: 189252365 Change-Id: I3464fb56b86a6b3ddd25e9eed14152eaeed9925c
2018-03-14Split CallDetailsActivitylinyuh
Bug: 74202944 Test: Existing tests PiperOrigin-RevId: 189095432 Change-Id: I13015ee6c5767edd95b78c3fb2e7338495e9e1d7
2018-03-12Don't fetch calls if the parent doesn't exist.calderwoodra
This CL is a continuation of cl/187700318. In that CL, we were able to unregister the call log's content observer and prevent this crash, but it's reshowing itself in voicemail now. Since the voicemail's observer is registered in the adapter and is unaware of lifecycle changes, it's much more invasive to fix. So as a quick bandaid, we'll just check that the parent isn't null. Bug: 73972084 Test: n/a PiperOrigin-RevId: 188812159 Change-Id: I533114de66b52395b0f3c90d4ec7a927c4df707f
2018-03-12Keyboard and search now close when appropriate.calderwoodra
Keyboard should close when: - requeting permission - placing a call - leaving the app Search should close when: - placing a call - leaving the app Bug: 74235853 Test: search closing onPause tests already exist (MainActivityOldPeerSearchIntegrationTest#placingCallFromSearchClosesSearch) PiperOrigin-RevId: 188812026 Change-Id: Iaee084c59b4c514d10375deff5d73d5a456ef9df
2018-03-09Add spam blocking setting in spam module.Android Dialer
Test: InAppSpamTest,ApdlSpamTest,VisualVoicemailUpdateTaskTest PiperOrigin-RevId: 188509191 Change-Id: I8b9c07dcc1c7b3b80ffc914ec99f4e6d80d50985
2018-03-08Implement non-ui logic for delete/undo delete voicemailsuabdullah
When a voicemail is deleted we have to allow the user the option of cancelling the deleting of voicemail. This is done by showing the user a snack bar which when a user taps will prevent the voicemail from being deleted. This CL only adds the underlying logic for the delete/undelete to take place via a ScheduledFuture, it does not fix all the UI issues that come with it, which will be sent in a follow up CL, issues such as: -Updating the group label when a delete/undo happens -Updating the entries above and below when a delete/undo happens -Showing the empty view immediately when a user deletes a single voicemail -Removing the empty view immediately when a user taps undo -Updating tests Bug: 69858266 Test: Manual PiperOrigin-RevId: 188424489 Change-Id: Iecf5cb7be5b80fa5e91acaad3a7cc4a6c8702521
2018-03-08Add flag for filtering emergency calls from call logmaxwelb
Bug: 73368638 Test: CallLogAdapterTest PiperOrigin-RevId: 188414469 Change-Id: I7d7522c841a6b4054e2e387346973c597174ee87
2018-03-08Implement logic for blocking a number from the new call log's bottom sheet.linyuh
Bug: 70989547 Test: ShowBlockReportSpamDialogNotifierEndToEndTest PiperOrigin-RevId: 188351591 Change-Id: I634fb821592bdc890df291fdf83cdf307c94ffa9
2018-03-07Add additional logging to missed call notification code pathroldenburg
Bug: 73877234 Test: just logging PiperOrigin-RevId: 188256051 Change-Id: Ic9486b3fc1d97338cb016b86a243612baa6282fe
2018-03-06Updating voicemail_donation_promo_content per UXWmaxwelb
Bug: 73798533 Test: N/A PiperOrigin-RevId: 188046222 Change-Id: I1b66afa787bb5c91d71dbeda544218226ae8f5fd
2018-03-05Check if the activity is still alive before refreshing unread tab counts.calderwoodra
My hypothesis is that there is a race condition where the call log changes and we are leaving the activity before the content observer is unregistered or the loader it starts is finished. This results in a callback calling #fetchCalls while Dialer is in the background, resulting in a crash. This change will confirm my hypothesis. Even if my hypothesis is incorrect, we have similar checks throughout this class which indicates to me that some issue exists here and that this check is safe to do. Bug: 73972084 Test: n/a PiperOrigin-RevId: 187700318 Change-Id: I98cea86b5b7041c4f4aac09544445aaade6bfd40
2018-03-02Remove dialer sounds and vibrations settings fragments and redirect to the ↵uabdullah
system sound settings fragment instead. There is no need for dialer to have it's own sounds and vibrations fragment. Instead of maintaining two separate fragments that do that same thing (and have to be kept in sync), we can just have one source of truth and have users modify those settings. Thus we have removed the dialer and vibrations settings fragment and have it instead re-direct to the system sound settings. The automatic advantage of this is also that for dual sim cases, dialer settings don't need to be updated. Bug: 73750524 Test: Manual. Navigated to the dialer sound and settings fragment, and it opened the system settings. Also pressing back took us back to Dialer as expected. PiperOrigin-RevId: 187564461 Change-Id: I7d620721237f1c932ed8cea949486ae7dbdefba1
2018-03-01Instead of just cancelling loaders, reset them as well.calderwoodra
Bug: 71385186 Test: manual PiperOrigin-RevId: 187552834 Change-Id: If4e1f7c18d5f5aae2a152762189948c3543ba321
2018-03-01Disable phone number formatting for devices with Argentinian SIMs.linyuh
Bug: 73718977 Test: PhoneNumberHelperTest PiperOrigin-RevId: 187540382 Change-Id: I814ec62b2215c24b8cde3442c5dc83d98ad87164
2018-02-28Some small bug fixes in NUI.calderwoodra
- Never show the dialpad chooser in MainActivity. - If the call log changed while dialer was in the background, it would trigger the content observer to fetch the new info, which would request it's parent that wasn't there. Now we register/unregister them in onResume/onPause. This is safe to do because we force refresh the data onResume anyways, so any changes will still be shown. Bug: 73972084,73975555,73995512 Test: manual PiperOrigin-RevId: 187407058 Change-Id: Iae86dabbcb852398bb2b9df4627e234261ab8030
2018-02-28Add accessibility label for voicemail transcription ratingmaxwelb
Bug: 73788896 Test: Manual :/ PiperOrigin-RevId: 187401558 Change-Id: I1c2c08cc01fd38ad5820c454991473cfb8f0fc76
2018-02-28Update voicemail donations stringsmaxwelb
Bug: 73798533 Test: Manual :/ PiperOrigin-RevId: 187383740 Change-Id: I0f35ccbf19a59b35338cb144f0192b692585159f
2018-02-27Fab now hides/shows correctly when you enter and leave the voicemail tab.calderwoodra
Test: manual, going between tabs hides/shows the fab properly when ToS is (in)visible. PiperOrigin-RevId: 187253210 Change-Id: Ied9ea44892786268b9dfa68816840dfbfc74aa6e
2018-02-27NUI no longer crashes when clicking "place call" in empty call log.calderwoodra
Bug: 73258376 Test: MainActivityOldPeerCallLogIntegrationTest PiperOrigin-RevId: 187242222 Change-Id: Ic2684467035fedc1156886712757bf0911f65ee5
2018-02-27Move DirectoryCompat from "contacts/common" to "dialer/common/cp2".linyuh
Bug: 73887387 Test: Existing tests PiperOrigin-RevId: 187225355 Change-Id: I65de553078e147a46d933daf34dfd912fc8aa74c
2018-02-26Implement logic of bottom sheet options related to spam numbers.linyuh
Bug: 70989605 Test: ShowBlockReportSpamDialogNotifierEndToEndTest + Manual PiperOrigin-RevId: 187047450 Change-Id: I23c3929135bcfe5c14fe317ef65f628dc126027f
2018-02-24Cancel Old SpeedDial contact loaders when they are reset.calderwoodra
This prevents to many loaders running at the same time and crashing the application for using too many threads at once. Also made a few UI changes: - Change Android nav bar color to #FFF - Move badges down 2dp - Limit badges to 9+ (instead of 99+, added flag to configure this) - search bar no longer has rounded corners when expanded Bug: 72525324 Test: MainActivityOldPeerTest PiperOrigin-RevId: 186894920 Change-Id: I36fc5d8794440b707184d54de427db5910ec5b8e
2018-02-24Fixed a few bugs in NUI Main Activity.calderwoodra
- Normalized the search query returned from DialpadFragment - Dial button now updates when given a psuedo emergency number - 'Clear frequents' now displays and functions properly in the menu - Added simulator to the menu Bug: 72525324 Test: added tests for clear frequents (only prod feature). PiperOrigin-RevId: 186875815 Change-Id: I3bad3c71b355b987fc85777550bfa1de5028c3a4
2018-02-22Adding real url for voicemail donation promo learn-more linkmdooley
Bug: 73780549 Test: manual PiperOrigin-RevId: 186669251 Change-Id: I2b45caa7b0a0a20e2466f51b7d659ce61a4945cf
2018-02-22Removed item animator in Call Log RecyclerView.calderwoodra
Bug: 69965302 Test: TAP PiperOrigin-RevId: 186573663 Change-Id: I099f22b7a8df7018ec50e309b2ae37f3eedd76fd
2018-02-22Moved metrics related methods out of LoggingBindings.zachh
Test: existing PiperOrigin-RevId: 186413083 Change-Id: I96c88c46b0ecc01167b655fa30fc47aaa6a9e351
2018-02-22Record jank metrics in old and new call logs.zachh
Bug: 70989667 Test: unit PiperOrigin-RevId: 186410938 Change-Id: I0671ab0bbbe957b8f034c673e6309204284756d2
2018-02-22Adding information section to voicemail settingsmdooley
this cl moves the TextViewPreference from dialer to third_party so it can be shared (sorry i meant to make that a separate cl, but forgot to switch branches). and it uses the TextViewPreference to add some informational text to the voicemail settings. screen shot: https://drive.google.com/open?id=0B9o_KvtLkcuIbENkeHRCSTUyOVpkM0JEZ0liMHphMnVzVHlN mock: https://drive.google.com/file/d/1gKt72pY-igXfphpamf8CqZV8HEmnOexj/view Bug: 37340510 Test: manual test PiperOrigin-RevId: 186388299 Change-Id: I2c142f1214a9424bec0bc7f12d841f0eeaef96f1
2018-02-22Fix a few UI issues based around multiselect in new nav.calderwoodra
- No longer crashes when entering mw-mode while in multiselect - Configuration changes now properly restore bottom nav visibility - toolbar shadow is now only visible in search Bug: 72525324 Test: MainActivityOldPeerSearchIntegrationTest PiperOrigin-RevId: 186037379 Change-Id: I5fc00c8091e85fc67482b2131944fb776626d06f
2018-02-14Mark calls as read in new call log.zachh
Playing with the existing app, the missed call becomes unbolded when: 1) Expanding the row. The closest analog of this is in the new UI is opening the bottom sheet, I've done that. 2) Swiping away from the call history tab. This can't be done in NewCallLogFragment because it doesn't know if the user is selected a new tab or pressed Home. So, I implemented this in NewMainActivityPeer. 3) After viewing the call log for 3(ish) seconds and leaving the activity pressing Home/Back. This is best done in NewCallLogFragment#onResume since MainActivity doesn't always know when the fragment is being displayed (it could be done after the user comes back to the app after pressing Home for example). Note that the notification is also removed in all of these cases. Also note that dismissing the notification makes the call unbolded (but this case already appears to be handled via the system call log content observer). Also, as part of writing tests for this, I made TestCallLogProvider more realistic. Bug: 70989622 Test: manual PiperOrigin-RevId: 185457438 Change-Id: Ib360d3bc73083bd1a018ed98e2b7d9a69fb7fafb
2018-02-14Clicking on a missed call in the call log no longer crashes the app.calderwoodra
Bug: 72956783 Test: DialtactsActivityIntegrationTest PiperOrigin-RevId: 185404033 Change-Id: I486f7b1a6739bf49c6f19bba82227dd4d9794e1f
2018-02-06Adding voicemail donation promomdooley
This cl shows a voicemail donation promo the first time a user tries to rate a transcription. It also changes the good/bad rating links to thumbs up/down icons. The 'learn more' link still needs the real URL. screen shots: https://drive.google.com/open?id=0B9o_KvtLkcuIOERUNUJId3FVY3UzUS0wVUdQQVpCS1lmM3Nz https://drive.google.com/open?id=0B9o_KvtLkcuIWkNVMDV1VTJ4VUMtakVwSE1UTGdUWjljTUV3 https://drive.google.com/open?id=0B9o_KvtLkcuIeU1ndG1palRkTnNJQWVYLXgyMnd4TjBDOFI4 mocks: https://drive.google.com/file/d/1FIhXDkn3h3xI7liVdJEraq47MoKQM3hi/view https://drive.google.com/file/d/1uTm58QCvFOBycsGP21vgvEGTq_Imgkqi/view Bug: 37340510 Test: manual tests PiperOrigin-RevId: 184745497 Change-Id: I40fd1e211311c3127f215ede2e44b22f345dcf8b
2018-02-05Visual Voicemail notifications now go to MainActivity when enabled.calderwoodra
Bug: 72525615 Test: VisualVoicemailNotifierTest PiperOrigin-RevId: 184625656 Change-Id: I8a0b53e12ebe8382f5bc5febd7a6ec448a255f2f
2018-02-05Missed calls now go to MainActivity if you have the component enabled.calderwoodra
This CL has a few changes of varying relevance: Most Relevance: - MissedCallNotifications will open MainActivity if the component is enabled (Meaning the launcher is in their app drawer and the flag is flipped). - Implemented show tab intent (open MainActivity directly to a specific tab) - Tests Some Relevance: - Implemented checking for ACTION_DIAL intents (dialpad will open immediately) - Tests Not Relevant but nice QoL changes: - Added tests for missed calls being marked as read - Makes espresso tests more horizontal to reduce timeouts - Bug: 72525550,72525615 Test: implemented PiperOrigin-RevId: 184600627 Change-Id: If96a44ce252e97c022ebc1b58fa783b3326035e7
2018-02-02Implemented drag to remove in NUI with old favorites.calderwoodra
This change moves the remove button to overlap the search bar instead of reside underneath it since we no longer have top tabs. Bug: 72722364 Test: manual PiperOrigin-RevId: 184347110 Change-Id: I5bfa70fec9dd7ee6ee0b7270039931f9277291f4
2018-01-31Added old voicemail to NUI activity.calderwoodra
Bug: 72722364 Test: existing PiperOrigin-RevId: 184083186 Change-Id: Ia51a50b343f75eec74a02dc6b4383341f939793d
2018-01-31Implemented missed call/voicemail notifications in NUI.calderwoodra
This CL shows and updates the missed call/voicemail count in the bottom nav. It also clears the call log notifications when the user either leaves the call log fragment or closes the activity after 3 seconds of browsing the call log. Bug: 72525595 Test: tba PiperOrigin-RevId: 184071058 Change-Id: I540c9e3d815e022b5e311cb02a3995e241b8a984
2018-01-30Added old call log to NUI.calderwoodra
Bug: 72618828 Test: existing PiperOrigin-RevId: 183902491 Change-Id: I079aca188b52c29c12b3cae7e57bf71a4e883898
2018-01-30Add old speed dial fragment to NUI.calderwoodra
Bug: 72618868 Test: existing PiperOrigin-RevId: 183896896 Change-Id: I9b90aaa02e1c40f38fbbe636f4e51cfd01c570f6
2018-01-29Added a hack for NUI because of a dependency cycle.calderwoodra
In order for NUI to include the old fragments, it needs a dependency on dialer/app. In order for Dialtacts to show the NUI shortcut, it needs a dependency on dialer/main. This change removes the requirement for Dialtacts by copying some of the code from dialer/main into dialer/app. Bug: 72525324 Test: existing PiperOrigin-RevId: 183769521 Change-Id: I29d00f22efecee35ca25f0b4172413c370f2506b
2018-01-26Pressing dial with an empty dialpad now queries the last number in NUI.calderwoodra
Bug: 72526019 Test: manual PiperOrigin-RevId: 183425741 Change-Id: Ied1b369d00baefe02db04ade26bee9faac4f829c
2018-01-25Remove non call log dependencies on PhoneAccountUtiltwyen
Methods moved to TelecomUtils Test: Unit tests PiperOrigin-RevId: 183305626 Change-Id: Idd6604e58c06a36066bd49870849dd71747969c6
2018-01-22Move legacy voicemail/error to nui voicemail/listui/erroruabdullah
All packages relating to NUI voicemail should be under third_party/java_src/android_app/dialer/java/com/android/dialer/voicemail/listui. Since there is a chance that during NUI development the legacy third_party/java_src/android_app/dialer/java/com/android/dialer/app/voicemail/error might undergo changes, it makes sense to move this package to the nui, so that no changes in the legacy code are missed for nui. This refactoring would also allow us to ensure that the strings do not need to be translated and that most of the code can be re-used for nui by hooking up the fragment and adapter to voicemail/listui/error. Bug: 71700117 Test: Unit tests PiperOrigin-RevId: 182868896 Change-Id: I23329654df5ce2bf612101708ed001ca308ae1ac
2018-01-17Update "Call blocking" to "Blocked numbers"roldenburg
Bug: 27705124 Test: n/a PiperOrigin-RevId: 182275405 Change-Id: Ic70b34790956f2d3652a23800ba0f5e37cfefca8
2018-01-17Updated toolbar and dialpad interactions in NUI.calderwoodra
Toolbar, Dialpad, Bottom Nav, FAB and Search now all show and hide properly according to the state of the application. Follow up CLs will include: - saving/restoring state - sending query to search fragment to display results Bug: 181512198 Test: MainActivityIntegrationTest PiperOrigin-RevId: 182259200 Change-Id: I1309d8df2a5425bf051e52a459a1f78e1157fe08
2018-01-16Implement dialer command line interfacetwyen
This CL adds a generic interface to perform action and retrieve data in dialer. Test: Unit tests PiperOrigin-RevId: 182128015 Change-Id: Ib45ce9808bd4e0e4a9c9e05c0017e19c3213bb0d
2018-01-10Add events for displaying set up or invite buttonsroldenburg
Bug: 70034799 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 181515491 Change-Id: I62dc4d4d4ebb02e8e1e8dce6c6970bb7c8845952
2018-01-09Let RCS Video Share take over Duo as the active video tech for a callroldenburg
Bug: 67005309 Test: VideoTechManagerTest PiperOrigin-RevId: 181368613 Change-Id: I8a13bd04d3ac342a06febb7437a0e0dd3d25affd
2018-01-08Update strings for Duo "Set up" and "Invite" buttonsroldenburg
Bug: 70034799 Test: manual PiperOrigin-RevId: 181241050 Change-Id: Iddf5ef331741f8ab8500eeb3d5481598ef5caca4
2018-01-08Hide emergency calls in the call logmaxwelb
Bug: 38494024,66926712 Test: CallLogAdapterTest, manually checked UI PiperOrigin-RevId: 181238101 Change-Id: I1b718e30a4bc874e098e30a3aaae39bdd69d0c9a
2018-01-02Fix accessibility bugs with transcription rating UImdooley
Bug: 71504376 Test: manual using accessibility scanner PiperOrigin-RevId: 180597338 Change-Id: Ie672d3718fec369cfcdec0eef09fb203da8ea8b9
2018-01-02Add assisted dialing indicators to the old call log.erfanian
Modify the call log grouping strategy. The strategy is as follows: When comparing the current group to the next candidate to add to that group, if the assisted dialing feature tag differs between the two, create a new group. Thus, if a call has other features like wifi or hd, we ignore those features when making grouping decisions. Bug: 70506228 Test: unit tests PiperOrigin-RevId: 180592125 Change-Id: I73d130bd9eb23706a04cb02f5711200729d978b6
2017-12-28Allow language change to take effect in T9 search without relaunching Dialer.linyuh
Bug: 30215380,70633239,70856260 Test: Manual PiperOrigin-RevId: 180276925 Change-Id: Ia0a7c435e48303781917bf0cc2e69995ee652ad9
2017-12-27Remove field prefixes.linyuh
Test: Existing tests PiperOrigin-RevId: 180230450 Change-Id: I0b2589cfeeaef81e42a04efa48af24b4e4d0e95f
2017-12-27Fixing transcription branding UI bugmdooley
Needed to set the branding text (to an empty string) when the transcription rating text is visible, so that both aren't displayed at the same time. Bug: 71361435 Test: manual PiperOrigin-RevId: 180218087 Change-Id: I04e485727267c306c7eb8f3780424855aaddebe5
2017-12-22Automated rollback of changelist 179847039calderwoodra
Bug: 36841782 Test: tap PiperOrigin-RevId: 179873378 Change-Id: I5e579f11c9738a75f312be33de556fd2bb3dac42
2017-12-22Reorganize classes related to smart dial.linyuh
Bug: 30215380,70633239 Test: Existing tests PiperOrigin-RevId: 179868033 Change-Id: If8cdbdfafb3a66397623578131649cb8adc18733
2017-12-22Added context menu for favorite contacts in new speed dial.calderwoodra
Bug: 36841782 Test: n/a PiperOrigin-RevId: 179847039 Change-Id: I5006e074fff4041eef54c9b81280097ac30be5b3
2017-12-19Add flags for the Duo install, activate and invite buttonsroldenburg
Bug: 70034799 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179596742 Change-Id: Ic5616af0680e36786ae5261813eae71cf096b084
2017-12-19Support dual alphabets in smart dial.linyuh
Bug: 30215380,70633239 Test: CompositeSmartDialMapTest, LatinSmartDialMapTest, RussianSmartDialMapTest, SmartDialNameMatcherTest PiperOrigin-RevId: 179580982 Change-Id: I5e4c3e61f0dfdc6ca1e80a93bb985ffec08dd8b0
2017-12-19Ignore deleted voicemail for notificationtwyen
Some voicemail sources keep deleted voicemails in the database for a while. Before this CL if the voicemail is deleted through blocking it will still be returned with CallLogNotificationQueryHelper.getNewVoicemail(), and deleted again. The Deletion triggers a notification update, and the phone enters a loop. If there are other voicemails, the phone will alert every time. In this CL, deleted voicemails are no longer returned with the new voicemail query. Also if All voicemails already has a notification, the user will not be alerted. Bug: 70585368 Test: VisualVoicmailUpdateTaskTest, CallLogNotificationQueryHelperTest PiperOrigin-RevId: 179575512 Change-Id: I352bbf7d0a9d5e2132b5f968e5b5776c9fd518c6
2017-12-18Ensure we do not have a null data string before checking for Duoroldenburg
Bug: 70794242 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179480604 Change-Id: Ic53ca21fb7e81390f45b116677df689d3d8fdb67
2017-12-18Upgrade target SDK version to 27.linyuh
Test: None PiperOrigin-RevId: 179458302 Change-Id: Ic6bfd4abe4c7f51d395488863edc1515754f6b36
2017-12-15Hide "Invite" and "Set up" Duo buttons for spam and voicemail callsroldenburg
Bug: 70681464 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179224173 Change-Id: I7b70f478898fade5cc5a9bf50581d35f2ce2261f
2017-12-15Remove voicemail settings if missing permissiontwyen
Bug: 70282673 Test: DialerSettingsActivityTest PiperOrigin-RevId: 179124385 Change-Id: I9a7f8edc4ae8df44891f551a8aa561bd81922f66
2017-12-14Use Dagger to get Duo instance in CallLogListItemViewHolderroldenburg
Bug: 70402153 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179106427 Change-Id: I2c82e95022c461d251d3385841640bc31d8aa765
2017-12-14Add input dialog for simulator to use customized number.weijiaxu
Add dialog for user to input whatever numbers with whatever types they want. With this functionality, users can use simulator to test payphone number, private number and etc.. This is a part of feature request in b/70244000. Bug: 70244000 Test: On a local device. PiperOrigin-RevId: 179105057 Change-Id: Ibb386e209d0907d23773cd2c55939b500de4d8f6
2017-12-14Add impressions for Duo related events (install, activate and invite)roldenburg
Bug: 70034799 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179085188 Change-Id: I7546cf7e35bbdd3788b03d19627d9a04f612335f
2017-12-14Take into consideration special characters when we do contact match.linyuh
Bug: 30225112 Test: CallLogGroupBuilderTest, PhoneNumberHelperTest, CallerInfoTest, and Manual (see demo) PiperOrigin-RevId: 179080046 Change-Id: I8e451a6c197a6c3df4260e58d0276a5dc5b9515a
2017-12-13Take user to install Duo if they tap "Set up" without the app installedroldenburg
Bug: 70034799 Test: DuoImplTest, GoogleCallLogAdapterTest PiperOrigin-RevId: 178981398 Change-Id: Id524dfe61bf3a2358d863dd8d5f7c6c083b8063c
2017-12-13Add reloadReachabilities to Duo interfaceroldenburg
Bug: 70034799 Test: DuoImplTest, GoogleDialtactsActivityTest PiperOrigin-RevId: 178971440 Change-Id: Ib624bd340fbeac11474db198763ae77eddb03ae3
2017-12-12Cleanup. Changing voicemail_transcription_enabled to ↵mdooley
voicemail_transcription_available Follow the convention that features allowed by server configuration flags use the word 'available' and when a feature is allowed by the user via settings then use the word 'enabled' Bug: 37340510 Test: manual and updated unit tests PiperOrigin-RevId: 178831467 Change-Id: I5691fd7db45a70908d32cdac2b049fe76e6a0680
2017-12-12BEGIN_PUBLIClinyuh
Automated rollback of changelist 172683494 Bug: 30225112 Test: None PiperOrigin-RevId: 178807986 Change-Id: I45978ea4daab71985ac93c3c3a0439fdd8e873d5
2017-12-11Update Spam module to use Daggermaxwelb
Test: TAP PiperOrigin-RevId: 178650781 Change-Id: I299907ac43d48b984b092433c9b651aadb17c62a
2017-12-08Implemented adding a new favorites contact flow NUI.calderwoodra
This change consists of mainly 3 things: - Update contacts fragment to meet AddFavoriteActivity requirements - Implement AddFavoriteActivity - Passing the contact back to SpeedDialFragment Bug: 36841782 Test: SpeedDialIntegrationTest PiperOrigin-RevId: 178461265 Change-Id: Ib3a13eae311acf6ce10a94df4f2c95b9af120cff
2017-12-08Add "Set up" and "Invite" for video to call log entry actionsroldenburg
Bug: 70034799 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 178434462 Change-Id: I220cb74116aaa5dc3518de0dd20f2cdefda4049b
2017-12-07Ignore "new" voicemails that are too old for notificationstwyen
Bug: 68049435 Test: CallLogNotificationQueryHelperTest PiperOrigin-RevId: 178016400 Change-Id: I6ddbebc9edce6830966072d42cf05eb21f26c8ac
2017-12-07Refactor Assisted Dialing Settings into standalone activity.erfanian
This will enable easier porting back into the framework. Test: existing tests PiperOrigin-RevId: 177960274 Change-Id: I1aa18734758900a93b19f4bb87b7759f6f7ca370
2017-11-30Implemented new favorites list UI.calderwoodra
Bug: 36841782 Test: implemented PiperOrigin-RevId: 177516412 Change-Id: If9478ce22c10fd17e352d5fdcc2c0bef5e14a6d8
2017-11-30Action bar is no longer visible in dialpad search after configuartion change.calderwoodra
If a user, for example, opened dialpad search then entered multiwindow mode, the actionbar would be visible and search results maligned. This change corrects that by updating it's state once possible. Test: manual PiperOrigin-RevId: 177497979 Change-Id: I41d4910b5bb92e29623960e7d4741a9a961e5b9e
2017-11-30*** Reason for rollback ***roldenburg
Copybara is fixed for AOSP export Bug: 68665330 Test: rollback PiperOrigin-RevId: 177480870 Change-Id: I0ba38e213bb840436fa6dafc4af0a79019ee93f4
2017-11-28Adding transcription rating feedbackmdooley
Allow users who have agreed to donate their voicemails to also provide transcription quality feedback. screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuIajVtdFN3Y0Qydmx2NXJYN2N3OVA3N0h5UEdR Bug: 68712148 Test: manual and new unit tests PiperOrigin-RevId: 176774942 Change-Id: I08b9afbbefaedfb0de5199038a1d2769bd983855
2017-11-22Allow deleting a call log entry in the call log UI and the call details UI.linyuh
In the call log UI, an entry can be deleted by selecting "delete" in its context menu. In the call details UI, a "delete" button is added at the bottom. The "delete" icon at the top right of the call details UI is removed. Public-Origin-Change-Id: Iabe1310fb9a97a277cf482a3fd61ffccbec125fe Signed-off-by: Linyu He <linyuh@google.com> Author: Masafumi Miya <masafumi.miya@sony.com> Bug: 38188896 Test: CallLogActivityIntegrationTest, CallDetailsActivityIntegrationTest PiperOrigin-RevId: 176677167 Change-Id: I2e31cd112efdfb83393f5e68ce016dcf36ac4858
2017-11-21Reduced jank when placing a call from search UI.calderwoodra
I accidently made the search/dialtacts UI TOO performant and everything was happening too quickly. Postponed closing the dialpad and exiting search until onPause, but immediately close the keyboard so it isn't visible over the in call ui. Bug: 69313203,68857994 Test: see video PiperOrigin-RevId: 176531801 Change-Id: I52729c451d46ad00ac87c47f189134694554d33a
2017-11-20Fixing verizon TOS textmdooley
This was caused by cl/176065849 where we added a per carrier check to see if transcription is supported. new screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuINkJ0R0JPTUZWSlpDMmlaRFdEUnJkY3pyTmxR Bug: 67457582 Test: manual and updated unit test PiperOrigin-RevId: 176389716 Change-Id: Ib41607a0ec6e9b40092d32fe055db80b6f9f8301
2017-11-20Cancel missed calls in call history when needed.yueg
Including when: - onStop() - switching tabs Also move old CallLogActivityTest to espresso directory. Test: CallLogActivityTest PiperOrigin-RevId: 176387019 Change-Id: Icbb77747882c8a5e35595557baa6917a4dc674b6
2017-11-18Refactoring and adding TOS check before transcribingmdooley
This cl just adds a check before starting a transcription job to verify that the user has accepted the appropriate TOS. Its a rather big cl just because it had to expose some TOS acceptance details that were previously encapsulated in the VoicemailTosMessageCreator. Bug: 69267260 Test: manual and unit tests PiperOrigin-RevId: 176132370 Change-Id: Ic28fb197a07f9df7a9b5f1729c84566cba0890fc
2017-11-18Don't transcribe voicemail unless carrier allows OTT transcriptionmdooley
Added a carrier config and check to see if the carrier allows over the top voicemail transcription, and if not do not attempt transcription. Bug: 68951869 Test: manual and unit test PiperOrigin-RevId: 176065849 Change-Id: I69df1f2867420d7fdcc7f0a31e0e6c26da67abb1
2017-11-18Add preferred SIM meta-data to dialer manifesttwyen
Contacts need to check the meta-data to decide if the preferred SIM UI should be shown. Bug: 64213352 Test: N/A PiperOrigin-RevId: 175912590 Change-Id: Ic02ca47ab156c3bb752b33c97cfb3b62f45a3667
2017-11-18Keyboard now closes in regular search when user scrolls list.calderwoodra
This change also enables search actions to be visible in regular search. screenshot: http://screen/ULBgq2RnKnM Bug: 68730642,67657783,68775021,66723880 Test: manual PiperOrigin-RevId: 175892821 Change-Id: I2c71fe8ffa2ffddfbc88d777909c4837e0ea4384
2017-11-18Use phone account ID for legacy voicemail notification.twyen
This allows one notification per SIM to be shown on multi SIM devices Bug: 64010653 Test: LegacyVoicemailNotifierTest PiperOrigin-RevId: 175756590 Change-Id: I8c2fe3ec06c5e6868ddc647742ab9ef422494b3b
2017-11-17Fix bug that RTL posistion is not correct when initializing in CallLogActivity.wangqi
Bug: 69133607 Test: manual PiperOrigin-RevId: 175586518 Change-Id: I9c03da6f559e2943d30220aefc399ba2a7842f29
2017-11-11Fix bug that "+" is dropped when performing actions in smart dial search.wangqi
This is caused by normalizing numbers from dialpad search into search box, while "add new contacts" and "send sms" etc. wouldn't work properly without full number. This change also fix "send sms" in old search fragment. This change includes upstream change from: https://android-review.googlesource.com/#/c/platform/packages/apps/Dialer/+/530377/ Change address format when sending message from smart dial In Android O, send search key number as address to message app. In Android N, send real input number as address to message app. Fixed the issue by reverting to Android N implementation. Affected Area: Send SMS operation from Dialer smart dial search result list. Bug: 68962106 Test: manual PiperOrigin-RevId: 175317850 Change-Id: I96dd576144f93f7502977bfdb4b9e9d9c8f73526
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-15 06:00:18 +0000