Age | Commit message (Collapse) | Author |
|
Bug: 69133607
Test: manual
PiperOrigin-RevId: 175586518
Change-Id: I9c03da6f559e2943d30220aefc399ba2a7842f29
|
|
This is caused by normalizing numbers from dialpad search into search box, while "add new contacts" and "send sms" etc. wouldn't work properly without full number.
This change also fix "send sms" in old search fragment.
This change includes upstream change from:
https://android-review.googlesource.com/#/c/platform/packages/apps/Dialer/+/530377/
Change address format when sending message from smart dial
In Android O, send search key number as address to message app.
In Android N, send real input number as address to message app.
Fixed the issue by reverting to Android N implementation.
Affected Area:
Send SMS operation from Dialer smart dial search result list.
Bug: 68962106
Test: manual
PiperOrigin-RevId: 175317850
Change-Id: I96dd576144f93f7502977bfdb4b9e9d9c8f73526
|
|
Bug: 68840377
Test: manual verify no regression from inconsistently showing promo
PiperOrigin-RevId: 174957368
Change-Id: I0ed4fa1b24e693e91705744f60a7a385385cec64
|
|
This CL replaces all instance of CallIntentBuilder.build() with PreCall.getIntent(), which when run as an activity, will finish building the intent with user interaction.
Bug: 64216442
Test: manual
PiperOrigin-RevId: 174924323
Change-Id: If41868df4c7ed078d03bd3431fa85b8947056a01
|
|
Multi-SIM and several other new features requires additional user input (ie. select the phone account to call with) or processing (ie. rewrite phone number for assisted dialing) before the call is actually made. The plan is to use a chain of pre-call actions to complete the dialing infomation,with the CallIntentBuilder holding the intermediate steps. For example, a pre-call action can examine the CallIntentBuilder and figure that the PhoneAccountHandle cannot be inferred, and show a dialog for the user the select it. Only after pre-call actions are completed, the intent is built and sent to telecom.
Since pre-call actions involves dialogs and the process can be interrupted, the CallIntentBuilder must be persistable so the state can be restored. This CL made it parcelable so it can be stored with onSaveInstanceState().
The AssistedDialingMediator in CallIntentBuilder is temporarily removed as it would be called using a pre-call action in a future CL.
Bug: 64216442
Test: CallIntentBuilderTest
PiperOrigin-RevId: 174902775
Change-Id: Icf2f8fae620868d1a2f5acf0d08ae0a6bec4fb76
|
|
All voicemails are called by using CallIntentBuilder.forVoicemail() so the PhoneAccountHandle can be designated. A future CL will use dialogs to customize the call (multi SIM selection, RTT, etc.)
As a result voicemail error messages and legacy voicemail notifications will call the account it is received from directly.
Bug: 64216442
Test: Unit tests
PiperOrigin-RevId: 174784322
Change-Id: Ibe1c57bc7852e3d55a39a0cc2da19b6a79954c0f
|
|
Test: In dialer lab.
PiperOrigin-RevId: 174781953
Change-Id: I987c0d191a7c5613debb857bab9438d0c1aa20a7
|
|
The display name mixed with Hebrew and English is not displayed
correctly at call log, because the TextDirection of the display name
area is not set correctly. Fixed by correctly setting TextDirection.
Affected Area:
Direction of display name of call log list.
Bug: 68024853
Public-Origin-Change-Id: I3fb0e248d380d5431a8026b8491534b46911af99
Signed-off-by: Eric Erfanian <erfanian@google.com>
Author: yuichiro fujiwara <yuichiro.fujiwara@sony.com>
Test: manual
PiperOrigin-RevId: 174200487
Change-Id: Ib2d207ebb91a99662e4156f84c696caca82f877a
|
|
The voicemail module should not contain any UI code.
Bug: 37258159
Test: DialerSettingsActivityTest,VoicemailSettingsFragmentTest. A future CL is refactoring VoicemailChangePinActivity into a fragment.
PiperOrigin-RevId: 174125949
Change-Id: I89cf6a083b0a0952332440d76e7ae0cb1c801931
|
|
This change removes restriction of showing HD icon only for some Motorola
devices.
After this change, any devices writing
android.provider.CallLog.Calls.FEATURES_HD_CALL into call logs' feature will
be able to show HD icon.
To be able to write HD features into call logs, both CarrierConfigManager#KEY_DISPLAY_HD_AUDIO_PROPERTY_BOOL and CarrierConfigManager#KEY_IDENTIFY_HIGH_DEFINITION_CALLS_IN_CALL_LOG_BOOL must be enabled.
It's part of upstream change to enable HD icon in call logs:
https://android-review.googlesource.com/#/q/topic:hd_icon_call_log
Bug: 68108125
Test: none
PiperOrigin-RevId: 174091763
Change-Id: I17c62153ebbc866c91acdaa7a7fcbd124594772b
|
|
Test: Run in dialer lab
PiperOrigin-RevId: 174075702
Change-Id: Ib663dc34d2c0c9e737c6d5f13b16d2b42b714127
|
|
We now use dagger everywhere for consistency and explicitness.
Test: tap
PiperOrigin-RevId: 174071122
Change-Id: I15d2f8261a7b753353be9e7d3b80692aa0c1b64d
|
|
app open
With this change we now only load the Favorites and Call Log Fragments when the
app opens.
Paging to the CallLogFragment makes the ContactsFragment load as we would want.
This should result in a faster app start time. I'll need to verify the impact
of this using the same method as http://cl/170422671
I verified the change in behavior by adding my own log line to the onCreate of each Fragment. I saw all of them get created before the change, and only the expected 2 with this change.
This change also fixes flaky test of voicemailTabVisibleNotVisible_volumeStreamCorrect.
Bug: 64541209,65460373,67297718
Test: DialtactsActivityIntegrationTest
PiperOrigin-RevId: 173734472
Change-Id: Ifd4a3064a6fdcffe5a373eaad6ee4aeebdadda1e
|
|
DialerUtils#getDefaultSharedPreferenceForDeviceProtectedStorageContext(Context) to StorageComponent.
Bug: 30224215
Test: none
PiperOrigin-RevId: 173612463
Change-Id: Ia89d5d85c31ea2114b196393ae43b803023fc9bf
|
|
Moved SearchContactViewHolder listener logic from SearchAdapter
to SearchFragment to make it easier to close search after placing a call.
Bug: 68201142
Test: existing + DialtactsActivityTest
PiperOrigin-RevId: 173454972
Change-Id: Ib5715d0f427d62344641b4bf841d34145fc3f65e
|
|
Follow repro steps to see contacts promo always consistently shown
Bug: 68158965
Test: manual
PiperOrigin-RevId: 173427472
Change-Id: I3717ee674aa81d1f1c563920796ef0f21dcdd963
|
|
By always creating executor services via dagger, we can now bind special versions during espresso tests that can implement idling resources. We should be using idling resources during espresso tests for threads that we create ourselves, because espresso does not know about them.
Hopefully this reduces some of the flakiness of espresso tests that we have today.
This required converting all existing calls to DialerExecutors to pass a context used to fetch the component, and also required creating new application classes for espresso tests.
Test: temporarily added a task which just slept to DialtactsActivity and verified that its integration test failed due to idling resource timeout
PiperOrigin-RevId: 173334773
Change-Id: I876a93022d235d62cfc377bf5b06687e21a34758
|
|
It fixes AOSP for package name conflict.
Test: manual
PiperOrigin-RevId: 173298696
Change-Id: Id10ebe0bcf029e61f65cf6580c7198abd8395081
|
|
*** Reason for rollback ***
Causes crashes on rotation: http://b/67839843
*** Original change description ***
Do not load every DialtactsActivity fragment on app open
With this change we now only load the Favorites and Call Log Fragments when the
app opens.
Paging to the CallLogFragment makes the ContactsFragment load as we would want.
This should result in a faster app start time. I'll need to verify the impact
of this using the same method as http://cl/170422671
I verified the change in behavior by adding my own log line to the onCreate of each Fragment. I saw all of them get created before the ch...
***
Bug: 64541209,65460373
Test: Manually verified regression fixed
PiperOrigin-RevId: 172684553
Change-Id: I9a5b30d6619d930adfb82b19ac3ff9da00decaaa
|
|
call log UI.
Currently we use PhoneNumberUtils#compare(String, String) to determine whether two numbers in the call log should be grouped. The method ignores special dialable characters such as "#", "*", "+", etc, which can cause phone numbers and service dialing numbers to be grouped.
For example, suppose the user has a contact named "John Smith" with number 123456789 and a contact named "Service" with number #123456789, and called each contact once. The old grouping logic will put the two numbers in the same group.
The new grouping logic in this CL can separate the two numbers.
Bug: 30225112
Test: CallLogGroupBuilderTest, PhoneNumberHelperTest
PiperOrigin-RevId: 172683494
Change-Id: Ie9e7b7418d6d7c74830cbae09c04ff1feb1b827d
|
|
Bug: 67322107
Test: manual
PiperOrigin-RevId: 172656296
Change-Id: Ia8b7d508ef35ff0091b762c28e1091af60ce15b4
|
|
Bulk insert is implemented in ag/3073902
When more than one voicemail is inserted into the VoicemailProvider, the URI type is Voicemails.DIR_TYPE instead of ITEM_TYPE. This CL adds support to the new type.
Previously when multiple voicemails are being notified, each one of them will generate a ringtone because the notifiction is set to alert children. In this CL, the summary will have alert instead, and will only alert when new voicemails are received.
Bug: 21281858
Test: VisualVoicemailNotifierTest
PiperOrigin-RevId: 172546076
Change-Id: I4df6098fc3a793139e3d4e77fe1339efdc001944
|
|
Bug: 67430264
Test: manual
PiperOrigin-RevId: 172520128
Change-Id: I061e3b45599e1c14be387713e63f6fdeae367be4
|
|
Bug: 67820772
Test: DialtactsActivityIntegrationTest
PiperOrigin-RevId: 172519580
Change-Id: I31983153cedb24c436cbaeef69fe6a2f4e558c65
|
|
Bug: 63994464
Test: integration test
PiperOrigin-RevId: 172499750
Change-Id: I7a7c23b403f649c1bbec0bb068e1285e02fddd22
|
|
Fixed notifying for Duo missed calls using the new constants to check if a call is a Duo call.
Bug: 66946794
Test: existing tests, manual
PiperOrigin-RevId: 172400311
Change-Id: I84ec0ac5c933cf1aec68b6d1f422c2effe6b69ec
|
|
Promo was being collapsed because rotate causes list to be scrolled at IDLE state. Make the drag more explicit by including the fastScroller drag state instead
manually verified fast scrolling still minimizes promo and rotating while promo is expanded keeps it expanded
Bug: 67670326
Test: ContactsPromoFragmentTest
PiperOrigin-RevId: 172352966
Change-Id: Iab5438501db1d54b7ffac3339faecde0256a3632
|
|
Now that our Duo integration is public, we no longer need a code name.
To avoid any disruption, logging and config related names were not changed.
Bug: 63753964
Test: manual, existing tests
PiperOrigin-RevId: 172172738
Change-Id: Ib9d3d80761944d850c8c4886def9fef9a28539a4
|
|
There was a race where the dialog could sometimes get detached before the success callback finished. The callback would attempt to show a snackbar using [fragment.]getString(), which throws when the fragment is detached.
The fix is to just use the activity to get the string (which has already been asserted to be valid).
Bug: 65968151
Test: unit
PiperOrigin-RevId: 172169503
Change-Id: If86250b14038958e6668b26d1f150619fe3eefae
|
|
- Dialpad now hides if user tries to scroll w/ a search query.
- Search now closes if the user touches the blank area w/o a search query.
- Since we don't even show location results in dialpad search,
we no longer request location permission in it.
Bug: 67657783,67656915
Test: tba
PiperOrigin-RevId: 172162620
Change-Id: I33a814797a053600e56fb163fd55b0c43e00a9c6
|
|
With this change we now only load the Favorites and Call Log Fragments when the
app opens.
Paging to the CallLogFragment makes the ContactsFragment load as we would want.
This should result in a faster app start time. I'll need to verify the impact
of this using the same method as http://cl/170422671
I verified the change in behavior by adding my own log line to the onCreate of each Fragment. I saw all of them get created before the change, and only the expected 2 with this change.
Bug: 64541209,65460373
Test: manual
PiperOrigin-RevId: 172154863
Change-Id: Iaf6e217df284e6df6f13688ac6aa677481a575e0
|
|
Added a check for null notification tags when updating voicemail notifications.
Bug: 67607115
Test: manual and unit test
PiperOrigin-RevId: 172121860
Change-Id: If9fd6ca972a5a1dbd48a9c529f3cb46c3c93fa2a
|
|
video call.
Bug: 67717800
Test: GoogleCallLogAdapterTest
PiperOrigin-RevId: 172013208
Change-Id: I86c4ca1ef7caf1899cb9587d98233a9e707b7f3d
|
|
Bug: 66946794
Test: MissedCallNotifierTest
PiperOrigin-RevId: 172007792
Change-Id: I14a2c0b6a5ad5a5b8acd449214c91bff68282b6a
|
|
Bug: 66633426
Test: LegacyVoicemailNotificationReceiverTest
PiperOrigin-RevId: 172007744
Change-Id: Ic67566c22659b51d605c92d2673f9baddaee531f
|
|
video: https://drive.google.com/open?id=0B2Hce9qilHmvZkREWm1BMURJNjQ
Bug: 67635181
Test: n/a
PiperOrigin-RevId: 171928416
Change-Id: Id0ef91647ec15ea970a691b1ae896010a12e6bb8
|
|
Previously before showing a voicemail notification dialer checks if the count has changed to avoid showing duplicated notifications. With the dismissed flag in place the count changed check is redundant, and it prevents the notification to reshow after reboot.
Also updated the EXTRA_IS_REFRESH to use the O_MR public version.
Bug: 66633426
Test: LegacyVoicemailNotificationReceiverTest
PiperOrigin-RevId: 171760393
Change-Id: I508b8f42a44fd849ab7c8ca6fe9d4e7e8a38b1c7
|
|
Also added ability to click on row to call.
Required plumbing through the original phone number and phone account info through AnnotatedCallLog and CoalescedAnnotatedCallLog, so that clicking to dial doesn't require an additional lookup.
Required some refactoring:
-created autovalue for CoalescedRow.
-created autovalue for ContactPrimaryActionInfo and use it in ContactActionBottomSheet
-moved logic for building primary and secondary text into CallLogUtils so it can be shared between call log list and bottom sheets
-moved clipboard logic to own package for copying numbers
Bug: 34672501
Test: unit
PiperOrigin-RevId: 171760252
Change-Id: I645d89974460b611c1d9668c3ca3e50a716c7f8f
|
|
screenshot:
https://drive.google.com/open?id=0B9o_KvtLkcuIdVZ2dE44MzNUZ2pkdUY5ZVdycHp0R1ZsLUtZ
Bug: 67634990
Test: manual
PiperOrigin-RevId: 171757382
Change-Id: If11b88a0682e5da9454238fa19fb78972115fb23
|
|
If a PhoneAccount declared it is CAPABILITY_SELF_MANAGED, it should handle the in call UI and notifications itself, but might still write to call log with EXTRA_LOG_SELF_MANAGED_CALLS}.
Bug: 66946794
Test: MissedCallNotifierTest
PiperOrigin-RevId: 171727177
Change-Id: I34444857d432d6bb72983c0ba919bcfef885192b
|
|
cl/170943038 groups calls in the call log according to their corresponding actions (Lightbringer, IMS, and voice). This way calls in the call detail UI are in the same category and an appropriate icon can be set.
Bug: 66026167
Test: CallDetailsActivityTest.callbackButtonLoggedForLightbringerCall, CallDetailsActivityTest.callbackButtonLoggedForVideoCall, CallDetailsActivityTest.callbackButtonLoggedForVoiceCall
PiperOrigin-RevId: 171703514
Change-Id: I534e1d22f1355f261105a6bde74285403fc9ed87
|
|
supported.
Test: manual
PiperOrigin-RevId: 171610298
Change-Id: I12ca284927603804b8761db695d35a1c79fa93f3
|
|
One of the biggest issues with the FAB is that it doesn't
scale in/out properly. It looked more like setVisibility was
being called instead. This CL migrates the FAB controller to
use the built in scale in/out methods #show and #hide and the
animation is much nicer.
Some of the other issues were:
- Now scaling animation is correct and visible.
- No longer flashes when going in/out of search.
- No longer shows on top of the return to call controller.
- No longer bugs when switching between VVM TOS and contacts.
- No longer shows FAB over VVM TOS when entering/exiting search
Bug: 62588192,35359563,64116334,27458212,37991480,67419607
Test: manual
PiperOrigin-RevId: 171608105
Change-Id: I9b3f61df35abf3659a432adf411b1b7d20eba683
|
|
Currently different types of calls can be grouped together (e.g., 1 voice call and 1 IMS call to/from the same number), which makes it difficult to choose the icon for the call detail UI's call back button.
This CL adds an extra constraint that separates different call types (Lightbringer, IMS, and voice). This way calls in the call detail UI are in the same category and an appropriate icon can be set.
Bug: 66026167
Test: CallLogGroupBuilderTest.addGroups_MixedEntries_PartiallyGroupedByAction
PiperOrigin-RevId: 171602617
Change-Id: Id8170206009ba836a40c38a86914c71d5c7701dc
|
|
* Add missing assisted dialing to calls from contacts in the call log.
* Add missing assisted dialing to calls from dialpad and normal search.
Bug: 63995025,63995261
Test: unit test
PiperOrigin-RevId: 171593967
Change-Id: I4e63ef1dcd7ee1b2b5cbb8ecb4d8da744d90bd66
|
|
QA noticed that the error message 'Transcription not available. Unsupported language'
didnt fit on one line and got truncated. This cl removes the single line constraint
for that text field.
Bug: 67384287
Test: manual
PiperOrigin-RevId: 171316291
Change-Id: I41f98fe207ebeca900bf4fd51cd4e95e20981a9a
|
|
As per the material desing spec [1], floating action buttons should be 56dp
in size normally and 40dp on small displays (like in multiwindow mode) while
always maintaing a 24dp image size.
screenshot (mw): http://screen/URJrg1WoQfn
screenshot (normal): http://screen/TUU65D1sSHp
[1]
https://material.io/guidelines/components/buttons-floating-action-button.html#buttons-floating-action-button-floating-action-button
Bug: 67312080
Test: n/a
PiperOrigin-RevId: 171086404
Change-Id: Ib213cf3c94dbb0f0df5b21f23f3022a8f53d80a8
|
|
Bug: 65559651
Test: MissedCallNotifierTest
PiperOrigin-RevId: 171070314
Change-Id: I57e6e0b55a07430daad944473ae4eb427d56ee96
|
|
and using non-breaking space in dialer TOS 'learn more' link.
screen shots:
https://drive.google.com/open?id=0B9o_KvtLkcuIV3BWWmxSTTlJQ2dBTnR2UHRGWjZJRlFQUGo0
https://drive.google.com/open?id=0B9o_KvtLkcuIOEJjanVhMXlfck81aU02Y0I2MkVtWFNOVGp3
Bug: 67379747
Test: manual and updated unit tests
PiperOrigin-RevId: 171025914
Change-Id: I9c4bfd899805681492a5063ee1bc674bbb98f630
|
|
Project Fi devices crash when declining voicemail TOS because
of an invalid PhoneAccountHandle. This cl fixes the problem by
not showing the TOS when the PhoneAccountHandle is not valid.
Bug: 67001886,66969838
Test: manual and updated unit tests
PiperOrigin-RevId: 170418189
Change-Id: I36dd0b10ab7468b0937a81f3f0427a4d64091955
|
|
Previously post call notifications are inserted by launching CallLogNotificationService. This usually works because the call has just broght dialer to the foreground and there are some grace period before the app is consider background again. However if the post call message comes later background check will crash the app.
This CL made the broadcast receiver async and complete the insertion in a worker since it wouldn't take more than a few seconds.
Bug: 66444859
Test: unit tests
PiperOrigin-RevId: 170275928
Change-Id: I0ff396b51a173f2e4bab0bca6b6e5c5b56ab62da
|
|
screenshot:
https://drive.google.com/open?id=0B9o_KvtLkcuIdGY1RnVXM3JuMXB4OVRVOFhrSU9qRDR6c2pj
Bug: 37340510
Test: manual
PiperOrigin-RevId: 170131627
Change-Id: Ib022bba44e24675082299132a5965fbcb58257fa
|
|
On M the framework does not retain the hidden state of a fragment properly when restoring it from a savedInstanceState. This appears to be fixed in N, but the exact cause and fix are unknown. This behavior will cause a fragment previously hidden coming back as visible when the device is rotated or going through any save/restore life cycle.
Previously whether to show the dialpad is stored in a separate flag, and the dialpad will be hidden when it is reattached. This was regresed in cl/169614750
In this CL, if the saved mIsDialpadShown indicate the dialpad should not be shown, but the dialpad is not hidden, it will be hidden on resume.
Bug: 66893723
Test: DialtactsActivityTest
PiperOrigin-RevId: 170124711
Change-Id: I6f8ed21fb970d6f688cb75f854442115a6803f3c
|
|
These are old code and considered to be grandfathered in.
Cleaned up some warnings in GoogleLocationSettingHelper.
Bug: 66498656
Test: none
PiperOrigin-RevId: 170090310
Change-Id: I2c43564af751eb5f431a395d75afa5ce126b5d18
|
|
after rotation
mCurrentPage is set onResume before the fragment is attached. In this CL, mCurrentPage is still used for page change, but for resume and pause, it is detected directly in CallLogFragment using getUserVisibleHint()
Bug: 65161134
Test: manual - change call volume after rotation, check ToS FAB not visible after rotation. CallLogFragment is not testable.
PiperOrigin-RevId: 169984576
Change-Id: I870cbe3b83e38ac2cb505193309ab4f8e75a859f
|
|
The about in settings is removed in google dialer, it is accessed through the dialtacts overflow "Help & feedback" instead:
https://screenshot.googleplex.com/9L1kdQz6c2B
https://screenshot.googleplex.com/FqqdG6X9JTR
Note that help articles has not been migrated at this moment.
Features in the original about is placed in the overflow
https://screenshot.googleplex.com/OmCVPqwGBM9
Version info is stock google help
https://screenshot.googleplex.com/EdveVnXUSML
Privacy policy/Terms of service opens the browser to the link we had before
Open source license opens the same license activity in about.
Bug: 34872689
Test: manual
PiperOrigin-RevId: 169953610
Change-Id: Ib1c25ddecbf28293b447112cb280a8f9788692d3
|
|
Change verizon's ToS title to use the string 'visual voicemail'
This change seems a bit strange since the verizon legal text uses the string 'Visual Voice Mail', but the title uses 'visual voice mail'
screen shots:
https://drive.google.com/open?id=0B9o_KvtLkcuIR1lmaUF4OXk1SnFLdS1fbFpfMlFieWlTQ25v
https://drive.google.com/open?id=0B9o_KvtLkcuIRURWd0hhYjc4NUdKQ1hzM2RIcG5fSmlHcGhJ
Bug: 37340510
Test: update unit tests
PiperOrigin-RevId: 169933539
Change-Id: Idba526293604b7a27083a91b86825ef66ce23bcd
|
|
The problem was that the same notification id was being used by
both VisualVoicemailNotifier and MissedCallNotifier, causing the
voicemail notification update code to filter out missed call notifications
instead of ignoring them.
Bug: 66168999
Test: manual and verified existing unit tests pass
PiperOrigin-RevId: 169925851
Change-Id: Ifa69506a250557dd7bba631122fdd6d0744d6341
|
|
We think it's viewed by user if it's showing and user scrolls on call log tab,
since action in the same tab that moves the dialog is a strong proof.
Test: GoogleCallLogAdapterTest
PiperOrigin-RevId: 169763132
Change-Id: Ie520c65627b1e5d364860507321fb268c89e0cf7
|
|
video call upgrade and calling from call log is logged
Bug: 66222115
Test: DialerCallTest, GoogleCallLogAdapterTest
PiperOrigin-RevId: 169703001
Change-Id: Ib4dc3507dec09f49d41cec09d32cc9800477ee8b
|
|
Also fixes an issue where if the promo is shown after the dialpad or search UI is brought up then the promo will be added to the bottom of those UIs.
Bug: 64491095
Test: manual
PiperOrigin-RevId: 169700496
Change-Id: I76a1aa977df623964b843d8e4b20146ba7c2f874
|
|
To repro the bug:
1) Turn on "Don't keep activities" option in developer options
2) Open dialpad
3) Press home
4) Launch dialer from home screen
5) Observe blank screen
Bug: 65458054,64129606
Test: unit
PiperOrigin-RevId: 169614750
Change-Id: I65e53add0f1f53c510c402f4f8b7ed60dcef273b
|
|
1. Use existing country iso info instead of guessing current country iso from sim and locale for blocked number.
2. Use country iso of current sim instead of default sim for incall location info. This fixes bug in multi sim device when default sim is out of service and making call with the other sim.
Bug: 65399976
Test: manual
PiperOrigin-RevId: 169554641
Change-Id: I416d7e2d6bc3c872bfec3eda4005a5a1684f0e40
|
|
Illustration icon TBD
https://photos.app.goo.gl/ZDLNLlXg9VBKNHGx1
Manual testing of duplicates promo end to end flow accept/dismiss states
Bug: 64491095
Test: http://sponge/db7bd5c3-ec97-46c8-a058-ed7f46a5e4ce
PiperOrigin-RevId: 169480950
Change-Id: Ia553e87ce72d84a001769851abb925da1ab31756
|
|
Test: TH
Change-Id: I48e807f3eafbc82401b2674a2610b20bf118c275
|
|
Also repostion contact icon (for allen, is there a bug for that?)
Originally i tried wrapping the transcription in a ScrollView,
but that didn't really work since there's no easy way to set
a max-height for it. Since most voicemails transcriptions are
not that long, an easier solution was just to not limit the number
of lines for the transcription.
screen shots:
https://drive.google.com/open?id=0B9o_KvtLkcuINkdXeVV0U0dOZVNfdExzSDNsai1Ld2F3ZlBN
https://drive.google.com/open?id=0B9o_KvtLkcuIZTZFQzRQaW1nblBPN2JkVW1hMkR3YWl1b2JV
Bug: 64211399
Test: manual
PiperOrigin-RevId: 169425482
Change-Id: I63c9165f48d902c06e288280116cd9b95d67852c
|
|
When a user dials a number with post dial digits, they are now
carried to contact details and used when they redial that number.
Additionally, when a user clicks on a photo in call details, they will
be taken to Bugle now. This behavior already exists with messages in CD.
Bug: 62236726,62230491
Test: CDEVHT
PiperOrigin-RevId: 169422921
Change-Id: I1507cb64876540cfc9a683a5a1ea01910443f77b
|
|
This CL partially revert cl/159492498, since data SMS cannot be properly processed under FBE and visual voicemail notification won't be received.
Bug: 65555345
Test: LegacyVoicemailNotificationReceiverTest
PiperOrigin-RevId: 169321096
Change-Id: I7134d80479efef67de8d5d44131eea30f82297a0
|
|
The problem was that the query for looking up a voicemail by URI was broken
which was causing the notifications to be cancelled then when they were supposed
to be updated they were actually getting re-added thus causing the notification
sound.
Bug: 65692173
Test: manual and unit test
PiperOrigin-RevId: 169304391
Change-Id: I1e8f648231b6f0ab984a5b0e4facd8351b01391a
|
|
Bug: 65648343
Test: updated unit tests (already submitted in previous cl)
PiperOrigin-RevId: 169280819
Change-Id: I5950087765ffd038c31b872c6468951472980407
|
|
Zero suggest in dialpad search clutters the UI and we shouldn't show and search
results until the user has input something into the dialpad.
Additionally, this change ensures the fab stays hidden through device rotation
in regular search.
Bug: 65858825
Test: implemented
PiperOrigin-RevId: 169270161
Change-Id: Ia08ce56ffd02f74ea9e4d9d8a1efc3726fcc66d9
|
|
Bug: 65687672
Test: existing
PiperOrigin-RevId: 168951800
Change-Id: Ie840acd608424551198ba3440d6060a7cd7a629f
|
|
Also replace deprecate android:singleLine=true with android:maxLines=1
video: https://drive.google.com/open?id=0B9o_KvtLkcuIWGVBOElWdFNKa1E
Bug: 65678844
Test: manual
PiperOrigin-RevId: 168858718
Change-Id: I8be70e8496a8f0c562ca09eb315bb4e28b3e9c00
|
|
verizon TOS screen shot 1: https://drive.google.com/open?id=0B9o_KvtLkcuIU3VpLUpqcXBUYy1QY19UUk81a29sdGQyNEZZ
verizon TOS screen shot 2: https://drive.google.com/open?id=0B9o_KvtLkcuIN3R6SUFjS3RVTWhZQUM1UzhoajhNUF9ZbzJJ
non-verizon TOS screen shot: https://drive.google.com/open?id=0B9o_KvtLkcuIeVFYaWhYZmRzYVctU2F6N1VqazcycGpmNmRZ
Bug: 37340510
Test: manual and update unit test
PiperOrigin-RevId: 168851805
Change-Id: I7be27360093cae315b7249152e10d1beae5c5966
|
|
Bug: 65212837
Test: DialpadFragmentTest
PiperOrigin-RevId: 168745371
Change-Id: I62da45cdac58e3387343589b952e5d6bce7a4ee2
|
|
Bug: 64399026
Test: None.
PiperOrigin-RevId: 168456040
Change-Id: I65fdae8dff1c9bb8e05e79f3ece2480b92f08c69
|
|
If it's a swipe, onPageScrolled() is called several times before onPageScrollStateChanged(SCROLL_STATE_SETTLING) and onPageSelected().
If it's a click, only onPageScrollStateChanged(SCROLL_STATE_SETTLING) is called before onPageSelected().
And onPageScrollStateChanged(SCROLL_STATE_SETTLING) will not be called if user don't switch to a new tab.
We use the difference to tell if user switching tabs by swiping or clicking.
Test: DialtactsActivityTest
PiperOrigin-RevId: 168403148
Change-Id: Iaaf84ab9c4955d0bc2c1e9857ba59fd37b3984af
|
|
When opening a voicemail setting from Dialer with
ACTION_CONFIGURE_VOICEMAIL, no subId is passed.
So on a multi-SIM device, it is always configuration on the default
phone regardless of SIM.
To solve this, set the PhoneAccountHandle to intent extra for
ACTION_CONFIGURE_VOICEMAIL. In the advanced settings, obtains subId
from the PhoneAccountHandle.
Test: manual - Checked that correct PhoneAccountHandle will be passed
with ACTION_CONFIGURE_VOICEMAIL intent
Bug: 65001008
Author: xuegang.x.liu <xuegang.x.liu@sony.com>
Bug: 65001008
Test: manual - Checked that correct PhoneAccountHandle will be passed
PiperOrigin-RevId: 168019873
Change-Id: I8578dd2c4ac24e4af121a90b2b175baae2832461
|
|
Improved behavior of back button in search ui.
Pressing the back button in the search UI now functions as follows:
- If the keyboard is opened, the keyboard is minimized
- If the dialpad is opened, the dialpad is closed
- If the keyboard and dialpad is closed, the search ui is closed
Our existing behavior was dependent on whether a query had been built yet.
basically, if the user pressed back with no query selected, the search ui
was closed.
From the bugbash:
7. No scroll bar in the search results if the results do not fill the entire
view. The keyboard overlaps the results and there is no way to get to the
enter list without dismissing the keyboard.
10. Dismiss the keyboard on tapping the down arrow on the keyboard. Arrow
points down but works like back button
Bug: 62685859,63691995,63939331,64137632,64902476
Test: manual
PiperOrigin-RevId: 168004913
Change-Id: Ia566fce6d90454a3eae6ecccfa81ce7e909e878f
|
|
This is mostly just a revived version of cl/158901400. It adds a job service that is triggered by changes to the voicemail database. The job updates voicemail notifications,
as necessary.
video of notification update:
https://drive.google.com/open?id=0B9o_KvtLkcuId1ptNk1EbGotWFU
Bug: 37340510,27535759
Test: manual and unit test
PiperOrigin-RevId: 167934550
Change-Id: I36f03c0769645f7a0cb478172171f1079eca2108
|
|
Changing voicemail notifications to match the latest mocks,
(replacing the 'Voicemail' title with what was the notification
content, and putting the voicemail status or transcription in
the notification content). The notifications will be updated in
a following cl.
screen shot: https://drive.google.com/open?id=0B9o_KvtLkcuIbDdjaTNHTFFZLW9YZEo1SG5scDR6SzloaWc4
Bug: 37340510
Test: manual
PiperOrigin-RevId: 167928866
Change-Id: I81492f7fbf1cc398401a948e036854d6a8ff878b
|
|
*** Reason for rollback ***
Turns out blocked number activity is actually used for devices on M.
*** Original change description ***
Removes the unused dialer/app/filterednumber package.
***
Test: n/a
PiperOrigin-RevId: 167663280
Change-Id: I6af1fc7d6eb61f946d4fba255fe7374bcdee0e72
|
|
*** Reason for rollback ***
Based off a CL that needs to be rolled back.
*** Original change description ***
Improved behavior of back button in search ui.
Pressing the back button in the search UI now functions as follows:
- If the keyboard is opened, the keyboard is minimized
- If the dialpad is opened, the dialpad is closed
- If the keyboard and dialpad is closed, the search ui is closed
Our existing behavior was dependent on whether a query had been built yet.
basically, if the user pressed back with no query selected, the search ui
was closed.
From the bugbash:
7. No scroll bar in the search...
***
Bug: 64902476,64137632,62685859,63691995,63939331
Test: n/a
PiperOrigin-RevId: 167661409
Change-Id: I0627d54af33fb55c64b5edcd459dde6a73d93266
|
|
-add branding 'Google is transcribing'
-add branding 'Transcribed by Google'
in-progress screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuIdVVTX3BBZkNzV180alZPQ3EtR3gzRFNoamhV
transcribed by screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuISUdaRjBlUFpjYTBWWTg1STVHS0oyQmNiSUVR
Bug: 37340510
Test: manual
PiperOrigin-RevId: 167620447
Change-Id: I5526bebb6999cf77b0902ae50ca72e380538a6e7
|
|
When the call log is restored by the system, all items are marked as new even though they could already been read. This causes a torrent of "missed" calls after restoring call log with the setup wizard.
This CL ignore read entities in the query.
Bug: 62871863
Test: CallLogNotificationQueryHelperTest
PiperOrigin-RevId: 167602820
Change-Id: Iba5609ace895a309685bfcd61eae85e080562ec5
|
|
Users can now create new contacts, add to existing contacts, send sms and make
ViLTE calls from dialpad search results.
screenshot: http://screen/7iR038nUvmh
from the bugbash:
11. Missing “Create new contact” “Add to a contact” “Send SMS” from search results with a phone number search
Bug: 64902476
Test: many
PiperOrigin-RevId: 167362073
Change-Id: I2f94d863035c119ec526e02e088992c618a858a9
|
|
Pressing the back button in the search UI now functions as follows:
- If the keyboard is opened, the keyboard is minimized
- If the dialpad is opened, the dialpad is closed
- If the keyboard and dialpad is closed, the search ui is closed
Our existing behavior was dependent on whether a query had been built yet.
basically, if the user pressed back with no query selected, the search ui
was closed.
From the bugbash:
7. No scroll bar in the search results if the results do not fill the entire
view. The keyboard overlaps the results and there is no way to get to the
enter list without dismissing the keyboard.
10. Dismiss the keyboard on tapping the down arrow on the keyboard. Arrow
points down but works like back button
Bug: 64902476,64137632,62685859,63691995,63939331
Test: manual
PiperOrigin-RevId: 167332236
Change-Id: I1c0b5b429316dae119b5fb21be4303d7fe052e35
|
|
These new states will be used to show descriptive failure messages to the user.
Also moved the VoicemailCompat class to avoid duplicate code.
Bug: 37340510
Test: none
PiperOrigin-RevId: 167314611
Change-Id: I618d7f196ea2b0161cbd33479553cae3521328d7
|
|
Test: manual
PiperOrigin-RevId: 167310802
Change-Id: Ie27a1b2f4daf73133edfb9de7f4e4aff1d87b6c8
|
|
Somehow a null action will be sent to the receiver.
Bug: 64934925
Test: LegacyVoicemailNotificationReceiveverTest
PiperOrigin-RevId: 167300542
Change-Id: Ifa001d102d265e1dad42806b48f0a1710d05b195
|
|
screenshots:
default: http://screen/qEdB51A3PDn
zero-query: http://screen/qEBDg0auGA8
query: http://screen/SuLp2GwyvYr
Bug: 64806278
Test: manual
PiperOrigin-RevId: 167205946
Change-Id: I07563fd23801da8d9d2eb95f6d09a079474403eb
|
|
The TelecomManager#isInCall method returns true anytime the user is in a call.
Starting in O, the APIs include support for self-managed ConnectionServices so that other apps like Duo can tell Telecom about its calls. So, if the user is in a Duo call, isInCall would return true.
Dialer uses this to determine whether to show the "return to call in progress" when Dialer is launched.
Instead, Dialer should use TelecomManager#isInManagedCall, which only returns true if the device is in a managed call which Dialer would know about.
Bug: 36991070
Test: none
PiperOrigin-RevId: 167200903
Change-Id: I12ac7b893dcbfa2fc842ca5ab356fbbc490a098b
|
|
Bug: 64129606
Test: none
PiperOrigin-RevId: 167174480
Change-Id: I4b5a494b0b334b42ee053c4d4d1e81d7699461d0
|
|
Test: http://screen/9eBrOUZj90T
PiperOrigin-RevId: 167099613
Change-Id: I3ae96b376ced290ff9d1f328cfaf29b8f8fce979
|
|
Previously, Android's Dialer app was developed in an internal Google
source control system and only exported to public during AOSP drops.
The Dialer team is now switching to a public development model similar
to the telephony team.
This CL represents all internal Google changes that were committed to
Dialer between the public O release and today's tip of tree on internal
master. This CL squashes those changes into a single commit.
In subsequent changes, changes will be exported on a per-commit basis.
Test: make, flash install, run
Merged-In: I45270eaa8ce732d71a1bd84b08c7fa0e99af3160
Change-Id: I529aaeb88535b9533c0ae4ef4e6c1222d4e0f1c8
PiperOrigin-RevId: 167068436
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC45
Branch: dialer-android_release_branch/153304843.1
dialer-android_20170416.00/dialer-android_20170416.00_RC45
This release contains the following bug fixes since RC39:
Bug: 38131932 38302993 38347350 38368993 38395481
62100344
Test: make, on device
Change-Id: Ib4af5dcc58c684d51ea1f4628b301e40184b81b3
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC39
Branch: dialer-android_release_branch/153304843.1
dialer-android_20170416.00/dialer-android_20170416.00_RC39
This release contains the following bug fixes since RC32:
Bug: 38137349 38249439 38299262 38329114
Test: make
Change-Id: I65f695db8aa20902fa60835d58b41cfdfe42704b
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC32
Branch: dialer-android_release_branch/153304843.1
dialer-android_20170416.00/dialer-android_20170416.00_RC32
This release contains the following bug fixes since RC17:
Bug: 33176679 33272455 3646510 36773894 37297649 37413780
37513689 37640315 37680595 37698062 37873639 37901752
37919295 37953423 38062852 38069600 38137349 38173549
38180252 38191514
Test: make, on device
Change-Id: I4e4bb630082758e418ff24892b7db3142c6eb09a
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC17
Branch: dialer-android_release_branch/153304843.1
dialer-android/dialer-android_20170416.00/dialer-android_20170416.00_RC17
This release contains the following bug fixes since RC16:
Bug: 37962346
Test: make, on device
Change-Id: I1852cc096ef242c7bfcd85b11f954ddb00903c39
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC16
Branch: dialer-android_release_branch/153304843.1
dialer-android/dialer-android_20170416.00/dialer-android_20170416.00_RC16
This release contains the following bug fixes since RC00:
Bug: 37324705 35304403 36067503 35304446 33203808 37280992
37346084 35766990 37481880 37424493 36470282 37347691
37519015 37168472 35805360 37545472 27704934 36515614
35766990 37577470 34739750 35801628 36788693 35264204
36708536 37628370 36904650 37314436 37642171 37530847
37637799 37666625 37548549 37648036 37636412 37323529
37630507 35919141 37198343 37548572 36178218 37640315
37663896 37720467 37275944 37710497 31634477 37744796
37348506 37744796 37568534 37672424 34872683 34873026
37681461 34873295 37748373 37526812 37618638 37663896
37536088 37727455 37165687 36651204 36900708 37323529
36902926 37256480 37328353 37432034 37436952 34093562
37720889 37321935 37780300 37781115 37755902 36588206
34258266 37290464 37698062 37618638 37473004 37432034
37918676 37870494 37722091
Test: make, on device
Change-Id: I99e1a484ccd578c1f8a13e7a6a4b4952f0791297
|