summaryrefslogtreecommitdiff
path: root/java/com/android/dialer/app/calllog
AgeCommit message (Collapse)Author
2018-07-10Revert "UI refresh for call log items."Eric Erfanian
This reverts commit 9c952d8f2688350f06d65df7852756ab05b6fdab. Change-Id: I3b2f23826c34ecdb16e786c5dd92f13ed97d88e7
2018-06-29UI refresh for call log items.wangqi
Bug: 79877518 Test: manual PiperOrigin-RevId: 202690405 Change-Id: Ibb2c5e81cb244aad25d75dc005bfc92ef775ffe1
2018-06-28Remove redundant @TargetApi, @RequiresApi and @SuppressWarningslinyuh
Test: Existing tests PiperOrigin-RevId: 202589482 Change-Id: I6982e4069d30032bf46caf3c9984dfc0e7196f6f
2018-06-28Use ConcurrentMap to log Contacts Provider metrics in the old call log.linyuh
Bug: 80482741 Test: None PiperOrigin-RevId: 202526514 Change-Id: Ia92b95b288638ccb77d3bac16bd8c5589326bf61
2018-06-26Refactor ContactPreferencetwyen
Moving it outside contacts.commons reduces dependency to legacy code. Also removed redundant implementations such as caching SharedPreferences (it is already cached), custom ListPreferences (standard ListPreferences already have what we want), and corrected preference storage location (allow standard ListPreferences to work) TEST=TAP Test: TAP PiperOrigin-RevId: 202000393 Change-Id: I45374e610b3510784b5a4da92e5d8462cbfc92bb
2018-06-26Reset speaker mode when done with VVM Tabuabdullah
Bug: 110530781,78281972 Test: N/A PiperOrigin-RevId: 201729044 Change-Id: Id00e8e3e4ee89b846bce78f4a29d5e6f26384e0c
2018-06-11Ignore read voicemails for notificationstwyen
Previously the notification is only auto-canceled if it is deleted from the server. In this CL it will also be canceled if it is read. TEST=TAP Bug: 80214330 Test: TAP PiperOrigin-RevId: 200134453 Change-Id: I716c4c6ee060a7b4162147d9bf9e2e1f5077317a
2018-06-08Removed cast to DialtactsActivity.zachh
DialtactsActivity should be dead code at this point so this code should be unreachable. Bug: 109931227 Test: none PiperOrigin-RevId: 199872804 Change-Id: I4f4f66f5c803662de238c42dc746423c8ab1f150
2018-06-08Don't refer to DialtactsActivity.class to launch the DIAL intent.zachh
We want to remove DialtactsActivity but cannot replace it with MainActivity or would create a circular dependency. Instead, just let the system to pick the activity appropriate for the dial intent (which should be MainActivity). Bug: 109931227 Test: manual PiperOrigin-RevId: 199871747 Change-Id: I6e4a5a854f3cd04d630df9d831df2767d411f1c1
2018-06-08Use an intent action to launch MainActivity instead of class reference to ↵zachh
DialtactsActivity. We can't just replace DialtactsActivity with MainActivity because a circular dependency would be created. Instead create a new dialer-specific "main" intent action and use it. Bug: 109931227 Test: manual PiperOrigin-RevId: 199868961 Change-Id: I0ef72ed418280eeb64ea1ea854d215093b0dba27
2018-06-08Moved EXTRA_CLEAR_NEW_VOICEMAILS to MainComponent.zachh
This needs to be moved in order to delete DialtactsActivity. Bug: 109931227 Test: none PiperOrigin-RevId: 199820125 Change-Id: I2b2c190152834bd1d0d0510f8e01110f05a5a8f3
2018-06-05Handle null carrier config for emergency call hinttwyen
getCarrierConfig() is @Nullable. While the default implementation always return a bundle, this is not true for other carrier apps. ShadowTelephonyManager.getCarrierConfig() now return null as default to catch this behavior. TEST=TAP Bug: 80629471 Test: TAP PiperOrigin-RevId: 199327865 Change-Id: I7416bee3d5f5307919c6825fc74c26f25b6b001f
2018-06-01Inlined ConfigProviderBindings.get() and removed ConfigProviderBindings.zachh
It no longer provides any value, so just use dagger directly. Bug: 80441695 Test: tap PiperOrigin-RevId: 198806461 Change-Id: Id607abb65b77633bce511ad0c943ac19453a85d5
2018-06-01UI fixes for emergency numbers in the old call log.linyuh
Bug: 80426301,80426768 Test: Manual PiperOrigin-RevId: 198783744 Change-Id: Ib704a710680b3cf18e4c3c91cd48e7b8491671ff
2018-06-01Use geocode as label for businesses.twyen
Business number from PhoneNumberService does not always have a sensible label. Previously it would be "Main", but geocode are a bit more useful. TEST=manual, old UI has no tests. Bug: 80251984 Test: manual, old UI has no tests. PiperOrigin-RevId: 198455846 Change-Id: I5efbc66aa295f8039eecfbcb119f18afc735b15c
2018-05-29Converted ThemeUtil into a DaggerModule.calderwoodra
This enables us to have Google-Sans font in GoogleDialer and Roboto in AOSP. Bug: 79883035 Test: tap PiperOrigin-RevId: 197774497 Change-Id: I1d490ab196a444c62e439444627d659fc42973ea
2018-05-29Delete AppCompatConstantslinyuh
Test: Existing tests PiperOrigin-RevId: 197681266 Change-Id: I27fdda1d5c252993795b6eb860663c8cab0d363c
2018-05-29Began implementation of Dialer dark theme.calderwoodra
- README on how to properly theme Dialer going forward. - Migrated all widgets to use global colors. - Removed all activity and application themes where it wasn't necessary. - Added themeing test rule for Espresso tests. Bug: 79883035 Test: tap PiperOrigin-RevId: 197634256 Change-Id: I4b7d94d45aeeb59d484b0069fdd1e200a654910b
2018-05-21Check for WRITE_CALL_LOG permission in CallLogNotificationsQueryHelper.zachh
TEST=unit Bug: 79667976,79925108 Test: unit PiperOrigin-RevId: 197468611 Change-Id: Ifedddd2bccd76b1fc2c9d3ea4e9854bfe6a218e5
2018-05-21Ignore dialer OMTP VVM error if VVM is disabledtwyen
The status will be stale. TEST=TAP Bug: 78831353 Test: TAP PiperOrigin-RevId: 197462056 Change-Id: Iaeeae9007f6b5ad8319889a860fdcce782be8a0d
2018-05-21Implement a global theme to be easily configured in Dialer.calderwoodra
deleted several colors and unified them across the app migrated several alert dialogs to support alert dialogs added many todos migrated several tests from GoogleRobolectricTestRunner to RobolectricTestRunner Because of the test migration: - moved dialpad theme attributes into dialpad/theme - moved incall ui theme attributes into incallui/theme Bug: 79883035 Test: tap PiperOrigin-RevId: 197246477 Change-Id: Ifc534793bc32757bbbf2007a7c40287c8d0817ad
2018-05-18Don't post throttled notifications again.yueg
Throttled missed call notification can be post again since they are in the newCalls list and not in activeNotifications list. We should record them and don't post again. Test: MissedCallNotifierTest, NotificationThrottlerTest PiperOrigin-RevId: 197177610 Change-Id: I1b03029663621f0a0c06951564eadf78bad016a1
2018-05-15Exit multiselect mode when opening the dialpad.calderwoodra
Bug: 79183384 Test: manual PiperOrigin-RevId: 196344851 Change-Id: I9f5c0e52cb4efe9e63e2c19a4f62ee0b9a23412f
2018-05-09Place Duo calls with PreCalltwyen
This CL consolidates common duo calling operations into precall, including checking reachability, falling back to carrier video call, placing the call to duo with startActivityForResult. TEST=TAP Bug: 78783816 Test: TAP PiperOrigin-RevId: 195742478 Change-Id: I9fea1e4999f604e1f3a153b28079cd0db77b7393
2018-05-09Fix bug that showing block option for private number.wangqi
This happens when the number exists in call log, which usually shouldn't happen but some OEMs may have different behavior. Adding an additional check to align it with call action so block option won't show up if the number is not callable. Bug: 79202933 Test: verified on LG device. PiperOrigin-RevId: 195480184 Change-Id: Icde5f5b0914b2198d9031d188b22a65d6a3085cc
2018-05-04Replace DuoConstants with interface.twyen
They are not constant across different Duo implementations. TEST=TAP Bug: 76430187,78783816 Test: TAP PiperOrigin-RevId: 195001650 Change-Id: I4356d04c9eeac50fefd41e1142f3123591e93bc0
2018-04-30Cancel all legacy voicemail notification when SIMs are removed on multi-SIM ↵twyen
devices When the SIM is removed, telephony will signal cancel notifications on the "null" account (the framework doen't know what was there.). Previously this has no effect. In this CL, all legacy voicemail notifications are removed since all SIM will be removed together. TEST=TAP Bug: 78446801 Test: TAP PiperOrigin-RevId: 194856211 Change-Id: I5df97f0c73e0644daa46ab182f19e60044e39d96
2018-04-26Implement CequintPhoneLookuplinyuh
Bug: 70989584 Test: CequintPhoneLookupTest PiperOrigin-RevId: 194493484 Change-Id: I59f9b334f0a218e7ba1c34948db4ddbf11490df3
2018-04-26Fix impression logging for spam blocking promo dialog shown in after callAndroid Dialer
notification. Test: N/A PiperOrigin-RevId: 194465415 Change-Id: Ica9301f4315b549c343112a824c8f7c51213bb99
2018-04-17Add spam blocking promotion after showing spam dialog in after-callAndroid Dialer
notification Test: N/A PiperOrigin-RevId: 193290689 Change-Id: Idff99e2f67d5161d09b7ea3c0818ed92d2286b61
2018-04-17Added logging for contacts provider metrics.zachh
TEST=unit Test: unit PiperOrigin-RevId: 193288015 Change-Id: I350fa06cb96ff1887c428c8d60c489ddf0da81f6
2018-04-17Add RTT transcript screen.wangqi
Bug: 67596257 Test: CallDetailsCursorLoaderTest PiperOrigin-RevId: 193259769 Change-Id: I8c6a8eb9a6bf06e9c1c25c45fc035f8db8ae5a65
2018-04-10Add RTT icon to RTT call log.wangqi
This is for old call log UI. This change also improves scaling for vector drawable icons. Bug: 67596257 Test: manual PiperOrigin-RevId: 192359601 Change-Id: I3322fe08b668f01c1e3a7ce3264c2988e2703aae
2018-04-06Change voicemail empty state icon to voicemail icon.calderwoodra
Bug: 75962146 Test: screenshot PiperOrigin-RevId: 191948101 Change-Id: Icba3cb63cbfe42ce0f193e731dbe2240b3dfc27d
2018-04-03Fix NPE for details numbermaxwelb
The phone number can be null in the call log (typically for conference calls), but this wasn't handled properly for calls from non-contacts. This CL fixes the issue by instead using the display number. PhoneNumberUtils properly handles null values and can parse the formatted version. Bug: 77486039 Test: manual :/ PiperOrigin-RevId: 191492307 Change-Id: I1be427b3f4ed1381bea3943d130256618f730f5d
2018-03-29Update what happens when donation is rejected & use correct donation ↵uabdullah
availability check Checking donation is not a simple config check, but everything that donation availability is dependent on via the isVoicemailDonationAvailable() helper method. We update the code accordingly. When the user declines the promo for donation, we should also update the toggle accordingly. Bug: 74033229 Test: N/A PiperOrigin-RevId: 191011808 Change-Id: I6e4ff9914355deed72175179fc7b9009f2395ef5
2018-03-29Mark spam voicemail as old after we auto block it.Android Dialer
Bug: 77242856 Test: N/A PiperOrigin-RevId: 191002650 Change-Id: Ia74423f28a40f148d507fb9f907fc2e5c41fc183
2018-03-27Delete debugging logging statement in voicemail spam blockingAndroid Dialer
Test: N/A PiperOrigin-RevId: 190673495 Change-Id: I1587449f6b0b53e7a16aac0b334225649a94f27b
2018-03-26Remove obsolete methods in CompatUtils and rename it as "LocaleUtils".linyuh
Test: Existing tests PiperOrigin-RevId: 190516504 Change-Id: I5fa9e123b45beb9728257ecd160a348fb3f4732c
2018-03-26Remove obsolete version checks and compat utilities after min SDK was bumped ↵linyuh
up to N. Test: Existing tests PiperOrigin-RevId: 190508397 Change-Id: Ia5f33e45af1d1cc666fec5f43efa564b2b68c193
2018-03-26Move spam setting related methods out of spam interface into a separate spamAndroid Dialer
setting interface. Test: All the existing tests PiperOrigin-RevId: 190314880 Change-Id: I030acbd70120f508c5a4616757d89113524110fa
2018-03-26Removed NUI shortcut.zachh
We're not going to have a shortcut for NUI anymore. There are individual flags related to NUI that are controlled in CallLogConfig. Other related changes to help accomplish this: -Changed how the call log framework/config/migrator interact; the migrator is now only called on config changes and enabling/disabling of the framework now lives in CallLogFramework. -Move CallLogConfig an interface, and moved it to its own package and added component and module. This is to simplify tests which just need to check the config status (like PhoneLookupHistoryRecorderTest). -The "Main" package is also on longer needed since it existed to control the shortcut. Bug: 74821995 Test: existing PiperOrigin-RevId: 190251418 Change-Id: I73c8e83aee80295131443a8ffaa7dea716ea89b6
2018-03-26Fix CallLogGroupBuilderTest after min SDK was bumped up to N.linyuh
Bug: 76154272 Test: CallLogGroupBuilderTest PiperOrigin-RevId: 190187854 Change-Id: Ib96c406c4bb0627729c24c58c526850ff4fda22f
2018-03-26Correctly display phone numbers containing whitespaces in RTL context.linyuh
Bug: 74421656 Test: DialerBidiFormatterTest PiperOrigin-RevId: 190154072 Change-Id: Ic7cb3be702dd28b07b6e5e1e6d89f75f0bb12655
2018-03-26Increase minSdk to 24.calderwoodra
Manually set to M - MissedCallNotifierTest (not sure what the issue is here...) - CallLogGroupBuilderTest (because a check was removed, some NPEs are thrown) - MainSearchControllerTest (/system/etc/fonts.xml (No such file or directory)) Ignore Tests - a few random ones in incallui/answer/impl/hint (shared prefs aren't working for some reason) - VisualVoicemailUpdateTaskTest (disabled the whole test, issue unclear) Bug: 73902692 Test: tap PiperOrigin-RevId: 190030202 Change-Id: I1e9b61d758a61582c5a183ee884dd2181d1c10de
2018-03-21Display "Emergency number" in the call log for emergency numbersmaxwelb
This CL updates the call log to show "Emergency number" for call log rows from numbers that PhoneNumberUtils.isEmergencyNumber considers to be emergency numbers. Bug: 66926712 Test: Manual, see above PiperOrigin-RevId: 189953302 Change-Id: Ibaae243ead8b918a26f6058164316e042a4f82fd
2018-03-19Show spam blocking promo after block spam dialogAndroid Dialer
Test: SpamBlockingPromoHelperTest PiperOrigin-RevId: 189674918 Change-Id: I0b22eb9b8128125cc5b439674099820a01c3889f
2018-03-19Check null for getPhoneAccount()twyen
A phone account can be removed after calling getCallCapablePhoneAccounts(), so subsequent getPhoneAccount() can be null. Other usages already has the null check. Bug: 75598828 Test: N/A testing this involves getPhoneAccount() returning null on the nth call, which requires replacing the shadows with a mock and is highly coupled with the implementation. The is an edge case and is not worth the effort and brittleness it will cause. PiperOrigin-RevId: 189644833 Change-Id: Ie92dda2537befb5936ad734954b4eaf75964f465
2018-03-16Check if parent is null since fetch call can be called while Dialer is paused.calderwoodra
Bug: 73972084 Test: n/a PiperOrigin-RevId: 189418664 Change-Id: I3dadea08dad1f2a594f5a7e0daf055721c3222a3
2018-03-16Refactor VM Settings and add support for voicemail transcriptionuabdullah
This CL refactors the existing voicemail settings fragment and adds UI support for voicemail transcription. It mainly deals with the following: - ensuring that when the VVM toggle is turned off, transcription and donations are gone. - when transcription is off, donation preference is gone. - donation is only available when transcription is available and enabled - as part of the refactor, fixes existing logging bugs - breaks preferences and its associated methods into helper methods when possible - groups relevant preferences together when possible Bug: 74033229 Test: Unit tests PiperOrigin-RevId: 189418217 Change-Id: I3442cb5752a235cfca643ba55df3fb75171e3fe4
2018-03-15Restore delete call log item logging in call details.calderwoodra
This was accidentally removed in cl/176677167. This change restores the logging in call details and also adds it to the call log menu. Bug: 73774284 Test: OldCallDetailsActivityIntegrationTest, CallLogActivityIntegrationTest PiperOrigin-RevId: 189279107 Change-Id: Iadda16d7f1e4d720f828b5a72f210bcb8029f939
2018-03-15Add utility used to style content with learn more linksmaxwelb
Bug: 74017355 Test: ContentWithLearnMoreSpannerTest PiperOrigin-RevId: 189252365 Change-Id: I3464fb56b86a6b3ddd25e9eed14152eaeed9925c
2018-03-14Split CallDetailsActivitylinyuh
Bug: 74202944 Test: Existing tests PiperOrigin-RevId: 189095432 Change-Id: I13015ee6c5767edd95b78c3fb2e7338495e9e1d7
2018-03-12Don't fetch calls if the parent doesn't exist.calderwoodra
This CL is a continuation of cl/187700318. In that CL, we were able to unregister the call log's content observer and prevent this crash, but it's reshowing itself in voicemail now. Since the voicemail's observer is registered in the adapter and is unaware of lifecycle changes, it's much more invasive to fix. So as a quick bandaid, we'll just check that the parent isn't null. Bug: 73972084 Test: n/a PiperOrigin-RevId: 188812159 Change-Id: I533114de66b52395b0f3c90d4ec7a927c4df707f
2018-03-09Add spam blocking setting in spam module.Android Dialer
Test: InAppSpamTest,ApdlSpamTest,VisualVoicemailUpdateTaskTest PiperOrigin-RevId: 188509191 Change-Id: I8b9c07dcc1c7b3b80ffc914ec99f4e6d80d50985
2018-03-08Add flag for filtering emergency calls from call logmaxwelb
Bug: 73368638 Test: CallLogAdapterTest PiperOrigin-RevId: 188414469 Change-Id: I7d7522c841a6b4054e2e387346973c597174ee87
2018-03-08Implement logic for blocking a number from the new call log's bottom sheet.linyuh
Bug: 70989547 Test: ShowBlockReportSpamDialogNotifierEndToEndTest PiperOrigin-RevId: 188351591 Change-Id: I634fb821592bdc890df291fdf83cdf307c94ffa9
2018-03-07Add additional logging to missed call notification code pathroldenburg
Bug: 73877234 Test: just logging PiperOrigin-RevId: 188256051 Change-Id: Ic9486b3fc1d97338cb016b86a243612baa6282fe
2018-03-05Check if the activity is still alive before refreshing unread tab counts.calderwoodra
My hypothesis is that there is a race condition where the call log changes and we are leaving the activity before the content observer is unregistered or the loader it starts is finished. This results in a callback calling #fetchCalls while Dialer is in the background, resulting in a crash. This change will confirm my hypothesis. Even if my hypothesis is incorrect, we have similar checks throughout this class which indicates to me that some issue exists here and that this check is safe to do. Bug: 73972084 Test: n/a PiperOrigin-RevId: 187700318 Change-Id: I98cea86b5b7041c4f4aac09544445aaade6bfd40
2018-03-01Disable phone number formatting for devices with Argentinian SIMs.linyuh
Bug: 73718977 Test: PhoneNumberHelperTest PiperOrigin-RevId: 187540382 Change-Id: I814ec62b2215c24b8cde3442c5dc83d98ad87164
2018-02-28Some small bug fixes in NUI.calderwoodra
- Never show the dialpad chooser in MainActivity. - If the call log changed while dialer was in the background, it would trigger the content observer to fetch the new info, which would request it's parent that wasn't there. Now we register/unregister them in onResume/onPause. This is safe to do because we force refresh the data onResume anyways, so any changes will still be shown. Bug: 73972084,73975555,73995512 Test: manual PiperOrigin-RevId: 187407058 Change-Id: Iae86dabbcb852398bb2b9df4627e234261ab8030
2018-02-28Update voicemail donations stringsmaxwelb
Bug: 73798533 Test: Manual :/ PiperOrigin-RevId: 187383740 Change-Id: I0f35ccbf19a59b35338cb144f0192b692585159f
2018-02-27Fab now hides/shows correctly when you enter and leave the voicemail tab.calderwoodra
Test: manual, going between tabs hides/shows the fab properly when ToS is (in)visible. PiperOrigin-RevId: 187253210 Change-Id: Ied9ea44892786268b9dfa68816840dfbfc74aa6e
2018-02-27NUI no longer crashes when clicking "place call" in empty call log.calderwoodra
Bug: 73258376 Test: MainActivityOldPeerCallLogIntegrationTest PiperOrigin-RevId: 187242222 Change-Id: Ic2684467035fedc1156886712757bf0911f65ee5
2018-02-26Implement logic of bottom sheet options related to spam numbers.linyuh
Bug: 70989605 Test: ShowBlockReportSpamDialogNotifierEndToEndTest + Manual PiperOrigin-RevId: 187047450 Change-Id: I23c3929135bcfe5c14fe317ef65f628dc126027f
2018-02-22Removed item animator in Call Log RecyclerView.calderwoodra
Bug: 69965302 Test: TAP PiperOrigin-RevId: 186573663 Change-Id: I099f22b7a8df7018ec50e309b2ae37f3eedd76fd
2018-02-22Moved metrics related methods out of LoggingBindings.zachh
Test: existing PiperOrigin-RevId: 186413083 Change-Id: I96c88c46b0ecc01167b655fa30fc47aaa6a9e351
2018-02-22Record jank metrics in old and new call logs.zachh
Bug: 70989667 Test: unit PiperOrigin-RevId: 186410938 Change-Id: I0671ab0bbbe957b8f034c673e6309204284756d2
2018-02-22Fix a few UI issues based around multiselect in new nav.calderwoodra
- No longer crashes when entering mw-mode while in multiselect - Configuration changes now properly restore bottom nav visibility - toolbar shadow is now only visible in search Bug: 72525324 Test: MainActivityOldPeerSearchIntegrationTest PiperOrigin-RevId: 186037379 Change-Id: I5fc00c8091e85fc67482b2131944fb776626d06f
2018-02-14Mark calls as read in new call log.zachh
Playing with the existing app, the missed call becomes unbolded when: 1) Expanding the row. The closest analog of this is in the new UI is opening the bottom sheet, I've done that. 2) Swiping away from the call history tab. This can't be done in NewCallLogFragment because it doesn't know if the user is selected a new tab or pressed Home. So, I implemented this in NewMainActivityPeer. 3) After viewing the call log for 3(ish) seconds and leaving the activity pressing Home/Back. This is best done in NewCallLogFragment#onResume since MainActivity doesn't always know when the fragment is being displayed (it could be done after the user comes back to the app after pressing Home for example). Note that the notification is also removed in all of these cases. Also note that dismissing the notification makes the call unbolded (but this case already appears to be handled via the system call log content observer). Also, as part of writing tests for this, I made TestCallLogProvider more realistic. Bug: 70989622 Test: manual PiperOrigin-RevId: 185457438 Change-Id: Ib360d3bc73083bd1a018ed98e2b7d9a69fb7fafb
2018-02-14Clicking on a missed call in the call log no longer crashes the app.calderwoodra
Bug: 72956783 Test: DialtactsActivityIntegrationTest PiperOrigin-RevId: 185404033 Change-Id: I486f7b1a6739bf49c6f19bba82227dd4d9794e1f
2018-02-06Adding voicemail donation promomdooley
This cl shows a voicemail donation promo the first time a user tries to rate a transcription. It also changes the good/bad rating links to thumbs up/down icons. The 'learn more' link still needs the real URL. screen shots: https://drive.google.com/open?id=0B9o_KvtLkcuIOERUNUJId3FVY3UzUS0wVUdQQVpCS1lmM3Nz https://drive.google.com/open?id=0B9o_KvtLkcuIWkNVMDV1VTJ4VUMtakVwSE1UTGdUWjljTUV3 https://drive.google.com/open?id=0B9o_KvtLkcuIeU1ndG1palRkTnNJQWVYLXgyMnd4TjBDOFI4 mocks: https://drive.google.com/file/d/1FIhXDkn3h3xI7liVdJEraq47MoKQM3hi/view https://drive.google.com/file/d/1uTm58QCvFOBycsGP21vgvEGTq_Imgkqi/view Bug: 37340510 Test: manual tests PiperOrigin-RevId: 184745497 Change-Id: I40fd1e211311c3127f215ede2e44b22f345dcf8b
2018-02-05Visual Voicemail notifications now go to MainActivity when enabled.calderwoodra
Bug: 72525615 Test: VisualVoicemailNotifierTest PiperOrigin-RevId: 184625656 Change-Id: I8a0b53e12ebe8382f5bc5febd7a6ec448a255f2f
2018-02-05Missed calls now go to MainActivity if you have the component enabled.calderwoodra
This CL has a few changes of varying relevance: Most Relevance: - MissedCallNotifications will open MainActivity if the component is enabled (Meaning the launcher is in their app drawer and the flag is flipped). - Implemented show tab intent (open MainActivity directly to a specific tab) - Tests Some Relevance: - Implemented checking for ACTION_DIAL intents (dialpad will open immediately) - Tests Not Relevant but nice QoL changes: - Added tests for missed calls being marked as read - Makes espresso tests more horizontal to reduce timeouts - Bug: 72525550,72525615 Test: implemented PiperOrigin-RevId: 184600627 Change-Id: If96a44ce252e97c022ebc1b58fa783b3326035e7
2018-01-31Added old voicemail to NUI activity.calderwoodra
Bug: 72722364 Test: existing PiperOrigin-RevId: 184083186 Change-Id: Ia51a50b343f75eec74a02dc6b4383341f939793d
2018-01-31Implemented missed call/voicemail notifications in NUI.calderwoodra
This CL shows and updates the missed call/voicemail count in the bottom nav. It also clears the call log notifications when the user either leaves the call log fragment or closes the activity after 3 seconds of browsing the call log. Bug: 72525595 Test: tba PiperOrigin-RevId: 184071058 Change-Id: I540c9e3d815e022b5e311cb02a3995e241b8a984
2018-01-30Added old call log to NUI.calderwoodra
Bug: 72618828 Test: existing PiperOrigin-RevId: 183902491 Change-Id: I079aca188b52c29c12b3cae7e57bf71a4e883898
2018-01-26Pressing dial with an empty dialpad now queries the last number in NUI.calderwoodra
Bug: 72526019 Test: manual PiperOrigin-RevId: 183425741 Change-Id: Ied1b369d00baefe02db04ade26bee9faac4f829c
2018-01-25Remove non call log dependencies on PhoneAccountUtiltwyen
Methods moved to TelecomUtils Test: Unit tests PiperOrigin-RevId: 183305626 Change-Id: Idd6604e58c06a36066bd49870849dd71747969c6
2018-01-22Move legacy voicemail/error to nui voicemail/listui/erroruabdullah
All packages relating to NUI voicemail should be under third_party/java_src/android_app/dialer/java/com/android/dialer/voicemail/listui. Since there is a chance that during NUI development the legacy third_party/java_src/android_app/dialer/java/com/android/dialer/app/voicemail/error might undergo changes, it makes sense to move this package to the nui, so that no changes in the legacy code are missed for nui. This refactoring would also allow us to ensure that the strings do not need to be translated and that most of the code can be re-used for nui by hooking up the fragment and adapter to voicemail/listui/error. Bug: 71700117 Test: Unit tests PiperOrigin-RevId: 182868896 Change-Id: I23329654df5ce2bf612101708ed001ca308ae1ac
2018-01-10Add events for displaying set up or invite buttonsroldenburg
Bug: 70034799 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 181515491 Change-Id: I62dc4d4d4ebb02e8e1e8dce6c6970bb7c8845952
2018-01-08Hide emergency calls in the call logmaxwelb
Bug: 38494024,66926712 Test: CallLogAdapterTest, manually checked UI PiperOrigin-RevId: 181238101 Change-Id: I1b718e30a4bc874e098e30a3aaae39bdd69d0c9a
2018-01-02Add assisted dialing indicators to the old call log.erfanian
Modify the call log grouping strategy. The strategy is as follows: When comparing the current group to the next candidate to add to that group, if the assisted dialing feature tag differs between the two, create a new group. Thus, if a call has other features like wifi or hd, we ignore those features when making grouping decisions. Bug: 70506228 Test: unit tests PiperOrigin-RevId: 180592125 Change-Id: I73d130bd9eb23706a04cb02f5711200729d978b6
2017-12-27Remove field prefixes.linyuh
Test: Existing tests PiperOrigin-RevId: 180230450 Change-Id: I0b2589cfeeaef81e42a04efa48af24b4e4d0e95f
2017-12-27Fixing transcription branding UI bugmdooley
Needed to set the branding text (to an empty string) when the transcription rating text is visible, so that both aren't displayed at the same time. Bug: 71361435 Test: manual PiperOrigin-RevId: 180218087 Change-Id: I04e485727267c306c7eb8f3780424855aaddebe5
2017-12-19Add flags for the Duo install, activate and invite buttonsroldenburg
Bug: 70034799 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179596742 Change-Id: Ic5616af0680e36786ae5261813eae71cf096b084
2017-12-19Ignore deleted voicemail for notificationtwyen
Some voicemail sources keep deleted voicemails in the database for a while. Before this CL if the voicemail is deleted through blocking it will still be returned with CallLogNotificationQueryHelper.getNewVoicemail(), and deleted again. The Deletion triggers a notification update, and the phone enters a loop. If there are other voicemails, the phone will alert every time. In this CL, deleted voicemails are no longer returned with the new voicemail query. Also if All voicemails already has a notification, the user will not be alerted. Bug: 70585368 Test: VisualVoicmailUpdateTaskTest, CallLogNotificationQueryHelperTest PiperOrigin-RevId: 179575512 Change-Id: I352bbf7d0a9d5e2132b5f968e5b5776c9fd518c6
2017-12-18Ensure we do not have a null data string before checking for Duoroldenburg
Bug: 70794242 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179480604 Change-Id: Ic53ca21fb7e81390f45b116677df689d3d8fdb67
2017-12-15Hide "Invite" and "Set up" Duo buttons for spam and voicemail callsroldenburg
Bug: 70681464 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179224173 Change-Id: I7b70f478898fade5cc5a9bf50581d35f2ce2261f
2017-12-14Use Dagger to get Duo instance in CallLogListItemViewHolderroldenburg
Bug: 70402153 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179106427 Change-Id: I2c82e95022c461d251d3385841640bc31d8aa765
2017-12-14Add impressions for Duo related events (install, activate and invite)roldenburg
Bug: 70034799 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 179085188 Change-Id: I7546cf7e35bbdd3788b03d19627d9a04f612335f
2017-12-14Take into consideration special characters when we do contact match.linyuh
Bug: 30225112 Test: CallLogGroupBuilderTest, PhoneNumberHelperTest, CallerInfoTest, and Manual (see demo) PiperOrigin-RevId: 179080046 Change-Id: I8e451a6c197a6c3df4260e58d0276a5dc5b9515a
2017-12-13Take user to install Duo if they tap "Set up" without the app installedroldenburg
Bug: 70034799 Test: DuoImplTest, GoogleCallLogAdapterTest PiperOrigin-RevId: 178981398 Change-Id: Id524dfe61bf3a2358d863dd8d5f7c6c083b8063c
2017-12-12BEGIN_PUBLIClinyuh
Automated rollback of changelist 172683494 Bug: 30225112 Test: None PiperOrigin-RevId: 178807986 Change-Id: I45978ea4daab71985ac93c3c3a0439fdd8e873d5
2017-12-11Update Spam module to use Daggermaxwelb
Test: TAP PiperOrigin-RevId: 178650781 Change-Id: I299907ac43d48b984b092433c9b651aadb17c62a
2017-12-08Add "Set up" and "Invite" for video to call log entry actionsroldenburg
Bug: 70034799 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 178434462 Change-Id: I220cb74116aaa5dc3518de0dd20f2cdefda4049b
2017-12-07Ignore "new" voicemails that are too old for notificationstwyen
Bug: 68049435 Test: CallLogNotificationQueryHelperTest PiperOrigin-RevId: 178016400 Change-Id: I6ddbebc9edce6830966072d42cf05eb21f26c8ac
2017-11-28Adding transcription rating feedbackmdooley
Allow users who have agreed to donate their voicemails to also provide transcription quality feedback. screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuIajVtdFN3Y0Qydmx2NXJYN2N3OVA3N0h5UEdR Bug: 68712148 Test: manual and new unit tests PiperOrigin-RevId: 176774942 Change-Id: I08b9afbbefaedfb0de5199038a1d2769bd983855
2017-11-22Allow deleting a call log entry in the call log UI and the call details UI.linyuh
In the call log UI, an entry can be deleted by selecting "delete" in its context menu. In the call details UI, a "delete" button is added at the bottom. The "delete" icon at the top right of the call details UI is removed. Public-Origin-Change-Id: Iabe1310fb9a97a277cf482a3fd61ffccbec125fe Signed-off-by: Linyu He <linyuh@google.com> Author: Masafumi Miya <masafumi.miya@sony.com> Bug: 38188896 Test: CallLogActivityIntegrationTest, CallDetailsActivityIntegrationTest PiperOrigin-RevId: 176677167 Change-Id: I2e31cd112efdfb83393f5e68ce016dcf36ac4858
2017-11-20Cancel missed calls in call history when needed.yueg
Including when: - onStop() - switching tabs Also move old CallLogActivityTest to espresso directory. Test: CallLogActivityTest PiperOrigin-RevId: 176387019 Change-Id: Icbb77747882c8a5e35595557baa6917a4dc674b6