Age | Commit message (Collapse) | Author |
|
Bug: 70989584
Test: CequintPhoneLookupTest
PiperOrigin-RevId: 194493484
Change-Id: I59f9b334f0a218e7ba1c34948db4ddbf11490df3
|
|
This CL is a continuation of cl/187700318. In that CL, we were able to unregister
the call log's content observer and prevent this crash, but it's reshowing
itself in voicemail now.
Since the voicemail's observer is registered in the adapter and is unaware of
lifecycle changes, it's much more invasive to fix. So as a quick bandaid, we'll
just check that the parent isn't null.
Bug: 73972084
Test: n/a
PiperOrigin-RevId: 188812159
Change-Id: I533114de66b52395b0f3c90d4ec7a927c4df707f
|
|
My hypothesis is that there is a race condition where the call log changes and
we are leaving the activity before the content observer is unregistered or the
loader it starts is finished. This results in a callback calling #fetchCalls
while Dialer is in the background, resulting in a crash. This change will
confirm my hypothesis.
Even if my hypothesis is incorrect, we have similar checks throughout this
class which indicates to me that some issue exists here and that this check is
safe to do.
Bug: 73972084
Test: n/a
PiperOrigin-RevId: 187700318
Change-Id: I98cea86b5b7041c4f4aac09544445aaade6bfd40
|
|
- Never show the dialpad chooser in MainActivity.
- If the call log changed while dialer was in the background, it would trigger
the content observer to fetch the new info, which would request it's parent
that wasn't there. Now we register/unregister them in onResume/onPause. This
is safe to do because we force refresh the data onResume anyways, so any
changes will still be shown.
Bug: 73972084,73975555,73995512
Test: manual
PiperOrigin-RevId: 187407058
Change-Id: Iae86dabbcb852398bb2b9df4627e234261ab8030
|
|
Test: manual, going between tabs hides/shows the fab properly when ToS is (in)visible.
PiperOrigin-RevId: 187253210
Change-Id: Ied9ea44892786268b9dfa68816840dfbfc74aa6e
|
|
Bug: 73258376
Test: MainActivityOldPeerCallLogIntegrationTest
PiperOrigin-RevId: 187242222
Change-Id: Ic2684467035fedc1156886712757bf0911f65ee5
|
|
Bug: 69965302
Test: TAP
PiperOrigin-RevId: 186573663
Change-Id: I099f22b7a8df7018ec50e309b2ae37f3eedd76fd
|
|
Test: existing
PiperOrigin-RevId: 186413083
Change-Id: I96c88c46b0ecc01167b655fa30fc47aaa6a9e351
|
|
Bug: 70989667
Test: unit
PiperOrigin-RevId: 186410938
Change-Id: I0671ab0bbbe957b8f034c673e6309204284756d2
|
|
- No longer crashes when entering mw-mode while in multiselect
- Configuration changes now properly restore bottom nav visibility
- toolbar shadow is now only visible in search
Bug: 72525324
Test: MainActivityOldPeerSearchIntegrationTest
PiperOrigin-RevId: 186037379
Change-Id: I5fc00c8091e85fc67482b2131944fb776626d06f
|
|
Bug: 72618828
Test: existing
PiperOrigin-RevId: 183902491
Change-Id: I079aca188b52c29c12b3cae7e57bf71a4e883898
|
|
Test: Existing tests
PiperOrigin-RevId: 180230450
Change-Id: I0b2589cfeeaef81e42a04efa48af24b4e4d0e95f
|
|
Including when:
- onStop()
- switching tabs
Also move old CallLogActivityTest to espresso directory.
Test: CallLogActivityTest
PiperOrigin-RevId: 176387019
Change-Id: Icbb77747882c8a5e35595557baa6917a4dc674b6
|
|
app open
With this change we now only load the Favorites and Call Log Fragments when the
app opens.
Paging to the CallLogFragment makes the ContactsFragment load as we would want.
This should result in a faster app start time. I'll need to verify the impact
of this using the same method as http://cl/170422671
I verified the change in behavior by adding my own log line to the onCreate of each Fragment. I saw all of them get created before the change, and only the expected 2 with this change.
This change also fixes flaky test of voicemailTabVisibleNotVisible_volumeStreamCorrect.
Bug: 64541209,65460373,67297718
Test: DialtactsActivityIntegrationTest
PiperOrigin-RevId: 173734472
Change-Id: Ifd4a3064a6fdcffe5a373eaad6ee4aeebdadda1e
|
|
One of the biggest issues with the FAB is that it doesn't
scale in/out properly. It looked more like setVisibility was
being called instead. This CL migrates the FAB controller to
use the built in scale in/out methods #show and #hide and the
animation is much nicer.
Some of the other issues were:
- Now scaling animation is correct and visible.
- No longer flashes when going in/out of search.
- No longer shows on top of the return to call controller.
- No longer bugs when switching between VVM TOS and contacts.
- No longer shows FAB over VVM TOS when entering/exiting search
Bug: 62588192,35359563,64116334,27458212,37991480,67419607
Test: manual
PiperOrigin-RevId: 171608105
Change-Id: I9b3f61df35abf3659a432adf411b1b7d20eba683
|
|
after rotation
mCurrentPage is set onResume before the fragment is attached. In this CL, mCurrentPage is still used for page change, but for resume and pause, it is detected directly in CallLogFragment using getUserVisibleHint()
Bug: 65161134
Test: manual - change call volume after rotation, check ToS FAB not visible after rotation. CallLogFragment is not testable.
PiperOrigin-RevId: 169984576
Change-Id: I870cbe3b83e38ac2cb505193309ab4f8e75a859f
|
|
We think it's viewed by user if it's showing and user scrolls on call log tab,
since action in the same tab that moves the dialog is a strong proof.
Test: GoogleCallLogAdapterTest
PiperOrigin-RevId: 169763132
Change-Id: Ie520c65627b1e5d364860507321fb268c89e0cf7
|
|
Bug: 64129606
Test: none
PiperOrigin-RevId: 167174480
Change-Id: I4b5a494b0b334b42ee053c4d4d1e81d7699461d0
|
|
Previously, Android's Dialer app was developed in an internal Google
source control system and only exported to public during AOSP drops.
The Dialer team is now switching to a public development model similar
to the telephony team.
This CL represents all internal Google changes that were committed to
Dialer between the public O release and today's tip of tree on internal
master. This CL squashes those changes into a single commit.
In subsequent changes, changes will be exported on a per-commit basis.
Test: make, flash install, run
Merged-In: I45270eaa8ce732d71a1bd84b08c7fa0e99af3160
Change-Id: I529aaeb88535b9533c0ae4ef4e6c1222d4e0f1c8
PiperOrigin-RevId: 167068436
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC32
Branch: dialer-android_release_branch/153304843.1
dialer-android_20170416.00/dialer-android_20170416.00_RC32
This release contains the following bug fixes since RC17:
Bug: 33176679 33272455 3646510 36773894 37297649 37413780
37513689 37640315 37680595 37698062 37873639 37901752
37919295 37953423 38062852 38069600 38137349 38173549
38180252 38191514
Test: make, on device
Change-Id: I4e4bb630082758e418ff24892b7db3142c6eb09a
|
|
This release was created following the instructions at:
go/dialer-aosp-release
Subsequent dialer releases will follow as O bugs are
fixed, until we reach our final RC.
Version: 10
Candidate: RC16
Branch: dialer-android_release_branch/153304843.1
dialer-android/dialer-android_20170416.00/dialer-android_20170416.00_RC16
This release contains the following bug fixes since RC00:
Bug: 37324705 35304403 36067503 35304446 33203808 37280992
37346084 35766990 37481880 37424493 36470282 37347691
37519015 37168472 35805360 37545472 27704934 36515614
35766990 37577470 34739750 35801628 36788693 35264204
36708536 37628370 36904650 37314436 37642171 37530847
37637799 37666625 37548549 37648036 37636412 37323529
37630507 35919141 37198343 37548572 36178218 37640315
37663896 37720467 37275944 37710497 31634477 37744796
37348506 37744796 37568534 37672424 34872683 34873026
37681461 34873295 37748373 37526812 37618638 37663896
37536088 37727455 37165687 36651204 36900708 37323529
36902926 37256480 37328353 37432034 37436952 34093562
37720889 37321935 37780300 37781115 37755902 36588206
34258266 37290464 37698062 37618638 37473004 37432034
37918676 37870494 37722091
Test: make, on device
Change-Id: I99e1a484ccd578c1f8a13e7a6a4b4952f0791297
|
|
cl/152373142.
Test: make, treehugger
This CL updates the AOSP Dialer source with all the changes that have
gone into the private google3 repository. This includes all the
changes from cl/151342913 (3/27/2017) to cl/152373142 (4/06/2017).
This goal of these drops is to keep the AOSP source in sync with the
internal google3 repository. Currently these sync are done by hand
with very minor modifications to the internal source code.
See the Android.mk file for list of modifications.
Our current goal is to do frequent drops (daily if possible) and
eventually switched to an automated process.
Change-Id: I2fbc88cf6867b90ac8b65f75e5e34468988c7217
|
|
* Refactor voicemail component
* Add new enriched calling components
Test: treehugger, manual aosp testing
Change-Id: I521a0f86327d4b42e14d93927c7d613044ed5942
|
|
Test: Built package and system image.
This change clobbers the old source, and is an export
from an internal Google repository.
The internal repository was forked form Android in March,
and this change includes modifications since then, to
near the v8 release.
Since the fork, we've moved code from monolithic to independent modules. In addition,
we've switched to Blaze/Bazel as the build sysetm. This export, however, still uses make.
New dependencies have been added:
- Dagger
- Auto-Value
- Glide
- Libshortcutbadger
Going forward, development will still be in Google3, and the Gerrit release
will become an automated export, with the next drop happening in ~ two weeks.
Android.mk includes local modifications from ToT.
Abridged changelog:
Bug fixes
● Not able to mute, add a call when using Phone app in multiwindow mode
● Double tap on keypad triggering multiple key and tones
● Reported spam numbers not showing as spam in the call log
● Crash when user tries to block number while Phone app is not set as default
● Crash when user picks a number from search auto-complete list
Visual Voicemail (VVM) improvements
● Share Voicemail audio via standard exporting mechanisms that support file attachment
(email, MMS, etc.)
● Make phone number, email and web sites in VVM transcript clickable
● Set PIN before declining VVM Terms of Service {Carrier}
● Set client type for outbound visual voicemail SMS {Carrier}
New incoming call and incall UI on older devices
(Android M)
● Updated Phone app icon
● New incall UI (large buttons, button labels)
● New and animated Answer/Reject gestures
Accessibility
● Add custom answer/decline call buttons on answer screen for touch exploration
accessibility services
● Increase size of touch target
● Add verbal feedback when a Voicemail fails to load
● Fix pressing of Phone buttons while in a phone call using Switch Access
● Fix selecting and opening contacts in talkback mode
● Split focus for ‘Learn More’ link in caller id & spam to help distinguish similar text
Other
● Backup & Restore for App Preferences
● Prompt user to enable Wi-Fi calling if the call ends due to out of service and Wi-Fi is
connected
● Rename “Dialpad” to “Keypad”
● Show "Private number" for restricted calls
● Delete unused items (vcard, add contact, call history) from Phone menu
Change-Id: I2a7e53532a24c21bf308bf0a6d178d7ddbca4958
|