summaryrefslogtreecommitdiff
path: root/InCallUI
AgeCommit message (Collapse)Author
2015-04-30Video call upgrade/dowgrade request changes.Tyler Gunn
- fixed potential NPE in VideoCallFragment when setting preview size. - moved photo load into the postExecute for the async task -- it is already threaded and I was seeing intermittent concurrency issues. - Changed CallButtonFragment to retrieve max # of buttons from config.xml. - Added override for wider screens (e.g. N6 and wider) to show an extra button. - Reorganized call buttons so that the "Camera on/off" button is adjacent to the flip camera button. - Changed answer Glowpad to pass correct video state so that accepting a video request uses the correct state (important for accepting requests to turn camera back on). - added new Session modification state REQUEST_REJECTED for when the remote user explicitly declines the request. This is used to trigger a "video request rejected" message when the remote party rejects the request. Bug: 20257400 Change-Id: Ibe25eb045ee868748f91bf411f285629d36ebcd2
2015-04-29VT related cleanup.Anthony Lee
Removed some unused imports and one constant introduced by the mass QCOM CL for VT bringup. Bug: 20090311 Change-Id: Iab7a89495557c8817216ff16559778c6f59a3919
2015-04-27Fix memory leak: remove a listenerWei Huang
CallButtonPresenter doesn't remove itself from InCallPresenter.CanAddCallListener, which causes a memory leak. Change-Id: I3dcfc6aaa26eca3547e95de01b292042e46e30af
2015-04-27Merge "DO NOT MERGE Fix missing "manage conference" option." into m-wireless-devTyler Gunn
2015-04-27DO NOT MERGE Fix missing "manage conference" option.Tyler Gunn
- Corrected alignment of manage conference button. Bug: 20476139 Change-Id: I31be2f460cc298f6b210931dd670ab7fbc19866e
2015-04-24Merge "Upgrade / downgrade requests" into m-wireless-devTyler Gunn
2015-04-24Upgrade / downgrade requestsTyler Gunn
- Remove unnecessary "change to voice" button. - Remove "modify call option" dialog that showed up in the past when pressing the "upgrade to video button". - Cleaned up some unnecessary Toasts for call session events, data usage, and video quality - Implemented the camera on/off functionality. - Change preview to show the user's profile photo when their camera is turned off, as well as a "camera off" icon. Bug: 20257400 Change-Id: I6b7bb3d2394467f1345a798557130b2a674337c4
2015-04-22Incoming video calls - accept only 2-way calls.Tyler Gunn
- In AnswerPresenter, only show the video targets if the incoming call is a bi-directional video call. Bug: 20254835 Change-Id: I34f3fd79d126a2ae621afeb13ceb2b143bdca2ce
2015-04-20DO NOT MERGE Temporarily disable code that uses pluralsYorke Lee
Using plurals currently causes a ResourceNotFoundException because the translated counterparts for all languages must be submitted first. Temporarily disable this codepath. Bug: 20427882 Change-Id: I3a8c565bc704443fe1766e9311952481a25a2295
2015-04-20Merge "DO NOT MERGE Remove use of ttsSpanAsPhoneNumber" into m-wireless-devYorke Lee
2015-04-20DO NOT MERGE Remove use of ttsSpanAsPhoneNumberYorke Lee
This API is deprecated (and hidden) Change-Id: Ie1fe6ed8c2aff4288c41b15a95da45090009df4b
2015-04-20DO NOT MERGE Remove code disabling VT calls when TTY mode is onYorke Lee
To be moved into Telephony instead Bug: 20090652 Change-Id: I58aeb382d7e213b4eeae997d1f4bac3e25d34e67
2015-04-20Merge "DO NOT MERGE Stop using internal plural resources" into m-wireless-devYorke Lee
2015-04-20Merge "DO NOT MERGE Remove use of VideoProfile.VideoState.isVideo" into ↵Yorke Lee
m-wireless-dev
2015-04-18DO NOT MERGE Remove use of VideoProfile.VideoState.isVideoYorke Lee
Don't further increase API surface, make this a utility method in our own package instead. Change-Id: Ib7036b20980afcb5d0fdb1c03c6d943ab9d7ece7
2015-04-18DO NOT MERGE Stop using internal plural resourcesYorke Lee
Change-Id: I6ddd0555c56cdd3c5269ba435b14d4c26e015e22
2015-04-18DO NOT MERGE Update buttons state once UI is readyYorke Lee
* updateUi was not getting called for outgoing calls between DIALING -> ACTIVE * Adhere to UI directive that buttons representing disabled functionality are hidden rather than disabled. * Also fix issue where buttons are not updated for incoming call. Bug: 20295789 Change-Id: I2606aa7b27c3dfb2de441737f1ecc2cc80ffdd7e
2015-04-16DO NOT MERGE Don't make all buttons invisible at startupYorke Lee
Bug: 20298277 Change-Id: Ia5db30f2e8c359f10d45f02e765e2529cb2d0d5d
2015-04-16DO NOT MERGE Rename CallListener to CallCallback.Andrew Lee
To match API changes. Plus, random fixes because of master being out of sync with MW. Bug: 20160491 Change-Id: I664cb0c3db7e0affc42179d467828246887069e8
2015-04-17Merge "DO NOT MERGE Remove usage of Phone.java in InCallService APIs." into ↵Santos Cordon
m-wireless-dev
2015-04-16Merge "DO NOT MERGE Remove connection substate" into m-wireless-devJay Shrauner
2015-04-16DO NOT MERGE Remove usage of Phone.java in InCallService APIs.Santos Cordon
Start using the direct methods of InCallService instead of using the Phone object. InCallService methods represent the public API which is what In-Call needs to compile against. Bug: 20160495 Change-Id: I223347e239e5d5954b6118c7ba5befdaea2932a0
2015-04-16DO NOT MERGE Remove unused system properties importYorke Lee
Change-Id: I4659ef1232afeb6257b056135d123ecabf788d9b
2015-04-16DO NOT MERGE Remove connection substateJay Shrauner
Bug:20300433 Change-Id: Iec4a56229ee30f3183c9f4cf37bed3f028eed155
2015-04-16DO NOT MERGE Show video call button only for video calls or upgrade to videoYorke Lee
Bug: 20297465 Change-Id: Ied98faeece5079a6c000726b82244057b0422c92
2015-04-16Show IMS Conference StatusHints in InCall.Andrew Lee
automerge: 1838e77 * commit '1838e77845e2ba822bc7f510515b50cf00ddc2a4': Show IMS Conference StatusHints in InCall.
2015-04-16Merge "DO NOT MERGE Don't use internal resources in InCallUI" into ↵Yorke Lee
m-wireless-dev
2015-04-15DO NOT MERGE Fix Preconditions importJay Shrauner
Bug: Change-Id: I5f4c347f83a97478fd76e10a4b0a88a1d7f14d95
2015-04-15DO NOT MERGE Don't use internal resources in InCallUIYorke Lee
Bug: 20090407 Change-Id: Id0e90507fe9d45545ed3774521bac68eb0bda8a7
2015-04-15DO NOT MERGE Suffix VT_LOCAL/REMOTE with BIDIRECTIONAL.Andrew Lee
Bug: 20160395 Change-Id: Ifa4b991cfe312a0bdff9be5d25c0c225f264b5c2
2015-04-15Show IMS Conference StatusHints in InCall.Andrew Lee
A lot of this logic for figuring out what label should be shown seems like it should be determined in the presenter, rather than passing through all this information to the fragment, but it can be cleaned up at another time. + minor layout tweak. Bug: 20181703 Change-Id: I392ce7cffc8c05eb94859892e899ce7c693895aa
2015-04-15Merge "DO NOT MERGE Follow TelecomManager API changes" into m-wireless-devYorke Lee
2015-04-14DO NOT MERGE Remove unused reference for unbundlingJay Shrauner
Bug: Change-Id: If82e3e0c1941ea8a0d39d853e332c19ea6950bdb
2015-04-14DO NOT MERGE Don't use AudioState.ROUTE_ALLJay Shrauner
For supported audio methods, explicitly construct a combination of known supported routes. Bug: Change-Id: Iee67a08370c8dc584106493bc751c9ac8e341198
2015-04-14DO NOT MERGE Follow TelecomManager API changesYorke Lee
Bug: 20160799 Change-Id: I47d4f5e511b59ecf5357f62a36144763c90d1246
2015-04-14Adding missing null-check.Tyler Gunn
Bug: 19850018 Change-Id: I17e1ac4c91fbf91ce53ab6a111aed854f8e4116e
2015-04-14Merge "DO NOT MERGE Use proximity wake lock in InCallUI" into m-wireless-devYorke Lee
2015-04-14DO NOT MERGE Use proximity wake lock in InCallUIYorke Lee
Bug: 20160495 Change-Id: I086e46360b72afc7a1db5e4fc4dde12f12b963ae
2015-04-13Fix orientation of preview surface when device rotated.Tyler Gunn
- Cleaned up some unused methods in InCallActivity. - In onDeviceOrientationChanged, handle orientatoin change by resizing surface. - Fixed setPreviewSize which was not rotating the surface the appropriate way (ensured it was setting a transform on the surface, and also made sure that the correct dimensions were being passed in). Bug: 19850018 Change-Id: Ia9324ce6bad5a797839e69ba20244f2bcc44acb5
2015-04-13Merge "Always allow landscape mode if video call is the primary call" into ↵Yorke Lee
m-wireless-dev
2015-04-13Always allow landscape mode if video call is the primary callYorke Lee
Bug: 19995709 Change-Id: Ie21b50bf8ed34b0c50463285104e59271c94b12e
2015-04-13Video calling landscape changes to match specsYorke Lee
* Call card has 4dp corners, and is 90% visible * Margins for call card * Call buttons are center aligned with end call button * Remote surface is always center aligned, tapping call card slides it in and out * Status bar is black Bug: 19668216 Change-Id: Ifea27faa5f8ff32f6be13e777ca70aa4d0c7727e
2015-04-13Merge "Simplify and rewire in-call buttons" into m-wireless-devYorke Lee
2015-04-13Simplify and rewire in-call buttonsYorke Lee
* Fix bug where the switch camera option was never shown * Fix bug where dialpad button was shown for video calls * Move management of call button's actual visiblity into the CallCardFragment. The CallCardPresenter is in charge of deciding what functionality is available, but the CallCardFragment manages the actual UI that is displayed. * Simplify code that collapses call button functionality into the overflow button. Any buttons that would cause the total number of buttons to exceed the given threshold will be collapsed into an overflow menu. * Dynamically toggle the contentDescription of the hold button. This is used for both accessibility as well as generating the menu option if the button is collapsed into the overflow menu * Removed some now unused strings and code. Bug: 20127747 Bug: 20127925 Bug: 20090502 Change-Id: I33fda7ad74af926d8c3a507bff8f3c69c19ea57e
2015-04-13Hide incoming video until call is connected.Tyler Gunn
Changing the VideoCallPresenter so that the incoming video surface is hidden until the call becomes active. This way the remote party's profile picture is shown until the call is connected. Bug: 19820114 Bug: 20153678 Change-Id: Ifb1eeab2dc92ccd54c070248bd4efb44a113fed3
2015-04-10Merge "Cleanup AnswerFragment glowpad UI" into m-wireless-devYorke Lee
2015-04-10Merge "Initial refactoring for call buttons" into m-wireless-devYorke Lee
2015-04-10Initial refactoring for call buttonsYorke Lee
Create common functions to show/enable call buttons Bug: 20127747 Change-Id: I22d45597a73a75954448cb3bd5b906af06d7d690
2015-04-10Hide end call button when video upgrade glowpad is showingYorke Lee
Bug: 20090411 Change-Id: I25bca70e2e2a40bbd88b55ba386d39cd796cb414
2015-04-10Cleanup AnswerFragment glowpad UIYorke Lee
* For incoming video requests, only show answer as video, answer as audio, or reject * For upgrade requests, only show upgrade to video, don't upgrade to video * Nuke unused tx/rx only assets Bug: 20090411 Change-Id: I51093bb702981256809020908442eb98b0d17606
2015-04-09Show progress spinner when upgrading to videoYorke Lee
Show spinner when waiting for remote consent. Also correctly propagate sessionModification state when downgrading to audio. Bug: 20090442 Change-Id: If733ce99683436c751a26a6511e6a41bac637c30
2015-04-09Merge "Cleanup of Video Call pause functionality." into m-wireless-devTyler Gunn
2015-04-08Standardize fragment layout namesYorke Lee
Change-Id: I76814eb5b90130227eea8e2f8576c472b80d1435
2015-04-08Adding video call icon in secondary call info.Tyler Gunn
- Icon indicates that a call is a video call. Per mocks. Bug: 20119995 Change-Id: Ibccfccaa3f2762659282bbde433796fe20da361c
2015-04-08Cleanup of Video Call pause functionality.Tyler Gunn
Whether the paused videoState is available is dependent on the carrier's implementation of the VT spec. The original VT implementation assumed that this was stored in a system property accessed via InCall; these CLs move this to a Call/Connection capability which will ultimately support multisim video capable devices. - Made some general cleanups in VideoPauseController (comments, some minor logic changes, renamed a few methods). - Removed access of system property to see if pause is supported and instead key in on the call capability. - Changed video call presenter to hide incoming video surface when a pause signal is received. Bug: 16680364 Bug: 19820114 Change-Id: I6d1a7789925c69e4022846f8d847b8bb1274c06b
2015-04-07Simplify InCall notification logicYorke Lee
Always show the InCall notification iff there is a live call (incoming, outgoing, active or held). Change-Id: I2fc2a54c92cd0978dcf1bf49b0e8217bf2acc3ec Bug: 20108489
2015-04-06Merge "Finish InCallActivity immediately for DisconnectCause.ERROR" into ↵Yorke Lee
m-wireless-dev
2015-04-06Finish InCallActivity immediately for DisconnectCause.ERRORYorke Lee
For DisconnectCause.ERROR, finish InCallActivity immediately instead of waiting for the 5s timeout. This is because a dialog is always shown for error cases, so the activity should finish as soon as the user acknowledges the dialog. Change-Id: I87d8cb9c0b7dabb20ed41b0ade13534a56a7a216
2015-04-06DO NOT MERGE Fix crash when rotating video fragmentYorke Lee
Due to a recent framework change, https://googleplex-android-review.git.corp.google.com/#/c/659363/ TextureView will now crash if setSurfaceTexture is called before the TextureView is attached to the window. Use an OnAttachStateListener to call setSurfaceTexture only after the view is attached to the window. Cherry-pick from https://us2-mirror-googleplex-android-review.googlesource.com/#/c/666312/1 Bug: 20071288 Change-Id: I8c443542db6f4a432a097326fdb49607baa55889
2015-03-26IMS-VT: Add support for video callsRekha Kumar
IMS-VT: Upgrade downgrade and hold resume video calls -Add support for upgrade downgrade video calls. -Add support for hold resume and call waiting IMS-VT: Fixed surface caching. Fixed surface caching. IMS-VT: Fixes InCallUI/Dialer crash when there is a VT call. -Fixes InCallUI/Dialer crash when UE is rotated. -Fixes InCallUI/Dialer crash when UE VoLTE call is upgraded to VT. Don't default to speaker phone for VT when speaker is disabled - The adb property persist.radio.ims.audio.output indicates whether speaker is disabled explicitly or not. - If the above property is set to 1, don't enable speaker phone by default in VT call. IMS-VT: Fix CVO, surface and resource related issues. - Send initial orientation to VT Service. - Detect if Activity is being destroyed due to confugration changes. - Close the camera when InCallUI is pushed to background. - Fix surface and VT service related issues when Fragment and Presenter gets destroyed. IMS-VT: Peer Resolution Feature Implementation Change display video size based on peer resolution values received from far end. IMS-VT: Answering calls and upgrade requests as VT_TX and VT_RX -Support for showing one way options for incoming upgrade request -Fix issue where incoming video popup stays on screen even after rejecting the request. -Fix issue where incoming video popup stays on even after it has been timed out by lower layers. - Answer with different calltypes support. Notify listeners of video quality changed event and display message on UI - Add methods to notify listeners of type VideoEventListener when video quality changes. - Display a notification on the UI when video quality changes. IMS-VT: Enable SIP based video multitasking. Enable SIP based video multitasking. IMS-VT: Call data usage feature - Add support for call data usage callback - Request for call data usage stats - Log call data usage stats when IMS layers send update Change-Id: I3f0dde0d82698085fa5d3f110720f10326eca768 IMS-VT: When TTY is ON, do not allow upgrade to VT call When TTY mode is ON, the user SHOULD NOT be allowed to upgrade a call from VOLTE to VT/VT-TX/VT-RX and an UI alert message will be displayed explaining upgrade to VT call cannot be initiated. IMS-VT: Add null check in call upgrade fail scenario Crash is observed if call is ended in the interval wherein handler is started to change state from REQUEST_FAILED to NO_REQUEST after an interval. Added null check to change state only when call exists Propagate call substate message and display a notification on the UI Ims: Reject upgrade request 1. If there is waiting call that is pending user action and 2. Before offering a waiting call IMS-VT: Provide Player State indication to user. Change to display "player started/stopped" toast message whenever video starts/stops flowing IMS-VT: Cleanup video views when not required - Hide video views when not required. Set display size as per current TextureView size - Using TextureView height and width to calculate the display size. - When ever there is change in display make sure that center the display. IMS-VT: Exit VT call full screen mode. If the call is no longer a VT call, then exit full screen mode Change-Id: Ibc4ad8f9a4c38e467820028cdc2c7e68d65fd93c CRs-Fixed: 760925 IMS-VT: Upgrade button fix -Show upgrade/downgrade button only when call is in ACTIVE or ONHOLD state IMS-VT: Show correct call types during video pause -In paused state, upgrade downgrade button does not list the calltypes dropdown box -Remove the paused bit to calculate call type during video paused state. IMS-VT: Move strings for video quality changed indication to resource files IMS-VT: Clean up the showCallSubstateChanged API - Make the code more readable. IMS-VT: Set audio route to Speaker if current route is not bluetooth or headset - We always set the audio route to speaker when we enter video mode. - That is not correct. We should check if headset or bluetooth is connected before defaulting to speaker. IMS-VT: Turn speaker on/off for video calls based on call state changes - Turn speaker on only when video call is active or dialing - Switch back to the previous audio mode when there are no more calls - Make the previous audio mode static so that information persists when the class is recreated (e.g. when UE is rotated or multitasking happens) IMS-VT: Use back camera instead of front camera for VT-TX Set back camera for below cases 1) VOLTE to VT-TX 2) VT to VT-TX 3) Waiting call over Vt-TX call. IMS-VT: Fix upgrade in call waiting scenarios -When one VoLTE call is active and another VoLTE call is on hold and upgrade button is hit, call ends. Fix this upgrade issue. IMS-VT: Enter video mode when the primary video call changes - We only enter video mode when we have any video state changes - Enter video mode should also be called when the video call changes. e.g. When we have a second call with the same video state, we don't enter video mode which is incorrect. This change fixes the issue Add null check for InCallActivity in setInCallAllowsOrientationChange - In some cases, this API is called when InCallActivity is null. This causes a null pointer exception. Fix is to add a null check. IMS-VT: Fix check for VOLTE call (AND to OR) when turning speaker on IMS-VT: Check if call is video before enabling speaker in updateAudioMode - Moved the video call check to the correct block where we are enabling speaker IMS-VT: Get call substate values correctly from the bit mask - We were getting the call substate incorrectly as an int. - Fixed that by getting it from the bit mask and using the possible multiple values to display the call substate message. IMS-VT: Keep the screen on during video calls. UI screens times out after some time. During video calls the screen must be kept on. Change-Id: Icaa8662210b2dd323b29f4a472869a9ed1e01d00 IMS-VT: Open front facing camera for VT calls. Open front facing camera for VT calls. IMS-VT: Show manage conference button for Video Call - We show the manage conference in a separate section for VOLTE Calls. - In the case of Video Call, the entire screen is occupied by the far end video. So we display manage conference in the overflow section of the call button fragment. IMS-VT: Fix camera preview freeze for CONF video calls. Fix camera preview freeze for CONF video calls. IMS-VT: Move persist.radio.ims.audio.output to frameworks Move persist.radio.ims.audio.output and related constants to TelephonyProperties and PhoneConstants so that these can be accessed from multiple git projects instead of redefining. IMS-VT: Multiple video call fixes/optimizations. -Current implementation clears primary call cache upon exiting video mode. This will remove video call provider interface as well, which will prevent further communication with the backend. Don't clear primary call cache upon exiting video mode. -Unregister call details listener when UI transitions into unready state -Send surface of incoming video to video call provider before opening camera. IMS: Cleanup all listener objects Clean all stale listener objects to avoid the memory leak. IMS: Fix speaker icon display issue in Call UI. In few devices, InCall UI can show upto five buttons in a row. Modify code to display at most five buttons in a row. Show overflow menu if number of buttons is more than five. IMS-VT: Show glowpad view with accept/reject for most video upgrade cases - Show the glowpad view with all options only when upgrading from Volte to VT - For all other cases, show the glowpad with accept/reject only Change-Id: I41ecbda40db7c3c69428fc4272f8bfbd258e2980
2015-03-25Don\'t show SSID for Wi-Fi calls.Andrew Lee
automerge: 1a3d05d * commit '1a3d05dc126773f0e0d32135f9b1018f1a4c8b5e': Don't show SSID for Wi-Fi calls.
2015-03-24Don't show SSID for Wi-Fi calls.Andrew Lee
- Delete wifi icon and method to get SSID. + Use labels provided by StatusHints instead. I'm not very happy with the additional "isWifi" cases I ended up adding in call card fragment. I felt this was necessary because of assumptions in some cases that if a label is provided, it should be formatted as a phone account source. While this was true before, it's becoming less so. I feel like the fragment shouldn't have to worry about formatting or choosing the label based on the call and conditions. It should just display the label if it thinks it is appropriate to show a label given the call state. To fix that, it seems like logic should be moved to the presenter instead, and possibly to Telephony. But, I'm hesitant to do that until these WFC changes back merge to master because of potential merge conflicts and its slightly more risky for this branch, because it starts dealing with logic/flows outside of WFC.. Bug: 19866988 Change-Id: Iacd5a09259c84ea7be28b0170ae603eb9561f7ca
2015-03-20DO NOT MERGE Don't hide caller photo for video callYorke Lee
Bug: 19728020 Change-Id: I6e5259c63553de9e5060621bcc749d1039b67ea1
2015-03-19Finish activity before reveal if not setup.Andrew Lee
automerge: c5722b4 * commit 'c5722b4638a4807a3accbd85822eeb7c09973c44': Finish activity before reveal if not setup.
2015-03-19Finish activity before reveal if not setup.Andrew Lee
This seems to be happening because it tries to start the circular reveal before the InCallPresenter has been configured to start a call. This is an error case; finish the activity to try to resolve it more gracefully. Bug: 19719403 Change-Id: I83240b88b7015d8709d5b4cb56a099a68c9c15ca
2015-03-13Video Call Upgrade/Downgrade fixesMatthieu Baglin
This is fixing multiple deficiencies affecting video call upgrade or downgrade in the L MR1 InCallUi. Change-Id: I61bf7efa6ac23859c900dfd059faf72184987943 Signed-off-by: Matthieu Baglin <matthieu.baglin@intel.com>
2015-03-11Fix emergency callback number not shown for incoming calls.Tyler Gunn
- In CallCardPresenter#setCallbackNumber() check for the case where a call has CAPABILITY_SHOW_CALLBACK_NUMBER. Use this to trigger showing the Emergency Callback Number (the ECM is only shown on outgoing calls if the user has a dark number). Bug: 18689292 Change-Id: I94391e3be3360982742ce961272b680d0eaa32a5
2015-03-11Correct capitaliztion of "wi-fi" to "Wi-Fi".Andrew Lee
automerge: 5f2de0f * commit '5f2de0f118c1b40ebbd4329c66722f907c396163': Correct capitaliztion of "wi-fi" to "Wi-Fi".
2015-03-11Correct capitaliztion of "wi-fi" to "Wi-Fi".Andrew Lee
Change-Id: I4ce0898dbae20ac26d1e12db9e9aa094c537e230
2015-03-11Indicate wifi for incoming calls.Andrew Lee
automerge: 6c5be77 * commit '6c5be778579619d055f6d12f381a63568bd8270d': Indicate wifi for incoming calls.
2015-03-10Indicate wifi for incoming calls.Andrew Lee
This is done in the call card by showing the wifi icon. This is done in the notification, by change the subtext. For international calls in particular, this helps users understand how accepting a phone call will affect the cost of their call. Change-Id: Ifebd9f9cc8598b7fe5b693673b27a485f7ecdf0f
2015-03-10InCallUi basic video call fixesMatthieu Baglin
This patch resolves some issues in video call establishment on L MR1 InCallUi. Change-Id: Ib72894f7e81932200b09b9995d169ef1124fc5b5 Signed-off-by: Matthieu Baglin <matthieu.baglin@intel.com>
2015-03-09Set the camera to null when preview surface is destroyedMatthieu Baglin
When the video call is disconnected, the camera would still be opened without this fix. Signed-off-by: Matthieu Baglin <matthieu.baglin@intel.com> Change-Id: Ie69fb87412c53e4c6072d998d3e3b067c4c8ba0f
2015-02-18Show icon and network label when using Wifi.Andrew Lee
+ Add Wifi icon and network label, to be shown when CAPABILITY_WIFI is present on the primary call. Assume we can infer the network label from the connection info returned by the WifiManager, supposing that the phone can only be connected to one wifi network. + Add helper to strip quotation marks from wifi network name. + Reposition HD audio icon beneath the name, and to the left of the number/location information. + Adjust assets and layout of call state and hd audio icons, to center them in a more visually pleasing way in the view. Bug: 19151850 Change-Id: Ic23d1e744960e80b65bc34a8e709266af508fe21
2015-01-26Merge "Hide emergency callback number when slot2 SIM is default." into ↵Nancy Chen
lmp-mr1-dev
2015-01-24Hide emergency callback number when slot2 SIM is default.Nancy Chen
Because emergency calls are always made from the SIM in slot1, when slot2 has the SIM set for default outgoing call, the InCallUI currently thinks the emergency callback number is different from the number being called from (the code only uses the default number). The fix is to check the line 1 number of the phone account being used instead of the default phone account. Bug: 19087382 Change-Id: I90a096f63493affea979689c7ad188eec7109c08
2015-01-22Merge "Ensure sim color is shown on multi-sim devices when only one sim ↵Tyler Gunn
installed." into lmp-mr1-dev
2015-01-20Merge "Remove padding from call buttons to fix undesired cropping." into ↵Nancy Chen
lmp-mr1-dev
2015-01-19Import translations. DO NOT MERGEGeoff Mendal
Change-Id: I489439c981d6dca20352208406491bcfdfd89354 Auto-generated-cl: translation import
2015-01-16Remove padding from call buttons to fix undesired cropping.Nancy Chen
Padding was added to the sides of the call button row in order to prevent false touches. However, this additional padding causes cropping of the background on the two buttons on the far left and far right when all 5 buttons are present on low resolution devices. Since on high resolution devices there is more than enough extra space on the left and right, this padding is being removed to eliminate cropping. Bug: 18122087 Change-Id: Ie948d9cbe4ef7025702ae1f4666354ab1be76bbc
2015-01-13Improve call button accessibility.Andrew Lee
+ Convert Audio Button into a ToggleButton, and update its content description depending on whether its acting as a toggle for speakerphone, or if it's acting as a menu button to select from more than two audio output modes. + Set custom style on ToggleButtons with null background, to override the default ToggleButton styling which was causing shadows. - Delete CallToggleButton, which did some hacky things with the content description and accessibility. - Delete helper method which abused TYPE_ANNOUNCEMENTS. Rely on default TalkBack behavior for ToggleButtons to read on click. - Delete unused accessibility strings. The states these were formerly read out for will now be handled by a combination of button labels and default TalkBack behavior. The UI (without TalkBack) behaves the same after these changes. The behavior with TalkBack after these changes is that the audio (when toggling for speakerphone), mute, and hold buttons will generally read "speaker/mute/hold button (not) checked" when explored by touch depending on their state. They will read "speaker/mute/hold" when clicked. If more than two audio modes are supported, the audio button will read "<mode> button checked", where <mode> can be speaker, bluetooth, handset, or earpiece. When clicked, it will open the audio pop up menu and read that there are # options displayed on the screen. This is combines the ToggleButton and PopupMenu Talkback behavior, since this is a custom widget. Bug: 18783204 Change-Id: I27363c697bb018b5f87ad2e27678f8db6d93b2e7
2015-01-09Merge "Tidy up text alignments for secondary call info." into lmp-mr1-devAndrew Lee
2015-01-09Tidy up text alignments for secondary call info.Andrew Lee
This fixes bad alignment in RTL languages. Bug: 18009146 Change-Id: I8691b5e017363158c6933f4b4e55c2c16ca3a2ac
2015-01-09[DS] Fix a bug about Sip incoming call screen do not show.Mick Lin
For buganizer #18847828 Dismiss the conference management screen when call incoming. Change-Id: I470d059ae69a5a54b54de6be12b4fe335c23b8f1
2015-01-08Merge "Fixing Null Pointer exception due to uninitialized view reference." ↵Tyler Gunn
into lmp-mr1-dev
2015-01-08Fixing Null Pointer exception due to uninitialized view reference.Tyler Gunn
Bug indicates a crash occurred when trying to separate a call from a conference call. The exception thrown was due to calling "setText" on mSecondaryCallProviderLabel when it was null. Although I was not able to reproduce this situation, it appears it would be possible for showAndInitializeSecondaryCallInfo to not set the mSecondaryCallProviderLabel reference when then mSecondaryCallName is initially set if the hasProvider flag is false at the time. If hasProvider becomes true in the future since mSecondaryCallName is already initialized, the code to initialize mSecondaryCallProviderLabel would not run, causing the NPE. I have restructured the code to ensure that this type of scenario is handled appropriately. Bug: 18917883 Change-Id: I837d96aad7ed98729490d95beb897b08e1b08365
2015-01-07Read enabled/disabled state for InCall buttons.Andrew Lee
+ Add CallToggleButton which ignores the content description so that we can substitue our own strings to be read by Talkback when the user clicks on buttons. + Convert ImageButtons with two states into ToggleButtons, so that when focused Talkback automatically reads out their states. For example, now it will read "Mute switch is (not) checked". This required updating some casts and references in the fragment. + Set baselineAligned property for call buttons to false. Because ToggleButtons could have text, it was attempting to align by text baselines which messed with the layout. - Remove a compound button listener which is not used. Bug: 18783204 Change-Id: I0b23f5f63a2bf7c34a34077a75a23ea92dc45bbc
2015-01-07Merge "Announce incoming calls in all cases" into lmp-mr1-devIhab Awad
2015-01-05Ensure sim color is shown on multi-sim devices when only one sim installed.Tyler Gunn
- Removed telecomManager check hasMultipleCallCapableAccounts() which would only return 1 when a single sim is installed in a multisim phone. - For single-sim devices, the Sim color is 0 (ie not selected) for the Sim PhoneAccount, so the default behavior is to not show a sim color. Bug: 18696518 Change-Id: I3968e181a41244092d2058fcf3dc8d627d12b412
2014-12-30Merge "Call duration should be verbalized as hours, minutes, seconds." into ↵Nancy Chen
lmp-mr1-dev
2014-12-23Call duration should be verbalized as hours, minutes, seconds.Nancy Chen
Currently the call duration in the InCallUI is read as a time. It should be read in terms of hours, minutes, seconds. Updated contentDescription to match this specification. Bug: 18761699 Change-Id: I5b6eded63471c905638e05a5b5336403568f77e9
2014-12-23Merge "Minor UI tweak" into lmp-mr1-devYorke Lee
2014-12-22Announce incoming calls in all casesIhab Awad
Bug: 18797453 Change-Id: I81d75a145db9303cd77cb0bc14abaed788f0c5b8
2014-12-22Merge "Add haptic vibration feedback on in-call buttons." into lmp-mr1-devSantos Cordon
2014-12-22Minor UI tweakYorke Lee
Change-Id: I37c1132d06264c3e8cdbbf181fe274cd26a99c80
2014-12-19Merge "Show error dialog and end call for service not supported error" into ↵Yorke Lee
lmp-mr1-dev
2014-12-18Add haptic vibration feedback on in-call buttons.Santos Cordon
For buttons which appear an first-class actions in the in-call screen, add haptic feedback. This feedback ignores the system settings, meaning that it vibrates when buttons are touched regardless of the system settings for vibrating on keypress. Bug: 18388068 Change-Id: Ifadc973af9bcdfdfdc9d51b1c927b08d93714a58
2014-12-18Show error dialog and end call for service not supported errorYorke Lee
Add another condition for which InCallActivity is launched so that it can disconnect the call and show the error dialog. Slight refactor of code that checks if a call has valid accounts so that it can be shared. Bug: 18781230 Change-Id: I83a9c4ee30f2a80168f3244f4929f70aa46b9d83
2014-12-17Always animate drawables when given animationsEvan Charlton
When given an animated drawable, always animate it, rather than only when the call isn't connected. Bug: 18695179 Change-Id: Ia9b320e2f5f47ee7fdfb489b91c736912dcdfd16
2014-12-17Merge "Add phone number annotations for TalkBack" into lmp-mr1-devIhab Awad