| Age | Commit message (Collapse) | Author |
|---|
|
automerge: 1a3d05d
* commit '1a3d05dc126773f0e0d32135f9b1018f1a4c8b5e':
Don't show SSID for Wi-Fi calls.
|
|
- Delete wifi icon and method to get SSID.
+ Use labels provided by StatusHints instead.
I'm not very happy with the additional "isWifi" cases I ended up
adding in call card fragment.
I felt this was necessary because of assumptions in some cases
that if a label is provided, it should be formatted as a phone
account source. While this was true before, it's becoming less so.
I feel like the fragment shouldn't have to worry about formatting
or choosing the label based on the call and conditions. It should
just display the label if it thinks it is appropriate to show a
label given the call state.
To fix that, it seems like logic should be moved to the presenter
instead, and possibly to Telephony. But, I'm hesitant to do that
until these WFC changes back merge to master because of potential
merge conflicts and its slightly more risky for this branch,
because it starts dealing with logic/flows outside of WFC..
Bug: 19866988
Change-Id: Iacd5a09259c84ea7be28b0170ae603eb9561f7ca
|
|
Bug: 19728020
Change-Id: I6e5259c63553de9e5060621bcc749d1039b67ea1
|
|
automerge: c5722b4
* commit 'c5722b4638a4807a3accbd85822eeb7c09973c44':
Finish activity before reveal if not setup.
|
|
This seems to be happening because it tries to start the circular
reveal before the InCallPresenter has been configured to start a
call. This is an error case; finish the activity to try to resolve
it more gracefully.
Bug: 19719403
Change-Id: I83240b88b7015d8709d5b4cb56a099a68c9c15ca
|
|
This is fixing multiple deficiencies affecting video call upgrade or
downgrade in the L MR1 InCallUi.
Change-Id: I61bf7efa6ac23859c900dfd059faf72184987943
Signed-off-by: Matthieu Baglin <matthieu.baglin@intel.com>
|
|
- In CallCardPresenter#setCallbackNumber() check for the case where a call
has CAPABILITY_SHOW_CALLBACK_NUMBER. Use this to trigger showing the
Emergency Callback Number (the ECM is only shown on outgoing calls if the
user has a dark number).
Bug: 18689292
Change-Id: I94391e3be3360982742ce961272b680d0eaa32a5
|
|
automerge: 5f2de0f
* commit '5f2de0f118c1b40ebbd4329c66722f907c396163':
Correct capitaliztion of "wi-fi" to "Wi-Fi".
|
|
Change-Id: I4ce0898dbae20ac26d1e12db9e9aa094c537e230
|
|
automerge: 6c5be77
* commit '6c5be778579619d055f6d12f381a63568bd8270d':
Indicate wifi for incoming calls.
|
|
This is done in the call card by showing the wifi icon.
This is done in the notification, by change the subtext.
For international calls in particular, this helps users understand
how accepting a phone call will affect the cost of their call.
Change-Id: Ifebd9f9cc8598b7fe5b693673b27a485f7ecdf0f
|
|
This patch resolves some issues in video call establishment
on L MR1 InCallUi.
Change-Id: Ib72894f7e81932200b09b9995d169ef1124fc5b5
Signed-off-by: Matthieu Baglin <matthieu.baglin@intel.com>
|
|
When the video call is disconnected, the camera would still
be opened without this fix.
Signed-off-by: Matthieu Baglin <matthieu.baglin@intel.com>
Change-Id: Ie69fb87412c53e4c6072d998d3e3b067c4c8ba0f
|
|
+ Add Wifi icon and network label, to be shown when CAPABILITY_WIFI
is present on the primary call. Assume we can infer the network label
from the connection info returned by the WifiManager, supposing that
the phone can only be connected to one wifi network.
+ Add helper to strip quotation marks from wifi network name.
+ Reposition HD audio icon beneath the name, and to the left of the
number/location information.
+ Adjust assets and layout of call state and hd audio icons, to
center them in a more visually pleasing way in the view.
Bug: 19151850
Change-Id: Ic23d1e744960e80b65bc34a8e709266af508fe21
|
|
lmp-mr1-dev
|
|
Because emergency calls are always made from the SIM in slot1, when
slot2 has the SIM set for default outgoing call, the InCallUI currently
thinks the emergency callback number is different from the number being
called from (the code only uses the default number). The fix is to check
the line 1 number of the phone account being used instead of the default
phone account.
Bug: 19087382
Change-Id: I90a096f63493affea979689c7ad188eec7109c08
|
|
installed." into lmp-mr1-dev
|
|
lmp-mr1-dev
|
|
Change-Id: I489439c981d6dca20352208406491bcfdfd89354
Auto-generated-cl: translation import
|
|
Padding was added to the sides of the call button row in order to
prevent false touches. However, this additional padding causes cropping
of the background on the two buttons on the far left and far right when
all 5 buttons are present on low resolution devices. Since on high
resolution devices there is more than enough extra space on the left and
right, this padding is being removed to eliminate cropping.
Bug: 18122087
Change-Id: Ie948d9cbe4ef7025702ae1f4666354ab1be76bbc
|
|
+ Convert Audio Button into a ToggleButton, and update its content
description depending on whether its acting as a toggle for
speakerphone, or if it's acting as a menu button to select from
more than two audio output modes.
+ Set custom style on ToggleButtons with null background, to override
the default ToggleButton styling which was causing shadows.
- Delete CallToggleButton, which did some hacky things with the
content description and accessibility.
- Delete helper method which abused TYPE_ANNOUNCEMENTS. Rely on
default TalkBack behavior for ToggleButtons to read on click.
- Delete unused accessibility strings. The states these were formerly
read out for will now be handled by a combination of button labels
and default TalkBack behavior.
The UI (without TalkBack) behaves the same after these changes.
The behavior with TalkBack after these changes is that the audio
(when toggling for speakerphone), mute, and hold buttons will
generally read "speaker/mute/hold button (not) checked" when
explored by touch depending on their state. They will read
"speaker/mute/hold" when clicked.
If more than two audio modes are supported, the audio button will
read "<mode> button checked", where <mode> can be speaker, bluetooth,
handset, or earpiece. When clicked, it will open the audio pop up
menu and read that there are # options displayed on the screen. This
is combines the ToggleButton and PopupMenu Talkback behavior, since
this is a custom widget.
Bug: 18783204
Change-Id: I27363c697bb018b5f87ad2e27678f8db6d93b2e7
|
|
|
|
This fixes bad alignment in RTL languages.
Bug: 18009146
Change-Id: I8691b5e017363158c6933f4b4e55c2c16ca3a2ac
|
|
For buganizer #18847828
Dismiss the conference management screen when call incoming.
Change-Id: I470d059ae69a5a54b54de6be12b4fe335c23b8f1
|
|
into lmp-mr1-dev
|
|
Bug indicates a crash occurred when trying to separate a call from a
conference call. The exception thrown was due to calling "setText" on
mSecondaryCallProviderLabel when it was null.
Although I was not able to reproduce this situation, it appears it would
be possible for showAndInitializeSecondaryCallInfo to not set the
mSecondaryCallProviderLabel reference when then mSecondaryCallName is
initially set if the hasProvider flag is false at the time. If
hasProvider becomes true in the future since mSecondaryCallName is already
initialized, the code to initialize mSecondaryCallProviderLabel would not
run, causing the NPE.
I have restructured the code to ensure that this type of scenario is
handled appropriately.
Bug: 18917883
Change-Id: I837d96aad7ed98729490d95beb897b08e1b08365
|
|
+ Add CallToggleButton which ignores the content description so that
we can substitue our own strings to be read by Talkback when the user
clicks on buttons.
+ Convert ImageButtons with two states into ToggleButtons, so that
when focused Talkback automatically reads out their states. For
example, now it will read "Mute switch is (not) checked". This
required updating some casts and references in the fragment.
+ Set baselineAligned property for call buttons to false. Because
ToggleButtons could have text, it was attempting to align by text
baselines which messed with the layout.
- Remove a compound button listener which is not used.
Bug: 18783204
Change-Id: I0b23f5f63a2bf7c34a34077a75a23ea92dc45bbc
|
|
|
|
- Removed telecomManager check hasMultipleCallCapableAccounts() which would
only return 1 when a single sim is installed in a multisim phone.
- For single-sim devices, the Sim color is 0 (ie not selected) for the
Sim PhoneAccount, so the default behavior is to not show a sim color.
Bug: 18696518
Change-Id: I3968e181a41244092d2058fcf3dc8d627d12b412
|
|
lmp-mr1-dev
|
|
Currently the call duration in the InCallUI is read as a time. It should
be read in terms of hours, minutes, seconds. Updated contentDescription
to match this specification.
Bug: 18761699
Change-Id: I5b6eded63471c905638e05a5b5336403568f77e9
|
|
|
|
Bug: 18797453
Change-Id: I81d75a145db9303cd77cb0bc14abaed788f0c5b8
|
|
|
|
Change-Id: I37c1132d06264c3e8cdbbf181fe274cd26a99c80
|
|
lmp-mr1-dev
|
|
For buttons which appear an first-class actions in the in-call screen,
add haptic feedback. This feedback ignores the system settings, meaning
that it vibrates when buttons are touched regardless of the system
settings for vibrating on keypress.
Bug: 18388068
Change-Id: Ifadc973af9bcdfdfdc9d51b1c927b08d93714a58
|
|
Add another condition for which InCallActivity is launched so that
it can disconnect the call and show the error dialog.
Slight refactor of code that checks if a call has valid accounts so
that it can be shared.
Bug: 18781230
Change-Id: I83a9c4ee30f2a80168f3244f4929f70aa46b9d83
|
|
When given an animated drawable, always animate it, rather than only
when the call isn't connected.
Bug: 18695179
Change-Id: Ia9b320e2f5f47ee7fdfb489b91c736912dcdfd16
|
|
|
|
lmp-mr1-dev
|
|
Bug: 18759212
Change-Id: I2850941e0f007320aa06c34f5c8e550e672e15dd
|
|
|
|
This reverts commit bd9ccd501ebd83508dfe52121e0f4827cc6e1fa3.
Bug: 18742942
Change-Id: I8016ddae8addb56b4d6350748628fec351e6531a
|
|
If the ConnectionService provides an animated drawable for the call
state icon, animate it.
Bug: 18745128
Change-Id: I2e688549e7f34445db49726c4eb986d5dd60efdc
|
|
It seems that attemptFinishActivity can occasionally be invoked when
mContext hasn't been set, via setActivity -> updateActivity ->
attemptFinishActivity, if there are NO_CALLS. In this case, fall back
on mInCallActivity as the context for clearing the display.
Bug: 18728214
Change-Id: I504af612f79e14787741b14b03170805f57c5699
|
|
|
|
+ Specify "START" text alignment for call state label and the
name.
+ Specify "END" text alignment for the elapsed time.
+ Make the elapsed time view expand to take the parent's width,
instead of the number and location label's parent view.
+ Switch elapsed time text alignment to START if the number and
label view is hidden.
Bug: 18716511
Change-Id: I6d2ef5fe8a4364d42fb0438541e00ecce3daeaab
|
|
|
|
|
|
- The hide of the conference manager fragment and subsequent show of the
call card was being done inconsistently in a few places.
- Added a new method to hide/show the conference manager fragment and
the call card at the same time and replaced all references with this new
unified method.
Bug: 18699503
Change-Id: Ia6b80bdc29198627b1c46de72da432dc9523dc5e
|
|
* Show InCallActivity for state IN_CALL as well to ensure that
error dialogs are shown
* Override pending transitions in CircularRevealActivity
to avoid animation jank when starting new call from launcher
* Don't override disconnect cause in onCallRemoved
* Track service unbinding and binding in InCallPresenter. An
unbound service means InCallActivity will not be shown.
Bug: 18675781
Change-Id: I6a34091dba13c730e5b69bfef50c2dda8224803a
|
|
This was preventing the actionBar from being initialized and used by the
Conference Manager. The actionbar would come back null in the
InCallActivity.
Bug: 18675877
Change-Id: I442fea79ee64fbadf26f957fd84c1492eefa8dbe
|
|
Bug: 18373617
Change-Id: If742fb29397c0d617721a54eaa05c098eeaf4280
|
|
|
|
|
|
* Start InCallUI immediately once Telecom binds
* This CL is a bandaid for improving outgoing call responsiveness
in the MR1 timeframe. Refactoring InCallActivity into dynamically
added fragments and modifying its lifecycle with respect to
the call list is too risky.
* Add a lightweight activity (CircularRevealAnimationActivity)
that is used to display the circular reveal animation while
the significantly heavier InCallActivity is starting up
* Inside InCallServiceImpl.bind, start the reveal animation once
bind is called to avoid being blocked by any synchronous work in
Telecom.
* Refactor CallCardFragment.animateForNewOutgoingCall to
conditionally display the reveal animation, depending on
whether or not it was already displayed by the
CircularRevealAnimationActivity.
* Refactor the calculation of theme colors in InCallPresenter so that
the CircularRevealAnimationActivity can use those colors as well.
* Remove PENDING_OUTGOING from the list of call states that bring up
InCallUI.
Bug: 18373617
Bug: 18611753
Change-Id: I44c593373864ffc0ba9edebb88887177112d8b27
|
|
1. The "Manage Conference" button would be announced twice when it received
focus. Moved content description to the parent FrameLayout that acts as
the button and made it focusable to ensure that the description is read
only a single time.
2. When tapping "Manage Conference" button there was no audible feedback
that the manage conference screen was opened. Set focus to the list of
conference participants so that this list is announced when the manage
conference screen opens.
3. It was possible to change focus from the list of participants in the
manage conference screen to the call card buttons and other elements
behind the manage conference screen. Fixed by explicitly setting the
call card fragment visibility to GONE when the conference manager is shown.
Bug: 18440532
Change-Id: I0ce4f74ccb98c5cefd6c6e75eb8ef9310bd6d7fb
|
|
The phone number should always be displayed LTR, regardless of
whether the language is LTR or RTL.
Bug: 18581329
Change-Id: I7f8e43f86d996625da781500e61c65abe507304e
|
|
buttons." into lmp-mr1-dev
|
|
|
|
|
|
|
|
Bug: 18468085
Change-Id: I5d64f8958fe2be1952ee8a98fef77c6dd7d5e46a
|
|
lmp-mr1-dev
|
|
Bug: 18589036
Change-Id: Idac704fab2f31ecc908c1fe9ffe854dda0d2c34f
|
|
|
|
Leveraging the same mechanism we use for indicating subscriptions.
I don't think we have any cases where we need to show more than one
icon for the moment; we can add functionality to show more if its
necessary later.
Bug: 18103173
Change-Id: I1134f6114e17d4492276dc4e19c4746fc38a3ab7
|
|
Added new ripple drawable for the two buttons.
Bug: 18592386
Change-Id: I3c4145c1a400e3880bbe11dfe5eae94d2e17de9e
|
|
Occasionally the message "Secondary info clicked but no secondary call."
will cause a crash because it is logging wtf. It's not quite clear why
this happens but is not causing any behavioral problems. Also no defined
repo steps, but it's low-risk to turn Log.wtf to Log.w which will just
log a warning instead of crash.
Bug: 18465594
Change-Id: Ied23e5b52162cf68089bd5248fbdbf9e05eefdf8
|
|
|
|
Change-Id: I62a93662730afb8f8a5f75417549c8bb7d50cc78
|
|
|
|
|
|
Change-Id: Ibf5f0ed2b04ebb8743fdfab923ca3de6a3133f1c
Auto-generated-cl: translation import
|
|
Bug: 18292176
Change-Id: I5bcb1838a8423f15ebdf87c945ca91da460506f4
|
|
Ringer should stop while user is selecting response from "respond via
text" dialog.
Bug: 14656360
Change-Id: Ib73e6f10f1bda8363b65391a53e61dc5eb5d8d8d
|
|
Change-Id: Iab5ea1801e730ffac6ccd5787eedcf3af59b31cd
Auto-generated-cl: translation import
|
|
Bug:18506544
Change-Id: I720e090bdda87904f61fa6fd0f1aa95844a4fe71
|
|
Change-Id: I416bba96f3579d2cf0600988905c680f66e23776
Auto-generated-cl: translation import
|
|
This code path happens ~8 times in the outgoing call process
and causes unnecessary binder transactions
Bug: 18373617
Change-Id: I179159df396fcbbae306c5599f59b24f3addc56f
|
|
Don't use conference call string / icon if it's a generic conference;
we aren't positive what the state of the call is.
Bug: 18488721
Change-Id: Ib9041b25d33f5f0baada6defca6351beb5a929d2
|
|
|
|
In the InCallUI for devices smaller than nexus 4, the dialpad digits are
squished because the text in the call card is too big. Shrink the text
selectively for smaller devices (by moving the current default sizes to
the >600dp height devices). See
http://developer.android.com/guide/topics/resources/providing-resources.html#BestMatch
for reference.
Bug:18122087
Change-Id: I3eceae520d5039dd18c39434eb548288d8ce4e61
|
|
|
|
- Use GENERIC_CONFERENCE capability to show CDMA-scenario string
and image asset.
- Since mPrimary/mSecondary and others are class variables, don't
pass them around all the time through functions if we don't need to.
- Split out the isConference logic for setting the call cards into
its own block.
- Move logic for specifying conference string / icon into the
CallCardPresenter. This makes more sense here, and means that we
don't need to pass around a bunch of call paraemters to the fragment.
Not all these changes are strictly necessary for the change I need to
do, but I had made them originally because I had been thinking of
using the VoLTE capability. Even though now I use GENERIC capability,
I think the changes are still an improvement in terms of organization
though.
Bug: 18284408
Change-Id: I41d7825611456e9ea524db9dd2ef19c9646ab7e2
|
|
Bug: 18373617
Change-Id: Ice934a4defbcb0a2c7c618230e00e352322ec95f
|
|
Change-Id: I8019412f81363a2e43ba1516e69cb3a37f1b01d4
Auto-generated-cl: translation import
|
|
Add drawable caching in CallCardFragment so that we don't set
the same drawable multiple times.
Save and reuse the default contact photo and default conference
photo to avoid possibly decoding them multiple times.
Bug: 18373617
Change-Id: I54b925e6fc6f136f3d3ef27609fcdaf4c39a73dd
|
|
|
|
Change-Id: I12ef7181f74056e42f6746d6db208ae1065b1345
Auto-generated-cl: translation import
|
|
Bug: 18373617
Change-Id: Iae8cdd1f73de5f9824aff9d57fcf33b924527607
|
|
Missing null check in recently added CanAddCall property.
Bug: 18358924
Change-Id: Ia94e621b339fbd08ad074baa6eec787a90bb0fa4
|
|
The tint color of a phone account only refers to the color of the icon,
the highlight color is the general display color used for text,
backgrounds etc. We should use highlight color in InCallUI
Also minor color updates (lightening the "dark" version a little)
Bug: 18192071
Change-Id: I4078897bcb871326a4806f64355a67c5b267e9e6
|
|
lmp-mr1-dev
|
|
|
|
lmp-mr1-dev
|
|
|
|
|
|
With the color-change for MSIM, the ripples disappeared from the
InCallUI buttons. This change adds them back.
Bug: 18332863
Change-Id: Ic6125df06d0d2f3f2323fc2c422ccf075ff2df84
|
