summaryrefslogtreecommitdiff
path: root/InCallUI
AgeCommit message (Collapse)Author
2013-10-16Removes private resources from InCallUiChristine Chen
Bug: 11244110 Change-Id: I88471a7d1e164ac7e464f199f1c0c36fa3c0876f
2013-10-15Merge "Clears notification when there is no call." into klp-devChristine Chen
2013-10-15Clears notification when there is no call.Christine Chen
Bug: 11083320 Change-Id: I05efd985114a78d87098a46b1c4c33ad5bcc5b94
2013-10-14Replaces ToggleButtons with ImageButtonsChristine Chen
- Defer setting the toggled/selected state until TeleService gets back to us. Bug: 11172457 Change-Id: I4d103c1288b6e730c61aaf49e679f6b58746897b
2013-10-14Merge "Recalculate in-call state when activity ends." into klp-devSantos Cordon
2013-10-12Recalculate in-call state when activity ends.Santos Cordon
Previoulsy we only calculated the in-call state on activity end if TeleService was still connected. This was insufficient as transitions to NO_CALLS (which happens generally when TeleService disconnects) may rely on the recalculation after the activity ends in cases where the app finish()es out of in-call's normal flow (like hitting back button while the call is ending). bug:11122139 Change-Id: I02eb8e7a977048d6f167c11a3f28e7aa629bdbe2
2013-10-11Import translations. DO NOT MERGEBaligh Uddin
Change-Id: I1335c2118943c785682faadaa8f9b51f1965d557 Auto-generated-cl: translation import
2013-10-11Merge "Import translations. DO NOT MERGE" into klp-devBaligh Uddin
2013-10-10Removes stopPing from onSaveInstanceState()Christine Chen
- I don't think it makes sense to do any processing in onSaveInstanceState() as we are already stopping the ping in onWindowVisibilityChanged. - onSaveInstanceState() should solely deal with saving app states anyway. Bug: 11156202 Change-Id: If2b17bd10b455899703aa2c8f9d15f04a9bea22f
2013-10-10Import translations. DO NOT MERGEBaligh Uddin
Change-Id: Ib986f4834326a6ae2be17a6be01f4b182c051eb1 Auto-generated-cl: translation import
2013-10-10Merge "Pull login protected images for profiles." into klp-devChiao Cheng
2013-10-09Pull login protected images for profiles.Chiao Cheng
Some GAL photos are login protected. The server supports oauth via http header. Change the reverse lookup api to lookup images by account if the image is identified to be login protected. Bug: 11106770 Change-Id: I92b506d325835a74f846829b0c03eed330938952
2013-10-09Merge "Turn down logging level." into klp-devChiao Cheng
2013-10-09Turn down logging level.Chiao Cheng
Logging was turned up to help track down urgent issues. No longer needed. Bug: 11155971 Change-Id: I29c081632ec608716191d7bed573f3947c75bd44
2013-10-09Merge "Catch potential NPE" into klp-devJay Shrauner
2013-10-09Catch potential NPEJay Shrauner
Catch case where country detector might return a null country. Bug:11139097 Change-Id: Ib61238ee8b4a628d6428bf65a2b9b67de3f73826
2013-10-09Merge "update dialpad state more often." into klp-devSantos Cordon
2013-10-08update dialpad state more often.Santos Cordon
Noticed while testing proximity sensor that we do not update the dialpad state sufficiently. We have increased the amount of places in the code where the dialpad comes up since we first introduced the proximity code and the callbacks wheren't updated. This manifested in situations where the proximity sensor was off at time when it should have been on. Repro: be in a call, answer a second call (call waiting), bring up dialpad, hangup second call. The dialpad would go away but the prox sensor still thought it was up. This change moves the callback to proximity sensor to the exact place where dialpad is shown/hidden in order to catch all instances. bug:11006867 Change-Id: I7651b4769d035b9bc68d226da3ffb3aea8986e58
2013-10-08Sets a few button to invisible by default.Christine Chen
- When user rejects an incoming call, the buttons wouldn't get initialized to be visible or invisible because the call state never gets to be processed. - A few non-essential buttons (add call/swap call/merge call) are therefore defaulted to be inivisible. Bug: 11028671 Change-Id: Ia2b800a80b83bd8212bef67834c9f5214e3090b5
2013-10-08Merge "Turn screen on for call-waiting calls" into klp-devSantos Cordon
2013-10-08Merge "Add logging to dialer." into klp-devSantos Cordon
2013-10-08Turn screen on for call-waiting callsSantos Cordon
Normal incoming calls get the screen powered on through the window flag FLAG_TURN_SCREEN_ON. However, this only works when the window is being created or sent to foreground. But for call-waiting cases where the screen is off and in-call is in foreground, the screen remains off since the flag is not triggered. Solution is to look for the case where the screen is off and the new incoming call is a call-waiting call...and in that case finish() the activity and create it again. Since the screen is off, there is no concern over jank from bouncing the activity. bug:11031245 Change-Id: Ic0c206d57c9d1ce5beebff49a07c7877f6d1a423
2013-10-08Merge "Adds support for texting after phone disconnects." into klp-devChristine Chen
2013-10-07Add logging to dialer.Santos Cordon
Two instances that need more logging: 1) Is UI showing for prox sensor. 2) Was the call hung up from notification? bug:11050553 Change-Id: I9eb60621bc320fe466780e5d7df7502354dd3f1f
2013-10-07Adds support for texting after phone disconnects.Christine Chen
Bug: 11111553 Change-Id: I8abcae4439e7b9697d7b4a4335e093d7ad13a1b3
2013-10-07Import translations. DO NOT MERGEBaligh Uddin
Change-Id: I0c0dccb873dcafd22361c0b1fe21100b998b3868 Auto-generated-cl: translation import
2013-10-05Add custom message dialog for Respond via Message.David Braun
We don't want to require SMS applications to implement activities that show over lock just to handle the "respond via custom message" scenario for rejecting phone calls. This change adds an entry dialog into the phone call UI. A separate change removes the code in the Telephony service that would have asked the default SMS app to show UI. Bug: 11084719 Provide UI for "quick response" messages built into Phone app Change-Id: I7fcf20280fd3b741aa941cc6a24f5c262db1899b
2013-10-04Import translations. DO NOT MERGEBaligh Uddin
Change-Id: I52326a66e7600be623e61c757689fbab27f8dfaa Auto-generated-cl: translation import
2013-10-03Removes textured background for InCallUiChristine Chen
Bug: 11070029 Change-Id: I28e0f92c26302b9cff497cd1f63dc0ad7fade3ce
2013-10-03Merge "Import translations. DO NOT MERGE" into klp-devBaligh Uddin
2013-10-02Merge "Send view notification for viewed contact in IncallUI" into klp-devYorke Lee
2013-10-02Merge "Add back the black line above the end-call button of the in-call UI." ↵Ben Gilad
into klp-dev
2013-10-02Merge "Default to business avatar for businesses without an image." into klp-devChiao Cheng
2013-10-02Send view notification for viewed contact in IncallUIYorke Lee
This triggers a download of the hi-res photo for the contact so the next time a call is made, the hi-res photo is displayed. Bug: 11006082 Change-Id: I8243dc0a6899c787807425226f2cfcd4a46e0ec1
2013-10-02Import translations. DO NOT MERGEBaligh Uddin
Change-Id: I70bcf3bc26e84402888993d925c179318417626b Auto-generated-cl: translation import
2013-10-02Merge "Adding the (lost) buttons back upon disconnected calls, see ↵Ben Gilad
b/11028671." into klp-dev
2013-10-01Add back the black line above the end-call button of the in-call UI.Ben Gilad
bug: 11032236 Change-Id: Ia3eedff0328a6a4aa90d87a23c27d52778507578
2013-10-01Adding the (lost) buttons back upon disconnected calls, see b/11028671.Ben Gilad
Change-Id: If4f48879bb9601484e69cb66fa0eb980ece53909
2013-10-01Go back to the main ui when conference call splitsChristine Chen
Bug: 11029034 Change-Id: I0c71847f8123555f0456c1ae22bae76d0665450b
2013-10-01Default to business avatar for businesses without an image.Chiao Cheng
Bug: 10988291 Change-Id: If06f30fdc6d12d1abcb20cd7a10b8d80a02ab22b
2013-10-01Merge "Scales the contact photo to fit notification icon" into klp-devChristine Chen
2013-10-01Merge "Import translations. DO NOT MERGE" into klp-devBaligh Uddin
2013-10-01Merge "Protect hideDialpad() code with isActivityStarted() check." into klp-devSantos Cordon
2013-09-30Scales the contact photo to fit notification iconChristine Chen
Bug: 11007879 Change-Id: Ide32f725bedc80095edd067ea531f0c07e18ffa3
2013-09-30Protect hideDialpad() code with isActivityStarted() check.Santos Cordon
Could hit NPE if the activity was not up or already brought down like with Fixed Dial Number where a disconnect comes almost immediately after dialing out. bug:10995838 Change-Id: I150d1ca135702814ac6d78722c3ad15ae5273c83
2013-09-30Merge "Changes primary call card padding" into klp-devChristine Chen
2013-09-30Import translations. DO NOT MERGEBaligh Uddin
Change-Id: I1f4a8ea387b463c748748b7fee3778c62d77025c Auto-generated-cl: translation import
2013-09-28Make sure glowpad is centered when gravity is centered.Santos Cordon
+----------------+ | ---- | | - - | | - - | | - - | | ---- | +----------------+ | h | from square edge to circle edge | d | diameter of circle | w | width of square Those are the three values involved in the calculation that we are changing. The formula calculated the center of the circle (glowpad). When setting the x position of the glowpad we should always grab the radius of the circle (d/2) then set h to a proper value depending on the gravity setting: left) h = 0 // do not shift at all center) h = (w - d) / 2 // half the diff. between box and circle widths right) h = (w - d) // total diff. between box and circle widths This is what the code does after this change. The flaw that I saw was that instead of using the radius and adding to h, we used the maximum between the radius or w/2 (half the width of the box). The result was that in rare occassion (possibly for the first time in the associated bug) where the circle is smaller than the box, we would shift too far to the right because w/2 is always larger than the more appropriate d/2. I don't know why this was done, but I have added jaggies@ who originally wrote the code. I consulted with christinech@ and both determined that this is the correct mathematical formula. I verified that the old code did not work correctly for left, right, or center and that all three work as expected with the new code. bug:10958942 Change-Id: I781dc25601382d7a43408cbce0badf8a0a90d663
2013-09-27Changes primary call card paddingChristine Chen
- Also changes the secondary call card padding and alignment Bug: 10955870 Change-Id: I781e2016914d6ce8e677cc8bc88ed909db23879c
2013-09-27Merge "Add deadzone to end call button." into klp-devSantos Cordon
2013-09-27Add deadzone to end call button.Santos Cordon
inside perimeter previously had a deadzone around the inside perimeter of the end call button to avoid unintentional hits. This change reintroduces the SmallerHitTargetTouchListener in order to add back the deadzone. Also added deadzone to the secondary call hit target since that previously also implemented the deadzone. SmallerHitTargetTouchListener.java copied from existing apps/Phone code. bug:10884607 Change-Id: I7445b6a2e364878aabf6fcb2f7a3e4b1dee87578
2013-09-26Merge "Show call ended if call disconnects while dialpad is showing" into ↵Yorke Lee
klp-dev
2013-09-26Fix potential NPE in ConferenceManagerPresenterYorke Lee
Bug: 10931593 Change-Id: I2b86ca5e7883bed86c978af0589d8865214f27c8
2013-09-26Show call ended if call disconnects while dialpad is showingYorke Lee
Bug: 10899209 Change-Id: Iefdef1890f8968fda57eb5f3286b97228906b596
2013-09-24Merge "Check for null during notification hangup Intent receipt." into klp-devSantos Cordon
2013-09-24Merge "Replace blue highlight feedback with gray." into klp-devRob Tsuk
2013-09-24Check for null during notification hangup Intent receipt.Santos Cordon
bug:10863336 Change-Id: I775f1855d07cc4f6591ceb51a0f90754ecc833ad
2013-09-24Merge "Add generic error code dialogs for failed calls." into klp-devSantos Cordon
2013-09-24Merge "Adds hardware keyboard support for DTMF" into klp-devChristine Chen
2013-09-23Add generic error code dialogs for failed calls.Santos Cordon
This change listens for disconnected calls and if the disconnection cause matches a set of predefined causes, we show a dialog to the user. New dialog messages: - You can\'t make outgoing calls while call barring is on. - All calls are restricted by access control. - Emergency calls are restricted by access control. - Normal calls are restricted by access control. - Outgoing calls are restricted by FDN. Several changes were necessary to support this: 1) Dialog code (InCallActivity.java) 2) Notifications for a new disconnect (CallList.java) - previously we sent a large update for ondisconnect, now we just send the notice for that particular call. InCallPresenter was written so that the same thing that used to happen still happens. 3) Check if we need to show a disconnect dialog when the UI comes up. - I found that FDN disconnection happens so quickly that the disconnect came before the UI was up, so this was necessary. (InCallPresenter.setActivity()) 4) CallCard should be initialized with disconnecting/disconnecting calls. - Call Card presenter intializes itself when it starts up using live calls, but as with the FDN case above, a disconnected call should be used if no live calls exist. (CallList.getFirstCall()) 5) If a dialog is up while an incoming call comes up, dismiss it automatically so that users can see incoming UI. - (InCallPresenter.startOrFinishUi()) 6) Keep the UI up as long as there is a dialog for the incoming call. - Previously, UI would come down once all calls were shut down but in the case of present dialogs, we want it to stay up. (InCallActivity.finish()) - When the dialog is dismissed, check if we want to tear down UI. (InCallActivity.onDialogDismissed()) 7) Only tear down UI once we are in the NO_CALL state. - We used to tear down when the activity was null (closed) and the service was disconnected. This is problematic because a call that immediately disconnects (like FDN errors) would shut down the service before the UI had a chance to come up. We added a check to the conditional for the state NO_CALL before shutting down. (InCallPresenter.attemptCleanup()). bug: 10680210 Change-Id: I1fd33dd53dc0eec5a02b7a940cfd018cec3d20c0
2013-09-23Replace blue highlight feedback with gray.Rob Tsuk
Change-Id: I821300c76e0c97e9998796a87c88a9bc55e89e84
2013-09-23Adds hardware keyboard support for DTMFChristine Chen
Bug: 10808399 Change-Id: Id12acee7baf11335916a38c50a266f83f578e0bd
2013-09-20Read back contact information in in-call screenYorke Lee
This changes talkback behavior so that it behaves the same way as in 4.3, other than reading the unnecessary description of the contact's photo Bug: 10844641 Change-Id: I2a2829d1a9650bf18d3b1d98d6ddc860fe9f8d27
2013-09-20Merge "Add "retrying" text for CDMA redial calls." into klp-devSantos Cordon
2013-09-19Add "retrying" text for CDMA redial calls.Santos Cordon
listening for new REDIALING state. bug:10824223 Change-Id: I2b6f2f74713197902c93deca203f4f136732f7a2
2013-09-19Updates extra button row with dialpad visibilityChristine Chen
Bug: 10843473 Change-Id: Ie8bccd53daaf6d59a5db6f3c6a43f76a218ec3a8
2013-09-19Hides dialpad on incoming call.Christine Chen
Bug: 10842639 Change-Id: Ia014bdc85128a4838b3dfcf7e67bb93c8a7725d9
2013-09-19Addressing finished and postponed TODO(klp)Christine Chen
Bug: 10605909 Change-Id: Id7594b306d23d4bd5d7a6983f2dbe524591a0d69
2013-09-19Fixes CallCardFragment lifecycle issue.Christine Chen
Bug: 10840705 Change-Id: Ibefe57b7e79546a777f20e43b52793d7ff41a4e1
2013-09-19Merge "Tear down proximity sensors when no longer in use." into klp-devSantos Cordon
2013-09-19Merge "Add support for hardware CALL button." into klp-devSantos Cordon
2013-09-19Merge "Adds DISCONNECTING state support." into klp-devChristine Chen
2013-09-19Merge "Import translations. DO NOT MERGE" into klp-devBaligh Uddin
2013-09-19Merge "Hide home and back buttons during incoming call" into klp-devYorke Lee
2013-09-19Tear down proximity sensors when no longer in use.Santos Cordon
bug:10493709 Change-Id: I76e1940472aa503f1fe8c4a73c82852f8670b61c
2013-09-19Add support for hardware CALL button.Santos Cordon
bug:10809304 Change-Id: I8b6c5e27a37624f38df965e2ad001703cf558708
2013-09-18Adds DISCONNECTING state support.Christine Chen
When user ends a call locally, we first set the call state to DISCONNECTING and show "Hanging up" as the status. We then show the "Call ended" status when the telephony layer comes back with the DISCONNECTED state for the call. Bug: 10808537 Change-Id: Iad5eda6ee34e2f04a861977ac1a2453a52081d27
2013-09-18Import translations. DO NOT MERGEBaligh Uddin
Change-Id: Icada1e0818f2ada7826d1227f4de602e36dcc269 Auto-generated-cl: translation import
2013-09-18Hide home and back buttons during incoming callYorke Lee
Bug: 10692603 Change-Id: I9bacaf39d926b9004778b33c33420a51dde1332f
2013-09-19Merge "Make back button exit ConferenceManagerFragment" into klp-devYorke Lee
2013-09-18Make back button exit ConferenceManagerFragmentYorke Lee
Bug: 10808785 Change-Id: I8acf38bfa06bb58a778c45b107ff49eead37f25b
2013-09-18Merge "Allow bringToForeground to work even after activity is destroyed" ↵Santos Cordon
into klp-dev
2013-09-18Moves some TODO(klp) to TODOChristine Chen
Bug: 10605909 Change-Id: I6c961494f5470e6e96dd50ccec49bbc8c5862285
2013-09-17Removing finished TODO(klp)Christine Chen
Bug: 10605909 Change-Id: Ia4bfcc385d4bf36cbc3b401521714958fd829c7e
2013-09-17Disable HOLD when SWAP is possibleChristine Chen
Bug: 10803088 Change-Id: I2aa40c4f645aa78cbec53e1ef72339c3bf17b038
2013-09-17Un-mute phone when add-call does not go throughChristine Chen
- Keeps a special flag for auto muted state. When the InCallUi resumes, checkes whether the auto mute is no longer needed. - Removes all exciplit setMute unless it is triggered by the AudioMode listener. Do not set UI mute state unless the Telephony layer sends an update. Bug: 10786369 Change-Id: Ifd1809f2d9df44121fcb29a87016152c706944cc
2013-09-17Allow bringToForeground to work even after activity is destroyedSantos Cordon
bug:10550460 Change-Id: I63d8b13c423c198603768e17a1ef15bbbb4c7705
2013-09-17Outgoing/Conference UI changes for Cdma supportSantos Cordon
Changes: - rename Cdma* to Generic* in code - Stop showing "manage conference" for generic_conference cases - Show simple "merge" button for generic_conference cases - Add generic icon/name label for generic conference calls - Do not submit a contact info request for any conference call sincle they always display generic information (this also fixed some jank of the image flipping back and forth between generic and normal conference call).o bug:10769004 Change-Id: I379895612614483f7f3ea6fef493796ea855743b
2013-09-17Merge "Import translations. DO NOT MERGE" into klp-devBaligh Uddin
2013-09-16Add a missing null check.Makoto Onuki
Apparently Call can still be null during the INCALL state. Bug 10699042 Change-Id: Ide8a0605a5f078dbfc12cc05d40d90f6aa8e9c76
2013-09-16Merge "Add internet call type label" into klp-devYorke Lee
2013-09-16Add internet call type labelYorke Lee
Bug: 10764487 Change-Id: I87e48063b14629c19a58b9ddb2acb736af6f37e0
2013-09-16b/10699042 show dialpad when connects to voice mail.Makoto Onuki
Also now "Use touch tone keypad" in the dialer works, and it automatically un-holds if there's only once call and it's on hold. (which was a regression too.) Change-Id: Id8eeb2737ffa2223acfbf9a8a30d957599c9db36
2013-09-16Import translations. DO NOT MERGEBaligh Uddin
Change-Id: I9bbe5360deb80cb95ddde292559895503778824b Auto-generated-cl: translation import
2013-09-16Merge "CallCardPresenter should listen for Call Waiting" into klp-devSantos Cordon
2013-09-15CallCardPresenter should listen for Call WaitingSantos Cordon
Regression from recent change to only update UI with incoming calls using the onIncomingCall callback. The CallCardPresenter wasn't listening for that specific change so call-waiting calls were not displaying "incoming call" label. Change-Id: I6a732585509c1e27e7ecf5805cb17ea8e7f043ed
2013-09-15Shut down if UI starts after service is disconnected.Santos Cordon
Additionally, this change can cause multiple calls to attemptToCleanup() so the change adds appropriate null checks. bug:10767438 Change-Id: Ieeb4a00653a6b3bcacca105d649ca9efd8ae8d44
2013-09-14Takes new Call states to enable/disable buttons.Christine Chen
Bug: 10733320 Change-Id: Ic8e58cad46610a1fcaef2b55af458ca7661c4f8b
2013-09-14Merge "Pass number to fetchImage as cache key" into klp-devJay Shrauner
2013-09-14Pass number to fetchImage as cache keyJay Shrauner
Pass phone number in on fetchImage lookups so it can be used to save the image to the cache. Bug:10760102 Change-Id: I3afb5e99aa4e8a4bc9148f6cfda4e5eba48ec476