| Age | Commit message (Collapse) | Author |
|---|
|
am: 803a8afbcc
* commit '803a8afbcc22d1daafbea011ddd7a8bf8b30765c':
Remove CallAudioStateCompat
|
|
am: 429e15a3de
* commit '429e15a3de2e5cfbc2c44071e97981e583f1ed15':
[Gradle] Allow dialer to be compiled as a library
|
|
am: b64b56dd45
* commit 'b64b56dd457d5f3bd32f4933808eb3f4629e0e83':
Remove Lollipop support for InCallUI
|
|
into nyc-dev am: 639ed3451d
am: c58829eee0
* commit 'c58829eee08d834b40909ea780ba666af44262ed':
Show Briefcase icon not displayed in in-call UI for work SIP calls
|
|
Now that we're no longer backwards compatible with Lollipop we don't
need CallAudioStateCompat. See ag/870962 for more info.
Bug: 26676586
Change-Id: I7c754d89a6c9e13bf5a004b7c5b15b88b9aff9ad
|
|
This CL adds a new build-library.gradle file for AOSP dialer.
This allows the dialer to be built as a library that can be
included from GoogleDialer.
Switching to a library project meant making two other changes:
- changed all switch statements that used resources to if statements.
This was required because resource IDs are not final in library
projects.
- changed InCalUI code to import com.android.dialer.R instead of
com.android.incallui.R. See http://b.android.com/82743 for more info
on why this is required.
src-N isn't supported yet. Also, this isn't the ideal project layout.
In the future we should consider switching to the following layout:
- dialer/incallui/ <- incall UI as an independent library project
- dialer/dialerlib/ <- dialer code as an independent library project
- dialer/app <- skelent app that builds a standalone dialer AOSP app
Bug: 26676586
Change-Id: I07fbee4d33cc683539e4f8b3953c93f1427af9d7
|
|
|
|
This CL removes support for running dialer on Android L MR1.
The change allows us to switch from the system SDK to the public SDK.
This is useful for the following reasons:
- makes it easier to switch to gradle
- makes it easier to migrate GoogleDialer to google3
- reduces maintenance overhead for unused code
Currently there's no plan to release Dialer on Lollipop. If or when
we decide to support Lollipop we can consider switching back to the
system SDK and restoring the comapatiblity code.
Bug: 26676586
Change-Id: Idac9e6e19f1d21c9261c1b0d0ff3e3ca4aab980b
|
|
into nyc-dev
|
|
Current dialer always queries PhoneLookup._ID and uses this as a contact
ID.
In pre-N, contact id of non-sip query is stored in PhoneLookup._ID and
it is actually a mistake. This problem does not exist in sip query,
and contact id of sip query is stored in Data.CONTACT_ID. So it is a "bug"
in dialer that we use PhoneLooup._ID for sip query as it is not really a
contacat id. The bug of missing work badge may not be the only issue
introduced by this.
In N, the issue is get fixed in framework, PhoneLookup.CONTACT_ID is
introduced. We should access PhoneLookup.CONTACT_ID no matter what
phone lookup query we are having.
The ideal case is we always use PhoneLookup.CONTACT_ID for retrieving
contact id, but given that we need to support in pre-N, we need to
query PhoneLookup._ID for contact id in non-sip query in pre-N.
BUG:27242975
Change-Id: Id14378e3dce5b07629ffe0c6e83c3d107fbb468e
|
|
am: ff3e825369
* commit 'ff3e825369e260b155d5d1865dacb8235ea7af19':
Checking for READ_CONTACTS permission
|
|
|
|
+ When starting a call, we attempt to look up the ContactInfo. This
lookup needs to be guarded by a check to ensure we have permission to
read the contacts.
Bug=27078247
Change-Id: Id68de80d3acd721642b79ff81fda5d9decd67e7b
|
|
into nyc-dev am: 73fb5b37a7
am: a3e5164c53
* commit 'a3e5164c532488b2a20deb6cdccb54b919c0a110':
IMS-VT: Do not create new surface when setting surface dimensions
|
|
into nyc-dev am: ebddd94caf
am: 3868a4a974
* commit '3868a4a974f0d63f7440d2f27d92e4284979afb6':
Fix end-call FAB position when dial pad is shown on device rotate.
|
|
into nyc-dev
|
|
Do not create a new surface when setting surface dimensions.
Bug: 27246093
Change-Id: I3f66594141d548680427a7579169647018ca7eb7
|
|
nyc-dev am: d1f0d57602
am: aac29b4966
* commit 'aac29b49662558f55d737fe2bb7f5060eddd1092':
IMS-VT: Moving upgradeVideoRequest handling to InCallPresenter
|
|
into nyc-dev
|
|
Move the "onDialpadVisibilityChange()" listener call so that it takes
place regardless if the dialpad is animated on show-hide. That
listener triggers "updateFabPosition()" in callCardFragment, which
repositions the fab.
Bug: 27170964
Change-Id: I56588695c633205f4ebaac6d9685f543b9e09293
|
|
nyc-dev
|
|
When user pressed back key InCallActviity will be destroyed and
corresponding listeners in VideoCallPresenter will be removed.
Due to this we are unable to process the upgrade request.
Moving handling of upgrade Video Call request handling from
VideoCallPresenter to InCallPresenter as InCallPresenter will be
available even InCallActivity is destroyed.
Bug: 27130345
Change-Id: Idbd3348cea9d712c8391319d091642d1fd60964f
|
|
am: e52c87274f
am: f47151d1a2
* commit 'f47151d1a203e7f98c127123e35544b5383b59b1':
Make secondary info visible for multi-window InCallUI.
|
|
|
|
am: d557bc2ba8
* commit 'd557bc2ba817a071005e18f006f7e80eacc506c8':
Enabling Dialer to play ringtones
|
|
+ The code to make the Dialer play was disabled behind flags, this
change flips the flags so the Dialer is responsible for playing the
ringtone.
+ The in-code flag will be removed later after a QA pass of the
feature.
- Removed TODO to respect Do Not Disturb, see b/26936902
Bug=18702990
Change-Id: I773c1c614beb61a6763daccd2903d9d341cf4dc0
|
|
am: c677fc1540
* commit 'c677fc15403996055d2c6fa73e7ff0928bd218b9':
Added ackAllMilestones api to PausableExecutor
|
|
am: 97fbfe5baa
* commit '97fbfe5baaccbd06c19ebde6636ca500278a21f2':
Integrating DialerRingtoneManager and InCallTonePlayer
|
|
+ This API simplifies tests, specifically their tearDown methods.
Rather than needing to call ackMilestone numerous times to clean up
at the end of the test, this method can be called to ensure that the
thread running the production code isn't blocked on the tests.
Change-Id: I60730c52491b315aee571f4ae158f62d34b0dbc2
|
|
This change makes the Call Waiting tone actually play during the
Call Waiting use case.
+ Plugging InCallTonePlayer into the DialerRingtoneManager in the
StatusBarNotifier
+ Test fixes
+ Added tests for when Dialer ringing is disabled
+ Added tests for DialerRingtoneManager#playCallWaitingTone
- Removed unneeded @NeededForTesting annotations from InCallTonePlayer
since they won't be stipped out by proguard.
Change-Id: I49a83d2a7fe6edf5f9ec88db973a5f37e307f23a
|
|
am: b12e25acbd
* commit 'b12e25acbd1550c61eaa652f60125b93d4a5da03':
Implementing class to play tones
|
|
am: 4074ba2c11
* commit '4074ba2c112b1f7ab9a04d5a2b96c7cd5fd70a17':
Added factory to create ToneGenerators
|
|
+ This class will be used by the DialerRingtoneManager to play the
call waiting tone. It exists to encapsulate the logic to play a tone
in a background thread.
+ The TonePlayer includes some thread safety measures, but is not
meant to be shared between multiple threads
Bug=26936401
Change-Id: I630959177fcd8a4fc8ba7d3153f036746ad8a4cf
|
|
+ This class was needed to abstract out the logic to determine which
stream to play tones though. It is also easily mockable for use.
Change-Id: I382239483871b9aa1ef6fece7e66ea95f3fba4e0
|
|
Secondary info was previously hidden after the layout refactoring to
support resizing in multi-window mode. Make it visible and also keep it
at the bottom of the screen because the vertical screen real estate is
limited.
Bug: 26253432
Change-Id: I8e7f3b462784c7af62ccdb95e637595f7d382edd
|
|
am: 4c6d68244b
* commit '4c6d68244beab9c9855594ab88168eb855496ac0':
Added executor framework to sync prod and tests
|
|
+ Use a TestableExecutor in the production code to allow tests to
sync up and block so the state of the system can be tested. In the
tests the executor can wait until the production code hits a
milestone to ensure that the system is in a proper state for testing.
+ The current implementation only attempts to synchronize between one
production thread and one test thread. Extend the TestableExecutor
interface to perform additional synchronization.
Change-Id: Ie6fc64392e402330ab66c6f2cd0ec22200ebbdea
|
|
[cherry-pick from ag/864046]
Photo of directory contact in call log should not require internet access.
It's now cached locally.
BUG=26111304
Change-Id: I9848e6fe9487c09899fd77f21804bcb4537799a8
|
|
[cherry-pick from ag/862143]
Update cache only when the result is returned to InCall UI.
Now both call log and InCallUI take the callerinfo
which are first returned from provider.
When both personal and work profile directory lookup returns
a caller info, InCallUI takes the personal one, while cache
takes the work one. So it might result in the name being inconsistent
between 2 UIs. However, it's extremely rare as it's unlikely
to happen unless 2 corporate accounts under the same domain
are registered in personal and work respectively.
BUG=26819634
Change-Id: I87c4533635c0e2f88a639ca1c23611b2a22f6b07
|
|
[cherry-pick from ag/861979]
Photo of directory contact in call log should not require internet access.
It's now cached locally.
BUG=26111304
Change-Id: I9848e6fe9487c09899fd77f21804bcb4537799a8
|
|
|
|
am: 1124c2fb24
* commit '1124c2fb24777f7b49e1c2311c2d88f6974e80a3':
IMS-VT: Clear progress spinner when primary call changes
|
|
This is a cherry-pick of partner CL in mm-wireless-dev.
In use-cases wherein UE receives waiting call or user tries to add call
soon after initiating a modify request, progress spinner is not hidden.
Fix this by clearing the progress spinner when primary call changes.
Change-Id: I3a5b28e36af3c73e797924cdf1b3cb87815296f1
|
|
Update cache only when the result is returned to InCall UI.
Now both call log and InCallUI take the callerinfo
which are first returned from provider.
When both personal and work profile directory lookup returns
a caller info, InCallUI takes the personal one, while cache
takes the work one. So it might result in the name being inconsistent
between 2 UIs. However, it's extremely rare as it's unlikely
to happen unless 2 corporate accounts under the same domain
are registered in personal and work respectively.
BUG=26819634
Change-Id: I87c4533635c0e2f88a639ca1c23611b2a22f6b07
|
|
|
|
In onStateChange, this branch of logic should be not be followed if mPrimary
is null.
Bug: 27045730
Change-Id: Ia948313d4886475dd5966b209c19696cb594ed59
|
|
+ ContactDisplayUtils's preferredName methods now accept the
ContactsPreferences object rather than just an int. This was done to
abstract out the null checks that were previously necessary when using
the utility.
+ Conference calls were crashing because the ContactsPreferences
object was attempting to access shared preferences while File based
encryption locked. This change makes use of the
ContactsPreferencesFactory to handle returning the proper instance
when in this locked case.
Bug=26822105
Change-Id: Ie382c0c615cf27f69682774fc9538828cc429e69
|
|
+ This change ensures that the Dialer doesn't try to use the
ContactsPreferences object (which uses information in unavailable
storage) while in File based encryption locked mode. Without these
checks, the Dialer crashes on receiving an incoming call while FBE
locked.
+ Added Factory method to create ContactsPreferences for tests/while
FBE locked/while FBE unlocked
+ Added tests for CallCardPresenter and StatusBarNotifier FBE related
code
Bug=26822105
Change-Id: I5df93526e70b7350885c7261982945c32b7e86a0
|
|
* changes:
Adding method to check if call waiting tone should be played
Refactored dialer Ringtone code in prep for call waiting
|
|
+ This method will be used in StatusBarNotifier to determine when
call waiting tones should be played instead of the standard ringtone
Change-Id: I4ad55f3870de5e63d03f4a5e8534680fa24556bd
|
|
+ Created class that is responsible for determining if a ringtone should
be played.
+ This class will also have the code to play call waiting tones
Change-Id: Ie8fb633c8a233cc6b54beeb09b3fd6b62c9cb76c
|
|
- Remote contact lookup was overwriting the cached contact specific
ringtone. This resulted in a longer wait time for the ringtone to
play since it would require the contact lookup to complete again.
- This CL prevents the cached ringtone from being overwritten.
Change-Id: I0a1cb30acd3aaf540533429c01427b185a7acf66
|
|
am: b68e8129c0
* commit 'b68e8129c056c60e78188e6fbcd6179406723eaa':
Adding flag to enable/disable Dialer ringing
|
|
Bug=26864105
Change-Id: Ifc565320dd9fd8845c45551454e59020806d985c
|
|
ub-contactsdialer-b-dev
am: 8a5ff66b41
* commit '8a5ff66b4136af7e7353d2b408a69262ee89013c':
Add downgrade to audio button for video calls.
|
|
ub-contactsdialer-b-dev
|
|
am: e8318d00f6
* commit 'e8318d00f6ed1ddbec23be052d6751076e87137c':
Play the ringtone for incoming calls in Dialer
|
|
+ Initial CL to make the Dialer play a ringtone for incoming calls.
- Not included in this CL:
- Playing call waiting tone
- Silencing ringer when volume key is pressed (power button works
properly)
- Bug fix for ringtone not playing when lockscreen is set
- Bug fix for contact look up taking too long - when do we play the
default ringtone
Change-Id: Ie8bd042b9ec142c78cb4d2de66475c96a18b8273
|
|
- Add downgrade to audio button for video calls where the call capabilities
indicates that it is supported.
- Requires N SDK or higher.
Bug: 22728624
Change-Id: I92aaf1d1e77da82c2ad982a57bb2eae599cff4da
|
|
into ub-contactsdialer-b-dev
am: ccfb9e42ea
* commit 'ccfb9e42ea60ba7a8f024d93da2b8c19657f8bf6':
Open work profile QuickContacts for work contacts in personal dialer
|
|
into ub-contactsdialer-b-dev
|
|
Set lookup key for enterprise contacts to allow QuickContacts to open it.
It requires framework change in NYC to support it.
BUG=26176780
Change-Id: I61345d52aa9fa296fdf95eca624b295c86925e46
|
|
ub-contactsdialer-b-dev
am: 8a63fc40cb
* commit '8a63fc40cbd04c9f3d3ce8bffac8340f62d19ddb':
Hiding addCall button while the device is fbe locked
|
|
am: db576118c0
* commit 'db576118c094a67b5c60b8c63f4426c9530ba94a':
Ensuring quickResponse isn't available while fbe locked
|
|
ub-contactsdialer-b-dev
|
|
Bug=26543932
Change-Id: I37c46404f20d16c91ab391c14b7f2d2cb5528630
|
|
+ Sending an outgoing message is not supported while in the fbe
locked state so the option to send an SMS should always be hidden.
Bug=26542221
Change-Id: I9d630bdf73ec9f6965607c60f36b7a04c04f4134
|
|
am: 23c6938d79
* commit '23c6938d7966e0b1121c60c66118b6f772c12730':
Add work description into call state in InCallUI
|
|
Only description of incoming call and call ended are affected
BUG=26082618
Change-Id: Ic511aac339b02db4453e695bfc92ccad47a97c83
|
|
am: 59978d307c
* commit '59978d307c8bf37d8ae7e333f0844aee5fedb329':
Showing badge icon in incall ui if it is a work call
|
|
am: dd8122a083
* commit 'dd8122a0831a44ef74e6b84ba97237edfa48815b':
Indicate the call is work call in notification
|
|
Work call means the call is placed through work phone account
or it is an outgoing call initiated from work dialer.
Please notice that both personal and work call is handled by personal
in-call UI, that's why we need to add a badge to indicate it.
There is another scenario we need to add badge, ie. having a work
contact caller, and it will be handled in ag/836110.
BUG=26022174
Change-Id: I96e72068f70674dbeabfbbf7bfffc6c15c3203bf
|
|
Bug: 26022174
Change-Id: I5f28e3fa47c91787fbc5c82b68316a8baa11d286
|
|
am: 76c8304946
* commit '76c8304946576707e21d0fa0da0ec3c477b687a5':
Show work badge icon/description in InCallUI/Dialer
|
|
Add work badge icon into IncallUI
Add work description into incoming call notification
To see this feature
1. Receive/Make a call from work contact
(a contact in work profile has the phone number)
2. See work description in incoming call notification
and work badge icon in IncallUI
BUG=26082618
Change-Id: I182b48a34d3d87ee3093e8433ae33939705d59d7
|
|
am: ede2f7e1f7
* commit 'ede2f7e1f790a97db95f6d34f54e2839005b88ef':
Fix InCallUI crash when post char dialog is shown
|
|
am: 86a8382274
* commit '86a8382274b955670f920324cba697360677a3b8':
Fix InCallUI crash when post char dialog is shown
|
|
features
Following dialer's practice, use src-N and pre-N to separate implementation
in different build sdk
BUG=26312016
Change-Id: Ib80a377564ed5a57bcaf2a78ac746ffbeb20bdbd
|
|
When user makes MO video call with post char, such as ";", post char
dialog is shown when call is established.
At this time if user rotate InCallUI screen, InCallUI will crash
because PostCharDialogFragment has no zero argument constructor.
Add zero argument constructor for PostCharDialogFragment, and save the
needed parameter to Bundle.
Change-Id: I3587ad2bc47d4397b78b32d1ec27b8c914e9fb2f
|
|
Where a child number is present in the call extras, show it using the
text "via 650-555-1212" in the second line of the incoming call
notification.
Bug: 24585039
Change-Id: Ic9827f8518778bf5e9c36235e2e1b6525aba4928
(cherry picked from commit 2e5cfc1a71942e2ca2c8e469042e82c1b4640476)
|
|
Changes to fetch the no-caller ID reason from callsubject extra in the
call object to display in the InCall UI. The callsubject extra would be
populated by the RIL to hold the non-caller ID reason in case of number
presentation that is set to RESTRICTED/UNKOWN and hence we need to
differentiate the contents of this extra in InCallUI.
PS: We should ideally be creating a different extra for the no-caller ID
reason at telephony layer even if RIL sends it in the same exta as call
subject, but that would require API changes.
BUG: 22683773
Change-Id: I4ae51754d7660e4b8c1082d142e2c1860d3f1604
|
|
b/25613098 sometimes corrupt the bundle, resulting in a
IllegalArgumentException while validating.
Workaround with abandoning all the information in it.
The bypassed code only tries to extract data from the bundle, which can
already be null.
These are not critical for the dialer to function.
Bug:26343012
Bug:25613098
Change-Id: I16b05ecb0e5317f7170d80eb8426b5cdce20f6c2
# Conflicts:
# src/com/android/incallui/Call.java
|
|
This CL is in master branch, but not in dialer branch, which causes a
merge conflict in master for ag/841237
Reverting ag/841237, cherry-picking this and will reapply ag/841237
later.
The child number display functionality assumed that the child number for
a call would only bet set at the start of the call. This change removes
that assumption and supports changes to the child number at any point
during the call by adding a new listener to the InCall Call List. It
appears there are some instances in reality where the child number can
come in after the start of a call (delayed only slightly, but enough to
prevent the number from showing up).
Bug: 24585039
(cherry picked from commit 7a2da71d22645d619e04b1704138f183a5e47724)
Change-Id: Id019dcb1fcdc7f13d738d9917bc9bbc4fe15dc02
|
|
android.util.ArrayMap"
This reverts commit b1d3cff91f5fc15c7f75c9bef8928101d7bb33d5.
Change-Id: Ie3b063f24ff27d3b79b40dd3f1d069d2023f5ef2
|
|
b/25613098 sometimes corrupt the bundle, resulting in a
IllegalArgumentException while validating.
Workaround with abandoning all the information in it.
The bypassed code only tries to extract data from the bundle, which can
already be null.
These are not critical for the dialer to function.
Bug:25613098
Change-Id: I16b05ecb0e5317f7170d80eb8426b5cdce20f6c2
|
|
Convert TelecomManager direct usages to using TelecomManagerCompat
instead.
Bug: 25776171
Change-Id: I534eb9ff72968f4351aaa0a3856769226c2f1941
|
|
Bug: 25776171
Change-Id: I540df6effc01c7c677a874129938b390a446f751
|
|
1. To follow Google Caller id behavior in call log,
only find display name in cache, but not actively querying directory
2. To following cache behavior in search bar,
cache direcetory result in ObjectFactory.newCachedNumberLookupService()
Test:
Display name of directory contact is shown in call log if any of the below
1. the directory contact has ever been selected in search bar result
2. the directory contact has ever been called
BUG=25967633,25968895
Change-Id: I6f317bfd161c9abb0b7c6ccc2df2bd27af8ef5d3
|
|
ub-contactsdialer-b-dev
|
|
Some Call.Details capabilities are available in L-Mr1 instead of just M.
Switch to using those.
Bug: 25776171
Change-Id: I71b727a0ba66d68e5e628ff27feee74b9d4c3b07
|
|
Many of the VideoProfile methods in M came VideoProfile$VideoState
previously. Due to the single line nature of most of the methods, the
implementations are copied into the compat class to use in the event
that the sdk is earlier than M.
Bug=25776171
Change-Id: Ia597228a050e50f0efd4f79a458535ddb2925c83
|
|
Bug=25776171
Change-Id: Ie9604c0c52fc3927cfd13c7903a53a4233accf99
|
|
VideoProfile#videoStateToString, TelecomManager#getLine1Number, and
TelecomManager#isVoiceMailNumber don't exist in the L sdk, so Compat
classes were added which duplicated the needed logic.
Bug=25776171
Change-Id: Ib546b8fbd802aa6f8f5c712e59b99716db4c6a7b
|
|
In L, InCallService callbacks were implemented through the listener from
android.telecom.Phone. To backport, this Listener calls through to the
InCallService methods that are overridden in the implementing class
Also includes miscellaneous backporting fixes that were missed
previously.
Change-Id: If8896c72454496459b0e6ea575574161184fba40
|
|
In L, Call.Details.CAPABILITY_* constants were found in
android.telecom.PhoneCapabilities, it has been verified that the
constant values match as needed.
In L, Call.Details.getExtras had all the information that was moved to
Call.Details.getIntentExtras in M
Added android.telecom.Call.Details compat class
Change-Id: I16d25173382575f351762e0e5b71775f1046fdd0
|
|
* changes:
Switch from DialerCompatUtils to CompatUtils for video calling.
Ignore check for phone accounts when making call from pre-MSIM device.
|
|
Bug: 25776171
Change-Id: Iedc86109fe28ec98ac0240298f30757d768acb08
|
|
ub-contactsdialer-b-dev
|
|
Use the android.telecom.Call$Listener object since it's the same as the
android.telecom.Call$Callback and available in L. Use branching logic to
avoid calling system apis when sdk >= M
Bug: 25776171
Change-Id: I87b26df0415e5583456ee5a6be103fe14a53f9df
|
|
|
