| Age | Commit message (Collapse) | Author |
|---|
|
am: f75eb1ac9c
* commit 'f75eb1ac9c28f1777ac375666b731d08630dbf1d':
Rename PROPERTY_WORK_CALL to PROPERTY_ENTERPRISE_CALL based on API review
Change-Id: I5ad7d6c4ea3eeac5b829beb1c984d25abdb059c2
|
|
Bug: 28842878
Change-Id: I52684f898137d7b07c4b9a7ac34081b3d5ec79da
|
|
To minimize delays and avoid race conditions, trigger
internal the onStateChanged event upon receiving onUiReady
notification.
Bug: 27135373
Change-Id: Ib9a26c6dbda8f3897072e6a276a262e191557073
|
|
- Add new "ExternalCallNotifier" which tracks external calls that Telecom
informs Incall about.
- Refactored some common code from StatusBarNotifier that is used in
ExternalCallNotifier into NotificationUtil so it can be used in both
places.
- Modified CallList to track and store external calls seperately from
regular ones.
- Added support for triggering a call pull in the
NotificationBroadcastReceiver.
Bug: 27458894
Change-Id: I505c8b5f7aad273ebdaaeae2431564d10b23770b
(cherry picked from commit d8eb77f116ba21a4f40fd59d608b2e8bbdf2e09b)
|
|
into nyc-mr1-dev
|
|
The "pause video" button had a few issues that needed to be cleaned up:
1. The accessibility text for the button was always "pause video".
I've changed this so that it says, "Turn on camera" or "Turn off camera"
to better indicate what pushing the button will do.
2. When the user accepts an incoming request to initiate a 1-way video
call, the button state would not be correct (the user's camera is
disabled, but the button would not reflect that).
Bug: 27944419
Bug: 28550284
Change-Id: I2594971ec21b5714ca2d750894a93b758f7a80e5
|
|
- Glowpad wrapper is now seen when we receive an upgrade request as
showAnswerUi is called when onUpgradeToVideo callback is invoked
- Without this change, we don't see the Glowpad wrapper
BUG=28384174
Change-Id: Ibeb1a49f6cc9b8b0d70d167debf496f897c7c14f
|
|
|
|
|
|
|
|
Upgrade to video notification is not shown
when UE's screen is on and InCallUI is not
visible, e.g. pushed to backgroud by pressing
the Home button.
CL: 121482384
BUG=28093622
Change-Id: Ia141886b7a085164b3294a682f14b60b7a2a83b4
|
|
There were a few issues with the auto-fullscreen mode code which is present in
video calls.
1. If the Incall UI is backgrounded, the auto-fullscreen mode code would still
trigger and put the user into fullscreen mode when they return to the InCall
UI.
2. If the user is already in a video call and the remote party enables their
camera, the auto fullscreen mode code would trigger and enable fullscreen mode.
Ultimately we only want to go into fullscreen mode if we are entering a video
call from a non-video state.
3. It is possible for the call to cease to be a video call by the time the auto
fullscreen code triggers, meaning that an audio only call would go into
fullscreen mode:
Change-Id: I338a9ba4bb8d171752dcb38c16363bf0ded701af
CL: 120864913
Bug: 28093622
|
|
|
|
Bug: 28295752
Change-Id: Ifb81912db0df7ab2b7c01868d7d2daae836eeefb
|
|
In onStateChange, this branch of logic should be not be followed if mPrimary
is null.
Bug: 27045730
Change-Id: Ia948313d4886475dd5966b209c19696cb594ed59
(cherry picked from commit 89fa1dbb7e73766647a9de92da1b8164aa71471e)
(cherry picked from commit 6e01a29e201837a6084e156aee7edcd21e46c8bc)
|
|
Change-Id: If35d4744c3ada3a3d0ae6063dd1150e309ee5c59
Fix: 27926006
(cherry picked from commit e61465686d1ee1be8297c1e758c63ca0bff8ef47)
|
|
|
|
The VideoCall object is made of two binders -
one for sending requests to telecomm and another one for
receiving notifications from telecom. The initialization of
the latter is delayed since a message is posted on a handler
and initialization is done in the handler. getVideoCall()
of InCallUi's Call class deligates the call to telecom's
getVideoCall() function. Since UI events are asynchronous
request to open the camera is sent, however, if the response
is received before the initialization is complete in the handler
the response will be dropped and camera initialization will fail.
Modify the getVideoCall() function of the InCallUI's call to
return valid VideoCall object only when the object is fully
constructed.
BUG=27810744
Change-Id: Id864892bf8452161f2c6f526edd6e4ecc39bf5cd
|
|
|
|
The existing VT implementation assumed that video conference calling is
not supported, and hence that the "manage conference" option could not
be shown for a video call. This was based on early requirements, but since
the video conference calling has become a requirement for some carriers.
Removed the video call check in "shouldShowManageConference" and replaced
with a check for fullscreen mode. This ensures that when a video call is
in fullscreen immersive mode, the "manage conference" banner is hidden
along with the call card.
Also added code in "onFullscreenModeChanged" which hides or shows the
manage conference option as the user enters and exists full screen mode.
Bug: 27616422
Change-Id: Ie23ebe2a0aed2e46166468fa3e833072c0e7a34a
|
|
Show Answer UI on receiving upgrade request to enable
the user to respond to the upgrade request.
BUG=27876152
Change-Id: I62fbd32e1c3b40df2136bd88d271484be8af52b6
|
|
+ The code which silences the ringtone for incoming calls from
blocked numbers did not check to see if blocking should be disabled
due to a recent incoming call.
+ This CL fixes that issue and rearranges logic to improve logging.
Change-Id: I6034a0ba26db09624d7ca6beb6f52bea9fda558a
Fixes: 26687001
(cherry picked from commit 256281e25aaa4764334f60a4333b607c2a4d5573)
|
|
nyc-dev
|
|
For some accounts the call info lookup results were not being passed
to the ContactInfoCache, causing the Ui to not display emergency calls
correctly.
Bug: 27621628
Change-Id: Ic4b6e43d7033e4a869bac8435f5abba75bd3d504
|
|
+ This CL ensures that when we're checking if a number is voicemail,
we first check if we have the phone state permission. This is
required to avoid Telecom throwing a SecurityException.
Bug: 27062147
Change-Id: Iee88e01ca8c116e779134dba63d7f8dd6094ac4a
|
|
Query lookup uri with work lookup key directly is not allowed, app crashes
if doing so. And actually, all APIs do not support work lookup key
except those explicitly say it does.
This Cls changed two places:
1. Do not pass lookup uri with work lookup to NotificationManager to avoid
NotificationManager using the uri to query.
2. Dialer perform query for alternative display name using lookup key.
But if it is a work contact, do not do so.
Bug: 27146678
Change-Id: Ie59c37ff43b6f953a96564c446d79d8812f5ada1
|
|
+ By playing through AudioManager.STREAM_VOICE_CALL, routing audio to
bluetooth is handled properly for us.
+ This change removes the code that was preparing to manually play
the call waiting tone through bluetooth.
+ Small fix ups for javadoc
Bug: 26932998
Change-Id: Ib5f872c72cdfa44ab0bc2ff5d7e41645aba813ff
|
|
|
|
+ Previously we didn't have a notification for ongoing/incoming calls
to show users when they're on the lock screen and have their
notification settings set to 'hide sensitive notification content'.
This change adds that notification, to disambiguate between
notifications for calls and other notifications such as those for
missed calls.
+ This notification matches the version shown when the device is
unlocked except that we choose to not show work call information as
that is related to contact info.
See http://screen/zYZseSS1d54
Bug: 13387034
Change-Id: I02290e585a9b46eb9207adf8258a67d29882518b
|
|
1. Announce "unmute" if the mute button is checked
2. Annouce "hide dialpad" if the show dialpad button is checked.
Bug: 24296610
Change-Id: Idc3b78e49ca5ef2c01b2ab671b5e34ba54cc4f4e
|
|
nyc-dev
|
|
nyc-dev
|
|
dismissed." into nyc-dev
|
|
When an incoming call waiting call is received, the VideoPauseController
sends a "pause" command to the video provider.
However, upon dismissing the call waiting call, the foreground call
was not being unpaused.
Bug: 21815566
Change-Id: I637ab70d1b2adf4510dd87e5d56e233b1a3e065d
|
|
Bug: 24200862
Change-Id: I102a9c8406984a9dd4cfd8b91ec77254aa984dd5
|
|
|
|
Bug: 27231038
Change-Id: I721de663ae09489dd51cea0a70c5bca2d272fbf7
|
|
|
|
+ Need to remove for DP1
Bug=27367182
Bug=27353237
Change-Id: If370c942534bba3fd98c11447e1a83a2bf0cdfe1
|
|
+ Previously the Dialer would always play a vibration pattern for
incoming calls, regardless of whether the user toggled the vibrate
setting off. This change causes the Dialer to respect that setting.
Bug=27353237
Change-Id: I65987cea0c13dd50fba5e0edacfba88b3e3ecbd7
|
|
Bug: 27323979
Change-Id: I6f66052dee5ef3be32df4008835d0918bba54e50
|
|
Bug: 27294280
Change-Id: Ia5d6580ef77078b3d489efc0b73c2bbd2b4d2b77
|
|
|
|
Bug: 26862821,27250655
Change-Id: I1b5c35846f1a2d2dedaf2df9abf1f522270b1638
|
|
Now that we're no longer backwards compatible with Lollipop we don't
need CallAudioStateCompat. See ag/870962 for more info.
Bug: 26676586
Change-Id: I7c754d89a6c9e13bf5a004b7c5b15b88b9aff9ad
|
|
This CL adds a new build-library.gradle file for AOSP dialer.
This allows the dialer to be built as a library that can be
included from GoogleDialer.
Switching to a library project meant making two other changes:
- changed all switch statements that used resources to if statements.
This was required because resource IDs are not final in library
projects.
- changed InCalUI code to import com.android.dialer.R instead of
com.android.incallui.R. See http://b.android.com/82743 for more info
on why this is required.
src-N isn't supported yet. Also, this isn't the ideal project layout.
In the future we should consider switching to the following layout:
- dialer/incallui/ <- incall UI as an independent library project
- dialer/dialerlib/ <- dialer code as an independent library project
- dialer/app <- skelent app that builds a standalone dialer AOSP app
Bug: 26676586
Change-Id: I07fbee4d33cc683539e4f8b3953c93f1427af9d7
|
|
|
|
This CL removes support for running dialer on Android L MR1.
The change allows us to switch from the system SDK to the public SDK.
This is useful for the following reasons:
- makes it easier to switch to gradle
- makes it easier to migrate GoogleDialer to google3
- reduces maintenance overhead for unused code
Currently there's no plan to release Dialer on Lollipop. If or when
we decide to support Lollipop we can consider switching back to the
system SDK and restoring the comapatiblity code.
Bug: 26676586
Change-Id: Idac9e6e19f1d21c9261c1b0d0ff3e3ca4aab980b
|
|
into nyc-dev
|
|
Current dialer always queries PhoneLookup._ID and uses this as a contact
ID.
In pre-N, contact id of non-sip query is stored in PhoneLookup._ID and
it is actually a mistake. This problem does not exist in sip query,
and contact id of sip query is stored in Data.CONTACT_ID. So it is a "bug"
in dialer that we use PhoneLooup._ID for sip query as it is not really a
contacat id. The bug of missing work badge may not be the only issue
introduced by this.
In N, the issue is get fixed in framework, PhoneLookup.CONTACT_ID is
introduced. We should access PhoneLookup.CONTACT_ID no matter what
phone lookup query we are having.
The ideal case is we always use PhoneLookup.CONTACT_ID for retrieving
contact id, but given that we need to support in pre-N, we need to
query PhoneLookup._ID for contact id in non-sip query in pre-N.
BUG:27242975
Change-Id: Id14378e3dce5b07629ffe0c6e83c3d107fbb468e
|
|
|
|
+ When starting a call, we attempt to look up the ContactInfo. This
lookup needs to be guarded by a check to ensure we have permission to
read the contacts.
Bug=27078247
Change-Id: Id68de80d3acd721642b79ff81fda5d9decd67e7b
|
|
into nyc-dev
|
|
Do not create a new surface when setting surface dimensions.
Bug: 27246093
Change-Id: I3f66594141d548680427a7579169647018ca7eb7
|
|
into nyc-dev
|
|
Move the "onDialpadVisibilityChange()" listener call so that it takes
place regardless if the dialpad is animated on show-hide. That
listener triggers "updateFabPosition()" in callCardFragment, which
repositions the fab.
Bug: 27170964
Change-Id: I56588695c633205f4ebaac6d9685f543b9e09293
|
|
nyc-dev
|
|
When user pressed back key InCallActviity will be destroyed and
corresponding listeners in VideoCallPresenter will be removed.
Due to this we are unable to process the upgrade request.
Moving handling of upgrade Video Call request handling from
VideoCallPresenter to InCallPresenter as InCallPresenter will be
available even InCallActivity is destroyed.
Bug: 27130345
Change-Id: Idbd3348cea9d712c8391319d091642d1fd60964f
|
|
|
|
+ The code to make the Dialer play was disabled behind flags, this
change flips the flags so the Dialer is responsible for playing the
ringtone.
+ The in-code flag will be removed later after a QA pass of the
feature.
- Removed TODO to respect Do Not Disturb, see b/26936902
Bug=18702990
Change-Id: I773c1c614beb61a6763daccd2903d9d341cf4dc0
|
|
+ This API simplifies tests, specifically their tearDown methods.
Rather than needing to call ackMilestone numerous times to clean up
at the end of the test, this method can be called to ensure that the
thread running the production code isn't blocked on the tests.
Change-Id: I60730c52491b315aee571f4ae158f62d34b0dbc2
|
|
This change makes the Call Waiting tone actually play during the
Call Waiting use case.
+ Plugging InCallTonePlayer into the DialerRingtoneManager in the
StatusBarNotifier
+ Test fixes
+ Added tests for when Dialer ringing is disabled
+ Added tests for DialerRingtoneManager#playCallWaitingTone
- Removed unneeded @NeededForTesting annotations from InCallTonePlayer
since they won't be stipped out by proguard.
Change-Id: I49a83d2a7fe6edf5f9ec88db973a5f37e307f23a
|
|
+ This class will be used by the DialerRingtoneManager to play the
call waiting tone. It exists to encapsulate the logic to play a tone
in a background thread.
+ The TonePlayer includes some thread safety measures, but is not
meant to be shared between multiple threads
Bug=26936401
Change-Id: I630959177fcd8a4fc8ba7d3153f036746ad8a4cf
|
|
+ This class was needed to abstract out the logic to determine which
stream to play tones though. It is also easily mockable for use.
Change-Id: I382239483871b9aa1ef6fece7e66ea95f3fba4e0
|
|
Secondary info was previously hidden after the layout refactoring to
support resizing in multi-window mode. Make it visible and also keep it
at the bottom of the screen because the vertical screen real estate is
limited.
Bug: 26253432
Change-Id: I8e7f3b462784c7af62ccdb95e637595f7d382edd
|
|
+ Use a TestableExecutor in the production code to allow tests to
sync up and block so the state of the system can be tested. In the
tests the executor can wait until the production code hits a
milestone to ensure that the system is in a proper state for testing.
+ The current implementation only attempts to synchronize between one
production thread and one test thread. Extend the TestableExecutor
interface to perform additional synchronization.
Change-Id: Ie6fc64392e402330ab66c6f2cd0ec22200ebbdea
|
|
[cherry-pick from ag/864046]
Photo of directory contact in call log should not require internet access.
It's now cached locally.
BUG=26111304
Change-Id: I9848e6fe9487c09899fd77f21804bcb4537799a8
|
|
[cherry-pick from ag/862143]
Update cache only when the result is returned to InCall UI.
Now both call log and InCallUI take the callerinfo
which are first returned from provider.
When both personal and work profile directory lookup returns
a caller info, InCallUI takes the personal one, while cache
takes the work one. So it might result in the name being inconsistent
between 2 UIs. However, it's extremely rare as it's unlikely
to happen unless 2 corporate accounts under the same domain
are registered in personal and work respectively.
BUG=26819634
Change-Id: I87c4533635c0e2f88a639ca1c23611b2a22f6b07
|
|
This is a cherry-pick of partner CL in mm-wireless-dev.
In use-cases wherein UE receives waiting call or user tries to add call
soon after initiating a modify request, progress spinner is not hidden.
Fix this by clearing the progress spinner when primary call changes.
Change-Id: I3a5b28e36af3c73e797924cdf1b3cb87815296f1
|
|
+ ContactDisplayUtils's preferredName methods now accept the
ContactsPreferences object rather than just an int. This was done to
abstract out the null checks that were previously necessary when using
the utility.
+ Conference calls were crashing because the ContactsPreferences
object was attempting to access shared preferences while File based
encryption locked. This change makes use of the
ContactsPreferencesFactory to handle returning the proper instance
when in this locked case.
Bug=26822105
Change-Id: Ie382c0c615cf27f69682774fc9538828cc429e69
|
|
+ This change ensures that the Dialer doesn't try to use the
ContactsPreferences object (which uses information in unavailable
storage) while in File based encryption locked mode. Without these
checks, the Dialer crashes on receiving an incoming call while FBE
locked.
+ Added Factory method to create ContactsPreferences for tests/while
FBE locked/while FBE unlocked
+ Added tests for CallCardPresenter and StatusBarNotifier FBE related
code
Bug=26822105
Change-Id: I5df93526e70b7350885c7261982945c32b7e86a0
|
|
* changes:
Adding method to check if call waiting tone should be played
Refactored dialer Ringtone code in prep for call waiting
|
|
+ This method will be used in StatusBarNotifier to determine when
call waiting tones should be played instead of the standard ringtone
Change-Id: I4ad55f3870de5e63d03f4a5e8534680fa24556bd
|
|
+ Created class that is responsible for determining if a ringtone should
be played.
+ This class will also have the code to play call waiting tones
Change-Id: Ie8fb633c8a233cc6b54beeb09b3fd6b62c9cb76c
|
|
- Remote contact lookup was overwriting the cached contact specific
ringtone. This resulted in a longer wait time for the ringtone to
play since it would require the contact lookup to complete again.
- This CL prevents the cached ringtone from being overwritten.
Change-Id: I0a1cb30acd3aaf540533429c01427b185a7acf66
|
|
am: b68e8129c0
* commit 'b68e8129c056c60e78188e6fbcd6179406723eaa':
Adding flag to enable/disable Dialer ringing
|
|
Bug=26864105
Change-Id: Ifc565320dd9fd8845c45551454e59020806d985c
|
|
ub-contactsdialer-b-dev
am: 8a5ff66b41
* commit '8a5ff66b4136af7e7353d2b408a69262ee89013c':
Add downgrade to audio button for video calls.
|
|
ub-contactsdialer-b-dev
|
|
am: e8318d00f6
* commit 'e8318d00f6ed1ddbec23be052d6751076e87137c':
Play the ringtone for incoming calls in Dialer
|
|
+ Initial CL to make the Dialer play a ringtone for incoming calls.
- Not included in this CL:
- Playing call waiting tone
- Silencing ringer when volume key is pressed (power button works
properly)
- Bug fix for ringtone not playing when lockscreen is set
- Bug fix for contact look up taking too long - when do we play the
default ringtone
Change-Id: Ie8bd042b9ec142c78cb4d2de66475c96a18b8273
|
|
- Add downgrade to audio button for video calls where the call capabilities
indicates that it is supported.
- Requires N SDK or higher.
Bug: 22728624
Change-Id: I92aaf1d1e77da82c2ad982a57bb2eae599cff4da
|
|
into ub-contactsdialer-b-dev
am: ccfb9e42ea
* commit 'ccfb9e42ea60ba7a8f024d93da2b8c19657f8bf6':
Open work profile QuickContacts for work contacts in personal dialer
|
|
into ub-contactsdialer-b-dev
|
|
Set lookup key for enterprise contacts to allow QuickContacts to open it.
It requires framework change in NYC to support it.
BUG=26176780
Change-Id: I61345d52aa9fa296fdf95eca624b295c86925e46
|
|
ub-contactsdialer-b-dev
am: 8a63fc40cb
* commit '8a63fc40cbd04c9f3d3ce8bffac8340f62d19ddb':
Hiding addCall button while the device is fbe locked
|
|
am: db576118c0
* commit 'db576118c094a67b5c60b8c63f4426c9530ba94a':
Ensuring quickResponse isn't available while fbe locked
|
|
ub-contactsdialer-b-dev
|
|
Bug=26543932
Change-Id: I37c46404f20d16c91ab391c14b7f2d2cb5528630
|
|
+ Sending an outgoing message is not supported while in the fbe
locked state so the option to send an SMS should always be hidden.
Bug=26542221
Change-Id: I9d630bdf73ec9f6965607c60f36b7a04c04f4134
|
|
am: 23c6938d79
* commit '23c6938d7966e0b1121c60c66118b6f772c12730':
Add work description into call state in InCallUI
|
|
Only description of incoming call and call ended are affected
BUG=26082618
Change-Id: Ic511aac339b02db4453e695bfc92ccad47a97c83
|
|
am: 59978d307c
* commit '59978d307c8bf37d8ae7e333f0844aee5fedb329':
Showing badge icon in incall ui if it is a work call
|
|
am: dd8122a083
* commit 'dd8122a0831a44ef74e6b84ba97237edfa48815b':
Indicate the call is work call in notification
|
|
Work call means the call is placed through work phone account
or it is an outgoing call initiated from work dialer.
Please notice that both personal and work call is handled by personal
in-call UI, that's why we need to add a badge to indicate it.
There is another scenario we need to add badge, ie. having a work
contact caller, and it will be handled in ag/836110.
BUG=26022174
Change-Id: I96e72068f70674dbeabfbbf7bfffc6c15c3203bf
|
|
Bug: 26022174
Change-Id: I5f28e3fa47c91787fbc5c82b68316a8baa11d286
|
|
am: 76c8304946
* commit '76c8304946576707e21d0fa0da0ec3c477b687a5':
Show work badge icon/description in InCallUI/Dialer
|
|
Add work badge icon into IncallUI
Add work description into incoming call notification
To see this feature
1. Receive/Make a call from work contact
(a contact in work profile has the phone number)
2. See work description in incoming call notification
and work badge icon in IncallUI
BUG=26082618
Change-Id: I182b48a34d3d87ee3093e8433ae33939705d59d7
|
|
am: ede2f7e1f7
* commit 'ede2f7e1f790a97db95f6d34f54e2839005b88ef':
Fix InCallUI crash when post char dialog is shown
|
|
am: 86a8382274
* commit '86a8382274b955670f920324cba697360677a3b8':
Fix InCallUI crash when post char dialog is shown
|
