summaryrefslogtreecommitdiff
path: root/InCallUI/src/com/android/incallui
AgeCommit message (Collapse)Author
2016-04-22Fix crash on accessibility service. am: 02bf9ac am: fe3157cQi Wang
am: 08276ee * commit '08276eeb1f121b06c65c6e6b837e6fc6655d2e63': Fix crash on accessibility service. Change-Id: I0499acc592278242cf8625d59cd7c071b9958002
2016-04-20Fix crash on accessibility service.Qi Wang
Change-Id: If35d4744c3ada3a3d0ae6063dd1150e309ee5c59 Fix: 27926006 (cherry picked from commit e61465686d1ee1be8297c1e758c63ca0bff8ef47)
2016-04-12Add after call notification code in InCallUI.Sarmad Hashmi
+Add asynchronous call to update inCallHistory boolean variable which specifies whether the number is in the call history (has previously called before) +Add CallHistoryStatus enum and variable to Call object to determine if the number is present in the call history +Added SpamCallListListener object which listens for changes in the CallList +Update the CallHistoryStatus for the call whenever an incoming call comes in +Added 11 tests for new listener BUG=27323295 Change-Id: I242cd4a53b3aeca69fbce972221a2c941d9d37ce
2016-04-07Merge "IMS-VT: Fix race-condition causing preview freeze." into nyc-dev am: ↵Tyler Gunn
1f77177 am: d75990c * commit 'd75990c1c893caf86cc09a2ccf6d0c3937401194': IMS-VT: Fix race-condition causing preview freeze. Change-Id: I4162ad954b4d78c365265bded0c720935553368c
2016-04-07Merge "IMS-VT: Fix race-condition causing preview freeze." into nyc-devTyler Gunn
2016-04-07IMS-VT: Fix race-condition causing preview freeze.Omkar Kolangade
The VideoCall object is made of two binders - one for sending requests to telecomm and another one for receiving notifications from telecom. The initialization of the latter is delayed since a message is posted on a handler and initialization is done in the handler. getVideoCall() of InCallUi's Call class deligates the call to telecom's getVideoCall() function. Since UI events are asynchronous request to open the camera is sent, however, if the response is received before the initialization is complete in the handler the response will be dropped and camera initialization will fail. Modify the getVideoCall() function of the InCallUI's call to return valid VideoCall object only when the object is fully constructed. BUG=27810744 Change-Id: Id864892bf8452161f2c6f526edd6e4ecc39bf5cd
2016-04-07Merge "IMS-VT: Show Answer UI on receiving upgrade request" into nyc-dev am: ↵Tyler Gunn
d9d80c6 am: d2d5cf4 * commit 'd2d5cf44745be6023ac023673cd7d70c20591712': IMS-VT: Show Answer UI on receiving upgrade request Change-Id: I8330c947311bc17516baaef88d33ba53a67e9064
2016-04-07Merge "IMS-VT: Show Answer UI on receiving upgrade request" into nyc-devTyler Gunn
2016-04-07Show "manage conference" for video calls. am: 84a1becTyler Gunn
am: aab8998 * commit 'aab8998d6e38ee771aa5c1ca06691b9bad7c141c': Show "manage conference" for video calls. Change-Id: Ic1f3afa1270ded8ad31a52ba1c814231acd3bbed
2016-04-07Show "manage conference" for video calls.Tyler Gunn
The existing VT implementation assumed that video conference calling is not supported, and hence that the "manage conference" option could not be shown for a video call. This was based on early requirements, but since the video conference calling has become a requirement for some carriers. Removed the video call check in "shouldShowManageConference" and replaced with a check for fullscreen mode. This ensures that when a video call is in fullscreen immersive mode, the "manage conference" banner is hidden along with the call card. Also added code in "onFullscreenModeChanged" which hides or shows the manage conference option as the user enters and exists full screen mode. Bug: 27616422 Change-Id: Ie23ebe2a0aed2e46166468fa3e833072c0e7a34a
2016-04-05Don't show spam indicator if incoming call number is in local contacts.Qi Wang
Change-Id: Iec81cd7432bfe7b8d1a5d74fc483ec51568f9f05 Fix: 27321333
2016-04-05IMS-VT: Show Answer UI on receiving upgrade requestGarik Badalyan
Show Answer UI on receiving upgrade request to enable the user to respond to the upgrade request. BUG=27876152 Change-Id: I62fbd32e1c3b40df2136bd88d271484be8af52b6
2016-04-04Merge "Integrate spam feature into call logs."Qi Wang
2016-04-04Integrate spam feature into call logs.Qi Wang
+ Add block and report spam actions. + Show spam icon and label for call log item. + Add stableIds for CallLogAdapter to improve performance(reuse same viewItem to minimize update work). * Fix funky UI of call log. Change-Id: I6144d70b6a8e38061e1447d0d01910d53026d1db Fix: 27295728 Fix: 26907466
2016-04-01Add support for multi-endpoint.Tyler Gunn
- Add new "ExternalCallNotifier" which tracks external calls that Telecom informs Incall about. - Refactored some common code from StatusBarNotifier that is used in ExternalCallNotifier into NotificationUtil so it can be used in both places. - Modified CallList to track and store external calls seperately from regular ones. - Added support for triggering a call pull in the NotificationBroadcastReceiver. Bug: 27458894 Change-Id: I505c8b5f7aad273ebdaaeae2431564d10b23770b
2016-03-31Fixing blocked number ringtone after E911 call am: bb69f18Brandon Maxwell
am: e7855fd * commit 'e7855fd7aef7ad9de0f3d26f1003137e1147dc2c': Fixing blocked number ringtone after E911 call Change-Id: I72af31ed192ed18056305528a5066e42f9e943e4
2016-03-31Fixing blocked number ringtone after E911 callBrandon Maxwell
+ The code which silences the ringtone for incoming calls from blocked numbers did not check to see if blocking should be disabled due to a recent incoming call. + This CL fixes that issue and rearranges logic to improve logging. Change-Id: I6034a0ba26db09624d7ca6beb6f52bea9fda558a Fixes: 26687001 (cherry picked from commit 256281e25aaa4764334f60a4333b607c2a4d5573)
2016-03-30Fix Dialer crash loop for caller id in personal contact directoryVictor Chang
The bug is dialer queries CP2 for alternative name by lookup key of personal directory CP2 throws IllegalArgumentException as the lookup key is not found locally 2 fixes are included to avoid this happening 1. slient IllegalArgumentException since alternative name is not very important to crash dialer. (It's a fix by reverting some changes in ag/880910) 2. Check directory id before querying CP2 either one should fix this bug. Include both to make sure that it's not crashed. Unit test added. Bug:27905000 Change-Id: Ib8eab5f718a168fcec2785c3101e96bb91521d40
2016-03-28Add spam indicator for notification and incoming call of incallui.Qi Wang
+ Add spam icon and label in notification of incoming call. + Add spam icon and label in primary call info of incall screen. + Change background color and status bar color if primary caller is spam. Screenshots: https://screenshot.googleplex.com/WFob2oPdXZd https://screenshot.googleplex.com/ddCfg91Anef Bug: 27611253 Change-Id: I03b3754f69631f5f6b07932b1a0006407b93c6e8
2016-03-18Merge "Fixing bug that prevented \'Emergency call\' from being displayed" ↵mike dooley
into nyc-dev am: 624f6c4 am: 3023298 * commit '3023298a09f00b57fee6c2a3bc15c85294fa6ca4': Fixing bug that prevented 'Emergency call' from being displayed
2016-03-18Merge "Fixing bug that prevented 'Emergency call' from being displayed" into ↵Michael Dooley
nyc-dev
2016-03-17Fixing bug that prevented 'Emergency call' from being displayedmike dooley
For some accounts the call info lookup results were not being passed to the ContactInfoCache, causing the Ui to not display emergency calls correctly. Bug: 27621628 Change-Id: Ic4b6e43d7033e4a869bac8435f5abba75bd3d504
2016-03-17Merge "Fixing securityException issue" into nyc-dev am: 3d7939dBrandon Maxwell
am: 625cc92 * commit '625cc92c3dbfec8d8b6e873cfeb54166f4d2b1f3': Fixing securityException issue
2016-03-16Fixing securityException issueBrandon Maxwell
+ This CL ensures that when we're checking if a number is voicemail, we first check if we have the phone state permission. This is required to avoid Telecom throwing a SecurityException. Bug: 27062147 Change-Id: Iee88e01ca8c116e779134dba63d7f8dd6094ac4a
2016-03-11Merge "Query lookup uri with work lookup key directly is not allowed" into ↵Tony Mak
nyc-dev am: ebfbfa10d9 am: 769f26fe74 * commit '769f26fe7488415cb677d4980540bbd7dcfc3ac0': Query lookup uri with work lookup key directly is not allowed
2016-03-11Query lookup uri with work lookup key directly is not allowedTony Mak
Query lookup uri with work lookup key directly is not allowed, app crashes if doing so. And actually, all APIs do not support work lookup key except those explicitly say it does. This Cls changed two places: 1. Do not pass lookup uri with work lookup to NotificationManager to avoid NotificationManager using the uri to query. 2. Dialer perform query for alternative display name using lookup key. But if it is a work contact, do not do so. Bug: 27146678 Change-Id: Ie59c37ff43b6f953a96564c446d79d8812f5ada1
2016-03-11Removing unneed bluetooth code am: 5558f89b14Brandon Maxwell
am: 2f0019f9b6 * commit '2f0019f9b6aebf9e61f579ec34595e45180947ce': Removing unneed bluetooth code
2016-03-10Removing unneed bluetooth codeBrandon Maxwell
+ By playing through AudioManager.STREAM_VOICE_CALL, routing audio to bluetooth is handled properly for us. + This change removes the code that was preparing to manually play the call waiting tone through bluetooth. + Small fix ups for javadoc Bug: 26932998 Change-Id: Ib5f872c72cdfa44ab0bc2ff5d7e41645aba813ff
2016-03-02Merge "Added public notification for calls" into nyc-dev am: d78f93b443Brandon Maxwell
am: 43e844eaa4 * commit '43e844eaa4224050bbbac335bdf049eb4cf074f7': Added public notification for calls
2016-03-02Merge "Provide better talkback for buttons in calling." into nyc-dev am: ↵Qi Wang
ae2b330d68 am: c82ffa7cf2 * commit 'c82ffa7cf29df64f5309f06199e7757ec0b2b9b4': Provide better talkback for buttons in calling.
2016-03-02Merge "Fix bug of secondary call info disappear after switching calls." into ↵Qi Wang
nyc-dev am: 008c82f409 am: 32f66bda67 * commit '32f66bda678994084dc0ab84e055dd5fe4b7a718': Fix bug of secondary call info disappear after switching calls.
2016-03-02Merge "Accessibility: announce the active call after switching calls." into ↵Qi Wang
nyc-dev am: af5880f151 am: c98bc9613e * commit 'c98bc9613ea8ac8e00400898338e802e536a9bce': Accessibility: announce the active call after switching calls.
2016-03-02Merge "Fix issue where video does not un-pause after call waiting ↵Tyler Gunn
dismissed." into nyc-dev am: 9ae9630e9c am: de54e21caf * commit 'de54e21cafdf72fc5a4c4ac6e30d03294d096c1f': Fix issue where video does not un-pause after call waiting dismissed.
2016-03-02Merge "Added public notification for calls" into nyc-devBrandon Maxwell
2016-03-01Added public notification for callsBrandon Maxwell
+ Previously we didn't have a notification for ongoing/incoming calls to show users when they're on the lock screen and have their notification settings set to 'hide sensitive notification content'. This change adds that notification, to disambiguate between notifications for calls and other notifications such as those for missed calls. + This notification matches the version shown when the device is unlocked except that we choose to not show work call information as that is related to contact info. See http://screen/zYZseSS1d54 Bug: 13387034 Change-Id: I02290e585a9b46eb9207adf8258a67d29882518b
2016-03-01Provide better talkback for buttons in calling.Qi Wang
1. Announce "unmute" if the mute button is checked 2. Annouce "hide dialpad" if the show dialpad button is checked. Bug: 24296610 Change-Id: Idc3b78e49ca5ef2c01b2ab671b5e34ba54cc4f4e
2016-03-01Merge "Fix bug of secondary call info disappear after switching calls." into ↵Qi Wang
nyc-dev
2016-03-01Merge "Accessibility: announce the active call after switching calls." into ↵Qi Wang
nyc-dev
2016-03-01Merge "Fix issue where video does not un-pause after call waiting ↵Tyler Gunn
dismissed." into nyc-dev
2016-03-01Fix issue where video does not un-pause after call waiting dismissed.Tyler Gunn
When an incoming call waiting call is received, the VideoPauseController sends a "pause" command to the video provider. However, upon dismissing the call waiting call, the foreground call was not being unpaused. Bug: 21815566 Change-Id: I637ab70d1b2adf4510dd87e5d56e233b1a3e065d
2016-02-29Accessibility: announce the active call after switching calls.Qi Wang
Bug: 24200862 Change-Id: I102a9c8406984a9dd4cfd8b91ec77254aa984dd5
2016-02-27Merge "Add back button to dialpad in callui" into nyc-dev am: 2ff80ef65aQi Wang
am: 25c55157c4 * commit '25c55157c416fcd8371f691bb6aa1e47d5d2a62d': Add back button to dialpad in callui
2016-02-27Merge "Add back button to dialpad in callui" into nyc-devQi Wang
2016-02-26Add back button to dialpad in calluiQi Wang
Bug: 27231038 Change-Id: I721de663ae09489dd51cea0a70c5bca2d272fbf7
2016-02-26Merge "Disabling Dialer ringing feature" into nyc-dev am: 9cff658da2Brandon Maxwell
am: 2e8f566867 * commit '2e8f566867541e1559a82b9f9e23d99e32cdadf8': Disabling Dialer ringing feature
2016-02-26Merge "Disabling Dialer ringing feature" into nyc-devBrandon Maxwell
2016-02-25Disabling Dialer ringing featureBrandon Maxwell
+ Need to remove for DP1 Bug=27367182 Bug=27353237 Change-Id: If370c942534bba3fd98c11447e1a83a2bf0cdfe1
2016-02-26Merge "Respect setting for incoming call to vibrate" into nyc-dev am: 0eeee8b2e0Brandon Maxwell
am: 5ec71527e2 * commit '5ec71527e2d6ed4c24e21a99ac7e820df68b7362': Respect setting for incoming call to vibrate
2016-02-25Respect setting for incoming call to vibrateBrandon Maxwell
+ Previously the Dialer would always play a vibration pattern for incoming calls, regardless of whether the user toggled the vibrate setting off. This change causes the Dialer to respect that setting. Bug=27353237 Change-Id: I65987cea0c13dd50fba5e0edacfba88b3e3ecbd7
2016-02-24Fix bug of secondary call info disappear after switching calls.Qi Wang
Bug: 27323979 Change-Id: I6f66052dee5ef3be32df4008835d0918bba54e50
2016-02-24Merge "Fix FAB position after hang up with secondary call." into nyc-dev am: ↵Qi Wang
f0bf4ca8ca am: 1368a4b0d1 * commit '1368a4b0d10269e4e25a2cd7f17ebb5af0a91d79': Fix FAB position after hang up with secondary call.
2016-02-23Fix FAB position after hang up with secondary call.Qi Wang
Bug: 27294280 Change-Id: Ia5d6580ef77078b3d489efc0b73c2bbd2b4d2b77
2016-02-24Merge "Let InCallActivity handle resize config change." into nyc-dev am: ↵Qi Wang
82557da65e am: 3f07759954 * commit '3f07759954ffed1ea48d6f345098e2d97b79b33a': Let InCallActivity handle resize config change.
2016-02-24Merge "Let InCallActivity handle resize config change." into nyc-devQi Wang
2016-02-23Let InCallActivity handle resize config change.Qi Wang
Bug: 26862821,27250655 Change-Id: I1b5c35846f1a2d2dedaf2df9abf1f522270b1638
2016-02-22Remove CallAudioStateCompat am: e4be64852dSailesh Nepal
am: 803a8afbcc * commit '803a8afbcc22d1daafbea011ddd7a8bf8b30765c': Remove CallAudioStateCompat
2016-02-22[Gradle] Allow dialer to be compiled as a library am: 68d86c656eSailesh Nepal
am: 429e15a3de * commit '429e15a3de2e5cfbc2c44071e97981e583f1ed15': [Gradle] Allow dialer to be compiled as a library
2016-02-22Merge "Remove Lollipop support for InCallUI" into nyc-dev am: fd70e58784Sailesh Nepal
am: b64b56dd45 * commit 'b64b56dd457d5f3bd32f4933808eb3f4629e0e83': Remove Lollipop support for InCallUI
2016-02-22Merge "Show Briefcase icon not displayed in in-call UI for work SIP calls" ↵Tony Mak
into nyc-dev am: 639ed3451d am: c58829eee0 * commit 'c58829eee08d834b40909ea780ba666af44262ed': Show Briefcase icon not displayed in in-call UI for work SIP calls
2016-02-22Remove CallAudioStateCompatSailesh Nepal
Now that we're no longer backwards compatible with Lollipop we don't need CallAudioStateCompat. See ag/870962 for more info. Bug: 26676586 Change-Id: I7c754d89a6c9e13bf5a004b7c5b15b88b9aff9ad
2016-02-22[Gradle] Allow dialer to be compiled as a librarySailesh Nepal
This CL adds a new build-library.gradle file for AOSP dialer. This allows the dialer to be built as a library that can be included from GoogleDialer. Switching to a library project meant making two other changes: - changed all switch statements that used resources to if statements. This was required because resource IDs are not final in library projects. - changed InCalUI code to import com.android.dialer.R instead of com.android.incallui.R. See http://b.android.com/82743 for more info on why this is required. src-N isn't supported yet. Also, this isn't the ideal project layout. In the future we should consider switching to the following layout: - dialer/incallui/ <- incall UI as an independent library project - dialer/dialerlib/ <- dialer code as an independent library project - dialer/app <- skelent app that builds a standalone dialer AOSP app Bug: 26676586 Change-Id: I07fbee4d33cc683539e4f8b3953c93f1427af9d7
2016-02-22Merge "Remove Lollipop support for InCallUI" into nyc-devSailesh Nepal
2016-02-22Remove Lollipop support for InCallUISailesh Nepal
This CL removes support for running dialer on Android L MR1. The change allows us to switch from the system SDK to the public SDK. This is useful for the following reasons: - makes it easier to switch to gradle - makes it easier to migrate GoogleDialer to google3 - reduces maintenance overhead for unused code Currently there's no plan to release Dialer on Lollipop. If or when we decide to support Lollipop we can consider switching back to the system SDK and restoring the comapatiblity code. Bug: 26676586 Change-Id: Idac9e6e19f1d21c9261c1b0d0ff3e3ca4aab980b
2016-02-22Merge "Show Briefcase icon not displayed in in-call UI for work SIP calls" ↵Tony Mak
into nyc-dev
2016-02-22Show Briefcase icon not displayed in in-call UI for work SIP callsTony Mak
Current dialer always queries PhoneLookup._ID and uses this as a contact ID. In pre-N, contact id of non-sip query is stored in PhoneLookup._ID and it is actually a mistake. This problem does not exist in sip query, and contact id of sip query is stored in Data.CONTACT_ID. So it is a "bug" in dialer that we use PhoneLooup._ID for sip query as it is not really a contacat id. The bug of missing work badge may not be the only issue introduced by this. In N, the issue is get fixed in framework, PhoneLookup.CONTACT_ID is introduced. We should access PhoneLookup.CONTACT_ID no matter what phone lookup query we are having. The ideal case is we always use PhoneLookup.CONTACT_ID for retrieving contact id, but given that we need to support in pre-N, we need to query PhoneLookup._ID for contact id in non-sip query in pre-N. BUG:27242975 Change-Id: Id14378e3dce5b07629ffe0c6e83c3d107fbb468e
2016-02-19Merge "Checking for READ_CONTACTS permission" into nyc-dev am: 3072b0c6b2Brandon Maxwell
am: ff3e825369 * commit 'ff3e825369e260b155d5d1865dacb8235ea7af19': Checking for READ_CONTACTS permission
2016-02-19Merge "Checking for READ_CONTACTS permission" into nyc-devBrandon Maxwell
2016-02-18Checking for READ_CONTACTS permissionBrandon Maxwell
+ When starting a call, we attempt to look up the ContactInfo. This lookup needs to be guarded by a check to ensure we have permission to read the contacts. Bug=27078247 Change-Id: Id68de80d3acd721642b79ff81fda5d9decd67e7b
2016-02-18Merge "IMS-VT: Do not create new surface when setting surface dimensions" ↵Tyler Gunn
into nyc-dev am: 73fb5b37a7 am: a3e5164c53 * commit 'a3e5164c532488b2a20deb6cdccb54b919c0a110': IMS-VT: Do not create new surface when setting surface dimensions
2016-02-18Merge "Fix end-call FAB position when dial pad is shown on device rotate." ↵Tyler Gunn
into nyc-dev am: ebddd94caf am: 3868a4a974 * commit '3868a4a974f0d63f7440d2f27d92e4284979afb6': Fix end-call FAB position when dial pad is shown on device rotate.
2016-02-18Merge "IMS-VT: Do not create new surface when setting surface dimensions" ↵Tyler Gunn
into nyc-dev
2016-02-18IMS-VT: Do not create new surface when setting surface dimensionsOmkar Kolangade
Do not create a new surface when setting surface dimensions. Bug: 27246093 Change-Id: I3f66594141d548680427a7579169647018ca7eb7
2016-02-18Merge "IMS-VT: Moving upgradeVideoRequest handling to InCallPresenter" into ↵Tyler Gunn
nyc-dev am: d1f0d57602 am: aac29b4966 * commit 'aac29b49662558f55d737fe2bb7f5060eddd1092': IMS-VT: Moving upgradeVideoRequest handling to InCallPresenter
2016-02-18Merge "Fix end-call FAB position when dial pad is shown on device rotate." ↵Tyler Gunn
into nyc-dev
2016-02-18Fix end-call FAB position when dial pad is shown on device rotate.Tyler Gunn
Move the "onDialpadVisibilityChange()" listener call so that it takes place regardless if the dialpad is animated on show-hide. That listener triggers "updateFabPosition()" in callCardFragment, which repositions the fab. Bug: 27170964 Change-Id: I56588695c633205f4ebaac6d9685f543b9e09293
2016-02-18Merge "IMS-VT: Moving upgradeVideoRequest handling to InCallPresenter" into ↵Tyler Gunn
nyc-dev
2016-02-18IMS-VT: Moving upgradeVideoRequest handling to InCallPresenterTyler Gunn
When user pressed back key InCallActviity will be destroyed and corresponding listeners in VideoCallPresenter will be removed. Due to this we are unable to process the upgrade request. Moving handling of upgrade Video Call request handling from VideoCallPresenter to InCallPresenter as InCallPresenter will be available even InCallActivity is destroyed. Bug: 27130345 Change-Id: Idbd3348cea9d712c8391319d091642d1fd60964f
2016-02-17Merge "Make secondary info visible for multi-window InCallUI." into nyc-dev ↵Nancy Chen
am: e52c87274f am: f47151d1a2 * commit 'f47151d1a203e7f98c127123e35544b5383b59b1': Make secondary info visible for multi-window InCallUI.
2016-02-17Merge "Make secondary info visible for multi-window InCallUI." into nyc-devNancy Chen
2016-02-16Enabling Dialer to play ringtones am: 9172c905b3Brandon Maxwell
am: d557bc2ba8 * commit 'd557bc2ba817a071005e18f006f7e80eacc506c8': Enabling Dialer to play ringtones
2016-02-16Enabling Dialer to play ringtonesBrandon Maxwell
+ The code to make the Dialer play was disabled behind flags, this change flips the flags so the Dialer is responsible for playing the ringtone. + The in-code flag will be removed later after a QA pass of the feature. - Removed TODO to respect Do Not Disturb, see b/26936902 Bug=18702990 Change-Id: I773c1c614beb61a6763daccd2903d9d341cf4dc0
2016-02-13Added ackAllMilestones api to PausableExecutor am: 90820a50b6Brandon Maxwell
am: c677fc1540 * commit 'c677fc15403996055d2c6fa73e7ff0928bd218b9': Added ackAllMilestones api to PausableExecutor
2016-02-13Integrating DialerRingtoneManager and InCallTonePlayer am: 054559b6c2Brandon Maxwell
am: 97fbfe5baa * commit '97fbfe5baaccbd06c19ebde6636ca500278a21f2': Integrating DialerRingtoneManager and InCallTonePlayer
2016-02-12Added ackAllMilestones api to PausableExecutorBrandon Maxwell
+ This API simplifies tests, specifically their tearDown methods. Rather than needing to call ackMilestone numerous times to clean up at the end of the test, this method can be called to ensure that the thread running the production code isn't blocked on the tests. Change-Id: I60730c52491b315aee571f4ae158f62d34b0dbc2
2016-02-12Integrating DialerRingtoneManager and InCallTonePlayerBrandon Maxwell
This change makes the Call Waiting tone actually play during the Call Waiting use case. + Plugging InCallTonePlayer into the DialerRingtoneManager in the StatusBarNotifier + Test fixes + Added tests for when Dialer ringing is disabled + Added tests for DialerRingtoneManager#playCallWaitingTone - Removed unneeded @NeededForTesting annotations from InCallTonePlayer since they won't be stipped out by proguard. Change-Id: I49a83d2a7fe6edf5f9ec88db973a5f37e307f23a
2016-02-12Merge "Implementing class to play tones" into nyc-dev am: a37612a50aBrandon Maxwell
am: b12e25acbd * commit 'b12e25acbd1550c61eaa652f60125b93d4a5da03': Implementing class to play tones
2016-02-12Merge "Added factory to create ToneGenerators" into nyc-dev am: f4b665e44bBrandon Maxwell
am: 4074ba2c11 * commit '4074ba2c112b1f7ab9a04d5a2b96c7cd5fd70a17': Added factory to create ToneGenerators
2016-02-12Implementing class to play tonesBrandon Maxwell
+ This class will be used by the DialerRingtoneManager to play the call waiting tone. It exists to encapsulate the logic to play a tone in a background thread. + The TonePlayer includes some thread safety measures, but is not meant to be shared between multiple threads Bug=26936401 Change-Id: I630959177fcd8a4fc8ba7d3153f036746ad8a4cf
2016-02-12Added factory to create ToneGeneratorsBrandon Maxwell
+ This class was needed to abstract out the logic to determine which stream to play tones though. It is also easily mockable for use. Change-Id: I382239483871b9aa1ef6fece7e66ea95f3fba4e0
2016-02-12Make secondary info visible for multi-window InCallUI.Nancy Chen
Secondary info was previously hidden after the layout refactoring to support resizing in multi-window mode. Make it visible and also keep it at the bottom of the screen because the vertical screen real estate is limited. Bug: 26253432 Change-Id: I8e7f3b462784c7af62ccdb95e637595f7d382edd
2016-02-12Added executor framework to sync prod and tests am: 7ba4e96fdcBrandon Maxwell
am: 4c6d68244b * commit '4c6d68244beab9c9855594ab88168eb855496ac0': Added executor framework to sync prod and tests
2016-02-12Added executor framework to sync prod and testsBrandon Maxwell
+ Use a TestableExecutor in the production code to allow tests to sync up and block so the state of the system can be tested. In the tests the executor can wait until the production code hits a milestone to ensure that the system is in a proper state for testing. + The current implementation only attempts to synchronize between one production thread and one test thread. Extend the TestableExecutor interface to perform additional synchronization. Change-Id: Ie6fc64392e402330ab66c6f2cd0ec22200ebbdea
2016-02-11Cache directory photo in app storage through CachedNumberLookupServiceVictor Chang
[cherry-pick from ag/864046] Photo of directory contact in call log should not require internet access. It's now cached locally. BUG=26111304 Change-Id: I9848e6fe9487c09899fd77f21804bcb4537799a8
2016-02-11Make work badge in call log consistent with InCallVictor Chang
[cherry-pick from ag/862143] Update cache only when the result is returned to InCall UI. Now both call log and InCallUI take the callerinfo which are first returned from provider. When both personal and work profile directory lookup returns a caller info, InCallUI takes the personal one, while cache takes the work one. So it might result in the name being inconsistent between 2 UIs. However, it's extremely rare as it's unlikely to happen unless 2 corporate accounts under the same domain are registered in personal and work respectively. BUG=26819634 Change-Id: I87c4533635c0e2f88a639ca1c23611b2a22f6b07
2016-02-11Cache directory photo in app storage through CachedNumberLookupServiceVictor Chang
[cherry-pick from ag/861979] Photo of directory contact in call log should not require internet access. It's now cached locally. BUG=26111304 Change-Id: I9848e6fe9487c09899fd77f21804bcb4537799a8
2016-02-10Merge "Make work badge in call log consistent with InCall"Victor Chang
2016-02-09IMS-VT: Clear progress spinner when primary call changes am: 2556c5cfb6Tyler Gunn
am: 1124c2fb24 * commit '1124c2fb24777f7b49e1c2311c2d88f6974e80a3': IMS-VT: Clear progress spinner when primary call changes
2016-02-09IMS-VT: Clear progress spinner when primary call changesTyler Gunn
This is a cherry-pick of partner CL in mm-wireless-dev. In use-cases wherein UE receives waiting call or user tries to add call soon after initiating a modify request, progress spinner is not hidden. Fix this by clearing the progress spinner when primary call changes. Change-Id: I3a5b28e36af3c73e797924cdf1b3cb87815296f1
2016-02-09Make work badge in call log consistent with InCallVictor Chang
Update cache only when the result is returned to InCall UI. Now both call log and InCallUI take the callerinfo which are first returned from provider. When both personal and work profile directory lookup returns a caller info, InCallUI takes the personal one, while cache takes the work one. So it might result in the name being inconsistent between 2 UIs. However, it's extremely rare as it's unlikely to happen unless 2 corporate accounts under the same domain are registered in personal and work respectively. BUG=26819634 Change-Id: I87c4533635c0e2f88a639ca1c23611b2a22f6b07
2016-02-08Merge "Fix NPE caused by misplaced parenthesis."Nancy Chen