summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-10-30Always hide blocked calls.Andrew Lee
- Remove setting for show/hide. - Remove utilities and behaviors for show/hide. ~ Continue filtering blocked call types in call log (which may be marked by other applications.) ~ Change behavior after blocking call; instead of keeping the call log entry but changing the type to BLOCKED, delete it instead. + Default behavior is now to delete entries and visual voicemails of blocked calls. Bug: 25378068 Bug: 25106387 Change-Id: I8cbc419b25cce6ba39099857cffe4eb1df9d0bef
2015-10-29Merge "Fix method calling itself. >_<" into ub-contactsdialer-a-devAndrew Lee
2015-10-29Fix method calling itself. >_<Andrew Lee
Bug: 25368270 Change-Id: Ie668b4f6cd029260440bafaf7951957a81cd7632
2015-10-28Removed padding at bottom of list item actions.Andrew Lee
When interacting, this causes an awkward ripple which doesn't reach the edge. Change-Id: I0b837d8159cb53584ecc779f8bed89ce554ddfa8
2015-10-29Merge "Rename activity for blocked numbers settings." into ↵Andrew Lee
ub-contactsdialer-a-dev
2015-10-28Rename activity for blocked numbers settings.Andrew Lee
Manage is more related to a specific screen, new name seems to make more sense based on location in settings menu of application. Bug: 25343277 Change-Id: Ia45c1b7aa91c045078fd1473500f5d474e1c598f
2015-10-28Simplify FilteredNumberDialogFragment params.Andrew Lee
Reconstruct the normalized phone number from other params. Bug: 25343277 Change-Id: Ibb526b0808e0b50a4e946d91279e5570af44c3ca
2015-10-28Rename adapters to a more consistent plurality.Andrew Lee
... really, this was just bugging me. I'm not trying to just pad my CL count. ;) Bug: 25343277 Change-Id: Ifa0e894415d64f373fc23b01eb6169b5fffd98ce
2015-10-29Merge "Rename FilterNumberDialogFragment." into ub-contactsdialer-a-devAndrew Lee
2015-10-28Rename FilterNumberDialogFragment.Andrew Lee
It bugged me how it was inconsistently named to other classes (ie. FilterNumber vs FilteredNumber). It's also specific to blocked numbers, for now, so it felt more appropriate to name it accordingly. Bug: 25343277 Change-Id: I33e2f9fd933d117326690901ec71e3e8c0e3bbd3
2015-10-28Merge "Don't update on voicemail fetch if no activity." into ↵Andrew Lee
ub-contactsdialer-a-dev
2015-10-28Don't update on voicemail fetch if no activity.Andrew Lee
The right thing to do is to return early in this case. This is a theoretical fix for the tagged bug; presuming that this exception caused code execution to terminate prematurely and delete the voicemail as it would be expected to. Bug: 25346075 Change-Id: I643ff4e8abf723f3673b38f5933416730e5d5f9f
2015-10-28Merge "Call blocking normalization cleanup." into ub-contactsdialer-a-devAndrew Lee
2015-10-28Merge "Notify for call blocking disabled by E911." into ub-contactsdialer-a-devAndrew Lee
2015-10-28Notify for call blocking disabled by E911.Andrew Lee
+ Add method and listener to FilteredNumberAsyncQueryHandler to query for whether there are any blocked numbers. + Added utility function for showing a notification, which points to the blocked numbers setting screen. This notification will only be shown if the user has blocked numbers. + Add a boolean flag to track whether we have shown this notification after an emergency call. This is to address the (edge) case where the user makes an emergency call when they have not blocked any numbers, but then later blocks a number. + Added strings for notification. Bug: 25327365 Change-Id: I3179f3884271ea0a504ef8c9a61bf9dfbd18ef10
2015-10-28Merge "Tweak accessibility in for call blocking settings." into ↵Andrew Lee
ub-contactsdialer-a-dev
2015-10-28Disable call blocking for SIP numbers.Andrew Lee
Bug: 25342525 Change-Id: I9a845ffa25323b53175dc0eac2da1f2b4311abe3
2015-10-28Merge "Fix blocked numbers rotation jank." into ub-contactsdialer-a-devAndrew Lee
2015-10-28Fix blocked numbers rotation jank.Andrew Lee
+ Saved search term. + Fix padding/shadow jank between rotations. + Fix title disappearing for import on rotation. Bug: 24910704 Change-Id: Ib683bd07ad629917ac429a5f33be54ecf781e33d
2015-10-28Merge "Revert a minor voicemail playback accessibility change." into ↵Nancy Chen
ub-contactsdialer-a-dev
2015-10-28Revert a minor voicemail playback accessibility change.Nancy Chen
Discovered the bug was in the TalkBack code instead of the dialer code, this change is no longer necessary. Bug: 25127953 Change-Id: Ic02dab7ab448d4df55bb6f4d91a723805de58f32
2015-10-28Tweak accessibility in for call blocking settings.Andrew Lee
+ Adjust talkback focus to allow the user to page through the cards for the settings and import separately, even though they are structurally part of the same header component, visually they reside in different "cards". + Change the "hide setting" to be toggled by tapping on the text description area. Bug: 25163592 Change-Id: I0d1fcd28dba058d707bfe5099cdf912aed14f728
2015-10-28Call blocking normalization cleanup.Andrew Lee
- Remove unnecessary getter. + Reorganized arguments logic in FilterNumberDialogFragment. Bug: 25343277 Change-Id: I7541f21ed28794b4a5d73e0c6c6d895ca6402c77
2015-10-28Merge "Bump Dialer version code to 20302" into ub-contactsdialer-a-devYorke Lee
2015-10-28Bump Dialer version code to 20302Yorke Lee
Change-Id: I94c1d1c5bc310f102903e97b108d5bc37bfb8170
2015-10-28Merge "Fix adding a blocked number and return cause dialer to crash" into ↵Ta-wei Yen
ub-contactsdialer-a-dev
2015-10-28Import translations. DO NOT MERGEGeoff Mendal
Change-Id: I5b3760624aa2be72f04ae524c43d952d66f7a592 Auto-generated-cl: translation import
2015-10-28Fix adding a blocked number and return cause dialer to crashTa-wei Yen
+ BlockedListSearchFragment.onChangeFilteredNumberSuccess() calls activity.onBackPressed() instead of re-adding the management fragment. Bug:25330660 Change-Id: If3a4cd26a180cf08a0e28f0c4bd05e7fd6149c20
2015-10-28Merge "Provide debug hook for call blocking / E911." into ↵Andrew Lee
ub-contactsdialer-a-dev
2015-10-27Provide debug hook for call blocking / E911.Andrew Lee
Add a systems settings config, which is checked for the delay threshold if a particular debug VERBOSE logging mode is used. Usage: adb shell setprop log.tag.DebugEmergencyCall VERBOSE adb shell settings put system dialer_emergency_call_threshold_ms 60000 Bug: 25216954 Change-Id: Ia9b179e16819d3d8232cbedd49d5744d7b69a825
2015-10-28Merge "Retain progress for voicemail playback when rebinding voicemail ↵Nancy Chen
card." into ub-contactsdialer-a-dev
2015-10-27Retain progress for voicemail playback when rebinding voicemail card.Nancy Chen
When rebinding the voicemail card, onPrepared gets called and resets the voicemail playback to 0 because mPosition is not updated to the most recent value. Update mPosition in this case to the position of the media player and then call onPrepared. Bug: 25080811 Change-Id: Ief3a021f4c11bac7b8c0a563765e14c897cb43b5
2015-10-27Remove onboarding flowYorke Lee
Straight revert of all onboarding flow related CLs - the onboarding flow is not needed for now as the Dialer will always at least be the system dialer. Bug: 25020847 Change-Id: Ic1c5020b9b423de50801485f764209b21d5d7f33
2015-10-27Merge "CallDetailActivity respect display name order" into ↵Brandon Maxwell
ub-contactsdialer-a-dev
2015-10-27Merge "Fix voicemail tab items reading "speed dial" when selected." into ↵Nancy Chen
ub-contactsdialer-a-dev
2015-10-26Fix voicemail tab items reading "speed dial" when selected.Nancy Chen
The voicemail entries were reading "speed dial" because the focus would go to the newly added "speed dial" tab since the tabs are all removed and readded when the tab info changes. Change the logic so that only the voicemail tab is changed when needed. The voicemail entry reads "seek playback" instead of the information about the voicemail because of custom expand logic for accessibilty. Change it so that only the call log items are expanded when selected (it is more important to be able to discover the overflow options). Also change content description text because it was too long and confusing. Bug: 25124120 Change-Id: I64c1b27d8c0db57525f7f4ada59655e9f8352245
2015-10-26CallDetailActivity respect display name orderBrandon Maxwell
- Updated the CallDetailActivity to choose whether to show last name first or first name first based on user preferences. - Modified callLog code to behave in a similar fashion - Fixed bug in ContactInfoHelperTests - Rename PhoneCallDetails.name -> PhoneCallDetails.namePrimary Bug: 19364093 Change-Id: I50971ad0f26f6ede49f1c82965d1b00ce0cba4d3
2015-10-26Merge "Show list of all phone numbers for empty query." into ↵Andrew Lee
ub-contactsdialer-a-dev
2015-10-26Merge "Fix issue with entering '+' with switch access" into ↵Yorke Lee
ub-contactsdialer-a-dev
2015-10-26Show list of all phone numbers for empty query.Andrew Lee
+ Configure BlockedListSearchFragment so it will not show empty when the search query is null. + Removed local reference and equality check for changes in the query string. This is done in the superclasses already, so was redundant. - Removed unnecessary override in RegularSearchFragment. Bug: 24910704 Change-Id: Ifd11eed9e3ba6fb00ba535ae019df477f81518fb
2015-10-26Merge "Change call blocking setting string." into ub-contactsdialer-a-devAndrew Lee
2015-10-26Change call blocking setting string.Andrew Lee
Bug: 25154882 Change-Id: I70d031dcf62a183efc4b830a2292e28917bc5279
2015-10-26Fix issue with entering '+' with switch accessYorke Lee
Distinguish between a manual long press and system long press (via accessibility) when modifying the current dial string. Bug: 23554996 Change-Id: I3fc610c8e24bdb39729b827715e08a3e7d73ba1f
2015-10-26Merge "Allow voicemail numbers to be blocked." into ub-contactsdialer-a-devAndrew Lee
2015-10-26Allow voicemail numbers to be blocked.Andrew Lee
Though it is lighter on logic now, it still seems helpful to have a common helper to return whether it should be possible to proceed with blocking a number. Bug: 25230222 Change-Id: I99f93f1cfc09988b3dec77f71541463c96d06225
2015-10-26Call log respects display name order preferencesBrandon Maxwell
- Updated ContactInfoHelper to retrieve DISPLAY_NAME_ALTERNATIVE (name in last name first order) - Stored alternative name in ContactInfo object - Updated CallLogAdapter to choose between first name first and last name first when showing contact name - Added tests for ContactInfoHelper.lookupContactFromUri (changed to public method) - Fixed bug with ContactsPreferences so ChangeListener works Bug:19364093 Change-Id: I73e8d8602a54e3134ef01b3d5167d828b26fa5ea
2015-10-26Merge "Wrap call log popup title with PhoneNumber TtsSpan" into ↵Yorke Lee
ub-contactsdialer-a-dev
2015-10-23Wrap call log popup title with PhoneNumber TtsSpanYorke Lee
Bug: 25122678 Change-Id: I83a7d231b8686152c63d9be71a652232664ea682
2015-10-23Merge "Revert "Call log respects display name order preferences"" into ↵Yorke Lee
ub-contactsdialer-a-dev
2015-10-23Revert "Call log respects display name order preferences"Brandon Maxwell
This reverts commit 327fb5bb609a6bee44a62888d671c951b19782fd. Change-Id: I134f0a26697bec20b746a6e8f041a715d8e95136
2015-10-23Merge "Remove unused permission request string" into ub-contactsdialer-a-devYorke Lee
2015-10-23Merge "Refresh onboarding flow UI" into ub-contactsdialer-a-devYorke Lee
2015-10-23Merge "Call log respects display name order preferences" into ↵Brandon Maxwell
ub-contactsdialer-a-dev
2015-10-23Call log respects display name order preferencesBrandon Maxwell
- Updated ContactInfoHelper to retrieve DISPLAY_NAME_ALTERNATIVE (name in last name first order) - Stored alternative name in ContactInfo object - Updated CallLogAdapter to choose between first name first and last name first when showing contact name - Added tests for ContactInfoHelper.lookupContactFromUri (changed to public method) - Fixed bug with ContactsPreferences so ChangeListener works Bug:19364093 Change-Id: I188d8fc2eccb87edbe56625c9a7537b3d5f0e19e
2015-10-23Remove unused permission request stringYorke Lee
Bug: 24172011 Change-Id: I13d84166c33859a38f6a920f3f082cb037d2a33b
2015-10-22Refresh onboarding flow UIYorke Lee
- Update button styles and positioning - Update background images Bug: 24270592 Change-Id: Idaca76d25d8fc1362fb6c004ec053ac5ed618170
2015-10-22Update character limit for stringYorke Lee
Bug: 25174539 Change-Id: I67e1f2e56c75469f84ee4a0255c3131448a23eab
2015-10-22Remove unused Dialer drawablesYorke Lee
Change-Id: Ibdbdc23c5c6dcd05eeda1e19fe44180a35847962
2015-10-21Merge "Fix NPE when plugging and unplugging earphones." into ↵Nancy Chen
ub-contactsdialer-a-dev
2015-10-21Fix NPE when plugging and unplugging earphones.Nancy Chen
Crashes because the VoicemailPlaybackPresenter is alerted when the state of the headset changes but the corresponding view may be out of focus. Bug: 25090589 Change-Id: Iabe24eb969777ae3919ede05474f35d6c596b20e
2015-10-21Merge "Update Dialer version to 20301" into ub-contactsdialer-a-devYorke Lee
2015-10-21Merge "Prevent fragment rotation crashes." into ub-contactsdialer-a-devAndrew Lee
2015-10-21Prevent fragment rotation crashes.Andrew Lee
Also, causes right fragment to retain after rotation and recreation. Bug: 25154818 Bug: 24910704 Change-Id: Icafbc7ba6f3ad877c2d28d92e510b9afbd822b65
2015-10-21Disable call blocking after emergency call.Andrew Lee
Will be disabled for 48 hours after an emergency call. + Add utility for noting last time of an emergency call. + Add utility for comparing current time to last time of an emergency call. + If current time is within 48 hours of emergency call, display text in settings explaining why call blocking is disabled. Bug: 24418319 Change-Id: I6824340f04fae17b73f17843a9f6ef991afa0327
2015-10-21Update Dialer version to 20301Yorke Lee
Change-Id: I592a9197f39c5a10ddc07947a76ee4d0ec9553a5
2015-10-21Fix scrolling in blocked numbers list.Andrew Lee
+ Add elements as header, so they scroll with the list. + Shuffle around some layouts to make this work correctly. + Replace default ListView divider with custom drawable, to achieve the desired effect of removing the divider on the first list item. + Override BlockedNumberAdapter to never report itself as empty. Otherwise, the header will disappear. + Tweak some padding. Bug: 25134186 Change-Id: I07711437fea2d3042d3987983667ab5316d51fcc
2015-10-20Add import fragment, rearrange fragments.Andrew Lee
+ Add a fragment (and adapter) for displaying numbers from contacts marked as send to voicemail. This fragment has import functionality. + Refactor logic around the Blocked Numbers activity; relocate a lot of the fragment-specific logic, particularly around actionbars, to within the fragments themselves. + Simplify fragment management logic by using replace instead of show/hide. Bug: 23351616 Change-Id: I5c1076d6d001a8401234f57c27ada4bcd90e6c27
2015-10-20Fix broken reference.Andrew Lee
Bug: 24134270 Change-Id: I62c32b6cacdc931e7c99dca68b73aa6bf678b497
2015-10-20Add null check for cursor.Andrew Lee
Bug: 24134270 Change-Id: I5d28c633abee226f7bc2d63ec80340cd6deb9c79
2015-10-21Merge "Hide the hide blocked call settings if no VVM." into ↵Andrew Lee
ub-contactsdialer-a-dev
2015-10-21Merge "Delete voicemails from blocked users." into ub-contactsdialer-a-devAndrew Lee
2015-10-20Delete voicemails from blocked users.Andrew Lee
+ Delete voicemail when the notification is received if the number is blocked and the "hide" setting is set to true. + Changed utility to take time into account; only block voicemail notifications and delete voicemails if the voicemails are from after the time when the number was blocked. Bug: 24134270 Change-Id: I2f3b24d6291a6cec4a7d8530b00dd5a4656ab024
2015-10-20Merge "Set snackbar action text to blue." into ub-contactsdialer-a-devAndrew Lee
2015-10-20Hide the hide blocked call settings if no VVM.Andrew Lee
We can only honor deleting voicemail for VVM users. Bug:24134270 Change-Id: I2b4ea6856ab4bc79ad93ac111bc78bc7f8b4833e
2015-10-20Merge "Add setting for hiding blocked calls." into ub-contactsdialer-a-devAndrew Lee
2015-10-20Add setting for hiding blocked calls.Andrew Lee
+ Add settings switch to blocked number settings. + Add utility for checking/setting whether calls should be blocked. + Filter out blocked calls in call log query, if appropriate. + Refresh call log fragment after a change in setting. Followup work: delete voicemails for calls by blocked numbers after the time when the user blocked them. Bug: 24134270 Change-Id: I85088697559ef6fb446b82617f14f1c6fa893df1
2015-10-20Merge "Update Dialer tests" into ub-contactsdialer-a-devYorke Lee
2015-10-20Update Dialer testsYorke Lee
* Update all tests with @SmallTest, @MediumTest or @LargeTest annotation to ensure coverage by continuous test infrastructure * Fix one failing test Change-Id: Ib878a3fe292916e21a465580a74319e807e7efe0
2015-10-20Merge "Show unblock icon for blocked numbers." into ub-contactsdialer-a-devAndrew Lee
2015-10-19Show unblock icon for blocked numbers.Andrew Lee
Bug: 25095683 Change-Id: I244ec8312ad24081fd36967e063ddccd53b0253c
2015-10-20Merge "Remove unnecessary log statement" into ub-contactsdialer-a-devYorke Lee
2015-10-20Merge "Create superclass for BlockedNumberAdapter." into ub-contactsdialer-a-devAndrew Lee
2015-10-19Create superclass for BlockedNumberAdapter.Andrew Lee
To facilitate reusings the same views and adapter for both the manage blocked numbers list and the import list. The two will use different cursors because they are pulling data from different places (Contacts db vs FilteredNumbers db), and it seemed better to reuse code rather than creating parallel implementations. Bug: 23351616 Change-Id: I5cac5f2a6b8b3bf4a6e8f54c8bc3f1c1500ac5e7
2015-10-19Remove unnecessary log statementYorke Lee
Bug: 25090920 Change-Id: I367e2109acf4f60cedc84bb7c2cd4b472be04f77
2015-10-19Disable VM notification for blocked numbers.Andrew Lee
+ Added a utility to do a synchronous lookup for whether a number is blocked, but it should not be used normally from the UI thread. + Change voicemail notifier code to obtain countryIso, and pass back list of calls to notify as list (to make it easier to remove elements). Bug: 23944007 Change-Id: Iad1f8ee200b8f8734be3db0504482fcdee61e412
2015-10-19Don't allow blocking of emergency or VM numbers.Andrew Lee
Bug: 24680730 Bug: 24303461 Change-Id: Ibd7d431355ca97eb2ae7f29537809987a8d5f96d
2015-10-19Set snackbar action text to blue.Andrew Lee
Done for both snackbars in call blocking/unblocking and voicemail deletion. Bug: 24370325 Change-Id: I00fdebb635e60ac1d421ccf7f15df46693773870
2015-10-19Merge "Fix up blocked photo scenarios." into ub-contactsdialer-a-devAndrew Lee
2015-10-16Add import for SEND_TO_VOICEMAIL.Andrew Lee
+ Add utility class for async import functions. + Move check for contacts with SEND_TO_VOICEMAIl to util. + Add function for adding phone numbers of contacts with SEND_TO_VOICEMAIL to the block list, then clearing the SEND_TO_VOICEMAIL flag. + Fixed bug where the import text would not be shown for an empty block list. Rearranged layouts slightly to facilitate this. + Protect against null listeners in FilteredNumberAsyncQueryHandler. Bug: 23351616 Change-Id: Id526e16f20a3d28966bbc5e458cecfcd03ecb20f
2015-10-16Fix up blocked photo scenarios.Andrew Lee
+ Show blocked drawable in CallDetailActivity. Rearrange logic in the activity to facilitate updating the contact photo and block item action in accordance to blocked state. + Fix bug in FilterNumberDialogFragment where callback was not always invoked because of final/scope issues where it was possible for the callback to be unintentionally null and not invoked. + Clear blocked id cache when pausing the call log adapter, so that after changing the blocked state in the call detail activity the changes will be reflected in the call log. Bug: 24871853 Change-Id: I1d58b1e0c222ead90fa7b6c30a95bc3254a14776
2015-10-15Polish call blocking rotation/undo behaviors.Andrew Lee
+ Correctly dismiss filtered number dialog on rotate. + Polish listener interface, and extend across all block/unblock and undo scenarios. + Update UI across all blocking scenarios (call log, call detail, settings, blocked number list, blocked number search); + Conslidate creation of FilterNumberDialogFragment in a single static method. The listener interface is not ideal, because it does not maintain state well across rotation and multiple instances. This option was selected, however, because of the number of scenarios in which the dialog is invoked and various circumstances (in a RecyclerView list item, in a fragment, in an activity). This range of scenarios makes it convoluted to implement a uniform mechanism in any other way, so the approach opted for is to set a listener, and dismiss the dialog on rotation.. Bug: 24638328 Bug: 24109819 Bug: 24871853 Change-Id: I2332edda2cae0341af3e80b13aa96af6068f75ac
2015-10-15Merge "Reset view state to unmarked when binding." into ub-contactsdialer-a-devAndrew Lee
2015-10-15Merge "DO NOT MERGE Correct issue where content of "All" and "Missed" tabs ↵Tyler Gunn
reversed in RTL." into ub-contactsdialer-a-dev
2015-10-14Merge "Moving call type/location for voicemail" into ub-contactsdialer-a-devBrandon Maxwell
2015-10-14Moving call type/location for voicemailBrandon Maxwell
Combination of two related bugs. 22168682: In the voicemail call log, moved call type/location to below the call action button and removed the call details button as it didn't have any additional information. 22514722: Modified spacing and text sizes for call log. Moved voicemail transcription below call date as in mocks. Bug:22168682,22514722 Change-Id: I557761b815604fee4e6b61f4670608b8fa90d3a7
2015-10-14Merge "Correctly set query string for new SmartDialSearchFragment instance" ↵Yorke Lee
into ub-contactsdialer-a-dev
2015-10-14Correctly set query string for new SmartDialSearchFragment instanceYorke Lee
If DialtactsActivity is created for the first time by launching a DIAL intent, the SmartDialSearchFragment is not correctly populated with the correct number for the "Create new contact" and "Add to contact" shortcuts since it is not attached yet when the callback is fired. Fix this by persisting the number and setting it on the fragment when it is attached. Bug: 24358325 Change-Id: I24d4603376e739a7c9368a9b115109ba23753585
2015-10-13DO NOT MERGE Correct issue where content of "All" and "Missed" tabs reversed ↵Tyler Gunn
in RTL. Root cause of issue was that the tab indexes were not reversed in RTL mode. Made a similar change as was made in ListsFragment. Bug: 24690256 Change-Id: Ifa7ae1127298aa098dd8201b4d1e095baa3c14e8
2015-10-13Reset view state to unmarked when binding.Andrew Lee
Some numbers had been showing up marked as blocked, even though they were not blocked, because the adapter list items were not updated properly. Bug: 24910704 Change-Id: Id3aead5212f4e51d02ec5c6be6c77962546722e0
2015-10-13Add missing import to fix build breakYorke Lee
Change-Id: Iabbc27e509fe8abfdb769c2932a1a025287bdc88
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-19 07:41:27 +0000