summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-06-05Handle null carrier config for emergency call hinttwyen
getCarrierConfig() is @Nullable. While the default implementation always return a bundle, this is not true for other carrier apps. ShadowTelephonyManager.getCarrierConfig() now return null as default to catch this behavior. TEST=TAP Bug: 80629471 Test: TAP PiperOrigin-RevId: 199327865 Change-Id: I7416bee3d5f5307919c6825fc74c26f25b6b001f
2018-06-05Merge "Update dagger types."Treehugger Robot
2018-06-04Update dagger types.erfanian
Bug: 73736474 Test: unit PiperOrigin-RevId: 199224642 Change-Id: Ie11e0bfb261a1ff49b49697314c4341cab4a48d0
2018-06-05Merge "Move feedback quantum assets to third_party."Treehugger Robot
2018-06-04Merge changes I91ea9027,I19f2ae7eTreehugger Robot
* changes: Add keep.xml to keep string resources for spam. Replace TextView with BidiTextView in the new call log where a phone number can be shown.
2018-06-04Move feedback quantum assets to third_party.weijiaxu
Test: tap presubmit. PiperOrigin-RevId: 199211030 Change-Id: I45e1b0d66a51a8c5f8820b8829e185e51003e5b1
2018-06-04Add keep.xml to keep string resources for spam.wangqi
Without this rule, these string resources not directly referenced by code will be stripped out by Proguard. Bug: 80512860 Test: manual PiperOrigin-RevId: 199201142 Change-Id: I91ea90273051b6bb6fa57d116bfb037fc86c1a94
2018-06-04Replace TextView with BidiTextView in the new call log where a phone number ↵linyuh
can be shown. Bug: 72162627 Test: Existing tests PiperOrigin-RevId: 199190694 Change-Id: I19f2ae7e8af452062672c67eb1be1bc6cc49b855
2018-06-04Merge "Fix assert when disabling VVM"Treehugger Robot
2018-06-04Fix assert when disabling VVMtwyen
The SIM may no longer be valid, but the rest of the deactivation process should still go through. TEST=TAP Bug: 79476712 Test: TAP PiperOrigin-RevId: 199174445 Change-Id: I52d6030320f2675ac74fc06470e3cd8f33b613b8
2018-06-04Merge "Fix video call icon color"Treehugger Robot
2018-06-04Fix video call icon colortwyen
It is a state list. TEST=manual Bug: 80315482 Test: manual PiperOrigin-RevId: 199162757 Change-Id: I3be255506871e0d32e5433c2a96bf620701b9c0d
2018-06-03Merge "Simplify & improve DialerBidiFormatter"Treehugger Robot
2018-06-02Merge changes I380bc932,Ida32182c,I61636776,I7957078a,Id35c3ebf, ...Treehugger Robot
* changes: Internal change Remove @GenerateTestDaggerApp from RCG. Fix color in RTT call screen. Updating PhotoInfo and GlidePhotoManager to support conference calls. Solve BiDi problem when phone number is concatenated with RTL-string Fix color of primary text on incall screen. Inlined ConfigProviderBindings.get() and removed ConfigProviderBindings. Removed isUserUnlocked checks from ConfigProvider. Add new spam API which can query additional data. Fix color of name text in call log. Removed static configProvider field in ConfigProviderBindings. Change RTT transcript screen to use toolbar. UI fixes for emergency numbers in the old call log. Fix title and icon color of action bar. Update speakEasy colors and use theme_dialer_light Add new default interface. Fix missing background color Also check call configuration for disconnected call Add toast message when RTT request failed. Update button color. Some minor tweaks to the UI. Fix dialpad theme on incall screen. Accommodate long call time text in call details. Fix color of checked button on incall screen. Use geocode as label for businesses. Add inject method to generated component by RCG.
2018-06-01Simplify & improve DialerBidiFormatterlinyuh
Bug: 72162627,78464687 Test: DialerBidiFormatterTest + Manual testing PiperOrigin-RevId: 198950604 Change-Id: Ia3d4d29b7c6a96a7facfeb5c41b17a6e7cabebf2
2018-06-01Internal changeAndroid Dialer
Bug: 79169954 Test: added tests in BlockingTest.java PiperOrigin-RevId: 198950042 Change-Id: I380bc93276223db74b87f94140bd6c5c29c3f3cb
2018-06-01Remove @GenerateTestDaggerApp from RCG.weijiaxu
Test: tap presubmit. PiperOrigin-RevId: 198907001 Change-Id: Ida32182c4d6a45334cb120e1e2183abae3af2a54
2018-06-01Fix color in RTT call screen.wangqi
Bug: 79883035 Test: manual PiperOrigin-RevId: 198884630 Change-Id: I61636776c234a4000dbaf1e206ffd0429364d942
2018-06-01Updating PhotoInfo and GlidePhotoManager to support conference calls.Android Dialer
Bug: 76205353 Test: GlidePhotoManagerImplTest PiperOrigin-RevId: 198872893 Change-Id: I7957078a63af2455e439286b8d2ef719d4c9ff4e
2018-06-01Solve BiDi problem when phone number is concatenated with RTL-stringlinyuh
Solves BiDi problem that might cause phone number to be displayed incorrectly in the dialer. Issue might occur when a phone number is concatenated with a custom number label containing an RTL-string. Solved by changing affected labels from TextView to BidiTextView. Removed function spanDisplayNumber in BottomRow which are now obsolete. Updates the DialerBidiFormatter to prevent whitespace to be misplaced within a BidiTextView. BUG=78464687 TEST=Manual Public-Origin-Change-Id: I789a6f76a5ca805c03a437813ce627eef7a0bf2e Signed-off-by: Linyu He <linyuh@google.com> Author: Torbjorn Eklund <torbjorn.eklund@sony.com> Bug: 78464687 Test: Manual PiperOrigin-RevId: 198823629 Change-Id: Id35c3ebf514609b4a1fe10a7ae5a297bde7c7456
2018-06-01Fix color of primary text on incall screen.wangqi
Bug: 79883035 Test: manual PiperOrigin-RevId: 198813765 Change-Id: If7dda82316946c7d1c07a3d7fb08e13c858807be
2018-06-01Inlined ConfigProviderBindings.get() and removed ConfigProviderBindings.zachh
It no longer provides any value, so just use dagger directly. Bug: 80441695 Test: tap PiperOrigin-RevId: 198806461 Change-Id: Id607abb65b77633bce511ad0c943ac19453a85d5
2018-06-01Removed isUserUnlocked checks from ConfigProvider.zachh
Bug: 80441695 Test: modified code to fetch a flag value while the user was locked and observed the default value to be returned by Phenotype, unlocked the device, and observed the non-default value to be returned PiperOrigin-RevId: 198804521 Change-Id: I096fc22b47357b4bc61e9e98896ccda8d8bb57d8
2018-06-01Add new spam API which can query additional data.maxwelb
Bug: 80303132 Test: InAppSpamTest, verified using Blueline device PiperOrigin-RevId: 198801576 Change-Id: I30f8c0c7c850ac4bd7b6fcf2dad18c0d70f1b2d1
2018-06-01Fix color of name text in call log.wangqi
Bug: 79883035 Test: manual PiperOrigin-RevId: 198799252 Change-Id: I0636351e5b9bca2c173487c8a53282ca66e61e84
2018-06-01Removed static configProvider field in ConfigProviderBindings.zachh
Also removed setForTesting method as it was only used to reset static state which no longer exists. Bug: 80441695 Test: tap PiperOrigin-RevId: 198789280 Change-Id: If56aa3942bcb12c950c9250309b51e72f59c5bdc
2018-06-01Change RTT transcript screen to use toolbar.wangqi
This also fixes crash bug under new theme. Test: manual PiperOrigin-RevId: 198787768 Change-Id: I0b26dcefd519d40987f7338c32d1a47759b237c0
2018-06-01UI fixes for emergency numbers in the old call log.linyuh
Bug: 80426301,80426768 Test: Manual PiperOrigin-RevId: 198783744 Change-Id: Ib704a710680b3cf18e4c3c91cd48e7b8491671ff
2018-06-01Fix title and icon color of action bar.wangqi
Test: manual PiperOrigin-RevId: 198783472 Change-Id: I7a825564fb42f406aea493cbaa819ab6bcefb9eb
2018-06-01Update speakEasy colors and use theme_dialer_lightuabdullah
Bug: 80539843 Test: N/A PiperOrigin-RevId: 198778001 Change-Id: I70809eb4afe1a28c8a54d17f5e72f06aa18dcd07
2018-06-01Add new default interface.erfanian
Bug: 79701706 Test: tap PiperOrigin-RevId: 198747775 Change-Id: I3bd0d26ee6621ebe428e4e8c82b51959d313608f
2018-06-01Fix missing background colortwyen
Styles resource cannot process #COLOR TEST=manual Test: manual PiperOrigin-RevId: 198653265 Change-Id: Ic885cf384230a24ca8b8ec1e26941fd1c7e49975
2018-06-01Also check call configuration for disconnected callyueg
Test: manual PiperOrigin-RevId: 198609574 Change-Id: Ic5e599b65d81968bdacaf6a90cb1ad34647b8419
2018-06-01Add toast message when RTT request failed.wangqi
Bug: 79522243 Test: manual PiperOrigin-RevId: 198598685 Change-Id: I05144ec734827b29e89bbba5070c9cb0ab06c215
2018-06-01Update button color.erfanian
Test: nope PiperOrigin-RevId: 198596861 Change-Id: Ibc2cccdcb7b02b5ba8b79f5429babc9028f282d8
2018-06-01Some minor tweaks to the UI.calderwoodra
Bug: 79883035 Test: tap PiperOrigin-RevId: 198510062 Change-Id: Ia07624a4511626b2b397199f3674817612557133
2018-06-01Fix dialpad theme on incall screen.wangqi
Test: manual PiperOrigin-RevId: 198488607 Change-Id: I54e2d7ac4320fd67e1670bb2e888cfe833dfb243
2018-06-01Accommodate long call time text in call details.linyuh
Bug: 80408178 Test: Manual PiperOrigin-RevId: 198485864 Change-Id: I72fa8bdbf9e600daad9be8c6466e2ae6bf2f42f6
2018-06-01Fix color of checked button on incall screen.wangqi
Bug: 80232219 Test: manual PiperOrigin-RevId: 198478103 Change-Id: Ic36bf831eef81754f5697e32c4e8813d7e41adf1
2018-06-01Use geocode as label for businesses.twyen
Business number from PhoneNumberService does not always have a sensible label. Previously it would be "Main", but geocode are a bit more useful. TEST=manual, old UI has no tests. Bug: 80251984 Test: manual, old UI has no tests. PiperOrigin-RevId: 198455846 Change-Id: I5efbc66aa295f8039eecfbcb119f18afc735b15c
2018-06-01Add inject method to generated component by RCG.weijiaxu
Bug: 80270083 Test: tap presubmit. PiperOrigin-RevId: 198430675 Change-Id: Iaf0e5a22a8e496339b666b5906584de3acdde6ed
2018-05-30Merge changes Ica13ee39,I5e0fedc8,I8e7efad0,I0ecc1f91,Iee1e658a, ...Eric Erfanian
* changes: Drop maps.impl from packages.mk Check if ID column is null before retrieving data from the smart dial database. Rename theme/private to theme/hidden. Some improvements to the answer fragment layouts. Better a11y for the bottom sheet. Fix a few UI bugs. Log IMS video call available state Better a11y for contact badge in the new call log. Use lookup key to determine the letter tile color Use Dialer Light Theme for SpeakEasyFragment Better a11y for new call log entries. Use Maps SDK lite mode instead of static API for emergency call. Updating locations where PrimaryInfo#setPhoto is used to also PrimaryInfo#setPhotoUri for new GlidePhotoManager implementation. As part of this addition, we also are cleaning the setPhoto(null) because this is not explicitly needed. Converted ThemeUtil into a DaggerModule. Delete AppCompatConstants Remove photo support in PhoneNumberService Began implementation of Dialer dark theme.
2018-05-30Drop maps.impl from packages.mkerfanian
PiperOrigin-RevId: 198426134 Change-Id: Ica13ee3942ef07e9f129d7c53c680953a8fa79ed
2018-05-30Check if ID column is null before retrieving data from the smart dial database.linyuh
Bug: 79469672 Test: None. See above. PiperOrigin-RevId: 198090637 Change-Id: I5e0fedc82d9b464d3d48111530c5836e5d84197f
2018-05-30Rename theme/private to theme/hidden.calderwoodra
private is a reserved word in java. Test: tap PiperOrigin-RevId: 198089995 Change-Id: I8e7efad0a8fed747466593dc7ddf1884f50fa9ac
2018-05-30Some improvements to the answer fragment layouts.erfanian
Test: unit PiperOrigin-RevId: 198080186 Change-Id: I0ecc1f918b2c62e42b287e4fc9ea38fafaf1e6c9
2018-05-30Better a11y for the bottom sheet.linyuh
Bug: 70989658 Test: Manual PiperOrigin-RevId: 197983797 Change-Id: Iee1e658a7a652f53413dec01db68109c3b75dc6e
2018-05-30Fix a few UI bugs.calderwoodra
- clear call log dialog no longer crashes - phone account selector dialog now has a visible title - dialpad text in the incall ui is now visible. Bug: 80144855,80146941,80175230 Test: tap PiperOrigin-RevId: 197952658 Change-Id: Ifaea9b798fef7e36d681a83269e4f65df33f1193
2018-05-30Log IMS video call available statetwyen
TEST=TAP Bug: 77976254 Test: TAP PiperOrigin-RevId: 197924728 Change-Id: I512ebe193cefae24e45c0526bcabdcb23846e236
2018-05-30Better a11y for contact badge in the new call log.linyuh
Bug: 70989658 Test: GlidePhotoManagerImplTest PiperOrigin-RevId: 197918533 Change-Id: I61d04e270ddf4237e8ed9c10e62e8d95f86d1eca
2018-05-30Use lookup key to determine the letter tile colortwyen
The lookup key is part of the lookup URI that is supposed to be stable even if the row is moved around. TEST=TAP Bug: 78266240 Test: TAP PiperOrigin-RevId: 197822055 Change-Id: Iee09556c284efaa68f71e1e0a69a511944c6b46e
2018-05-30Use Dialer Light Theme for SpeakEasyFragmentuabdullah
Bug: 79523664,80195371 Test: Need to add Scuba tests (http://b/80194939) PiperOrigin-RevId: 197821095 Change-Id: I92ea1e6b95d264ea69f7d30eea12f547ee60eeac
2018-05-30Better a11y for new call log entries.linyuh
Bug: 70989658 Test: CallLogDatesTest, CallLogEntryDescriptionsTest, NewCallLogViewHolderTest PiperOrigin-RevId: 197811739 Change-Id: I0f9d1e79d8e687efffbb1dac01aaf6fa26a45f6a
2018-05-30Use Maps SDK lite mode instead of static API for emergency call.yueg
Test: manual PiperOrigin-RevId: 197810897 Change-Id: Ia9dff17333152763b6c644d4f89bc32eedcc2aab
2018-05-29Updating locations where PrimaryInfo#setPhoto is used to also ↵Android Dialer
PrimaryInfo#setPhotoUri for new GlidePhotoManager implementation. As part of this addition, we also are cleaning the setPhoto(null) because this is not explicitly needed. Bug: 76206920 Test: BottomRowTest,TopRowTest,SpeakEasyFragmentV2Test PiperOrigin-RevId: 197785533 Change-Id: I1702f43ec206a6c31cf162978712292aff0f8a17
2018-05-29Converted ThemeUtil into a DaggerModule.calderwoodra
This enables us to have Google-Sans font in GoogleDialer and Roboto in AOSP. Bug: 79883035 Test: tap PiperOrigin-RevId: 197774497 Change-Id: I1d490ab196a444c62e439444627d659fc42973ea
2018-05-29Delete AppCompatConstantslinyuh
Test: Existing tests PiperOrigin-RevId: 197681266 Change-Id: I27fdda1d5c252993795b6eb860663c8cab0d363c
2018-05-29Remove photo support in PhoneNumberServicetwyen
Also cleaned up unused parameters. TEST=TAP Bug: 78654933 Test: TAP PiperOrigin-RevId: 197652430 Change-Id: I1820e8c8de83fcda17f38e92d4ab1c28f519cdce
2018-05-29Began implementation of Dialer dark theme.calderwoodra
- README on how to properly theme Dialer going forward. - Migrated all widgets to use global colors. - Removed all activity and application themes where it wasn't necessary. - Added themeing test rule for Espresso tests. Bug: 79883035 Test: tap PiperOrigin-RevId: 197634256 Change-Id: I4b7d94d45aeeb59d484b0069fdd1e200a654910b
2018-05-22Merge "Fix bug that SpeakEasyFragment is added again after recreate of ↵Treehugger Robot
InCallActivity."
2018-05-22Merge changes Ia1765cb4,Ib262ca4bTreehugger Robot
* changes: Use new dialer base theme instead of AppCompat theme for spam blocking promo dialog. Append the directory ID when building contact lookup URIs in CP2 lookups.
2018-05-22Fix bug that SpeakEasyFragment is added again after recreate of InCallActivity.wangqi
Bug: 79885898 Test: manual PiperOrigin-RevId: 197630981 Change-Id: Ib4ace31c7c207f5ee9f69aee148ddf49021da37b
2018-05-22Use new dialer base theme instead of AppCompat theme for spam blocking promoAndroid Dialer
dialog. Test: N/A PiperOrigin-RevId: 197629283 Change-Id: Ia1765cb42f08002c671a5ac4a774d9b69dfaeda0
2018-05-22Append the directory ID when building contact lookup URIs in CP2 lookups.zachh
Before, when tapping the icon in the call log for a call made to a remote contact, I would get a "Contact doesn't exist" message because CP2 couldn't find the contact due to: 05-18 22:28:48.750 E/DatabaseUtils(26187): java.lang.IllegalArgumentException: Invalid lookup id: people-v2:114584120460114609902 05-18 22:28:48.750 E/DatabaseUtils(26187): at com.android.providers.contacts.ContactLookupKey.parse(ContactLookupKey.java:157) 05-18 22:28:48.750 E/DatabaseUtils(26187): at com.android.providers.contacts.ContactsProvider2.lookupContactIdByLookupKey(ContactsProvider2.java:7766) 05-18 22:28:48.750 E/DatabaseUtils(26187): at com.android.providers.contacts.ContactsProvider2.queryLocal(ContactsProvider2.java:6248) 05-18 22:28:48.750 E/DatabaseUtils(26187): at com.android.providers.contacts.ContactsProvider2.queryDirectoryIfNecessary(ContactsProvider2.java:5565) 05-18 22:28:48.750 E/DatabaseUtils(26187): at com.android.providers.contacts.ContactsProvider2.query(ContactsProvider2.java:5544) 05-18 22:28:48.750 E/DatabaseUtils(26187): at android.content.ContentProvider.query(ContentProvider.java:1147) 05-18 22:28:48.750 E/DatabaseUtils(26187): at android.content.ContentProvider$Transport.query(ContentProvider.java:240) 05-18 22:28:48.750 E/DatabaseUtils(26187): at android.content.ContentProviderNative.onTransact(ContentProviderNative.java:102) 05-18 22:28:48.750 E/DatabaseUtils(26187): at android.os.Binder.execTransact(Binder.java:697) When we construct the contact URI in Cp2ExtendedDirectoryPhoneLookup, we should include the directory ID so that CP2 knows where to look when the user taps the icon in the call log. TEST=unit, manual Bug: 80008014 Test: unit, manual PiperOrigin-RevId: 197600727 Change-Id: Ib262ca4b7e605c3e94ea683289f62c727389b32f
2018-05-22Merge "Don't show "Add contact" and/or "Message" in the bottom sheet if ↵Treehugger Robot
corresponding permissions are not granted."
2018-05-21Don't show "Add contact" and/or "Message" in the bottom sheet if ↵linyuh
corresponding permissions are not granted. Bug: 80059644 Test: HistoryItemActionModulesBuilderTest, PermissionUtilTest PiperOrigin-RevId: 197494701 Change-Id: I607ebd3079fa816b447fbff08cc28c96c55e22bb
2018-05-22Merge "Handle null VideoCall"Treehugger Robot
2018-05-22Merge "Set navigation bar color when dialpad is visible."Treehugger Robot
2018-05-21Merge changes Ifedddd2b,Iaeeae900,I1f8348fb,Iff042966Treehugger Robot
* changes: Check for WRITE_CALL_LOG permission in CallLogNotificationsQueryHelper. Ignore dialer OMTP VVM error if VVM is disabled Bump version codes and name to v22 Adds alternative spam words for non-english speaking countries.
2018-05-21Handle null VideoCalltwyen
When a call is downgraded, video call might be set to null by telecom. TEST=TAP Bug: 79336398 Test: TAP PiperOrigin-RevId: 197479259 Change-Id: Ib5400b0d59bc97b952ee64aad41812f3477a3722
2018-05-21Set navigation bar color when dialpad is visible.wangqi
Instead of fake a black bar on voice incall UI, the more reliable way is to set navigation bar color. Bug: 79902234 Test: manual PiperOrigin-RevId: 197475300 Change-Id: I96085700e633570ef385386cdf366d758e50a6e2
2018-05-21Check for WRITE_CALL_LOG permission in CallLogNotificationsQueryHelper.zachh
TEST=unit Bug: 79667976,79925108 Test: unit PiperOrigin-RevId: 197468611 Change-Id: Ifedddd2bccd76b1fc2c9d3ea4e9854bfe6a218e5
2018-05-21Merge "Check READ_PHONE_STATE for isVoicemailAvailable()"Treehugger Robot
2018-05-21Ignore dialer OMTP VVM error if VVM is disabledtwyen
The status will be stale. TEST=TAP Bug: 78831353 Test: TAP PiperOrigin-RevId: 197462056 Change-Id: Iaeeae9007f6b5ad8319889a860fdcce782be8a0d
2018-05-21Bump version codes and name to v22Android Dialer
Test: n/a PiperOrigin-RevId: 197456564 Change-Id: I1f8348fbeba098d3c6522a9ba0d8e083beb60dbe
2018-05-21Adds alternative spam words for non-english speaking countries.Android Dialer
This CL adds alternative spam words and code for using these words in an experiment. Test: Tap, Unit tests where alterntive experiment is provided and not provided. PiperOrigin-RevId: 197444892 Change-Id: Iff042966f1728ac571699085f07d1325e756dd36
2018-05-21Check READ_PHONE_STATE for isVoicemailAvailable()twyen
TelecomUtil.has*Permission() pass if the dialer is the default dialer. In reality most API does not allow the default dialer do whatever they want. PermissionUtil should be used instead. TEST=uabdullah please fix your "Temporary" @Ignore Bug: 77907588 Test: uabdullah please fix your "Temporary" @Ignore PiperOrigin-RevId: 197442842 Change-Id: Idff3fda855ab0dfc330e963557776461aac677e1
2018-05-21Merge "Check READ_PHONE_STATE for isVoicemailAvailable()"Treehugger Robot
2018-05-21Check READ_PHONE_STATE for isVoicemailAvailable()twyen
TelecomUtil.has*Permission() pass if the dialer is the default dialer. In reality most API does not allow the default dialer do whatever they want. PermissionUtil should be used instead. TEST=uabdullah please fix your "Temporary" @Ignore Bug: 77907588 Test: uabdullah please fix your "Temporary" @Ignore PiperOrigin-RevId: 197442842 Change-Id: I1e6f275e2b8e6d3cfa54ddb8cd24f7d47f9462ca
2018-05-21Merge changes I511c3930,Ifc534793Treehugger Robot
* changes: Add promotion module. Implement a global theme to be easily configured in Dialer.
2018-05-21Add promotion module.wangqi
Refactor Duo disclosure card to general promotion card. Bug: 78905507 Test: unit tests PiperOrigin-RevId: 197436677 Change-Id: I511c39308cadfb96ee4519b71ca29b75d0e6750b
2018-05-21Implement a global theme to be easily configured in Dialer.calderwoodra
deleted several colors and unified them across the app migrated several alert dialogs to support alert dialogs added many todos migrated several tests from GoogleRobolectricTestRunner to RobolectricTestRunner Because of the test migration: - moved dialpad theme attributes into dialpad/theme - moved incall ui theme attributes into incallui/theme Bug: 79883035 Test: tap PiperOrigin-RevId: 197246477 Change-Id: Ifc534793bc32757bbbf2007a7c40287c8d0817ad
2018-05-19Merge "A11y: group caller information together."Treehugger Robot
2018-05-19A11y: group caller information together.wangqi
Bug: 79723777 Test: manual PiperOrigin-RevId: 197245874 Change-Id: Iad639ef467c8d0db861dddb7a174355127b8636c
2018-05-18Merge "Fix video call from search stripping + prefix"Treehugger Robot
2018-05-18Merge "Don't show an outgoing call to a spam number as spam."Treehugger Robot
2018-05-18Merge "Cleaned up deps in SpamBlockingPromoHelperTest."Treehugger Robot
2018-05-18Fix video call from search stripping + prefixtwyen
The smart dial normalization remove non-digits, so the raw number must be set. TEST=TAP Bug: 79400183 Test: TAP PiperOrigin-RevId: 197208475 Change-Id: I303f1b19c30f11303066750f7a830f33ab79ce4f
2018-05-18Don't show an outgoing call to a spam number as spam.linyuh
Bug: 79770053 Test: SpamTest + Existing tests PiperOrigin-RevId: 197201496 Change-Id: Iff2eb03d00d3b559d2a008487b19a2d044b2cb5b
2018-05-18Cleaned up deps in SpamBlockingPromoHelperTest.zachh
Deprecated RobolectricApplication. RobolectricApplication uses RobolectricDialerRootComponent, which depends on all parts of the dialer application (CallLog, PhoneLookup, CommandLine, etc). None of these things matter for leafy unit tests like SpamBlockingPromoHelperTest and they just serve to slow down builds; both for tests that use RobolectricApplication and presubmits for all parts of the application. (Unrelated changes to the call log for example, would trigger this test on presubmit because this test depends on call log when it shouldn't.) TEST=yes Test: yes PiperOrigin-RevId: 197193370 Change-Id: I425351eef2954d105ac7fc7c4120767d275a4fc8
2018-05-18Merge "Remove duplicate code when constructing PhotoInfo proto."Treehugger Robot
2018-05-18Remove duplicate code when constructing PhotoInfo proto.linyuh
Bug: 79770053 Test: Existing tests PiperOrigin-RevId: 197192087 Change-Id: I44c60d13c83b3e23dc141fd9e9b88e108687bf96
2018-05-18Merge "Don't post throttled notifications again."Treehugger Robot
2018-05-18Merge "Handle invalid PhoneAccountHandle for CarrierIdentifier"Treehugger Robot
2018-05-18Don't post throttled notifications again.yueg
Throttled missed call notification can be post again since they are in the newCalls list and not in activeNotifications list. We should record them and don't post again. Test: MissedCallNotifierTest, NotificationThrottlerTest PiperOrigin-RevId: 197177610 Change-Id: I1b03029663621f0a0c06951564eadf78bad016a1
2018-05-18Handle invalid PhoneAccountHandle for CarrierIdentifiertwyen
Previously the phoneAccountHandle is validated before creating the CarrierIdentifier, but it seems like there's a chance that it would be invalidated in the gap before the identifier is created. TEST=TAP Bug: 73890027 Test: TAP PiperOrigin-RevId: 197172168 Change-Id: I6f4f77819ed6ce9f3449f7e47a3538af1098d826
2018-05-18Merge "Show spam blocking promo notification in place of after call ↵Treehugger Robot
notification instead of canceling it and recreating a new notification."
2018-05-18Merge changes I2f94f9a6,Ie58ecf2a,I56696fefTreehugger Robot
* changes: Update spam blocking promotion wordings. Handle null returned from TelecomManager.getCallCapablePhoneAccounts() Add more Cequint provider.
2018-05-17Show spam blocking promo notification in place of after call notificationAndroid Dialer
instead of canceling it and recreating a new notification. Test: ManuallyTested PiperOrigin-RevId: 197093375 Change-Id: I5214acd160d10a191d66c95798b2a44cdd3a9c7e
2018-05-17Update spam blocking promotion wordings.Android Dialer
Bug: 79884797 Test: N/A PiperOrigin-RevId: 197092298 Change-Id: I2f94f9a66a2530a5f2d0ad6630993a2e7b2b4bb8