Age | Commit message (Collapse) | Author |
|
My hypothesis is that there is a race condition where the call log changes and
we are leaving the activity before the content observer is unregistered or the
loader it starts is finished. This results in a callback calling #fetchCalls
while Dialer is in the background, resulting in a crash. This change will
confirm my hypothesis.
Even if my hypothesis is incorrect, we have similar checks throughout this
class which indicates to me that some issue exists here and that this check is
safe to do.
Bug: 73972084
Test: n/a
PiperOrigin-RevId: 187700318
Change-Id: I98cea86b5b7041c4f4aac09544445aaade6bfd40
|
|
|
|
Bug: 70989667
Test: unit
PiperOrigin-RevId: 187694255
Change-Id: Ie6ec70a70a4c59cbdfe25c34003d21fa2f751564
|
|
|
|
This includes:
1) Made RefreshAnnotatedCallLogWorker.refresh() methods return a result which is "not dirty", "dirty but no changes needed" or "dirty and changes need". It will be interesting to see how often these cases occur (will log impressions in a future CL) so I thought we might as well log the latency of each case separately as well.
2) To support 1) added a new method to FutureTimer which allows you to compute the event name from the result of the timed Future. Also needed to update the Metrics interface to support deferring the event name when starting a timer via a generic token.
3) Timing the coalesce operation which is very heavyweight.
4) Made StubMetrics do some logcat logging to easily observe timing information using AOSP
Bug: 70989667
Test: unit
PiperOrigin-RevId: 187691203
Change-Id: I5f19a2fc94d86639486299b65b0edd66eeaab52e
|
|
|
|
Bug: 73727182
Test: tested
PiperOrigin-RevId: 187673539
Change-Id: I9c790e912990fb8dc46da1c1057339c979ac9501
|
|
|
|
* changes:
Update fragment class.
Add ripple effect to RTT incall buttons.
Remove dialer sounds and vibrations settings fragments and redirect to the system sound settings fragment instead.
|
|
Bug: 74028377
Test: Manual :/
PiperOrigin-RevId: 187634587
Change-Id: I51be6c151db37988bd68558a6af8c2bab31939a1
|
|
Bug: 73775453
Test: unit tests.
PiperOrigin-RevId: 187630263
Change-Id: Ib8e1b852b4ab4ca6614182db0cb72e413c1612eb
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 187564625
Change-Id: I7e848e975bbab19e605d09283dee24eeb02550f1
|
|
system sound settings fragment instead.
There is no need for dialer to have it's own sounds and vibrations fragment. Instead of maintaining two separate fragments that do that same thing (and have to be kept in sync), we can just have one source of truth and have users modify those settings. Thus we have removed the dialer and vibrations settings fragment and have it instead re-direct to the system sound settings. The automatic advantage of this is also that for dual sim cases, dialer settings don't need to be updated.
Bug: 73750524
Test: Manual. Navigated to the dialer sound and settings fragment, and it opened the system settings. Also pressing back took us back to Dialer as expected.
PiperOrigin-RevId: 187564461
Change-Id: I7d620721237f1c932ed8cea949486ae7dbdefba1
|
|
* changes:
Use voicemail image for empty voicemail tab and update color
Implemented DialerFloatingActionButton
Instead of just cancelling loaders, reset them as well.
Update RTT icon on ringing screen.
|
|
This CL updates the icon for the empty voicemail tab and updates the tint of it as well. It also updates the size of the voicemail icon when in landscape mode.
Bug: 25661977,74085541
Test: N/A
PiperOrigin-RevId: 187557890
Change-Id: Ic19643f4e63e3ce70ba6b029ce45a570404f28e7
|
|
Implemented wrapper class for FloatingActionButton to resolve some of
FloatingActinButton's many issues. One of which is alllowing clicks while
animating that was causing a crash in NUI.
This change also fixes an issue with the dialpad exit animation.
Bug: 73995512
Test: Robolectric and Espresso don't support these kinds of tests very well
PiperOrigin-RevId: 187556390
Change-Id: I4cb7c2346a0ef09f2f3d8b48e7e14d01460cd1a7
|
|
Bug: 71385186
Test: manual
PiperOrigin-RevId: 187552834
Change-Id: If4e1f7c18d5f5aae2a152762189948c3543ba321
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 187551861
Change-Id: I38facbaaa48ba4afe29e382de9c8241d8936c3ab
|
|
|
|
Bug: 73718977
Test: PhoneNumberHelperTest
PiperOrigin-RevId: 187540382
Change-Id: I814ec62b2215c24b8cde3442c5dc83d98ad87164
|
|
* changes:
Implement overflow menu for RTT call.
Rename NUI logging prefix from NUI_ to MAIN_
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 187529383
Change-Id: I6ef6593a79ef0c4fb407284eede966a1eaabcd1e
|
|
Bug: 72525843
Test: none
PiperOrigin-RevId: 187500135
Change-Id: Iaa73b9355a6b5c299f73fd113eb1f74a3eb47dd4
|
|
* changes:
Updating SecondaryInfo value class to use AutoValue with builder pattern.
Added same primes metrics that existed in Dialtacts to NUI.
|
|
Test: CallCardPresenterTest,SecondaryInfoTest
PiperOrigin-RevId: 187481728
Change-Id: I3d2b23b5d51ea1e5ff30b8f6b6570d76c006fe86
|
|
Test: n/a
PiperOrigin-RevId: 187442952
Change-Id: I9463e2c976102276ebc5886531397ad0cf160b78
|
|
|
|
Default is set to true but if we see issues with startup latency we can disable
this server side.
Test: n/a
PiperOrigin-RevId: 187419851
Change-Id: I6d1debfed86dbcaf3ee73ec0906e514a2687e2c0
|
|
* changes:
Some small bug fixes in NUI.
Log contact source when reporting spam from the new UI.
|
|
* changes:
Add accessibility label for voicemail transcription rating
Parity of OldMainActivityPeer with ListsFragment for VM
Show empty view when there are no voicemails
|
|
- Never show the dialpad chooser in MainActivity.
- If the call log changed while dialer was in the background, it would trigger
the content observer to fetch the new info, which would request it's parent
that wasn't there. Now we register/unregister them in onResume/onPause. This
is safe to do because we force refresh the data onResume anyways, so any
changes will still be shown.
Bug: 73972084,73975555,73995512
Test: manual
PiperOrigin-RevId: 187407058
Change-Id: Iae86dabbcb852398bb2b9df4627e234261ab8030
|
|
Bug: 73780748
Test: PhoneLookupInfoConsolidatorTest
PiperOrigin-RevId: 187404074
Change-Id: I1db81304909fbf63aba00088c12e18922042c3b1
|
|
Bug: 73788896
Test: Manual :/
PiperOrigin-RevId: 187401558
Change-Id: I1c2c08cc01fd38ad5820c454991473cfb8f0fc76
|
|
This CL helps to ensure that when the VVM settings toggle is turned on or off, or a sim is swapped, inserted or removed the VM tab disappears and appears, just like it currently does. When a VM tab disappears we also move to the speed dial index.
Bug: 73123614,73998717
Test: N/A
PiperOrigin-RevId: 187400703
Change-Id: I76a0b43da86713caa67956413a39299c7ecbc8d1
|
|
When there are no voicemails to be shown, we show an empty view. This is done by hiding the recycler view and showing the empty view. Similarly when a voicemail is present, we hide the empty view and then show the recycler view.
Bug: 25661977
Test: Unit Tests
PiperOrigin-RevId: 187396952
Change-Id: Ifa718fb05c1be37aabdf4c91bc2c1653357565b2
|
|
* changes:
Never start playing voicemails in the NUI VM tab from the speaker
Remove background of RTT chat fragment.
|
|
All voicemails played from the VM tab should always be played from the non-speaker mode.
Bug: 71500892
Test: N/A
PiperOrigin-RevId: 187388964
Change-Id: I3f6a5887784b0192074157cfd8a91727d124ed06
|
|
The default incall gradiant background will be shown instead.
Bug: 67596257
Test: manual
PiperOrigin-RevId: 187384455
Change-Id: Icf91804d78aa98d051248a9eca0d13be0ea880f0
|
|
|
|
Bug: 73798533
Test: Manual :/
PiperOrigin-RevId: 187383740
Change-Id: I0f35ccbf19a59b35338cb144f0192b692585159f
|
|
avoid long method signatures."
|
|
long method signatures.
Test: Existing tests
PiperOrigin-RevId: 187338094
Change-Id: I0d7a5206d127931d322b5604b2bb81f5202b8de8
|
|
set connection to active at the end."
|
|
connection to active at the end.
This is necessary to make sure that NonSimulatorConnectionListener gets event callback when Connection.setDialing() or Connection.setActive() is called.
Test: On a local device.
PiperOrigin-RevId: 187266120
Change-Id: I6ee5d5113285e7a27a4e8497a95b28844ac6b397
|
|
* changes:
Do not show the voicemail tab if the VM toggle is turned off.
Internal cleanup for the new UI's bottom sheet.
|
|
tab."
|
|
|
|
Bug: 73123614
Test: N/A
PiperOrigin-RevId: 187255950
Change-Id: I9ab50a7a8052f325f1743721bf6432e6c4787a4e
|
|
Test: Existing tests
PiperOrigin-RevId: 187254014
Change-Id: I8a57b632d45e87ad075eb8bbb25180858e890f08
|
|
Test: manual, going between tabs hides/shows the fab properly when ToS is (in)visible.
PiperOrigin-RevId: 187253210
Change-Id: Ied9ea44892786268b9dfa68816840dfbfc74aa6e
|
|
- main fragments are no longer detected by talkback while search is open.
- FAB now has a content description
Bug: 73587831,73891132
Test: tap
PiperOrigin-RevId: 187248081
Change-Id: I5a8fe2df23542d19c935cba77d1337ec753064af
|
|
|
|
Bug: 73258376
Test: MainActivityOldPeerCallLogIntegrationTest
PiperOrigin-RevId: 187242222
Change-Id: Ic2684467035fedc1156886712757bf0911f65ee5
|
|
* changes:
Set the correct reporting location when reporting spam in the new call log.
Bump version codes and name to v19
|
|
Bug: 73816729
Test: Existing tests
PiperOrigin-RevId: 187230516
Change-Id: I59d70b9676e2972b80f124f29f2c1cb1858efef8
|
|
Test: n/a
PiperOrigin-RevId: 187229492
Change-Id: If166951bbbe8bc38b1053f1bc8bd7eac74944964
|
|
|
|
|
|
Bug: 73887387
Test: Existing tests
PiperOrigin-RevId: 187225355
Change-Id: I65de553078e147a46d933daf34dfd912fc8aa74c
|
|
Bug: 72525950
Test: ContactsPromoFragmentTest, MainSearchControllerTest, OldGoogleMainActivityPeerTest
PiperOrigin-RevId: 187224361
Change-Id: Idc43255ccc673c6c5c17b70d1f367d1a4802bfd0
|
|
* changes:
Fix bug that soft keyboard pushes action bar out of window.
Added 2 null checks to fix top crashers.
|
|
This is happening on outgoing call.
Bug: 67596257
Test: manual
PiperOrigin-RevId: 187207221
Change-Id: I09e8be0dbad695a1a5afb64e08faf533d068e5c4
|
|
Bug: 73886704,73887420
Test: n/a
PiperOrigin-RevId: 187201516
Change-Id: Ic94816e198e29b87b031a85252e984bc167bb7f8
|
|
ending a call."
|
|
a call.
Bug: 73903013
Test: On a local device.
PiperOrigin-RevId: 187114719
Change-Id: I9cd0ee8ee33c5711f68ed78d3181347ae439f2b6
|
|
|
|
Bug: 73821574
Test: manual
PiperOrigin-RevId: 187096752
Change-Id: I2ac254523582958084f4ebbe1b324c406c2e86f5
|
|
* changes:
Added Call History activity to MainMenu.
Updating PrimaryCallState value class to use AutoValue with builder pattern.
|
|
Test: MainActivityOldPeerIntegrationTest
PiperOrigin-RevId: 187080344
Change-Id: I1c9fd942a4c198c9a914d6aefe7c4cc638f39c01
|
|
Bug: 34502119
Test: BottomRowTest,CallCardPresenterTest,PrimaryCallStateTest,TopRowTest
PiperOrigin-RevId: 187071451
Change-Id: Ib1b4baee397f61eade84bf1a887596dddc37230a
|
|
|
|
Bug: 73547944
Test: Cp2ExtendedDirectoryPhoneLookupTest
PiperOrigin-RevId: 187064655
Change-Id: Icb468e0867248f097a77134dd67a53352f7c80b0
|
|
|
|
Bug: 70989605
Test: ShowBlockReportSpamDialogNotifierEndToEndTest + Manual
PiperOrigin-RevId: 187047450
Change-Id: I23c3929135bcfe5c14fe317ef65f628dc126027f
|
|
|
|
This prevents to many loaders running at the same time and crashing the
application for using too many threads at once.
Also made a few UI changes:
- Change Android nav bar color to #FFF
- Move badges down 2dp
- Limit badges to 9+ (instead of 99+, added flag to configure this)
- search bar no longer has rounded corners when expanded
Bug: 72525324
Test: MainActivityOldPeerTest
PiperOrigin-RevId: 186894920
Change-Id: I36fc5d8794440b707184d54de427db5910ec5b8e
|
|
|
|
- Normalized the search query returned from DialpadFragment
- Dial button now updates when given a psuedo emergency number
- 'Clear frequents' now displays and functions properly in the menu
- Added simulator to the menu
Bug: 72525324
Test: added tests for clear frequents (only prod feature).
PiperOrigin-RevId: 186875815
Change-Id: I3bad3c71b355b987fc85777550bfa1de5028c3a4
|
|
building metrics."
|
|
|
|
metrics.
This required creating "CallLogState" which is currently just a boolean value which can only be turned on once (when the annotated call log flow finishes for the first time).
This CL also changes CompositePhoneLookup to no longer implement PhoneLookup. This was done to support a now reverted implementation of CallLogState but it's easier for me to keep the change and it shouldn't be harmful.
Bug: 70989667
Test: unit
PiperOrigin-RevId: 186852257
Change-Id: I3f342737aaf909f8230b8a69d9c21e6e5c19b84e
|
|
1. send bubble break characters to remote
2. correctly handle text replacement
Bug: 67596257
Test: RttChatMessageTest
PiperOrigin-RevId: 186850402
Change-Id: I0aebb0f4315a021da1463d7903d28e912918efca
|
|
|
|
On VVM3 when the user upgrade to premium VVM through the carrier, the carrier will actively send STATUS SMSes first indicating the status is unknown, then the new premium status.
STATUS updates sent by the carrier were ignored until recently. Currently seeing the unknown status the provisioning process will be triggered, and the user will be downgraded back to basic VVM.
In this CL if the STATUS update is initiated by the carrier instead by a STATUS request, provisioning will be ignored.
Bug: 73625577
Test: N/A
PiperOrigin-RevId: 186737242
Change-Id: Ieb10f9a50e0c3001d02cefc31256a9adac1ae5d1
|
|
|
|
Bug: 70989667
Test: unit
PiperOrigin-RevId: 186726722
Change-Id: I1a68ae1e01b101b1624e4f5ede1a8d639d481ad2
|
|
|
|
|
|
cannot get it"
|
|
Bug: 73757382
Test: none
PiperOrigin-RevId: 186707825
Change-Id: Ib491e958b08298f233841718283e915bedb57fb2
|
|
When users press "enable simulator mode" button, one PhoneAccount associated with SimulatorConnectionService will be registered into platform so users can make fake call through dialer. To end this, simply press "disable simulator mode" button.
Bug: 71898328
Test: On a local device.
PiperOrigin-RevId: 186707002
Change-Id: Ic584bcd88bb52ac0b96c4cb214ad8edc70cf24d4
|
|
Bug: 71707082
Test: MotorolaHiddenMenuKeySequenceTest
PiperOrigin-RevId: 186685319
Change-Id: If23ec797a174736e68b6100b3d33c7dccb9a88f8
|
|
|
|
|
|
Bug: 72997695
Test: existing tests, LoggerUtilsTest, placed call to voicemail and verified
PiperOrigin-RevId: 186677560
Change-Id: I63d0a463f890c8cc1a301daa37388f58aed33aae
|
|
Bug: 73780549
Test: manual
PiperOrigin-RevId: 186669251
Change-Id: I2b45caa7b0a0a20e2466f51b7d659ce61a4945cf
|
|
* changes:
Removed item animator in Call Log RecyclerView.
NUI bug fixes: handling intents and onActivityResult.
Use the vector spam icon in the new call log.
Fixed some Dialer theming bugs in NUI.
Make MarkDirtyObserver available to all call log data sources & PhoneLookups.
Updating PrimaryInfo value class to use AutoValue with builder pattern.
When there is no VM support hide the tab in the Old Main Activity
Rebuild Call Log on first launch after NUI is enabled
Changing the voicemail transcription font size
Moved metrics related methods out of LoggingBindings.
Record jank metrics in old and new call logs.
Fixed some bugs in NUI search.
Adding information section to voicemail settings
Add Tracfone to Motorola menu, move existing menu to Sprint only
Fixed some issues in NUI search bar.
Disable VVM for tracfone USA
Fix an NPE when ContactInfoHelper tries to retrieve remote directories.
Merge searchfragment/remote into searchfragment/directories and renaming things accordingly.
Initialize/Update the UI of New{CallLog|Voicemail}Fragment iff the fragment is truly visible.
Use a broadcast receiver to refresh the annotated call log.
Rename invalid resource folder
Fix a few UI issues based around multiselect in new nav.
Include the primary callback action in the new call log's bottom sheet.
Implement read/write text stream to RttCall.
Add configuration for when we show decimal and barcode device id
Annotate RTT as @TargetApi(28).
|
|
Bug: 69965302
Test: TAP
PiperOrigin-RevId: 186573663
Change-Id: I099f22b7a8df7018ec50e309b2ae37f3eedd76fd
|
|
- Handle Calls.CONTENT_TYPE intents
- Handle Add Call intents
- Handle onActivityResults
Bug: 72525324,72525840
Test: implemented
PiperOrigin-RevId: 186523438
Change-Id: Ia014e5e10ee0be2f32a09df79b3ade12d09814e9
|
|
Bug: 73123894
Test: GlidePhotoManagerImplTest
PiperOrigin-RevId: 186522766
Change-Id: I3950071e6af492e07972619a4933231b4341aaf4
|