summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-09-18Fixed crash when users press back twice in call composer.calderwoodra
Bug: 65686665 Test: manual PiperOrigin-RevId: 168983351 Change-Id: I6443a05c8435e777c52ed3586dfc228a0fb0f51f
2017-09-18Pressing back when the dialpad is empty now exist the search UI.calderwoodra
Bug: 65687672 Test: existing PiperOrigin-RevId: 168951800 Change-Id: Ie840acd608424551198ba3440d6060a7cd7a629f
2017-09-18Dialpad VM and + are now only accessible w/ double-tap instead of long hover.calderwoodra
Users using touch to explore with TalkBack on the dialpad would occasionally call voicemail if they hovered over 1 for a long period of time. This functionality doesn't align with keyboards, where a long hover still acts as a normal click. This CL updates the Dialpad to align better with a keyboard and now users can only speeddial voicemail and type a 0 with double-tap activation. Bug: 62712616 Test: manual PiperOrigin-RevId: 168909308 Change-Id: Ib46342f173aef7c2ef64c2b42745966f83266b98
2017-09-15Merge "Make voicemail transcription text selectable and phone numbers clickable"Treehugger Robot
2017-09-15Merge "Updating voicemail TOS UI to match mocks"Treehugger Robot
2017-09-15Make voicemail transcription text selectable and phone numbers clickablemdooley
Also replace deprecate android:singleLine=true with android:maxLines=1 video: https://drive.google.com/open?id=0B9o_KvtLkcuIWGVBOElWdFNKa1E Bug: 65678844 Test: manual PiperOrigin-RevId: 168858718 Change-Id: I8be70e8496a8f0c562ca09eb315bb4e28b3e9c00
2017-09-15Updating voicemail TOS UI to match mocksmdooley
verizon TOS screen shot 1: https://drive.google.com/open?id=0B9o_KvtLkcuIU3VpLUpqcXBUYy1QY19UUk81a29sdGQyNEZZ verizon TOS screen shot 2: https://drive.google.com/open?id=0B9o_KvtLkcuIN3R6SUFjS3RVTWhZQUM1UzhoajhNUF9ZbzJJ non-verizon TOS screen shot: https://drive.google.com/open?id=0B9o_KvtLkcuIeVFYaWhYZmRzYVctU2F6N1VqazcycGpmNmRZ Bug: 37340510 Test: manual and update unit test PiperOrigin-RevId: 168851805 Change-Id: I7be27360093cae315b7249152e10d1beae5c5966
2017-09-15Merge "Dialpad chooser now properly shows when in a call."Treehugger Robot
2017-09-15Dialpad chooser now properly shows when in a call.calderwoodra
Bug: 65212837 Test: DialpadFragmentTest PiperOrigin-RevId: 168745371 Change-Id: I62da45cdac58e3387343589b952e5d6bce7a4ee2
2017-09-14Merge "Don't use guava prebuilts outside of annotations processing."Treehugger Robot
2017-09-14Don't use guava prebuilts outside of annotations processing.Eric Erfanian
This results in class incompatiblity with other dependencies that are transitively dependent on the same library. Test: make, flash, th Bug: 65254753 Change-Id: Ib32b088df60582df7559c9be49b0fa1b1f1a4fef Merged-In: Idfbae76a38e64bb96eb824cda3d201ae63a13e90
2017-09-14Merge "Fixed an animation bug in new search fragment that was clipping results."Treehugger Robot
2017-09-14Merge "Setup SMS filter even if VVM is already activated"Treehugger Robot
2017-09-13Fixed an animation bug in new search fragment that was clipping results.calderwoodra
Test: manual PiperOrigin-RevId: 168612783 Change-Id: I811133aee3301bac6936d5ba101719c30322d3be
2017-09-13Setup SMS filter even if VVM is already activatedtwyen
VVM can be "activated" through restoring shared preferences from another device. In this case the SMS filter in telephony is still not configured, and needs to be set up. Bug: 65542413 Test: ActivationTaskTest PiperOrigin-RevId: 168560153 Change-Id: I46dd9b31e43899d8d567e7e6baebf06559548525
2017-09-13Merge "Log opening dialpad."Treehugger Robot
2017-09-13Merge changes Ie58920b7,Iaaf84ab9Treehugger Robot
* changes: Fixed crash in RemoteContactCusror. Log swiping and clicking for switching tabs.
2017-09-13Log opening dialpad.yueg
Bug: 64399026 Test: None. PiperOrigin-RevId: 168456040 Change-Id: I65fdae8dff1c9bb8e05e79f3ece2480b92f08c69
2017-09-13Fixed crash in RemoteContactCusror.calderwoodra
Test: manual PiperOrigin-RevId: 168427349 Change-Id: Ie58920b76266ebb298210b5faac8fcbda4dbcd15
2017-09-13Log swiping and clicking for switching tabs.yueg
If it's a swipe, onPageScrolled() is called several times before onPageScrollStateChanged(SCROLL_STATE_SETTLING) and onPageSelected(). If it's a click, only onPageScrollStateChanged(SCROLL_STATE_SETTLING) is called before onPageSelected(). And onPageScrollStateChanged(SCROLL_STATE_SETTLING) will not be called if user don't switch to a new tab. We use the difference to tell if user switching tabs by swiping or clicking. Test: DialtactsActivityTest PiperOrigin-RevId: 168403148 Change-Id: Iaaf84ab9c4955d0bc2c1e9857ba59fd37b3984af
2017-09-11Merge changes I8578dd2c,Ia8e581f1Treehugger Robot
* changes: Send PhoneAccountHandle with ACTION_CONFIGURE_VOICEMAIL Fix NPE in contacts fragment.
2017-09-11Merge changes Ia566fce6,I36f03c07,I81492f7fTreehugger Robot
* changes: This is a rollforward of cl/167332236 Updating voicemail notifications Updating voicemail notifications for transcription, part 2
2017-09-11Send PhoneAccountHandle with ACTION_CONFIGURE_VOICEMAILtwyen
When opening a voicemail setting from Dialer with ACTION_CONFIGURE_VOICEMAIL, no subId is passed. So on a multi-SIM device, it is always configuration on the default phone regardless of SIM. To solve this, set the PhoneAccountHandle to intent extra for ACTION_CONFIGURE_VOICEMAIL. In the advanced settings, obtains subId from the PhoneAccountHandle. Test: manual - Checked that correct PhoneAccountHandle will be passed with ACTION_CONFIGURE_VOICEMAIL intent Bug: 65001008 Author: xuegang.x.liu <xuegang.x.liu@sony.com> Bug: 65001008 Test: manual - Checked that correct PhoneAccountHandle will be passed PiperOrigin-RevId: 168019873 Change-Id: I8578dd2c4ac24e4af121a90b2b175baae2832461
2017-09-11Fix NPE in contacts fragment.calderwoodra
Bug: 64716624 Test: manual PiperOrigin-RevId: 168017541 Change-Id: Ia8e581f19a0a9c4d45bacc4ab94e54131763640a
2017-09-11This is a rollforward of cl/167332236calderwoodra
Improved behavior of back button in search ui. Pressing the back button in the search UI now functions as follows: - If the keyboard is opened, the keyboard is minimized - If the dialpad is opened, the dialpad is closed - If the keyboard and dialpad is closed, the search ui is closed Our existing behavior was dependent on whether a query had been built yet. basically, if the user pressed back with no query selected, the search ui was closed. From the bugbash: 7. No scroll bar in the search results if the results do not fill the entire view. The keyboard overlaps the results and there is no way to get to the enter list without dismissing the keyboard. 10. Dismiss the keyboard on tapping the down arrow on the keyboard. Arrow points down but works like back button Bug: 62685859,63691995,63939331,64137632,64902476 Test: manual PiperOrigin-RevId: 168004913 Change-Id: Ia566fce6d90454a3eae6ecccfa81ce7e909e878f
2017-09-11Updating voicemail notificationsmdooley
This is mostly just a revived version of cl/158901400. It adds a job service that is triggered by changes to the voicemail database. The job updates voicemail notifications, as necessary. video of notification update: https://drive.google.com/open?id=0B9o_KvtLkcuId1ptNk1EbGotWFU Bug: 37340510,27535759 Test: manual and unit test PiperOrigin-RevId: 167934550 Change-Id: I36f03c0769645f7a0cb478172171f1079eca2108
2017-09-11Updating voicemail notifications for transcription, part 2mdooley
Changing voicemail notifications to match the latest mocks, (replacing the 'Voicemail' title with what was the notification content, and putting the voicemail status or transcription in the notification content). The notifications will be updated in a following cl. screen shot: https://drive.google.com/open?id=0B9o_KvtLkcuIbDdjaTNHTFFZLW9YZEo1SG5scDR6SzloaWc4 Bug: 37340510 Test: manual PiperOrigin-RevId: 167928866 Change-Id: I81492f7fbf1cc398401a948e036854d6a8ff878b
2017-09-11Merge changes I6af1fc7d,I0627d54aTreehugger Robot
* changes: Automated g4 rollback of changelist 167310802. Automated g4 rollback of changelist 167332236.
2017-09-11Merge "Updating transcription UI to match latest mocks, part 1"Treehugger Robot
2017-09-11Merge changes Icc92997c,I70c032fd,Ibafdaf5f,Ifd2efcc9,Iba5609acTreehugger Robot
* changes: Fixing transcription crashes caused by job stoppage Strip trace info for release build. Load VVM config override before loading anything else Fix bubble crash when dismiss audio route selector dialog. Ignore read missed calls and voicemails for notification
2017-09-11Automated g4 rollback of changelist 167310802.calderwoodra
*** Reason for rollback *** Turns out blocked number activity is actually used for devices on M. *** Original change description *** Removes the unused dialer/app/filterednumber package. *** Test: n/a PiperOrigin-RevId: 167663280 Change-Id: I6af1fc7d6eb61f946d4fba255fe7374bcdee0e72
2017-09-11Automated g4 rollback of changelist 167332236.calderwoodra
*** Reason for rollback *** Based off a CL that needs to be rolled back. *** Original change description *** Improved behavior of back button in search ui. Pressing the back button in the search UI now functions as follows: - If the keyboard is opened, the keyboard is minimized - If the dialpad is opened, the dialpad is closed - If the keyboard and dialpad is closed, the search ui is closed Our existing behavior was dependent on whether a query had been built yet. basically, if the user pressed back with no query selected, the search ui was closed. From the bugbash: 7. No scroll bar in the search... *** Bug: 64902476,64137632,62685859,63691995,63939331 Test: n/a PiperOrigin-RevId: 167661409 Change-Id: I0627d54af33fb55c64b5edcd459dde6a73d93266
2017-09-11Updating transcription UI to match latest mocks, part 1mdooley
-add branding 'Google is transcribing' -add branding 'Transcribed by Google' in-progress screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuIdVVTX3BBZkNzV180alZPQ3EtR3gzRFNoamhV transcribed by screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuISUdaRjBlUFpjYTBWWTg1STVHS0oyQmNiSUVR Bug: 37340510 Test: manual PiperOrigin-RevId: 167620447 Change-Id: I5526bebb6999cf77b0902ae50ca72e380538a6e7
2017-09-11Fixing transcription crashes caused by job stoppagemdooley
Apparently, scheduling a new job when one is already running (even using the enqueue api) causes the running job to be stopped. We weren't handling that case correctly. This cl makes sure no more work is attempted after a job is stopped by cancelling any active transcription task. We request that stopped task be rescheduled by the job scheduler, so it will get run eventually. I was able to verify this fix by sending a new voicemail while backfill old transcription tasks were running. Bug: 64908823,63524274,65129734,63803709 Test: manual and unit tests PiperOrigin-RevId: 167617191 Change-Id: Icc92997c2687e61bef9b3b7f9ff572da2cb4ed2e
2017-09-11Strip trace info for release build.wangqi
Each trace info will add several milliseconds overhead and it's not used by end user. Bug: 64542087 Test: none. PiperOrigin-RevId: 167614347 Change-Id: I70c032fde162d6c8aa46be72c9ece3b7c3249fe8
2017-09-11Load VVM config override before loading anything elsetwyen
The override config is used by carriers to test out different configs using a prod dialer. Previously the type was loaded before the override config, causing carriers that is not currently supported never able to force enable VVM. This CL also fixes getCarrierPackageNames() and getDisabledCapabilities() not loading the override. Bug: 65370543 Test: revived OmtpVvmCarrierConfigHelperTest PiperOrigin-RevId: 167614182 Change-Id: Ibafdaf5fdc3e948bc65656f94c4bdc7d6e97046c
2017-09-11Fix bubble crash when dismiss audio route selector dialog.yueg
When AudioRouteSelectorDialogFragment tries to call onAudioRouteSelectorDismiss() on its parent AudioRouteSelectorActivity, the parent might already finish, which causes NPE. We should make sure the fragment is dismissed and removed before the activity finished. We do it when activity onPause because we don't expect it to resume. Test: AudioRouteSelectorDialogFragmentTest PiperOrigin-RevId: 167607068 Change-Id: Ifd2efcc92eb45262da2c6441bfac8119799d78f2
2017-09-11Ignore read missed calls and voicemails for notificationtwyen
When the call log is restored by the system, all items are marked as new even though they could already been read. This causes a torrent of "missed" calls after restoring call log with the setup wizard. This CL ignore read entities in the query. Bug: 62871863 Test: CallLogNotificationQueryHelperTest PiperOrigin-RevId: 167602820 Change-Id: Iba5609ace895a309685bfcd61eae85e080562ec5
2017-09-11Merge "Switch Dialer to use new third_party bubble library"Treehugger Robot
2017-09-11Switch Dialer to use new third_party bubble librarysail
This CL switches Dialer to use the new common bubble libary. It also moves the integration tests into the bubble libary. Bug: 64797730 Test: BubbleIntegrationTest PiperOrigin-RevId: 167439680 Change-Id: Ie2e9367cb6a6561efb8abd425b6a12f8c1e78138
2017-09-07Merge changes I2f94d863,Id7f5ce4b,I1c0b5b42,I4d8d8de8,I3765a9ae, ...Treehugger Robot
* changes: Added search actions to the end of the dialpad search results. Disable action on bubble when hiding, and reable it when showing. Improved behavior of back button in search ui. Fix crash when Context is null in InCallPresenter Bump version code and name to Dialer v12.1 and Dialer v13 (again). Adding dialer specific transcription error codes Removes the unused dialer/app/filterednumber package. Ignore invalid action for LegacyVociemailNotificationReceiver
2017-09-07Added search actions to the end of the dialpad search results.calderwoodra
Users can now create new contacts, add to existing contacts, send sms and make ViLTE calls from dialpad search results. screenshot: http://screen/7iR038nUvmh from the bugbash: 11. Missing “Create new contact” “Add to a contact” “Send SMS” from search results with a phone number search Bug: 64902476 Test: many PiperOrigin-RevId: 167362073 Change-Id: I2f94d863035c119ec526e02e088992c618a858a9
2017-09-07Disable action on bubble when hiding, and reable it when showing.yueg
Allowing click or moving bubble when hiding bubble makes no sense. Also, hide() and swapViewHolders() (called when expand/collapse) may add/remove the same view to windowManager and cause crash. Before: https://drive.google.com/a/google.com/file/d/0Bz1rQbdSCWSKRDEyT2JDdk9LVDA After: https://drive.google.com/a/google.com/file/d/0Bz1rQbdSCWSKUE53aldna0RFVFE Test: BubbleTest PiperOrigin-RevId: 167334496 Change-Id: Id7f5ce4bdfa074840c1e9fac981abad59e261c0e
2017-09-07Improved behavior of back button in search ui.calderwoodra
Pressing the back button in the search UI now functions as follows: - If the keyboard is opened, the keyboard is minimized - If the dialpad is opened, the dialpad is closed - If the keyboard and dialpad is closed, the search ui is closed Our existing behavior was dependent on whether a query had been built yet. basically, if the user pressed back with no query selected, the search ui was closed. From the bugbash: 7. No scroll bar in the search results if the results do not fill the entire view. The keyboard overlaps the results and there is no way to get to the enter list without dismissing the keyboard. 10. Dismiss the keyboard on tapping the down arrow on the keyboard. Arrow points down but works like back button Bug: 64902476,64137632,62685859,63691995,63939331 Test: manual PiperOrigin-RevId: 167332236 Change-Id: I1c0b5b429316dae119b5fb21be4303d7fe052e35
2017-09-07Fix crash when Context is null in InCallPresenterroldenburg
We need to use the Context to check if the device is a ODR device for a workaround (http://cl/165734624). It turns out the Context can be null (rarely). In those cases, we should not crash. Bug: 64954483 Test: manual PiperOrigin-RevId: 167326838 Change-Id: I4d8d8de86b5e3a4eca165a562f2ddc6106052c6e
2017-09-07Bump version code and name to Dialer v12.1 and Dialer v13 (again).Android Dialer
This CL updates version codes and name for Dialer v12.1 to 17*****. Doing so also bumps v13 to 18*****. Test: N/A PiperOrigin-RevId: 167326768 Change-Id: I3765a9ae8b06669a3eb96fef03a8a1432b3fc278
2017-09-07Adding dialer specific transcription error codesmdooley
These new states will be used to show descriptive failure messages to the user. Also moved the VoicemailCompat class to avoid duplicate code. Bug: 37340510 Test: none PiperOrigin-RevId: 167314611 Change-Id: I618d7f196ea2b0161cbd33479553cae3521328d7
2017-09-07Removes the unused dialer/app/filterednumber package.calderwoodra
Test: manual PiperOrigin-RevId: 167310802 Change-Id: Ie27a1b2f4daf73133edfb9de7f4e4aff1d87b6c8
2017-09-07Ignore invalid action for LegacyVociemailNotificationReceivertwyen
Somehow a null action will be sent to the receiver. Bug: 64934925 Test: LegacyVoicemailNotificationReceiveverTest PiperOrigin-RevId: 167300542 Change-Id: Ifa001d102d265e1dad42806b48f0a1710d05b195
2017-09-07Merge changes Ib013b10f,I07563fd2Treehugger Robot
* changes: Use simulator to add in-call UI integration tests Adjusted layout dimensions in new search UI.
2017-09-07Merge changes I0e8549cf,I12ac7b89,I2c77f0c6,I3ba5795bTreehugger Robot
* changes: Lazy loading animation of hd icon. Use TelecomManager#isInManagedCall starting from O. Setup SMS filter during activation if legacy mode is used Last contact in search is now visible when dialpad is closed.
2017-09-07Merge changes I4b5a494b,I4b6f7ca8Treehugger Robot
* changes: Added logging to aid debugging of issue where dialer shows blank screen. NewSearchFragment contact photos now properly open quick contact cards.
2017-09-07Merge "Added presubmit check to remove static imports from third_party java/"Treehugger Robot
2017-09-07Use simulator to add in-call UI integration testssail
This CL uses the simulator connection service to perform integration tests for incallui. The main pieces of this CL are: - DialerCallEvent - this is how we track changes to the incallui calls - Simulator.Event - this is how we track changes to a simulator connection With the above two we can do things like: - block until a DialerCall switches from ACTIVE TO ONHOLD: - DialerCallEspresso.waitForNextEvent(tracker, call, new DialerCallEvent(STATE_CHANGE, "ACTIVE", "ONHOLD") - block for a connection to recive a particular DTMF code: - SimulatorConnectionEspresso.waitForNextEvent(call, Event.DTMF) Future CLs will include things like: - fling to answer / reject - conference calls - screenshot diffing - video calling Test: InCallActivityTest PiperOrigin-RevId: 167211015 Change-Id: Ib013b10fe963092fad0816b07b1659efd69d9468
2017-09-06Adjusted layout dimensions in new search UI.calderwoodra
screenshots: default: http://screen/qEdB51A3PDn zero-query: http://screen/qEBDg0auGA8 query: http://screen/SuLp2GwyvYr Bug: 64806278 Test: manual PiperOrigin-RevId: 167205946 Change-Id: I07563fd23801da8d9d2eb95f6d09a079474403eb
2017-09-06Lazy loading animation of hd icon.wangqi
This save us ~180ms on Go device. (analyzed by systrace) This change also adds some trace information on incallui. Bug: 64542087 Test: manual PiperOrigin-RevId: 167201182 Change-Id: I0e8549cfb3534d518e3990696616855bcf7733f2
2017-09-06Use TelecomManager#isInManagedCall starting from O.wangqi
The TelecomManager#isInCall method returns true anytime the user is in a call. Starting in O, the APIs include support for self-managed ConnectionServices so that other apps like Duo can tell Telecom about its calls. So, if the user is in a Duo call, isInCall would return true. Dialer uses this to determine whether to show the "return to call in progress" when Dialer is launched. Instead, Dialer should use TelecomManager#isInManagedCall, which only returns true if the device is in a managed call which Dialer would know about. Bug: 36991070 Test: none PiperOrigin-RevId: 167200903 Change-Id: I12ac7b893dcbfa2fc842ca5ab356fbbc490a098b
2017-09-06Setup SMS filter during activation if legacy mode is usedtwyen
If the user disabled VVM on pre-O devices then upgrade to O, dialer will not setup the filter because VVM is disabled. The legacy mode which translate VVM SMS into traditional notifications needs the filter to operate. This CL sets up the filter if legacy mode is used. Bug: 65050952 Test: ActivationTaskTest PiperOrigin-RevId: 167199492 Change-Id: I2c77f0c6964b157d36bfa2adde7169b9ac6ccc3a
2017-09-06Last contact in search is now visible when dialpad is closed.calderwoodra
When the dialpad closes and we enter regular search, the fragment translates downwards so the upper contact is not cropped. This resulted in the bottom contact being cropped. Now the fragment translates and resizes so all contacts fit in the provided space. from the bugbash: #20: last contact is hidden off screen when in regular search screenshot: http://screen/vbduKLKKor2 Bug: 64902476,36880551 Test: manual PiperOrigin-RevId: 167189351 Change-Id: I3ba5795ba4c2f781dc320add3928c5ad74070b46
2017-09-06Added logging to aid debugging of issue where dialer shows blank screen.zachh
Bug: 64129606 Test: none PiperOrigin-RevId: 167174480 Change-Id: I4b5a494b0b334b42ee053c4d4d1e81d7699461d0
2017-09-06NewSearchFragment contact photos now properly open quick contact cards.calderwoodra
There was an issue where businesses' and remote contacts' contact photos wouldn't open contact cards correctly. The issue was rooted in the incorrect contact uri being assigned to the quick contact badge. from the bugbash: 16. Tap on business icon from search results says “ no application found” instead of opening the business info 17. Same as #16 but with contact from Directory Google.com - “The contact doesn’t exist” when tapping contact icon Bug: 64902476 Test: existing PiperOrigin-RevId: 167111016 Change-Id: I4b6f7ca812d2fc4dc220951e8c05db2c8b8d6114
2017-09-06Added presubmit check to remove static imports from third_party java/calderwoodra
Test: http://screen/9eBrOUZj90T PiperOrigin-RevId: 167099613 Change-Id: I3ae96b376ced290ff9d1f328cfaf29b8f8fce979
2017-09-04Merge "Explicitly specify annotation processor classes for Grok."Roland Levillain
2017-09-01Explicitly specify annotation processor classes for Grok.Roland Levillain
Test: mmma packages/apps/Dialer Test: make dist grok-index ALTERNATE_JAVAC=vendor/unbundled_google/tools/grok/javac_wrapper.sh GROK_ROOT_DIRECTORY=`pwd` (on mirror-aosp-master) Bug: 64948335 Change-Id: I98af4233f86369dfb1c85062d90cf3164819207d
2017-08-31Merge "Update Dialer source to latest internal Google revision."Treehugger Robot
2017-08-31Update Dialer source to latest internal Google revision.Eric Erfanian
Previously, Android's Dialer app was developed in an internal Google source control system and only exported to public during AOSP drops. The Dialer team is now switching to a public development model similar to the telephony team. This CL represents all internal Google changes that were committed to Dialer between the public O release and today's tip of tree on internal master. This CL squashes those changes into a single commit. In subsequent changes, changes will be exported on a per-commit basis. Test: make, flash install, run Merged-In: I45270eaa8ce732d71a1bd84b08c7fa0e99af3160 Change-Id: I529aaeb88535b9533c0ae4ef4e6c1222d4e0f1c8 PiperOrigin-RevId: 167068436
2017-06-21Disable Orange VVM in AOSP dialerTa-wei Yen
am: 7cc2ab563c Change-Id: I7285305983985264b5588f7240e19785a484cb11
2017-06-13Merge "Fix dependencies of packages that target earlier releases" am: 8e49b42b6fPaul Duffin
am: ef26655bcf -s ours Change-Id: Ie6549560c815fb1ee03ff9ec51f27b30f5087cf9
2017-06-13Merge "Fix dependencies of packages that target earlier releases"Paul Duffin
am: 8e49b42b6f Change-Id: If33a227619c50e0d2b19dd3cc9f14e9d45ad5807
2017-06-13Merge "Fix dependencies of packages that target earlier releases"Treehugger Robot
2017-06-13Fix dependencies of packages that target earlier releasesPaul Duffin
A previous change added legacy-android-test as a static dependency to all packages that build against the current, test_current or system_current and failed to compile when the junit and android.test classes were removed from the API. Unfortunately, those changes did not take into account that some of those packages target earlier API versions and so will always have the classes available at runtime. This change replaces those static dependencies with dynamic dependencies for any package that targets an earlier API version. The file changes were made automatically by a tool that constructed and then analyzed a full dependency graph of all the Android Java modules. The individual changes were checked manually to ensure that the changes matched the intent. The affected modules were built against an API with the junit and android.test classes removed. Any issues found during this process resulted in either the tool being updated to address the issue or a separate change being made to fix an existing problem with the build. A sample of the affected packages were run to ensure that they worked as expected at runtime; no issues were found during testing. The following change descriptions were generated automatically and so may be a little repetitive. They are provided to give the reviewer enough information to check the comments match what has actually been changed and check the reasoning behind the changes. * Android.mk Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES because Dialer's manifest file (AndroidManifest.xml) targets API level 23 and dynamically includes the android.test.runner library at runtime so there is no point in statically including the classes. It was not added to LOCAL_JAVA_LIBRARIES because module Dialer does not have any dependencies on android.test classes * tests/Android.mk Added 'android.test.mock.sdk' and 'legacy-android-test' to LOCAL_JAVA_LIBRARIES because module DialerTests builds against 'LOCAL_SDK_VERSION := current' and uses classes from packages android.test and android.test.mock (possibly indirectly) so will no longer compile once they are removed from the API. They were not added to LOCAL_STATIC_JAVA_LIBRARIES because DialerTests's manifest file (AndroidManifest.xml) targets API level 23 and uses the android.test.runner library which will provide the classes dynamically at runtime. Dependency 'android.test.mock.sdk' is used instead of 'android.test.mock' because module DialerTests builds against the API not internal jars and so should use libraries that build against the API not internal jars. A future change will replace the dependency on 'legacy-android-test', which builds against the internal jars with a dependency on 'android.legacy.test' which will build against the API. Bug: 30188076 Test: make checkbuild and ran a sample of tests Change-Id: Ia69a25caeef20017c311f45d046fbccb83ea7394 Merged-In: I10c2c5f315e442477be81726e7df20d569fe5305 Merged-In: I37a618deba48d87a1a03d82ad4022233b408a788
2017-06-12Disable Orange VVM in AOSP dialerTa-wei Yen
Orange has made a few request that cannot be resolved in the O timeframe. VVM support for it should be disabled in AOSP so OEMs won't get it by default without the fixes. These issues will be resolved in August when O is released and dialer is doing regular drops in the public. France is live in prod while Belgium/Luxembourg is experimental behind a flag. This CL does not affect GoogleDialer in the system image Change-Id: Ia7e5c9b5d2411a15453f585bb9eae88aae1bbc00 Fixes: 62536071 Test: manual
2017-06-01Merge "Remove usages of ActionBarActivity." into oc-devAurimas Liutikas
am: 28d5e3ca4a Change-Id: Ic4912b727886f3e9a24f6e4a88ab433b57c19057
2017-06-01Merge "Remove usages of ActionBarActivity." into oc-devTreeHugger Robot
2017-05-31Update Dialer to v10 RC45.Eric Erfanian
am: 83b20211c3 Change-Id: Ide21415247a3ec743f5438c49d29ba2d861081b0
2017-05-31Update Dialer to v10 RC45.Eric Erfanian
This release was created following the instructions at: go/dialer-aosp-release Subsequent dialer releases will follow as O bugs are fixed, until we reach our final RC. Version: 10 Candidate: RC45 Branch: dialer-android_release_branch/153304843.1 dialer-android_20170416.00/dialer-android_20170416.00_RC45 This release contains the following bug fixes since RC39: Bug: 38131932 38302993 38347350 38368993 38395481 62100344 Test: make, on device Change-Id: Ib4af5dcc58c684d51ea1f4628b301e40184b81b3
2017-05-26Set camera to null when disabling IMS video transmissionSailesh Nepal
am: d40e05b9e0 Change-Id: I083c9e03f38eacd2cb4eff67b07b302e67196add
2017-05-26Set camera to null when disabling IMS video transmissionSailesh Nepal
From Tyler's investigation: In the past (Marshmallow days) we used to call setCamera(null) as well as sending the downgrade request. Stopping the video transmission is one thing but I think the modem implementation depends on the camera being nulled to clean up its resources. (This CL is a manual cherry pick of cl/157154988 from google3 to gerrit.) Bug: 38395481 Change-Id: I7f71c1ffb7194165b8968cd4a033ffea1af443ed
2017-05-26Fix permissions missing in AOSP buildTa-wei Yen
am: 6af9c02cc2 Change-Id: I9862669e6fce83a12fcac9e64287346cd03e72ce
2017-05-25Fix permissions missing in AOSP buildTa-wei Yen
The voicemail module permissions are in a different manifest, and was not merged. Test: manual VVM smoke test Change-Id: I00c7abf16a5ed40d2d3b0e26463663e60fc8b05f Fixes: 38421210
2017-05-24Remove usages of ActionBarActivity.Aurimas Liutikas
ActionBarActivity has been deprecated for 2+ years and has been extending AppCompatActivity for all that time. These changes should be no-ops. Bug: 35253513 Test: None Change-Id: Ic87c8db6f9733fbcfa59d3bc08c77013799ae652 (cherry picked from commit 27b5eaeb2d0cdffb0b89db4971894548da8afdd4)
2017-05-23Update Dialer to v10 RC39Eric Erfanian
am: 3ed0c281a1 Change-Id: Ibcd2bd797d09d8d5cbc490fb1779db37ec5069e7
2017-05-23Update Dialer to v10 RC39Eric Erfanian
This release was created following the instructions at: go/dialer-aosp-release Subsequent dialer releases will follow as O bugs are fixed, until we reach our final RC. Version: 10 Candidate: RC39 Branch: dialer-android_release_branch/153304843.1 dialer-android_20170416.00/dialer-android_20170416.00_RC39 This release contains the following bug fixes since RC32: Bug: 38137349 38249439 38299262 38329114 Test: make Change-Id: I65f695db8aa20902fa60835d58b41cfdfe42704b
2017-05-16Merge "Revert "Tweak app makefile with extra resources"" into oc-devKirill Grouchnikov
am: fb63fc2c6b Change-Id: I88573a3020e6394f819245dea10ad741b6ccb81a
2017-05-16Merge "Revert "Tweak app makefile with extra resources"" into oc-devKirill Grouchnikov
2017-05-16Revert "Tweak app makefile with extra resources"Kirill Grouchnikov
This reverts commit cb06686aba5b9e080e1b758e2ea17a73be648601. Bug: 30240339 Change-Id: Ida9c44c7d856d9bcbf921fcd8ff05cef88b69b7c
2017-05-16Merge "Update Dialer to v10 RC32" into oc-devEric Erfanian
am: 0c9dbf507b Change-Id: I5f90090090c6e430d83fcdd294082c1f5237ade8
2017-05-15Merge "Tweak app makefile with extra resources" into oc-devKirill Grouchnikov
am: e724c7b637 Change-Id: I63a0ccc8cb1fa4908ff2c5b6f9d6a968079e12fd
2017-05-15Merge "Update Dialer to v10 RC32" into oc-devTreeHugger Robot
2017-05-15Merge "Tweak app makefile with extra resources" into oc-devKirill Grouchnikov
2017-05-15Update Dialer to v10 RC32Eric Erfanian
This release was created following the instructions at: go/dialer-aosp-release Subsequent dialer releases will follow as O bugs are fixed, until we reach our final RC. Version: 10 Candidate: RC32 Branch: dialer-android_release_branch/153304843.1 dialer-android_20170416.00/dialer-android_20170416.00_RC32 This release contains the following bug fixes since RC17: Bug: 33176679 33272455 3646510 36773894 37297649 37413780 37513689 37640315 37680595 37698062 37873639 37901752 37919295 37953423 38062852 38069600 38137349 38173549 38180252 38191514 Test: make, on device Change-Id: I4e4bb630082758e418ff24892b7db3142c6eb09a
2017-05-11Tweak app makefile with extra resourcesKirill Grouchnikov
Test: mmma packages/apps/Dialer Bug: 30240339 Change-Id: Id7c7ba6eaf46b0561a7c186aa87e96a1d407ddcb
2017-05-10Exclude SpannedTestUtils from buildPaul Duffin
The SpannedTestUtils class which is built into the production Dialer app contains references to JUnit. Rather then embed JUnit in Dialer it was excluded from the build. It is not actually used at all anywhere in Dialer app so may even be able to be deleted. Bug: 30188076 Test: make checkbuild Change-Id: I10c2c5f315e442477be81726e7df20d569fe5305 Merged-In: I37a618deba48d87a1a03d82ad4022233b408a788
2017-05-05Update Dialer to v10 RC17Eric Erfanian
am: 738bb09ade Change-Id: Iaa12541ea3513328710edc6ae21f77d3260bebe8
2017-05-05Update Dialer to v10 RC17Eric Erfanian
This release was created following the instructions at: go/dialer-aosp-release Subsequent dialer releases will follow as O bugs are fixed, until we reach our final RC. Version: 10 Candidate: RC17 Branch: dialer-android_release_branch/153304843.1 dialer-android/dialer-android_20170416.00/dialer-android_20170416.00_RC17 This release contains the following bug fixes since RC16: Bug: 37962346 Test: make, on device Change-Id: I1852cc096ef242c7bfcd85b11f954ddb00903c39
2017-05-05Update Dialer to V10 RC16Eric Erfanian
am: 10b34a5ebf Change-Id: Iea3e96ccdeaf1fa796ceca702cace82ca20f298c
2017-05-04Update Dialer to V10 RC16Eric Erfanian
This release was created following the instructions at: go/dialer-aosp-release Subsequent dialer releases will follow as O bugs are fixed, until we reach our final RC. Version: 10 Candidate: RC16 Branch: dialer-android_release_branch/153304843.1 dialer-android/dialer-android_20170416.00/dialer-android_20170416.00_RC16 This release contains the following bug fixes since RC00: Bug: 37324705 35304403 36067503 35304446 33203808 37280992 37346084 35766990 37481880 37424493 36470282 37347691 37519015 37168472 35805360 37545472 27704934 36515614 35766990 37577470 34739750 35801628 36788693 35264204 36708536 37628370 36904650 37314436 37642171 37530847 37637799 37666625 37548549 37648036 37636412 37323529 37630507 35919141 37198343 37548572 36178218 37640315 37663896 37720467 37275944 37710497 31634477 37744796 37348506 37744796 37568534 37672424 34872683 34873026 37681461 34873295 37748373 37526812 37618638 37663896 37536088 37727455 37165687 36651204 36900708 37323529 36902926 37256480 37328353 37432034 37436952 34093562 37720889 37321935 37780300 37781115 37755902 36588206 34258266 37290464 37698062 37618638 37473004 37432034 37918676 37870494 37722091 Test: make, on device Change-Id: I99e1a484ccd578c1f8a13e7a6a4b4952f0791297
2017-05-03This change reflects the Dialer V10 RC00 branch.Eric Erfanian
am: 8369df095a Change-Id: I6820870feb74cba010ac3039e4da41325b3005f9
2017-05-03This change reflects the Dialer V10 RC00 branch.Eric Erfanian
RC00 is based on: branch: dialer-android_release_branch/153304843.1 synced to: 153304843 following the instructions at go/dialer-aosp-release. In this release: * Removes final apache sources. * Uses native lite compilation. More drops will follow with subsequent release candidates until we reach our final v10 release, in cadence with our prebuilt drops. Test: TreeHugger, on device Change-Id: Ic9684057230f9b579c777820c746cd21bf45ec0f
2017-05-02Merge "Use AAPT2" into oc-devAlan Viverette
am: afa29d4a86 Change-Id: Ib5c647a5129794248862156bf8f836c74ddbf486