summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-03-08Bring back new navigation screen event logging.yueg
Test: MainActivityOldPeerTest PiperOrigin-RevId: 188409482 Change-Id: I0c132c49d63b9af849522851c55f51d431faa603
2018-03-08Show bubble when call connected and in-call UI not showing.yueg
We used to only show bubble when leaving in-call UI, so answering from Bluetooth does not show bubble. Fix it by also showing bubble in onCallListChanged(). Test: NewReturnToCallControllerTest PiperOrigin-RevId: 188403460 Change-Id: I5e6a3c37b2773e426dcc73ae5661b9e145b20cb8
2018-03-08Add divider line to nui voicemail alertuabdullah
Adds a divider line to differentiate the voicemail entries and the alerts. Bug: 73158572 Test: N/A PiperOrigin-RevId: 188389442 Change-Id: I33bd32fc310cdf52f20bcb2d0b2cd4266420cab6
2018-03-08Optimize characters sent to remote party for RTT chat.wangqi
Instead of using things provided by Android of onTextChanged, we compare the text in EditText with the text in bubble before the change and compute the delta string need to send to remote party. This way we could minimize characters sent thus reduce latency. Bug: 67596257 Test: RttChatMessageTest PiperOrigin-RevId: 188389325 Change-Id: I3023b484c32b2369ca8720104da74cf6906bb46e
2018-03-08Refactor array of RttChatMessage to List.wangqi
Bug: 67596257 Test: RttChatMessageTest PiperOrigin-RevId: 188373256 Change-Id: I0f0798a5310225456619757dcca5bbd5df372b91
2018-03-08Merge changes I513e1111,Ie1b1f439Treehugger Robot
* changes: Disable phone number formatting for Argentina only (MCC = 722). Implement logic for unblocking a number from the new call log's bottom sheet.
2018-03-08Disable phone number formatting for Argentina only (MCC = 722).linyuh
Bug: 73718977 Test: Existing tests PiperOrigin-RevId: 188359859 Change-Id: I513e1111b643d6fa476d1e56b60c0d6e61e131f4
2018-03-08Implement logic for unblocking a number from the new call log's bottom sheet.linyuh
Bug: 70989547 Test: ShowBlockReportSpamDialogNotifierEndToEndTest PiperOrigin-RevId: 188357953 Change-Id: Ie1b1f439f043805892876790d7590a4c721dbf8c
2018-03-08Merge "Implement logic for blocking a number from the new call log's bottom ↵Treehugger Robot
sheet."
2018-03-08Implement logic for blocking a number from the new call log's bottom sheet.linyuh
Bug: 70989547 Test: ShowBlockReportSpamDialogNotifierEndToEndTest PiperOrigin-RevId: 188351591 Change-Id: I634fb821592bdc890df291fdf83cdf307c94ffa9
2018-03-08Merge changes I23025e9b,Ic9486b3fTreehugger Robot
* changes: Support local emergency phone number check when there are multiple SIMs. Add additional logging to missed call notification code path
2018-03-08Merge "Fix view not attached to window manager crash and add logs."Treehugger Robot
2018-03-07Support local emergency phone number check when there are multiple SIMs.linyuh
Bug: 73994020 Test: PhoneNumberHelperTest PiperOrigin-RevId: 188260007 Change-Id: I23025e9b9454f487117c35e7a3b09307371ae825
2018-03-07Add additional logging to missed call notification code pathroldenburg
Bug: 73877234 Test: just logging PiperOrigin-RevId: 188256051 Change-Id: Ic9486b3fc1d97338cb016b86a243612baa6282fe
2018-03-07Fix view not attached to window manager crash and add logs.yueg
Test: none PiperOrigin-RevId: 188244536 Change-Id: I7d41adaf600ba7829054ab8af6b4d30fd0873c3b
2018-03-07Merge changes I699fc02f,Ifaacf982Treehugger Robot
* changes: Combine fragment hide/show transactions into one transaction. Handle preferred SIM for ACTION_CALL
2018-03-07Combine fragment hide/show transactions into one transaction.roldenburg
My hypothesis is that trying to commit multiple seperate transactions back to back causes the fragment container to get into a weird state. So this change has two parts: - Disable preloading call log - Combine the seperate hide/show transactions into one transaction - Don't call conflicting transactions (i.e. hide then immediately show) Bug: 74051208 Test: existing tests, manual PiperOrigin-RevId: 188215791 Change-Id: I699fc02f1e2716bc019a29dc047ee4bc0d52df35
2018-03-07Handle preferred SIM for ACTION_CALLtwyen
Previously preferred SIM is handled only by precall, which covers dialing with dialer or with the special receiver contacts uses. If a third party app uses ACTION_CALL or telecomManager.placeCall(), then the in call UI will be launched directly and the old account selection dialog will be used without preferred SIM support. In this CL logic from CallingAccountSelector is refactored out so InCallActivity can use it for the dialog. Bug: 73718976 Test: Unit tests, In call UI not covered. PiperOrigin-RevId: 188214007 Change-Id: Ifaacf982a3e98601dc362b649c3501d4ee96e63e
2018-03-07Merge "Show a warning dialog about charges when user starts a video call"Treehugger Robot
2018-03-07Merge "NUI logging"Treehugger Robot
2018-03-06Show a warning dialog about charges when user starts a video callwangqi
The user starts a video call a warning dialog shall be presented. If the user presses "OK" with the "Do not show again" box selected, the dialog shall not be presented anymore. Test: manual - Verified that a warning dialog about charges is shown when a video call is started if KEY_SHOW_VIDEO_CALL_CHARGES_ALERT_DIALOG_BOOL is true. This is an upstream change from: https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/518977/8 Bug: 67832837 Test: partner manual test PiperOrigin-RevId: 188103414 Change-Id: I62628a32557297acaef096db90d2ddf049ef5017
2018-03-06NUI loggingyueg
- Add screen events for 4 tabs, dialpad and search. - Add impressions for opening MainActivity with tabs/dialpad (non user tab selection). - Add impression for VVM visible. Bug: 72525843 Test: MainActivityOldPeerTest, MainSearchControllerTest PiperOrigin-RevId: 188090249 Change-Id: Ifdf3519f07d7230f20b5d82691a96747b1944d63
2018-03-07Merge "Make user able to set default sim when there is no account."Treehugger Robot
2018-03-06Make user able to set default sim when there is no account.yueg
Test: CallingAccountSelectorTest, manual PiperOrigin-RevId: 188089149 Change-Id: Id1be88124e243e46ac9b0277f40de142af6bb5a9
2018-03-06Merge "Covnert @AutoValue PhotoInfo into a proto."Treehugger Robot
2018-03-06Covnert @AutoValue PhotoInfo into a proto.linyuh
Bug: 74202944 Test: Existing tests PiperOrigin-RevId: 188060790 Change-Id: I4d79a353abf767935383d4149f261f5e96fd7acb
2018-03-06Merge "Updating voicemail_donation_promo_content per UXW"Treehugger Robot
2018-03-06Updating voicemail_donation_promo_content per UXWmaxwelb
Bug: 73798533 Test: N/A PiperOrigin-RevId: 188046222 Change-Id: I1b66afa787bb5c91d71dbeda544218226ae8f5fd
2018-03-06Merge "Add support for bluetooth etc. audio route for RTT call."Treehugger Robot
2018-03-05Add support for bluetooth etc. audio route for RTT call.wangqi
Bug: 67596257 Test: manual PiperOrigin-RevId: 187944752 Change-Id: I2bbe45d2bda22bb000239f8613576fffb9f6ab28
2018-03-05Merge changes I00d58071,I98cea86bTreehugger Robot
* changes: Disable phone number formatting for LATAM MCCs. Check if the activity is still alive before refreshing unread tab counts.
2018-03-05Disable phone number formatting for LATAM MCCs.linyuh
Bug: 73718977 Test: MotorolaUtilsTest & PhoneNumberHelperTest PiperOrigin-RevId: 187889473 Change-Id: I00d58071ba18ddce5a09c07de9edd2d0956d6478
2018-03-05Check if the activity is still alive before refreshing unread tab counts.calderwoodra
My hypothesis is that there is a race condition where the call log changes and we are leaving the activity before the content observer is unregistered or the loader it starts is finished. This results in a callback calling #fetchCalls while Dialer is in the background, resulting in a crash. This change will confirm my hypothesis. Even if my hypothesis is incorrect, we have similar checks throughout this class which indicates to me that some issue exists here and that this check is safe to do. Bug: 73972084 Test: n/a PiperOrigin-RevId: 187700318 Change-Id: I98cea86b5b7041c4f4aac09544445aaade6bfd40
2018-03-03Merge "Added impression logging for AnnotatedCallLog rebuild operations."Treehugger Robot
2018-03-02Added impression logging for AnnotatedCallLog rebuild operations.zachh
Bug: 70989667 Test: unit PiperOrigin-RevId: 187694255 Change-Id: Ie6ec70a70a4c59cbdfe25c34003d21fa2f751564
2018-03-03Merge "Added timing to some more AnnotatedCallLog operations."Treehugger Robot
2018-03-02Added timing to some more AnnotatedCallLog operations.zachh
This includes: 1) Made RefreshAnnotatedCallLogWorker.refresh() methods return a result which is "not dirty", "dirty but no changes needed" or "dirty and changes need". It will be interesting to see how often these cases occur (will log impressions in a future CL) so I thought we might as well log the latency of each case separately as well. 2) To support 1) added a new method to FutureTimer which allows you to compute the event name from the result of the timed Future. Also needed to update the Metrics interface to support deferring the event name when starting a timer via a generic token. 3) Timing the coalesce operation which is very heavyweight. 4) Made StubMetrics do some logcat logging to easily observe timing information using AOSP Bug: 70989667 Test: unit PiperOrigin-RevId: 187691203 Change-Id: I5f19a2fc94d86639486299b65b0edd66eeaab52e
2018-03-03Merge "Move assisted dialing out of P."Treehugger Robot
2018-03-02Move assisted dialing out of P.erfanian
Bug: 73727182 Test: tested PiperOrigin-RevId: 187673539 Change-Id: I9c790e912990fb8dc46da1c1057339c979ac9501
2018-03-02Merge "Remove voicemail instruction text"Treehugger Robot
2018-03-02Merge changes Ib8e1b852,I7e848e97,I7d620721Treehugger Robot
* changes: Update fragment class. Add ripple effect to RTT incall buttons. Remove dialer sounds and vibrations settings fragments and redirect to the system sound settings fragment instead.
2018-03-02Remove voicemail instruction textmaxwelb
Bug: 74028377 Test: Manual :/ PiperOrigin-RevId: 187634587 Change-Id: I51be6c151db37988bd68558a6af8c2bab31939a1
2018-03-02Update fragment class.erfanian
Bug: 73775453 Test: unit tests. PiperOrigin-RevId: 187630263 Change-Id: Ib8e1b852b4ab4ca6614182db0cb72e413c1612eb
2018-03-02Add ripple effect to RTT incall buttons.wangqi
Bug: 67596257 Test: manual PiperOrigin-RevId: 187564625 Change-Id: I7e848e975bbab19e605d09283dee24eeb02550f1
2018-03-02Remove dialer sounds and vibrations settings fragments and redirect to the ↵uabdullah
system sound settings fragment instead. There is no need for dialer to have it's own sounds and vibrations fragment. Instead of maintaining two separate fragments that do that same thing (and have to be kept in sync), we can just have one source of truth and have users modify those settings. Thus we have removed the dialer and vibrations settings fragment and have it instead re-direct to the system sound settings. The automatic advantage of this is also that for dual sim cases, dialer settings don't need to be updated. Bug: 73750524 Test: Manual. Navigated to the dialer sound and settings fragment, and it opened the system settings. Also pressing back took us back to Dialer as expected. PiperOrigin-RevId: 187564461 Change-Id: I7d620721237f1c932ed8cea949486ae7dbdefba1
2018-03-02Merge changes Ic19643f4,I4cb7c234,If4e1f7c1,I38facbaaTreehugger Robot
* changes: Use voicemail image for empty voicemail tab and update color Implemented DialerFloatingActionButton Instead of just cancelling loaders, reset them as well. Update RTT icon on ringing screen.
2018-03-01Use voicemail image for empty voicemail tab and update coloruabdullah
This CL updates the icon for the empty voicemail tab and updates the tint of it as well. It also updates the size of the voicemail icon when in landscape mode. Bug: 25661977,74085541 Test: N/A PiperOrigin-RevId: 187557890 Change-Id: Ic19643f4e63e3ce70ba6b029ce45a570404f28e7
2018-03-01Implemented DialerFloatingActionButtoncalderwoodra
Implemented wrapper class for FloatingActionButton to resolve some of FloatingActinButton's many issues. One of which is alllowing clicks while animating that was causing a crash in NUI. This change also fixes an issue with the dialpad exit animation. Bug: 73995512 Test: Robolectric and Espresso don't support these kinds of tests very well PiperOrigin-RevId: 187556390 Change-Id: I4cb7c2346a0ef09f2f3d8b48e7e14d01460cd1a7
2018-03-01Instead of just cancelling loaders, reset them as well.calderwoodra
Bug: 71385186 Test: manual PiperOrigin-RevId: 187552834 Change-Id: If4e1f7c18d5f5aae2a152762189948c3543ba321
2018-03-01Update RTT icon on ringing screen.wangqi
Bug: 67596257 Test: manual PiperOrigin-RevId: 187551861 Change-Id: I38facbaaa48ba4afe29e382de9c8241d8936c3ab
2018-03-02Merge "Disable phone number formatting for devices with Argentinian SIMs."Treehugger Robot
2018-03-01Disable phone number formatting for devices with Argentinian SIMs.linyuh
Bug: 73718977 Test: PhoneNumberHelperTest PiperOrigin-RevId: 187540382 Change-Id: I814ec62b2215c24b8cde3442c5dc83d98ad87164
2018-03-01Merge changes I6ef6593a,Iaa73b935Treehugger Robot
* changes: Implement overflow menu for RTT call. Rename NUI logging prefix from NUI_ to MAIN_
2018-03-01Implement overflow menu for RTT call.wangqi
Bug: 67596257 Test: manual PiperOrigin-RevId: 187529383 Change-Id: I6ef6593a79ef0c4fb407284eede966a1eaabcd1e
2018-03-01Rename NUI logging prefix from NUI_ to MAIN_yueg
Bug: 72525843 Test: none PiperOrigin-RevId: 187500135 Change-Id: Iaa73b9355a6b5c299f73fd113eb1f74a3eb47dd4
2018-03-01Merge changes I3d2b23b5,I9463e2c9Treehugger Robot
* changes: Updating SecondaryInfo value class to use AutoValue with builder pattern. Added same primes metrics that existed in Dialtacts to NUI.
2018-03-01Updating SecondaryInfo value class to use AutoValue with builder pattern.Android Dialer
Test: CallCardPresenterTest,SecondaryInfoTest PiperOrigin-RevId: 187481728 Change-Id: I3d2b23b5d51ea1e5ff30b8f6b6570d76c006fe86
2018-03-01Added same primes metrics that existed in Dialtacts to NUI.calderwoodra
Test: n/a PiperOrigin-RevId: 187442952 Change-Id: I9463e2c976102276ebc5886531397ad0cf160b78
2018-03-01Merge "Preload call log fragment on app start."Treehugger Robot
2018-02-28Preload call log fragment on app start.calderwoodra
Default is set to true but if we see issues with startup latency we can disable this server side. Test: n/a PiperOrigin-RevId: 187419851 Change-Id: I6d1debfed86dbcaf3ee73ec0906e514a2687e2c0
2018-03-01Merge changes Iae86dabb,I1db81304Treehugger Robot
* changes: Some small bug fixes in NUI. Log contact source when reporting spam from the new UI.
2018-03-01Merge changes I1c2c08cc,I76a0b43d,Ifa718fb0Treehugger Robot
* changes: Add accessibility label for voicemail transcription rating Parity of OldMainActivityPeer with ListsFragment for VM Show empty view when there are no voicemails
2018-02-28Some small bug fixes in NUI.calderwoodra
- Never show the dialpad chooser in MainActivity. - If the call log changed while dialer was in the background, it would trigger the content observer to fetch the new info, which would request it's parent that wasn't there. Now we register/unregister them in onResume/onPause. This is safe to do because we force refresh the data onResume anyways, so any changes will still be shown. Bug: 73972084,73975555,73995512 Test: manual PiperOrigin-RevId: 187407058 Change-Id: Iae86dabbcb852398bb2b9df4627e234261ab8030
2018-02-28Log contact source when reporting spam from the new UI.linyuh
Bug: 73780748 Test: PhoneLookupInfoConsolidatorTest PiperOrigin-RevId: 187404074 Change-Id: I1db81304909fbf63aba00088c12e18922042c3b1
2018-02-28Add accessibility label for voicemail transcription ratingmaxwelb
Bug: 73788896 Test: Manual :/ PiperOrigin-RevId: 187401558 Change-Id: I1c2c08cc01fd38ad5820c454991473cfb8f0fc76
2018-02-28Parity of OldMainActivityPeer with ListsFragment for VMuabdullah
This CL helps to ensure that when the VVM settings toggle is turned on or off, or a sim is swapped, inserted or removed the VM tab disappears and appears, just like it currently does. When a VM tab disappears we also move to the speed dial index. Bug: 73123614,73998717 Test: N/A PiperOrigin-RevId: 187400703 Change-Id: I76a0b43da86713caa67956413a39299c7ecbc8d1
2018-02-28Show empty view when there are no voicemailsuabdullah
When there are no voicemails to be shown, we show an empty view. This is done by hiding the recycler view and showing the empty view. Similarly when a voicemail is present, we hide the empty view and then show the recycler view. Bug: 25661977 Test: Unit Tests PiperOrigin-RevId: 187396952 Change-Id: Ifa718fb05c1be37aabdf4c91bc2c1653357565b2
2018-03-01Merge changes I3f6a5887,Icf91804dTreehugger Robot
* changes: Never start playing voicemails in the NUI VM tab from the speaker Remove background of RTT chat fragment.
2018-02-28Never start playing voicemails in the NUI VM tab from the speakeruabdullah
All voicemails played from the VM tab should always be played from the non-speaker mode. Bug: 71500892 Test: N/A PiperOrigin-RevId: 187388964 Change-Id: I3f6a5887784b0192074157cfd8a91727d124ed06
2018-02-28Remove background of RTT chat fragment.wangqi
The default incall gradiant background will be shown instead. Bug: 67596257 Test: manual PiperOrigin-RevId: 187384455 Change-Id: Icf91804d78aa98d051248a9eca0d13be0ea880f0
2018-03-01Merge "Update voicemail donations strings"Treehugger Robot
2018-02-28Update voicemail donations stringsmaxwelb
Bug: 73798533 Test: Manual :/ PiperOrigin-RevId: 187383740 Change-Id: I0f35ccbf19a59b35338cb144f0192b692585159f
2018-02-28Merge "Group info needed to show a block/report spam dialog into a proto to ↵Treehugger Robot
avoid long method signatures."
2018-02-28Group info needed to show a block/report spam dialog into a proto to avoid ↵linyuh
long method signatures. Test: Existing tests PiperOrigin-RevId: 187338094 Change-Id: I0d7a5206d127931d322b5604b2bb81f5202b8de8
2018-02-28Merge "set connection state after adding NonSimulatorConnectionListener and ↵Treehugger Robot
set connection to active at the end."
2018-02-27set connection state after adding NonSimulatorConnectionListener and set ↵weijiaxu
connection to active at the end. This is necessary to make sure that NonSimulatorConnectionListener gets event callback when Connection.setDialing() or Connection.setActive() is called. Test: On a local device. PiperOrigin-RevId: 187266120 Change-Id: I6ee5d5113285e7a27a4e8497a95b28844ac6b397
2018-02-28Merge changes I9ab50a7a,I8a57b632Treehugger Robot
* changes: Do not show the voicemail tab if the VM toggle is turned off. Internal cleanup for the new UI's bottom sheet.
2018-02-28Merge "Fab now hides/shows correctly when you enter and leave the voicemail ↵Treehugger Robot
tab."
2018-02-28Merge "Fixed some a11y issues in MainActivity."Treehugger Robot
2018-02-27Do not show the voicemail tab if the VM toggle is turned off.uabdullah
Bug: 73123614 Test: N/A PiperOrigin-RevId: 187255950 Change-Id: I9ab50a7a8052f325f1743721bf6432e6c4787a4e
2018-02-27Internal cleanup for the new UI's bottom sheet.linyuh
Test: Existing tests PiperOrigin-RevId: 187254014 Change-Id: I8a57b632d45e87ad075eb8bbb25180858e890f08
2018-02-27Fab now hides/shows correctly when you enter and leave the voicemail tab.calderwoodra
Test: manual, going between tabs hides/shows the fab properly when ToS is (in)visible. PiperOrigin-RevId: 187253210 Change-Id: Ied9ea44892786268b9dfa68816840dfbfc74aa6e
2018-02-27Fixed some a11y issues in MainActivity.calderwoodra
- main fragments are no longer detected by talkback while search is open. - FAB now has a content description Bug: 73587831,73891132 Test: tap PiperOrigin-RevId: 187248081 Change-Id: I5a8fe2df23542d19c935cba77d1337ec753064af
2018-02-28Merge "NUI no longer crashes when clicking "place call" in empty call log."Treehugger Robot
2018-02-27NUI no longer crashes when clicking "place call" in empty call log.calderwoodra
Bug: 73258376 Test: MainActivityOldPeerCallLogIntegrationTest PiperOrigin-RevId: 187242222 Change-Id: Ic2684467035fedc1156886712757bf0911f65ee5
2018-02-27Merge changes I59d70b96,If166951bTreehugger Robot
* changes: Set the correct reporting location when reporting spam in the new call log. Bump version codes and name to v19
2018-02-27Set the correct reporting location when reporting spam in the new call log.linyuh
Bug: 73816729 Test: Existing tests PiperOrigin-RevId: 187230516 Change-Id: I59d70b9676e2972b80f124f29f2c1cb1858efef8
2018-02-27Bump version codes and name to v19roldenburg
Test: n/a PiperOrigin-RevId: 187229492 Change-Id: If166951bbbe8bc38b1053f1bc8bd7eac74944964
2018-02-27Merge "Move DirectoryCompat from "contacts/common" to "dialer/common/cp2"."Treehugger Robot
2018-02-27Merge "Implement contacts promo in NUI."Treehugger Robot
2018-02-27Move DirectoryCompat from "contacts/common" to "dialer/common/cp2".linyuh
Bug: 73887387 Test: Existing tests PiperOrigin-RevId: 187225355 Change-Id: I65de553078e147a46d933daf34dfd912fc8aa74c
2018-02-27Implement contacts promo in NUI.yueg
Bug: 72525950 Test: ContactsPromoFragmentTest, MainSearchControllerTest, OldGoogleMainActivityPeerTest PiperOrigin-RevId: 187224361 Change-Id: Idc43255ccc673c6c5c17b70d1f367d1a4802bfd0
2018-02-27Merge changes I09e8be0d,Ic94816e1Treehugger Robot
* changes: Fix bug that soft keyboard pushes action bar out of window. Added 2 null checks to fix top crashers.
2018-02-27Fix bug that soft keyboard pushes action bar out of window.wangqi
This is happening on outgoing call. Bug: 67596257 Test: manual PiperOrigin-RevId: 187207221 Change-Id: I09e8be0dbad695a1a5afb64e08faf533d068e5c4
2018-02-27Added 2 null checks to fix top crashers.calderwoodra
Bug: 73886704,73887420 Test: n/a PiperOrigin-RevId: 187201516 Change-Id: Ic94816e198e29b87b031a85252e984bc167bb7f8
2018-02-27Merge "Fix for NonSimulatorConnection listener causing dialer crashing after ↵Treehugger Robot
ending a call."
2018-02-26Fix for NonSimulatorConnection listener causing dialer crashing after ending ↵weijiaxu
a call. Bug: 73903013 Test: On a local device. PiperOrigin-RevId: 187114719 Change-Id: I9cd0ee8ee33c5711f68ed78d3181347ae439f2b6
2018-02-27Merge "Allow selecting IMEI/MEID text"Treehugger Robot
2018-02-26Allow selecting IMEI/MEID textroldenburg
Bug: 73821574 Test: manual PiperOrigin-RevId: 187096752 Change-Id: I2ac254523582958084f4ebbe1b324c406c2e86f5
2018-02-26Merge changes I1c9fd942,Ib1b4baeeTreehugger Robot
* changes: Added Call History activity to MainMenu. Updating PrimaryCallState value class to use AutoValue with builder pattern.
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-15 06:51:57 +0000