Age | Commit message (Collapse) | Author |
|
PhoneLookupInfo should contain one message per PhoneLookup implementation for clarity. Instead of having a repeated Cp2Info field, we now have a single Cp2Info field which wraps a repeated Cp2ContactInfo field.
Also added ApdlInfo to the message to make testing of CompositePhoneLookup more realistic, in that it tests merging across submessages now. (ApdlInfo is more or less a placeholder until ApdlPhoneLookup is implemented.)
Test: yes
PiperOrigin-RevId: 175316738
Change-Id: I196c2eaa885e1268ff80ebaad6d85840a9cc7a15
|
|
Bug: 34672501
Test: yes
PiperOrigin-RevId: 175243488
Change-Id: Iec3b5eb0e81f6e6cc04c64c3ea65c9c7fcb33fe3
|
|
* changes:
Use type TEXT instead of STRING for annotated call log columns.
Stop turning on the screen when the incoming/outgoing call is via Bluetooth.
Filter out contacts with null primary display names in search.
Conferece call management screen UI adjustment.
|
|
* changes:
Renamed string.xml to strings.xml to match Android convention
Add UiThreadExecutor
|
|
The declared type of "STRING" has an affinity of NUMERIC, not TEXT per:
https://sqlite.org/datatype3.html
Bug: 34672501
Test: existing
PiperOrigin-RevId: 175237916
Change-Id: I220a35f3060eb60870f6e930c821bdb2f6d2c7ed
|
|
Bug: 38453773
Test: InCallActivityTest
PiperOrigin-RevId: 175230358
Change-Id: I2460308e1af554e2198c256fb1f4c62d2b8124b2
|
|
Bug: 68848807
Test: unit
PiperOrigin-RevId: 175190786
Change-Id: I15b525951cb87afb8b48f3bdb2174605c94c99cf
|
|
Including:
- change action icon color
- hide TextView for name if name is empty
- if name is empty, use number to generate avatar
- don't show number type
Bug: 67053842
Test: manual
PiperOrigin-RevId: 175188810
Change-Id: I4ba40e5332d7b8567932360d36c8dc6ec3d604a5
|
|
Bug: 68844134
Test: n/a
PiperOrigin-RevId: 175102999
Change-Id: I63e930809d4bb96669062f724fb9cab90d675afa
|
|
This CL adds an executor which runs tasks on the Ui thread, using the existing
ThreadUtil class.
Bug: 67752611
Test: UiThreadExecutorTest
PiperOrigin-RevId: 175046280
Change-Id: Iff15e216be0e91891a9d63fddf1288ecbec41f83
|
|
* changes:
Expose tab index to protected
Added temporary logging to debug problem with null phone numbers from remote contacts.
Hook up pre-call actions
Implement CallingAccountSelector and AssistedDialAction
|
|
Bug: 68840377
Test: manual verify no regression from inconsistently showing promo
PiperOrigin-RevId: 174957368
Change-Id: I0ed4fa1b24e693e91705744f60a7a385385cec64
|
|
contacts.
Bug: 68942044
Test: none
PiperOrigin-RevId: 174944384
Change-Id: Ie03ce41e517cfb73081231898a7e9dcc3feee2f2
|
|
This CL replaces all instance of CallIntentBuilder.build() with PreCall.getIntent(), which when run as an activity, will finish building the intent with user interaction.
Bug: 64216442
Test: manual
PiperOrigin-RevId: 174924323
Change-Id: If41868df4c7ed078d03bd3431fa85b8947056a01
|
|
CallingAccountSelector examines the CallIntentBuilder, and if the PhoneAccountHandle is missing on a multi-SIM device while the default is not set, it will show a dialog to let the user select it. This step used to be after the in call UI is launched and telecom wants dialer to disambiguate. This step is moved to pre call as dialer need more control, like voicemail calls should always prompt, or the preferred SIM info might be available. This also allows telecom to send the selected PhoneAccountHandle to other apps so they have more information on how to rewrite numbers.
AssistedDialAction replaces the step previously in CallIntentBuilder.build(), and rewrites the URI.
Pre-call actions are not hooked up for dialing in this CL yet, assisted dialing will still be broken.
Bug: 64216442
Test: CallingAccountSelectorTest, AssistedDialActionTest
PiperOrigin-RevId: 174917321
Change-Id: Iba2e9092f83c036b402d4044a48ff5c44e806210
|
|
* changes:
Implement PreCallCoordinator
Make CallIntentBuilder parcelable
|
|
* changes:
Use layout_gravity to horizontally center each dialpad key in landscape mode.
Unify voicemail call placing
Stop storing device orientation in DialpadView's instance variable to improve reliability.
|
|
* changes:
Rename value name to avoid conflict.
Fix previous usage of LoggingBinding with Logger class.
Disable "Switch Camera" button when not transmitting
|
|
|
|
When the user makes a call, the PreCallCoordinator will get a list of actions to perform from PreCallActionProviderComponent and apply them to the pending CallIntentBuilder, before sending the built intent to telecom
Bug: 64216442
Test: PreCallExecutorImplTest
PiperOrigin-RevId: 174911537
Change-Id: Ide5ec431d4e6e7879fcdfdbbbd7ea5eed9963b2c
|
|
Multi-SIM and several other new features requires additional user input (ie. select the phone account to call with) or processing (ie. rewrite phone number for assisted dialing) before the call is actually made. The plan is to use a chain of pre-call actions to complete the dialing infomation,with the CallIntentBuilder holding the intermediate steps. For example, a pre-call action can examine the CallIntentBuilder and figure that the PhoneAccountHandle cannot be inferred, and show a dialog for the user the select it. Only after pre-call actions are completed, the intent is built and sent to telecom.
Since pre-call actions involves dialogs and the process can be interrupted, the CallIntentBuilder must be persistable so the state can be restored. This CL made it parcelable so it can be stored with onSaveInstanceState().
The AssistedDialingMediator in CallIntentBuilder is temporarily removed as it would be called using a pre-call action in a future CL.
Bug: 64216442
Test: CallIntentBuilderTest
PiperOrigin-RevId: 174902775
Change-Id: Icf2f8fae620868d1a2f5acf0d08ae0a6bec4fb76
|
|
Test: Manual
PiperOrigin-RevId: 174792372
Change-Id: I80ff3852c40cd532fdd2ed332e8b84ffb211a6e2
|
|
All voicemails are called by using CallIntentBuilder.forVoicemail() so the PhoneAccountHandle can be designated. A future CL will use dialogs to customize the call (multi SIM selection, RTT, etc.)
As a result voicemail error messages and legacy voicemail notifications will call the account it is received from directly.
Bug: 64216442
Test: Unit tests
PiperOrigin-RevId: 174784322
Change-Id: Ibe1c57bc7852e3d55a39a0cc2da19b6a79954c0f
|
|
improve reliability.
Bug: 68941995
Test: Manual
PiperOrigin-RevId: 174782574
Change-Id: I93f358507f1f60b87e26e1bdcddf50ed1ef8e1b2
|
|
Test: None
PiperOrigin-RevId: 174782468
Change-Id: Iaf842b35f6f5fa4ac0e1505ce39e7470fb23b51d
|
|
Test: In dialer lab.
PiperOrigin-RevId: 174781953
Change-Id: I987c0d191a7c5613debb857bab9438d0c1aa20a7
|
|
Author: Ravi Paluri <rpaluri@codeaurora.org>
Bug: 68677786
Test: CallButtonPresenterTest
PiperOrigin-RevId: 174740252
Change-Id: If20e9fb92c4d729a75edf8ac6d088a88d4d319d8
|
|
Bug: 68900535
Test: SendTranscriptionFeedbackActionTest
PiperOrigin-RevId: 174732357
Change-Id: I9a99606a13cfc32f53a6ce8a15ad258bb48d7130
|
|
|
|
* changes:
Defining transcription feedback API
Added phone paused icon to on hold banner.
|
|
This adds a file called new_voicemail_media_player_layout.xml that can be expanded and collapsed on tapping the voicemail entry. This file will later be updated in accordance with the specs, but the logic for expansion and collapsing would not be affected by the future cosmetic change.
Video=https://drive.google.com/open?id=1aIpmVfUYrFrg_FZ4tRX_TX6pU9YgPQaN
Bug: 64882313,68382421
Test: Unit Tests
PiperOrigin-RevId: 174713873
Change-Id: I15a6c5f01715429a6eb51fee447a5b42f25fdb56
|
|
Bug: 68712148
Test: none
PiperOrigin-RevId: 174535170
Change-Id: I436335d142f369f8e7c3249463117ffd5c00d6b4
|
|
Public-Origin-Change-Id: If22474d96ee53ce4f7c31fac828fb56022f4fa49
Signed-off-by: Allen Calderwood <calderwoodra@google.com>
Author: Kitta Koutarou <koutarou.x.kitta@sonymobile.com>
Bug: 62440523
Test: manual
PiperOrigin-RevId: 174532793
Change-Id: I436307d42f42387c3d37eb79c99ef9200703d57f
|
|
* changes:
Implemented CompositePhoneLookup#bulkUpdate.
Allow the client to specify voicemail transcript id's
Implement bulk update for Cp2PhoneLookup.
Add character mappings for Bulgarian & Ukrainian in DialpadCharMappings.
Support dual alphabets in smart search when a secondary alphabet is available.
Commit transaction synchronously for OnHoldFragment.
|
|
Bug: 34672501
Test: unit
PiperOrigin-RevId: 174532642
Change-Id: I0115fb26f99fe764bc90625e3ed51f3c4c99439d
|
|
This is needed for rating transcription quality since we don't
persist the transcript id. The id we generate is just the md5
hash of the voicemail audio data.
Bug: 68712148
Test: manual and updated unit tests
PiperOrigin-RevId: 174527907
Change-Id: I7a29bf5a96447129fc1437074f20ecebcdb1f43b
|
|
Test: Cp2PhoneLookupTest
PiperOrigin-RevId: 174525877
Change-Id: I7888f3b6adc58416c560271166ec6bd85306d58b
|
|
Bug: 30215380
Test: Manual
PiperOrigin-RevId: 174493347
Change-Id: I06d5d3d8877ac29d148b3945e28dc0a094660eca
|
|
Bug: 30215380
Test: QueryBoldingUtilTest, QueryFilteringUtilTest, ContactFilterCursorTest
PiperOrigin-RevId: 174408771
Change-Id: I4c601b16dd90db6b7b2a05c9daa6804749ea2a43
|
|
We show OnHoldFragment for new conference call, and remove it after updating info. After cl/172475223, the update only happens once and sometimes removing the fragment happens before adding the fragment. Committing synchronously fix the bug.
Test: manual
PiperOrigin-RevId: 174374676
Change-Id: I5337f6592ca2924ed6a089ecaefe00d920f85738
|
|
|
|
|
|
* changes:
Fixed AOSP breakage due to incompatible guava api.
Implement some UI changes.
Stop ringtone when user opens "respond via message" option
Fixing bug in donation settings
|
|
* changes:
Set the ceiling at O.
Use prebuilt guava for dialer.
|
|
Currently we only show as much of the voicemail transcription, as we can see on the first line. This CL allows us to tap the voicemail, so that it is expanded and the whole transcription is now visible.
Bug: 68382421,64882313
Test: Unit Tests
PiperOrigin-RevId: 174267231
Change-Id: I19d3dea028c06d7c31aeb2949a19360eff648dcd
|
|
IsDirty is implemented by (possibly in parallel) executing all child lookups, and completing as soon as the first lookup reports itself as dirty, cancelling other lookups upon completion.
If a lookup fails for some reason, it is treated as not being dirty.
This required adding a new method DialerFutures#firstMatching.
Bug: 34672501
Test: yes
PiperOrigin-RevId: 174261470
Change-Id: Icb4f7b5d9926094fc446542411d15d02a4b873a3
|
|
Test: none
PiperOrigin-RevId: 174258291
Change-Id: Idf4eb0096fef383bd5f3544fdedba03528d14f41
|
|
Including:
- merge end call button with other buttons
- add ripple effect for buttons
- adjust elevation according to material design guide
- add triangle in expanded view
Bug: 67605985
Test: manual
PiperOrigin-RevId: 174253861
Change-Id: I7b5315245a322235efb39a9cda26b8686cc7bbf9
|
|
Ringtone should be stopped if user uses the "respond via message"
option because user already notices the incoming call and user
just feels the ringtone is noisy.
Author: Takeshi Tanigawa <takeshi.tanigawa@sonymobile.com>
Bug: 63089671
Test: AnswerFragmentTest
PiperOrigin-RevId: 174249368
Change-Id: I2c6353cd662f23c20ac3ce873c38f18e8378b0a9
|
|
in cl/173731907 we added a setting for donating voicemails, but didn't
distinguish between when this feature is enabled/disabled by the user
or by configuration. this cl fixes that by adding a method to check
if the feature is available (ie enabled by config).
Bug: 62423454
Test: manual and unit test
PiperOrigin-RevId: 174245260
Change-Id: I45a59de7f4a171d759e2fcf86db27a100a84de67
|
|
Test: no
PiperOrigin-RevId: 174239092
Change-Id: I6672c5b0a41df6426b527d1565f0cb216dc82917
|
|
We are now using guava APIs from guava 20, and AOSP guava is stuck at 18.
Test: mma
Change-Id: Ie053a5d8a30a41c7ce0deaaa01a3e17febc651cf
|
|
|
|
Bug: 68219224,65940484
Test: tap, manual
PiperOrigin-RevId: 174224721
Change-Id: Iaa48cefe94ea2e0e9209e4fe00217af4352d5ba8
|
|
* changes:
Fixed tab in packages.mk.
Adding packages.mk
Fixed that name mixed Hebrew is not displayed correctly at call log
Show dual alphabets on the dialpad if a secondary alphabet is available.
|
|
|
|
Test: none
PiperOrigin-RevId: 174217434
Change-Id: Ibaf55bdede96ecce4674186f174f61127b4c2648
|
|
Bug: 68219289
Test: none
PiperOrigin-RevId: 174216483
Change-Id: I044861a1882bcef9bb8f07b11d66053686c36b8a
|
|
The display name mixed with Hebrew and English is not displayed
correctly at call log, because the TextDirection of the display name
area is not set correctly. Fixed by correctly setting TextDirection.
Affected Area:
Direction of display name of call log list.
Bug: 68024853
Public-Origin-Change-Id: I3fb0e248d380d5431a8026b8491534b46911af99
Signed-off-by: Eric Erfanian <erfanian@google.com>
Author: yuichiro fujiwara <yuichiro.fujiwara@sony.com>
Test: manual
PiperOrigin-RevId: 174200487
Change-Id: Ib2d207ebb91a99662e4156f84c696caca82f877a
|
|
Bug: 30215380
Test: Manual
PiperOrigin-RevId: 174197504
Change-Id: Ide61f65a9dc1c104fa5bf136143c34e193c21396
|
|
The voicemail module should not contain any UI code.
Bug: 37258159
Test: DialerSettingsActivityTest,VoicemailSettingsFragmentTest. A future CL is refactoring VoicemailChangePinActivity into a fragment.
PiperOrigin-RevId: 174125949
Change-Id: I89cf6a083b0a0952332440d76e7ae0cb1c801931
|
|
|
|
This change removes restriction of showing HD icon only for some Motorola
devices.
After this change, any devices writing
android.provider.CallLog.Calls.FEATURES_HD_CALL into call logs' feature will
be able to show HD icon.
To be able to write HD features into call logs, both CarrierConfigManager#KEY_DISPLAY_HD_AUDIO_PROPERTY_BOOL and CarrierConfigManager#KEY_IDENTIFY_HIGH_DEFINITION_CALLS_IN_CALL_LOG_BOOL must be enabled.
It's part of upstream change to enable HD icon in call logs:
https://android-review.googlesource.com/#/q/topic:hd_icon_call_log
Bug: 68108125
Test: none
PiperOrigin-RevId: 174091763
Change-Id: I17c62153ebbc866c91acdaa7a7fcbd124594772b
|
|
|
|
Bug: 67605985
Test: NewBubbleIntegrationTest, NewReturnToCallControllerTest
PiperOrigin-RevId: 174089572
Change-Id: Icaeb41482cffe522e09ee1ec068b5d47f476b146
|
|
calldetails package."
|
|
|
|
|
|
* changes:
Use unencrypted storage for shared prefs in new call log.
Removed helper methods in DialerExecutors.
Add country code support to ad settings.
Add VoLTE conference call to simulator and fix a minor issue for GSM conference.
Use DialpadTextView instead of TextView to show letters under each digit key.
|
|
|
|
|
|
calldetails package.
Test: tap
PiperOrigin-RevId: 174084052
Change-Id: I10c07767392060fafed048a74df5aece4090cd68
|
|
Refresh heads up notification to show only accept and reject options when
incoming Video call is handed over to CS.
Author: Suresh Koleti <skolet@codeaurora.org>
Bug: 63157046
Test: StatusBarNotifierTest
PiperOrigin-RevId: 174077146
Change-Id: Ic74d5a201392c6764ee33f1512bf528f86b80f69
|
|
Test: Run in dialer lab
PiperOrigin-RevId: 174075702
Change-Id: Ib663dc34d2c0c9e737c6d5f13b16d2b42b714127
|
|
We need to be able to write the shared prefs when the device is in direct boot mode, and this data is not sensitive so can be unencrypted.
Bug: 68350256
Test: existing unit, manual
PiperOrigin-RevId: 174075154
Change-Id: Ib52e11c6abba0812d1dc07c642691359089c3e6e
|
|
We now use dagger everywhere for consistency and explicitness.
Test: tap
PiperOrigin-RevId: 174071122
Change-Id: I15d2f8261a7b753353be9e7d3b80692aa0c1b64d
|
|
This allows users to override our automatically selected country code.
Bug: 63994464
Test: unit tests
PiperOrigin-RevId: 174064853
Change-Id: I12bd770300b041f3c7d5b8d5f5c0b75c4945492e
|
|
Bug: 67785540
Test: On a walleye.
PiperOrigin-RevId: 174062497
Change-Id: I757b423f1c9ffe286fab15d3d8b5be8fe7c549dc
|
|
Bug: 30215380
Test: Manual
PiperOrigin-RevId: 174055180
Change-Id: Iac6deb8f9dcb6f3e9da6dfd0d732f29cc34bb7f6
|
|
Because the phone is one of the few applications that operate
when the phone is locked, disable the feature to avoid reading/writing
any encrypted preferences while the user is in the locked state.
I do not anticipate this being a necessary feature when
the device is locked.
Bug: 65399148
Test: unit test
PiperOrigin-RevId: 174044403
Change-Id: I1b9a2ac677ced2af06455a384bf169c417ffc1a5
|
|
Test: none
PiperOrigin-RevId: 174042820
Change-Id: Ia09f55d9f38b9335b23234cfe399987a3f3a65b1
|
|
|
|
Fleshed out docs for PhoneLookup.
Added dagger components and modules.
Bug: 34672501
Test: unit
PiperOrigin-RevId: 173977963
Change-Id: If07795d9d3d56a59afd27cdda3e98543bf30fdb8
|
|
fragment on app open"
|
|
* changes:
Let InCallPresenter instead of StatusBarNotifier implement AudioModeListener.
Clear cached requested video state
|
|
* changes:
internal change
Make dialpad key alignment responsive to font size.
|
|
app open
With this change we now only load the Favorites and Call Log Fragments when the
app opens.
Paging to the CallLogFragment makes the ContactsFragment load as we would want.
This should result in a faster app start time. I'll need to verify the impact
of this using the same method as http://cl/170422671
I verified the change in behavior by adding my own log line to the onCreate of each Fragment. I saw all of them get created before the change, and only the expected 2 with this change.
This change also fixes flaky test of voicemailTabVisibleNotVisible_volumeStreamCorrect.
Bug: 64541209,65460373,67297718
Test: DialtactsActivityIntegrationTest
PiperOrigin-RevId: 173734472
Change-Id: Ifd4a3064a6fdcffe5a373eaad6ee4aeebdadda1e
|
|
The bug is caused by old StatusBarNotifier object cancelling new notification. Remove listener for InCallPresenter is safer than for StatusBarNotifer.
Test: manual
PiperOrigin-RevId: 173734079
Change-Id: Iefdc2d0e399da97bf31dbd5f99beb9ed34bcd874
|
|
This CL accepts this AOSP CL: ag/64881150
Author: Ravi Paluri <rpaluri@codeaurora.org>
Bug: 64881150
Test: manual, ImsVideoTechTest
PiperOrigin-RevId: 173734014
Change-Id: Ibccc610c85c4bd06f34fc6bb057c356dd74f362d
|
|
Bug: 62423454
Test: manual and updated unit test
PiperOrigin-RevId: 173731907
Change-Id: Ic73600197b1c4fa6ac0937a8c38b048cd8faded8
|
|
In portrait mode, we surround the icon and letters with a linear layout so that we can adjust its height.
In landscape mode, we add a horizontal placeholder to each key's layout so that we can adjust its width.
This approach was put forward by Ryan Oldenburg (roldenburg@).
Bug: 30215380
Test: Manual
PiperOrigin-RevId: 173717443
Change-Id: I9b60657ca20d371a60c303a9683578663fc28a09
|
|
mode."
|
|
No changes are made to the portrait-mode UI.
Bug: 30215380
Test: Manual
PiperOrigin-RevId: 173710022
Change-Id: I9ef8a57b044e069af2eb886ea6baa30c279f4f70
|
|
* changes:
Fix HOLD option not displayed in voice calls in CDMA + GSM.
Use string concatenation for CREATE_TABLE_SQL instead of StringBuilder()
Move the functionality of DialerUtils#getDefaultSharedPreferenceForDeviceProtectedStorageContext(Context) to StorageComponent.
|
|
Add hold button for all phone types and rely on SUPPORT_HOLD capability to show it.
The issue is that if GSM call is made on devices with CDMA + GSM sim, the default phone type is CDMA so the hold button is not available. This change is a workaround that adding hold button to CDMA button chooser so button choose of all phone type has hold button available and it's totally controlled by telecom's CAPABILITY_SUPPORT_HOLD and CAPABILITY_HOLD. It shouldn't affect CDMA call.
Idealy we should use correct phone type but unfortunately it's not well supported on pre-O device.
This is upstream change from
https://android-review.googlesource.com/#/c/platform/packages/apps/Dialer/+/482377/
Bug: 63911282
Test: ButtonChooserIntegrationTest
PiperOrigin-RevId: 173614690
Change-Id: I6e17c1cc69ad50b1ba4c9b09804d5a7b5eeaf496
|
|
The current implementation is easy to read but causes klippy warnings.
Also removed the AnnotatedCallLogDatabaseHelperTest.voicemailColumnsExist and combined it with the onCreate Test
Test: Unit Test
PiperOrigin-RevId: 173614534
Change-Id: If00f7e91f48e582aa481268d88a4871cc2364684
|
|
DialerUtils#getDefaultSharedPreferenceForDeviceProtectedStorageContext(Context) to StorageComponent.
Bug: 30224215
Test: none
PiperOrigin-RevId: 173612463
Change-Id: Ia89d5d85c31ea2114b196393ae43b803023fc9bf
|
|
activity#onCreate When dialer application class got launced but GoogleDialtactsActivity was not launched, there was an unstopped timer started by dialer application, causing the measurement to be very huge next time."
|
|
|
|
When dialer application class got launced but GoogleDialtactsActivity was not launched, there was an unstopped timer started by dialer application, causing the measurement to be very huge next time.
Test: Run on devices in dialer lab.
PiperOrigin-RevId: 173570185
Change-Id: If835c7b0b7cf01b9ec3f7bc36a5104f57c697908
|