Age | Commit message (Collapse) | Author |
|
transcription is available.
Also updated the isVoicemailAvailable helper method, since just checking if the flag and OS is not enough (we have other things such as is VVM enabled, is VM activated), if we don't do this, it doesnt make sense to turn on transcription e.g Why what would happen if transcription is turned on but vvm is disabled
Bug: 74033229
Test: Added a todo, will be added later (there are a few more similar CL's that I am sending for other ToS conditions) to ensure the logic is correct for all ToS conditions first and I can add a test right at the end for all conditions.
PiperOrigin-RevId: 190696695
Change-Id: I9cb063a97e11943abeb1f823dc661efe88dfa3f1
|
|
When an existing dialer user is shown the ToS and they declines it, the transcription setting must be turned off, to respect the users wishes.
We also no longer take the user to the settings page.
Bug: 74033229,77147114
Test: Unit test
PiperOrigin-RevId: 190682249
Change-Id: I8c0abf9f3cbb15ded12a760abe540c557fd2e7d3
|
|
* changes:
Delete debugging logging statement in voicemail spam blocking
Add permission for in-call visibility change
|
|
Test: N/A
PiperOrigin-RevId: 190673495
Change-Id: I1587449f6b0b53e7a16aac0b334225649a94f27b
|
|
Bug: 76445204
Test: n/a
PiperOrigin-RevId: 190650130
Change-Id: I594a16676cfcca4e6a10c1f5bc6604509417ad23
|
|
|
|
When transcription toggle is turned off, we delete all local transcriptions. However when it is turned back on, we should re-transcribe all those( previously transcribed, then deleted) voicemails again.
Bug: 74033229
Test: N/A
PiperOrigin-RevId: 190640972
Change-Id: Iaaf324e74c7630852daeb314f34c2c3095fe3196
|
|
|
|
Adds the we can turn off transcription from settings.
Bug: 76226374
Test: N/A
PiperOrigin-RevId: 190626638
Change-Id: I22b56f133cc83749cdd52a4406be0c36c5a0d0ac
|
|
|
|
Adds the we can turn off transcription from settings.
Bug: 76226374
Test: N/A
PiperOrigin-RevId: 190623712
Change-Id: Ib2990f9ba025cc5a7f51ba7f7b7d85085327cae9
|
|
* changes:
Remove TODOs left for M in the new call log as the min SDK has been bumped to N.
Change the maximum number of notifications per tag from 10 to 8.
Replace png icon with vector drawable for voice call screen.
|
|
|
|
* changes:
Add 311910 to motorola sprint configs.
Remove obsolete methods in CompatUtils and rename it as "LocaleUtils".
Placing a call from a search action now closes the keyboard.
|
|
* changes:
Add Motorola hidden menu to all Sprint MCCMNCs
Remove obsolete version checks and compat utilities after min SDK was bumped up to N.
Bump version codes and name to v20
Catch BadParcelableException
Move spam setting related methods out of spam interface into a separate spam setting interface.
Add logging support for auto blocked spam calls.
|
|
|
|
* changes:
Forward extras from pre call external receivers to placeCall().
Bumped a few more tests to N.
|
|
* changes:
Check empty number before querying data ID for preferred account
Fix UK numbers in international format with extra 0
Cleaned up the AndroidManifest Intent Filters.
Removed NUI shortcut.
Implement wifi emergency calling warning
Fix CallLogGroupBuilderTest after min SDK was bumped up to N.
Delete locally transcribed transcripts when transcription is turned off.
Show SIM auto select reason in in call UI
|
|
* changes:
Correctly display phone numbers containing whitespaces in RTL context.
Add waiting for join banner to RTT outgoing call.
Allow user to delete previous bubbles.
|
|
* changes:
Increase minSdk to 24.
Delete old search, old contacts, p13n logger, filtered numbers add number search.
Add learn more info to VM Transcription setting
|
|
Bug: 72125574
Test: None.
PiperOrigin-RevId: 190572832
Change-Id: I581d3c9e366a1190c1608b369700aeb511fe51d1
|
|
For grouped notifications, the system UI only displays the last 8.
Bug: 74132249
Test: NotificationThrottlerTest
PiperOrigin-RevId: 190544350
Change-Id: Idc52f4e98c1262bcb16a7a5052829b0a0faaacc6
|
|
Icons in video call screen will be replaced in following change.
Bug: 76221932
Test: manual
PiperOrigin-RevId: 190534558
Change-Id: Ia8abb468c71ffa4f6322043bc3bbbbe475b20a1f
|
|
There were 2 issues at play here:
1) views not being able to leave the list view bounds
2) RemoveView not getting drag events.
Their resolutions are:
1) add a drag drop listener to the root layout of the activity, now the view
can be dragged anywhere.
2) Drag events are only sent to views that are visible, so we no longer set the
remove view visibility to GONE and instead set it's contents to GONE.
Bug: 76086197
Test: manual
PiperOrigin-RevId: 190526568
Change-Id: I3360015f65a134a896601d6298d07163844e302c
|
|
Bug: 76405608
Test: TAP
PiperOrigin-RevId: 190517564
Change-Id: If0de75264b9c604f6bdf9536997c95c3cee9e0b5
|
|
Test: Existing tests
PiperOrigin-RevId: 190516504
Change-Id: I5fa9e123b45beb9728257ecd160a348fb3f4732c
|
|
Bug: 74784637
Test: impl
PiperOrigin-RevId: 190515545
Change-Id: I70f2e6db078f3a83fc33e8493b6af143184fe736
|
|
Before this CL it is only added to 310120. The values are moved to the base values, and the overrides override the enabled flag instead.
Multiple SPN matching is also added.
Bug: 76405608
Test: TAP
PiperOrigin-RevId: 190515244
Change-Id: Ia937f0300ade57dc7a1b36df1433865ee4837a23
|
|
up to N.
Test: Existing tests
PiperOrigin-RevId: 190508397
Change-Id: Ia5f33e45af1d1cc666fec5f43efa564b2b68c193
|
|
Test: n/a
PiperOrigin-RevId: 190500474
Change-Id: I1d73a90bf37b36c454b2d72102193764f4e25013
|
|
This happens when an old dialer submitted a job and the newer dialer is trying to handle it. The class fingerprint changed so it can no longer be unparceled.
In this CL, such tasks will be dropped.
Bug: 64225192
Test: N/A
PiperOrigin-RevId: 190491751
Change-Id: I90fe2d24a435201cfae09970387e9b1c3a58b094
|
|
setting interface.
Test: All the existing tests
PiperOrigin-RevId: 190314880
Change-Id: I030acbd70120f508c5a4616757d89113524110fa
|
|
Test: N/A
PiperOrigin-RevId: 190307083
Change-Id: Ifb0ee63d8d9c7cd247f2a2d36595e48f33fa72af
|
|
Solves copy and paste error where call to setLabel and setLocation has
been mixed up. Problem was introduced in:
Ifb90019b6a5568788d51f4a55a07f7693c803eaf
Bug: 76190741
Test: Verifies that phone number is correct in callscreen when calling
contact
Cherry picked from https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/648300
Bug: 76190741
Test: N/A
PiperOrigin-RevId: 190305044
Change-Id: Ie268f02cabadc939e6a2e1f73ae4e126e314dc57
|
|
All extras that CallIntentBuilder handles will be stripped and read into the builder. Other entries will be send to telecom when the intent is build.
Renamed CallIntentBuilder.outGoingCallExtras for clarity.
Bug: 72877810
Test: Unit tests
PiperOrigin-RevId: 190301333
Change-Id: I9a8bf6664b270078d91dbfb3398f8990d243b9f8
|
|
Bug: 73902692
Test: tap
PiperOrigin-RevId: 190298092
Change-Id: Icb9f26a93b6e3c27a836442c48a9dd6f99124785
|
|
In call UI might use PreferredAccountWorker with a voicemail URI that has no numbers.
Bug: 76205637
Test: Unit tests
PiperOrigin-RevId: 190298082
Change-Id: I9949de5499958c408d6e1bf18cab6e77852d2487
|
|
See class comment on UkRegionPrefixInInternationalFormatHandler
Bug: 32501490
Test: Unit tests
PiperOrigin-RevId: 190296011
Change-Id: I6f01935f022fc288ad702735b38cb297fb9d2621
|
|
Bug: 75962274,75967273,75972847
Test: manual
PiperOrigin-RevId: 190251834
Change-Id: I3673a6b20a886ded86dc4e1a8f75a82e5e0bb199
|
|
We're not going to have a shortcut for NUI anymore. There are individual flags related to NUI that are controlled in CallLogConfig.
Other related changes to help accomplish this:
-Changed how the call log framework/config/migrator interact; the migrator is now only called on config changes and enabling/disabling of the framework now lives in CallLogFramework.
-Move CallLogConfig an interface, and moved it to its own package and added component and module. This is to simplify tests which just need to check the config status (like PhoneLookupHistoryRecorderTest).
-The "Main" package is also on longer needed since it existed to control the shortcut.
Bug: 74821995
Test: existing
PiperOrigin-RevId: 190251418
Change-Id: I73c8e83aee80295131443a8ffaa7dea716ea89b6
|
|
The warning is shown when there is no service, and the carrier requires the message to be shown because they cannot make emergency call over wifi.
Bug: 68030294
Test: Unit tests, integration tests.
PiperOrigin-RevId: 190241868
Change-Id: Ia6b838ac1e8e62ad6b40d97c1cf1a970491c1e6f
|
|
Bug: 76154272
Test: CallLogGroupBuilderTest
PiperOrigin-RevId: 190187854
Change-Id: Ib96c406c4bb0627729c24c58c526850ff4fda22f
|
|
When a user turns off transcription setting we should delete all the voicemails locally transcribed by google. We do this by deleting all the transcripts associated with the source package of the app.
Bug: 74033229,76167428
Test: Unit Test
PiperOrigin-RevId: 190159353
Change-Id: I328aece594aa0e66de59e43fa3619b5e9ae15f78
|
|
The assisted dialed string will also along show with the "calling via" label. To handle the long string, Top row is now a marquee.
Bug: 72571130
Test: Unit tests
PiperOrigin-RevId: 190156719
Change-Id: I18a13712bdc9d780f744ef65a1773d249e40fb15
|
|
Bug: 74421656
Test: DialerBidiFormatterTest
PiperOrigin-RevId: 190154072
Change-Id: Ic7cb3be702dd28b07b6e5e1e6d89f75f0bb12655
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 190126654
Change-Id: I412f8fbf5b345005f9fb3651c345303d965e4e02
|
|
After this change, user will be able to delete text in previous finished bubble. It will also correctly handle deletion from remote.
Bug: 67596257
Test: RttChatMessageTest
PiperOrigin-RevId: 190122728
Change-Id: Ifebcbe874e5f03857d109b58e758e53f408e7e44
|
|
Manually set to M
- MissedCallNotifierTest (not sure what the issue is here...)
- CallLogGroupBuilderTest (because a check was removed, some NPEs are thrown)
- MainSearchControllerTest (/system/etc/fonts.xml (No such file or directory))
Ignore Tests
- a few random ones in incallui/answer/impl/hint (shared prefs aren't working for some reason)
- VisualVoicemailUpdateTaskTest (disabled the whole test, issue unclear)
Bug: 73902692
Test: tap
PiperOrigin-RevId: 190030202
Change-Id: I1e9b61d758a61582c5a183ee884dd2181d1c10de
|
|
search.
These components are safe to delete because:
- New Contacts has been in prod for several releases.
- New Search has been in in prod for 2 releases.
- p13n logger was based on old search and is no longer being implemented in
Dialer.
- Filtered Number Settings contact search since we no longer support M.
Bug: 37208802,73902692
Test: tap
PiperOrigin-RevId: 189992017
Change-Id: I2720a252ababd164b5d0fb1011753a3c96a704d1
|
|
Updates the transcription setting from using a switch preference to a SwitchPreferenceWithClickableSummary. This allows the voicemail transcription setting preferences summary to be clicked and opened to the specified learn more url.
Bug: 74033229
Test: Unit Tests
PiperOrigin-RevId: 189983125
Change-Id: I1b162f3e2e582243fe8f84633e9401155170194c
|
|
different dialer variants."
|
|
dialer variants.
Bug: 35612086
Test: Test included
PiperOrigin-RevId: 189981890
Change-Id: Ife99969189d5d37bb1ad8ba61361a51e78abdfbb
|
|
* changes:
Use SwitchPreferenceWithClickableSummary instead of SwitchPreference for VM Donation
Removed appContext from CallLogDataSource and PhoneLookup.
|
|
|
|
|
|
Donation
The learn more link needs to be in the summary of the switch preference, however having a hyperlink in the summary text view of a switch preference does not open the hyperlink. To do this we made our custom switch preference which allows the summary to be clicked. All other aspects of the switch preference remain the same.
Bug: 74033229
Test: Unit test
PiperOrigin-RevId: 189978676
Change-Id: I31e744f3545e576ee3f5ac4a8fee249e22835e19
|
|
Impls can access appContext via dagger.
Test: existing
PiperOrigin-RevId: 189974157
Change-Id: Ie64d2c6f9ba08fc914d3c31f7e014c2beef3ab00
|
|
When a user enters the voicemail settings page and the voicemail is still being activated, we need to show the "Activating...." string to tell the user that something is still happening. This is important since unless the activation has happened, other settings are not visible e.g transcription and donation
Bug: 76107888
Test: N/A
PiperOrigin-RevId: 189970472
Change-Id: Ib9eeee64cd67c2adc4830a743516851ffa637fbf
|
|
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189969399
Change-Id: I8e287cc7884dde7640721bd385fe383a4635f3c8
|
|
|
|
|
|
This CL updates the call log to show "Emergency number" for call log rows from
numbers that PhoneNumberUtils.isEmergencyNumber considers to be emergency
numbers.
Bug: 66926712
Test: Manual, see above
PiperOrigin-RevId: 189953302
Change-Id: Ibaae243ead8b918a26f6058164316e042a4f82fd
|
|
If we get no location data for emergency call, we used to show spinner forever. This change shows error after 5s with no data, but still tries to get location.
Test: LocationFragmentTest
PiperOrigin-RevId: 189946803
Change-Id: Iaa0b429eec806337b9ab9cae3ca95e737fc667bf
|
|
"dialer/widget"."
|
|
Bug: 74421656
Test: Existing tests
PiperOrigin-RevId: 189935875
Change-Id: I834e15b7ff102ea021d7a99ebe568998a9c43603
|
|
|
|
Bug: 73774242
Test: unit tests where they exist
PiperOrigin-RevId: 189853302
Change-Id: Ibf3431cc0d7716c2c53c7ea165dfc130102a1bc7
|
|
|
|
This is necessary to disable the call log framework via flags.
This isn't yet called anywhere.
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189838957
Change-Id: I926c02c41151528eabc208c874acbfe7897a2f93
|
|
|
|
Bug: 72162360
Test: SpecialCharSequenceMgrTest, TranssionUtilsTest
PiperOrigin-RevId: 189825957
Change-Id: Ia161ad47c4122d33c108b545540707bb18076464
|
|
|
|
There is still some jank on first open, but it's much less janky
on close and consecutive open calls.
Test: existing tests confirm no regressions
PiperOrigin-RevId: 189802733
Change-Id: I49d6c2def7c33be0fdbb79c89772a5e4513cde3b
|
|
|
|
|
|
In order to correctly show animation, we have to ensure:
1. fab.scaleIn() is not called before dialpad is slide up.
2. fab is invisible before scaleIn is called.
Caveat:
This change is not tested on old UI (DialtactsActivity) since it's deprecated.
Test: manual
PiperOrigin-RevId: 189765153
Change-Id: Iada96b2789f96ca1612ae2048020a649f8b57b6b
|
|
This is needed to support flag changes which should cause the call log framework to become disabled.
It's not called anywhere yet.
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189761665
Change-Id: I914c690448f03ebacd7d05c9ad082aba7bf1a4ce
|
|
|
|
|
|
Test: Existing tests
PiperOrigin-RevId: 189683790
Change-Id: I0209e7fa839175041da29e9a6d8a590133121376
|
|
Test: Existing tests
PiperOrigin-RevId: 189678764
Change-Id: I6b9edd99e727788c65d325c1be43f0190c25c30e
|
|
* changes:
Convert @AutoValue CoalescedRow to a proto
Show spam blocking promo after block spam dialog
|
|
|
|
|
|
Test: Existing tests
PiperOrigin-RevId: 189675976
Change-Id: Ieae92b5ac2aefd3f0397bbb07ebb1c97bd72ed42
|
|
Test: SpamBlockingPromoHelperTest
PiperOrigin-RevId: 189674918
Change-Id: I0b22eb9b8128125cc5b439674099820a01c3889f
|
|
NUI dialpad is still broken.
Test: Unit tests
PiperOrigin-RevId: 189674304
Change-Id: I58d114ed45839f8ff85a3a0e48c3d200337915c9
|
|
Test: InAppSpamTest
PiperOrigin-RevId: 189670786
Change-Id: Ie7bf394ecc02ac647211f7375faaf3e1b48ad7dd
|
|
|
|
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189670163
Change-Id: Ifdfcab7dc4493cbe688ef77d43df7e7a1400fa27
|
|
|
|
|
|
|
|
|
|
This data source determines if the call is to the voicemail inbox.
isVoicemail() is removed from NumberAttributes and PhoneLookup. It is yet decided how in call UI should handle voicemail calls in the future.
TAG_CHANGE_OK=proto not in prod yet. Please clear app data.
TYPE_CHANGE_OK=above
Bug: 70989587
Test: Unit tests
PiperOrigin-RevId: 189650273
Change-Id: Iafebf1abb18c74301b62a72d1d04deecd6d78d29
|
|
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189648655
Change-Id: I9918bd6f35bf7eb1bebb9862c2d78880457efa91
|
|
A phone account can be removed after calling getCallCapablePhoneAccounts(), so subsequent getPhoneAccount() can be null.
Other usages already has the null check.
Bug: 75598828
Test: N/A testing this involves getPhoneAccount() returning null on the nth call, which requires replacing the shadows with a mock and is highly coupled with the implementation. The is an edge case and is not worth the effort and brittleness it will cause.
PiperOrigin-RevId: 189644833
Change-Id: Ie92dda2537befb5936ad734954b4eaf75964f465
|
|
A phone account can be removed after calling getCallCapablePhoneAccounts(), so subsequent getPhoneAccount() can be null.
Bug: 75598828
Test: In a follow up CL, where all instance of these will be fixed.
PiperOrigin-RevId: 189635573
Change-Id: I897db6e8e7706bc8afe6f25d89fd2ca4405900df
|
|
|
|
Repro steps:
1. open dialer, click on FAB to open dialpad
2. make outgoing call, end call, press home
3. enable WiFi call
4. open dialer again, click on FAB to open dialpad
This is caused by change icon called after the FAB is visible and scaleIn won't do anything since it's already visible. But for some reason the icon is changed so nothing is drawn on the screen when the dialpad slide up. (dialpadfragment is visible even before it's slide up before user trigger it)
The fix is to scaleOut the FAB when the fragment onStop thus the changed icon will be correctly drawn.
Bug: 74586190
Test: manual
PiperOrigin-RevId: 189629441
Change-Id: I3dcbedcd171c992e5df14bff35758fce1bb67bc1
|