summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-04-23Use TelecomManager.placeCall APIYorke Lee
Bug: 20348183 Change-Id: If1b193f933b4a7b2b322784b0cbbc66c210b25df
2015-04-22Import translations. DO NOT MERGEGeoff Mendal
Change-Id: Idf60c6913e7696b9c19f0f12328cdc66ba3c0687 Auto-generated-cl: translation import
2015-04-21Merge "CallLogAdapter cleanup and refactoring."Tyler Gunn
2015-04-21Merge "Add resources to recyclerview dependency."Deepanshu Gupta
2015-04-21CallLogAdapter cleanup and refactoring.Tyler Gunn
- Some minor cleanup and refactoring. Bug: 20393675 Change-Id: I438a9ca222cac87c9323417a216453706393c190
2015-04-20Make sure to correctly remove onPreDrawListenerYorke Lee
Bug: 20421404 Change-Id: Icc8b4a74ea17e969577dbaaa794b85a2e66ef8df
2015-04-20Merge "Use UserManager.isSystemUser API"Yorke Lee
2015-04-20Import translations. DO NOT MERGEGeoff Mendal
Change-Id: I628c0ad59f8b8cd044cbe605f66c928770b01202 Auto-generated-cl: translation import
2015-04-18Use UserManager.isSystemUser APIYorke Lee
Bug: 20348316 Change-Id: I066e6b93c63e09850ef2234dd5c724e44594aaf8
2015-04-16Add resources to recyclerview dependency.Deepanshu Gupta
Change-Id: I8c93f4e770705bf59c43b2b135145ac0c17dcf0c
2015-04-16Remove use of private isResumed APIYorke Lee
Change-Id: I3ad2277b4822d219bd53b35914befb4a4d52b45b
2015-04-16Merge "Change hasVoicemailNumber to getVoicemailNumber"Yorke Lee
2015-04-16Move call log actions into expandable view.Andrew Lee
This isn't the prettiest thing ever, but with this the "framework" of all of the changes for the new visual style of the call logs is in place. From here on out, the remainder of tasks should be unblocked and relatively independent. + Rename ...ItemViews to ...ItemViewHolder. This probably wasn't completely necessary, but is more proper given the new architecture. + ViewHolder is now officially where most of the independent UI logic for a single call log list item should live. This changelist moves further in that direction by storing references and helpers in it, to lessen what must be passed in from the adapter. + Split out the call action from the rest of the actions, since it has a special treatment on the card. + Convert text action buttons into a vertical stack. + Consolidate action stylings into a single style, for simplicity. + Miscellaneous style and string changes to put things in a better state. This included tweaking some of the (ripple) backgrounds. + Update tests, according to changes. Bug: 19372817 Change-Id: Ic923c0bcbbc1c153952131d0c772df9e9589fb03
2015-04-16Change hasVoicemailNumber to getVoicemailNumberYorke Lee
Bug: 20223485 Change-Id: Iaa8f140746d1266febfcacf0f007ef2b4ebba968
2015-04-15Merge "Use TelecommManager.getDefaultOutgoingPhoneAccount"Yorke Lee
2015-04-15Use TelecommManager.getDefaultOutgoingPhoneAccountYorke Lee
Bug: 20224972 Change-Id: If7f1bde0229044f60bc889b380bc3e49e043e3ff
2015-04-14Follow TelecomManager API changesYorke Lee
Bug: 20160799 Change-Id: I667fb47cf261703af817a6a16405bcf56f2bf0f7
2015-04-13Make call log cards white.Andrew Lee
Disassociate the color of the cards/list items from the background color. Before, they were connected so they were ending up as the same color. Bug: 19372817 Change-Id: Id31891a0f86f98bd6143911e361abc70435abddf
2015-04-12Merge "Merge commit 'd3ffa4914baebe668d540fc966efddd0c89a92a2' into merge_work"Prerepa Viswanadham
2015-04-10Cardify the call log list items!Andrew Lee
+ Added card view dependencies to makefile. + Convert call log list items to use card views. + Cleaned up code style and unused views in fragment xml. - Removed deprecated expand code (more work to be done here). - Removed now-unused constants. Bug: 19372817 Change-Id: I237cf214f8f052de5fb1f41908d6012f52de994e
2015-04-10Merge commit 'd3ffa4914baebe668d540fc966efddd0c89a92a2' into merge_workPrerepa Viswanadham
Change-Id: I79fa0e84dc5ba0f2f9282cd4b209c2022d740b8d
2015-04-10Merge "Replace ListView with RecyclerView in call log."Andrew Lee
2015-04-09Replace ListView with RecyclerView in call log.Andrew Lee
Yay, finally! + Replace ListView with RecyclerView in layout and fragment files. + Change GroupingListAdapter to extend RecyclerView.Adapter instead of BaseAdapter. + Change CallLogListItemViews to extend RecyclerView.ViewHolder. + Adapt onBindViewHolder and onCreateViewHolder methods in the CallLogAdapter. + Update/rework tests for related classes. + Fix a bug in the GroupingListAdapter, where childCount was not updated for standalone views, and the previously cached group size was used instead. Set childCount to 1 for standalone views. - Removed the idea of creating different views for standalone vs group vs group headers from the adapters. This logic has not been used for quite some time and all these functions funneled into createView/bindView methods anyways, so there is no logical difference. If we need to create custom views in the future, we can leverage onCreateViewHolder's viewType parameter. Bug: 19372817 Change-Id: I1b7289340600609669db22d8bc89265240d0b561
2015-04-09Merge "Remove deprecated API use"Jay Shrauner
2015-04-09Merge "Switch to new SelectPhoneAccountDialogFragment API"Jay Shrauner
2015-04-09Remove deprecated API useJay Shrauner
Switch to getPhoneTtsSpannable Bug: Change-Id: I1024aea2a766f6ac284bc5207c0e32c29c0cb72f
2015-04-09Move some CallLog testing from adapter to fragment.Andrew Lee
- Remove custom testing method formerly in the adapter. - Remove unused expand animate code. Bug: 19372817 Change-Id: I78489d63ac9c3324cd80f8039d14a41813772e11
2015-04-08Remove footer view.Andrew Lee
This depends on ListView footer functions, but the Call Log is being migrated to the RecyclerView. This view will be added back later, with that work tracked in b/20108202 in scope of M. Bug: 20108202 Bug: 19372817 Change-Id: I55201e068362083bf5c18ebd08c2e57c97c1b827
2015-04-08Merge "Remove expand/collapse animations in the Call Log."Andrew Lee
2015-04-07Separate empty view logic from ListView.Andrew Lee
Don't rely on setting the empty list on the ListView for controlling visibility of the list view and empty view. Save the reference and control this in the call log fragment. This removes a dependency on ListView-specific functionality which is not found in the RecyclerView. Bug: 19372817 Change-Id: I0a7e2e2366e258013ddbe30bd2ee7efb38349421
2015-04-07Merge "Move copy of GroupingListAdapter to Dialer app."Andrew Lee
2015-04-07Move copy of GroupingListAdapter to Dialer app.Andrew Lee
+ Copied in from com.android.common.widget. This component is pretty specific to phone number / call log grouping anyways. + Changed CallLogAdapter to reference this GroupingListAdapter instead of the one in the framework library. + Changed CallLogGroupBuilder to reference this adapter too. + Copy in tests too. Next step: change GroupingListAdapter to extend RecyclerView.Adapter. This will preserve existing grouping logic, despite switching to the new view. Bug: 19372817 Change-Id: Ic0186ca5fad06a3ae398b9d8f8006210077149dc
2015-04-07Add dependencies for RecyclerView.Andrew Lee
And, sort dependencies to make them more organized. These dependencies aren't used yet, but will be shortly by using a RecyclerView for the call log. Bug: 19372817 Change-Id: Ie10077fc10a849bee7573c451c779705ac5cdccb
2015-04-06Remove expand/collapse animations in the Call Log.Andrew Lee
- Remove animation logic in CallLogFragment. - Remove expand listener from CallLogAdapter. + Update tests and constructor. This preemptively removes expand/collapse behavior. While this will result in a janky short-term experience, this is an incremental step in shifting to RecyclerView and the new "Card" UI. I figured it would be most efficient to delete it straight up, rather than coding in intermediate logic to work with the RecyclerView because it will be made obsolete by the Cards UI anyways. In the long run, expand/collapse animation behavior will be restored once the call log is migrated to RecyclerView and converted to Cards. Bug: 19372817 Change-Id: Icbdc7dcb9f2f2223456c29334c826d38917b087a
2015-04-06Merge "Don't track ReportDialog state in CallLogFragment."Andrew Lee
2015-04-06Switch to new SelectPhoneAccountDialogFragment APIJay Shrauner
Bug:20064573 Change-Id: If528b7a06a9e5d1452cfbd99c6e11d7ce390038c
2015-04-06Merge "Create ContactInfoCache from CallLogAdapter."Andrew Lee
2015-04-03Don't track ReportDialog state in CallLogFragment.Andrew Lee
This was implemented formerly to prevent a crash on rotation, but this can be done by specifying that the Report fragment should be retained in GoogleDialer. This means that the fragment will not be retained now if the activity is killed off by the system, but I think this should be okay since it is a dialog. Bug: 19949319 Change-Id: If3ebca4625fce93d9d9ce3c9bde6d92729f21c40
2015-04-03Merge "Use hardware layer for SearchFragment fade in"Yorke Lee
2015-04-03Cannot direct dial or video call from Dialer search results.Tyler Gunn
- Change made in partner CL introduced a regression in dialing from the search results: https://partner-android-review.googlesource.com/#/c/206297/ The problem with that change is that it was intended to ensure that the + was not stripped off when dialing from the dial pad. It had the unintential impact of rendering direct dial from the search box inoperative. since mAddToContactNumber was null in this case. Bug: 20068746 Change-Id: Ic3a75ccf00164e7c865cc633a6a16d1699227ed2
2015-04-03Create ContactInfoCache from CallLogAdapter.Andrew Lee
This pulls code from the CallLogAdapter, with only tweaks to variable names and comments, to create a ContactInfoCache responsible for logic pertaining to looking up and caching contact info. The logic is intended to be unchanged for now, although in the future it can/should probably be cleaned up sometime. Bug: 20038300 Change-Id: I60a57b0a665496522a6b51c9e6e41a4fd6dbad1f
2015-04-03Merge "Declare that Dialer does not use cleartext network traffic."Alex Klyubin
2015-04-03Use hardware layer for SearchFragment fade inYorke Lee
This greatly improves the dialpad slidein animation on low end devices. Bug: 20055089 Change-Id: I17e04eeaad48b8d2245ef6d9ce5fef623588cccc
2015-04-03Merge "Stop using static common test lib. Fix Jack build"Brian Attwell
2015-04-02Merge "Move ContactInfo request classes to package."Andrew Lee
2015-04-02Declare that Dialer does not use cleartext network traffic.Alex Klyubin
This declares to the platform and tools that this app does not use cleartext network traffic. The platform and tools will be blocking (on best effort basis) attempts to use such traffic by this app. For example, attempts to use HTTP (rather than HTTPS) will be blocked. Bug: 19215516 Change-Id: I33d78928e2b2ff96112a5ba694615ff6c31164a6
2015-04-01Move ContactInfo request classes to package.Andrew Lee
Once a ContactInfoCache is implemented, these will be changed to have package visibility. This is an incremental step of breaking out and moving these classes to a "contactinfo" package. The next CL will actually implement the Cache and have more churn in terms of logic, while this is more straightforward. Bug: 20038300 Change-Id: Ie6082b2eeab52e25f861f2459517fff057370f82
2015-04-01Move ContactInfo database methods into helper.Andrew Lee
Bug: 20038300 Change-Id: Id1636fdf6a1b15ac0c570f484e6f0c05985027e8
2015-04-01Stop using static common test lib. Fix Jack buildBrian Attwell
This is an exact copy of ag/655143. Bug: 19667686 Change-Id: I36d5e3e91b0e58e0fc4ecb4a3068c994f9b90111
2015-04-01Move setPhoto logic to CallLogListItemViews.Andrew Lee
Bug: 19372817 Change-Id: Icddc1edd2ca1ad040a03726471a19ddc9d434d4d
2015-03-31Move view expand logic to CallLogListItemViews.Andrew Lee
Bug: 19372817 Change-Id: I92d9f001155d4a059c89bc4b00abcef4e817f32d
2015-03-31Don't return contacts photo manager as a service.Andrew Lee
It will initialize itself if it does not exist, instead of relying on getting a system service as the mechanism for initialization. Bug: 19372817 Change-Id: Iae3eff986a79730bb2a8da9dcd4f28f664719673
2015-03-27Import translations. DO NOT MERGEGeoff Mendal
Change-Id: Iee6330e8d314a72d5f5e0258eb134a20e19c930d Auto-generated-cl: translation import
2015-03-27Merge "Move view-specific logic to ViewHolders."Andrew Lee
2015-03-27Move view-specific logic to ViewHolders.Andrew Lee
There's a lot of logic around inflating/initializing which lives in the adapter, but only really applies to the views. Move this into the View Holder for now. This may not be its final resting place, but in any case this seems like it can be extracted from the adapter. Bug: 19372817 Change-Id: Ib3436ad4d8e666a8df8cb2f894e71b321ecb68da
2015-03-27Merge "Move Report-Bad-Data toast to GoogleDialer."Andrew Lee
2015-03-26Remove unused getBetterNumberFromContacts method.Andrew Lee
I don't think this method has been used for quite some time, and am uncertain what it was used for originally. Bug: 19372817 Change-Id: I6abc7cb2699306706dd790247a038d94ed7d1583
2015-03-26Move Report-Bad-Data toast to GoogleDialer.Andrew Lee
Bug: 19949319 Change-Id: I32a2217a24915a7d862a1c9d521fc0c45f0ecb68
2015-03-26Merge "Fix image-related GoogleDialer compiler warnings."Andrew Lee
2015-03-26Merge "Remove more strings without default translation."Andrew Lee
2015-03-26Merge "Add logging of shortcut types on click."Andrew Lee
2015-03-26Merge "Make menu options protected instead of private."Andrew Lee
2015-03-25Fix image-related GoogleDialer compiler warnings.Andrew Lee
Fix warnings of form: "libpng warning: iCCP: Not recognizing known sRGB profile that has been edited". Most of these were swaped by replacing the old assets with newer or equivalent versions. Bug: 19536005 Change-Id: I0535c0876806607f4aa170a5839829fff367ab9a
2015-03-25Remove more strings without default translation.Andrew Lee
Bug: 19536005 Change-Id: Idf1252288ccbf044f84981a7ba813ab9b337a0cd
2015-03-25Add logging of shortcut types on click.Andrew Lee
Log more info, to help with debugging misbehaving shortcuts. Bug: 19406317 Change-Id: Ia1dd8e51f7129a142d23867179fd1db7ca86c865
2015-03-25Make menu options protected instead of private.Andrew Lee
Thsi allows Google Dialer to add a feedback option and handle its behavior accordingly. Bug: 19254693 Change-Id: I64ab34049406d10f53504af8d5eda9ac29758ef8
2015-03-25Merge "Fix NPE in device ID dialog."Nancy Chen
2015-03-25Import translations. DO NOT MERGEGeoff Mendal
Change-Id: I7c7264cf828fed07093ac6d7dbfab95d4dad134b Auto-generated-cl: translation import
2015-03-24Fix the dial string to include the + sign added by user for VT callGarik Badalyan
- The smart dial search normalizes the dial string and removes anything other than digits - Add a fix to add the + sign back to the normalized string if original typed number had a + sign - Add a check for prohibited numbers before making a call and display an error dialog Change-Id: Ib36462be573ce4fecc8821980226ae2920041cd2
2015-03-23Merge "Remove search shortcut background drawable."Andrew Lee
2015-03-23Merge "Notify adapter of data set change onResume."Andrew Lee
2015-03-23Fix NPE in device ID dialog.Nancy Chen
Do not add null strings to list of device ids when responding to MMI code for device ids (IMEI/MEID). Also fix string resource that is not available in AOSP. Bug: 19897433 Change-Id: Ie06bb793eafa66f451bf1843d2a5ad4d343999d2
2015-03-23Merge "Add CACHED_PHOTO_URI to test values"Yorke Lee
2015-03-23Merge "Fix NPE in call detail activity for voicemails."Nancy Chen
2015-03-23Fix NPE in call detail activity for voicemails.Nancy Chen
Because the call detail activity is being used for playing voicemails, this happens when playing voicemails but not looking at more details for a non-voicemail call because the "details" option is not available for non-voicemail entries. If the voicemail comes from an unknown number, the activity attempts to get the number and convert it to a string for use in intents within the call details activity, but since the number does not exist, the app crashes instead. Bug: 19627341 Change-Id: I5302527c1c51c620a66ead85984b2e2399839086
2015-03-23Import translations. DO NOT MERGEGeoff Mendal
Change-Id: I944c15eb524cc5264ae4b451a832b9cb201471c8 Auto-generated-cl: translation import
2015-03-20Import translations. DO NOT MERGEGeoff Mendal
Change-Id: If2eeee5d4f1b125671567ca32ff4dc2d85dcb88c Auto-generated-cl: translation import
2015-03-20Remove search shortcut background drawable.Andrew Lee
Bug: 19372539 Change-Id: I84055e620335483027a70c3693d06e9f83d4570a
2015-03-20Notify adapter of data set change onResume.Andrew Lee
Even if we don't need to reload the data, refresh the list view with the data we currently have. We display the call log times using text descriptions relative to the present. This refresh updates those descriptions. Bug: 19653523 Change-Id: Ib5bc79d52946baabac86c2b9459ab66901d5615b
2015-03-20Update smart dial results after adding contact.Andrew Lee
+ Add a URI for smart dial database updates, and notify this URI with the content resolver after finishing an update. + Add a content observer to the SmartDialCursorLoader, to force a reload of its contents when notified. Bug: 19372539 Change-Id: I963d0d0fcb519e672f580ea8d33dc80d0c3f7799
2015-03-20Add CACHED_PHOTO_URI to test valuesYorke Lee
Change-Id: I4cbc6d79985680b4b5fc6e807fb30908352900b5
2015-03-20Merge "Cleanup logic for showing/hiding shortcuts."Andrew Lee
2015-03-19Cleanup logic for showing/hiding shortcuts.Andrew Lee
+ Update SEND_SMS in the regular search list adapter. Before, it was showing up all the time, even when it wasn't supposed to. + Hide CREATE and ADD in the regular search list adapter. + Move disabling of DIRECT_CALL to the smart dial adapter. It's only used by the single fragment right now, so centralizes the enabling of the shortcuts. Bug: 19372539 Change-Id: Iea9108e83f15026d86400a5d1e63d5c011b2770a
2015-03-19Remove extra options from dialpad menu.Andrew Lee
These are now exposed as shortcuts in the search fragment. Bug: 19372539 Change-Id: I526570cf8326dbfac1770c0f3c06b72ee1166cc8
2015-03-19Add shortcut for creating new contact with number.Andrew Lee
Add a shortcut in the search fragment for "Create new contact" which opens the compact editor with the entered phone number populated as the main phone number. Bug: 19372539 Change-Id: I9ccb462f399e3fab77c2d8ad536dbd0bd0e23609
2015-03-19Merge "Change add contact shortcut to be for "existing"."Andrew Lee
2015-03-18Change add contact shortcut to be for "existing".Andrew Lee
We're going to "fork" the add action into "existing" and "new". This converts the existing shortcut action to the scenario for adding to an existing contact, and the action for adding to a new contact will be added as a follow up. Bug: 19372539 Change-Id: I9e78fa5637a6f0ff22ce1d74bca3fe98e531242f
2015-03-18Merge "Delete unused images and drawables."Andrew Lee
2015-03-18Merge "Add "Send SMS" shortcut to Dialer."Andrew Lee
2015-03-18Add "Send SMS" shortcut to Dialer.Andrew Lee
Bug: 19372539 Change-Id: I8135a7e6fb7d5becdafcb0ecfb64d6f6c73aeb88
2015-03-18Delete unused images and drawables.Andrew Lee
Bug: 19536005 Change-Id: I326986d079b1980429d89379a147c3fbd441b203
2015-03-18Merge "Clean up extra helper methods."Andrew Lee
2015-03-18Clean up extra helper methods.Andrew Lee
To assists with readability, clean up call log fragment by calling the contents of the helper methods directly, to remove extra level of indirection created by the helpers. In most cases, these helpers were one-offs, or were direct calls to another helper method. Bug: 19372817 Change-Id: I96d96bee6b300a26987513d50115de0c4cd522c1
2015-03-18Merge "Move add contact intent creation to IntentProvider."Andrew Lee
2015-03-18Import translations. DO NOT MERGEGeoff Mendal
Change-Id: I555f4afe52b63b5a481f89c8ffafc8e77d670255 Auto-generated-cl: translation import
2015-03-17Merge "Hide accessibility settings if none."Andrew Lee
2015-03-17Merge "Do not cache non-contacts URI in calllog provider. (2/2)"Makoto Onuki
2015-03-16Move add contact intent creation to IntentProvider.Andrew Lee
This is the more established pattern for creating intents to be used by call log list item actions. Bug: 19372817 Change-Id: I62cf5170cf51c4fbec8d1d9910b3fa3380a3dc3e
2015-03-16Merge "Delete call log list item extras."Andrew Lee
2015-03-16Delete call log list item extras.Andrew Lee
- Remove isCallLog specific code from adapter; now everything will always be in the call log. - Remove unneeded adapter bits from ListsFragment; there is now no shortcut card shown in the lists fragment. - Remove call log list item extra. We won't bind badges using this any more. This will be superseded by the actions. Remove badge-related code in CallLogAdapter. + Leaving the add-person icon, since it will be used in the future. Bug: 19372817 Bug: 19627987 Change-Id: I4db8149761b017e02e89c081930a05f3aafe9606