summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-12-07Added PhoneLookupHistoryRecorder.zachh
When a call is added in InCallUi, it fetches the current PhoneLookupInfo for the call and writes it to PhoneLookupHistory. Required updating PhoneLookupHistoryContentProvider#update to use "replace" to (presumably) atomically insert when a row is missing. Bug: 34672501 Test: unit PiperOrigin-RevId: 177896892 Change-Id: I43f9ded240a81156722be816a9635d586de642a1
2017-12-07Added PhoneLookupSelector.zachh
This class is responsible for prioritizing and selecting data from a PhoneLookupInfo object, which contains information from many phone lookup sources. Bug: 34672501 Test: unit PiperOrigin-RevId: 177893924 Change-Id: Ib98a4656fe87141162a7ac53af4a0ad421196046
2017-12-07Removed timestamps from PhoneLookup APIs.zachh
Also added onSuccessfulBulkUpdate method. It is safer for each PhoneLookup to keep track of its own last processed time via shared prefs where the value saved is the actual last processed timestamp from the underlying data. This is because it is difficult or impossible to select a single time that spans lookups due to queries being run and processed at different times. The onSuccessfulBulkUpdate method is provided as a hook for PhoneLookups to persist their shared pref once they know the result of bulkUpdate have been successfully saved. Finally, removed usage of the lastModified timestamp from PhoneLookupHistory in PhoneLookupDataSource since I believe the cases it was originally intended to cover are now handled by populateInserts(). Bug: 34672501 Test: unit PiperOrigin-RevId: 177891586 Change-Id: I072409fc217e4d7e36816548862e8b358aebf165
2017-12-05Merge "Add filtration logic to Assisted Dialing Settings."erfanian
am: 7370d93ade Change-Id: I6990c2449d6bef4621014dd6d7fe8f49b45c4fe2
2017-12-05Merge "Add filtration logic to Assisted Dialing Settings."Treehugger Robot
2017-12-04Add filtration logic to Assisted Dialing Settings.erfanian
The filtration logic will only show countries in the country picker if the feature is enabled for those countries. This will not cover the regressive case where a user has already selected a default option, but then the option is later removed. This behavior is currently undefined. Bug: 69274259 Test: unit tests PiperOrigin-RevId: 177881199 Change-Id: I113f6d25249c42c1bd98383fd6ee0bc6a8c0e615
2017-12-04Merge changes Iac15302a,I228ce134yueg
am: 9ffe71da47 Change-Id: I350b28a94971f1169fb70373b1d1a6ecf37e8ae4
2017-12-04Merge changes Iac15302a,I228ce134Treehugger Robot
* changes: Rollback the broadcast in-call UI changes since it breaks AOSP. Rollback the rollback of broadcast in-call UI changes.
2017-12-01Rollback the broadcast in-call UI changes since it breaks AOSP.yueg
Test: none PiperOrigin-RevId: 177596967 Change-Id: Iac15302aca9593bfd4d1cbe5a8336ed6fd71b21c
2017-12-01Rollback the rollback of broadcast in-call UI changes.yueg
Test: none PiperOrigin-RevId: 177530923 Change-Id: I228ce134b49065bd137296f5ab99375bac9e9fa3
2017-12-01Merge changes If9478ce2,I41d4910bcalderwoodra
am: 9acd105472 Change-Id: I2a7baeace7ad935ae8294345e829acc9ff7e271f
2017-12-01Merge changes If9478ce2,I41d4910bTreehugger Robot
* changes: Implemented new favorites list UI. Action bar is no longer visible in dialpad search after configuartion change.
2017-11-30Implemented new favorites list UI.calderwoodra
Bug: 36841782 Test: implemented PiperOrigin-RevId: 177516412 Change-Id: If9478ce22c10fd17e352d5fdcc2c0bef5e14a6d8
2017-11-30Action bar is no longer visible in dialpad search after configuartion change.calderwoodra
If a user, for example, opened dialpad search then entered multiwindow mode, the actionbar would be visible and search results maligned. This change corrects that by updating it's state once possible. Test: manual PiperOrigin-RevId: 177497979 Change-Id: I41d4910b5bb92e29623960e7d4741a9a961e5b9e
2017-12-01Merge changes Ide2ea08f,I24186745yueg
am: 9db815f051 Change-Id: I8fdf785b6ac3c16b2d9ecabdbdcc3a7131124c10
2017-12-01Merge changes Ide2ea08f,I24186745Treehugger Robot
* changes: Rollback Broadcast in-call UI changes. Fix NPE crash on video call.
2017-11-30Rollback Broadcast in-call UI changes.yueg
Test: none PiperOrigin-RevId: 177490090 Change-Id: Ide2ea08f89b8a8072913617e6ce4587abffc7df4
2017-11-30Fix NPE crash on video call.wangqi
Bug: 69960961 Test: manual PiperOrigin-RevId: 177486235 Change-Id: I241867456830e0a8479ed0652aac71abc77c86e3
2017-11-30Merge "*** Reason for rollback ***"roldenburg
am: 1d18e69c85 Change-Id: I19766bea103778f6502c3176d5460bd3ffa61eda
2017-11-30Merge "*** Reason for rollback ***"Treehugger Robot
2017-11-30*** Reason for rollback ***roldenburg
Copybara is fixed for AOSP export Bug: 68665330 Test: rollback PiperOrigin-RevId: 177480870 Change-Id: I0ba38e213bb840436fa6dafc4af0a79019ee93f4
2017-11-30Merge changes Ifcd52b16,I025ea703zachh
am: 49842c4701 Change-Id: Ic0677c87716d8f4fbac9b2d3b6f010a153179870
2017-11-30Merge changes Ifcd52b16,I025ea703Treehugger Robot
* changes: Implemented fill for PhoneLookupDataSource. Search contacts now update when there are changes to the cp2 db.
2017-11-29Implemented fill for PhoneLookupDataSource.zachh
Rewrote FakePhoneLookup to be more realistic. Bug: 34672501 Test: unit PiperOrigin-RevId: 177376374 Change-Id: Ifcd52b16b7046f39d1bfc0e8b8e76452a9daadd2
2017-11-29Search contacts now update when there are changes to the cp2 db.calderwoodra
Since we close the original cursor we queried in the cursor loader, we need to assign a new content observer to the cursor we build so that our search results update when there are changes to the contacts db. Bug: 63830179 Test: manual PiperOrigin-RevId: 177368459 Change-Id: I025ea70334265cb2fdc651ed7ea046b039738e94
2017-11-30Merge changes Id7954667,I22de38dcerfanian
am: b1e7530af2 Change-Id: I3812e62448d4851afcea7d35842c27dd28b00b0c
2017-11-30Merge changes Id7954667,I22de38dcTreehugger Robot
* changes: Bump API ceiling for Assisted Dialing. Add flag to control default assisted dialing state during precall flow.
2017-11-29Bump API ceiling for Assisted Dialing.erfanian
Bug: 69857502 Test: TAP PiperOrigin-RevId: 177367228 Change-Id: Id79546672fa8bf3bf85bbe569ef638970b1365d8
2017-11-29Add flag to control default assisted dialing state during precall flow.erfanian
Currently, the only other client that is initiating calls is Contacts, and we consider that to be a non-idle-dial. Bug: 69860859 Test: existing unit tests PiperOrigin-RevId: 177367226 Change-Id: I22de38dc973f5a1eecfe42833110690744c317fd
2017-11-30Merge "Enable timer in emergency call."wangqi
am: 226b01b4fb Change-Id: I45041d6564d53277b22209ccd7c0a2b337752fd1
2017-11-30Merge "Enable timer in emergency call."Treehugger Robot
2017-11-29Enable timer in emergency call.wangqi
"This phone's number: xxx" is shown for emergency call which replaces in call timer. This change move it to under emergency location service so timer could be shown again. Bug: 69810801 Test: manual PiperOrigin-RevId: 177363955 Change-Id: I543fbbee869923800ffd92a5799819b712f0b953
2017-11-29Merge "Move country constraint logic into standalone class."erfanian
am: b33463c7cd Change-Id: I89fc96f42158934dd10da45ec42ed88544b24f6a
2017-11-29Merge "Move country constraint logic into standalone class."Treehugger Robot
2017-11-29Merge "Adjust strings for select SIM dialog"twyen
am: 3fbdd1c482 Change-Id: I7283753d282b15fd2a76f76a3921ed692af3e117
2017-11-29Merge "Adjust strings for select SIM dialog"Treehugger Robot
2017-11-29Merge changes Ie04496dc,Ib2998f03,I6cf53e50,Id6eaaad2mdooley
am: b500efc0b0 Change-Id: I8b0ea80772d52457e38cf8b6ff617a05c3c52c87
2017-11-29Merge "Fix resource not found when placing call outside dialer"twyen
am: 0e029e7f6d Change-Id: I26a5a05e9288ddb952dad3eae973f7d31644be72
2017-11-29Merge changes Ie04496dc,Ib2998f03,I6cf53e50,Id6eaaad2Treehugger Robot
* changes: Delete voicemails when disabling visual voicemail Switching to alarms and exponential backoff while polling for transcription result Format number for SIM selection Disable phone number formatting on the dialpad when making domestic call to Argentina mobile numbers.
2017-11-29Merge "Fix resource not found when placing call outside dialer"Treehugger Robot
2017-11-29Merge changes Ic61819b8,I4149abe1,Ic738a6dd,I297faa26,Ib6a929ef, ...twyen
am: 38db0c78bf Change-Id: I3857acc52182d915bef2ec6ab5e2e1479008da8d
2017-11-29Merge changes Ic61819b8,I4149abe1,Ic738a6dd,I297faa26,Ib6a929ef, ...Treehugger Robot
* changes: Prevent PreCallActivity from showing in lockscreen if it is not started in the lockscreen Prevent change SIM icon from showing during a voicemail call Expose user home country code as public method in Mediator Interface. Update assisted dialing setting text. Contact list no longer jumps to the top when the cp2 database updates. Refactor DialpadFragment's DtmfKeyListener Adjust strings for select SIM dialog Add impressions for dual sim features
2017-11-29Move country constraint logic into standalone class.erfanian
In a subsequent change, the assisted dialing settings will be able to use the parsing logic to filter the available countries listed in the settings. Bug: 69274259 Test: existing tests PiperOrigin-RevId: 177338864 Change-Id: I8ef76874d5f6d885b415174371225b738cc68716
2017-11-29Adjust strings for select SIM dialogtwyen
Test: N/A PiperOrigin-RevId: 177336359 Change-Id: Icec2eacef55ea6c1b3aad00fe10cde6284c89e25
2017-11-29Delete voicemails when disabling visual voicemailmdooley
For privacy reasons we now delete all voicemails and transcriptions when the user disables visual voicemail, (after confirming that they want to do this via a dialog). Note: we only delete voicemails whose source package is the google dialer. Note: the voicemails will be re-downloaded and re-transcribed if the user re-enables visual voicemail Bug: 69323147 Test: manual and unit test PiperOrigin-RevId: 177315139 Change-Id: Ie04496dc5960b485794733fbf74f7f704e806023
2017-11-29Switching to alarms and exponential backoff while polling for transcription ↵mdooley
result This cl switches the way asynchronous transcription tasks poll for their results. it has been observed that sometimes the server side transcription takes longer than expected (sometimes many minutes), so instead of blocking a thread for all that time this cl schedules an alarm for the next time to poll. it also uses an exponential backoff scheme to determine the poll times and increases the maximum total polling time from 20 seconds to 20 minutes. Bug: 66966157 Test: manual and unit tests PiperOrigin-RevId: 177257577 Change-Id: Ib2998f03cc418d5241ccffec71ba3945c9fe4cbc
2017-11-29Format number for SIM selectiontwyen
Bug: 69812286 Test: PhoneNumberHelperTest PiperOrigin-RevId: 177227451 Change-Id: I6cf53e50d17860f4374cbd9a94451bc0731905a4
2017-11-29Disable phone number formatting on the dialpad when making domestic call to ↵linyuh
Argentina mobile numbers. Bug: 30224215 Test: DialerPhoneNumberFormattingTextWatcherTest, DialpadFragmentIntegrationTest PiperOrigin-RevId: 177218942 Change-Id: Id6eaaad2f6d81e591d59a1d8444f45fb06f3f8d5
2017-11-29Fix resource not found when placing call outside dialertwyen
newInstance() defaults setDefaultResId to 0 and if it is written into the args the real default ID will not be used. Bug: 69804734 Test: SelectPhoneAccountDialogFragmentTest PiperOrigin-RevId: 177194281 Change-Id: Ic2b50fa741d812fd464d5e81199b040ef4c07195
2017-11-29Prevent PreCallActivity from showing in lockscreen if it is not started in ↵twyen
the lockscreen Bug: 69812359 Test: PreCallActivityTest PiperOrigin-RevId: 177193665 Change-Id: Ic61819b8456ee22c01228d6be2255b3f2c1e418a
2017-11-29Prevent change SIM icon from showing during a voicemail calltwyen
Calling the VM other number is to complicated for this release. Bug: 69803593 Test: CallButtonPresenterTest PiperOrigin-RevId: 177193486 Change-Id: I4149abe1d6eea48bb5399e12b9ce43a8e1ef4b37
2017-11-29Expose user home country code as public method in Mediator Interface.erfanian
This will be used in a subsequent change to show the user the default/predetected country code in the assisted dialing settings. Bug: 68775522 Test: unit tests PiperOrigin-RevId: 177168946 Change-Id: Ic738a6ddde8766962a725668f6db5056ab0bcafd
2017-11-29Update assisted dialing setting text.erfanian
Bug: 69562852 Test: none PiperOrigin-RevId: 177165337 Change-Id: I297faa26d778ec39f2365e84e90398e7ab49f353
2017-11-29Contact list no longer jumps to the top when the cp2 database updates.calderwoodra
The contacts fragment recycler view was rebuilding the adapter and layout manager each time the Contacts.CONTENT_URI observered a content change. Now we simply update the adapter's cursor and notifyDataSetChanged. This keeps the recycler view in place through all changes (inserts, deletes and updates). This change also fixes another bug replated to contacts fragment not refreshing when the contacts permission was granted in another part of the UI. Bug: 64044576,67781478,68179085 Test: manual PiperOrigin-RevId: 177106761 Change-Id: Ib6a929efb047001d681cb008c3ede69860146836
2017-11-29Refactor DialpadFragment's DtmfKeyListenermaxwelb
This change is the refactoring on DtmfKeyListener and adding tests. The class is an overridden version of DialerKeyListener, but it also supports direct onKeyDown and onKeyUp hooks from the DialpadFragment. There was a lot of duplicated code between these hooks and the overridden methods so the code was refactored to share more logic. The interesting part of this change is using EMPTY_SPANNABLE to call into super type methods instead of having to copy the implementation. This change may also help with OutOfMemoryExceptions because the DtmfKeyListener is promoted from a non-static inner class to a top level class. It no longer maintains an implicit reference to the DialpadFragment, holding onto the DialpadPresenter instead. To support testing this code, the ShadowCall had to be updated since it didn't support checking when a Dtmf tone was playing. Bug: 69133398 Test: DtmfKeyListenerTest, InCallActivityTest PiperOrigin-RevId: 177092841 Change-Id: I368083c71982e14db0ad936432a3a5bdf0dde5ee
2017-11-29Adjust strings for select SIM dialogtwyen
Test: N/A PiperOrigin-RevId: 177075957 Change-Id: Idf4546c57aba72470e07614d2a20d828da8ee08d
2017-11-29Add impressions for dual sim featurestwyen
Bug: 69618691 Test: CallingAccountSelectorTest PiperOrigin-RevId: 177062349 Change-Id: I4bc9098d06c541b607cca293269cf3489077b6c2
2017-11-29Merge "Adding transcription rating feedback"mdooley
am: 9c93611edc Change-Id: I269dda4f1c88105d234f077ac55da8cf73435ee7
2017-11-29Merge "Adding transcription rating feedback"Treehugger Robot
2017-11-28Adding transcription rating feedbackmdooley
Allow users who have agreed to donate their voicemails to also provide transcription quality feedback. screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuIajVtdFN3Y0Qydmx2NXJYN2N3OVA3N0h5UEdR Bug: 68712148 Test: manual and new unit tests PiperOrigin-RevId: 176774942 Change-Id: I08b9afbbefaedfb0de5199038a1d2769bd983855
2017-11-23Merge "Fix the crash caused by DialpadView's OnPreDrawListener."linyuh
am: 5b6d823a45 Change-Id: I329aa9a9e953d37f190144a6b3bfbad22eb82a4b
2017-11-23Merge "Fix the crash caused by DialpadView's OnPreDrawListener."Treehugger Robot
2017-11-23Merge "Prevent SIM selection and change SIM from showing when there are ↵twyen
active calls" am: e9641f8664 Change-Id: I26244e6dd6534709c003189eaae66be990e8cf5c
2017-11-23Merge "Prevent SIM selection and change SIM from showing when there are ↵Treehugger Robot
active calls"
2017-11-23Merge "Fix showing CallingAccountSelector in lock screen"twyen
am: 8bfd9a8caa Change-Id: I237a467a72fd7aa40192c1ce7d1e0454966e14ea
2017-11-23Merge "Fix showing CallingAccountSelector in lock screen"Treehugger Robot
2017-11-22Fix the crash caused by DialpadView's OnPreDrawListener.linyuh
OnPreDrawListener can be triggered AFTER a device orientation change but BEFORE DialpadView's onDetachedFromWindow() and onFinishInflate() are called, i.e., the listener will attempt to adjust the layout before it is inflated, which results in a crash. This fix is to remove the listener after all keys are adjusted for the first time since no more adjustments will be needed during the rest of DialpadView's lifecycle. Bug: 69665429 Test: DialpadFragmentIntegrationTest PiperOrigin-RevId: 176718488 Change-Id: Iff8a4108c73054a9e76725ef85e2559b90fe5f3e
2017-11-22Prevent SIM selection and change SIM from showing when there are active callstwyen
Most devices are DSDS (dual SIM dual standby) which only one SIM can have active calls at a time. Telecom will ignore the phone account handle and use the current active SIM. The SIM selection dialog has no effect, and the change SIM button will just redial with the same SIM. Bug: 69417430 Test: CallingAccountSelectorTest, CallButtonPresenterTest PiperOrigin-RevId: 176718021 Change-Id: I231cfeaa5ff77c29cdaf8e0865d096c85cfb7fc4
2017-11-22Fix showing CallingAccountSelector in lock screentwyen
FLAG_SHOW_WHEN_LOCKED is added to PreCallActivity so it can be launched in lockscreen. PreCallCoordinator now grabs new instances of PreCallActions onResume so the state can be flushed. If it is reused states like PendingAction might be used after it is discarded. Added null check before discarding fragment because it might not be created yet due to background query. Bug: 69570769 Test: CallingAccountSelectorTest PiperOrigin-RevId: 176714225 Change-Id: I8b09441bd1cdb8df835978a1d82b53a3d3d056e0
2017-11-23Merge changes I50da0d2d,Id00debe2,I2807510e,I3f7836d8,I2e31cd11, ...twyen
am: 6c773cbf11 Change-Id: I597de27ffcaea382b338720d9765a272c1e83f50
2017-11-23Merge changes I50da0d2d,Id00debe2,I2807510e,I3f7836d8,I2e31cd11, ...Treehugger Robot
* changes: Automated rollback of changelist 176587256 Check Contacts support for preferred SIM Add SpamJobType for all spam job IDs. Bubble v2 UI changes. Allow deleting a call log entry in the call log UI and the call details UI. Fix showing CallingAccountSelector in lock screen
2017-11-22Automated rollback of changelist 176587256twyen
Bug: 69570769 Test: CallingAccountSelectorTest PiperOrigin-RevId: 176706378 Change-Id: I50da0d2dd40a83ae6c1189fed2693368369849d3
2017-11-22Check Contacts support for preferred SIMtwyen
Preferred SIM can only be enabled when both dialer and the system contact app supports it. This CL checks if the app for ACTION_QUICK_CONTACT has the metadata supports_per_number_preferred_account. Also added a flag to disable the whole preferred SIM feature. Bug: 69638458 Test: CallingAccountSelectorTest PiperOrigin-RevId: 176687062 Change-Id: Id00debe2393068a422907a9eff2ac4ef0fcf6f8e
2017-11-22Add SpamJobType for all spam job IDs.wangqi
Bug: 69556012 Test: SpamJobSchedulerTest PiperOrigin-RevId: 176683042 Change-Id: I2807510e3c511c1672ed2c49117ad03b92c4cee5
2017-11-22Bubble v2 UI changes.yueg
Including: - Use exit-to-app icon instead of fullscreen icon for back-to-call button - Use ripple for first button since it needs top-rounded background - Change red hang-up button color and grey icon and text color - Change some dimensions Bug: 67605985 Test: manual PiperOrigin-RevId: 176678427 Change-Id: I3f7836d832f7130f82d7f3764fb392807f3fab9a
2017-11-22Allow deleting a call log entry in the call log UI and the call details UI.linyuh
In the call log UI, an entry can be deleted by selecting "delete" in its context menu. In the call details UI, a "delete" button is added at the bottom. The "delete" icon at the top right of the call details UI is removed. Public-Origin-Change-Id: Iabe1310fb9a97a277cf482a3fd61ffccbec125fe Signed-off-by: Linyu He <linyuh@google.com> Author: Masafumi Miya <masafumi.miya@sony.com> Bug: 38188896 Test: CallLogActivityIntegrationTest, CallDetailsActivityIntegrationTest PiperOrigin-RevId: 176677167 Change-Id: I2e31cd112efdfb83393f5e68ce016dcf36ac4858
2017-11-22Fix showing CallingAccountSelector in lock screentwyen
android:showWhenLocked and FLAG_SHOW_WHEN_LOCKED is added to PreCallActivity so it can be launched in lockscreen. PreCallCoordinator now grabs new instances of PreCallActions onResume so the state can be flushed. If it is reused states like PendingAction might be used after it is discarded. Added null check before discarding fragment because it might not be created yet due to background query. Bug: 69570769 Test: CallingAccountSelectorTest PiperOrigin-RevId: 176587256 Change-Id: Iaa7145e860136e9177f568e2c84461ed5efa12a1
2017-11-22Merge "Force disable VVM if carrier app is preloaded"twyen
am: ecbcc5c8cc Change-Id: I935c9515e8d75ba4ae420c41de6d9c34b3990f99
2017-11-22Merge "Force disable VVM if carrier app is preloaded"Treehugger Robot
2017-11-21Force disable VVM if carrier app is preloadedtwyen
This CL checks if the carrier app is installed on the system image. If so, VVM will be force disabled (user can't turn it on, can't even see the switch as if they are on a unsupported carrier). Otherwise, VVM will only be disabled by default if the carrier app is present (User can still turn it on in settings). Bug: 67496592 Test: OmtpCarrierConfigHelperTest / manual - move carrier app to /system/app PiperOrigin-RevId: 176586849 Change-Id: Idf79bdf61c600423062ca54d1b4c6e77cfcd8033
2017-11-22Merge "Adding call feedback mechanism"Android Dialer
am: 9d9ed5edd2 Change-Id: I0e7ea807f25f6fdadc8f2db015471afb508bdf24
2017-11-22Merge "Adding call feedback mechanism"Treehugger Robot
2017-11-21Adding call feedback mechanismAndroid Dialer
Test: No impact on existing functionalities PiperOrigin-RevId: 176562444 Change-Id: I209379dde3e920a27d6e735c8494647154e40e5a
2017-11-21Merge "Require N for preferred SIM query"twyen
am: ed6893eb40 Change-Id: I422ef37a9f3be66807e2e995a6902bd31067ee32
2017-11-21Merge changes I52729c45,Ia6cc29c4,I90da4789calderwoodra
am: f98533e549 Change-Id: I6fab3367577188a0c75ccc9e51a89f90cfb5dedf
2017-11-21Merge "Require N for preferred SIM query"Treehugger Robot
2017-11-21Merge changes I52729c45,Ia6cc29c4,I90da4789Treehugger Robot
* changes: Reduced jank when placing a call from search UI. Nearby places location permission request is now in a card view. Merge what's left in InCallActivityCommon into InCallActivity.
2017-11-21Require N for preferred SIM querytwyen
PhoneLookup.DATA_ID is only available after N. The fallback database should address this in a future CL. Bug: 69420158 Test: CallingAccountSelectorTest PiperOrigin-RevId: 176534281 Change-Id: I51ae1705fce6d7d4138b41fbd00d131447e49786
2017-11-21Reduced jank when placing a call from search UI.calderwoodra
I accidently made the search/dialtacts UI TOO performant and everything was happening too quickly. Postponed closing the dialpad and exiting search until onPause, but immediately close the keyboard so it isn't visible over the in call ui. Bug: 69313203,68857994 Test: see video PiperOrigin-RevId: 176531801 Change-Id: I52729c451d46ad00ac87c47f189134694554d33a
2017-11-21Nearby places location permission request is now in a card view.calderwoodra
Bug: 68272141 Test: n/a PiperOrigin-RevId: 176531675 Change-Id: Ia6cc29c4285ebe280d23a81f91007a02a65855b3
2017-11-21Merge what's left in InCallActivityCommon into InCallActivity.linyuh
Bug: 69272096 Test: None PiperOrigin-RevId: 176443652 Change-Id: I90da4789deb4b6337a38cfe010b8aee5090d35e0
2017-11-21Merge changes I73982924,Ic0747302,I8202a760,Icd66f8eb,I17091560, ...weijiaxu
am: a3990fc2f6 Change-Id: I98bd1930f4308f4bd6c920749927886a00394a97
2017-11-21Merge changes I73982924,Ic0747302,I8202a760,Icd66f8eb,I17091560, ...Treehugger Robot
* changes: Quick fix recursively importing. Add impression to track when users explicitly disable assisted dialing. Initialize executors before updating change PIN state Remove assert on StubVoicemailClient.addActivationStateListener() Implement SIM selection dialog Clear pendingAction when pausing PreCallCoordinator Add fast database populating button for benefit of testing.
2017-11-20Quick fix recursively importing.weijiaxu
Test: On a local device. PiperOrigin-RevId: 176443649 Change-Id: I73982924baf6ce0e947137766ec0038decd716e5
2017-11-20Add impression to track when users explicitly disable assisted dialing.erfanian
Test: new unit tests PiperOrigin-RevId: 176438950 Change-Id: Ic0747302170593b91da4148029396c36ab070c6e
2017-11-20Initialize executors before updating change PIN statetwyen
When the activity is launched it might immediately attempt to verify the stored pin, which happened before the executor is initialized Bug: 69179171 Test: N/A - legacy code, refactoring required PiperOrigin-RevId: 176433263 Change-Id: I8202a760dbfc7759e128ef31d477510526d0bee7
2017-11-20Remove assert on StubVoicemailClient.addActivationStateListener()twyen
The default "do nothing" behavior is enough. Bug: 69309850 Test: N/A PiperOrigin-RevId: 176427193 Change-Id: Icd66f8ebb75b889a3cceef895bc3bf71c466ccf6
2017-11-20Implement SIM selection dialogtwyen
Bug: 64216442,64214592,64213352 Test: N/A PiperOrigin-RevId: 176424724 Change-Id: I1709156098a14ac3bd35d98b913e7b881fcd9b2b
2017-11-20Clear pendingAction when pausing PreCallCoordinatortwyen
When resumed runNextAction() will assert that pendingAction is null so if there's any it won't be interrupted. When the coordinator is paused all dialogs and pending actions must be discarded. If the pending action is not properly discarded it will still assert when trying to call finish(). Bug: 69069675 Test: PreCallCoordinatorImplTest PiperOrigin-RevId: 176420108 Change-Id: Ie89bda3621371a105dc58ff02d83812194a1ea0b
2017-11-20Add fast database populating button for benefit of testing.weijiaxu
Bug: 69431528 Test: On a local device. PiperOrigin-RevId: 176420058 Change-Id: I3013800d86597b19268723377112286d2e2ceb68