Age | Commit message (Collapse) | Author |
|
|
|
Bug: 21814327
Change-Id: I6f59781ba5f8e5e396d919fefed6bfd76ec9e206
|
|
|
|
Better to ask the presenter, where it can check if the media player
is in the appropriate prepared state.
Bug: 21765119
Change-Id: Ieeade86900da1eb0ed9407bea17a7fc6219b3ad2
|
|
|
|
|
|
Change-Id: I132a119238c8de7249a4944e6dda472b3851637e
|
|
|
|
Bug: 21654804
Change-Id: I9fa76a33231ae95f4a233b4f6615c56280a0228e
|
|
Returning early if media player is not prepared in all these cases,
just in case.
Bug: 21764908
Change-Id: Ieca0e9fd1c323ea5150464683600542fefb318b3
|
|
|
|
Bug: 21764908
Change-Id: I5336ccadf13724430c2f3ee76c37efacd73cd27f
|
|
|
|
|
|
Change-Id: I6eb14e7eb9ecdedc96cd76bdb7bf288704cfe5cf
Auto-generated-cl: translation import
|
|
|
|
And, deleted some unused strings.
Bug: 21654755
Change-Id: I89fe9ac8caf121980d062583caa59bb45307e028
|
|
- Delete old report button/handling code.
+ Convert menu click listeners into single onMenuItemClick method.
+ Add and populate objectId on PhoneCallDetails, to be able to
tell from the CallDetailActivity whether to enable reporting.
Change-Id: Ie4b9a3c1835792cbba04dc826f71fd2e53071400
|
|
* Refactor code so that the callback can be parcelled and
persisted in the fragment after rotation.
* Make callbacks inner static classes to avoid potential
leaks
Bug: 21650435
Change-Id: Ie7c640f580233256c99d0e9e1643153d4c599d20
|
|
Promo card coming, but wanted to get strings in before strings deadline.
Bug: 21086059
Change-Id: I60455bfdb6fa268898312cb6aa2a2cb8f567a9d6
|
|
|
|
It's been a pain to add/change fields on PhoneCallDetails because
a multitude of parameters required for the constructors to create
an instance. I ran into this while considering how to add an
objectId to its parameters, and have previously too...
Make fields non-final so that they are more easily set. This has
the side-effect of making the casing of some initialization code
more straightforward.
+ Change it's constructor to a subset of required fields.
+ Simplify/reorganize CallLogAdapter and CallLogAsyncTaskUtil code.
+ Simplify tests.
Bug: 21733599
Change-Id: I236dfb0b8e6513f4b44dbdae17ce2eb9c9ae4778
|
|
|
|
|
|
Bug: 21715448
Change-Id: I809081ae80bfb15a3d95eb976715b1cc786a2b94
|
|
Changing the call log details duration display to show only the seconds
if the elapsed duration is less than a minute.
Bug: 19383401
Change-Id: I8d39ca2c6c680e58602022250d4272d83024696d
|
|
|
|
|
|
Run "changeCursor" on the main thread. I'm not precisely sure why
this fixes things, but it appeared before that the data I had on my
local device was being used instead of the test data.
Bug: 21471763
Change-Id: I6bece02e7c6828d54f76b5221ad10cf8f0052aa9
|
|
|
|
+ Pull out voicemail playback tests into their own test class.
+ Fix CallDetailActivity unit tests.
+ Some minor tweaks to functional code to facilitate.
Bug: 21471763
Change-Id: I0f1747ab7ad6eba7dd2a7f6f8cfd060b409771bc
|
|
This reverts commit e6f7928823e08a51cf66aa19c46deb9c669b8c7f.
Change-Id: Ica1daa35acfdc8a635499970ca7f7b4d5bfb3a19
|
|
Change-Id: Ie141ef5afb960f73c48af495a09a08d41877d14c
Auto-generated-cl: translation import
|
|
Uses carrier config instead of settings to show/hide dialer settings.
Bug: b/21355336
Change-Id: I2a19b82855cd5e48d1047edcf78d46718d68b3c9
|
|
Bug: 21471763
Change-Id: Ie28dc2715a173179ed753a7e38bd252c01e78f46
|
|
|
|
|
|
Bug: 21687649
Change-Id: I212243932c1be5306d97db9020874cadf5a55058
|
|
This reverts commit 06202b5c1c9d0c658c298646e95185e7763143b0.
Change-Id: I35a6e77a9cd276d2cb0359bacaa298619f9a3d01
|
|
Change-Id: I91f9105027611774ffbd0b6c443861883b16c443
Auto-generated-cl: translation import
|
|
Previously, the voicemail only needed to be looked up once, but now
a single presenter may load multiple voicemails. As such, destroy
the old FetchResultHandler if one already exists.
Bug: 21663448
Change-Id: Ibdb08f03760b770d0800bd44d4cdcf0ca7c57fc9
|
|
|
|
|
|
* changes:
Show empty view after load returns empty.
Change text to "add to a contact".
|
|
|
|
... instead of before. Mildly disorienting as a loading experience.
Bug: 19937778
Change-Id: Id1c7d48f3379350030aaed4f4a50320d22f970f6
|
|
Bug: 21550993
Change-Id: Ib903d19c589709a414ef475c8450843054f81375
|
|
+ Cleanup some asset and variable naming.
Bug: 21239168
Change-Id: I4c99484bee1fcd300857cf44080c38e19a98cb5a
|
|
+ Add call back button in call details.
+ Increase touch target size of call back button.
+ Simplify tint styling and layouts.
- Delete asset which was duplicate of one in ContactsCommon.
Bug: 18331084
Bug: 21659613
Change-Id: Icbd5f66a294f1215dc2056e7f7aece2129af5630
|
|
Bug: 20981731
Change-Id: I659903305475691e241955555494b2596846af6f
|
|
Bug: 21647046
Change-Id: Ib0f5c2d7cd973ba4732defeceb32fe956e8dbdb8
|
|
|
|
+ Lower shortcut char limits. There's probably 40 characters of
space on a N6, but less on smaller devices.
+ Shorten "Add to existing contact" to "add to contact".
Bug: 21550993
Change-Id: I136b01cd90ae36e07b7f567294e68316a57856a0
|
|
|
|
When joining strings, we want to respect RTL formatting for the
individual elements being joined, and joined string as a whole.
For example...
In LTR: "<LTR-formatted string>, <RTL-formatted string>"
In RTL: "<RTL-formatted string>, <LTR-formatted string>"
Bug: 20988802
Change-Id: I984ff364cbd0b0378bc467213274080e9524b18b
|
|
|
|
|
|
When this was refactored before, some of the logic was bad.
Some of the expected values were changed as well. I figured
"add to contacts" is a really bad default text, because we
don't actually support that action in call details. Also,
the strings returned by the library for describing relative
time spans changed.
Bug: 21471763
Change-Id: I0c78c89c9c2e44de198f1f9299711fc31fe81cb1
|
|
VoicemailStatusHelperImplTest was broken because of visibility issues
caused by recent changes to how we read voicemail status. But, we
plan to use this functionality again in the future.
Bug: 21471763
Change-Id: I2049d2661c7d0686c8a439ea8a9e5bd20b009dd6
|
|
- Delete voicemail playback in the CallDetailActivity.
+ Add voicemail playback to the call log list items.
+ Move the VoicemailPlaybackPresenter to the CallLogFragment.
+ Fix some retaining state for both call log (expanded items), and
preserve rotation/state functionality for voicemail playback. This
included some changes to the Presenter logic.
+ Fix some tests.
Bug: 21471763
Bug: 21170557
Change-Id: I30aae3a52c5bbf74a5075a9666343c337b1fc0df
|
|
Change-Id: I9395c300cd4cfc041bd2fc10d720d6782e704e45
Auto-generated-cl: translation import
|
|
|
|
In response to more API review.
Bug: 21571895
Change-Id: Ia1fa69da07a3427997919ba61c77fcbad7e79f2a
|
|
|
|
|
|
|
|
This allows unnecessary debug statements to be stripped out by
the compiler.
Change-Id: Id1b6f8bd6c86cf5014e4b76524aa3839eb31bbb8
|
|
This fixes a UI bug that happens when the dialpad is displayed
without animation.
Bug: 21524134
Change-Id: Ic566b09c2839d7f34d5d983f67e592c1b2d50d2e
|
|
Don't pause playback or release the media player during onPause or
onDestroy.
Bug: 21235334
Change-Id: I0eccd4e38e89c3416817d80aa25cc3bb529a9d6b
|
|
|
|
+ Reset the AsyncTaskExecutor's instance between calls in tests.
I don't know why this is necessary, but it fixes a class of problems
which were happening.
+ Don't try to release a media player if it has not been prepared.
+ Handle possible race conditions since MediaPlayer's async prepare
may be buffering or finished when a test assert is executed.
+ Add asset file no longer provided by variablespeed library.
- Cleanup some stream copy code.
Change-Id: I0ae5fde00514c6dcdb1e9c063435a13eed6e8528
|
|
Change-Id: Iaf5c16a5295cb7e172d640dfc350fb952a2a5900
Auto-generated-cl: translation import
|
|
Change-Id: Iac064f2404ce5962bc6a4d49106d8f0ab790741f
Auto-generated-cl: translation import
|
|
|
|
|
|
Bug: 21448455
Change-Id: Icb9f37643d12dde2d46743d2ce3aa2fade7a68a1
|
|
+ Substitutes the existing playback widget in CallDetailActivity,
although the plan is to move this to the call log shortly.
+ Convert the widget from a fragment into a layout. This allows us
to more easily create multiple instances of the voicemail widget in
the same view, as we intend to do in the call log.
+ Shift UI-related logic from Presenter to the Layout.
+ Fix janky seeking, so that it now works correctly consistently
rather than sporadically, and doesn't need to buffer again.
- Remove the VariableSpeed player formerly used in the Presenter. We
don't use this functionality anymore, and this allows us to directly
used the framework MediaPlayer (instead of a custom legacy proxy).
Bug: 21170557
Bug: 20693172
Change-Id: Ia34f459df10e43763b32fdb0954f83e882664231
|
|
Change-Id: I39080af6ee5a21313860b7ca1198c8d2088e4c1b
Auto-generated-cl: translation import
|
|
Change-Id: I388fc922485fa1af1db404aab5eebadd32b52fb1
|
|
|
|
|
|
Change-Id: I79427c479f3835dd0732cdbc11f38ef4f50c185f
Auto-generated-cl: translation import
|
|
We don't have access to the call log without the phone
permission, so disable the following functionality:
1) Call log display
2) Show call history overflow menu option
3) Last number dialed functionality
Bug: 20266292
Change-Id: I2f1d4b8b5f747d2fa04c3a9c291f9cf5147646b7
|
|
Conditionally disable the following features if the required
permissions are not available:
1) Display of all contacts
2) Display of speed dial
3) Caller ID in call log
4) Import/export contacts
5) Conversion of People.CONTENT_ITEM_TYPE and Phones.CONTENT_ITEM_TYPE
into a phone number (via DIAL intent)
6) UndemoteOutgoingCallReceiver
7) Contact Search
8) Contact lookup in call detail activity
9) Nearby places search
Bug: 20266292
Change-Id: I6d26902acb0eac407ae7bc18c11aa6ec57299506
|
|
|
|
|
|
We want the presenter to handle/manage resources pertinent to
the activity lifecycle, so that we can convert the playback
fragment into a component.
My apologies to whoever has to disentangle this presenter logic
later (though that could be me).
Bug: 21170557
Change-Id: Icf65d3c23f1a12a7d63c2a281f96d2168a4a560f
|
|
|
|
Bug: 20554942
Change-Id: I47daa3491223aed7e988e7d81501a281f1566f1c
|
|
- Delete unused shortcut code.
+ Consolidate logic for reporting the current lists view.
+ Change page position logic to make private the list fragment's
calculation of the type of tab in RTL.
Bug: 21328994
Change-Id: Ic05a895fce77fea668798fca6e67863a2fcfd88a
|
|
|
|
Bug: 21328994
Change-Id: Id6cd45c5614fafcc6f01842a8ec1eaba45dc0928
|
|
|
|
Change-Id: Iede24802e00301b96b7029aa69593a33931b761e
Auto-generated-cl: translation import
|
|
Change-Id: Id1763fe55b1950d43176649a1d0b66733e804cc8
Auto-generated-cl: translation import
|
|
+ Factors out async tasks from Call Detail activity, so that in the
near future it can be invoked from the call log directly.
+ Create listener interfaces for actions to execute after tasks have
been completed.
+ Should have no logical/behavioral changes.
Hopefully, this creates a more opaque interface for activities or
other classes to perform these actions as well.
Bug: 21170557
Change-Id: I43aea7e37600d3978e285f047cba7ce75ebb5787
|
|
- Remove call to CallUtil to check if video is enabled. It seems
like it's fine to include the content description of what the
call was, if it was a video call, even if there is not a
video-enabled call account.
- Factor out PhoneNumberDisplayHelper so it doesn't need to be
an instance. This reduces some extra calls to getDisplayNameHelper.
Probably a marginal difference, performance-wise, but it probably
helps a smidgen and also simplifies the need for creating and
passing or recalculating various instances of things.
TODO: It'd be much better if PhoneCallDetails had a builder.
It's terribly painful to fix all the tests when adding fields...
Change-Id: I6da13dc8b6b047043aba871796a8ed13b112a227
|
|
Move NotificationBroadcastReceiver into its own class.
Change-Id: I64dec0c72a30993c471352c9a0fc497fa31b4bc6
|
|
|
|
It will continue to be shown in the call log, but will be removed
from details since the widget will be moved.
Bug: 21170557
Change-Id: I1ec3b090adc0736f7b134d0f67282ba7b4f9483b
|