Age | Commit message (Collapse) | Author |
|
This makes the old peer read the CallLogConfig#isNewVoicemailFragmentEnabled and show the old or new fragment accordingly.
If the user is viewing the NewVoicemail and the CallLogConfig needs to disable the framework, the new fragment is immediately replaced with the old one. This is necessary because if the user were to scroll the fragment, the AnnotatedCallLog database would be read, which would trigger creation.
I tested this by flipping flags and observing underlying data being removed:
> dialer-cmd configprovider set new_voicemail_fragment_enabled false
> adb shell ls /data/data/com.google.android.dialer/databases/ && echo && adb shell cat /data/user_de/0/com.google.android.dialer/shared_prefs/com.google.android.dialer_preferences.xml
I test flipping flags back and forth on the voicemail tab, call log tab and ensuring that they are independent.
Bug: 77601968
Test: unit and manual. Some tests are failing, so to ensure we can have the voicemail ready for the bug bash tomorrow, I've ignored them temporarily but will be fixed in a follow up CL (tracked by b/77601893)
PiperOrigin-RevId: 191738860
Change-Id: I24ca38b862e98324cf802a3020e7e9df31c0b966
|
|
* changes:
Fix search bar margin issue in RTL
Prevent crash when dialpad animation ends after activity is saved.
Fixed some issues in dialer's dialpad for talkback users.
Voicemail and Call log notifications now open GoogleMainActivity.
|
|
|
|
The RemoveView is pushing it around. Since RemoveView and SearchBarView are mutually exclusive, this CL put them into a FrameLayout to avoid position interference.
Bug: 77273749
Test: manual
PiperOrigin-RevId: 191678018
Change-Id: If4000f63c77c9da6794193d389f890d21452dcbf
|
|
Bug: 77484989
Test: TAP
PiperOrigin-RevId: 191677909
Change-Id: If49a357a9ba158cd740eb789befd2ff802f670d4
|
|
- Content description for voicemail button is now "1... double tap and hold to
call vociemail"
- Content description for 0 button is now "0... double tap and hold for plus
symbol"
Bug: 19621015,62712616
Test: manual + a11y office hours
PiperOrigin-RevId: 191673375
Change-Id: I9b5d8d875f1bf218be6fcc33dff4ac9e479e4f43
|
|
Bug: 75972847,77595270
Test: manual
PiperOrigin-RevId: 191672019
Change-Id: I9ea7fb67b4dffeb6acb30840eaf093e4d00a3bcf
|
|
Bug: 74196353,77485680,77486095,77540395
Test: tap
PiperOrigin-RevId: 191666270
Change-Id: I0423735dde42299bf33ea0b8482c03fd3c2d4675
|
|
|
|
Bug: 74196353,77485680,77486095,77540395
Test: tap
PiperOrigin-RevId: 191666270
Change-Id: Ia56ca2636d4f3bbf37e54f33752ea678eb787705
|
|
|
|
Bug: 77486043
Test: unit tests
PiperOrigin-RevId: 191660058
Change-Id: Ia68c8b06e266950cb964a796ea338e4bbc1d6b07
|
|
* changes:
Better support for multi call.
Migrate RTT chat history to use proto buffer.
Disable RTT request button when the call is not active yet.
Use the default phone account for a voice call when the call log item is for Duo.
Explicitly hide the badge in ContactPhotoView when it shouldn't be shown.
|
|
Bug: 73775453,73775590
Test: unit tests
PiperOrigin-RevId: 191657758
Change-Id: If1ae5505185191f04fd57aa828ae5bcc9c21b173
|
|
This change also moved chat history to be saved in DialerCall, thus it will be persist when switching calls.
Bug: 67596257
Test: RttChatMessageTest
PiperOrigin-RevId: 191626079
Change-Id: I65e9c6ac7aa41beb45dfe561b0a48506ea938e6f
|
|
Bug: 70177426
Test: unit
PiperOrigin-RevId: 191612825
Change-Id: I1a72ca86fe9c74fb6420dcfa14f417a8aa6bd5d7
|
|
Duo.
Bug: 77535982
Test: ModulesTest + Manual
PiperOrigin-RevId: 191612821
Change-Id: I417b46ed3ec131bf409c427d82f5b2fa6b791054
|
|
Bug: 70988682
Test: ContactPhotoViewTest
PiperOrigin-RevId: 191600243
Change-Id: I60f979241898f1799a57c2401cbddb8975a9caa7
|
|
* changes:
Remove reference to RTT system setting.
Fix the button style of RTT request dialog.
Don't deadlock in DialerDatabaseHelper.
Fix NPE for details number
Per linguists' request, increase CHAR_LIMIT of "Carrier video" from 30 to 31.
Fix permission
Handle missed calls for new call log in old peer.
Separate calls with the video feature from others when coalescing rows in the new call log.
Support placing Duo calls in the new UI's bottom sheet.
Turn off component generating step of RootComponentGenerato and @DialerCompoennt. Delete related tests.
Implement dialog for responding RTT request.
|
|
This should be handled by PhoneAccount.hasCapabilities(PhoneAccount.CAPABILITY_RTT)
Test: none
PiperOrigin-RevId: 191522319
Change-Id: I28244a725c63fb3b83e97fd9a585473a94da96d9
|
|
Change to use public android API of button style.
Also changed padding left and right to 16dp (up from default 8dp).
Bug: 70177426
Test: manual
PiperOrigin-RevId: 191505606
Change-Id: Ic984f95843775af3057fb15bf5fe54d3384c478d
|
|
The fix is to use FutureSerializer instead of synchronizing on the method. FutureSerializer provides the guarantee that the next AsyncCallable won't even be submitted until the ListenableFuture returned by the previous one completes.
Bug: 73877234
Test: added sleep to update task, and verified that resuming activity > 5 times does not deadlock the app
PiperOrigin-RevId: 191494662
Change-Id: I5dc2bed7e117fd3ba5a3cd6a8c39c82a565ce070
|
|
The phone number can be null in the call log (typically for conference calls),
but this wasn't handled properly for calls from non-contacts.
This CL fixes the issue by instead using the display number. PhoneNumberUtils
properly handles null values and can parse the formatted version.
Bug: 77486039
Test: manual :/
PiperOrigin-RevId: 191492307
Change-Id: I1be427b3f4ed1381bea3943d130256618f730f5d
|
|
Bug: 77513242
Test: None
PiperOrigin-RevId: 191470111
Change-Id: I0220a342dc1ff04f247ad09dc1fc308f61bbe80c
|
|
Bug: 76445204
Test: manual
PiperOrigin-RevId: 191470043
Change-Id: I8d57331b2fbeff358535d92852d6bbb2ac677613
|
|
Test: unit
PiperOrigin-RevId: 191380073
Change-Id: If554d5ee0c55754802692a364bae591c3951c060
|
|
the new call log.
Test: CoalescerTest
PiperOrigin-RevId: 191376690
Change-Id: Id5939175edddd164a1b477319fb20e6d2a9671a9
|
|
Bug: 70988685
Test: DuoCallModuleTest, PlaceDuoCallEndToEndTest, Manual testing
PiperOrigin-RevId: 191372706
Change-Id: I439be71c361eaca722820b81278e5f95322e100c
|
|
@DialerCompoennt. Delete related tests.
Test: On a local device.
PiperOrigin-RevId: 191365675
Change-Id: Ia90463b936f3f07df99909c463b2bdb51223fbe6
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 191365412
Change-Id: Ida741a837d6495c0d5f51b748f4d6c09a1beafec
|
|
|
|
In this CL, the client will stop treating text/* attachments as transcrptions for T-mobile. Transcriptions are already disabled by the device type sent during provisioning so this will not affect any existing functionality. This prevents other data on the server showing up as transcription.
Bug: 77342321
Test: TAP, exact behavior not testable.
PiperOrigin-RevId: 191350836
Change-Id: I758996c3fef75ece7cecf0f7a0b4df7ace970d80
|
|
* changes:
Update contact photo for RTT call screen.
Fix the bug that number format is not correct in RTL mode.
|
|
Bug: 70177426
Test: manual
PiperOrigin-RevId: 191348602
Change-Id: I332d53ab0c3c628b3dca0c184435bafcf2a13d02
|
|
Bug: 76227259
Test: manual
PiperOrigin-RevId: 191347301
Change-Id: I18d63f4e85ca07be00f7564a5ee256d3a6b1b480
|
|
|
|
|
|
|
|
We want to be more consistent with other usages of NEW in the app, i.e. NEW should be used primarily by notifications.
Bug: 74821515
Test: unit
PiperOrigin-RevId: 191139559
Change-Id: Ib6fbead8b5589aedd881db26a07f7daed4d83543
|
|
This button has higher priority over add call button if RTT is enabled.
Bug: 67596257
Test: ButtonChooserIntegrationTest
PiperOrigin-RevId: 191129313
Change-Id: I5a3302a0970e77a933439749e0e559a691235523
|
|
|
|
Bug: 36841782
Test: SpeedDialEntryDatabaseHelperTest
PiperOrigin-RevId: 191121137
Change-Id: Iab712d5fac56e515bd4e977282656bf80db4337d
|
|
|
|
* changes:
Added logging for popping in new call log.
Move update color code from CallCardPresenter to InCallPresenter.
Log the number of "invalid" CP2 rows.
|
|
|
|
Now we also show bubble in onCallListChange(), but we shouldn't show bubble after dismiss in this case.
Test: ReturnToCallControllerTest
PiperOrigin-RevId: 191101307
Change-Id: I13ff6bf4ae7ab574966c43c0e6fee13853899ba0
|
|
Bug: 70989667
Test: unit
PiperOrigin-RevId: 191099351
Change-Id: I47f1e487e2a0cc23af7b39ae89e20abf993933ea
|
|
Bug: 74022483
Test: manual
PiperOrigin-RevId: 191098829
Change-Id: I715a97ba48db9a3a81ef7b27750131a3a3a331b7
|
|
Also use a flag to control the threshold at which we process invalid numbers.
Bug: 70989667
Test: unit
PiperOrigin-RevId: 191095892
Change-Id: Idb424831d637ae44e5e5915afaf59c3d534ce4a0
|
|
Old blocking is deprecated.
Bug: 70989544
Test: TAP
PiperOrigin-RevId: 191086875
Change-Id: Icde4963fce603fc4e16e486b78c070bd439e26e4
|
|
the new UI."
|
|
new UI.
Bug: 70988686
Test: CallLogEntryTextTest
PiperOrigin-RevId: 191071267
Change-Id: I392e3b4c47e266f0a553fe28079d4800fc174a8f
|
|
|
|
availability check"
|
|
Repeated requests from the server responds in an ALREADY_EXISTS error and does not transcribe the voicemails. In that case we should ask the server if the request is present already on the server, and if so retrieve it.
Bug: 77236260
Test: N/A
PiperOrigin-RevId: 191016332
Change-Id: I605c546a3bec3599c7b162853463ca7e46f63886
|
|
availability check
Checking donation is not a simple config check, but everything that donation availability is dependent on via the isVoicemailDonationAvailable() helper method. We update the code accordingly.
When the user declines the promo for donation, we should also update the toggle accordingly.
Bug: 74033229
Test: N/A
PiperOrigin-RevId: 191011808
Change-Id: I6e4ff9914355deed72175179fc7b9009f2395ef5
|
|
|
|
|
|
1. Don't close overflow menu after menu item is clicked.
2. Add correct shadow and animation to overflow menu.
3. Only scroll when remote message is updated if input box is empty.
4. Only hide keyboard if scrolling up is triggered by user.
5. Add paddingTop to recyclerView so that first message won't be covered by toolbar.
Bug: 70177426
Test: manual
PiperOrigin-RevId: 191002774
Change-Id: Ic69f80323e3d31d7853d4e8d0c6e4c100fe4a776
|
|
Bug: 77242856
Test: N/A
PiperOrigin-RevId: 191002650
Change-Id: Ia74423f28a40f148d507fb9f907fc2e5c41fc183
|
|
|
|
Bug: 75602772,77235335
Test: ImsVideoTechTest
PiperOrigin-RevId: 190988177
Change-Id: I2f4883f6bf492b380ef839562fd65ff6ac630bfb
|
|
|
|
- back arrow in search now flips in RTL mode http://screen/1eccBLDqPp0
- search text no longer overlaps icons http://screen/Mq0omQEuZez
- keyboard now always closes on pause
- location permission is no longer visible in dialpad search
Bug: 73088433,74784637,76117373,76440832,76441216
Test: keyboard and rtl tested manually, added test for location permission
PiperOrigin-RevId: 190981686
Change-Id: Ia121d410c158df0de9cd731ab280a6d8e9b300d9
|
|
Bug: 77148954
Test: m -j Dialer
Change-Id: Ife575d816af624a6a1dcb4ddc2c3be539bcd61ff
|
|
|
|
|
|
|
|
Change-Id: I70a6f1e2f59677292219a1ea4f493e6918f1956a
Test: Local run.
|
|
Bug: 76221932
Test: manual
PiperOrigin-RevId: 190948113
Change-Id: I4151ab3fc5231183d49fc1bdc247a09e5ffadc22
|
|
Bug: 70988682
Test: Existing tests
PiperOrigin-RevId: 190946639
Change-Id: Iaa8294e8ba6e85ab3c27bb2e67200d7972a240f2
|
|
|
|
* changes:
Create a common widget (ContactPhotoView) for a contact photo and its optional badge.
Remove unnecessary call to StatusBarNotifier.updateNotification().
|
|
Bug: 65490850
Test: manual
PiperOrigin-RevId: 190859631
Change-Id: I89aeb41a7709e9366367cdc54ba506e276685b5f
|
|
optional badge.
Bug: 70988682
Test: ContactPhotoViewTest
PiperOrigin-RevId: 190855440
Change-Id: Ib658efa6486b66548c710804049517905dc67b13
|
|
The call for incoming call is covered in StatusBarNotifier.onStateChange(). The two calls in InCallActivity is not useful (maybe is before notification becoming foreground).
Test: manual
PiperOrigin-RevId: 190845157
Change-Id: I0f84f15cfda5294566fa8976e09aac5163f85aa9
|
|
* changes:
Update spam blocking promo wordings.
Replace assets "quantum_ic_videocam_white_24" with a vector asset.
|
|
|
|
Bug: 75308663
Test: N/A
PiperOrigin-RevId: 190825933
Change-Id: Iaf112cfec81c82e127d77aedba351788a03eee54
|
|
Test: Existing tests
PiperOrigin-RevId: 190820867
Change-Id: I4835bcbc7698075fb54015dccc6823ada4c71651
|
|
System blocking should be used instead. These code are obsolete.
Bug: 70989544
Test: TAP
PiperOrigin-RevId: 190818334
Change-Id: I71475905ba110fdc0560991a2a9c2b9e2f2de9f2
|
|
|
|
|
|
When a user accepts the Dialer ToS for the first time, we should also enable transcription if it is available.
Bug: 74033229
Test: N/A
PiperOrigin-RevId: 190794147
Change-Id: I7eb9b3d481426aceb55a8990fdbd246101937e7b
|
|
When a user declines the transcription, we should turn off transcription and never show the transcription promo ever again.
Bug: 74033229
Test: N/A
PiperOrigin-RevId: 190790323
Change-Id: Ida60592b0550b18b28e7f7a7a22d19100f56231a
|
|
|
|
Bug: 70988682
Test: NewCallLogViewHolderTest
PiperOrigin-RevId: 190783830
Change-Id: Ib0b1ec23b7c278b83516019924b6c68ff12adaf9
|
|
|
|
* changes:
Use CallLogConfig for enabling new peer.
Turn on transcription when existing dialer user accepts ToS and transcription is available.
Turn off transcription when user declines tos (existing dialer user)
|
|
This makes the old peer read the CallLogConfig#isNewCallLogFragmentEnabled and show the old or new fragment accordingly.
If the user is viewing the NewCallLog and the CallLogConfig needs to disable the framework, the new fragment is immediately replaced with the old one. This is necessary because if the user were to scroll the fragment, the AnnotatedCallLog and PhoneLookupHistory databases would be read, which would trigger creation.
I don't expect this to be a common case because 1) we hopefully never have to disable the framework and 2) Framework is only updated on Phenotype broadcasts and JobScheduler jobs, which hopefully don't typically happen when user is viewing the call log. However, I still want to make sure that if it happens we don't irreversibly break users when we turn the framework back on.
I tested this by flipping flags and observing underlying data being removed:
> dialer-cmd configprovider set new_voicemail_fragment_enabled false
> adb shell ls /data/data/com.google.android.dialer/databases/ && echo && adb shell cat /data/user_de/0/com.google.android.dialer/shared_prefs/com.google.android.dialer_preferences.xml
I test flipping flags back and forth on the call log tab, speed dial tab, and while the activity was paused (pressing Home after viewing call log).
Note that this CL doesn't address showing missed calls and badge counts correctly with the new fragment; that will come in a later CL.
Bug: 74821995
Test: unit and manual
PiperOrigin-RevId: 190706481
Change-Id: I618d9c1649169abd65733502cfebc662a835e787
|
|
ConfigProvider should not be used directly for reading NUI flags as CallLogConfig needs to perform work when they change.
Bug: 74821995
Test: existing
PiperOrigin-RevId: 190698415
Change-Id: Ic084d9032d2a6f35ffba9f395eaaff9053cfa262
|
|
transcription is available.
Also updated the isVoicemailAvailable helper method, since just checking if the flag and OS is not enough (we have other things such as is VVM enabled, is VM activated), if we don't do this, it doesnt make sense to turn on transcription e.g Why what would happen if transcription is turned on but vvm is disabled
Bug: 74033229
Test: Added a todo, will be added later (there are a few more similar CL's that I am sending for other ToS conditions) to ensure the logic is correct for all ToS conditions first and I can add a test right at the end for all conditions.
PiperOrigin-RevId: 190696695
Change-Id: I9cb063a97e11943abeb1f823dc661efe88dfa3f1
|
|
When an existing dialer user is shown the ToS and they declines it, the transcription setting must be turned off, to respect the users wishes.
We also no longer take the user to the settings page.
Bug: 74033229,77147114
Test: Unit test
PiperOrigin-RevId: 190682249
Change-Id: I8c0abf9f3cbb15ded12a760abe540c557fd2e7d3
|
|
* changes:
Delete debugging logging statement in voicemail spam blocking
Add permission for in-call visibility change
|
|
Test: N/A
PiperOrigin-RevId: 190673495
Change-Id: I1587449f6b0b53e7a16aac0b334225649a94f27b
|
|
Bug: 76445204
Test: n/a
PiperOrigin-RevId: 190650130
Change-Id: I594a16676cfcca4e6a10c1f5bc6604509417ad23
|
|
|
|
When transcription toggle is turned off, we delete all local transcriptions. However when it is turned back on, we should re-transcribe all those( previously transcribed, then deleted) voicemails again.
Bug: 74033229
Test: N/A
PiperOrigin-RevId: 190640972
Change-Id: Iaaf324e74c7630852daeb314f34c2c3095fe3196
|
|
|
|
Adds the we can turn off transcription from settings.
Bug: 76226374
Test: N/A
PiperOrigin-RevId: 190626638
Change-Id: I22b56f133cc83749cdd52a4406be0c36c5a0d0ac
|