Age | Commit message (Collapse) | Author |
|
Test: existing test (MotorolaUtils)
PiperOrigin-RevId: 189225421
Change-Id: Id15181746cd087c82bc0b97262b03c76bc571b3f
|
|
Bug: 73830902
Test: Manual
PiperOrigin-RevId: 189222303
Change-Id: I0397986d784d28e7948b39778319e3936f6c55e9
|
|
|
|
This happens when outgoing video call is accepted as voice call or switching
between video call and voice call.
Bug: 71590134
Test: manual
PiperOrigin-RevId: 189206585
Change-Id: I564c261614990b9b6baab6025f1625f42058ba70
|
|
* changes:
Add audio select menu.
Introduce GlidePhotoManager to CallDetailsActivity
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 189204691
Change-Id: I9ecd36ce1c27072dea4ae87beeecd4565bf05378
|
|
Bug: 74202944
Test: ModulesTest, CallDetailsActivityTest
PiperOrigin-RevId: 189204143
Change-Id: I917bac76009522c6a99fdb63299556ec2a454dfa
|
|
* changes:
Added CallLogConfig.
Split CallDetailsActivity
|
|
This class is responsible for enabling or disabling the call log framework when flags change.
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189143911
Change-Id: I4727645ce621fbc01acbcd0acab523fe955d4075
|
|
Bug: 74202944
Test: Existing tests
PiperOrigin-RevId: 189095432
Change-Id: I13015ee6c5767edd95b78c3fb2e7338495e9e1d7
|
|
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 189064976
Change-Id: I3265881114baceb4d63fcc3d55d1c904cd3216dc
|
|
|
|
|
|
|
|
Fast consercutive calls to #showFragment can have undesirable effects because
fragment manager doesn't handle transactions sychronously. This CL resolves one
of the scanrios where voicemail fetch status was calling #showFragment nearly
simulataniously to the #onHandleIntent call.
This issue may show itself again and I'm looking into more long term solutions
but we should be fine in the short term since the all of our fragment logic
is implemented.
Bug: 74051208,74621909
Test: manual
PiperOrigin-RevId: 188956984
Change-Id: I0796e31b03e0b749ae7e81f82859ea6f814a5fb5
|
|
Incall and answer screen is using transparent status and navigation bar, while RTT screen is using customized color. Switch between them require correct setting of system UI.
Bug: 67596257
Test: manually test to make RTT call and voice call, then switch between them.
PiperOrigin-RevId: 188956868
Change-Id: I3c17ff453be943f0b2ad28fe5cae434453fbe326
|
|
Test: N/A
PiperOrigin-RevId: 188953886
Change-Id: I3279efe088e8a37df79d635bd44c6fa831109f2e
|
|
|
|
Test: existing
PiperOrigin-RevId: 188928916
Change-Id: I2b6fb73545194fa175526a77ce2a76b1d23c049d
|
|
|
|
|
|
|
|
|
|
SQLiteQueryBuilder.query() is used in strict mode with a projection map.
Bug: 74601176
Test: Unit tests
PiperOrigin-RevId: 188907943
Change-Id: I2f34e185ad175695d941697cd0dbdc8ad6172321
|
|
Add 6dp of spacing between transcription and the secondary text.
Bug: 69963448
Test: N/A
PiperOrigin-RevId: 188902056
Change-Id: Iba1c9c110bd238842567e7b1b36a757d388cea2d
|
|
Makes the views where the voicemails are displayed and the empty view white.
Bug: 74402112
Test: N/A
PiperOrigin-RevId: 188901487
Change-Id: I55a12dd067e66cc0f4efca3eb79b5a8f9e761082
|
|
The default text alignment of a TextView is based on the content of the view (does it has any RTL characters or not). Previously the TextView width is match parent so the text will either align to the left or right depending on the content (the label is user content which we don't control). In this CL it is changed to wrap content so the whole text will align to the parent's gravity which is "start".
Bug: 74421655
Test: N/A
PiperOrigin-RevId: 188899698
Change-Id: Id754ed97bb6d3b6bba05d0a96c83623daca01cc8
|
|
|
|
|
|
This CL is a continuation of cl/187700318. In that CL, we were able to unregister
the call log's content observer and prevent this crash, but it's reshowing
itself in voicemail now.
Since the voicemail's observer is registered in the adapter and is unaware of
lifecycle changes, it's much more invasive to fix. So as a quick bandaid, we'll
just check that the parent isn't null.
Bug: 73972084
Test: n/a
PiperOrigin-RevId: 188812159
Change-Id: I533114de66b52395b0f3c90d4ec7a927c4df707f
|
|
Keyboard should close when:
- requeting permission
- placing a call
- leaving the app
Search should close when:
- placing a call
- leaving the app
Bug: 74235853
Test: search closing onPause tests already exist (MainActivityOldPeerSearchIntegrationTest#placingCallFromSearchClosesSearch)
PiperOrigin-RevId: 188812026
Change-Id: Iaee084c59b4c514d10375deff5d73d5a456ef9df
|
|
|
|
|
|
Previously the OEM MMI codes are hardcoded and inadvertently affected other devices. In this CL it is read from the config provider instead. The config provider is expected to provide values based on the OEM.
Bug: 72162360,74016291
Test: SpecialCharSequenceMgrTest
PiperOrigin-RevId: 188786408
Change-Id: Ie70e49a8a9d2ced5da9cf502c020477615bbe8a2
|
|
Bug: 74402112
Test: none
PiperOrigin-RevId: 188782198
Change-Id: I36c2adcd8f0403c88694343cbbf12e9aba229afb
|
|
|
|
Decrease the padding from 10dp to 4dp for bottom and top
Bug: 68727352
Test: N/A
PiperOrigin-RevId: 188776245
Change-Id: I7ced053a5989e15e84fad6a264683a5c8e5d9339
|
|
not available."
|
|
* changes:
Make NUI VM avatar and icon consistent with nui call log
Move HIDE_VOICEMAIL_SETTINGS_MENU out of voicemail/impl
|
|
available.
Bug: 70989591
Test: GlidePhotoManagerImplTest
PiperOrigin-RevId: 188758361
Change-Id: I038b5618a0005159ebae28e4b95ef5a4d388e2be
|
|
Makes the avatar and more icon the same as the nui call log.
Bug: 69963448
Test: N/A
PiperOrigin-RevId: 188756733
Change-Id: I93303a2a872ac156470d223d6fb4fd2959766adc
|
|
The metadata belongs with the voicemail settings menu, which is moved into dialer a while ago. Not moving the metadata causes build variants without VVM to have duplicated voicemail settings in telephony and dialer.
Also removed the redundant metadata in incall ui manifest.
Bug: 73096806
Test: manual
PiperOrigin-RevId: 188756468
Change-Id: I00174f84024c5b9ab809d99e40a55d22a07bd063
|
|
* changes:
Remove bubble "new" prefix.
Dismiss keyboard when opening overflow menu in RTT call.
|
|
|
|
Test: BubbleImplTest, BubbleImplIntegrationTest, ReturnToCallControllerTest, ReturnToCallActionReceiverTest, BottomActionViewControllerTest, ChangeOnScreenBoundsTest
PiperOrigin-RevId: 188558386
Change-Id: Ieab3ee3f148092312a50597b41c0975419756e23
|
|
This is to prevent dialpad showing with keyboard open.
The alternative way to dismiss keyboard after dialpad shows up doesn't work.
Bug: 67596257
Test: manual
PiperOrigin-RevId: 188556453
Change-Id: I4b917d8ac83246d2002641ae7759261699149c65
|
|
Makes the redlines similar to what we have for the call log nui. The values are structured and copied as much as possible from /calllog/ui/res/layout/new_call_log_*.xml
Things to note for:
-Today/Older header the same as call log
-More items all the way to the right
-Padding in voicemail icon gone
-Removed padding between each recycler view item
Bug: 69963448
Test: N/A
PiperOrigin-RevId: 188547442
Change-Id: I515d75e392591243510634c3fabe444a7ba10d7f
|
|
|
|
|
|
Test: InAppSpamTest,ApdlSpamTest,VisualVoicemailUpdateTaskTest
PiperOrigin-RevId: 188509191
Change-Id: I8b9c07dcc1c7b3b80ffc914ec99f4e6d80d50985
|
|
Thus putting call into background won't lose the history.
This is only stored in memory by making RttChatMessage Parcelable and saved
along with fragment's life cycle.
Bug: 67596257
Test: manual
PiperOrigin-RevId: 188500104
Change-Id: I11e8e55f0475defd9c3b9a8cc10db4186392ddd8
|
|
|
|
|
|
|
|
When a voicemail is deleted we have to allow the user the option of cancelling the deleting of voicemail. This is done by showing the user a snack bar which when a user taps will prevent the voicemail from being deleted.
This CL only adds the underlying logic for the delete/undelete to take place via a ScheduledFuture, it does not fix all the UI issues that come with it, which will be sent in a follow up CL, issues such as:
-Updating the group label when a delete/undo happens
-Updating the entries above and below when a delete/undo happens
-Showing the empty view immediately when a user deletes a single voicemail
-Removing the empty view immediately when a user taps undo
-Updating tests
Bug: 69858266
Test: Manual
PiperOrigin-RevId: 188424489
Change-Id: Iecf5cb7be5b80fa5e91acaad3a7cc4a6c8702521
|
|
This change also dismiss overflow menu when any button is clicked inside it.
Bug: 67596257
Test: manual
PiperOrigin-RevId: 188424236
Change-Id: I90b803d592f12525cdb8727aaeebc45c3da5dcdd
|
|
Bug: 73368638
Test: CallLogAdapterTest
PiperOrigin-RevId: 188414469
Change-Id: I7d7522c841a6b4054e2e387346973c597174ee87
|
|
|
|
* changes:
Show bubble when call connected and in-call UI not showing.
Add divider line to nui voicemail alert
Optimize characters sent to remote party for RTT chat.
Refactor array of RttChatMessage to List.
|
|
Test: MainActivityOldPeerTest
PiperOrigin-RevId: 188409482
Change-Id: I0c132c49d63b9af849522851c55f51d431faa603
|
|
We used to only show bubble when leaving in-call UI, so answering from Bluetooth does not show bubble. Fix it by also showing bubble in onCallListChanged().
Test: NewReturnToCallControllerTest
PiperOrigin-RevId: 188403460
Change-Id: I5e6a3c37b2773e426dcc73ae5661b9e145b20cb8
|
|
Adds a divider line to differentiate the voicemail entries and the alerts.
Bug: 73158572
Test: N/A
PiperOrigin-RevId: 188389442
Change-Id: I33bd32fc310cdf52f20bcb2d0b2cd4266420cab6
|
|
Instead of using things provided by Android of onTextChanged, we compare the
text in EditText with the text in bubble before the change and compute the
delta string need to send to remote party. This way we could minimize
characters sent thus reduce latency.
Bug: 67596257
Test: RttChatMessageTest
PiperOrigin-RevId: 188389325
Change-Id: I3023b484c32b2369ca8720104da74cf6906bb46e
|
|
Bug: 67596257
Test: RttChatMessageTest
PiperOrigin-RevId: 188373256
Change-Id: I0f0798a5310225456619757dcca5bbd5df372b91
|
|
* changes:
Disable phone number formatting for Argentina only (MCC = 722).
Implement logic for unblocking a number from the new call log's bottom sheet.
|
|
Bug: 73718977
Test: Existing tests
PiperOrigin-RevId: 188359859
Change-Id: I513e1111b643d6fa476d1e56b60c0d6e61e131f4
|
|
Bug: 70989547
Test: ShowBlockReportSpamDialogNotifierEndToEndTest
PiperOrigin-RevId: 188357953
Change-Id: Ie1b1f439f043805892876790d7590a4c721dbf8c
|
|
sheet."
|
|
Bug: 70989547
Test: ShowBlockReportSpamDialogNotifierEndToEndTest
PiperOrigin-RevId: 188351591
Change-Id: I634fb821592bdc890df291fdf83cdf307c94ffa9
|
|
* changes:
Support local emergency phone number check when there are multiple SIMs.
Add additional logging to missed call notification code path
|
|
|
|
Bug: 73994020
Test: PhoneNumberHelperTest
PiperOrigin-RevId: 188260007
Change-Id: I23025e9b9454f487117c35e7a3b09307371ae825
|
|
Bug: 73877234
Test: just logging
PiperOrigin-RevId: 188256051
Change-Id: Ic9486b3fc1d97338cb016b86a243612baa6282fe
|
|
Test: none
PiperOrigin-RevId: 188244536
Change-Id: I7d41adaf600ba7829054ab8af6b4d30fd0873c3b
|
|
* changes:
Combine fragment hide/show transactions into one transaction.
Handle preferred SIM for ACTION_CALL
|
|
My hypothesis is that trying to commit multiple seperate transactions back to
back causes the fragment container to get into a weird state. So this change
has two parts:
- Disable preloading call log
- Combine the seperate hide/show transactions into one transaction
- Don't call conflicting transactions (i.e. hide then immediately show)
Bug: 74051208
Test: existing tests, manual
PiperOrigin-RevId: 188215791
Change-Id: I699fc02f1e2716bc019a29dc047ee4bc0d52df35
|
|
Previously preferred SIM is handled only by precall, which covers dialing with dialer or with the special receiver contacts uses. If a third party app uses ACTION_CALL or telecomManager.placeCall(), then the in call UI will be launched directly and the old account selection dialog will be used without preferred SIM support.
In this CL logic from CallingAccountSelector is refactored out so InCallActivity can use it for the dialog.
Bug: 73718976
Test: Unit tests, In call UI not covered.
PiperOrigin-RevId: 188214007
Change-Id: Ifaacf982a3e98601dc362b649c3501d4ee96e63e
|
|
|
|
|
|
The user starts a video call a warning dialog shall be presented.
If the user presses "OK" with the "Do not show again" box selected,
the dialog shall not be presented anymore.
Test: manual - Verified that a warning dialog about charges is shown
when a video call is started if
KEY_SHOW_VIDEO_CALL_CHARGES_ALERT_DIALOG_BOOL is true.
This is an upstream change from:
https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/518977/8
Bug: 67832837
Test: partner manual test
PiperOrigin-RevId: 188103414
Change-Id: I62628a32557297acaef096db90d2ddf049ef5017
|
|
- Add screen events for 4 tabs, dialpad and search.
- Add impressions for opening MainActivity with tabs/dialpad (non user tab selection).
- Add impression for VVM visible.
Bug: 72525843
Test: MainActivityOldPeerTest, MainSearchControllerTest
PiperOrigin-RevId: 188090249
Change-Id: Ifdf3519f07d7230f20b5d82691a96747b1944d63
|
|
|
|
Test: CallingAccountSelectorTest, manual
PiperOrigin-RevId: 188089149
Change-Id: Id1be88124e243e46ac9b0277f40de142af6bb5a9
|
|
|
|
Bug: 74202944
Test: Existing tests
PiperOrigin-RevId: 188060790
Change-Id: I4d79a353abf767935383d4149f261f5e96fd7acb
|
|
|
|
Bug: 73798533
Test: N/A
PiperOrigin-RevId: 188046222
Change-Id: I1b66afa787bb5c91d71dbeda544218226ae8f5fd
|
|
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 187944752
Change-Id: I2bbe45d2bda22bb000239f8613576fffb9f6ab28
|
|
* changes:
Disable phone number formatting for LATAM MCCs.
Check if the activity is still alive before refreshing unread tab counts.
|
|
Bug: 73718977
Test: MotorolaUtilsTest & PhoneNumberHelperTest
PiperOrigin-RevId: 187889473
Change-Id: I00d58071ba18ddce5a09c07de9edd2d0956d6478
|
|
My hypothesis is that there is a race condition where the call log changes and
we are leaving the activity before the content observer is unregistered or the
loader it starts is finished. This results in a callback calling #fetchCalls
while Dialer is in the background, resulting in a crash. This change will
confirm my hypothesis.
Even if my hypothesis is incorrect, we have similar checks throughout this
class which indicates to me that some issue exists here and that this check is
safe to do.
Bug: 73972084
Test: n/a
PiperOrigin-RevId: 187700318
Change-Id: I98cea86b5b7041c4f4aac09544445aaade6bfd40
|
|
|
|
Bug: 70989667
Test: unit
PiperOrigin-RevId: 187694255
Change-Id: Ie6ec70a70a4c59cbdfe25c34003d21fa2f751564
|
|
|
|
This includes:
1) Made RefreshAnnotatedCallLogWorker.refresh() methods return a result which is "not dirty", "dirty but no changes needed" or "dirty and changes need". It will be interesting to see how often these cases occur (will log impressions in a future CL) so I thought we might as well log the latency of each case separately as well.
2) To support 1) added a new method to FutureTimer which allows you to compute the event name from the result of the timed Future. Also needed to update the Metrics interface to support deferring the event name when starting a timer via a generic token.
3) Timing the coalesce operation which is very heavyweight.
4) Made StubMetrics do some logcat logging to easily observe timing information using AOSP
Bug: 70989667
Test: unit
PiperOrigin-RevId: 187691203
Change-Id: I5f19a2fc94d86639486299b65b0edd66eeaab52e
|
|
|
|
Bug: 73727182
Test: tested
PiperOrigin-RevId: 187673539
Change-Id: I9c790e912990fb8dc46da1c1057339c979ac9501
|
|
|