Age | Commit message (Collapse) | Author |
|
In call UI might use PreferredAccountWorker with a voicemail URI that has no numbers.
Bug: 76205637
Test: Unit tests
PiperOrigin-RevId: 190298082
Change-Id: I9949de5499958c408d6e1bf18cab6e77852d2487
|
|
See class comment on UkRegionPrefixInInternationalFormatHandler
Bug: 32501490
Test: Unit tests
PiperOrigin-RevId: 190296011
Change-Id: I6f01935f022fc288ad702735b38cb297fb9d2621
|
|
Bug: 75962274,75967273,75972847
Test: manual
PiperOrigin-RevId: 190251834
Change-Id: I3673a6b20a886ded86dc4e1a8f75a82e5e0bb199
|
|
We're not going to have a shortcut for NUI anymore. There are individual flags related to NUI that are controlled in CallLogConfig.
Other related changes to help accomplish this:
-Changed how the call log framework/config/migrator interact; the migrator is now only called on config changes and enabling/disabling of the framework now lives in CallLogFramework.
-Move CallLogConfig an interface, and moved it to its own package and added component and module. This is to simplify tests which just need to check the config status (like PhoneLookupHistoryRecorderTest).
-The "Main" package is also on longer needed since it existed to control the shortcut.
Bug: 74821995
Test: existing
PiperOrigin-RevId: 190251418
Change-Id: I73c8e83aee80295131443a8ffaa7dea716ea89b6
|
|
The warning is shown when there is no service, and the carrier requires the message to be shown because they cannot make emergency call over wifi.
Bug: 68030294
Test: Unit tests, integration tests.
PiperOrigin-RevId: 190241868
Change-Id: Ia6b838ac1e8e62ad6b40d97c1cf1a970491c1e6f
|
|
Bug: 76154272
Test: CallLogGroupBuilderTest
PiperOrigin-RevId: 190187854
Change-Id: Ib96c406c4bb0627729c24c58c526850ff4fda22f
|
|
When a user turns off transcription setting we should delete all the voicemails locally transcribed by google. We do this by deleting all the transcripts associated with the source package of the app.
Bug: 74033229,76167428
Test: Unit Test
PiperOrigin-RevId: 190159353
Change-Id: I328aece594aa0e66de59e43fa3619b5e9ae15f78
|
|
The assisted dialed string will also along show with the "calling via" label. To handle the long string, Top row is now a marquee.
Bug: 72571130
Test: Unit tests
PiperOrigin-RevId: 190156719
Change-Id: I18a13712bdc9d780f744ef65a1773d249e40fb15
|
|
Bug: 74421656
Test: DialerBidiFormatterTest
PiperOrigin-RevId: 190154072
Change-Id: Ic7cb3be702dd28b07b6e5e1e6d89f75f0bb12655
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 190126654
Change-Id: I412f8fbf5b345005f9fb3651c345303d965e4e02
|
|
After this change, user will be able to delete text in previous finished bubble. It will also correctly handle deletion from remote.
Bug: 67596257
Test: RttChatMessageTest
PiperOrigin-RevId: 190122728
Change-Id: Ifebcbe874e5f03857d109b58e758e53f408e7e44
|
|
Manually set to M
- MissedCallNotifierTest (not sure what the issue is here...)
- CallLogGroupBuilderTest (because a check was removed, some NPEs are thrown)
- MainSearchControllerTest (/system/etc/fonts.xml (No such file or directory))
Ignore Tests
- a few random ones in incallui/answer/impl/hint (shared prefs aren't working for some reason)
- VisualVoicemailUpdateTaskTest (disabled the whole test, issue unclear)
Bug: 73902692
Test: tap
PiperOrigin-RevId: 190030202
Change-Id: I1e9b61d758a61582c5a183ee884dd2181d1c10de
|
|
search.
These components are safe to delete because:
- New Contacts has been in prod for several releases.
- New Search has been in in prod for 2 releases.
- p13n logger was based on old search and is no longer being implemented in
Dialer.
- Filtered Number Settings contact search since we no longer support M.
Bug: 37208802,73902692
Test: tap
PiperOrigin-RevId: 189992017
Change-Id: I2720a252ababd164b5d0fb1011753a3c96a704d1
|
|
Updates the transcription setting from using a switch preference to a SwitchPreferenceWithClickableSummary. This allows the voicemail transcription setting preferences summary to be clicked and opened to the specified learn more url.
Bug: 74033229
Test: Unit Tests
PiperOrigin-RevId: 189983125
Change-Id: I1b162f3e2e582243fe8f84633e9401155170194c
|
|
different dialer variants."
|
|
dialer variants.
Bug: 35612086
Test: Test included
PiperOrigin-RevId: 189981890
Change-Id: Ife99969189d5d37bb1ad8ba61361a51e78abdfbb
|
|
* changes:
Use SwitchPreferenceWithClickableSummary instead of SwitchPreference for VM Donation
Removed appContext from CallLogDataSource and PhoneLookup.
|
|
|
|
|
|
Donation
The learn more link needs to be in the summary of the switch preference, however having a hyperlink in the summary text view of a switch preference does not open the hyperlink. To do this we made our custom switch preference which allows the summary to be clicked. All other aspects of the switch preference remain the same.
Bug: 74033229
Test: Unit test
PiperOrigin-RevId: 189978676
Change-Id: I31e744f3545e576ee3f5ac4a8fee249e22835e19
|
|
Impls can access appContext via dagger.
Test: existing
PiperOrigin-RevId: 189974157
Change-Id: Ie64d2c6f9ba08fc914d3c31f7e014c2beef3ab00
|
|
When a user enters the voicemail settings page and the voicemail is still being activated, we need to show the "Activating...." string to tell the user that something is still happening. This is important since unless the activation has happened, other settings are not visible e.g transcription and donation
Bug: 76107888
Test: N/A
PiperOrigin-RevId: 189970472
Change-Id: Ib9eeee64cd67c2adc4830a743516851ffa637fbf
|
|
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189969399
Change-Id: I8e287cc7884dde7640721bd385fe383a4635f3c8
|
|
|
|
|
|
This CL updates the call log to show "Emergency number" for call log rows from
numbers that PhoneNumberUtils.isEmergencyNumber considers to be emergency
numbers.
Bug: 66926712
Test: Manual, see above
PiperOrigin-RevId: 189953302
Change-Id: Ibaae243ead8b918a26f6058164316e042a4f82fd
|
|
If we get no location data for emergency call, we used to show spinner forever. This change shows error after 5s with no data, but still tries to get location.
Test: LocationFragmentTest
PiperOrigin-RevId: 189946803
Change-Id: Iaa0b429eec806337b9ab9cae3ca95e737fc667bf
|
|
"dialer/widget"."
|
|
Bug: 74421656
Test: Existing tests
PiperOrigin-RevId: 189935875
Change-Id: I834e15b7ff102ea021d7a99ebe568998a9c43603
|
|
|
|
Bug: 73774242
Test: unit tests where they exist
PiperOrigin-RevId: 189853302
Change-Id: Ibf3431cc0d7716c2c53c7ea165dfc130102a1bc7
|
|
|
|
This is necessary to disable the call log framework via flags.
This isn't yet called anywhere.
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189838957
Change-Id: I926c02c41151528eabc208c874acbfe7897a2f93
|
|
|
|
Bug: 72162360
Test: SpecialCharSequenceMgrTest, TranssionUtilsTest
PiperOrigin-RevId: 189825957
Change-Id: Ia161ad47c4122d33c108b545540707bb18076464
|
|
|
|
There is still some jank on first open, but it's much less janky
on close and consecutive open calls.
Test: existing tests confirm no regressions
PiperOrigin-RevId: 189802733
Change-Id: I49d6c2def7c33be0fdbb79c89772a5e4513cde3b
|
|
|
|
|
|
In order to correctly show animation, we have to ensure:
1. fab.scaleIn() is not called before dialpad is slide up.
2. fab is invisible before scaleIn is called.
Caveat:
This change is not tested on old UI (DialtactsActivity) since it's deprecated.
Test: manual
PiperOrigin-RevId: 189765153
Change-Id: Iada96b2789f96ca1612ae2048020a649f8b57b6b
|
|
This is needed to support flag changes which should cause the call log framework to become disabled.
It's not called anywhere yet.
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189761665
Change-Id: I914c690448f03ebacd7d05c9ad082aba7bf1a4ce
|
|
|
|
|
|
Test: Existing tests
PiperOrigin-RevId: 189683790
Change-Id: I0209e7fa839175041da29e9a6d8a590133121376
|
|
Test: Existing tests
PiperOrigin-RevId: 189678764
Change-Id: I6b9edd99e727788c65d325c1be43f0190c25c30e
|
|
* changes:
Convert @AutoValue CoalescedRow to a proto
Show spam blocking promo after block spam dialog
|
|
|
|
|
|
Test: Existing tests
PiperOrigin-RevId: 189675976
Change-Id: Ieae92b5ac2aefd3f0397bbb07ebb1c97bd72ed42
|
|
Test: SpamBlockingPromoHelperTest
PiperOrigin-RevId: 189674918
Change-Id: I0b22eb9b8128125cc5b439674099820a01c3889f
|
|
NUI dialpad is still broken.
Test: Unit tests
PiperOrigin-RevId: 189674304
Change-Id: I58d114ed45839f8ff85a3a0e48c3d200337915c9
|
|
Test: InAppSpamTest
PiperOrigin-RevId: 189670786
Change-Id: Ie7bf394ecc02ac647211f7375faaf3e1b48ad7dd
|
|
|
|
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189670163
Change-Id: Ifdfcab7dc4493cbe688ef77d43df7e7a1400fa27
|
|
|
|
|
|
|
|
|
|
This data source determines if the call is to the voicemail inbox.
isVoicemail() is removed from NumberAttributes and PhoneLookup. It is yet decided how in call UI should handle voicemail calls in the future.
TAG_CHANGE_OK=proto not in prod yet. Please clear app data.
TYPE_CHANGE_OK=above
Bug: 70989587
Test: Unit tests
PiperOrigin-RevId: 189650273
Change-Id: Iafebf1abb18c74301b62a72d1d04deecd6d78d29
|
|
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189648655
Change-Id: I9918bd6f35bf7eb1bebb9862c2d78880457efa91
|
|
A phone account can be removed after calling getCallCapablePhoneAccounts(), so subsequent getPhoneAccount() can be null.
Other usages already has the null check.
Bug: 75598828
Test: N/A testing this involves getPhoneAccount() returning null on the nth call, which requires replacing the shadows with a mock and is highly coupled with the implementation. The is an edge case and is not worth the effort and brittleness it will cause.
PiperOrigin-RevId: 189644833
Change-Id: Ie92dda2537befb5936ad734954b4eaf75964f465
|
|
A phone account can be removed after calling getCallCapablePhoneAccounts(), so subsequent getPhoneAccount() can be null.
Bug: 75598828
Test: In a follow up CL, where all instance of these will be fixed.
PiperOrigin-RevId: 189635573
Change-Id: I897db6e8e7706bc8afe6f25d89fd2ca4405900df
|
|
|
|
Repro steps:
1. open dialer, click on FAB to open dialpad
2. make outgoing call, end call, press home
3. enable WiFi call
4. open dialer again, click on FAB to open dialpad
This is caused by change icon called after the FAB is visible and scaleIn won't do anything since it's already visible. But for some reason the icon is changed so nothing is drawn on the screen when the dialpad slide up. (dialpadfragment is visible even before it's slide up before user trigger it)
The fix is to scaleOut the FAB when the fragment onStop thus the changed icon will be correctly drawn.
Bug: 74586190
Test: manual
PiperOrigin-RevId: 189629441
Change-Id: I3dcbedcd171c992e5df14bff35758fce1bb67bc1
|
|
is paused."
|
|
* changes:
Refactor VM Settings and add support for voicemail transcription
Use single return to break bubble of RTT chat.
|
|
|
|
Bug: 73972084
Test: n/a
PiperOrigin-RevId: 189418664
Change-Id: I3dadea08dad1f2a594f5a7e0daf055721c3222a3
|
|
This CL refactors the existing voicemail settings fragment and adds UI support for voicemail transcription. It mainly deals with the following:
- ensuring that when the VVM toggle is turned off, transcription and donations are gone.
- when transcription is off, donation preference is gone.
- donation is only available when transcription is available and enabled
- as part of the refactor, fixes existing logging bugs
- breaks preferences and its associated methods into helper methods when possible
- groups relevant preferences together when possible
Bug: 74033229
Test: Unit tests
PiperOrigin-RevId: 189418217
Change-Id: I3442cb5752a235cfca643ba55df3fb75171e3fe4
|
|
Also change "done" button to "send" in input box and disallow multiple line since return will be interpreted as "send".
Bug: 67596257
Test: manual
PiperOrigin-RevId: 189409725
Change-Id: I3d3bf3e11cd04d6689125399f4567e88ee3f28f0
|
|
This also finishes moving all of the old tests over from
Dialtacts to Main. The only 2 tests that fail are:
- searchBoxClosedWhenHandlingNotificationIntent
- openSearchFragment_fabGoneInRegularSearchAfterRotation
I will fix these in a follow up CL.
Bug: 72525887
Test: dialer_aosp build target launches MainActivity, TAP
PiperOrigin-RevId: 189408987
Change-Id: Ice30191d95c19c62bcd89503e89f66440f30beac
|
|
|
|
Bug: 72755010
Test: manaul
PiperOrigin-RevId: 189408046
Change-Id: Ia23442b2243e2008042e0046a21f840a30dbf008
|
|
|
|
|
|
|
|
|
|
Previously it is unclear what the "county ISO" should be so the originating county of the SIM is used. When telecom writes to the call log the county the user is in is used. This caused the DialerPhoneNumber key in in call UI and call log to differ and info to be lost.
In this CL, the current country is used in PhoneLookupHistoryRecorder to make it consistent with the call log.
PhoneLookupHistoryRecorder is currently the only consumer for telecom call util.getCountryCode().
Additionally, dialer/location no longer depends on dialer/util. dialer/util has too many unnecessary dependencies that will cause cycles.
Bug: 73752730
Test: Unit tests
PiperOrigin-RevId: 189378542
Change-Id: I59773f7745c835a6523efda951c475e2fde9aaf9
|
|
Bug: 73741286
Test: none
PiperOrigin-RevId: 189377028
Change-Id: Ifb9c6375d0026fb012ae868741b471f2ca02c5f9
|
|
Apperently contact ids are invalid for work contacts, so the URI needs to
exclude them.
Bug: 72755010
Test: manual
PiperOrigin-RevId: 189374262
Change-Id: Ibeaa555dc035e14ea67905c342369188ecfd1832
|
|
If the user had the dialpad open when they received a call, they could
potentially crash dialer if they pressed add call or clicked on a phone number
in another app.
Bug: 74711879
Test: manual
PiperOrigin-RevId: 189371425
Change-Id: I14df55e2467be07dd30e3971004e601216f57daf
|
|
|
|
Bug: 73133096
Test: ModulesTest
PiperOrigin-RevId: 189303135
Change-Id: Id92d65e4c0bbb3c325c9d89d41d0645df19cde06
|
|
|
|
* changes:
Close keyboard when placing a call to nearby places and remote contacts.
Adjust bottom nav margins, sizes, ect.
|
|
This was accidentally removed in cl/176677167. This change restores
the logging in call details and also adds it to the call log menu.
Bug: 73774284
Test: OldCallDetailsActivityIntegrationTest, CallLogActivityIntegrationTest
PiperOrigin-RevId: 189279107
Change-Id: Iadda16d7f1e4d720f828b5a72f210bcb8029f939
|
|
Bug: 74784637
Test: manual
PiperOrigin-RevId: 189276349
Change-Id: I27b0f911ab5165f902bef017e8c09276441a9dee
|
|
Test: n/a
PiperOrigin-RevId: 189274795
Change-Id: I495e326ce74568d8add739275562284ef12e276f
|
|
|
|
* changes:
Add utility used to style content with learn more links
Remove deprecated android.graphics.Canvas APIs
|
|
For simplicity, instead of resolve the nui shortcut string, I
deleted it since it isn't used anymore.
Test: build log
PiperOrigin-RevId: 189260472
Change-Id: I67d5a49d78916a8960e41ad1c7b7f59efad6d718
|
|
Bug: 74017355
Test: ContentWithLearnMoreSpannerTest
PiperOrigin-RevId: 189252365
Change-Id: I3464fb56b86a6b3ddd25e9eed14152eaeed9925c
|
|
Bug: 73777445
Test: TAP
PiperOrigin-RevId: 189225531
Change-Id: I806be1c2a05d842b4991a9c95c19238f999d814d
|
|
* changes:
Fix bubble not showing on device restart.
Add Brazil to the set of countries we do not format phone numbers
|
|
|
|
Test: ReturnToCallControllerTest
PiperOrigin-RevId: 189225436
Change-Id: I845855d0b66941e311f3db239d10249015473c65
|
|
Test: existing test (MotorolaUtils)
PiperOrigin-RevId: 189225421
Change-Id: Id15181746cd087c82bc0b97262b03c76bc571b3f
|
|
Bug: 73830902
Test: Manual
PiperOrigin-RevId: 189222303
Change-Id: I0397986d784d28e7948b39778319e3936f6c55e9
|
|
|
|
This happens when outgoing video call is accepted as voice call or switching
between video call and voice call.
Bug: 71590134
Test: manual
PiperOrigin-RevId: 189206585
Change-Id: I564c261614990b9b6baab6025f1625f42058ba70
|