Age | Commit message (Collapse) | Author |
|
Bug: 79723777
Test: manual
PiperOrigin-RevId: 197245874
Change-Id: Iad639ef467c8d0db861dddb7a174355127b8636c
|
|
|
|
|
|
|
|
The smart dial normalization remove non-digits, so the raw number must be set.
TEST=TAP
Bug: 79400183
Test: TAP
PiperOrigin-RevId: 197208475
Change-Id: I303f1b19c30f11303066750f7a830f33ab79ce4f
|
|
Bug: 79770053
Test: SpamTest + Existing tests
PiperOrigin-RevId: 197201496
Change-Id: Iff2eb03d00d3b559d2a008487b19a2d044b2cb5b
|
|
Deprecated RobolectricApplication.
RobolectricApplication uses RobolectricDialerRootComponent, which depends on all parts of the dialer application (CallLog, PhoneLookup, CommandLine, etc). None of these things matter for leafy unit tests like SpamBlockingPromoHelperTest and they just serve to slow down builds; both for tests that use RobolectricApplication and presubmits for all parts of the application. (Unrelated changes to the call log for example, would trigger this test on presubmit because this test depends on call log when it shouldn't.)
TEST=yes
Test: yes
PiperOrigin-RevId: 197193370
Change-Id: I425351eef2954d105ac7fc7c4120767d275a4fc8
|
|
|
|
Bug: 79770053
Test: Existing tests
PiperOrigin-RevId: 197192087
Change-Id: I44c60d13c83b3e23dc141fd9e9b88e108687bf96
|
|
|
|
|
|
Throttled missed call notification can be post again since they are in the newCalls list and not in activeNotifications list. We should record them and don't post again.
Test: MissedCallNotifierTest, NotificationThrottlerTest
PiperOrigin-RevId: 197177610
Change-Id: I1b03029663621f0a0c06951564eadf78bad016a1
|
|
Previously the phoneAccountHandle is validated before creating the CarrierIdentifier, but it seems like there's a chance that it would be invalidated in the gap before the identifier is created.
TEST=TAP
Bug: 73890027
Test: TAP
PiperOrigin-RevId: 197172168
Change-Id: I6f4f77819ed6ce9f3449f7e47a3538af1098d826
|
|
notification instead of canceling it and recreating a new notification."
|
|
* changes:
Update spam blocking promotion wordings.
Handle null returned from TelecomManager.getCallCapablePhoneAccounts()
Add more Cequint provider.
|
|
instead of canceling it and recreating a new notification.
Test: ManuallyTested
PiperOrigin-RevId: 197093375
Change-Id: I5214acd160d10a191d66c95798b2a44cdd3a9c7e
|
|
Bug: 79884797
Test: N/A
PiperOrigin-RevId: 197092298
Change-Id: I2f94f9a66a2530a5f2d0ad6630993a2e7b2b4bb8
|
|
Usually it is non-null, but not true for some OEMs.
TEST=TAP
Bug: 73905236
Test: TAP
PiperOrigin-RevId: 197076980
Change-Id: Ie58ecf2ab392e3393d190cefe9815b6bb8542800
|
|
Bug: 64975757
Test: none
PiperOrigin-RevId: 197074854
Change-Id: I56696fef1e76d72bbb2ef639cdd4257321cacc94
|
|
* changes:
Update dynamic shortcuts to match speed dial pinned positions.
Add empty content view for when the user has no contacts in favorites.
|
|
* changes:
Fixed various speed dial issues.
Use StorageComponent to get SharedPreference in SpamBlockingPromoHelper
|
|
6. App shortcut list should refresh when changes are made to
favorites, does not do so currently.
Bug: 79873008
Test: manual
PiperOrigin-RevId: 197073422
Change-Id: Ia72bdfab39a11daf8811cb122e819964ec37594f
|
|
Bug: 79885614
Test: SpeedDialFragmentTest
PiperOrigin-RevId: 197071565
Change-Id: I72df9feb44737e5f0fe42d26a77be7ffe57c1d09
|
|
X. Pinned contacts are now saved onPause
4. Large display size no longer crops images
14. If ViLTE is disabled, IMS_VIDEO channels won't be added.
Bug: 78491298,79876391,79876661
Test: manual
PiperOrigin-RevId: 197068627
Change-Id: I642a11d684c648b7f6579792313b09eabb09a9fa
|
|
Test: SpamBlockingPromoHelperTest
PiperOrigin-RevId: 197068358
Change-Id: Ic4b69781d0b32035c7d12d91d27e85d99e7d3732
|
|
voicemail fragment"
|
|
|
|
efficient contact photo creation. If the photoUri does not exist, GlidePhotoManagerImpl will create the needed LetterTileDrawable to use in the contact photo's place."
|
|
voicemail fragment
Bug: 70989658
Test: Manual
PiperOrigin-RevId: 197046549
Change-Id: I11f9515aad0b5d9c07ebb5d3ff480ed6751bd187
|
|
Bug: 38502365
Test: None
PiperOrigin-RevId: 197043585
Change-Id: If9baef5cdd59d6f94cca6d6298efe59d4e296485
|
|
contact photo creation. If the photoUri does not exist, GlidePhotoManagerImpl will create the needed LetterTileDrawable to use in the contact photo's place.
Bug: 76204286,76206686,76206786
Test: ContactGridManagerTest
PiperOrigin-RevId: 197034807
Change-Id: Icb286e557b21a21029bfa7e7d5a390e4eb889dde
|
|
|
|
Bug: 70989658
Test: Manual
PiperOrigin-RevId: 196907085
Change-Id: If3db2d6906245f052e756b315365b9d306f9d06d
|
|
|
|
Bug: 79213974
Test: n/a
PiperOrigin-RevId: 196868459
Change-Id: Ic1df5debf5273f3b41985b6922589854f07733e1
|
|
|
|
Bug: 70989658
Test: NewCallLogIntegrationTest + Manual
PiperOrigin-RevId: 196845473
Change-Id: Ic0cbcf668ea1921c88fb6b080308884fa1113e61
|
|
|
|
Bug: 78492722,79213974
Test: SpeedDialUiItemTest
PiperOrigin-RevId: 196754044
Change-Id: I7aec281ea7904087de0363245974cb08aec54c73
|
|
|
|
|
|
Delete simulator/portal package and move all files to simulator/impl package.
Bug: 79488174
Test: presubmit test.
PiperOrigin-RevId: 196735123
Change-Id: I2f578ca0912552ee32104d9ee5088bbb34ce5123
|
|
Bug: 79131964
Test: manual, frequents table is only readable, so setting up tests is difficult
PiperOrigin-RevId: 196720970
Change-Id: I0b0ef991fadaebb8abbcd48394a2780d8f824550
|
|
|
|
|
|
* changes:
Don't use LoaderManager.getInstance() in dialer.
Implement PhoneNumberCacheLookup
Fix add call button behavior.
Use component for iconography
Move SpamStub to separate package.
Initialize dialpadFragment and searchFragment with FragmentManager when MainSearchController is created
Compress all of dialer's png files.
Delete unused check__SpamStatus methods
Refactor simulator menu and add portal package for adding simulator service later.
Add simulator component in generated root component.
Update DialerCall to use SpamStatus instead of booleans
Added contacts permission screen to speed dial fragment.
Don't crash when cp2 returns a null label.
Register system call log content observer if user enables Phone permission.
Exit multiselect mode when opening the dialpad.
Support missing phone permission in new call log.
|
|
Bug: 70989635
Test: NewCallLogIntegrationTest
PiperOrigin-RevId: 196696755
Change-Id: I63c45f2996e08b40e41344fc35ce69317c08a42d
|
|
Previously the same action instance is used every time the PreCallActivity is resumed. This causes some state to be retain, for example the isDiscarding state on CallingAccountSelector prevents canceling the next dialog to abort the call.
Actions should not retain state between activity life cycles.
TEST=TAP
Bug: 79692264
Test: TAP
PiperOrigin-RevId: 196696224
Change-Id: Ifa604f431563dd1fb123a42e2a64b34c001e897d
|
|
It was added in support library 28 which isn't available in AOSP.
TEST=none
Test: none
PiperOrigin-RevId: 196692493
Change-Id: Id53c298af61c4635f1874131a8ae84620669a16d
|
|
PhoneNumberCacheLookup migrates lookup result from the old call log.
TEST=TAP
Bug: 72119926
Test: TAP
PiperOrigin-RevId: 196601622
Change-Id: I7df0ece770532c410747ceb310abb307fce80465
|
|
Double clicking add call button mutes the call, and going back to in call UI doesn't unmute the call. It's because previousMuteState is set twice. We shouldn't do anything for the second click since the first click makes you leave in call UI.
Also change automaticallyMuted to automaticallyMutedByAddCall to clearly indicate the value is for add call button only.
Test: CallButtonPresenterTest
PiperOrigin-RevId: 196590319
Change-Id: I9f41b1a75ced3900ae0c4fa787f3defaf7f1cbe6
|
|
Test: tap, manual
PiperOrigin-RevId: 196582079
Change-Id: Iffbfa408cbb32e81824cd46a67d51baa270132cf
|
|
This is necessary to avoid potential conflict binding with spam/testing on auto generated components in tests.
Test: presubmit
PiperOrigin-RevId: 196577184
Change-Id: I2aac0df138b7efb62cdcc35b2a79ce889d001cd8
|
|
MainSearchController is created
If the controller is recreated the same fragments should be used.
TEST=TAP
Bug: 77540395
Test: TAP
PiperOrigin-RevId: 196575979
Change-Id: I80a239296079ea625b076c0c42cff1a71ffbd4c0
|
|
Test: tap
PiperOrigin-RevId: 196575887
Change-Id: If2d07a2db075697f490d99021ad0616b40a3aff7
|
|
Test: Build
PiperOrigin-RevId: 196574842
Change-Id: Id9a63d975e114ada88de8e4a482409b5b618f55e
|
|
later.
Bug: 79488174
Test: build dialer.
PiperOrigin-RevId: 196565757
Change-Id: Ic87c2640d856e25f3d7d476edc4fa36588351ece
|
|
Test: tap presubmit.
PiperOrigin-RevId: 196563308
Change-Id: I0baa4efb03a857cc713d824d024ba2a164e50b0d
|
|
Test: Tap
PiperOrigin-RevId: 196562314
Change-Id: Ie90a5ad183d4fb65ff512ea158a8687fe1f77963
|
|
Bug: 79255819
Test: SpeedDialFragmentTest
PiperOrigin-RevId: 196560164
Change-Id: Ieb537da269d77089c4403ccb939c7194d04910bb
|
|
Bug: 79260760
Test: n/a
PiperOrigin-RevId: 196547205
Change-Id: Ic3c39a920ea759e5fc2b03f5022c5f2cc7ed3f8c
|
|
Previously, we only attempted to create the content observer in Application#onCreate and if the user didn't have the permission enabled, it wouldn't get added and would remain off for the duration of the application's life. Now we check if the observer is registered when refreshing the call log and enable it if necessary.
TEST=unit
Bug: 72461366
Test: unit
PiperOrigin-RevId: 196543060
Change-Id: I1d58efd21fb63e0745b43ac8ff11d87562126a2f
|
|
Bug: 79183384
Test: manual
PiperOrigin-RevId: 196344851
Change-Id: I9f5c0e52cb4efe9e63e2c19a4f62ee0b9a23412f
|
|
When the permission is missing, provide a link for the user to turn it on.
TEST=unit
Bug: 72461366
Test: unit
PiperOrigin-RevId: 196329702
Change-Id: I13f8c82769a13b12e1b3bd9fc14dfda36bd9a348
|
|
|
|
|
|
Bug: 79232964
Test: CoalescerTest, AnnotatedCallLogCursorLoaderTest, and manual testing.
PiperOrigin-RevId: 196321995
Change-Id: I016bf28e0c09cf4fee5bc5a9115335fb35b7f7e9
|
|
When the user disables contacts permisssions, instead of crashing, we need to clear all CP2 data from the annotated call log.
When updating tests to use the dagger processor there were some other dependencies and tests that needed to be cleaned up a bit.
TEST=unit
Bug: 72461366
Test: unit
PiperOrigin-RevId: 196318115
Change-Id: I95ff952f1e4492bebe364571ff70b2483c894ead
|
|
discarded"
|
|
If the PreferredAccountWorker completed after a rotation, it might show a dialog from the previous action which is no longer valid.
TEST=TAP
Bug: 79530586
Test: TAP
PiperOrigin-RevId: 196306574
Change-Id: I1d64eb63ad4f0bbe0ccdb7b8f73f638f67c56070
|
|
* changes:
Use old BottomSheetBehavior.
Use listeners to drive fragment lifecycles.
Add SpamMetadata to SpamStatus
Prevent showDialpad from adding multiple instances of fragments
Update logging in incallactivity.
Revert null check on dialpadHint
Add @InstallIn and @IncludeInDialerRoot to dagger modules in dialer codebase.
Add RTT after call promo bottomsheet.
|
|
Test: presubmit
PiperOrigin-RevId: 196285108
Change-Id: Ie424d231ced4066b0d5b734bebae443942994943
|
|
Test: tap
PiperOrigin-RevId: 196278370
Change-Id: Ied6072caf4a6e87da5ba6395db8c0b0fa55b3f97
|
|
Test: Tap, metadata not currently used anywhere
PiperOrigin-RevId: 196198986
Change-Id: I1902e527b2c5ab826e31425aab6d9b81f11fd009
|
|
Previously when the dialpad is shown the fragment manager is checked to decide whether to create a new fragment or not. This check does not account for pending transactions. If multiple ACTION_DIAL intents is received before the first showDialpad transaction is actually committed (due to the system lagging), multiple dialpad fragment will be added and cause crashes.
In this CL, the MainSearchController will hold on to the dialpad and search fragment instance, instead of querying the fragment manager.
TEST=manual - modify code to delay the commit. The timing is difficult to set up in tests.
Bug: 77540395
Test: manual - modify code to delay the commit. The timing is difficult to set up in tests.
PiperOrigin-RevId: 196197187
Change-Id: Ie649a9fba0ecfd8944781949c179ac8739930830
|
|
Bug: 194611503
Test: Unit Test
PiperOrigin-RevId: 196190392
Change-Id: I11fc1a02bd89207bf1c2d12f2821ef4447529c6e
|
|
This is caused by apps modifying dialer resources.
TEST=TAP
Bug: 79441501
Test: TAP
PiperOrigin-RevId: 196175830
Change-Id: Ia42e8debe66adbaa2e4e7bdfea7bafe1ef7372bf
|
|
Test: presubmit.
PiperOrigin-RevId: 196158524
Change-Id: Iec1e457039e97be0236cd700d397b4095ee3c2c3
|
|
Bug: 67596257
Test: unit tests
PiperOrigin-RevId: 196049621
Change-Id: I6f9c6292b1d56e3faf7808aa668b03d07230a70b
|
|
* changes:
Add some annotations that won't influence aosp.
Update answer button logic.
Hide new after call spam blocking promo behind an additional flag.
Allow the TextView for call log primary text to adjust size when recycled.
Format callback phone number.
Added getLoggingName() to CallLogDataSource and PhoneLookup interfaces.
Do not show bubble for outgoing call if it's not a background call.
Always fetch status onResume and add logging for voicemail status in OldMainPeer and
Place Duo calls with PreCall
Creating CallIntent, AutoValue builder, to replace CallIntentBuilder.
Set the DisplayNameSource to PHONE in DefaultLookupUriGenerator.
Config correct layout boundaries to accommodate long text (call log & bottom sheet)
Use info from EmergencyPhoneLookup to render UI for an emergency number.
Implement EmergencyPhoneLookup for checking if a number is an emergency number.
Add GlobalSpamListStatus and UserSpamListStatus
Move SpamStatus classes into subpackage
Delete obsolete checkSpamStatus(Listener) API
Update callers of checkSpamStatus to use Future based API
Fix bug that showing block option for private number.
Add a null check for digitsHint.
Don't commit fragment transactions if it's not safe.
Add ListenableFuture based APIs for checkSpamStatus
Pass activity between new call log's adapter/view holder.
Replace assert checks with safety checks instead.
Add SimpleSpamStatus and use it in FakeSpam and SpamStub
Show calls to/from emergency numbers as "Emergency number" in call log & call details
|
|
Test: blaze test.
PiperOrigin-RevId: 196047666
Change-Id: Ia54e342113f9dbc9fe884b9a85d0f4db33f94cf5
|
|
Bug: 73774884
Test: unit
PiperOrigin-RevId: 196021103
Change-Id: Id2176e6ef4259dc6e1136564051dae14e30175d4
|
|
Test: N/A
PiperOrigin-RevId: 195995975
Change-Id: I0311770eecdf36f275d81ba481098259344cbf5b
|
|
Bug: 77835800
Test: Manual
PiperOrigin-RevId: 195861757
Change-Id: I79f99c3468324922560961ea71dcc792a4d83a24
|
|
Test: manual
PiperOrigin-RevId: 195856176
Change-Id: I8579afff48e9c07d422505b81d703adc03656435
|
|
Use it when logging performance metrics.
Unfortunately the class names returned by Class#getSimpleName() are obfuscated by proguard and make viewing the metrics difficult to impossible.
TEST=none
Test: none
PiperOrigin-RevId: 195749831
Change-Id: I40320f388d34e059c9a913e2b72a1acf1a727f60
|
|
Test: ReturnToCallControllerTest
PiperOrigin-RevId: 195747611
Change-Id: Ibce7ef45af2f79cc5a35825a2bb38fe268a4681c
|
|
OldMainPeer and
Always fetch the voicemail status when resuming OldMainPeerActivity. There is no reason why this should not happen.
TEST=N/A
Bug: 79365547
Test: N/A
PiperOrigin-RevId: 195744525
Change-Id: Ie31551bfecd5056b0b3b559946e9cd2c8f6ef23f
|
|
This CL consolidates common duo calling operations into precall, including checking reachability, falling back to carrier video call, placing the call to duo with startActivityForResult.
TEST=TAP
Bug: 78783816
Test: TAP
PiperOrigin-RevId: 195742478
Change-Id: I9fea1e4999f604e1f3a153b28079cd0db77b7393
|
|
Bug: 78243194
Test: CallIntentTest
PiperOrigin-RevId: 195718047
Change-Id: I09134e13c9c5a811dba313cb4415a36aba7d7262
|
|
In this case we don't have a name, but set the DISPLAY_NAME to the number to make the contact card look nice. However, when using STRUCTURED_NAME and creating a new contact with the number, the number is populated in both the first/last name fields and the number field. Using PHONE makes it so the number is displayed on the contact card but the number is not populated in the name fields when creating a contact. This is consistent with the old call log's behavior (see ContactInfoHelper:createTemporaryContactUri).
TEST=manual
Bug: 78252466
Test: manual
PiperOrigin-RevId: 195714742
Change-Id: I26cf18a76af60f48d7979cd8cc8e47d72de1bf5e
|
|
sheet)
Bug: 77835800
Test: Manual
PiperOrigin-RevId: 195706300
Change-Id: Iccc97d5cc3ab6f196dc917faf1d7b6659b06cf30
|
|
Bug: 71719349
Test: CallLogEntryTextTest, HistoryItemActionModulesBuilderTest
PiperOrigin-RevId: 195694340
Change-Id: Ib53305c36f7ca062ef798ab3f61585d3c71adef3
|
|
Bug: 71719349
Test: EmergencyPhoneLookupTest, PhoneLookupInfoConsolidatorTest
PiperOrigin-RevId: 195691356
Change-Id: I705721fa6e6a22e5b2d541578b83196181c895eb
|
|
Test: Build
PiperOrigin-RevId: 195502147
Change-Id: I5f88fb91e52f36da73725e392dee8dfef2666be0
|
|
Test: Build
PiperOrigin-RevId: 195498557
Change-Id: I28525d0475f847b2ff5a128580256e2688ed47d5
|
|
Bug: 79171382
Test: Build
PiperOrigin-RevId: 195485088
Change-Id: I306c1ab0fdd629baf1feb0a689debe72eb08b450
|
|
Bug: 79171382
Test: Tap, manually verified spam calls (and autoblock)
PiperOrigin-RevId: 195480993
Change-Id: Ifefee382ae6181c20e83d16b2e0519dd05e60c6a
|
|
This happens when the number exists in call log, which usually shouldn't happen but some OEMs may have different behavior. Adding an additional check to align it with call action so block option won't show up if the number is not callable.
Bug: 79202933
Test: verified on LG device.
PiperOrigin-RevId: 195480184
Change-Id: Icde5f5b0914b2198d9031d188b22a65d6a3085cc
|
|
Bug: 77908301
Test: listnr
PiperOrigin-RevId: 195479105
Change-Id: Ieb64d5df486392b9bc1f6e9bbd340dc18e7b6e26
|