summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-11-20Initialize executors before updating change PIN statetwyen
When the activity is launched it might immediately attempt to verify the stored pin, which happened before the executor is initialized Bug: 69179171 Test: N/A - legacy code, refactoring required PiperOrigin-RevId: 176433263 Change-Id: I8202a760dbfc7759e128ef31d477510526d0bee7
2017-11-20Remove assert on StubVoicemailClient.addActivationStateListener()twyen
The default "do nothing" behavior is enough. Bug: 69309850 Test: N/A PiperOrigin-RevId: 176427193 Change-Id: Icd66f8ebb75b889a3cceef895bc3bf71c466ccf6
2017-11-20Implement SIM selection dialogtwyen
Bug: 64216442,64214592,64213352 Test: N/A PiperOrigin-RevId: 176424724 Change-Id: I1709156098a14ac3bd35d98b913e7b881fcd9b2b
2017-11-20Clear pendingAction when pausing PreCallCoordinatortwyen
When resumed runNextAction() will assert that pendingAction is null so if there's any it won't be interrupted. When the coordinator is paused all dialogs and pending actions must be discarded. If the pending action is not properly discarded it will still assert when trying to call finish(). Bug: 69069675 Test: PreCallCoordinatorImplTest PiperOrigin-RevId: 176420108 Change-Id: Ie89bda3621371a105dc58ff02d83812194a1ea0b
2017-11-20Add fast database populating button for benefit of testing.weijiaxu
Bug: 69431528 Test: On a local device. PiperOrigin-RevId: 176420058 Change-Id: I3013800d86597b19268723377112286d2e2ceb68
2017-11-20Merge "Dialpad icon now remains white through device rotation."Treehugger Robot
2017-11-20Merge "Add config flag for CallingAccountSelector"Treehugger Robot
2017-11-20Merge changes Ib41607a0,Icbb77747,I02bb3f67Treehugger Robot
* changes: Fixing verizon TOS text Cancel missed calls in call history when needed. Add more Cequint provider and signature check.
2017-11-20Merge changes Ifb41457a,Ia890ad20Treehugger Robot
* changes: Use correct field type for annotation definition. Search now supports alternative sort and display orders for contact names.
2017-11-20Merge changes Ie8759ae5,I5bb23420,I5b2b0f3fTreehugger Robot
* changes: Add more Cequint provider and signature check. Use correct field type for annotation definition. Search now supports alternative sort and display orders for contact names.
2017-11-20Dialpad icon now remains white through device rotation.calderwoodra
Bug: 69463065 Test: manual PiperOrigin-RevId: 176399153 Change-Id: I699688ab47c1ba497a0b6bb3301380a8e06f2ee2
2017-11-20Add config flag for CallingAccountSelectortwyen
Since CallingAccountSelector is currently the only action that requires a UI, disabling it will effectively revert the PreCall behavior back to pre-PreCall era, sending intents to telecom directly. Bug: 68953196 Test: CallingAccountSelectorTest PiperOrigin-RevId: 176398440 Change-Id: I612a56bc66f32cf72779bd7c507de6a0784f1298
2017-11-20Fixing verizon TOS textmdooley
This was caused by cl/176065849 where we added a per carrier check to see if transcription is supported. new screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuINkJ0R0JPTUZWSlpDMmlaRFdEUnJkY3pyTmxR Bug: 67457582 Test: manual and updated unit test PiperOrigin-RevId: 176389716 Change-Id: Ib41607a0ec6e9b40092d32fe055db80b6f9f8301
2017-11-20Cancel missed calls in call history when needed.yueg
Including when: - onStop() - switching tabs Also move old CallLogActivityTest to espresso directory. Test: CallLogActivityTest PiperOrigin-RevId: 176387019 Change-Id: Icbb77747882c8a5e35595557baa6917a4dc674b6
2017-11-20Add more Cequint provider and signature check.wangqi
This change expands Cequint Caller ID to more provider name and adds signature check to avoid fake provider fraud. Bug: 69061848,69310040 Test: CequintPackageUtilsTest PiperOrigin-RevId: 176386836 Change-Id: I02bb3f67d74f7cccbf99b0967e517595c6c2033b
2017-11-20Use correct field type for annotation definition.erfanian
Test: TAP PiperOrigin-RevId: 176382315 Change-Id: Ifb41457ad54cdffe9d721f6c13ee985b0a30149a
2017-11-20Search now supports alternative sort and display orders for contact names.calderwoodra
This means that names like "Bob Dylan" can be displayed as "Dylan, Bob" and the names are now able to be sorted by last name as well. This change also adds content descriptions to search icon for a11y. Bug: 68293751 Test: NewSearchFragmentTest PiperOrigin-RevId: 176382228 Change-Id: Ia890ad20e9e484fa9c4622c4b899b33f5b6e3990
2017-11-20Add more Cequint provider and signature check.wangqi
This change expands Cequint Caller ID to more provider name and adds signature check to avoid fake provider fraud. Bug: 69061848,69310040 Test: CequintPackageUtilsTest PiperOrigin-RevId: 176386836 Change-Id: Ie8759ae5acb18fe8fe61f365065ae020428a7880
2017-11-20Use correct field type for annotation definition.erfanian
Test: TAP PiperOrigin-RevId: 176382315 Change-Id: I5bb2342012e401dd28dcce440126e73b744523e5
2017-11-20Search now supports alternative sort and display orders for contact names.calderwoodra
This means that names like "Bob Dylan" can be displayed as "Dylan, Bob" and the names are now able to be sorted by last name as well. This change also adds content descriptions to search icon for a11y. Bug: 68293751 Test: NewSearchFragmentTest PiperOrigin-RevId: 176382228 Change-Id: I5b2b0f3f3f1e2f23ea6b745fd809adfb0ba6242c
2017-11-18Merge "When an expanded NUI VM is collapsed, ensure it remains collapsed ↵Treehugger Robot
when recycling views."
2017-11-18When an expanded NUI VM is collapsed, ensure it remains collapsed when ↵uabdullah
recycling views. The adapter maintains the state of those voicemails that were expanded. When the views are recycled we ensure that the expanded view holder whenever visible is expanded. However when an expanded viewholder is collapsed, taken out of view and then brought back into view (recycled), the expanded state is preserved. This CL ensures that this no longer happens. Bug: 64882313,68382421 Test: Unit test PiperOrigin-RevId: 176233960 Change-Id: Ib57859a287ec0c4f9e955a0fc01a49f093023fd1
2017-11-18Merge "Added place voice call search action to regular search."Treehugger Robot
2017-11-18Added place voice call search action to regular search.calderwoodra
When a user types a phone number into the search bar, there isn't an intuitive way for them to place a call when the number doesn't match any existing contacts in the new search UI. This change adds the option to place a voice call from regular search, like the old UI. Bug: 69385190 Test: NSFT PiperOrigin-RevId: 176189153 Change-Id: I6c1561bcce104c56855d996570a79b34da7230ff
2017-11-18Merge "Guard against remote directories returning results with no phone ↵Treehugger Robot
numbers during search."
2017-11-18Merge changes Iee4e3db8,I6e74c7fe,Ibe722477,Ia22751f0,Ic28fb197, ...Treehugger Robot
* changes: DialpadView cleanup. Merge the following methods in InCallActivityCommon into InCallActivity: Add contact source options. Automated rollback of changelist 174944384 Refactoring and adding TOS check before transcribing Adding exponential backoff utilities Implement suggested SIM Fix dialer simulator for conference calling funcitonality. Updated the following contents: 1.Fix the order of spawning connections for GSM conference. 2.Make VOLTE conference call more realistic. 3.Fix minor bugs about simulator. 4.Add SimulatorConnectionsBank class to store connection tags created by simulator. 5.Fix tests influenced by SimulatorConnectionsBank.
2017-11-18Merge changes Iebf5ab67,I69df1f28Treehugger Robot
* changes: Use OnPreDrawListener to adjust key layouts on the dialpad. Don't transcribe voicemail unless carrier allows OTT transcription
2017-11-18Merge changes I8cb0c6e7,I03258e86,I0b31bd93,I866708a6,I84f9e19b, ...Treehugger Robot
* changes: Implement change SIM animation Implement headless PreCall Merge the following methods in InCallActivityCommon into InCallActivity: 1. maybeShowErrorDialogOnDisconnect(DisconnectMessage), 2. onDialogDismissed(), 3. showErrorDialog(Dialog, CharSequence), 4. showInternationalCallOnWifiDialog(DialerCall), 5. showWifiFailedDialog(DialerCall), and 6. showWifiToLteHandoverToast(DialerCall). Added PhoneLookupDataSource and implemented isDirty. Send SUB_ID_EXTRA to VoicemailSettingsActivity in Telephony Add preferred SIM meta-data to dialer manifest Remove unused code InCallUiBings.getUiReadyBroadcastIntent(). Move the following methods from InCallActivityCommon to InCallActivity: 1. enableInCallOrientationEventListener(boolean) 2. isDialpadVisible() 3. getDialpadFragment() Keyboard now closes in regular search when user scrolls list. Optimize contact search by using a Ternary Search Tree. Dialpad FAB no longer loses it's icon on fragment resume. Automated rollback Move InCallActivityCommon#dismissPendingDialogs to InCallActivity. Automated rollback Replace NUI voicemail media buttons with image buttons Notify content URI when preferred SIM is updated Use phone account ID for legacy voicemail notification. Move InCallActivityCommon#dismissKeyGuard to InCallActivity.
2017-11-18Merge changes I7d2748cf,I70496c00,Ia455a18dTreehugger Robot
* changes: Combine voicemail uri and duration for NUI media player Set total duration for NUI voicemail media player seekbar Added URI for selecting distinct phone numbers from AnnotatedCallLog.
2017-11-18Guard against remote directories returning results with no phone numbers ↵zachh
during search. We have observed in the wild that some apps implementing remote directory don't seem to respect the where clause. Note that if a search returns 10 results, and 4 of them have null numbers, we will only show 6 numbers where ideally we'd show 10. (It would take a lot of work to fix that just to workaround misbehaving providers which I don't think is worthwhile.) Bug: 68942044 Test: unit + manually changed guard condition and observed rows hidden PiperOrigin-RevId: 176183008 Change-Id: Icdb26fa043644e27a4b6ac3c767c728b3ca224ff
2017-11-18DialpadView cleanup.linyuh
Changes: 1. Rewrote the logic to pick a NumberFormat. 2. Deleted dead method setShowVoicemailButton(boolean) and field mCanDigitsBeEdited. 3. Deleted the redundant SDK version check when getting a Drawable. Test: DialpadFragmentIntegrationTest PiperOrigin-RevId: 176181808 Change-Id: Iee4e3db8535ebbea3d4c63c8d8c1d3eb342b538e
2017-11-18Merge the following methods in InCallActivityCommon into InCallActivity:linyuh
01. handleDialerKeyDown(int, KeyEvent), 02. onBackPressed(boolean), 03. onDestroy(), 04. onKeyDown(int, KeyEvent), 05. onKeyUp(int, KeyEvent), 06. onPause(), 07. onSaveInstanceState(Bundle), 08. onStart(), 09. onStop(), 10. updateNavigationBar(boolean), and 11. updateTaskDescription(). Note that InCallActivityCommon#handleDialerKeyDown(int, KeyEvent) is merged into InCallActivity#onKeyDown(int, KeyEvent). This is part of the effort to delete InCallActivityCommon. Bug: 69272096 Test: None PiperOrigin-RevId: 176161247 Change-Id: I6e74c7feec5414fb4bc58814eef3bd297d6eb96f
2017-11-18Add contact source options.Android Dialer
Bug: 66900825 Test: manual PiperOrigin-RevId: 176155772 Change-Id: Ibe722477b90671b55ff7bf5405de9fb66569d43e
2017-11-18Automated rollback of changelist 174944384zachh
Bug: 68942044 Test: NO PiperOrigin-RevId: 176147553 Change-Id: Ia22751f02cdd621c2095e8e476a3077db2c541fa
2017-11-18Refactoring and adding TOS check before transcribingmdooley
This cl just adds a check before starting a transcription job to verify that the user has accepted the appropriate TOS. Its a rather big cl just because it had to expose some TOS acceptance details that were previously encapsulated in the VoicemailTosMessageCreator. Bug: 69267260 Test: manual and unit tests PiperOrigin-RevId: 176132370 Change-Id: Ic28fb197a07f9df7a9b5f1729c84566cba0890fc
2017-11-18Adding exponential backoff utilitiesmdooley
This cl adds two classes, one to calculate a base multiplier for an exponential backoff series and the other to return sequential values in an exponential backoff series. This cl has a number of advantages over the previous one, such as: - separating the base multiplier calculation from the exponential backoff class so that a standard exponential backoff class like com.google.common.labs.concurrent.RetryStrategy.ExponentialBackoff could be used instead if it becomes open source - allows the backoff sequence to be scaled by specify an initial backoff delay - uses milliseconds instead of arbitrary time units which allows the tolerance to be set automatically when calculating the base multiplier WANT_LGTM=zachh Bug: 66966157 Test: unit tests PiperOrigin-RevId: 176130268 Change-Id: I75135d4df16f642ea9dd3ef9ff9498981beae2c6
2017-11-18Implement suggested SIMtwyen
This CL adds a module that can query providers to aid users choosing which SIM to call with. Bug: 64214592 Test: MotoSuggestionProviderTest PiperOrigin-RevId: 176129303 Change-Id: Idb6314ad7f5a1bcd20b5b9173d3bfd873383cc84
2017-11-18Fix dialer simulator for conference calling funcitonality.weijiaxu
Updated the following contents: 1.Fix the order of spawning connections for GSM conference. 2.Make VOLTE conference call more realistic. 3.Fix minor bugs about simulator. 4.Add SimulatorConnectionsBank class to store connection tags created by simulator. 5.Fix tests influenced by SimulatorConnectionsBank. WANT_LGTM=wangqi Bug: 67785540 Test: In dialer lab. PiperOrigin-RevId: 176127584 Change-Id: I846174b97ed9329df6347583c41095f45f43494b
2017-11-18Use OnPreDrawListener to adjust key layouts on the dialpad.linyuh
Test: DialpadFragmentIntegrationTest PiperOrigin-RevId: 176122540 Change-Id: Iebf5ab67569fd4532411cfdae20ad5fb91cbcc55
2017-11-18Don't transcribe voicemail unless carrier allows OTT transcriptionmdooley
Added a carrier config and check to see if the carrier allows over the top voicemail transcription, and if not do not attempt transcription. Bug: 68951869 Test: manual and unit test PiperOrigin-RevId: 176065849 Change-Id: I69df1f2867420d7fdcc7f0a31e0e6c26da67abb1
2017-11-18Implement change SIM animationtwyen
CheckableLabledButton will no longer set icon if the icon has not changed, so the animation will not be interrupted. Bug: 64215256 Test: N/A PiperOrigin-RevId: 176047325 Change-Id: I8cb0c6e706b931406e78c91821f75e266e453ceb
2017-11-18Implement headless PreCalltwyen
If no actions require an activity, instead of launching the PreCallActivity, all actions will be performed immediately, and the call intent will be sent to telecom directly. This reduces the latency & risk when mutli SIM is not supported. Bug: 68953196 Test: PreCallImplTest, HeadlessPreCallCoordinatorTest PiperOrigin-RevId: 176032790 Change-Id: I03258e8643f18c65a8e5b1a84b18b71b30638044
2017-11-18Merge the following methods in InCallActivityCommon into InCallActivity:linyuh
1. maybeShowErrorDialogOnDisconnect(DisconnectMessage), 2. onDialogDismissed(), 3. showErrorDialog(Dialog, CharSequence), 4. showInternationalCallOnWifiDialog(DialerCall), 5. showWifiFailedDialog(DialerCall), and 6. showWifiToLteHandoverToast(DialerCall). Renaming in InCallActivity: 1. "maybeShowErrorDialogOnDisconnect" -> "showDialogOrToastForDisconnectedCall", 2. "onHandoverToWifiFailed" -> "showDialogOrToastForWifiHandoverFailure", 3. "onInternationalCallOnWifi" -> "showDialogForInternationalCallOnWifi", and 4. "onWiFiToLteHandover" -> "showToastForWiFiToLteHandover". This is part of the effort to delete InCallActivityCommon. Bug: 69272096 Test: None PiperOrigin-RevId: 175991784 Change-Id: I0b31bd93437e633d2f77b09982e0c7fc94ad8a32
2017-11-18Added PhoneLookupDataSource and implemented isDirty.zachh
Also extracted FakePhoneLookup to a testing package. Bug: 34672501 Test: unit PiperOrigin-RevId: 175923790 Change-Id: I866708a676e788051b369a024344967975c05979
2017-11-18Send SUB_ID_EXTRA to VoicemailSettingsActivity in Telephonytwyen
EXTRA_PHONE_ACCOUNT_HANDLE is not implemented in O. subId is required to determine which SIM the settings is for. Bug: 67669006 Test: VoicemailSettingsFragmentTest, TelecomUtilTest PiperOrigin-RevId: 175913331 Change-Id: I84f9e19b711c5baa275d934cfdfd5b7a2d4b6f6d
2017-11-18Add preferred SIM meta-data to dialer manifesttwyen
Contacts need to check the meta-data to decide if the preferred SIM UI should be shown. Bug: 64213352 Test: N/A PiperOrigin-RevId: 175912590 Change-Id: Ic02ca47ab156c3bb752b33c97cfb3b62f45a3667
2017-11-18Remove unused code InCallUiBings.getUiReadyBroadcastIntent().yueg
It also fixes NPE when mContext is null in InCallPresenter.onUiShowing(). Test: InCallPresenterTest PiperOrigin-RevId: 175898339 Change-Id: Id4aad7e15310663b9f561e5bdc56be5106e24ca8
2017-11-18Move the following methods from InCallActivityCommon to InCallActivity:linyuh
1. enableInCallOrientationEventListener(boolean) 2. isDialpadVisible() 3. getDialpadFragment() This is part of the effort to delete InCallActivityCommon. Bug: 69272096 Test: None PiperOrigin-RevId: 175898158 Change-Id: Ib0f58dbe35d528a475268a86b2af4119e7cfa381
2017-11-18Keyboard now closes in regular search when user scrolls list.calderwoodra
This change also enables search actions to be visible in regular search. screenshot: http://screen/ULBgq2RnKnM Bug: 68730642,67657783,68775021,66723880 Test: manual PiperOrigin-RevId: 175892821 Change-Id: I2c71fe8ffa2ffddfbc88d777909c4837e0ea4384
2017-11-18Optimize contact search by using a Ternary Search Tree.calderwoodra
This change updates search fragment to now preprocess query results and hold them in memory. This significantly improves the lookup runtime to be O(logn) on average and O(N) worst case. Bug: 69100384 Test: existing (plus some time measurement regression tests) PiperOrigin-RevId: 175891990 Change-Id: I6d7ae61c478b544af42d954af4e8580e052693ba
2017-11-18Dialpad FAB no longer loses it's icon on fragment resume.calderwoodra
There must be a bug in FloatingActionButton because when you call setImageDrawable multiple times (possibly with the same drawable/icon), the FAB renders with no icon present. That's why the icon would disappear in Fragment#onResume. Bug: 69006360 Test: manual PiperOrigin-RevId: 175878924 Change-Id: I1c36be3f9aeb003410f0bdbb9d52b5a483262f03
2017-11-18Automated rollbackroldenburg
END_PUBLIC BEGIN_PUBLIC Automated rollback of changelist 169615685 Test: rollback PiperOrigin-RevId: 175863544 Change-Id: I8785da90afed236cbe897efe774263765f188b14
2017-11-18Move InCallActivityCommon#dismissPendingDialogs to InCallActivity.linyuh
This is part of the effort to delete InCallActivityCommon. Related instance variables remain in InCallActivityCommon for now as they are used in several other places. Temporary getters/setters are added in InCallActivityCommon so that InCallActivity has access to these instance variables. Bug: 69272096 Test: None PiperOrigin-RevId: 175853702 Change-Id: Iaeb96c8ad7acb628393dd5c775ad7f3b40940a2b
2017-11-18Automated rollbackroldenburg
END_PUBLIC BEGIN_PUBLIC Automated rollback of changelist 169756942 Test: rollback PiperOrigin-RevId: 175849764 Change-Id: I3be3899682db84521fd933a5f058d5518ecb1fa1
2017-11-18Replace NUI voicemail media buttons with image buttonsuabdullah
Replaces the existing buttons with Image Buttons using standards images. Also added a phone button. Bug: 64882313,68382421 Test: Unit Tests PiperOrigin-RevId: 175843834 Change-Id: I21898f7da72f3dd17fce0047b11349737b373513
2017-11-18Notify content URI when preferred SIM is updatedtwyen
Test: PreferredSimFallBackProviderTest PiperOrigin-RevId: 175769540 Change-Id: Ie4e33f32ae9e99da92baa9906a3576df31b1b0a3
2017-11-18Use phone account ID for legacy voicemail notification.twyen
This allows one notification per SIM to be shown on multi SIM devices Bug: 64010653 Test: LegacyVoicemailNotifierTest PiperOrigin-RevId: 175756590 Change-Id: I8c2fe3ec06c5e6868ddc647742ab9ef422494b3b
2017-11-18Move InCallActivityCommon#dismissKeyGuard to InCallActivity.linyuh
This is part of the effort to delete InCallActivityCommon. There are 25 references to InCallActivityCommon in InCallActivity and we will remove them one at a time. Bug: 69272096 Test: None PiperOrigin-RevId: 175718978 Change-Id: I0713bd28c2d34791045be2bb851003000b88abca
2017-11-18Combine voicemail uri and duration for NUI media playeruabdullah
Voicemail URI and duration are both retrieved from VoicemailEntry. This CL combines it. This was a todo added from http://cl/175585919 Test: unit tests PiperOrigin-RevId: 175718355 Change-Id: I7d2748cf6e110e494f6895c512ce355aa2d048a7
2017-11-18Set total duration for NUI voicemail media player seekbaruabdullah
The duration of the voicemail shown in the seekbar/media player (upon expanding) should be the same as the duration shown when the voicemail view holder is collapsed. Both values are retrieved from the same source (VoicemailEntry). Bug: 64882313,68382421,69268144 Test: Unit Tests PiperOrigin-RevId: 175712662 Change-Id: I70496c004d52deb1793e6d6354b0ec79bf4c4398
2017-11-18Added URI for selecting distinct phone numbers from AnnotatedCallLog.zachh
This will be used in the PhoneLookupDataSource. A separate URI is necessary because the content provider APIs do not provide a mechanism for querying using the "distinct" keyword. Bug: 34672501 Test: unit PiperOrigin-RevId: 175706603 Change-Id: Ia455a18d10afb116d26f69e8b0c7493f4f877d0b
2017-11-18Merge "Fix crash caused by opening dialogs with a dead activity"Treehugger Robot
2017-11-18Merge "Add seekbar to Voicemail Media Player"Treehugger Robot
2017-11-18Merge changes I6a5a8ad8,I096ea022,Id164d08cTreehugger Robot
* changes: Implement preferred SIM Allow external apps to start pre-call flow Play voicemails downloaded from the voicemail server in the NUI VM Fragment
2017-11-18Fix crash caused by opening dialogs with a dead activitymaxwelb
This CL fixes crashes that are caused by opening the PhoneDisambiguationDialogFragment after the associated activity is destroyed. This is done by detecting when the activity is destroyed or finished. Bug: 69133504 Test: PhoneNumberInteractionTest PiperOrigin-RevId: 175623483 Change-Id: Ic639e9e9421205edcb5438d594bb144c6b09dd86
2017-11-18Add seekbar to Voicemail Media Playeruabdullah
Adds the UX support for showing the seekbar in the NUI Media player. It also shows a starting and total duration text as well, though as of right now it's a static value and will be updated in a follow up CL. Bug: 64882313,68382421,69268144 Test: Unit tests PiperOrigin-RevId: 175595293 Change-Id: I14440599d52352c213c7513dd2d0a8aef2f51bfe
2017-11-18Implement preferred SIMtwyen
Before prompting the user to select the SIM, CallingAccountSelector will lookup the fallback preferred SIM database to see if a preferred SIM is already set and bypass the selection. If the number is in contacts the user will also have the option to store the selected SIM as preferred. Bug: 64213352 Test: CallingAccountSelectorTest PiperOrigin-RevId: 175592732 Change-Id: I6a5a8ad8772eccfb4a119c529dcd3945b9dc0b1e
2017-11-18Allow external apps to start pre-call flowtwyen
This CL adds an activity that will forward parameters to PreCall so external apps like contact can utilize SIM selection or assisted dialing features. The caller needs to have CALL_PHONE permission. Bug: 64213352 Test: LaunchPreCallActivityTest PiperOrigin-RevId: 175591732 Change-Id: I096ea022d5ed87c29ffb191cd1bdb04e3a17c945
2017-11-18Play voicemails downloaded from the voicemail server in the NUI VM Fragmentuabdullah
Voicemails that are available locally on the device (have been downloaded from the voicemail server) will have their "HAS_CONTENT" column set to one. This CL adds the plumbing logic of checking that when a user presses the play button, if the voicemail is available locally, it is played. Bug: 64882313,68382421 Test: Existing unit tests PiperOrigin-RevId: 175590204 Change-Id: Id164d08c16b89c84a75af0c4a7c899c02d64fff7
2017-11-18Merge changes Id877da97,I449c851cTreehugger Robot
* changes: Fix bug that RTL posistion is not correct when initializing in CallLogActivity. Use TextUtils.isEmpty() instead of null check.
2017-11-18Merge "Fix bug that RTL posistion is not correct when initializing in ↵Treehugger Robot
CallLogActivity."
2017-11-18Merge "Use TextUtils.isEmpty() instead of null check."Treehugger Robot
2017-11-17Fix bug that RTL posistion is not correct when initializing in CallLogActivity.wangqi
Bug: 69133607 Test: manual PiperOrigin-RevId: 175586518 Change-Id: Id877da9734973f067b1455c4314406f00652b480
2017-11-17Use TextUtils.isEmpty() instead of null check.yueg
If phoneNumber is empty string, we go to endless loop. Test: ContactDisplayUtilsTest PiperOrigin-RevId: 175573954 Change-Id: I449c851c65912de5d666efe27a41ffc37a52e5ff
2017-11-17Fix bug that RTL posistion is not correct when initializing in CallLogActivity.wangqi
Bug: 69133607 Test: manual PiperOrigin-RevId: 175586518 Change-Id: I9c03da6f559e2943d30220aefc399ba2a7842f29
2017-11-17Use TextUtils.isEmpty() instead of null check.yueg
If phoneNumber is empty string, we go to endless loop. Test: ContactDisplayUtilsTest PiperOrigin-RevId: 175573954 Change-Id: If266a15041134dda4b9b365bc77f31b15cf89b32
2017-11-14Merge "Add a new impression proto for same prefix call marked as spam."Treehugger Robot
2017-11-14Merge "Reference packages.mk in dialer's Android.mk."Treehugger Robot
2017-11-13Add a new impression proto for same prefix call marked as spam.Android Dialer
Test: LoggerUtilsTest PiperOrigin-RevId: 175555340 Change-Id: Ic38e4e60559d91d3471629a5ffff496081fb5fb9
2017-11-13Reference packages.mk in dialer's Android.mk.Zachary Heidepriem
Test: mma Change-Id: I354059a3464e6dbafb7f5bab85d42b441ebb1335
2017-11-13Merge "Added voicemail.settings to packages.mk."Treehugger Robot
2017-11-13Added voicemail.settings to packages.mk.zachh
Test: none PiperOrigin-RevId: 175554007 Change-Id: Iba492820bcf5b06d4725be494e25e0b06b0943e6
2017-11-12Merge changes I828ff9d5,Id7844c3aTreehugger Robot
* changes: Implement PreferredSimFallbackProvider Use lambdas in CompositePhoneLookup.
2017-11-12Merge "Adjust weights of layouts on the dialpad so that key letters aren't ↵Treehugger Robot
clipped."
2017-11-12Merge changes I96dd5761,I196c2eaaTreehugger Robot
* changes: Fix bug that "+" is dropped when performing actions in smart dial search. Use parent message for CP2 info in phone_lookup_info.proto.
2017-11-12Merge "Added content provider for PhoneLookupHistory."Treehugger Robot
2017-11-11Implement PreferredSimFallbackProvidertwyen
The PhoneAccountHandle is keyed with the DATA_ID of a Phone row in the Contacts provider. Bug: 64213352 Test: PreferredSimFallbackProviderTest PiperOrigin-RevId: 175354818 Change-Id: I828ff9d5a1e03e18b05256bcf8a61170be8ce7bc
2017-11-11Use lambdas in CompositePhoneLookup.zachh
They should work now that we target guava 20 instead of 18 in AOSP. Test: tap PiperOrigin-RevId: 175354039 Change-Id: Id7844c3a1c8e29e5ecb13fa36a92dd80be0cfc7c
2017-11-11Adjust weights of layouts on the dialpad so that key letters aren't clipped.linyuh
Bug: 30215380 Test: Manual PiperOrigin-RevId: 175342952 Change-Id: I0e0318c5471605dfc47553552f558c65d41f9e9e
2017-11-11Fix bug that "+" is dropped when performing actions in smart dial search.wangqi
This is caused by normalizing numbers from dialpad search into search box, while "add new contacts" and "send sms" etc. wouldn't work properly without full number. This change also fix "send sms" in old search fragment. This change includes upstream change from: https://android-review.googlesource.com/#/c/platform/packages/apps/Dialer/+/530377/ Change address format when sending message from smart dial In Android O, send search key number as address to message app. In Android N, send real input number as address to message app. Fixed the issue by reverting to Android N implementation. Affected Area: Send SMS operation from Dialer smart dial search result list. Bug: 68962106 Test: manual PiperOrigin-RevId: 175317850 Change-Id: I96dd576144f93f7502977bfdb4b9e9d9c8f73526
2017-11-11Use parent message for CP2 info in phone_lookup_info.proto.zachh
PhoneLookupInfo should contain one message per PhoneLookup implementation for clarity. Instead of having a repeated Cp2Info field, we now have a single Cp2Info field which wraps a repeated Cp2ContactInfo field. Also added ApdlInfo to the message to make testing of CompositePhoneLookup more realistic, in that it tests merging across submessages now. (ApdlInfo is more or less a placeholder until ApdlPhoneLookup is implemented.) Test: yes PiperOrigin-RevId: 175316738 Change-Id: I196c2eaa885e1268ff80ebaad6d85840a9cc7a15
2017-11-11Added content provider for PhoneLookupHistory.zachh
Bug: 34672501 Test: yes PiperOrigin-RevId: 175243488 Change-Id: Iec3b5eb0e81f6e6cc04c64c3ea65c9c7fcb33fe3
2017-11-12Merge changes I220a35f3,I2460308e,I15b52595,I4ba40e53Treehugger Robot
* changes: Use type TEXT instead of STRING for annotated call log columns. Stop turning on the screen when the incoming/outgoing call is via Bluetooth. Filter out contacts with null primary display names in search. Conferece call management screen UI adjustment.
2017-11-12Merge changes I63e93080,Iff15e216Treehugger Robot
* changes: Renamed string.xml to strings.xml to match Android convention Add UiThreadExecutor
2017-11-12Use type TEXT instead of STRING for annotated call log columns.zachh
The declared type of "STRING" has an affinity of NUMERIC, not TEXT per: https://sqlite.org/datatype3.html Bug: 34672501 Test: existing PiperOrigin-RevId: 175237916 Change-Id: I220a35f3060eb60870f6e930c821bdb2f6d2c7ed
2017-11-12Stop turning on the screen when the incoming/outgoing call is via Bluetooth.linyuh
Bug: 38453773 Test: InCallActivityTest PiperOrigin-RevId: 175230358 Change-Id: I2460308e1af554e2198c256fb1f4c62d2b8124b2
2017-11-12Filter out contacts with null primary display names in search.zachh
Bug: 68848807 Test: unit PiperOrigin-RevId: 175190786 Change-Id: I15b525951cb87afb8b48f3bdb2174605c94c99cf
2017-11-12Conferece call management screen UI adjustment.yueg
Including: - change action icon color - hide TextView for name if name is empty - if name is empty, use number to generate avatar - don't show number type Bug: 67053842 Test: manual PiperOrigin-RevId: 175188810 Change-Id: I4ba40e5332d7b8567932360d36c8dc6ec3d604a5
2017-11-12Renamed string.xml to strings.xml to match Android conventionroldenburg
Bug: 68844134 Test: n/a PiperOrigin-RevId: 175102999 Change-Id: I63e930809d4bb96669062f724fb9cab90d675afa
2017-11-11Add UiThreadExecutorZachary Heidepriem
This CL adds an executor which runs tasks on the Ui thread, using the existing ThreadUtil class. Bug: 67752611 Test: UiThreadExecutorTest PiperOrigin-RevId: 175046280 Change-Id: Iff15e216be0e91891a9d63fddf1288ecbec41f83
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-15 13:15:41 +0000