Age | Commit message (Collapse) | Author |
|
Bug: 72722364
Test: existing
PiperOrigin-RevId: 184083186
Change-Id: Ia51a50b343f75eec74a02dc6b4383341f939793d
|
|
Bug: 72757397
Test: 'N/A'
PiperOrigin-RevId: 184082977
Change-Id: I3375fe14b81dffc4d8b54468c95b67ebe2b38fd1
|
|
Bug: 72443587
Test: BatchSpamCheckerTest, SpamDatabaseUtilsTest
PiperOrigin-RevId: 184076803
Change-Id: Ib11ca44190a28e28843ef4674c0abebc4203c46a
|
|
This CL shows and updates the missed call/voicemail count in the bottom nav. It
also clears the call log notifications when the user either leaves the call log
fragment or closes the activity after 3 seconds of browsing the call log.
Bug: 72525595
Test: tba
PiperOrigin-RevId: 184071058
Change-Id: I540c9e3d815e022b5e311cb02a3995e241b8a984
|
|
Previously it is only disabled when the user has not changed the VVM settings, and the user can still re-enable it.
After this CL, VVM will always be disabled, and the settings will be hidden.
Bug: 72668279
Test: Unit tests
PiperOrigin-RevId: 184063245
Change-Id: I42c12f3fd2f3e397158e08b26875a7e99a766d33
|
|
|
|
It's an indicator that the button triggers another list.
Bug: 67605985
Test: manual
PiperOrigin-RevId: 184042869
Change-Id: I3fea526a322dcc3935af111ebd0916b7c5ffcb24
|
|
|
|
Bug: 67605985
Test: NewBubbleImplTest, NewBubbleImplIntegrationTest, NewReturnToCallControllerTest
PiperOrigin-RevId: 184026033
Change-Id: Ie141ce9a0265ce3a08c01943cdeb94e2cd962e9f
|
|
|
|
* changes:
Don't override contactExists if there is no update from Cequint Caller ID.
Make default lastModified timestamp configurable
Added old call log to NUI.
Add old speed dial fragment to NUI.
Added badge count feature to bottom nav.
Allow delete of Restricted number entries
Update FragUtils to encourage better readability in Activities.
|
|
Bug: 72162360
Test: SpecialCharSequenceMgrTest
PiperOrigin-RevId: 183921310
Change-Id: I3a47106a42a6e7c3b903f595f690c7d125e72a04
|
|
Bug: 72485878
Test: none
PiperOrigin-RevId: 183915863
Change-Id: Ib035855d944c91145418222cc390be066744b4fb
|
|
Bug: 72320869
Test: manually verified that the config value is used
PiperOrigin-RevId: 183911716
Change-Id: I15bc2c4505306eb65446a792b305226255ae4315
|
|
Bug: 72618828
Test: existing
PiperOrigin-RevId: 183902491
Change-Id: I079aca188b52c29c12b3cae7e57bf71a4e883898
|
|
Bug: 72618868
Test: existing
PiperOrigin-RevId: 183896896
Change-Id: I9b90aaa02e1c40f38fbbe636f4e51cfd01c570f6
|
|
This Change doesn't actually fetch the badge counts, but it's now possible to
set badge counts.
Bug: 72525595
Test: manual
PiperOrigin-RevId: 183887322
Change-Id: I452ca6352133befc8cc2a39c44cd84a33fd66d42
|
|
Bug: 72639087
Test: CallDetailsActivityTest
PiperOrigin-RevId: 183872706
Change-Id: I2c3241b3b9059fe4ed82d79902a474df3d5975a4
|
|
Bug: 72525324
Test: existing
PiperOrigin-RevId: 183776841
Change-Id: Ia78002d3da823a228cf5a29f93cd53ad21105f94
|
|
* changes:
Added a hack for NUI because of a dependency cycle.
Use application context when fetching shared prefs.
|
|
In order for NUI to include the old fragments, it needs a dependency on
dialer/app.
In order for Dialtacts to show the NUI shortcut, it needs a dependency on
dialer/main.
This change removes the requirement for Dialtacts by copying some of the code
from dialer/main into dialer/app.
Bug: 72525324
Test: existing
PiperOrigin-RevId: 183769521
Change-Id: I29d00f22efecee35ca25f0b4172413c370f2506b
|
|
Using non-application contexts incurs extra disk access because shared prefs are cached per context.
Test: manually ejected sim and observed no strict mode violations
PiperOrigin-RevId: 183739285
Change-Id: I9337e226ae1e060478219cf495752ceccf5a31e6
|
|
|
|
These are frequently used attributes of numbers that we can compute once at parse-time.
Also did some general cleanup of DialerPhoneNumberUtil:
-Removed unused Future version of parse()
-Remove formatToValidE164 now that the new fields are available
-Inlined normalizeNumber()
Bug: 72563861
Test: existing
PiperOrigin-RevId: 183720128
Change-Id: I702dc265360e590439c5352c493ae8a858f36812
|
|
* changes:
Reworked the internals of DialerPhoneNumber.
Implemented Post Call in NUI.
|
|
It turns out the storing the libphonenumber representation of the number is not particularly useful because even formatting these objects cannot be done on the main thread. Rather than propagate the requirement of using PhoneNumberUtil (and background threads by extension) in the call log UI, we now just store a dialer-normalized version of the number which contains all information required by the UI in a way that allows us to avoid any background work in the UI code.
Bug: 72563861
Test: existing
PiperOrigin-RevId: 183463907
Change-Id: I4bdadaccb7a84033b3c72c54fe3833064f587ee3
|
|
Bug: 72525658
Test: PostCallIntegrationTest
PiperOrigin-RevId: 183441836
Change-Id: Ie1f8da1a7e24b22c5aa79cfa2a1261beb23579a1
|
|
* changes:
Disable phone icon for unknown numbers in NUI Voicemail
Pressing dial with an empty dialpad now queries the last number in NUI.
Disable seekbar user seeking
Add voice search to NUI.
|
|
The phone icon should be disabled for unknown numbers in the NUI Voicemail, so that those numbers may not be called. This should have the same logic as as what we do for the call log.
Bug: 72449247
Test: Unit Test
PiperOrigin-RevId: 183428831
Change-Id: If1ecc3b4d47de04bccf69ae735a619f6b33c3bbd
|
|
Bug: 72526019
Test: manual
PiperOrigin-RevId: 183425741
Change-Id: Ied1b369d00baefe02db04ade26bee9faac4f829c
|
|
By default the seekbar should be disabled unless being played or the voicemails have downloaded. This first part of the seekbar update ensures that a user is not able to seek, and the seekbar will only be updated automatically when the voicemail is being played.
Bug: 7252855
Test: N/A
PiperOrigin-RevId: 183419966
Change-Id: I4e492279402d76d3e1ece03dded9b402c88138c8
|
|
Bug: 72525718
Test: MainActivityIntegrationTest
PiperOrigin-RevId: 183418364
Change-Id: I30a4b7fe3e8a82c1b5cddcd747bd01ebd127b624
|
|
|
|
* changes:
Added number presentation to AnnotatedCallLog.
Add enriched calling simulation.
|
|
Updated the new call log UI to properly show text based on the presentation.
Bug: 70989592
Test: unit
PiperOrigin-RevId: 183414195
Change-Id: I2123f37cd3c733060125b6e894c1a80be4193ad6
|
|
Test: on a local device.
PiperOrigin-RevId: 183414102
Change-Id: I56efda40994e9f0b84f462e42301adbf625273e5
|
|
Test: make
Change-Id: I8ea8736c5fb4c123955bb2de2e328f6d833851bb
|
|
|
|
Previously we only logged during degenerative events.
Bug: 72174016
Test: none
PiperOrigin-RevId: 183392966
Change-Id: Ibf4b8ce08dff39e9bba2f698162683c2431d06eb
|
|
|
|
* changes:
Update preferred SIM SuggestionProvider
Remove non call log dependencies on PhoneAccountUtil
|
|
NUI VM"
|
|
When a user presses the phone icon in NUI voicemail, we should make a phone call.
This does not handle phone account handling and disabling showing the phone icon for unknown numbers (tracked in b/72449247 and b/72449246)
Bug: 72449869
Test: Unit test
PiperOrigin-RevId: 183318358
Change-Id: I075ae79ec6896f2b9244f990bd2a01493c495e07
|
|
"remember this SIM" checkbox state is reported to the provider.
The other SIM is reported to the provider when "change SIM" is used
Bug: 70503524
Test: Unit tests
PiperOrigin-RevId: 183308581
Change-Id: I3d097d14a503c759f130044c9a9c48c420eee19d
|
|
Methods moved to TelecomUtils
Test: Unit tests
PiperOrigin-RevId: 183305626
Change-Id: Idd6604e58c06a36066bd49870849dd71747969c6
|
|
Clicking the speaker button in the NUI VM for a voicemail entry alternates playing the audio via the speaker and headset. This CL does not change the state of the speaker icon, that will be done in a follow up CL (cl/183175378) and the todo for that has been added.
Bug: 69858226
Test: N/A
PiperOrigin-RevId: 183304029
Change-Id: I3a55e62ab8d1203f659a45db9534fd69deda122f
|
|
|
|
* changes:
Prevent VvmNetworkRequestCallback from releasing twice
By pass media player strict mode violation
|
|
This CL shows the voicemail error messages for both VVM and OMTP type voicemails. It hooks upto the existing error framework and retrieves the voicemail error states and then displays it.
Bug: 71700117
Test: Unit Tests
PiperOrigin-RevId: 183301455
Change-Id: Ib2b7fb957fbfd2af2227747d327cef466259eb6f
|
|
It is unclear from the docs or implementation what callbacks are invoked when the network is lost, or does the system release the callback for us somewhere else. In this CL VvmNetworkRequestCallback.releaseNetwork() will be guarded from calling twice, and log levels for callbacks are raised.
Bug: 64243619
Test: N/A, repro steps unknown.
PiperOrigin-RevId: 183298754
Change-Id: I5e589b2b59478b270890056fa08abb306ee1600c
|
|
The media player throws a strict mode violation when setting the data source and calling prepare async. This currently makes the voicemail fragment unusable since you can't play voicemails. I've added a todo to remove this in the future.
Test: N/A
PiperOrigin-RevId: 183298572
Change-Id: I821a700cc7e60d0bdde7ec4d7b543dfa7acaf274
|
|
* changes:
Explicitly disable strict mode during the assisted dialing action.
Set avatar as background instead of src.
|
|
Dialing is a critical path and there is no opportunity to perform
this action asynchronously.
Starting in P we could leverage the libphonenumber instance
that would live in PhoneGlobals and share that to warm up
the disk reads.
Bug: 70860471
Test: none. Unit tests do not trigger strict mode violations.
PiperOrigin-RevId: 183292426
Change-Id: I607c6af4d725272152f31e619367fdde5ed07302
|
|
Since we don't need background any more, setting avatar as background makes elevation work on the same view. So we don't need setOutlineProvider() which might provide a different outline to the image's.
Also fix an windowParams NPE.
Test: manual
PiperOrigin-RevId: 183289973
Change-Id: I452b3f2b66b1810839626f57449be7d10662f2c5
|
|
|
|
Test: N/A
PiperOrigin-RevId: 183278324
Change-Id: Ieec13543b67a09cc0475efb9e7210ca165884771
|
|
|
|
In some cases, we may revoke countries or make them
otherwise unavailable to assisted dialing.
In this case, we reset the preference back the the
default value, which is always the zeroth value.
Bug: 72322367
Test: new unit test
PiperOrigin-RevId: 183238476
Change-Id: Ib5cf200f6da04e332b6248b04057d5de0f64d01f
|
|
* changes:
Add skeleton for SpamPhoneLookup
Show Icon and label for blocked numbers
Bubble v2 a11y.
Add flag to enable NUI shortcut.
Rename "ApdlInfo" as "SpamInfo" in proto PhoneLookupInfo.
|
|
Bug: 70989534
Test: SpamPhoneLookupTest
PiperOrigin-RevId: 183174131
Change-Id: I46e819a0710ccce293195594e2f249e91d74551a
|
|
CallLogPhoto.getPhotoUri() returns a URI to a drawable so it will be easier to transition into glide. Meanwhile ContactPhotoManager will just show the drawable directly.
Bug: 70989547
Test: Unit tests
PiperOrigin-RevId: 183163818
Change-Id: I4ee4ff98782e35d2be03dfe14f8bf3dfd6ded074
|
|
- Set checkable for bubble buttons so the check status of non checkable button (back to call, end call) is not read.
- Add support for bottom action buttons.
Test: manual
PiperOrigin-RevId: 183150371
Change-Id: Ifae9c912ec923e8d2cda3146413138bd2eb94b47
|
|
Bug: 64655802
Test: n/a
PiperOrigin-RevId: 183149638
Change-Id: Idc58efced8f70311eccd67f403bc5bd98f3f8518
|
|
Bug: 70989534
Test: Existing tests
PiperOrigin-RevId: 183145910
Change-Id: I60b0122fb236a7e7ee7b746867c40fefe0a3b487
|
|
|
|
Bug: 72162360
Test: SpecialCharSequenceMgrTest, manual
PiperOrigin-RevId: 183138805
Change-Id: I57903a6b3bc30243e4f225d758d1ace550e8ab99
|
|
* changes:
Define methods in Spam interface to be used later in the PhoneLookup for spam features.
Link to the correct Assisted Dialing settings depending on platform version.
Add foreground service permission
Fixed a regression where we incorrectly reported that the dialpad was visible.
Add support for yesterday header in NUI Voicemail Tab
|
|
spam features.
Bug: 70989534
Test: ApdlSpamTest, InAppSpamTest
PiperOrigin-RevId: 183138320
Change-Id: I647568c31e234995f44d6cbeb2f97f73952db6bb
|
|
Bug: 72162646
Test: unit tests
PiperOrigin-RevId: 183134859
Change-Id: I73d3349f0ff33188cfe0a121b7737a57155683c7
|
|
Bug: 72116995
Test: built APK, verified permission
PiperOrigin-RevId: 183126225
Change-Id: I0889ea619a21413e510a7b58143c5011ed81b688
|
|
A request was made to update the value of #isDialpadVisible, in the process a
regression was introduced that would cause #isDialpadVisible to return true
when the dialpad's root view was null. This caused a NPE when we tried to
animate it.
We should now return the correct value in the scenarios important to our
partners as well our users and animations.
Bug: 64657832,72384544
Test: manual/logging
PiperOrigin-RevId: 183122628
Change-Id: I981e944dbb003064163b8ec11883dbc5381cba0e
|
|
Currently NUI only supports today and older, however we also need to support yesterday and be consistent with the call log.
Bug: 69858354,72331988
Test: Unit Tests
PiperOrigin-RevId: 183121631
Change-Id: Ica75164c28ee60a2f776287eefd7eed5db08e035
|
|
* changes:
Updated nearby places search permission icon for Material.
Updated call number by NW is not displayed
|
|
* changes:
Search no longer crashes if you don't have the contacts permission.
-Add cleaning blocked numbers stored in a separate database when people try to clean calllog database.
|
|
|
|
Bug: 68272797
Test: manual
PiperOrigin-RevId: 183023158
Change-Id: Iccee9278a89c944c443cb0d4022554ce7f634bab
|
|
CallCardPresenter updates a call number if the number is updated by NW.
But the logic is worng. The comparing numbers are always same. Because
it compares with the same objects in DialerCall#areSameNumber.
This is a upstream change from:
https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/556000
originating number is shown in the call screen.
Bug: 70201489
Test: manual - Verified that a call number that changed from a
PiperOrigin-RevId: 183022988
Change-Id: I04305998e77ca120b1248636c63984b3d20f0db1
|
|
Bug: 71737256
Test: NewSearchFragmentTest
PiperOrigin-RevId: 183020934
Change-Id: Ifed4364901ca77036fa6d0b149857fbbd7e9fca0
|
|
to clean calllog database.
Bug: 71898641,72104419
Test: On a local device.
PiperOrigin-RevId: 183016474
Change-Id: Ib59bf558d5552e9b88c3feee1c47d96791fd542c
|
|
We currently limit the size of AnnotatedCallLog to 999 via a trigger, but it doesn't exclude voicemails. Since we don't want to ever garbage collect the user's voicemails, exclude them from the trigger.
This means that we can no longer assume a maximum size for the table (the user culd have more than 999 voicemails) so I've updated the places in the code where we did that before.
Finally, I changed AnnotatedCallLog's CALL_TYPE column to be non-null. This is so that we can have more confidence that the trigger will work as intended. Null values cannot be compared in SQLite, so an expression like "where call_type != 4" won't actually match a null call type. Rather than implicitly fail to clean up such rows, we just crash completely when encountering such rows (even though I don't expect that to happen).
Bug: 70989634
Test: unit
PiperOrigin-RevId: 183006714
Change-Id: I9f4394a4812afe4b65c1e8427c355d825356557c
|
|
* changes:
Bubble bottom action changes.
Contacts recyclerview is now hidden when we don't have contacts permission.
Moved coalesced_ids.proto and number_attributes.proto to calllog/database/contract.
Write PhoneLookup results to PhoneLookupHistory in RealtimeRowProcessor.
Attempt to work around sqlite database cursor window issue
|
|
- Hide bottom action view when bubble move canceled
- Get display height every time when show bottom action view (onConfigurationChanged() won't be called when bubble is not visible)
Test: manual
PiperOrigin-RevId: 182979768
Change-Id: I989422c4ab5866b22c78bffbc82f229842a6dd9e
|
|
Bug: 71867982
Test: ContactsFragmentTest
PiperOrigin-RevId: 182977635
Change-Id: Ibdefc49c76dd607c5f1316ae46da5e38f74c0e85
|
|
calllog/database/contract.
The "model" package should be reserved for call history proper (and not voicemail) so it shouldn't contain things needed by voicemail.
Test: existing
PiperOrigin-RevId: 182976719
Change-Id: I463c8ed4600950a8d18db49d991609bfaa49c709
|
|
This is an optimization to reduce "popping" in the new call log. Since we have to do the PhoneLookup anyway to update the UI, we may as well write the result to PhoneLookupHistory so that the next time the AnnotatedCallLog is refreshed, the updated results can be retrieved from PhoneLookupHistory.
I also updated RealtimeRowProcessorTest to use FakePhoneLookup rather than the real Cp2PhoneLookup since RealtimeRowProcessor no longer uses Cp2PhoneLookup directly (it was updated to use the general-purpose PhoneLookup in a previous CL but I didn't update the test at that time).
Test: unit
PiperOrigin-RevId: 182974567
Change-Id: I813e9d69f802ca08757238290fdfcf58e78b3592
|
|
Bug: 72320869
Test: DialerDatabaseHelperTest
PiperOrigin-RevId: 182964251
Change-Id: Ie6539ce27bcbd97b093a47e1f5882770fc345e59
|
|
* changes:
Bubble change when display size change.
Update Assisted Dialing references.
Pressing back button twice really quickly no longer crashes dialer.
|
|
- Set primary button background oval and transparent.
- Provide outline for primary button since elevation doesn't work when background is transparent.
- Re-draw bubble on configuration changed to propagate changes.
Test: manual
PiperOrigin-RevId: 182949653
Change-Id: I71e70d6fa43fa5867f9cf37002930c5a8dc42b06
|
|
Test: existing unit tests
PiperOrigin-RevId: 182949031
Change-Id: I40955c6e5f4fe06687880d3e9ef4b91ef9c0b371
|
|
Bug: 72319656
Test: manual
PiperOrigin-RevId: 182947143
Change-Id: I70ed303ba8cdb64591ab6debf60eef540aacea73
|
|
|
|
All packages relating to NUI voicemail should be under third_party/java_src/android_app/dialer/java/com/android/dialer/voicemail/listui. Since there is a chance that during NUI development the legacy third_party/java_src/android_app/dialer/java/com/android/dialer/app/voicemail/error might undergo changes, it makes sense to move this package to the nui, so that no changes in the legacy code are missed for nui. This refactoring would also allow us to ensure that the strings do not need to be translated and that most of the code can be re-used for nui by hooking up the fragment and adapter to voicemail/listui/error.
Bug: 71700117
Test: Unit tests
PiperOrigin-RevId: 182868896
Change-Id: I23329654df5ce2bf612101708ed001ca308ae1ac
|
|
* changes:
Implement System blocked number
Don't let the FAB obscure the last item of speed dial/call log/voicemail.
Changed PhoneLookup#lookup to accept a DialerPhoneNumber.
For call log entry labels, remove the dot after abbreviated time units.
Implement blocking commands
|
|
This CL implements looking up blocked number in the Android system blocked number provider, which is available after N. Dialer and system blocked number will return empty if requirements are not made (N+ and migration completed is needed for system, otherwise dialer should not be used).
Bug: 70989543
Test: Unit tests
PiperOrigin-RevId: 182852672
Change-Id: I1360b7eed7c18f459292d769529ffcfceb61a7ed
|
|
Bug: 72235391
Test: Manual
PiperOrigin-RevId: 182848699
Change-Id: I587f5f4dd770278747114da17581c8fc253651c0
|
|
There's a problem with the existing implementation of RealtimeRowProcessor; when CP2 information is not present, data from other sources can potentially be erased.
This CL fixes the problem by fetching the latest data from all sources, instead of just CP2. This requires being able to fetch PhoneLookup info without a Call, using only a number, so I changed PhoneLookup#lookup to accept a DialerPhoneNumber rather than a Call.
(The reason that it accepted a Call was to support CNAP so we'll need a revised solution for that later.)
There is a potential concern with performance in RealtimeRowProcessor due to performing a full [Composite]PhoneLookup vs. a CP2 lookup, because the full lookup includes network requests. However, it's anticipated that the real time lookups will very rarely have changes to apply so this might be OK as-is. If not, a mitigation strategy could be improving the performance of CompositePhoneLookup#lookup by short-circutiing slower sources when faster, higher priority sources have already completed.
A follow-up CL will write the result of RealtimeRowProcessor queries to PhoneLookupHistory to further reduce how frequently real time updates need to be applied.
Bug: 72229553
Test: existing unit
PiperOrigin-RevId: 182839130
Change-Id: I8cb26827b4f4dc4702fb416234c8938179cd5ac5
|
|
The platform utility adds a dot after time units (e.g., "8 min. ago") but we prefer not to have it (e.g., "8 min ago").
Bug: 70989595
Test: CallLogDatesTest, CallLogEntryTextTest
PiperOrigin-RevId: 182838540
Change-Id: Ib8766a892aa04decb38917a6c5660804755725e0
|
|
Test: Unit tests
PiperOrigin-RevId: 182813080
Change-Id: I952f49352fb57c02c4efb9cc4ede84dc7c32c893
|
|
* changes:
Properly display date and/or time of entries in the new call log.
Add simulator enriched call related to interfaces and stubs.
|
|
Bug: 70989595
Test: CallLogDatesTest, CallLogEntryTextTest
PiperOrigin-RevId: 182809700
Change-Id: I84b699536ae7f77e6c27db0b1b008e3ebc6216c2
|