summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-10-25Improved dagger support for executor services.zachh
By always creating executor services via dagger, we can now bind special versions during espresso tests that can implement idling resources. We should be using idling resources during espresso tests for threads that we create ourselves, because espresso does not know about them. Hopefully this reduces some of the flakiness of espresso tests that we have today. This required converting all existing calls to DialerExecutors to pass a context used to fetch the component, and also required creating new application classes for espresso tests. Test: temporarily added a task which just slept to DialtactsActivity and verified that its integration test failed due to idling resource timeout PiperOrigin-RevId: 173334773 Change-Id: I876a93022d235d62cfc377bf5b06687e21a34758
2017-10-25Refactor client platform checks to be DRY.erfanian
It didn't sit well with me that we would check for platform eligibility in two places. Test: existing unit tests; PiperOrigin-RevId: 173334224 Change-Id: Ia7075bc40e935c2794646671b5cfea34b7a06afb
2017-10-24Merge "Rename the new bubble package name from "bubble" to "newbubble"."Treehugger Robot
2017-10-24Rename the new bubble package name from "bubble" to "newbubble".Eric Erfanian
It fixes AOSP for package name conflict. Test: manual PiperOrigin-RevId: 173298696 Change-Id: Id10ebe0bcf029e61f65cf6580c7198abd8395081
2017-10-19Merge changes I9a5b30d6,Ie9e7b741,I415f5b7e,I86e720b8,Ia8b7d508, ...maxwelb
am: 958b292fc0 Change-Id: Iaf76c729a8c2021b6a7d3cbccbeea4a9c2466aa0
2017-10-19Merge changes I9a5b30d6,Ie9e7b741,I415f5b7e,I86e720b8,Ia8b7d508, ...Treehugger Robot
* changes: Automated g4 rollback of changelist 172154863. Take into account special dialable characters when grouping calls in the call log UI. Move more Video Share stuff to third_party Fix NPE in TelecomAdapter.stopForegroundNotification(). wrapping %s in in <xliff:g> </xliff:g> tags to prevent translation Check AD eligibility before utilizing the feature.
2017-10-19Automated g4 rollback of changelist 172154863.maxwelb
*** Reason for rollback *** Causes crashes on rotation: http://b/67839843 *** Original change description *** Do not load every DialtactsActivity fragment on app open With this change we now only load the Favorites and Call Log Fragments when the app opens. Paging to the CallLogFragment makes the ContactsFragment load as we would want. This should result in a faster app start time. I'll need to verify the impact of this using the same method as http://cl/170422671 I verified the change in behavior by adding my own log line to the onCreate of each Fragment. I saw all of them get created before the ch... *** Bug: 64541209,65460373 Test: Manually verified regression fixed PiperOrigin-RevId: 172684553 Change-Id: I9a5b30d6619d930adfb82b19ac3ff9da00decaaa
2017-10-19Take into account special dialable characters when grouping calls in the ↵linyuh
call log UI. Currently we use PhoneNumberUtils#compare(String, String) to determine whether two numbers in the call log should be grouped. The method ignores special dialable characters such as "#", "*", "+", etc, which can cause phone numbers and service dialing numbers to be grouped. For example, suppose the user has a contact named "John Smith" with number 123456789 and a contact named "Service" with number #123456789, and called each contact once. The old grouping logic will put the two numbers in the same group. The new grouping logic in this CL can separate the two numbers. Bug: 30225112 Test: CallLogGroupBuilderTest, PhoneNumberHelperTest PiperOrigin-RevId: 172683494 Change-Id: Ie9e7b7418d6d7c74830cbae09c04ff1feb1b827d
2017-10-19Move more Video Share stuff to third_partyroldenburg
Bug: 36565933 Test: manual, just moving PiperOrigin-RevId: 172671853 Change-Id: I415f5b7e518cca22fad96b017a573322af3f73be
2017-10-19Fix NPE in TelecomAdapter.stopForegroundNotification().yueg
In InCallServiceImpl.tearDown(), we should only clear inCallService after InCallPresenter.tearDown() where we remove all notification. Also remove null assertion in stopForegroundNotification() since other crash should only happens when there is no notification. Test: StatusBarNotifierTest PiperOrigin-RevId: 172657924 Change-Id: I86e720b80f885aa93f12215fda899ee62eeaba5b
2017-10-19wrapping %s in in <xliff:g> </xliff:g> tags to prevent translationmdooley
Bug: 67322107 Test: manual PiperOrigin-RevId: 172656296 Change-Id: Ia8b7d508ef35ff0091b762c28e1091af60ce15b4
2017-10-19Check AD eligibility before utilizing the feature.erfanian
Bug: 67914094 Test: unit tests PiperOrigin-RevId: 172650441 Change-Id: Ie7df3174a07df2de3a102fb70a126004f704b22f
2017-10-18Merge "Support bulk inserted voicemails."twyen
am: 5cb3ecff08 Change-Id: I0da752b47176d1da7c329fe082dde69ec98074a3
2017-10-18Merge "Support bulk inserted voicemails."Treehugger Robot
2017-10-18Merge "Fix top text cropping issue in new voicemail tab"uabdullah
am: 7a168cbe00 Change-Id: I60d8f4de722cd6e255995dff236f23e9c29b2cda
2017-10-18Merge "Fix top text cropping issue in new voicemail tab"Treehugger Robot
2017-10-18Merge changes Ib92b055d,I5c9f66ffcalderwoodra
am: 4b46ec2258 Change-Id: I8cbfb88558d46cbdd3ed696b56774913d1839a78
2017-10-18Merge changes Ibc853aa4,I061e3b45,I31983153maxwelb
am: 96a2f8ec01 Change-Id: I5d81a2fb1b6c3fcdfadfa8eeb4b06b951534b68b
2017-10-18Merge changes Ib92b055d,I5c9f66ffTreehugger Robot
* changes: Update SearchAdapter query if fragment has query before fragment is ready. Contacts are now searchable by company name.
2017-10-18Merge changes Ibc853aa4,I061e3b45,I31983153Treehugger Robot
* changes: Update simulator to add emergency call Allow voicemail transcription notifications to expand Hide voice search button when exiting search if it is not available
2017-10-17Support bulk inserted voicemails.twyen
Bulk insert is implemented in ag/3073902 When more than one voicemail is inserted into the VoicemailProvider, the URI type is Voicemails.DIR_TYPE instead of ITEM_TYPE. This CL adds support to the new type. Previously when multiple voicemails are being notified, each one of them will generate a ringtone because the notifiction is set to alert children. In this CL, the summary will have alert instead, and will only alert when new voicemails are received. Bug: 21281858 Test: VisualVoicemailNotifierTest PiperOrigin-RevId: 172546076 Change-Id: I4df6098fc3a793139e3d4e77fe1339efdc001944
2017-10-17Fix top text cropping issue in new voicemail tabuabdullah
The numbers used to be cropped (http://screen/YYBG8T0Ma0J). We've fixed that issue in this CL and also removed the term "call_log" from the file name. Screenshot: http://screen/uHCPwf5smVX Bug: 64882313 Test: N/A PiperOrigin-RevId: 172541833 Change-Id: Ib2746b38284c2c04c84ab369d449412d8a9880b4
2017-10-17Update SearchAdapter query if fragment has query before fragment is ready.calderwoodra
If a user made a search using the voice/mic icon, the search results weren't being applied to on device contacts because SearchAdapter wasn't receiving the query. Bug: 67633975 Test: manual PiperOrigin-RevId: 172540423 Change-Id: Ib92b055dddf4e4fbdf88eadd62583bf1bac32055
2017-10-17Contacts are now searchable by company name.calderwoodra
This change coalesces Cp2 contacts into a new cursor so that they can be associated with the Company name. The following logs can help explain how the data is organizes in the original cursor: display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/name), data1 (A Pixel) display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/note), data1 () display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/group_membership), data1 (1) display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/phone_v2), data1 (+1 650-200-7932) display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/phone_v2), data1 (+1 540-555-6666) display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/organization), data1 (Walmart) This is an example of what is returned for a single contact. We can easily associate contact rows together using the lookup key and determine which rows have relevant data by checking the mime type. I use the data here to coalesce the contacts together into one row for easy parsing in ContactFilterCursor. Rows with mime type phone_v2 contain contact information (for example, this contact has 2 phone numbers). Rows with mime type organization contain contact's company information (for example, this contact works at Walmart). Bug: 67675742,64894607,67848713 Test: existing + SCCT.filter_companyName PiperOrigin-RevId: 172528797 Change-Id: I5c9f66ff0c27276869295eff97bb0216f92995be
2017-10-17Update simulator to add emergency callmaxwelb
Test: Manual :/ PiperOrigin-RevId: 172521778 Change-Id: Ibc853aa429d61c13a43b56411fb00a0fcb38795f
2017-10-17Allow voicemail transcription notifications to expandmdooley
Bug: 67430264 Test: manual PiperOrigin-RevId: 172520128 Change-Id: I061e3b45599e1c14be387713e63f6fdeae367be4
2017-10-17Hide voice search button when exiting search if it is not availabletwyen
Bug: 67820772 Test: DialtactsActivityIntegrationTest PiperOrigin-RevId: 172519580 Change-Id: I31983153cedb24c436cbaeef69fe6a2f4e558c65
2017-10-18Merge changes Ida554313,Ie7187b02,I7a7c23b4linyuh
am: ef7a7eb0f1 Change-Id: Ief66221a645aa90569c9f9cb5c7838d7122a501a
2017-10-18Merge changes Ida554313,Ie7187b02,I7a7c23b4Treehugger Robot
* changes: Stop showing partially matched numbers that are not global phone numbers. Display Voicemail Contact Name and Photo in Voicemail Fragment. Add temporary assisted dialing setting to Dialer.
2017-10-17Stop showing partially matched numbers that are not global phone numbers.linyuh
When determining whether two phone numbers are identical enough for caller ID purposes, the Contacts Provider ignores special dialable characters such as '#', '*', '+', etc. This makes it possible for the cursor returned by the Contacts Provider to have multiple rows even when the URI asks for a specific number. For example, suppose the user has two contacts whose numbers are "#123" and "123", respectively. When the URI asks for number "123", both numbers will be returned. Therefore, the following strategy is employed to find a match. If the cursor points to a global phone number (i.e., a number that can be accepted by PhoneNumberUtils#isGlobalPhoneNumber(String)) and the lookup number in the URI is a PARTIAL match, the cursor is a match. If the cursor points to a number that is not a global phone number, the cursor is a match iff the lookup number in the URI is an EXACT match. There is no matched cursor in all other circumstances. UI demo: Suppose the user has a contact named "Service1" with number "#123". Before: Incall UI after the user dials "123": https://photos.app.goo.gl/xFWCD4qy2VR3YEuJ2 Call log UI after the call ends: https://photos.app.goo.gl/FT28GdTBy1dtANtI2 After: Incall UI after the user dials "123": https://photos.app.goo.gl/Io3BisQmsyfnvitV2 Call log UI after the call ends: https://photos.app.goo.gl/6GgRrmx75yUTga3B3 Bug: 30225112 Test: PhoneNumberHelperTest PiperOrigin-RevId: 172505648 Change-Id: Ida554313455ff9ce40432897681f89f58d64af04
2017-10-17Display Voicemail Contact Name and Photo in Voicemail Fragment.uabdullah
This CL lays the foundation of querying the annotated call log, retrieving only the voicemail entries and some of the voicemail information in the Voicemail tab. This CL only displays the name/number as well as the corresponding photo of the voicemails present on the device. WANT_LGTM=zachh SCREENSHOT: http://screen/YYBG8T0Ma0J Bug: 33006245, 64882313 Test: Unit tests and manual verification. PiperOrigin-RevId: 172504512 Change-Id: Ie7187b021abf42d1a4522458a1ab28537a7c222c
2017-10-17Add temporary assisted dialing setting to Dialer.Eric Erfanian
Bug: 63994464 Test: integration test PiperOrigin-RevId: 172499750 Change-Id: I7a7c23b403f649c1bbec0bb068e1285e02fddd22
2017-10-17Merge "Some cleanup of incoming call latency."wangqi
am: c2590357cf Change-Id: I6c792917ea790010c415a86a9f3389eadad4ab99
2017-10-17Merge "Some cleanup of incoming call latency."Treehugger Robot
2017-10-17Some cleanup of incoming call latency.wangqi
1. Only update secondary info when it's changed. 2. Removed redundant call to update notification on activity start (b/36649622) 3. Use same call back for notification update from contact info query to avoid duplicated call backs. The actual latency reduction is insignificant (<10%). Bug: 36649622,64542087 Test: manual PiperOrigin-RevId: 172475223 Change-Id: I1c91cb5715287991de774a1d9b95e4c8b722d28f
2017-10-17Merge changes I84ec0ac5,I2b92e1e0,Ic30fa6c6roldenburg
am: 0d1362b28a Change-Id: I0f432016615a87e8c02075b17b2b724c1f4b1481
2017-10-17Merge changes I84ec0ac5,I2b92e1e0,Ic30fa6c6Treehugger Robot
* changes: Move Duo related constants out of interface Dismissing location prompt now actually prevents it from reshowing. Add GSM conference calling to simulator.
2017-10-17Move Duo related constants out of interfaceroldenburg
Fixed notifying for Duo missed calls using the new constants to check if a call is a Duo call. Bug: 66946794 Test: existing tests, manual PiperOrigin-RevId: 172400311 Change-Id: I84ec0ac5c933cf1aec68b6d1f422c2effe6b69ec
2017-10-17Dismissing location prompt now actually prevents it from reshowing.calderwoodra
Bug: 67709163 Test: NewSearchFragmentTest PiperOrigin-RevId: 172378559 Change-Id: I2b92e1e06057a57638d23a333d04239b2e288bc1
2017-10-17Add GSM conference calling to simulator.yueg
This CL adds a new item to the simulator menu: - Add GSM conference The GSM conference action creates a conference with 5 phone calls. Users can individually separate or kick calls out of the conference. Hanging up the second last call finishes the conference. Bug: 67785540 Test: SimulatorConferenceTest PiperOrigin-RevId: 172377631 Change-Id: Ic30fa6c65cf782247f75bcdd1ecbd86b1c16f143
2017-10-17Merge changes Iab543850,I305f8a0eAndroid Dialer
am: 5a6cb962ae Change-Id: I82c93bbdcf35d08495987aec98a01cfea62c3f7c
2017-10-17Merge "Finish AudioRouteSelectorActivity in onAudioRouteSelected."yueg
am: 6c40b97de1 Change-Id: I899eb542362b22680356adb006d1159c95f5d0f4
2017-10-16Merge changes Iab543850,I305f8a0eTreehugger Robot
* changes: Keep promo state on rotate FAB is no longer visible on return to call dialog.
2017-10-16Merge "Finish AudioRouteSelectorActivity in onAudioRouteSelected."Treehugger Robot
2017-10-16Keep promo state on rotateAndroid Dialer
Promo was being collapsed because rotate causes list to be scrolled at IDLE state. Make the drag more explicit by including the fastScroller drag state instead manually verified fast scrolling still minimizes promo and rotating while promo is expanded keeps it expanded Bug: 67670326 Test: ContactsPromoFragmentTest PiperOrigin-RevId: 172352966 Change-Id: Iab5438501db1d54b7ffac3339faecde0256a3632
2017-10-16FAB is no longer visible on return to call dialog.calderwoodra
Bug: 67419607 Test: manual PiperOrigin-RevId: 172349180 Change-Id: I305f8a0e5ae90b2e5e8f77772edfb0b973aca096
2017-10-16Finish AudioRouteSelectorActivity in onAudioRouteSelected.yueg
In previous change, we use AudioRouteSelectorDialogFragment.onCancel() instead of onDismiss(). And selecting an item only calls onDismiss() instead of onCancel(), so the activity is not finished. In this change we finish the activity when an item is selected. Test: manual PiperOrigin-RevId: 172342660 Change-Id: I2d34874ae9e1a7e5ad858b4f1ba855b48647d995
2017-10-16Merge "Rename Lightbringer to Duo"roldenburg
am: a682c9208f Change-Id: Ia8a49e8bd9c398e5ad96a8efb2d114c16bf0cc77
2017-10-16Merge "Rename Lightbringer to Duo"Treehugger Robot
2017-10-16Rename Lightbringer to Duoroldenburg
Now that our Duo integration is public, we no longer need a code name. To avoid any disruption, logging and config related names were not changed. Bug: 63753964 Test: manual, existing tests PiperOrigin-RevId: 172172738 Change-Id: Ib9d3d80761944d850c8c4886def9fef9a28539a4
2017-10-15Merge changes If86250b1,Ib2a01013zachh
am: 4114f539e7 Change-Id: I7db988c15ae33c9335a534ed103f11aa437f3bfc
2017-10-15Merge "Bug fixes for new search ui w/ Dialpad."calderwoodra
am: f09b9f8f65 Change-Id: I7454b7935316e7110391736c616368df33669cbe
2017-10-15Merge changes Iaf6e217d,Ib22e33de,If9fd6ca9roldenburg
am: 65aa3b3677 Change-Id: I8fbd63b32623a3cd7cc35051aaa110c88a8b2313
2017-10-15Merge "Use CONTENT_URI_WITH_VOICEMAIL for SystemCallLogDataSource"uabdullah
am: 5fb96c9646 Change-Id: I79f55ac7c3eefccbdd9334e53185d7ed82978115
2017-10-15Merge "Set the secondary action to be a voice call when the primary action ↵linyuh
is a video call." am: cf83cae3d3 Change-Id: I7a6ee2444a1a623875536bc74309a0577d9ad983
2017-10-14Merge changes If86250b1,Ib2a01013Treehugger Robot
* changes: Fixed crash which occurred when clearing call log containing enriched call data. Add config provider value for dynamic locales for assisted dialing.
2017-10-14Merge "Bug fixes for new search ui w/ Dialpad."Treehugger Robot
2017-10-13Fixed crash which occurred when clearing call log containing enriched call data.zachh
There was a race where the dialog could sometimes get detached before the success callback finished. The callback would attempt to show a snackbar using [fragment.]getString(), which throws when the fragment is detached. The fix is to just use the activity to get the string (which has already been asserted to be valid). Bug: 65968151 Test: unit PiperOrigin-RevId: 172169503 Change-Id: If86250b14038958e6668b26d1f150619fe3eefae
2017-10-13Add config provider value for dynamic locales for assisted dialing.erfanian
This is a dialer only feature and will not be available in the framework. Test: unit tests. PiperOrigin-RevId: 172166023 Change-Id: Ib2a0101386a9d892dab87c7c4fb8d4728d8c55f0
2017-10-13Bug fixes for new search ui w/ Dialpad.calderwoodra
- Dialpad now hides if user tries to scroll w/ a search query. - Search now closes if the user touches the blank area w/o a search query. - Since we don't even show location results in dialpad search, we no longer request location permission in it. Bug: 67657783,67656915 Test: tba PiperOrigin-RevId: 172162620 Change-Id: I33a814797a053600e56fb163fd55b0c43e00a9c6
2017-10-14Merge changes Iaf6e217d,Ib22e33de,If9fd6ca9Treehugger Robot
* changes: Do not load every DialtactsActivity fragment on app open Enable Lightbringer upgrades on M Fixing voicemail notification bug
2017-10-13Do not load every DialtactsActivity fragment on app openroldenburg
With this change we now only load the Favorites and Call Log Fragments when the app opens. Paging to the CallLogFragment makes the ContactsFragment load as we would want. This should result in a faster app start time. I'll need to verify the impact of this using the same method as http://cl/170422671 I verified the change in behavior by adding my own log line to the onCreate of each Fragment. I saw all of them get created before the change, and only the expected 2 with this change. Bug: 64541209,65460373 Test: manual PiperOrigin-RevId: 172154863 Change-Id: Iaf6e217df284e6df6f13688ac6aa677481a575e0
2017-10-13Enable Lightbringer upgrades on Mroldenburg
Test: existing tests, manual (tested on Nexus 6 running M) PiperOrigin-RevId: 172122858 Change-Id: Ib22e33de3ed134cf76a06af54d054dbb92f91039
2017-10-13Fixing voicemail notification bugmdooley
Added a check for null notification tags when updating voicemail notifications. Bug: 67607115 Test: manual and unit test PiperOrigin-RevId: 172121860 Change-Id: If9fd6ca972a5a1dbd48a9c529f3cb46c3c93fa2a
2017-10-13Merge "Use CONTENT_URI_WITH_VOICEMAIL for SystemCallLogDataSource"Treehugger Robot
2017-10-13Use CONTENT_URI_WITH_VOICEMAIL for SystemCallLogDataSourceuabdullah
Currently the SystemCallLogDataSource queries the call log table with CONTENT_URI. This works for the call log tab, but will not work for the voicemail tab. To allow the voicemail tab to query annotated call log for voicemail information, we need to surface up voicemail data from the system call log data source into the annotated call log. Bug: 64882313,33006245 Test: Unit tests, also verified that in the call log only the non-voicemail entries show PiperOrigin-RevId: 172036196 Change-Id: Ieac855ae854a043207c9ae668280391c790ac33d
2017-10-13Merge "Set the secondary action to be a voice call when the primary action ↵Treehugger Robot
is a video call."
2017-10-12Merge changes I14a2c0b6,Ic67566c2,Id0ef9164,Iec48f030,Ibe1f9de6, ...twyen
am: 5f57e30484 Change-Id: Iabe5ea0bad0851164161c3552ee5354789292e83
2017-10-12Set the secondary action to be a voice call when the primary action is a ↵linyuh
video call. Bug: 67717800 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 172013208 Change-Id: I86c4ca1ef7caf1899cb9587d98233a9e707b7f3d
2017-10-12Merge changes I14a2c0b6,Ic67566c2,Id0ef9164,Iec48f030,Ibe1f9de6, ...Treehugger Robot
* changes: Handle invalid PhoneAccountHandle component name in MissedCallNotifier Use TelephonyManagerCompat for IS_REFRESH Updated animation to enter and exit search ui. Optimization for incoming call latency. Fix for voice screen showing for a short time when making a video call Fix incallui to use latest ux mocks for assisted dialing. Remove voicemail count changed check for legacy notifications
2017-10-12Handle invalid PhoneAccountHandle component name in MissedCallNotifiertwyen
Bug: 66946794 Test: MissedCallNotifierTest PiperOrigin-RevId: 172007792 Change-Id: I14a2c0b6a5ad5a5b8acd449214c91bff68282b6a
2017-10-12Use TelephonyManagerCompat for IS_REFRESHtwyen
Bug: 66633426 Test: LegacyVoicemailNotificationReceiverTest PiperOrigin-RevId: 172007744 Change-Id: Ic67566c22659b51d605c92d2673f9baddaee531f
2017-10-12Updated animation to enter and exit search ui.calderwoodra
video: https://drive.google.com/open?id=0B2Hce9qilHmvZkREWm1BMURJNjQ Bug: 67635181 Test: n/a PiperOrigin-RevId: 171928416 Change-Id: Id0ef91647ec15ea970a691b1ae896010a12e6bb8
2017-10-12Optimization for incoming call latency.wangqi
There are many binder call triggered by IPC on main thread. This change will try to reduce them by caching thing that's bound to a call. It reduce total binder transaction from 1002 to 664 and saves ~11% latency of incoming call on locked screen. 1. Cache isVoiceMailNumber in DialerCall 2. Cache call capable accounts in DialerCall 3. Cache current country iso in DialerCall 4. Don't set orientation change if it's not changed. This change also add lots of trace info. It won't affect release build though since they are stripped out by proguard. Bug: 64542087 Test: manual PiperOrigin-RevId: 171901266 Change-Id: Iec48f030529aa59974212147276f6d0ae121872a
2017-10-12Fix for voice screen showing for a short time when making a video callroldenburg
Author: tomoyuki.nishikawa@sony.com This change was inspired by http://aosp/508735 Even though VideoProfile.isVideo(getVideoState() returns true when starting a video call, ImsVideoTech is not ready until call.getVideoCall() returns not null (see https://android.googlesource.com/platform/packages/apps/Dialer/+/master/java/com/android/incallui/videotech/ims/ImsVideoTech.java#66) During the time between VideoProfile.isVideo(getVideoState() being true but call.getVideoCall() returning null, we are incorrectly showing the phone call UI instead of the video call UI. To fix this, we need to trust the VideoProfile check in addition to the VideoTech check. We still need to check VideoTech for other video options aside from just IMS VT. Bug: 67712159 Test: manual PiperOrigin-RevId: 171892356 Change-Id: Ibe1f9de60aaa4adc971401bee0277961cfe037e4
2017-10-12Fix incallui to use latest ux mocks for assisted dialing.erfanian
* Remove old language icon from bottom row. Screenshot=In change as scuba test Bug: 64205446 Test: new unit tests PiperOrigin-RevId: 171858076 Change-Id: Idf781be193dae3593f778af1ac833f046abd87e3
2017-10-12Remove voicemail count changed check for legacy notificationstwyen
Previously before showing a voicemail notification dialer checks if the count has changed to avoid showing duplicated notifications. With the dismissed flag in place the count changed check is redundant, and it prevents the notification to reshow after reboot. Also updated the EXTRA_IS_REFRESH to use the O_MR public version. Bug: 66633426 Test: LegacyVoicemailNotificationReceiverTest PiperOrigin-RevId: 171760393 Change-Id: I508b8f42a44fd849ab7c8ca6fe9d4e7e8a38b1c7
2017-10-12Merge "Added basic bottom sheet to new call log."Zachary Heidepriem
am: 2633778c27 Change-Id: Id6b9f75c0cf3c42b28a0c44d75c10d9c80853936
2017-10-12Merge "Added basic bottom sheet to new call log."Treehugger Robot
2017-10-11Added basic bottom sheet to new call log.Zachary Heidepriem
Also added ability to click on row to call. Required plumbing through the original phone number and phone account info through AnnotatedCallLog and CoalescedAnnotatedCallLog, so that clicking to dial doesn't require an additional lookup. Required some refactoring: -created autovalue for CoalescedRow. -created autovalue for ContactPrimaryActionInfo and use it in ContactActionBottomSheet -moved logic for building primary and secondary text into CallLogUtils so it can be shared between call log list and bottom sheets -moved clipboard logic to own package for copying numbers Bug: 34672501 Test: unit PiperOrigin-RevId: 171760252 Change-Id: I645d89974460b611c1d9668c3ca3e50a716c7f8f
2017-10-11Merge changes Ie12fd2f4,If92e7595maxwelb
am: c3409a7f7a Change-Id: Ia576ff6bf2afeaf8d27caa171909d2e16415358d
2017-10-11Merge changes Ie12fd2f4,If92e7595Treehugger Robot
* changes: Handle race condition with CallComposerActivity.onBackPressed Skeleton implementation of PhoneLookup and Cp2PhoneLookup.
2017-10-11Merge changes If11b88a0,I34444857,Ie64f7daamdooley
am: 252fed4f12 Change-Id: Ic83fd8eedd79bc9d6021416bb9960425e265006c
2017-10-11Merge changes If11b88a0,I34444857,Ie64f7daaTreehugger Robot
* changes: Change voicemail transcription progress string Ignore self-manged calls for missed call notification Remove period from location request string.
2017-10-11Merge changes Idb3f486e,I534e1d22twyen
am: 38e05b7d25 Change-Id: Iaee335fe5fef57a4435899c6d3e68d2683549335
2017-10-11Merge changes Idb3f486e,I534e1d22Treehugger Robot
* changes: Implement SIM swapping Set an appropriate icon for the call detail UI's callback button.
2017-10-11Handle race condition with CallComposerActivity.onBackPressedmaxwelb
For fast users/testing suites, it's possible to hit a race condition where onBackPressed is called multiple times in a way that allows the second call to endCallComposerSession to happen and crash. This CL fixes the issue by checking that the session still exists prior to calling endCallComposerSession. I tried to write tests for this, but since the code guards against this from happening, I wasn't able to get the code into a situation to cause the crash. Bug: 64136293 Test: none PiperOrigin-RevId: 171758119 Change-Id: Ie12fd2f4390329b9bebb503fa3cf0f26d3bc1caf
2017-10-11Skeleton implementation of PhoneLookup and Cp2PhoneLookup.calderwoodra
Bug: 67605130 Test: Cp2PhoneLookupTest PiperOrigin-RevId: 171757865 Change-Id: If92e759567456dda09a925e9c625df001f2d573f
2017-10-11Change voicemail transcription progress stringmdooley
screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuIdVZ2dE44MzNUZ2pkdUY5ZVdycHp0R1ZsLUtZ Bug: 67634990 Test: manual PiperOrigin-RevId: 171757382 Change-Id: If11b88a0682e5da9454238fa19fb78972115fb23
2017-10-11Ignore self-manged calls for missed call notificationtwyen
If a PhoneAccount declared it is CAPABILITY_SELF_MANAGED, it should handle the in call UI and notifications itself, but might still write to call log with EXTRA_LOG_SELF_MANAGED_CALLS}. Bug: 66946794 Test: MissedCallNotifierTest PiperOrigin-RevId: 171727177 Change-Id: I34444857d432d6bb72983c0ba919bcfef885192b
2017-10-11Remove period from location request string.calderwoodra
Bug: 67635072 Test: n/a PiperOrigin-RevId: 171720799 Change-Id: Ie64f7daa071986b23653876172011d4f2343fc69
2017-10-11Implement SIM swappingtwyen
When the call is still ringing, a new button is added to allow to user to call with the other SIM. A background worker will be created to hang up the phone and redial with the other SIM. The in call UI will be prevented from ending during the process. Video: https://drive.google.com/a/google.com/file/d/0B2eYBUUznfyTSl9MdXQ0V1ZzQkE/view?usp=sharing UX has not been finalized, the icon and position are just placeholder. Bug: 64215256 Test: SwapSimWorkerTest PiperOrigin-RevId: 171715715 Change-Id: Idb3f486e9fc9a45d4c5e244af2d7d91b075bf0f2
2017-10-11Set an appropriate icon for the call detail UI's callback button.linyuh
cl/170943038 groups calls in the call log according to their corresponding actions (Lightbringer, IMS, and voice). This way calls in the call detail UI are in the same category and an appropriate icon can be set. Bug: 66026167 Test: CallDetailsActivityTest.callbackButtonLoggedForLightbringerCall, CallDetailsActivityTest.callbackButtonLoggedForVideoCall, CallDetailsActivityTest.callbackButtonLoggedForVoiceCall PiperOrigin-RevId: 171703514 Change-Id: I534e1d22f1355f261105a6bde74285403fc9ed87
2017-10-10Merge "Hide the text view showing call type or location when assisted ↵Android Dialer
dialing is supported." am: 5a0a312336 Change-Id: I9d550defdd0c0f410cc0f2a14979bf6161d614c2
2017-10-10Merge "Hide the text view showing call type or location when assisted ↵Treehugger Robot
dialing is supported."
2017-10-10Merge "Improved FAB UX."calderwoodra
am: 29bb4a8400 Change-Id: I8d2958e850263aa1579c94cba61b5b0cf334725d
2017-10-10Merge "Improved FAB UX."Treehugger Robot
2017-10-10Merge changes Id8170206,I4e63ef1d,I05e176efAndroid Dialer
am: 21de509b13 Change-Id: Ief68ccf2c2618323f914bf1e8f462dd0a2a58253
2017-10-10Merge changes Id8170206,I4e63ef1d,I05e176efTreehugger Robot
* changes: Group calls in the call log according to their corresponding actions. Add assisted dialing to outbound calls that qualify. Show "Incoming video call" instead of "Incoming call" for ViLTE notification.
2017-10-10Hide the text view showing call type or location when assisted dialing is ↵Android Dialer
supported. Test: manual PiperOrigin-RevId: 171610298 Change-Id: I12ca284927603804b8761db695d35a1c79fa93f3
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-07 12:35:18 +0000