Age | Commit message (Collapse) | Author |
|
For fast users/testing suites, it's possible to hit a race condition
where onBackPressed is called multiple times in a way that allows the
second call to endCallComposerSession to happen and crash.
This CL fixes the issue by checking that the session still exists prior
to calling endCallComposerSession.
I tried to write tests for this, but since the code guards against this
from happening, I wasn't able to get the code into a situation to cause
the crash.
Bug: 64136293
Test: none
PiperOrigin-RevId: 171758119
Change-Id: Ie12fd2f4390329b9bebb503fa3cf0f26d3bc1caf
|
|
Bug: 67605130
Test: Cp2PhoneLookupTest
PiperOrigin-RevId: 171757865
Change-Id: If92e759567456dda09a925e9c625df001f2d573f
|
|
screenshot:
https://drive.google.com/open?id=0B9o_KvtLkcuIdVZ2dE44MzNUZ2pkdUY5ZVdycHp0R1ZsLUtZ
Bug: 67634990
Test: manual
PiperOrigin-RevId: 171757382
Change-Id: If11b88a0682e5da9454238fa19fb78972115fb23
|
|
If a PhoneAccount declared it is CAPABILITY_SELF_MANAGED, it should handle the in call UI and notifications itself, but might still write to call log with EXTRA_LOG_SELF_MANAGED_CALLS}.
Bug: 66946794
Test: MissedCallNotifierTest
PiperOrigin-RevId: 171727177
Change-Id: I34444857d432d6bb72983c0ba919bcfef885192b
|
|
Bug: 67635072
Test: n/a
PiperOrigin-RevId: 171720799
Change-Id: Ie64f7daa071986b23653876172011d4f2343fc69
|
|
When the call is still ringing, a new button is added to allow to user to call with the other SIM. A background worker will be created to hang up the phone and redial with the other SIM. The in call UI will be prevented from ending during the process.
Video: https://drive.google.com/a/google.com/file/d/0B2eYBUUznfyTSl9MdXQ0V1ZzQkE/view?usp=sharing
UX has not been finalized, the icon and position are just placeholder.
Bug: 64215256
Test: SwapSimWorkerTest
PiperOrigin-RevId: 171715715
Change-Id: Idb3f486e9fc9a45d4c5e244af2d7d91b075bf0f2
|
|
cl/170943038 groups calls in the call log according to their corresponding actions (Lightbringer, IMS, and voice). This way calls in the call detail UI are in the same category and an appropriate icon can be set.
Bug: 66026167
Test: CallDetailsActivityTest.callbackButtonLoggedForLightbringerCall, CallDetailsActivityTest.callbackButtonLoggedForVideoCall, CallDetailsActivityTest.callbackButtonLoggedForVoiceCall
PiperOrigin-RevId: 171703514
Change-Id: I534e1d22f1355f261105a6bde74285403fc9ed87
|
|
dialing is supported."
am: 5a0a312336
Change-Id: I9d550defdd0c0f410cc0f2a14979bf6161d614c2
|
|
dialing is supported."
|
|
am: 29bb4a8400
Change-Id: I8d2958e850263aa1579c94cba61b5b0cf334725d
|
|
|
|
am: 21de509b13
Change-Id: Ief68ccf2c2618323f914bf1e8f462dd0a2a58253
|
|
* changes:
Group calls in the call log according to their corresponding actions.
Add assisted dialing to outbound calls that qualify.
Show "Incoming video call" instead of "Incoming call" for ViLTE notification.
|
|
supported.
Test: manual
PiperOrigin-RevId: 171610298
Change-Id: I12ca284927603804b8761db695d35a1c79fa93f3
|
|
One of the biggest issues with the FAB is that it doesn't
scale in/out properly. It looked more like setVisibility was
being called instead. This CL migrates the FAB controller to
use the built in scale in/out methods #show and #hide and the
animation is much nicer.
Some of the other issues were:
- Now scaling animation is correct and visible.
- No longer flashes when going in/out of search.
- No longer shows on top of the return to call controller.
- No longer bugs when switching between VVM TOS and contacts.
- No longer shows FAB over VVM TOS when entering/exiting search
Bug: 62588192,35359563,64116334,27458212,37991480,67419607
Test: manual
PiperOrigin-RevId: 171608105
Change-Id: I9b3f61df35abf3659a432adf411b1b7d20eba683
|
|
Currently different types of calls can be grouped together (e.g., 1 voice call and 1 IMS call to/from the same number), which makes it difficult to choose the icon for the call detail UI's call back button.
This CL adds an extra constraint that separates different call types (Lightbringer, IMS, and voice). This way calls in the call detail UI are in the same category and an appropriate icon can be set.
Bug: 66026167
Test: CallLogGroupBuilderTest.addGroups_MixedEntries_PartiallyGroupedByAction
PiperOrigin-RevId: 171602617
Change-Id: Id8170206009ba836a40c38a86914c71d5c7701dc
|
|
* Add missing assisted dialing to calls from contacts in the call log.
* Add missing assisted dialing to calls from dialpad and normal search.
Bug: 63995025,63995261
Test: unit test
PiperOrigin-RevId: 171593967
Change-Id: I4e63ef1dcd7ee1b2b5cbb8ecb4d8da744d90bd66
|
|
Test: StatusBarNotifierTest
PiperOrigin-RevId: 171588023
Change-Id: I05e176ef1032da00c4b75a83e92f39e8293d598e
|
|
am: 589db3a4b3
Change-Id: I36fd15a3ccf7fb43019f40519fbae58ae9f8cfa0
|
|
|
|
Tracking bug to fix the refactoring: http://b/67512378
Bug: 67470678
Test: manual
PiperOrigin-RevId: 171553078
Change-Id: Ib83e4240d6024347f97d246f9b526c3ccbf02057
|
|
am: 63e639710c
Change-Id: Id35d7483f8d28dd05d39742d648c5075f8f4b3c1
|
|
|
|
When any locks are acquired, the InCallActivity will not auto-finish when there are no active calls. The disconnected cause and reject with SMS dialogs are migrated to use this API, which prevents the activity form ending before the user has finished interacting with the dialogs.
Bug: 64215256
Test: InCallPresenterTest
PiperOrigin-RevId: 171362338
Change-Id: Ied07ebbf6bee056ea6b2314c57f3324561b1651a
|
|
am: 30842b2099
Change-Id: Ia603717089816e10f1603b1671a7253019952f83
|
|
am: 087329e925
Change-Id: Ib5b5b782cdbd1867491d2098df22338c8d89dab6
|
|
* changes:
Adding Future method for DialerPhoneNumberUtil
Show on hold in management screen for conference call.
Allow for multi-line transcription error messages
|
|
|
|
This CL adds a method to DialerPhoneNumberUtil which returns a Future
holding the result of parsing a number into the DialerPhoneNumber proto.
This will be used in the APDL integration as it will use Futures as
well.
The CL also changes DialerExecutors.lowPriorityThreadPool to be an
ExecutorService instead of an Executor (the super type) so it can be
used in MoreExecutors.listeningDecorator.
Test: TAP
PiperOrigin-RevId: 171347542
Change-Id: I620aacf3304d625f57af6d2b89a36f11b44008dd
|
|
Do the following when a participant is on hold:
- Add "On hold • " in front of the number
- Gray out avatar and text (contact name & number)
Notice:
We only have the on hold state information for VoLTE conference call and IMS conference call. So the change only works for them (not for GSM/CDMA conference call).
Test: ConferenceManagerPresenterTest
PiperOrigin-RevId: 171345423
Change-Id: Ie5fe2fc1097f4858604283989dcb916c2ac21972
|
|
QA noticed that the error message 'Transcription not available. Unsupported language'
didnt fit on one line and got truncated. This cl removes the single line constraint
for that text field.
Bug: 67384287
Test: manual
PiperOrigin-RevId: 171316291
Change-Id: I41f98fe207ebeca900bf4fd51cd4e95e20981a9a
|
|
The label is colorized with the SIM color, if the system UI decides to respect it.
screenshot:
https://screenshot.googleplex.com/PzkCKdQJ7Wy
Bug: 64215023
Test: StatusBarNotifierTest
PiperOrigin-RevId: 171234005
Change-Id: I684753b6181bdfe601244d01ab608fcd5d5dc422
|
|
am: 016e53f6ec
Change-Id: Ib4a8362d5211d434a73e8bcca47fa3d1814eba9f
|
|
|
|
This is a regression caused by cl/165479077.
Bug: 63038002
Test: manual
PiperOrigin-RevId: 171193536
Change-Id: Ib0ca2af64b5fdce2b5f3c78f171b8d5fe0388f47
|
|
am: ce13778736
Change-Id: I542ecc5e2c7516c6033a02ac40381869fe4ff120
|
|
* changes:
No longer close cursors manually after onLoadFinished is called.
FAB now properly scales in multiwindowed mode.
|
|
Documentation clearly states that cursor loaders will close all cursors for
you. This CL removes all calls to cursor.close() after onLoaderFinished is
called.
Bug: 66902052
Test: n/a
PiperOrigin-RevId: 171087171
Change-Id: If771fbea52e03ffdd3652af2699c393cc7424de3
|
|
As per the material desing spec [1], floating action buttons should be 56dp
in size normally and 40dp on small displays (like in multiwindow mode) while
always maintaing a 24dp image size.
screenshot (mw): http://screen/URJrg1WoQfn
screenshot (normal): http://screen/TUU65D1sSHp
[1]
https://material.io/guidelines/components/buttons-floating-action-button.html#buttons-floating-action-button-floating-action-button
Bug: 67312080
Test: n/a
PiperOrigin-RevId: 171086404
Change-Id: Ib213cf3c94dbb0f0df5b21f23f3022a8f53d80a8
|
|
am: 3a292c344c
Change-Id: I1d6348fbbbb52aa4d47b56b0b2f9bc4e79ad7c12
|
|
* changes:
Inserting post call notes now compares notifications using fuzzy matching.
Do not crash when LightbringerTech receives device orientation update
Copy directory list into new list to prevent modifications.
Remove 'learn more' link from verizon voicemail TOS text and using non-breaking space in dialer TOS 'learn more' link.
|
|
Bug: 65559651
Test: MissedCallNotifierTest
PiperOrigin-RevId: 171070314
Change-Id: I57e6e0b55a07430daad944473ae4eb427d56ee96
|
|
Bug: 67379105
Test: LightbringerTechTest
PiperOrigin-RevId: 171069656
Change-Id: I8aa9d5a1886d98b6039eeec993b91dd2b600d415
|
|
Since lists are passed by reference, if the directory list passed into
RemoteContactsCursorLoader was modified before #lodInBackground was called, the
directory list would change and crash when compared to the list of cursors.
Since directory lists are small, there shouldn't be any memory issues with
copying the list.
Additionally, this CL adds some logging to the new Search Fragment.
Bug: 66902071,66902062
Test: RemoteContactsCursorLoaderTest
PiperOrigin-RevId: 171063035
Change-Id: Id2faa542805da4167fc7045e6fbe71d02c644ab6
|
|
and using non-breaking space in dialer TOS 'learn more' link.
screen shots:
https://drive.google.com/open?id=0B9o_KvtLkcuIV3BWWmxSTTlJQ2dBTnR2UHRGWjZJRlFQUGo0
https://drive.google.com/open?id=0B9o_KvtLkcuIOEJjanVhMXlfck81aU02Y0I2MkVtWFNOVGp3
Bug: 67379747
Test: manual and updated unit tests
PiperOrigin-RevId: 171025914
Change-Id: I9c4bfd899805681492a5063ee1bc674bbb98f630
|
|
am: bc07ed7f31
Change-Id: Ia1b45110e6dd3005e7b9f6c799607f3c42f67269
|
|
* changes:
Only show the most recent call type icon in the new call log, instead of the last 3.
Make incoming and ongoing call notification foreground and highest priority.
|
|
last 3.
This is according to the latest PRD:
https://docs.google.com/document/d/1FLoQ6kNYL-QKplbniJAIUCHku87S9eYuYPs6IXe-U78
Also cleaned up warnings in CallLogQueryHandler.
Screenshot: https://screenshot.googleplex.com/Z7p4BRVpLpE
Bug: 34672501
Test: unit
PiperOrigin-RevId: 170941445
Change-Id: Ibf79b70eda3837ea46d365729aaed0a87961e42b
|
|
Use startForeground()/stopForeground() for posting notification instead of NotificationManager.notify()/cancel(). It makes incoming and ongoing notification foreground and not able to snooze. It also colorize ongoing call notification for Android O, since we already setColorized().
Use setPriority(Notification.PRIORITY_MAX) for pre-O, and NotificationManager.IMPORTANCE_MAX for O. It makes incoming and ongoing notification stay on the top.
Test: StatusBarNotifierTest*2
PiperOrigin-RevId: 170924163
Change-Id: Iab1415b0161a4623a1ccf52d3948f32b6f93eeb2
|
|
am: 69ff7c1717
Change-Id: Ief18a762dd0f21310290052394a3a9378dec11df
|
|
|
|
am: 40a59d3070
Change-Id: I9833ad954c352f648186945e30576c017fee5c39
|
|
duration."
am: 4fd9c153b6
Change-Id: I2a2380400f9e127ed7bffd7ff24124b4218fe2ce
|
|
The data here can be used to drive the in call ui
by providing key information about the transformation
process.
Bug: 63995261
Test: unit tests
PiperOrigin-RevId: 170885399
Change-Id: I525aa1f987b3dfd9548ef8656d97efa7fce2b692
|
|
* changes:
Adjust the location update frequency for emergency calls
Fix issue that the connection icon is placed a little left from center
|
|
duration."
|
|
am: 48824769e0
Change-Id: I947e3bff99b0d92efad5f293413babd8a6eb3ddc
|
|
* changes:
Fix incorrect information in LightbringerTech log line
Warmup shared prefs in googledialer when strict mode is enabled.
|
|
Sometimes takes many seconds to get an accurate location during an emergency call.
With this cl we use a high frequency update rate (5 seconds) until we get an accurate
location, and then we decrease the update rate (30 seconds) to save power.
Bug: 67317743
Test: manual
PiperOrigin-RevId: 170770361
Change-Id: Ib6415145f6a62125f4b458e242ebe23409f9d406
|
|
When status text is empty, VoWiFi icon is placed a bit left from center
because the view of connection icon is containing margin between the
tatus text.
Fix to remove margin from the icon when the text is empty.
Public-Origin-Change-Id: Ic302104d85fa9114bebb5688f3e8028d398d1921
Signed-off-by: Eric Erfanian <erfanian@google.com>
Author: Kousuke Kitahara <kousuke.kitahara@sony.com>
Bug: 66075997
Test: scuba tests
PiperOrigin-RevId: 170753786
Change-Id: Ifde98a8c04ba3dc2233439957a74fc4f54b444fa
|
|
Screenshot:http://screen/dwihQaaeaQC
Bug: 64882313,33006245
Test: NewVoicemailCallLogViewHolderTest, NewVoicemailCallLogAdapterTest
PiperOrigin-RevId: 170542645
Change-Id: I00c145c5856c3f1f53d12b0fd7bd80c63bb8a094
|
|
Test: manual
PiperOrigin-RevId: 170511271
Change-Id: Ief58171c675c6ece3cea5055abb6836487f23f9c
|
|
This avoid some spurious strict mode violations.
Test: observed no strict mode notification launching google dialer
PiperOrigin-RevId: 170505918
Change-Id: Ie48671dcd306ea18b041a0bd7989b419bab903f5
|
|
am: 0c396de3c9
Change-Id: I146f5a4ae2eaf82714b7e7b539cfd68895a22039
|
|
|
|
am: ff0b29390d
Change-Id: Ibefedb86280a8d0e28473f4b8756acff88ffcdf1
|
|
|
|
am: 7c54c42584
Change-Id: Ia3cd588e5608611abeaf54e4bf97740805d33bc8
|
|
|
|
am: 6f46d80593
Change-Id: I385ebc38c4f8555491128079b099bf88390d0358
|
|
* changes:
Fix audio route selector.
Fix crash on hanging up simulator video call.
|
|
This is a regression caused by cl/169961072.
This change will make sure phone number is only shown on top row for non-local contacts if the name is not number and the call is active.
Bug: 67047386
Test: TopRowTest
PiperOrigin-RevId: 170424277
Change-Id: I9b3ab9432a938b2fb1c6632f2d9404bee413588f
|
|
Project Fi devices crash when declining voicemail TOS because
of an invalid PhoneAccountHandle. This cl fixes the problem by
not showing the TOS when the PhoneAccountHandle is not valid.
Bug: 67001886,66969838
Test: manual and updated unit tests
PiperOrigin-RevId: 170418189
Change-Id: I36dd0b10ab7468b0937a81f3f0427a4d64091955
|
|
Also tuning the location request accuracy and minimum update interval.
i noticed during testing that we often get locations with
uncertainties greater than our threshold (100 meters), which we ignore.
That combined with the long update interval can result in not showing
a location for a long time.
Bug: 67046739
Test: manual
PiperOrigin-RevId: 170407138
Change-Id: I1a84088f9fa09b474b07e375b92af25852dd6f46
|
|
1. Use onCancel() instead of onDismiss(). onCancel() is not called when changing orientation, so it won't crash on getParentUnsafe(). onCancel() is also not called when pressing home button, but it will be handled by AudioRouteSelectorActivity.onPause(). b/67013452 will happen after the fix.
2. Use FLAG_ACTIVITY_NEW_TASK and FLAG_ACTIVITY_MULTIPLE_TASK when starting AudioRouteSelectorActivity. This prevents showing Dialer with AudioRouteSelectorActivity. The downside is that the activity is no longer excluded from recent screen.
The two fixes can affect each other, so they are in one CL.
Video: https://drive.google.com/open?id=0Bz1rQbdSCWSKYVJkd3R1SkI4c3c
Test: manual
PiperOrigin-RevId: 170404203
Change-Id: Ifa8ebcd566670115d3865b0d67c311c296fbbd51
|
|
The problem is that InCallActivityCommon#onStop will try to commit any fragment which will crash.
This change also fix a bug that simulatorRemoteVideo is not stopped after hanging up.
Bug: 67045513
Test: manual
PiperOrigin-RevId: 170380589
Change-Id: I25e0f43141eaa573189f4d9c0109fd2689c10374
|
|
am: 43d73dfdbd
Change-Id: Ib13d248db3280e648ee295529f860ca2b672feeb
|
|
|
|
This is a upstream fix from AOSP:
https://android-review.googlesource.com/#/c/platform/packages/apps/Dialer/+/475598/
Bug: 63608380
Test: none
PiperOrigin-RevId: 170365033
Change-Id: Id58cf4c67a3b0144521622a14997a83403017bee
|
|
am: ea2f430dd5
Change-Id: I1a7b0a9b856f352017609673d83a118988ef2bf8
|
|
* changes:
Use goAsync() and dialer executor to insert post call notifications
Add the assisted dialing logic module.
Refactor DialerStrictMode into an interface.
Adding logging for transcription polling requests
|
|
Previously post call notifications are inserted by launching CallLogNotificationService. This usually works because the call has just broght dialer to the foreground and there are some grace period before the app is consider background again. However if the post call message comes later background check will crash the app.
This CL made the broadcast receiver async and complete the insertion in a worker since it wouldn't take more than a few seconds.
Bug: 66444859
Test: unit tests
PiperOrigin-RevId: 170275928
Change-Id: I0ff396b51a173f2e4bab0bca6b6e5c5b56ab62da
|
|
This implements the core assisted dialing logic specified in
go/assisted-dialing-dd-v1
Bug: 36414469,63995261
Test: new unit tests
PiperOrigin-RevId: 170232634
Change-Id: I3b668c3a0e9fb5398eca4614548c8141b200e70e
|
|
-bypassed violations are no longer logged in AospDialer
The default implementation will use system strict mode and crash on bugfood build same as before.
Bug: 66003745
Test: manual
PiperOrigin-RevId: 170214128
Change-Id: Iab630f19499e90b15eb0b7f0707b4a70c7d81fbe
|
|
This will allow us to tune the polling rate.
Bug: 66966157
Test: none
PiperOrigin-RevId: 170210987
Change-Id: I6ef204acc6e0d43a3ada524511866d4a629fe1e2
|
|
am: 126469d102
Change-Id: Ib0352be5838b9c16573a730c4dbacbe0d17c4974
|
|
|
|
am: 753cfdbfc7
Change-Id: I37ac93f9a45aae764af2d9f707eaa95c4789dcef
|
|
am: 6502bb4961
Change-Id: I6ce51d3d82f2bb5fe7c169341ffd29e037f0578e
|
|
* changes:
Update v13 licences
Setup recycler view for new voicemail ui
Force dialpad to hide on resume if it should be hidden
|
|
|
|
screenshot:
https://drive.google.com/open?id=0B9o_KvtLkcuIdGY1RnVXM3JuMXB4OVRVOFhrSU9qRDR6c2pj
Bug: 37340510
Test: manual
PiperOrigin-RevId: 170131627
Change-Id: Ib022bba44e24675082299132a5965fbcb58257fa
|
|
Test: N/A
PiperOrigin-RevId: 170130892
Change-Id: Ifc59f239043c66eaa8341fe34c080dad08454236
|
|
Screenshot:http://screen/RK42CXn5uB6
Bug: 64882313,33006245
Test: VoicemailFragmentTest, NewVoicemailCallLogAdapterTest, NewVoicemailCallLogViewHolderTest
PiperOrigin-RevId: 170129401
Change-Id: Ib82357763bd9cf9f215804225be009650402fe84
|
|
On M the framework does not retain the hidden state of a fragment properly when restoring it from a savedInstanceState. This appears to be fixed in N, but the exact cause and fix are unknown. This behavior will cause a fragment previously hidden coming back as visible when the device is rotated or going through any save/restore life cycle.
Previously whether to show the dialpad is stored in a separate flag, and the dialpad will be hidden when it is reattached. This was regresed in cl/169614750
In this CL, if the saved mIsDialpadShown indicate the dialpad should not be shown, but the dialpad is not hidden, it will be hidden on resume.
Bug: 66893723
Test: DialtactsActivityTest
PiperOrigin-RevId: 170124711
Change-Id: I6f8ed21fb970d6f688cb75f854442115a6803f3c
|
|
These are old code and considered to be grandfathered in.
Cleaned up some warnings in GoogleLocationSettingHelper.
Bug: 66498656
Test: none
PiperOrigin-RevId: 170090310
Change-Id: I2c43564af751eb5f431a395d75afa5ce126b5d18
|
|
attahced after rotation"
am: 418dc0004c
Change-Id: Id4ef0d67366e2a615a9d9e71c644e9de1241d972
|
|
attahced after rotation"
|
|
am: 2bc616694d
Change-Id: I91bab74f97c577f9a40c61518aa58c2a8f231d3a
|
|
business etc.)"
am: 92fd6ef2b0
Change-Id: I2ac6c4c1b6f3d09973164e2ecfb1bfa8caf23ff1
|