Age | Commit message (Collapse) | Author |
|
|
|
Test: Existing tests
PiperOrigin-RevId: 189675976
Change-Id: Ieae92b5ac2aefd3f0397bbb07ebb1c97bd72ed42
|
|
Test: SpamBlockingPromoHelperTest
PiperOrigin-RevId: 189674918
Change-Id: I0b22eb9b8128125cc5b439674099820a01c3889f
|
|
NUI dialpad is still broken.
Test: Unit tests
PiperOrigin-RevId: 189674304
Change-Id: I58d114ed45839f8ff85a3a0e48c3d200337915c9
|
|
Test: InAppSpamTest
PiperOrigin-RevId: 189670786
Change-Id: Ie7bf394ecc02ac647211f7375faaf3e1b48ad7dd
|
|
|
|
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189670163
Change-Id: Ifdfcab7dc4493cbe688ef77d43df7e7a1400fa27
|
|
|
|
|
|
|
|
|
|
This data source determines if the call is to the voicemail inbox.
isVoicemail() is removed from NumberAttributes and PhoneLookup. It is yet decided how in call UI should handle voicemail calls in the future.
TAG_CHANGE_OK=proto not in prod yet. Please clear app data.
TYPE_CHANGE_OK=above
Bug: 70989587
Test: Unit tests
PiperOrigin-RevId: 189650273
Change-Id: Iafebf1abb18c74301b62a72d1d04deecd6d78d29
|
|
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189648655
Change-Id: I9918bd6f35bf7eb1bebb9862c2d78880457efa91
|
|
A phone account can be removed after calling getCallCapablePhoneAccounts(), so subsequent getPhoneAccount() can be null.
Other usages already has the null check.
Bug: 75598828
Test: N/A testing this involves getPhoneAccount() returning null on the nth call, which requires replacing the shadows with a mock and is highly coupled with the implementation. The is an edge case and is not worth the effort and brittleness it will cause.
PiperOrigin-RevId: 189644833
Change-Id: Ie92dda2537befb5936ad734954b4eaf75964f465
|
|
A phone account can be removed after calling getCallCapablePhoneAccounts(), so subsequent getPhoneAccount() can be null.
Bug: 75598828
Test: In a follow up CL, where all instance of these will be fixed.
PiperOrigin-RevId: 189635573
Change-Id: I897db6e8e7706bc8afe6f25d89fd2ca4405900df
|
|
|
|
Repro steps:
1. open dialer, click on FAB to open dialpad
2. make outgoing call, end call, press home
3. enable WiFi call
4. open dialer again, click on FAB to open dialpad
This is caused by change icon called after the FAB is visible and scaleIn won't do anything since it's already visible. But for some reason the icon is changed so nothing is drawn on the screen when the dialpad slide up. (dialpadfragment is visible even before it's slide up before user trigger it)
The fix is to scaleOut the FAB when the fragment onStop thus the changed icon will be correctly drawn.
Bug: 74586190
Test: manual
PiperOrigin-RevId: 189629441
Change-Id: I3dcbedcd171c992e5df14bff35758fce1bb67bc1
|
|
is paused."
|
|
* changes:
Refactor VM Settings and add support for voicemail transcription
Use single return to break bubble of RTT chat.
|
|
|
|
Bug: 73972084
Test: n/a
PiperOrigin-RevId: 189418664
Change-Id: I3dadea08dad1f2a594f5a7e0daf055721c3222a3
|
|
This CL refactors the existing voicemail settings fragment and adds UI support for voicemail transcription. It mainly deals with the following:
- ensuring that when the VVM toggle is turned off, transcription and donations are gone.
- when transcription is off, donation preference is gone.
- donation is only available when transcription is available and enabled
- as part of the refactor, fixes existing logging bugs
- breaks preferences and its associated methods into helper methods when possible
- groups relevant preferences together when possible
Bug: 74033229
Test: Unit tests
PiperOrigin-RevId: 189418217
Change-Id: I3442cb5752a235cfca643ba55df3fb75171e3fe4
|
|
Also change "done" button to "send" in input box and disallow multiple line since return will be interpreted as "send".
Bug: 67596257
Test: manual
PiperOrigin-RevId: 189409725
Change-Id: I3d3bf3e11cd04d6689125399f4567e88ee3f28f0
|
|
This also finishes moving all of the old tests over from
Dialtacts to Main. The only 2 tests that fail are:
- searchBoxClosedWhenHandlingNotificationIntent
- openSearchFragment_fabGoneInRegularSearchAfterRotation
I will fix these in a follow up CL.
Bug: 72525887
Test: dialer_aosp build target launches MainActivity, TAP
PiperOrigin-RevId: 189408987
Change-Id: Ice30191d95c19c62bcd89503e89f66440f30beac
|
|
|
|
Bug: 72755010
Test: manaul
PiperOrigin-RevId: 189408046
Change-Id: Ia23442b2243e2008042e0046a21f840a30dbf008
|
|
|
|
|
|
|
|
|
|
Previously it is unclear what the "county ISO" should be so the originating county of the SIM is used. When telecom writes to the call log the county the user is in is used. This caused the DialerPhoneNumber key in in call UI and call log to differ and info to be lost.
In this CL, the current country is used in PhoneLookupHistoryRecorder to make it consistent with the call log.
PhoneLookupHistoryRecorder is currently the only consumer for telecom call util.getCountryCode().
Additionally, dialer/location no longer depends on dialer/util. dialer/util has too many unnecessary dependencies that will cause cycles.
Bug: 73752730
Test: Unit tests
PiperOrigin-RevId: 189378542
Change-Id: I59773f7745c835a6523efda951c475e2fde9aaf9
|
|
Bug: 73741286
Test: none
PiperOrigin-RevId: 189377028
Change-Id: Ifb9c6375d0026fb012ae868741b471f2ca02c5f9
|
|
Apperently contact ids are invalid for work contacts, so the URI needs to
exclude them.
Bug: 72755010
Test: manual
PiperOrigin-RevId: 189374262
Change-Id: Ibeaa555dc035e14ea67905c342369188ecfd1832
|
|
If the user had the dialpad open when they received a call, they could
potentially crash dialer if they pressed add call or clicked on a phone number
in another app.
Bug: 74711879
Test: manual
PiperOrigin-RevId: 189371425
Change-Id: I14df55e2467be07dd30e3971004e601216f57daf
|
|
|
|
Bug: 73133096
Test: ModulesTest
PiperOrigin-RevId: 189303135
Change-Id: Id92d65e4c0bbb3c325c9d89d41d0645df19cde06
|
|
|
|
* changes:
Close keyboard when placing a call to nearby places and remote contacts.
Adjust bottom nav margins, sizes, ect.
|
|
This was accidentally removed in cl/176677167. This change restores
the logging in call details and also adds it to the call log menu.
Bug: 73774284
Test: OldCallDetailsActivityIntegrationTest, CallLogActivityIntegrationTest
PiperOrigin-RevId: 189279107
Change-Id: Iadda16d7f1e4d720f828b5a72f210bcb8029f939
|
|
Bug: 74784637
Test: manual
PiperOrigin-RevId: 189276349
Change-Id: I27b0f911ab5165f902bef017e8c09276441a9dee
|
|
Test: n/a
PiperOrigin-RevId: 189274795
Change-Id: I495e326ce74568d8add739275562284ef12e276f
|
|
|
|
* changes:
Add utility used to style content with learn more links
Remove deprecated android.graphics.Canvas APIs
|
|
For simplicity, instead of resolve the nui shortcut string, I
deleted it since it isn't used anymore.
Test: build log
PiperOrigin-RevId: 189260472
Change-Id: I67d5a49d78916a8960e41ad1c7b7f59efad6d718
|
|
Bug: 74017355
Test: ContentWithLearnMoreSpannerTest
PiperOrigin-RevId: 189252365
Change-Id: I3464fb56b86a6b3ddd25e9eed14152eaeed9925c
|
|
Bug: 73777445
Test: TAP
PiperOrigin-RevId: 189225531
Change-Id: I806be1c2a05d842b4991a9c95c19238f999d814d
|
|
* changes:
Fix bubble not showing on device restart.
Add Brazil to the set of countries we do not format phone numbers
|
|
|
|
Test: ReturnToCallControllerTest
PiperOrigin-RevId: 189225436
Change-Id: I845855d0b66941e311f3db239d10249015473c65
|
|
Test: existing test (MotorolaUtils)
PiperOrigin-RevId: 189225421
Change-Id: Id15181746cd087c82bc0b97262b03c76bc571b3f
|
|
Bug: 73830902
Test: Manual
PiperOrigin-RevId: 189222303
Change-Id: I0397986d784d28e7948b39778319e3936f6c55e9
|
|
|
|
This happens when outgoing video call is accepted as voice call or switching
between video call and voice call.
Bug: 71590134
Test: manual
PiperOrigin-RevId: 189206585
Change-Id: I564c261614990b9b6baab6025f1625f42058ba70
|
|
* changes:
Add audio select menu.
Introduce GlidePhotoManager to CallDetailsActivity
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 189204691
Change-Id: I9ecd36ce1c27072dea4ae87beeecd4565bf05378
|
|
Bug: 74202944
Test: ModulesTest, CallDetailsActivityTest
PiperOrigin-RevId: 189204143
Change-Id: I917bac76009522c6a99fdb63299556ec2a454dfa
|
|
* changes:
Added CallLogConfig.
Split CallDetailsActivity
|
|
This class is responsible for enabling or disabling the call log framework when flags change.
Bug: 74821995
Test: unit
PiperOrigin-RevId: 189143911
Change-Id: I4727645ce621fbc01acbcd0acab523fe955d4075
|
|
Bug: 74202944
Test: Existing tests
PiperOrigin-RevId: 189095432
Change-Id: I13015ee6c5767edd95b78c3fb2e7338495e9e1d7
|
|
|
|
Bug: 67596257
Test: manual
PiperOrigin-RevId: 189064976
Change-Id: I3265881114baceb4d63fcc3d55d1c904cd3216dc
|
|
|
|
|
|
|
|
Fast consercutive calls to #showFragment can have undesirable effects because
fragment manager doesn't handle transactions sychronously. This CL resolves one
of the scanrios where voicemail fetch status was calling #showFragment nearly
simulataniously to the #onHandleIntent call.
This issue may show itself again and I'm looking into more long term solutions
but we should be fine in the short term since the all of our fragment logic
is implemented.
Bug: 74051208,74621909
Test: manual
PiperOrigin-RevId: 188956984
Change-Id: I0796e31b03e0b749ae7e81f82859ea6f814a5fb5
|
|
Incall and answer screen is using transparent status and navigation bar, while RTT screen is using customized color. Switch between them require correct setting of system UI.
Bug: 67596257
Test: manually test to make RTT call and voice call, then switch between them.
PiperOrigin-RevId: 188956868
Change-Id: I3c17ff453be943f0b2ad28fe5cae434453fbe326
|
|
Test: N/A
PiperOrigin-RevId: 188953886
Change-Id: I3279efe088e8a37df79d635bd44c6fa831109f2e
|
|
|
|
Test: existing
PiperOrigin-RevId: 188928916
Change-Id: I2b6fb73545194fa175526a77ce2a76b1d23c049d
|
|
|
|
|
|
|
|
|
|
SQLiteQueryBuilder.query() is used in strict mode with a projection map.
Bug: 74601176
Test: Unit tests
PiperOrigin-RevId: 188907943
Change-Id: I2f34e185ad175695d941697cd0dbdc8ad6172321
|
|
Add 6dp of spacing between transcription and the secondary text.
Bug: 69963448
Test: N/A
PiperOrigin-RevId: 188902056
Change-Id: Iba1c9c110bd238842567e7b1b36a757d388cea2d
|
|
Makes the views where the voicemails are displayed and the empty view white.
Bug: 74402112
Test: N/A
PiperOrigin-RevId: 188901487
Change-Id: I55a12dd067e66cc0f4efca3eb79b5a8f9e761082
|
|
The default text alignment of a TextView is based on the content of the view (does it has any RTL characters or not). Previously the TextView width is match parent so the text will either align to the left or right depending on the content (the label is user content which we don't control). In this CL it is changed to wrap content so the whole text will align to the parent's gravity which is "start".
Bug: 74421655
Test: N/A
PiperOrigin-RevId: 188899698
Change-Id: Id754ed97bb6d3b6bba05d0a96c83623daca01cc8
|
|
|
|
|
|
This CL is a continuation of cl/187700318. In that CL, we were able to unregister
the call log's content observer and prevent this crash, but it's reshowing
itself in voicemail now.
Since the voicemail's observer is registered in the adapter and is unaware of
lifecycle changes, it's much more invasive to fix. So as a quick bandaid, we'll
just check that the parent isn't null.
Bug: 73972084
Test: n/a
PiperOrigin-RevId: 188812159
Change-Id: I533114de66b52395b0f3c90d4ec7a927c4df707f
|
|
Keyboard should close when:
- requeting permission
- placing a call
- leaving the app
Search should close when:
- placing a call
- leaving the app
Bug: 74235853
Test: search closing onPause tests already exist (MainActivityOldPeerSearchIntegrationTest#placingCallFromSearchClosesSearch)
PiperOrigin-RevId: 188812026
Change-Id: Iaee084c59b4c514d10375deff5d73d5a456ef9df
|
|
|
|
|
|
Previously the OEM MMI codes are hardcoded and inadvertently affected other devices. In this CL it is read from the config provider instead. The config provider is expected to provide values based on the OEM.
Bug: 72162360,74016291
Test: SpecialCharSequenceMgrTest
PiperOrigin-RevId: 188786408
Change-Id: Ie70e49a8a9d2ced5da9cf502c020477615bbe8a2
|
|
Bug: 74402112
Test: none
PiperOrigin-RevId: 188782198
Change-Id: I36c2adcd8f0403c88694343cbbf12e9aba229afb
|
|
|
|
Decrease the padding from 10dp to 4dp for bottom and top
Bug: 68727352
Test: N/A
PiperOrigin-RevId: 188776245
Change-Id: I7ced053a5989e15e84fad6a264683a5c8e5d9339
|
|
not available."
|
|
* changes:
Make NUI VM avatar and icon consistent with nui call log
Move HIDE_VOICEMAIL_SETTINGS_MENU out of voicemail/impl
|
|
available.
Bug: 70989591
Test: GlidePhotoManagerImplTest
PiperOrigin-RevId: 188758361
Change-Id: I038b5618a0005159ebae28e4b95ef5a4d388e2be
|
|
Makes the avatar and more icon the same as the nui call log.
Bug: 69963448
Test: N/A
PiperOrigin-RevId: 188756733
Change-Id: I93303a2a872ac156470d223d6fb4fd2959766adc
|
|
The metadata belongs with the voicemail settings menu, which is moved into dialer a while ago. Not moving the metadata causes build variants without VVM to have duplicated voicemail settings in telephony and dialer.
Also removed the redundant metadata in incall ui manifest.
Bug: 73096806
Test: manual
PiperOrigin-RevId: 188756468
Change-Id: I00174f84024c5b9ab809d99e40a55d22a07bd063
|
|
* changes:
Remove bubble "new" prefix.
Dismiss keyboard when opening overflow menu in RTT call.
|
|
|
|
Test: BubbleImplTest, BubbleImplIntegrationTest, ReturnToCallControllerTest, ReturnToCallActionReceiverTest, BottomActionViewControllerTest, ChangeOnScreenBoundsTest
PiperOrigin-RevId: 188558386
Change-Id: Ieab3ee3f148092312a50597b41c0975419756e23
|
|
This is to prevent dialpad showing with keyboard open.
The alternative way to dismiss keyboard after dialpad shows up doesn't work.
Bug: 67596257
Test: manual
PiperOrigin-RevId: 188556453
Change-Id: I4b917d8ac83246d2002641ae7759261699149c65
|
|
Makes the redlines similar to what we have for the call log nui. The values are structured and copied as much as possible from /calllog/ui/res/layout/new_call_log_*.xml
Things to note for:
-Today/Older header the same as call log
-More items all the way to the right
-Padding in voicemail icon gone
-Removed padding between each recycler view item
Bug: 69963448
Test: N/A
PiperOrigin-RevId: 188547442
Change-Id: I515d75e392591243510634c3fabe444a7ba10d7f
|
|
|
|
|
|
Test: InAppSpamTest,ApdlSpamTest,VisualVoicemailUpdateTaskTest
PiperOrigin-RevId: 188509191
Change-Id: I8b9c07dcc1c7b3b80ffc914ec99f4e6d80d50985
|