summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-07-15Update Dialer UI to prompt for permissionsYorke Lee
First pass at adding functionality to Dialer to prompt for permissions. Also updates the UI for various fragments when there are no contacts/calls available to unify the UI with the new UI for the permissions denied state. * Refactor existing empty view functionality and encapsulate into a new custom view class * Add action buttons to existing empty views in various fragments -> Speed Dial (Add to favorites) - scrolls to all contacts fragment -> Recents (Make a call) - shows dialpad -> All contacts (Add a contact) - Launches add contact dialog * Add functionality to various fragments to detect if permissions are denied, and request the permission when the action button is pressed. -> Speed Dial (request for contacts permission) -> Call Log (request for phone permission) -> All contacts (request for contacts permission) * Remove now unneeded EmptyContactsListAdapter Remaining issues (to be addressed in a follow up CL to avoid bloating this CL): UI alignment tweaks for empty view to match mocks If the read contacts permission is requested from the speed dial screen, the all contacts fragment doesn't update with the list of contacts until restarted. Bug: 22174668 Change-Id: I70721914bb9b32910d746de288ccac049749e42e
2015-07-15Merge "Update/add strings for permissions UI changes" into mnc-devYorke Lee
2015-07-15Update/add strings for permissions UI changesYorke Lee
Bug: 22174668 Change-Id: I7c857a5fbc6c80274e22201cb8d349cb048bc970
2015-07-15Import translations. DO NOT MERGEGeoff Mendal
Change-Id: Idb35d7cb3094705662841e6c1dc774f426ccaa7e Auto-generated-cl: translation import
2015-07-14Permission protect UndemoteOutgoingCallReceiverYorke Lee
Bug: 22479151 Change-Id: I7e2689cfd3b6a315e7a225d2a8646b5917f70570
2015-07-14Build against SDK 23Jay Shrauner
Bug:22478141 Change-Id: I1abf786f708b6dee7d88204404220e125c99ed4b
2015-07-14Merge "Don't cache results of permission check" into mnc-devYorke Lee
2015-07-13Merge "Fix a bug in the dtmf tone length setting." into mnc-devRoshan Pius
2015-07-13Fix a bug in the dtmf tone length setting.Roshan Pius
Had an error in the preference setting string name. BUG: 22452758 Change-Id: Ia9b55cb0a41382e4307cff6f5a8b97d9de2ac883
2015-07-13Don't cache results of permission checkYorke Lee
For maximum safety, always check the current permission status on the fly. Bug: 22455059 Change-Id: I05da7ec1ad2e885e3e5e78e14585c876ac19178e
2015-07-13Merge "Fix SecurityException in DefaultVoicemailNotifier" into mnc-devYorke Lee
2015-07-13Fix SecurityException in DefaultVoicemailNotifierYorke Lee
Protect querying of ContentResolvers with the relevant permission checks. Check the correct permission in onHandleIntent of CallLogNotificationsService. Bug: 22436465 Change-Id: I7fed82545b10921c1a935f903a466d8894d7b7f1
2015-07-11Import translations. DO NOT MERGEGeoff Mendal
Change-Id: Idacd38d3975c5a9dfbf51455bd34434451db4005 Auto-generated-cl: translation import
2015-07-09Merge "Update call shortcuts even if contacts permission denied" into mnc-devYorke Lee
2015-07-08Update call shortcuts even if contacts permission deniedYorke Lee
Bug: 22232717 Change-Id: I3c32a6ca55a8e0f904c2147e2c2df05327dbe9ed
2015-07-08Merge "Fix some voicemail playback bugs" into mnc-devYorke Lee
2015-07-08Fix some voicemail playback bugsYorke Lee
* Don't fetch voicemail until playback is started * Prevent multiple voicemail fetches for the same voicemail * Fixed an issue where the seekbar would be stuck in the same position even after seeking * Fix for playback position getting reset after the voicemail view is scrolled out of view and back in * Respect the invariant that if mMediaPlayer is null, mPrepared is always false. This fixes potential NPEs when resuming playback. Bug: 22127956 Bug: 22333494 Change-Id: I5c419424950c0e21317cbd133ca6f7e1edd9fd31
2015-07-08Import translations. DO NOT MERGEGeoff Mendal
Change-Id: Icae019ff3d32d6b8950ee4c69909982525d47bcc Auto-generated-cl: translation import
2015-07-07Merge "Don't auto-expand first call log entry" into mnc-devYorke Lee
2015-07-07Don't auto-expand first call log entryYorke Lee
Bug: 22278550 Change-Id: I756703c9441801c623b9dbcbe0d96803de2a3063
2015-07-07Merge "Go to recents tab instead of CallLogActivity for call views." into ↵Nancy Chen
mnc-dev
2015-07-07Go to recents tab instead of CallLogActivity for call views.Nancy Chen
Use the DialtactsActivity instead of CallLogActivity when accepting ACTION_VIEW intents for the "calls" mime type. Also remove an unused method in CallLogFragment. Bug: 22266705 Change-Id: I1bf089901b1a5f9534c9f7a8484c12e535a87749
2015-07-06Fix NPE in setSpeakerphoneOnJay Shrauner
Null check mActivity Bug:22301343 Change-Id: Ia020f2a8c74cf16786af9ab7132da4eb9b9d0401
2015-07-06Import translations. DO NOT MERGEGeoff Mendal
Change-Id: Id784f8184e302dc3c4a4666269dff9cc4922b611 Auto-generated-cl: translation import
2015-07-03Fix NPE in pausePlaybackJay Shrauner
Null check mActivity as we do in onPause Bug:22249553 Change-Id: I147fbd517696205a2eb478a6df032f50cbbd5b34
2015-07-01Merge "Restore Dialer content after permissions granted" into mnc-devYorke Lee
2015-07-01Restore Dialer content after permissions grantedYorke Lee
First pass at making Dialer display the call log, favorites, all contacts, and contact search after permissions are granted withut having to restart the app. Update cached permission status in onResume for Dialer activities Update SpeedDialFragment to correctly initialize loader in onResume if it was null previously because of revoked permission. Bug: 22205650 Change-Id: I68982e69395bc9c7da84ff3221cd12b8f79005f9
2015-07-01Merge "Fix dialer monkey NPEs" into mnc-devYorke Lee
2015-07-01Fix dialer monkey NPEsYorke Lee
Monkey tests exposed a bug in Dialer where certain call shortcuts could show up if contacts permissions were disabled and the UI was changing quickly. Don't enable shortcuts by default, and make sure to correctly disable all shortcuts in the case of missing permissions. Bug: 22225052 Change-Id: Icdd81412f695860eb322d7ccdc30555591c584d0
2015-07-01Merge "Don't auto-expand first voicemail card" into mnc-devYorke Lee
2015-07-01Merge "Ensure the EXTRA_SHOW_TAB is checked for all new intents." into mnc-devNancy Chen
2015-07-01Ensure the EXTRA_SHOW_TAB is checked for all new intents.Nancy Chen
onNewIntent is only called when the activity is already active so when an intent is sent to start the DialtactsActivity on a specific tab when the DialtactsActivity is not already active, the code to switch to the specific tab is not called. Move this code to onResume() instead. Bug: 21120186 Change-Id: I735eae22ca5de54f4c17688777b4309616f2c691
2015-07-01Don't auto-expand first voicemail cardYorke Lee
Bug: 22127956 Change-Id: Ia1a62e799bf7b535da2390bc0e8fa62201b8a684
2015-06-30Protect against null mViewYorke Lee
Bug: 22194812 Change-Id: I95e07820ed97d02fe61ee3ceee62c7e76c6f1cb5
2015-06-29Add long press actions to call logYorke Lee
When a call log entry is long pressed, show a context menu that provides the following actions: 1) Copy to clipboard 2) Edit number before call Bug: 21453814 Change-Id: I796cffbec39847fd9c61891063217b15cb298479
2015-06-29Merge "Accessibility fix for Dialer search results" into mnc-devYorke Lee
2015-06-29Merge "Add missing null check in VoicemailPlaybackPresenter" into mnc-devYorke Lee
2015-06-29Accessibility fix for Dialer search resultsYorke Lee
In portrait mode, resize the listview to fit above the dialpad, so that accessibility services can correctly traverse the view hierarchy. Bug: 20172384 Change-Id: I35fb49be7bea5d13d951c4d954ddaf9d8d12780e
2015-06-29Add missing null check in VoicemailPlaybackPresenterYorke Lee
Bug: 22171979 Change-Id: Ia26ba711b888de3c787167bf9af99fcf26a80b7a
2015-06-29Merge "Remove voicemail tab in call history" into mnc-devYorke Lee
2015-06-29Remove voicemail tab in call historyYorke Lee
Bug: 22169419 Change-Id: I512153e31a13df5f36bcb8dc00d53d55ba70117c
2015-06-29Merge "Cache repeated Telecom requests from call log." into mnc-devYorke Lee
2015-06-29Merge "Make the full search bar respond to clicks" into mnc-devYorke Lee
2015-06-27Make the full search bar respond to clicksYorke Lee
Bug: 21663461 Change-Id: I79bf44f7956511e6894a122a98a69d7793b9a785
2015-06-26Null protect invocation of getContentResolver.Andrew Lee
Bug: 22118779 Change-Id: I9a11c2fc05f8a6f418bc0e6daa55dfb61707bd6a
2015-06-26Cache repeated Telecom requests from call log.Andrew Lee
This improves call log scrolling performance. + Split "Wrapper" into a utility and a cache. + Use cache for repeated calls related to call logs. + In the process of fixing plumbing and typer, moved some phone call detail classes into the more appropriate call log package. + Update tests. Bug: 20524705 Change-Id: Ib8ee21e417c19f98f6474a5793416e8f99103b55
2015-06-26Merge "Revise layout/style of VoicemailPlaybackLayout." into mnc-devAndrew Lee
2015-06-25Revise layout/style of VoicemailPlaybackLayout.Andrew Lee
- Delete now-unused old icons. + Add new material icons for voicemail playback. + Rearrange buttons, padding/spacing. + Change ripple feedback when pressing button. + Use different text fields for total duration and state labels. Bug: 22070564 Change-Id: Ibc9b9908154ac0a846f828bb9707a61ab15f8ba5
2015-06-25Merge "Target MNC for Dialer" into mnc-devYorke Lee
2015-06-25Merge "Update some icons/styles used in Dialer." into mnc-devAndrew Lee
2015-06-25Merge "Enable proximity sensor onPause." into mnc-devAndrew Lee
2015-06-25Target MNC for DialerYorke Lee
Bug: 22071996 Change-Id: Ic37a70f0cd81d3981f6888cfc6d52f957810ddd6
2015-06-24Update some icons/styles used in Dialer.Andrew Lee
Bug: 22070564 Change-Id: I7b0d691c18a011f1f61cc12fe063458560528bd4
2015-06-24Merge "Fix potential crash if uri is unavailable." into mnc-devNancy Chen
2015-06-24Enable proximity sensor onPause.Andrew Lee
+ When using speakerphone, add flag to keep the screen on. Bug: 22047261 Change-Id: I4e28ab526218b4cc1f53f2ec98c4749f24ac95af
2015-06-24Merge "Expand the first call log item for new cursors." into mnc-devAndrew Lee
2015-06-24Merge "Show transcriptions in voicemail notifications." into mnc-devAndrew Lee
2015-06-24Merge "Add a promo card for visual voicemail." into mnc-devNancy Chen
2015-06-24Merge "InCallService meta-data [3/4]" into mnc-devSantos Cordon
2015-06-23Show transcriptions in voicemail notifications.Andrew Lee
+ Get transcript when obtaining information for notification. + If there is only one voicemail, show the transcription in the expanded/long text of the notification. Bug: 21762588 Change-Id: I35958f863d6622147032561121073960a30a6f0e
2015-06-24Merge "Protect against null context." into mnc-devAndrew Lee
2015-06-23Expand the first call log item for new cursors.Andrew Lee
This increases discoverability of the expand actions, and also makes it quicker to interact with the most recent items. Bug: 21960523 Change-Id: I6aefdd5b96a86177b26ecc59879d1a787115221a
2015-06-23Protect against null context.Andrew Lee
Bug: 22031896 Change-Id: I2da646a30a119c5be07dba8ad71c8e902969454e
2015-06-24Merge "Protect against CP2 crash in Dialer" into mnc-devYorke Lee
2015-06-24Merge "Add extra to jump to DialtactsActivity tab." into mnc-devAndrew Lee
2015-06-23Add extra to jump to DialtactsActivity tab.Andrew Lee
+ For the voicemail notification, jump to voicemail tab. + Jump through some hoops to handle this properly when waiting for the voicemail status to be retrieved. Bug: 21120186 Change-Id: I5a82f3ecafadb45246e6637e8275a09f78cc188a
2015-06-23Protect against CP2 crash in DialerYorke Lee
Bug: 21755796 Change-Id: I81a337db0728455ffa72b3067bc5d2260dd03db8
2015-06-23Fix potential crash if uri is unavailable.Nancy Chen
If the voicemail is in the process of deleting, the uri may be unavailable after the async task has started executing. Make a null check first. Bug: 21978479 Change-Id: I0ec93e66b055c4e5d9ce2743a3cffc689c835f78
2015-06-23InCallService meta-data [3/4]Santos Cordon
Bug: 21816241 Change-Id: I981c850d8b783d93877e762d9023213cd38d5421
2015-06-23Add a promo card for visual voicemail.Nancy Chen
The promo card explains what visual voicemail is, along with a link to settings to disable it and an ok button to dismiss it. Also move common resources from GoogleDialer to the respective resource files. Bug: 21086059 Change-Id: Iecfe778b815fb572667d0cecdb958205ec1b48a0
2015-06-22Merge "Set FAB to invisible on hide if no animation." into mnc-devAndrew Lee
2015-06-19Set FAB to invisible on hide if no animation.Andrew Lee
ScaleIn animation will not trigger if FAB is already visible, so if we don't scaleOut, set the visibility of the FAB to GONE. Bug: 21903907 Change-Id: I25ef78ca4e042665d62c40b791d7217310515597
2015-06-20Merge "Rewrite of MediaPlayer logic." into mnc-devAndrew Lee
2015-06-19Rewrite of MediaPlayer logic.Andrew Lee
+ Control MediaPlayer instance more tightly. Wait until prepareContent to initialize instance. Release MediaPlayer when it is no longer needed. + Instead of using isFinishing, check explicitly for orientation change to know whether to release MediaPlayer. + Change Presenter to singleton, to address audio change wonkiness. + Only create a Presenter if the call log fragment shows voicemail. + ... fixing a variety of cases. - Temporarily disable proximity sensor until blocking issue is fixed. Bug: 21856243 Change-Id: Ic06e98bb5278467c3cce726a06b6cf3d855861a2
2015-06-19Visual indicator that voicemail is unread.Nancy Chen
Bold the text for unread voicemail messages. Bug: 21086059 Change-Id: Ieb07c7fa22a91669faeb425dabb60b1176ec1091
2015-06-19Import translations. DO NOT MERGEGeoff Mendal
Change-Id: Ibbdabcfc6befbaa5ec5cc58b56cf49fbeab43f70 Auto-generated-cl: translation import
2015-06-19Merge "Cache whether voicemail tab should be shown." into mnc-devAndrew Lee
2015-06-18Cache whether voicemail tab should be shown.Andrew Lee
Bug: 21530107 Change-Id: Ib3023e7100157d6e061542075f0930a6b622e516
2015-06-18Merge "Do not set type label if "Custom"." into mnc-devAndrew Lee
2015-06-18Merge "Clarify phone type magic constant naming." into mnc-devAndrew Lee
2015-06-18Do not set type label if "Custom".Andrew Lee
If the label type is "Custom", it falls back to the number label to display. But, if the number label is empty we do not want to show "Custom" as the label type, so skip in this case. Bug: 21814339 Change-Id: Icfee49aef3c73ceaf81b6f9e767436a4188db119
2015-06-18Merge "Pass activity into VoicemailPlaybackPresenter." into mnc-devAndrew Lee
2015-06-18Pass activity into VoicemailPlaybackPresenter.Andrew Lee
We will use it to set windows flags to help make playback behaviors reasonable. Bug: 21856243 Change-Id: I7c1ecb9e225a507ea8956ccc31d667361a4b6824
2015-06-18Clarify phone type magic constant naming.Andrew Lee
Bug: 21895943 Change-Id: I562eea49292704aa8b8c76706fa1ea196a180eed
2015-06-17Merge "Fix FAB state and transitions." into mnc-devAndrew Lee
2015-06-17Import translations. DO NOT MERGEGeoff Mendal
Change-Id: Ib0bf22ec43b52407c13c02b7a20dea6f0671d2c9 Auto-generated-cl: translation import
2015-06-16Fix FAB state and transitions.Andrew Lee
+ Change to dialpad FAB in search (used to stay as add contact FAB, if we were in the Contacts list). + Position dialpad to align end in search (used to stay in the center, if we opened the search from Speed Dial). + Restore correct position/icon when exiting search. + Add correct FAB scale in/out behaviors in for transitions between lists fragment and search UI, search UI and dialpad, in particular for when the FAB changes position from END to MIDDLE when going from search UI back to Speed Dial. + Add FAB scale in/outs for showing/hiding the soft keyboard. Bug: 21161760 Change-Id: Idbddbac161e459e3708d43395850d80927d5e448
2015-06-16Merge "Add play voicemail primary action to call log." into mnc-devAndrew Lee
2015-06-16Change VM string from "unread" to "new".Andrew Lee
Bug: 21851066 Change-Id: Iba7c69231e235faf2306d23a29684146d5cc6142
2015-06-15Add play voicemail primary action to call log.Andrew Lee
+ Add voicemail primary action button, which expands the call log and plays immediately when clicked. + Pass expand/collapse listener into the view holder. This is necessary because it needs to be triggered when the "play" primary action is clicked so that the CallLogAdapter correctly registers what has been added and binded. + Update primary action button state when showing or hiding actions, so the visibility of the voicemail play button is managed properly. + Ensure voicemail playback state is consistent between multiple call log items when the user initiates a collapse or expand. Add reset function to help manage this. + With the reset, protect against the possibility of functions in the presenter being called when no voicemail playback view is set. Bug: 21654755 Change-Id: I7bcf67d27fa08fe77d1334dc084b52effe8d3ccc
2015-06-15Merge "Fix abundance of "Custom" labels." into mnc-devAndrew Lee
2015-06-15Merge "Fix VoicemailPlaybackTest flakiness." into mnc-devAndrew Lee
2015-06-15Fix abundance of "Custom" labels.Andrew Lee
Not sure precisely why this changed, but hopefully this logic is more robust. Show the geocoded location if there is no name to use and a location is available. Removed GEOCODE_AS_LABEL, which wasn't really used anymore. Bug: 21814339 Change-Id: I1343282ef415647853d7995d900a3f50186ad156
2015-06-15Fix VoicemailPlaybackTest flakiness.Andrew Lee
Change-Id: I9568ab3236ab02125c3d7da5f8a477df34bd7499
2015-06-15Merge "Convert to primary action button on call log items." into mnc-devAndrew Lee
2015-06-15Import translations. DO NOT MERGEGeoff Mendal
Change-Id: I176e4111d4a9de26a7fbbfbac4cea40efa7dcefb Auto-generated-cl: translation import
2015-06-12Convert to primary action button on call log items.Andrew Lee
+ This is the call button on the standard call log list item, but will be play on voicemail call log list items. + Add call "list" action for voicemail call log list items. Change-Id: I4b115b96738b77c8a19c1071d5290e65f93395ac
2015-06-12Merge "Don't include voicemails in ALL call type filter." into mnc-devAndrew Lee
2015-06-12Don't include voicemails in ALL call type filter.Andrew Lee
Bug: 21814327 Change-Id: I6f59781ba5f8e5e396d919fefed6bfd76ec9e206
2015-06-12Merge "Don't pass media player to VM playback layout." into mnc-devAndrew Lee
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-19 08:04:26 +0000