summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-10-11Handle race condition with CallComposerActivity.onBackPressedmaxwelb
For fast users/testing suites, it's possible to hit a race condition where onBackPressed is called multiple times in a way that allows the second call to endCallComposerSession to happen and crash. This CL fixes the issue by checking that the session still exists prior to calling endCallComposerSession. I tried to write tests for this, but since the code guards against this from happening, I wasn't able to get the code into a situation to cause the crash. Bug: 64136293 Test: none PiperOrigin-RevId: 171758119 Change-Id: Ie12fd2f4390329b9bebb503fa3cf0f26d3bc1caf
2017-10-11Skeleton implementation of PhoneLookup and Cp2PhoneLookup.calderwoodra
Bug: 67605130 Test: Cp2PhoneLookupTest PiperOrigin-RevId: 171757865 Change-Id: If92e759567456dda09a925e9c625df001f2d573f
2017-10-11Change voicemail transcription progress stringmdooley
screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuIdVZ2dE44MzNUZ2pkdUY5ZVdycHp0R1ZsLUtZ Bug: 67634990 Test: manual PiperOrigin-RevId: 171757382 Change-Id: If11b88a0682e5da9454238fa19fb78972115fb23
2017-10-11Ignore self-manged calls for missed call notificationtwyen
If a PhoneAccount declared it is CAPABILITY_SELF_MANAGED, it should handle the in call UI and notifications itself, but might still write to call log with EXTRA_LOG_SELF_MANAGED_CALLS}. Bug: 66946794 Test: MissedCallNotifierTest PiperOrigin-RevId: 171727177 Change-Id: I34444857d432d6bb72983c0ba919bcfef885192b
2017-10-11Remove period from location request string.calderwoodra
Bug: 67635072 Test: n/a PiperOrigin-RevId: 171720799 Change-Id: Ie64f7daa071986b23653876172011d4f2343fc69
2017-10-11Implement SIM swappingtwyen
When the call is still ringing, a new button is added to allow to user to call with the other SIM. A background worker will be created to hang up the phone and redial with the other SIM. The in call UI will be prevented from ending during the process. Video: https://drive.google.com/a/google.com/file/d/0B2eYBUUznfyTSl9MdXQ0V1ZzQkE/view?usp=sharing UX has not been finalized, the icon and position are just placeholder. Bug: 64215256 Test: SwapSimWorkerTest PiperOrigin-RevId: 171715715 Change-Id: Idb3f486e9fc9a45d4c5e244af2d7d91b075bf0f2
2017-10-11Set an appropriate icon for the call detail UI's callback button.linyuh
cl/170943038 groups calls in the call log according to their corresponding actions (Lightbringer, IMS, and voice). This way calls in the call detail UI are in the same category and an appropriate icon can be set. Bug: 66026167 Test: CallDetailsActivityTest.callbackButtonLoggedForLightbringerCall, CallDetailsActivityTest.callbackButtonLoggedForVideoCall, CallDetailsActivityTest.callbackButtonLoggedForVoiceCall PiperOrigin-RevId: 171703514 Change-Id: I534e1d22f1355f261105a6bde74285403fc9ed87
2017-10-10Merge "Hide the text view showing call type or location when assisted ↵Treehugger Robot
dialing is supported."
2017-10-10Merge "Improved FAB UX."Treehugger Robot
2017-10-10Merge changes Id8170206,I4e63ef1d,I05e176efTreehugger Robot
* changes: Group calls in the call log according to their corresponding actions. Add assisted dialing to outbound calls that qualify. Show "Incoming video call" instead of "Incoming call" for ViLTE notification.
2017-10-10Hide the text view showing call type or location when assisted dialing is ↵Android Dialer
supported. Test: manual PiperOrigin-RevId: 171610298 Change-Id: I12ca284927603804b8761db695d35a1c79fa93f3
2017-10-10Improved FAB UX.calderwoodra
One of the biggest issues with the FAB is that it doesn't scale in/out properly. It looked more like setVisibility was being called instead. This CL migrates the FAB controller to use the built in scale in/out methods #show and #hide and the animation is much nicer. Some of the other issues were: - Now scaling animation is correct and visible. - No longer flashes when going in/out of search. - No longer shows on top of the return to call controller. - No longer bugs when switching between VVM TOS and contacts. - No longer shows FAB over VVM TOS when entering/exiting search Bug: 62588192,35359563,64116334,27458212,37991480,67419607 Test: manual PiperOrigin-RevId: 171608105 Change-Id: I9b3f61df35abf3659a432adf411b1b7d20eba683
2017-10-10Group calls in the call log according to their corresponding actions.Android Dialer
Currently different types of calls can be grouped together (e.g., 1 voice call and 1 IMS call to/from the same number), which makes it difficult to choose the icon for the call detail UI's call back button. This CL adds an extra constraint that separates different call types (Lightbringer, IMS, and voice). This way calls in the call detail UI are in the same category and an appropriate icon can be set. Bug: 66026167 Test: CallLogGroupBuilderTest.addGroups_MixedEntries_PartiallyGroupedByAction PiperOrigin-RevId: 171602617 Change-Id: Id8170206009ba836a40c38a86914c71d5c7701dc
2017-10-10Add assisted dialing to outbound calls that qualify.erfanian
* Add missing assisted dialing to calls from contacts in the call log. * Add missing assisted dialing to calls from dialpad and normal search. Bug: 63995025,63995261 Test: unit test PiperOrigin-RevId: 171593967 Change-Id: I4e63ef1dcd7ee1b2b5cbb8ecb4d8da744d90bd66
2017-10-10Show "Incoming video call" instead of "Incoming call" for ViLTE notification.yueg
Test: StatusBarNotifierTest PiperOrigin-RevId: 171588023 Change-Id: I05e176ef1032da00c4b75a83e92f39e8293d598e
2017-10-09Merge "Partial revert of cl/170369554 to fix video call ringing screen"Treehugger Robot
2017-10-09Partial revert of cl/170369554 to fix video call ringing screenroldenburg
Tracking bug to fix the refactoring: http://b/67512378 Bug: 67470678 Test: manual PiperOrigin-RevId: 171553078 Change-Id: Ib83e4240d6024347f97d246f9b526c3ccbf02057
2017-10-09Merge "Implement InCallUiLock"Treehugger Robot
2017-10-09Implement InCallUiLocktwyen
When any locks are acquired, the InCallActivity will not auto-finish when there are no active calls. The disconnected cause and reject with SMS dialogs are migrated to use this API, which prevents the activity form ending before the user has finished interacting with the dialogs. Bug: 64215256 Test: InCallPresenterTest PiperOrigin-RevId: 171362338 Change-Id: Ied07ebbf6bee056ea6b2314c57f3324561b1651a
2017-10-06Merge changes I620aacf3,Ie5fe2fc1,I41f98fe2Treehugger Robot
* changes: Adding Future method for DialerPhoneNumberUtil Show on hold in management screen for conference call. Allow for multi-line transcription error messages
2017-10-06Merge "Tag incoming call notification with SIM label on multi-SIM devices"Treehugger Robot
2017-10-06Adding Future method for DialerPhoneNumberUtilmaxwelb
This CL adds a method to DialerPhoneNumberUtil which returns a Future holding the result of parsing a number into the DialerPhoneNumber proto. This will be used in the APDL integration as it will use Futures as well. The CL also changes DialerExecutors.lowPriorityThreadPool to be an ExecutorService instead of an Executor (the super type) so it can be used in MoreExecutors.listeningDecorator. Test: TAP PiperOrigin-RevId: 171347542 Change-Id: I620aacf3304d625f57af6d2b89a36f11b44008dd
2017-10-06Show on hold in management screen for conference call.yueg
Do the following when a participant is on hold: - Add "On hold • " in front of the number - Gray out avatar and text (contact name & number) Notice: We only have the on hold state information for VoLTE conference call and IMS conference call. So the change only works for them (not for GSM/CDMA conference call). Test: ConferenceManagerPresenterTest PiperOrigin-RevId: 171345423 Change-Id: Ie5fe2fc1097f4858604283989dcb916c2ac21972
2017-10-06Allow for multi-line transcription error messagesmdooley
QA noticed that the error message 'Transcription not available. Unsupported language' didnt fit on one line and got truncated. This cl removes the single line constraint for that text field. Bug: 67384287 Test: manual PiperOrigin-RevId: 171316291 Change-Id: I41f98fe207ebeca900bf4fd51cd4e95e20981a9a
2017-10-06Tag incoming call notification with SIM label on multi-SIM devicestwyen
The label is colorized with the SIM color, if the system UI decides to respect it. screenshot: https://screenshot.googleplex.com/PzkCKdQJ7Wy Bug: 64215023 Test: StatusBarNotifierTest PiperOrigin-RevId: 171234005 Change-Id: I684753b6181bdfe601244d01ab608fcd5d5dc422
2017-10-05Merge "Fix bug that clickling buttons on spam notification has no effect."Treehugger Robot
2017-10-05Fix bug that clickling buttons on spam notification has no effect.wangqi
This is a regression caused by cl/165479077. Bug: 63038002 Test: manual PiperOrigin-RevId: 171193536 Change-Id: Ib0ca2af64b5fdce2b5f3c78f171b8d5fe0388f47
2017-10-05Merge changes If771fbea,Ib213cf3cTreehugger Robot
* changes: No longer close cursors manually after onLoadFinished is called. FAB now properly scales in multiwindowed mode.
2017-10-05No longer close cursors manually after onLoadFinished is called.calderwoodra
Documentation clearly states that cursor loaders will close all cursors for you. This CL removes all calls to cursor.close() after onLoaderFinished is called. Bug: 66902052 Test: n/a PiperOrigin-RevId: 171087171 Change-Id: If771fbea52e03ffdd3652af2699c393cc7424de3
2017-10-05FAB now properly scales in multiwindowed mode.calderwoodra
As per the material desing spec [1], floating action buttons should be 56dp in size normally and 40dp on small displays (like in multiwindow mode) while always maintaing a 24dp image size. screenshot (mw): http://screen/URJrg1WoQfn screenshot (normal): http://screen/TUU65D1sSHp [1] https://material.io/guidelines/components/buttons-floating-action-button.html#buttons-floating-action-button-floating-action-button Bug: 67312080 Test: n/a PiperOrigin-RevId: 171086404 Change-Id: Ib213cf3c94dbb0f0df5b21f23f3022a8f53d80a8
2017-10-05Merge changes I57e6e0b5,I8aa9d5a1,Id2faa542,I9c4bfd89Treehugger Robot
* changes: Inserting post call notes now compares notifications using fuzzy matching. Do not crash when LightbringerTech receives device orientation update Copy directory list into new list to prevent modifications. Remove 'learn more' link from verizon voicemail TOS text and using non-breaking space in dialer TOS 'learn more' link.
2017-10-04Inserting post call notes now compares notifications using fuzzy matching.calderwoodra
Bug: 65559651 Test: MissedCallNotifierTest PiperOrigin-RevId: 171070314 Change-Id: I57e6e0b55a07430daad944473ae4eb427d56ee96
2017-10-04Do not crash when LightbringerTech receives device orientation updateroldenburg
Bug: 67379105 Test: LightbringerTechTest PiperOrigin-RevId: 171069656 Change-Id: I8aa9d5a1886d98b6039eeec993b91dd2b600d415
2017-10-04Copy directory list into new list to prevent modifications.calderwoodra
Since lists are passed by reference, if the directory list passed into RemoteContactsCursorLoader was modified before #lodInBackground was called, the directory list would change and crash when compared to the list of cursors. Since directory lists are small, there shouldn't be any memory issues with copying the list. Additionally, this CL adds some logging to the new Search Fragment. Bug: 66902071,66902062 Test: RemoteContactsCursorLoaderTest PiperOrigin-RevId: 171063035 Change-Id: Id2faa542805da4167fc7045e6fbe71d02c644ab6
2017-10-04Remove 'learn more' link from verizon voicemail TOS textmdooley
and using non-breaking space in dialer TOS 'learn more' link. screen shots: https://drive.google.com/open?id=0B9o_KvtLkcuIV3BWWmxSTTlJQ2dBTnR2UHRGWjZJRlFQUGo0 https://drive.google.com/open?id=0B9o_KvtLkcuIOEJjanVhMXlfck81aU02Y0I2MkVtWFNOVGp3 Bug: 67379747 Test: manual and updated unit tests PiperOrigin-RevId: 171025914 Change-Id: I9c4bfd899805681492a5063ee1bc674bbb98f630
2017-10-04Merge changes Ibf79b70e,Iab1415b0Treehugger Robot
* changes: Only show the most recent call type icon in the new call log, instead of the last 3. Make incoming and ongoing call notification foreground and highest priority.
2017-10-04Only show the most recent call type icon in the new call log, instead of the ↵zachh
last 3. This is according to the latest PRD: https://docs.google.com/document/d/1FLoQ6kNYL-QKplbniJAIUCHku87S9eYuYPs6IXe-U78 Also cleaned up warnings in CallLogQueryHandler. Screenshot: https://screenshot.googleplex.com/Z7p4BRVpLpE Bug: 34672501 Test: unit PiperOrigin-RevId: 170941445 Change-Id: Ibf79b70eda3837ea46d365729aaed0a87961e42b
2017-10-04Make incoming and ongoing call notification foreground and highest priority.yueg
Use startForeground()/stopForeground() for posting notification instead of NotificationManager.notify()/cancel(). It makes incoming and ongoing notification foreground and not able to snooze. It also colorize ongoing call notification for Android O, since we already setColorized(). Use setPriority(Notification.PRIORITY_MAX) for pre-O, and NotificationManager.IMPORTANCE_MAX for O. It makes incoming and ongoing notification stay on the top. Test: StatusBarNotifierTest*2 PiperOrigin-RevId: 170924163 Change-Id: Iab1415b0161a4623a1ccf52d3948f32b6f93eeb2
2017-10-03Merge "Expose more transformation state."Treehugger Robot
2017-10-03Expose more transformation state.erfanian
The data here can be used to drive the in call ui by providing key information about the transformation process. Bug: 63995261 Test: unit tests PiperOrigin-RevId: 170885399 Change-Id: I525aa1f987b3dfd9548ef8656d97efa7fce2b692
2017-10-03Merge changes Ib6415145,Ifde98a8cTreehugger Robot
* changes: Adjust the location update frequency for emergency calls Fix issue that the connection icon is placed a little left from center
2017-10-03Merge "Create UI support for voicemail transcription, location, date and ↵Treehugger Robot
duration."
2017-10-03Merge changes Ief58171c,Ie48671dcTreehugger Robot
* changes: Fix incorrect information in LightbringerTech log line Warmup shared prefs in googledialer when strict mode is enabled.
2017-10-03Adjust the location update frequency for emergency callsmdooley
Sometimes takes many seconds to get an accurate location during an emergency call. With this cl we use a high frequency update rate (5 seconds) until we get an accurate location, and then we decrease the update rate (30 seconds) to save power. Bug: 67317743 Test: manual PiperOrigin-RevId: 170770361 Change-Id: Ib6415145f6a62125f4b458e242ebe23409f9d406
2017-10-03Fix issue that the connection icon is placed a little left from centererfanian
When status text is empty, VoWiFi icon is placed a bit left from center because the view of connection icon is containing margin between the tatus text. Fix to remove margin from the icon when the text is empty. Public-Origin-Change-Id: Ic302104d85fa9114bebb5688f3e8028d398d1921 Signed-off-by: Eric Erfanian <erfanian@google.com> Author: Kousuke Kitahara <kousuke.kitahara@sony.com> Bug: 66075997 Test: scuba tests PiperOrigin-RevId: 170753786 Change-Id: Ifde98a8c04ba3dc2233439957a74fc4f54b444fa
2017-10-03Create UI support for voicemail transcription, location, date and duration.uabdullah
Screenshot:http://screen/dwihQaaeaQC Bug: 64882313,33006245 Test: NewVoicemailCallLogViewHolderTest, NewVoicemailCallLogAdapterTest PiperOrigin-RevId: 170542645 Change-Id: I00c145c5856c3f1f53d12b0fd7bd80c63bb8a094
2017-10-03Fix incorrect information in LightbringerTech log lineroldenburg
Test: manual PiperOrigin-RevId: 170511271 Change-Id: Ief58171c675c6ece3cea5055abb6836487f23f9c
2017-10-03Warmup shared prefs in googledialer when strict mode is enabled.zachh
This avoid some spurious strict mode violations. Test: observed no strict mode notification launching google dialer PiperOrigin-RevId: 170505918 Change-Id: Ie48671dcd306ea18b041a0bd7989b419bab903f5
2017-10-03Merge "Fix bug that phone number is shown for local contacts."Treehugger Robot
2017-10-03Merge "Check for valid phone account before displaying voicemail TOS"Treehugger Robot
2017-10-03Merge "Updating emergency location code to use non-deprecated location apis"Treehugger Robot
2017-10-02Merge changes Ifa8ebcd5,I25e0f431Treehugger Robot
* changes: Fix audio route selector. Fix crash on hanging up simulator video call.
2017-10-02Fix bug that phone number is shown for local contacts.wangqi
This is a regression caused by cl/169961072. This change will make sure phone number is only shown on top row for non-local contacts if the name is not number and the call is active. Bug: 67047386 Test: TopRowTest PiperOrigin-RevId: 170424277 Change-Id: I9b3ab9432a938b2fb1c6632f2d9404bee413588f
2017-10-02Check for valid phone account before displaying voicemail TOSmdooley
Project Fi devices crash when declining voicemail TOS because of an invalid PhoneAccountHandle. This cl fixes the problem by not showing the TOS when the PhoneAccountHandle is not valid. Bug: 67001886,66969838 Test: manual and updated unit tests PiperOrigin-RevId: 170418189 Change-Id: I36dd0b10ab7468b0937a81f3f0427a4d64091955
2017-10-02Updating emergency location code to use non-deprecated location apismdooley
Also tuning the location request accuracy and minimum update interval. i noticed during testing that we often get locations with uncertainties greater than our threshold (100 meters), which we ignore. That combined with the long update interval can result in not showing a location for a long time. Bug: 67046739 Test: manual PiperOrigin-RevId: 170407138 Change-Id: I1a84088f9fa09b474b07e375b92af25852dd6f46
2017-10-02Fix audio route selector.yueg
1. Use onCancel() instead of onDismiss(). onCancel() is not called when changing orientation, so it won't crash on getParentUnsafe(). onCancel() is also not called when pressing home button, but it will be handled by AudioRouteSelectorActivity.onPause(). b/67013452 will happen after the fix. 2. Use FLAG_ACTIVITY_NEW_TASK and FLAG_ACTIVITY_MULTIPLE_TASK when starting AudioRouteSelectorActivity. This prevents showing Dialer with AudioRouteSelectorActivity. The downside is that the activity is no longer excluded from recent screen. The two fixes can affect each other, so they are in one CL. Video: https://drive.google.com/open?id=0Bz1rQbdSCWSKYVJkd3R1SkI4c3c Test: manual PiperOrigin-RevId: 170404203 Change-Id: Ifa8ebcd566670115d3865b0d67c311c296fbbd51
2017-10-02Fix crash on hanging up simulator video call.wangqi
The problem is that InCallActivityCommon#onStop will try to commit any fragment which will crash. This change also fix a bug that simulatorRemoteVideo is not stopped after hanging up. Bug: 67045513 Test: manual PiperOrigin-RevId: 170380589 Change-Id: I25e0f43141eaa573189f4d9c0109fd2689c10374
2017-09-29Merge "Fix crash on incoming video call when video upgrade call is pending."Treehugger Robot
2017-09-29Fix crash on incoming video call when video upgrade call is pending.wangqi
This is a upstream fix from AOSP: https://android-review.googlesource.com/#/c/platform/packages/apps/Dialer/+/475598/ Bug: 63608380 Test: none PiperOrigin-RevId: 170365033 Change-Id: Id58cf4c67a3b0144521622a14997a83403017bee
2017-09-28Merge changes I0ff396b5,I3b668c3a,Iab630f19,I6ef204acTreehugger Robot
* changes: Use goAsync() and dialer executor to insert post call notifications Add the assisted dialing logic module. Refactor DialerStrictMode into an interface. Adding logging for transcription polling requests
2017-09-28Use goAsync() and dialer executor to insert post call notificationstwyen
Previously post call notifications are inserted by launching CallLogNotificationService. This usually works because the call has just broght dialer to the foreground and there are some grace period before the app is consider background again. However if the post call message comes later background check will crash the app. This CL made the broadcast receiver async and complete the insertion in a worker since it wouldn't take more than a few seconds. Bug: 66444859 Test: unit tests PiperOrigin-RevId: 170275928 Change-Id: I0ff396b51a173f2e4bab0bca6b6e5c5b56ab62da
2017-09-28Add the assisted dialing logic module.erfanian
This implements the core assisted dialing logic specified in go/assisted-dialing-dd-v1 Bug: 36414469,63995261 Test: new unit tests PiperOrigin-RevId: 170232634 Change-Id: I3b668c3a0e9fb5398eca4614548c8141b200e70e
2017-09-28Refactor DialerStrictMode into an interface.wangqi
-bypassed violations are no longer logged in AospDialer The default implementation will use system strict mode and crash on bugfood build same as before. Bug: 66003745 Test: manual PiperOrigin-RevId: 170214128 Change-Id: Iab630f19499e90b15eb0b7f0707b4a70c7d81fbe
2017-09-28Adding logging for transcription polling requestsmdooley
This will allow us to tune the polling rate. Bug: 66966157 Test: none PiperOrigin-RevId: 170210987 Change-Id: I6ef204acc6e0d43a3ada524511866d4a629fe1e2
2017-09-27Merge "Updating non-verizon ToS string for declining ToS"Treehugger Robot
2017-09-27Merge changes Ifc59f239,Ib8235776,I6f8ed21fTreehugger Robot
* changes: Update v13 licences Setup recycler view for new voicemail ui Force dialpad to hide on resume if it should be hidden
2017-09-27Merge "Bypassed some strict mode violations."Treehugger Robot
2017-09-27Updating non-verizon ToS string for declining ToSmdooley
screenshot: https://drive.google.com/open?id=0B9o_KvtLkcuIdGY1RnVXM3JuMXB4OVRVOFhrSU9qRDR6c2pj Bug: 37340510 Test: manual PiperOrigin-RevId: 170131627 Change-Id: Ib022bba44e24675082299132a5965fbcb58257fa
2017-09-27Update v13 licencesuabdullah
Test: N/A PiperOrigin-RevId: 170130892 Change-Id: Ifc59f239043c66eaa8341fe34c080dad08454236
2017-09-27Setup recycler view for new voicemail uiuabdullah
Screenshot:http://screen/RK42CXn5uB6 Bug: 64882313,33006245 Test: VoicemailFragmentTest, NewVoicemailCallLogAdapterTest, NewVoicemailCallLogViewHolderTest PiperOrigin-RevId: 170129401 Change-Id: Ib82357763bd9cf9f215804225be009650402fe84
2017-09-27Force dialpad to hide on resume if it should be hiddentwyen
On M the framework does not retain the hidden state of a fragment properly when restoring it from a savedInstanceState. This appears to be fixed in N, but the exact cause and fix are unknown. This behavior will cause a fragment previously hidden coming back as visible when the device is rotated or going through any save/restore life cycle. Previously whether to show the dialpad is stored in a separate flag, and the dialpad will be hidden when it is reattached. This was regresed in cl/169614750 In this CL, if the saved mIsDialpadShown indicate the dialpad should not be shown, but the dialpad is not hidden, it will be hidden on resume. Bug: 66893723 Test: DialtactsActivityTest PiperOrigin-RevId: 170124711 Change-Id: I6f8ed21fb970d6f688cb75f854442115a6803f3c
2017-09-27Bypassed some strict mode violations.zachh
These are old code and considered to be grandfathered in. Cleaned up some warnings in GoogleLocationSettingHelper. Bug: 66498656 Test: none PiperOrigin-RevId: 170090310 Change-Id: I2c43564af751eb5f431a395d75afa5ce126b5d18
2017-09-26Merge "Fix onVisible/onNotVisible called on CallLogFragment without being ↵Treehugger Robot
attahced after rotation"
2017-09-26Merge "Increase location title length"Treehugger Robot
2017-09-26Merge "Fix bug that phone number is not shown for non-contacts. (CNAP, ↵Treehugger Robot
business etc.)"
2017-09-26Merge changes Ib1c25dde,I0ea10aca,Idba52629,Ia3728be4Treehugger Robot
* changes: Use help center for GoogleDialer about Upgrade and refactor latency test over Dialer. Now it has Incall UI latency besides app launch latency. Alert functionality is not included in this cl. Tweaking verizon's voicemail TOS text Update text of call back number in emergency calls.
2017-09-26Fix onVisible/onNotVisible called on CallLogFragment without being attahced ↵twyen
after rotation mCurrentPage is set onResume before the fragment is attached. In this CL, mCurrentPage is still used for page change, but for resume and pause, it is detected directly in CallLogFragment using getUserVisibleHint() Bug: 65161134 Test: manual - change call volume after rotation, check ToS FAB not visible after rotation. CallLogFragment is not testable. PiperOrigin-RevId: 169984576 Change-Id: I870cbe3b83e38ac2cb505193309ab4f8e75a859f
2017-09-26Increase location title lengthmdooley
Need to increase character limit for location title text as the title string is now longer than the original character limit. This should have been part of cl/169270157 Bug: 66330058,66330115,66411110 Test: none PiperOrigin-RevId: 169967227 Change-Id: Ib49da4086c190d60da832d4ef64689e44b114150
2017-09-26Fix bug that phone number is not shown for non-contacts. (CNAP, business etc.)wangqi
Phone number should always be shown for non-contacts. Screenshots: https://screenshot.googleplex.com/guKEWdQKDpG https://screenshot.googleplex.com/iMcPte5Vhyc Bug: 64685156 Test: TopRowTest PiperOrigin-RevId: 169961072 Change-Id: Iaf8fc5b1e7f3d386d20deb01f4325efb5e645363
2017-09-26Use help center for GoogleDialer abouttwyen
The about in settings is removed in google dialer, it is accessed through the dialtacts overflow "Help & feedback" instead: https://screenshot.googleplex.com/9L1kdQz6c2B https://screenshot.googleplex.com/FqqdG6X9JTR Note that help articles has not been migrated at this moment. Features in the original about is placed in the overflow https://screenshot.googleplex.com/OmCVPqwGBM9 Version info is stock google help https://screenshot.googleplex.com/EdveVnXUSML Privacy policy/Terms of service opens the browser to the link we had before Open source license opens the same license activity in about. Bug: 34872689 Test: manual PiperOrigin-RevId: 169953610 Change-Id: Ib1c25ddecbf28293b447112cb280a8f9788692d3
2017-09-26Upgrade and refactor latency test over Dialer. Now it has Incall UI latency ↵weijiaxu
besides app launch latency. Alert functionality is not included in this cl. Add a new idlingResource for incall ui and a new method called waitForInCallUiShown in DialerCallEspresso. Add UiListener interface in CallList and insert uilisteners on onCallAdded() and onInCallUiShown(). Also, a g3doc page has been created in http://cl/168901452 to show the dashboards. Test: Run on a local device PiperOrigin-RevId: 169934618 Change-Id: I0ea10aca051c62cd8252ee5a3c9dfbce81316a33
2017-09-26Tweaking verizon's voicemail TOS textmdooley
Change verizon's ToS title to use the string 'visual voicemail' This change seems a bit strange since the verizon legal text uses the string 'Visual Voice Mail', but the title uses 'visual voice mail' screen shots: https://drive.google.com/open?id=0B9o_KvtLkcuIR1lmaUF4OXk1SnFLdS1fbFpfMlFieWlTQ25v https://drive.google.com/open?id=0B9o_KvtLkcuIRURWd0hhYjc4NUdKQ1hzM2RIcG5fSmlHcGhJ Bug: 37340510 Test: update unit tests PiperOrigin-RevId: 169933539 Change-Id: Idba526293604b7a27083a91b86825ef66ce23bcd
2017-09-26Update text of call back number in emergency calls.wangqi
Screeshot: Before: https://screenshot.googleplex.com/bnByOaCTV4O After: https://screenshot.googleplex.com/v0vhkuuvT28 Bug: 38347145 Test: manual PiperOrigin-RevId: 169933363 Change-Id: Ia3728be488ff329531c171b03a3045f1839d1d5e
2017-09-25Merge "Fixing bug where missed call notifications were getting clobbered"Treehugger Robot
2017-09-25Fixing bug where missed call notifications were getting clobberedmdooley
The problem was that the same notification id was being used by both VisualVoicemailNotifier and MissedCallNotifier, causing the voicemail notification update code to filter out missed call notifications instead of ignoring them. Bug: 66168999 Test: manual and verified existing unit tests pass PiperOrigin-RevId: 169925851 Change-Id: Ifa69506a250557dd7bba631122fdd6d0744d6341
2017-09-25Merge changes Ie520c656,I222009beTreehugger Robot
* changes: Don't show Lightbringer disclosure dialog after 1 day since viewed. Fix crash on ending call.
2017-09-25Merge changes If7872377,Ie255f0d9Treehugger Robot
* changes: Update HD and Wifi feature of call log to use framework API. Updated image asset in location permission request.
2017-09-25Don't show Lightbringer disclosure dialog after 1 day since viewed.yueg
We think it's viewed by user if it's showing and user scrolls on call log tab, since action in the same tab that moves the dialog is a strong proof. Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 169763132 Change-Id: Ie520c65627b1e5d364860507321fb268c89e0cf7
2017-09-25Fix crash on ending call.yueg
We moved onUiShowing() call from InCallActivityCommon.onPause to onStop in cl/169615685, which causes the crash since InCallPresenter is cleared up before calling onUiShowing() and mContext is null at that time. This CL fix the crash by also moving the clearup(InCallPresenter.unsetActivity()) from onPause to onStop. It also makes sense because InCallPresenter.onActivityStarted() is called in onStart instead of onPause. Test: manual PiperOrigin-RevId: 169756942 Change-Id: I222009be1b672f8a6dcb8bfdcea2d633c5810575
2017-09-25Update HD and Wifi feature of call log to use framework API.wangqi
Bug: 35359461 Test: none PiperOrigin-RevId: 169752834 Change-Id: If78723774babb86a55e07d4b94d9f1d784791b76
2017-09-25Updated image asset in location permission request.calderwoodra
screenshots http://screen/d2qPOq3h1o1 http://screen/wHcnO5LXRO2 Bug: 65858857 Test: n/a PiperOrigin-RevId: 169748652 Change-Id: Ie255f0d9be958f004c8bc9639d478553f66109d3
2017-09-22Merge "Log non-contact lightbringer actions"Treehugger Robot
2017-09-22Merge "Delay commiting of promo fragment until user visits the contacts tab"Treehugger Robot
2017-09-22Log non-contact lightbringer actionstwyen
video call upgrade and calling from call log is logged Bug: 66222115 Test: DialerCallTest, GoogleCallLogAdapterTest PiperOrigin-RevId: 169703001 Change-Id: Ib4dc3507dec09f49d41cec09d32cc9800477ee8b
2017-09-22Delay commiting of promo fragment until user visits the contacts tabAndroid Dialer
Also fixes an issue where if the promo is shown after the dialpad or search UI is brought up then the promo will be added to the bottom of those UIs. Bug: 64491095 Test: manual PiperOrigin-RevId: 169700496 Change-Id: I76a1aa977df623964b843d8e4b20146ba7c2f874
2017-09-22Merge "Fixed call duration bug."Treehugger Robot
2017-09-22Merge changes I146a5d87,I65e53add,I5163be69,I65376894,I416d7e2d, ...Treehugger Robot
* changes: Don't show bubble when InCallActivity is visible in multi screen mode. Fixed bug where dialer would sometimes show blank screen. Update ViLTE strings to reflect "carrier" video calling Adding some contacts permission guards. Better handling country iso when getting geo location of phone number. Dialer integration of contacts suggestions promo Updated ongoing call notification to reflect video call state. Added dismiss button to location permission request. Refactor CallList to call onUpdateCall and notifyGenericListeners directly. Added location permission request inline the search fragment. Update package assets and strings.
2017-09-22Fixed call duration bug.calderwoodra
SimpleDateFormatter just wasn't working. This CL simplifies this method to something similar to what we had before the call details rewrite. To avoid going through the trouble of having the strings retranslated through the i18n coordinator, I've left them as is and worked around it. screenshots: before: http://screen/eJqs5EijCYe after: http://screen/AbrLFn0caL0 Bug: 63370483 Test: existing PiperOrigin-RevId: 169626011 Change-Id: I160529e276db2fc098a29b005db104e7ac601f15
2017-09-22Don't show bubble when InCallActivity is visible in multi screen mode.yueg
By moving InCallPresenter.onUiShowing() from InCallActivityCommon.onResume/onPause to onStart/onStop. Test: manual PiperOrigin-RevId: 169615685 Change-Id: I146a5d87028040b0f5e587b8163f29d55b9e7ff7
2017-09-22Fixed bug where dialer would sometimes show blank screen.zachh
To repro the bug: 1) Turn on "Don't keep activities" option in developer options 2) Open dialpad 3) Press home 4) Launch dialer from home screen 5) Observe blank screen Bug: 65458054,64129606 Test: unit PiperOrigin-RevId: 169614750 Change-Id: I65e53add0f1f53c510c402f4f8b7ed60dcef273b
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-07 12:57:20 +0000