Age | Commit message (Collapse) | Author |
|
- Search bar text no longer extends underneath the X/clear button.
- Dialpad text is now preserved when it is lowered then raised again without
leaving the search UI.
- Search bar now has a shadow in the search UI
Bug: 73088433
Test: tests for dialpad text logic
PiperOrigin-RevId: 185350273
Change-Id: Ie4c968cba4f187af81121aa40d43c26a762cdd2b
|
|
Earlier we were using the legacy CallLogQueryHandler for querying the voicemail status table. However we should be using UI Listeners instead in NUI. This CL queries the voicemail status table and returns a list of voicemail status', which are then used to display the corresponding error messages.
This CL also moved VoicemailStatus out of the legacy dialer/database and moves it to dialer/voicemailstatus and ensures that there are no dependencies on the legacy dialer/database in the NUI.
Bug: 73139237
Test: Unit tests
PiperOrigin-RevId: 185321023
Change-Id: Id16ea475b6a52da380fbf8b3590dc75cbcdc370e
|
|
Test: N/A
PiperOrigin-RevId: 185242444
Change-Id: I389977105da0eaa8a512f788fcf77df742740f5b
|
|
|
|
* changes:
internal change
Bump version codes of v18
|
|
* changes:
Update title of after call spam dialog.
Used VectorDrawable for Blocked Numbers
Finish AudioRouteSelectorActivity when all calls disconnect.
Add LookupUri to PeopApiPhoneLookupInfo
Implemented NUI menu items.
Implemented GoogleMainSearchController to customize menu to GoogleDialer.
Show reject hint text for all incoming calls
|
|
Bug: 72833789
Test: On a local device.
PiperOrigin-RevId: 185212142
Change-Id: Id8fb82a95f7f2c3972206ec027814b5f732db773
|
|
Bug: 68825005
Test: Added unit tests for CallFeedbackActivity.java
PiperOrigin-RevId: 185183043
Change-Id: Ida17f8e2284388439fc482da47cdc7a19551af00
|
|
Bug: 73160667
Test: n/a
PiperOrigin-RevId: 185172063
Change-Id: I7604d7455841d66d655ee64eed75c82fafbdd3f6
|
|
Bug: 73136533
Test: none
PiperOrigin-RevId: 185160539
Change-Id: I43cc987c646a13d1d012415c0869780317dcb7b8
|
|
Previously the icon is tinted with a BitmapDrawable, which glide ignores. This CL uses a VectorDrawable instead.
Bug: 73089932
Test: N/A
PiperOrigin-RevId: 185084222
Change-Id: I99ef5ccf40aeb52f40d21ef8418ea8f16ec0f2dc
|
|
Bug: 67605985
Test: AudioRouteSelectorActivityTest
PiperOrigin-RevId: 185069195
Change-Id: Icae34dd6374a775c3ad5d3835750bd2fe703dfa0
|
|
Bug: 72108777
Test: Unit tests
PiperOrigin-RevId: 185058075
Change-Id: I161b5127fdc94c0b77536d2901e2c24d7f1eeb7c
|
|
Bug: 72526274
Test: implemented
PiperOrigin-RevId: 185046520
Change-Id: I4740c0f4cadb39058a197f270f4fb0ad54846a69
|
|
This change doesn't implement any of the menu actinos, it just abstracts some
components so that the GoogleDialer toolbar menu can show help and feedback
(and thus, AOSP won't).
Bug: 72526274
Test: implemented
PiperOrigin-RevId: 185033936
Change-Id: I30f8cde6705145ef95efcfc82973a8aa2b16e4ee
|
|
The function setHintText sets the hint text reject text to null when
hintText for answering a call is non-null.
Correcting so the reject text is always be set to
call_incoming_swipe_to_reject regardless of the value of hintText.
This is an upstream change from:
https://android-review.googlesource.com/c/platform/packages/apps/Dialer/+/612667
Bug: 73018780
Test: manual
PiperOrigin-RevId: 185020322
Change-Id: I413f8cf63a1b11e70300536a13c1a8a103d847cc
|
|
|
|
Bug: 73077158
Test: CallLogEntryTextTest, GlidePhotoManagerImplTest, PhoneLookupInfoConsolidatorTest
PiperOrigin-RevId: 185017362
Change-Id: I113472482da2213d17a847054272a22249edc578
|
|
* changes:
Support GID1 for VVM configs
Add VVM Config for Bouygues FR
Fix new special codes
Handle concurrently deleted rows in all updateSmartDialDatabase cursors
Deleted some unused classes
Replace ContactPhotoManager with GlidePhotoManager in new call log.
Fix glide makefile
|
|
This CL allows VVM configs to be specifed with Group identifier, which takes precedence over configs with only MCC/MNC.
TelephonyVvmConfigManger is renamed to DialerVvmConfigManger. It was created when VVM was still in telephony, and need to separate itself from the CarrierConfig app.
Bug: 72666573
Test: Unit tests
PiperOrigin-RevId: 184924155
Change-Id: Ic71e99ed2b3015eed87dfb7e111538ff3b744206
|
|
Bug: 72647204
Test: Tested by Bouygues
PiperOrigin-RevId: 184914101
Change-Id: Ic7dec5ee33a959751062127ab010dc79f6fb2bae
|
|
Bug: 72162360
Test: existing test (SpecialCharSequenceMgrTest)
PiperOrigin-RevId: 184913147
Change-Id: If801b4521939e9fad6ea7227368b9f5146bf46bc
|
|
Bug: 73074317
Test: Not possible, see above
PiperOrigin-RevId: 184893521
Change-Id: Iecb99c658dafa98a2518202c14e67c4494983090
|
|
Test: tap
PiperOrigin-RevId: 184876627
Change-Id: I8db7e08b3fe2f652f8733ecba7f8bc99803944fc
|
|
Glide handles photo loading/caching/placeholders cleaner then ContactPhotoManager.
PeopleApi photos will be downloading photo from the internet using this in a future CL.
Bug: 70533591,70989596
Test: Unit tests
PiperOrigin-RevId: 184864936
Change-Id: I2c374891679f8ce79369a6e929ef172cdd1c5bfd
|
|
Dagger bundles javapoet 1.7.0 while glide needs 1.8.0
Added the dependency above dagger.
Test: make
Change-Id: I31ef9fbcaf0c86672ced9ade9f366c7d96f2617c
|
|
* changes:
Bubble layout change.
Adding voicemail donation promo
|
|
- Flip back-to-call button icon.
- Use different button height for portrait and landscape. In order to make it work, we also create new ViewHolder object when bubble shows and remove reset() when bubble hides.
Bug: 67605985
Test: NewBubbleImplIntegrationTest, NewBubbleImplTest, NewReturnToCallControllerTest
PiperOrigin-RevId: 184768224
Change-Id: If4e613b12e39c647c34f4cb63a7f934043d42ec7
|
|
This cl shows a voicemail donation promo the first time a user
tries to rate a transcription. It also changes the good/bad rating links
to thumbs up/down icons.
The 'learn more' link still needs the real URL.
screen shots:
https://drive.google.com/open?id=0B9o_KvtLkcuIOERUNUJId3FVY3UzUS0wVUdQQVpCS1lmM3Nz
https://drive.google.com/open?id=0B9o_KvtLkcuIWkNVMDV1VTJ4VUMtakVwSE1UTGdUWjljTUV3
https://drive.google.com/open?id=0B9o_KvtLkcuIeU1ndG1palRkTnNJQWVYLXgyMnd4TjBDOFI4
mocks:
https://drive.google.com/file/d/1FIhXDkn3h3xI7liVdJEraq47MoKQM3hi/view
https://drive.google.com/file/d/1uTm58QCvFOBycsGP21vgvEGTq_Imgkqi/view
Bug: 37340510
Test: manual tests
PiperOrigin-RevId: 184745497
Change-Id: I40fd1e211311c3127f215ede2e44b22f345dcf8b
|
|
|
|
|
|
|
|
Bug: 72986691
Test: Unit tests
PiperOrigin-RevId: 184743227
Change-Id: I2e37c2916ce05a72324f68c4530b7f6f3daf23eb
|
|
Bug: 70989534
Test: SpamPhoneLookupTest
PiperOrigin-RevId: 184738576
Change-Id: I63743e5df155a8d31ffa5e2ee3b88e2446023a28
|
|
Bug: 68722828
Test: used zipalign to verify dex files were uncompressed.
PiperOrigin-RevId: 184728960
Change-Id: I6536c96a5ad91b11273ce36786ef9a3aed2ecc9c
|
|
|
|
This Activity is only visible if you flip the flag in the AndroidManifest.
Bug: 72525324
Test: implemented
PiperOrigin-RevId: 184719387
Change-Id: I88d7ee1be537cbe5aa5cd4ee5a8f84d56bddb757
|
|
|
|
Bug: 70989530
Test: Unit tests
PiperOrigin-RevId: 184703655
Change-Id: I043c05a2db9f05745952ee04a84912f7540a9a17
|
|
|
|
* changes:
Don't set the "incomplete" bit for empty numbers.
Updated bottom nav to match redlines.
|
|
Bug: 72525615
Test: VisualVoicemailNotifierTest
PiperOrigin-RevId: 184625656
Change-Id: I8a0b53e12ebe8382f5bc5febd7a6ec448a255f2f
|
|
There will never be contact information for an empty number, so don't bother trying to look them up at render time.
This also prevents a crash in the new voicemail fragment that occurs due to an assertion that voicemail rows will never be incomplete, when it may be possible for a voicemail to exist with an empty number.
Also, don't set short numbers in VoicemailPopulator, since we don't expect this to be possible and would like to avoid crashing in the aforementioned assertion when using simulator.
Test: unit
PiperOrigin-RevId: 184615402
Change-Id: I5286112b57179e002f04de81c04475f30b3e1833
|
|
Bug: 72525324
Test: manual
PiperOrigin-RevId: 184615350
Change-Id: Ic5701d67111e38f73dfa4be31dd89115ad7f5bb8
|
|
* changes:
Match redlines in new call log.
Missed calls now go to MainActivity if you have the component enabled.
|
|
This includes:
-Moved call count to after icons
-Bold PhoneAccount for new calls
-Fixed recycling issues in call type icons and phone account
-Fixed cropping at bottom of "y" character (see b/67913060)
-Reduced nesting in layout
-Removed dimens.xml as it shouldn't be shared by voicemail
-Set the alpha for Wifi/HD icons depending on read/unread status
-Don't color call type icons, except for missed
-Call type icons scale with display size
-Call type icons are larger (18dp) in new UI
Note that FrameLayout is used to ensure that icons/callCount view is not clipped, and instead contact name is ellipsized when the content is too wide to fit.
Bug: 67913060,70989593,70989611
Test: unit and manual
PiperOrigin-RevId: 184605728
Change-Id: Ie36c89354cbe4444ad2b42b6b0040430e396691c
|
|
This CL has a few changes of varying relevance:
Most Relevance:
- MissedCallNotifications will open MainActivity if the component is enabled
(Meaning the launcher is in their app drawer and the flag is flipped).
- Implemented show tab intent (open MainActivity directly to a specific tab)
- Tests
Some Relevance:
- Implemented checking for ACTION_DIAL intents (dialpad will open immediately)
- Tests
Not Relevant but nice QoL changes:
- Added tests for missed calls being marked as read
- Makes espresso tests more horizontal to reduce timeouts
-
Bug: 72525550,72525615
Test: implemented
PiperOrigin-RevId: 184600627
Change-Id: If96a44ce252e97c022ebc1b58fa783b3326035e7
|
|
* changes:
Check for null column before getting contact_id
Remove experiment flag "enable_dual_alphabets_on_t9".
|
|
* changes:
Make transcription text black
Remove bubble v1.
|
|
Bug: 72320869
Test: None :/. See above, I tried
PiperOrigin-RevId: 184576992
Change-Id: I2c9eb095d298043ec3d4bc514c0ffa6bd8a98241
|
|
Test: Existing tests
PiperOrigin-RevId: 184574898
Change-Id: I66f8fabacada8a86a0d36b904a47f38f0290867a
|
|
Makes the color of the transcription text different from the secondary text as expected by the spec.
Bug: 72746803
Test: N/A
PiperOrigin-RevId: 184372919
Change-Id: I3de30a3031a57d1bf3600c491e3881152aee9b03
|
|
Bug: 67605985
Test: manual
PiperOrigin-RevId: 184358120
Change-Id: I17288da2b059f18bd51247e27aa174c7994e6f05
|
|
|
|
Preferred SIM"
|
|
* changes:
Update the SpeakEasy component.
Update text on after call spam notification and dialog.
|
|
|
|
* changes:
Implemented drag to remove in NUI with old favorites.
NUI VM Transcribed by Google UI Support
|
|
|
|
Adds the support for NUI VM Tab to add phone account handle information to Pre-Call. This is used when making a call via the voicemail tab.
Bug: 72449246
Test: existing unit test
PiperOrigin-RevId: 184357841
Change-Id: Icc086c878c86cf5204511860d4524ff2ea1f8935
|
|
Previously all results are validated then checked if there are duplicate. In this CL once duplicates are found it will exit early.
Bug: 72873001
Test: Existing unit tests. No behavior changes except query counts and latency which we don't test.
PiperOrigin-RevId: 184355913
Change-Id: I5ef89c25b100752d939daba69fcfeca3c9d32521
|
|
Test: unit tests
PiperOrigin-RevId: 184352489
Change-Id: If3f2414dd9769dc54035c7fcf5afe925af3006db
|
|
This change also includes:
1. Fixes formatting of phone number in the dialog.
2. Remove body text if the dialog.
3. Update to material design dialog style.
Bug: 72120616
Test: manual
PiperOrigin-RevId: 184350133
Change-Id: I8bdd9c792877822fe18ba6aae6c04136a603dbba
|
|
Test: n/a
PiperOrigin-RevId: 184350063
Change-Id: Iaab629a6658d8b597e047a59b42e451a60c54d79
|
|
This change moves the remove button to overlap the search bar
instead of reside underneath it since we no longer have top tabs.
Bug: 72722364
Test: manual
PiperOrigin-RevId: 184347110
Change-Id: I5bfa70fec9dd7ee6ee0b7270039931f9277291f4
|
|
Shows the "Transcribed by Google" logo for voicemails transcribed by Google
Bug: 72491920
Test: Unit Tests
PiperOrigin-RevId: 184343786
Change-Id: I9d662860e218ff555c65f667f4ee15015df47ab2
|
|
This solution has a couple hacks in it because the DialtactsActivity has a
non-support ActionBar and MainActivity has a support Toolbar. When multiselect
is implemented for NewVoicemailFragment, we should be careful to use support
action mode instead of non-support action mode so that the transitions and
styling are seamless and consistent.
Bug: 72722083
Test: manual
PiperOrigin-RevId: 184343414
Change-Id: Id16652de2d0add7b7c304d1cedb429fe9b1cf338
|
|
|
|
Transcription state column is needed for voicemail transcriptions. This CL adds the support for it in the NUI so that it maybe used by the VM Tab.
Bug: 72491920
Test: Unit Tests
PiperOrigin-RevId: 184335015
Change-Id: I14a71890224216c957e0d6146af9dafaa1550865
|
|
|
|
We do not expect any invalid numbers for the voicemail tab. We crash the app if an invalid number is detected in the NUI VM tab, so that we can handle invalid numbers for voicemail accordingly.
Bug: 72863479
Test: N/A
PiperOrigin-RevId: 184333020
Change-Id: Ifd769da08c7cba3aab555b56eef799de47810fb3
|
|
|
|
This change updates MainActivity to defer lifecycle callbacks and other
relevant methods to which ever peer is active, old or new.
The old peer implements the logic for the old fragments.
The new peer implements the logic for the new fragments.
MainActivity implements the logic that is shared or common between the two like
last tab, post call, search, dialpad, ect.
Bug: 72525324
Test: pending
PiperOrigin-RevId: 184317828
Change-Id: Ie73733f2a3837c9d63e54cf5b142984633340731
|
|
|
|
This CL copies the code dealing with refreshing the annotated call log from the NewCallLogFragment and applies it to the NewVoicemailFragment. This is necessary since the NewVoicemailFragment should be able to refresh the annotated call log without depending on the user going to the call log fragment for the update. The only thing we don't copy over is the logic and handling when the CP2 info is incomplete for a number (INVALID number), however we do not expect any invalid numbers for voicemail and as such have added an assert for that.
Bug: 72523272
Test: Unit Tests
PiperOrigin-RevId: 184292549
Change-Id: I2994974fe60221a4854fed5f9d80d3d428449ae9
|
|
* changes:
internal change
Add suggestion reason ACCOUNT
|
|
Bug: 68825005
Test: Added unit tests on CallFeedbackListenerImpl, CallFeedbackNotificationManager and DialerCall. Also manually verified the change.
PiperOrigin-RevId: 184211115
Change-Id: I50927036c3cd5d47862704376e2eef108c473fbf
|
|
Bug: 72817785
Test: Unit tests
PiperOrigin-RevId: 184178722
Change-Id: I7154058ab7ac1a94adc781a1aa9a49a3f13c1599
|
|
|
|
Bug: 72163953,72749906
Test: Unit tests
PiperOrigin-RevId: 184167756
Change-Id: I19f4a71fb443fbb31960be486c3c5e996535fc32
|
|
dialog after a call, instead of to hang up the call."
|
|
a call, instead of to hang up the call.
Bug: 72120616
Test: none
PiperOrigin-RevId: 184162123
Change-Id: I20dbdb258ad0640fa4ed8cf6492549ba9c62eda6
|
|
|
|
|
|
* changes:
Updating Dialer v17 licenses.
Add a BatchSpamChecker for InAppSpam.
Implemented missed call/voicemail notifications in NUI.
Fullly disable VVM if carrier VVM app is installed.
|
|
Now when the user exits Dialer NUI, next time they open Dialer they will return
to the same location they were before.
This change also preserves active tab through configuration changes.
Bug: 72068052,72722083
Test: MainActivityIntegrationTest
PiperOrigin-RevId: 184085830
Change-Id: Ic6d3bf7c9089b38d480dfc658127eec6c9c55bfb
|
|
Bug: 72722364
Test: existing
PiperOrigin-RevId: 184083186
Change-Id: Ia51a50b343f75eec74a02dc6b4383341f939793d
|
|
Bug: 72757397
Test: 'N/A'
PiperOrigin-RevId: 184082977
Change-Id: I3375fe14b81dffc4d8b54468c95b67ebe2b38fd1
|
|
Bug: 72443587
Test: BatchSpamCheckerTest, SpamDatabaseUtilsTest
PiperOrigin-RevId: 184076803
Change-Id: Ib11ca44190a28e28843ef4674c0abebc4203c46a
|
|
This CL shows and updates the missed call/voicemail count in the bottom nav. It
also clears the call log notifications when the user either leaves the call log
fragment or closes the activity after 3 seconds of browsing the call log.
Bug: 72525595
Test: tba
PiperOrigin-RevId: 184071058
Change-Id: I540c9e3d815e022b5e311cb02a3995e241b8a984
|
|
Previously it is only disabled when the user has not changed the VVM settings, and the user can still re-enable it.
After this CL, VVM will always be disabled, and the settings will be hidden.
Bug: 72668279
Test: Unit tests
PiperOrigin-RevId: 184063245
Change-Id: I42c12f3fd2f3e397158e08b26875a7e99a766d33
|
|
|
|
It's an indicator that the button triggers another list.
Bug: 67605985
Test: manual
PiperOrigin-RevId: 184042869
Change-Id: I3fea526a322dcc3935af111ebd0916b7c5ffcb24
|
|
|
|
Bug: 67605985
Test: NewBubbleImplTest, NewBubbleImplIntegrationTest, NewReturnToCallControllerTest
PiperOrigin-RevId: 184026033
Change-Id: Ie141ce9a0265ce3a08c01943cdeb94e2cd962e9f
|
|
|
|
* changes:
Don't override contactExists if there is no update from Cequint Caller ID.
Make default lastModified timestamp configurable
Added old call log to NUI.
Add old speed dial fragment to NUI.
Added badge count feature to bottom nav.
Allow delete of Restricted number entries
Update FragUtils to encourage better readability in Activities.
|
|
Bug: 72162360
Test: SpecialCharSequenceMgrTest
PiperOrigin-RevId: 183921310
Change-Id: I3a47106a42a6e7c3b903f595f690c7d125e72a04
|
|
Bug: 72485878
Test: none
PiperOrigin-RevId: 183915863
Change-Id: Ib035855d944c91145418222cc390be066744b4fb
|
|
Bug: 72320869
Test: manually verified that the config value is used
PiperOrigin-RevId: 183911716
Change-Id: I15bc2c4505306eb65446a792b305226255ae4315
|