Age | Commit message (Collapse) | Author |
|
This CL also updates the tests that were TODOs from http://b/70401224 to allow testing the MediaPlayerView
SCREENSHOT:
Today: http://screen/8KvVtLtHeq4
Older: http://screen/5oskBZPbDR5
Test: Unit tests
PiperOrigin-RevId: 178699528
Change-Id: Idab797eff18fd277618938a8a54da350c60b3d54
|
|
state after recycling."
|
|
|
|
|
|
after recycling.
This CL adds the support for playing voicemails, changing the play button to pause button when playing the voicemail, updating the seekbar and duration timer when the voicemail is being played. It also adds the support to preserve the state of the media player such that when scrolling and recycling views, when an expanded and playing voicemail is recycled back into view, it's most recent state is shown i.e the duration and the seekbar are upto date.
Video: https://drive.google.com/open?id=1CKbLK5-1YDeXBZFiKvuTxoPuFJQ1rbj7
Test: Unit tests
PiperOrigin-RevId: 178681663
Change-Id: Ifdd1d945572926bdc7d652aa7a876d3156fc21ce
|
|
Instead of just showing avatar for active or background call, we should also show avatar for other calls. In the order:
1. incoming call
2. outgoing call
3. active or background call
Test: NewReturnToCallControllerTest
PiperOrigin-RevId: 178675371
Change-Id: Ibf8b757821d9a6420ba56439e4f6a93e9e5c3d91
|
|
When an activity is killed by the system, a new UiListener is created and attached, but it doesn't have its executor set. Rather than save it as an instance field, just get the Ui executor when needed, by passing the context to the listen method.
Bug: 70510707
Test: unit and manual via "don't keep activities" developer option
PiperOrigin-RevId: 178668338
Change-Id: I5360b525377edab5f3a117d1f0f50bf6da6a6f0c
|
|
|
|
Test: TAP
PiperOrigin-RevId: 178650781
Change-Id: I299907ac43d48b984b092433c9b651aadb17c62a
|
|
|
|
This change consists of mainly 3 things:
- Update contacts fragment to meet AddFavoriteActivity requirements
- Implement AddFavoriteActivity
- Passing the contact back to SpeedDialFragment
Bug: 36841782
Test: SpeedDialIntegrationTest
PiperOrigin-RevId: 178461265
Change-Id: Ib3a13eae311acf6ce10a94df4f2c95b9af120cff
|
|
* changes:
Add "Set up" and "Invite" for video to call log entry actions
Fix voicemail populator bug and change emergency call to emergency call back.
|
|
|
|
Bug: 70034799
Test: GoogleCallLogAdapterTest
PiperOrigin-RevId: 178434462
Change-Id: I220cb74116aaa5dc3518de0dd20f2cdefda4049b
|
|
The voicemail populator bug was caused by missing Voicemail.PHONE_ACCOUNT_COMPONENT_NAME.
Since we are making incoming emergency call by simulator. The name should be emergency call back.
Bug: 70246587
Test: On a local device.
PiperOrigin-RevId: 178424437
Change-Id: I471b2d19d1d431e2180a1f0481153831a9e51040
|
|
Including:
1. Add opacity animation when show/hide/expand/collapse
2. Decrease animation duration when hide
3. Animate small icon when switch left/right side instead of changing gravity
Bug: 67605985
Test: manual
PiperOrigin-RevId: 178413027
Change-Id: I8a915bbed60a2841ccc534f2c68575da062c82e3
|
|
column COALESCED_IDS."
|
|
COALESCED_IDS.
For a row in the coalesced call log, COALESCED_IDS contains IDs of the corresponding rows in the annotated call log. These IDs will be used to (1) launch CallDetailsActivity or (2) delete the row in the call log UI.
Bug: 70218437
Test: CoalescerTest, CoalescedAnnotatedCallLogCursorLoaderTest
PiperOrigin-RevId: 178392968
Change-Id: I2d6cd46bec4d47a9e18941b7a019f39403fa76f5
|
|
|
|
Phone.CONTENT_FILTER_URI."
|
|
* changes:
Implemented PhoneLookupDataSource#onSuccesfulFill.
Fixed compile error in AOSP due to use of guava 23 API.
Add isActivated check to Duo interface
Bug: 68953167
Made PhoneLookupDataSource implementation async.
Renamed PhoneLookup#bulkUpdate to #getMostRecentPhoneLookupInfo.
Added bindings for ListeningExecutorServices.
Use explicit version constant for AD ceiling.
Add Assisted Dialing Call Details Implementation.
Switched CallLogDataSource interface to be Future based.
|
|
Bug: 70034799
Test: DuoImplTest
PiperOrigin-RevId: 178326133
Change-Id: Ie4a0e717d9f1c9c066cb535a44721aeea3c265cc
|
|
Bug: 70336190,70348007
Test: existing
PiperOrigin-RevId: 178325355
Change-Id: Ic43beb7a10c5127083ed33e69603b25b2831754f
|
|
Required adding applyBatch functionality to PhoneLookupHistoryContentProvider so that the updates can be performed in a transaction. This code was just copied and modified from AnnotatedCallLogContentProvider.
Also removed the trigger which limited the size of the PhoneLookupHistory, since we now delete rows from PhoneLookupHistory when the last occurrence of a number is deleted from AnnotatedCallLog. Since AnnotatedCallLog is bounded to 1000 rows PhoneLookupHistory is now indirectly bounded by that as well.
Bug: 34672501
Test: unit
PiperOrigin-RevId: 178323464
Change-Id: I233163fe70641b0e4b1d4c5c0e8970ad0b4b167d
|
|
Futures.submitAsync is V23 and AOSP is currently stuck at V20.
This is just a completely non-sensical dummy implementation of DialerFutureSerializer until we can figure out what to do.
Test: tap
PiperOrigin-RevId: 178323108
Change-Id: I1dc2c8ddfa7ef3e15170543dadefbe4fc2e19226
|
|
Bug: 70034799
Test: GoogleCallLogAdapterTest
PiperOrigin-RevId: 178292533
Change-Id: I9769a7fbe0edcc42eff99d636334a0c2eaf14779
|
|
Test: Bubble.show
PiperOrigin-RevId: 178265418
Change-Id: Iad3b85b10aae736953a64824bac1631d506892c8
|
|
We were previously calling get() which can cause deadlocks.
Bug: 34672501
Test: existing
PiperOrigin-RevId: 178192772
Change-Id: Id9088b12b765307c778d101d847cb1016ea828d1
|
|
This is just to more clearly convey what the method does.
Bug: 34672501
Test: existing
PiperOrigin-RevId: 178188575
Change-Id: Id02f34b1d79346ecd8ca9eebc043fe9b3063264b
|
|
Use them where appropriate.
Bug: 34672501
Test: existing
PiperOrigin-RevId: 178182298
Change-Id: If454225e0d636c7cb14b5af02d46780d7732abf0
|
|
Test: tap
PiperOrigin-RevId: 178121918
Change-Id: Ia60c844181b63b527ce9753a9bef96d7b7076c40
|
|
This includes all of the work specified in the UX layouts,
with the exception of the parenthetical country code.
Because the canonical mapping of dial prefixes to country
codes is not contained in this package, some thought needs to
be given on the best way to implement this part of the spec.
This change also introduces a fallback error text, in case the
client experiences bad data from the call log.
Test: new unit tests
PiperOrigin-RevId: 178038123
Change-Id: I88eec72a73820e092f24c5f53ee9520a42486ada
|
|
Bug: 34672501
Test: existing
PiperOrigin-RevId: 178038086
Change-Id: I1230992ad04bb4415f5a29bd15802d23dff88012
|
|
* changes:
Add DialpadView's OnPreDrawListener in onFinishInflate() to ensure the layout is inflated before adjustments are made.
Added manifest override for PhoneLookupHistory provider.
|
|
* changes:
Hide bubble in (New)ReturnToCallController.tearDown().
Grouping each listener's logic in an inner class in CallDetailsActivity.
Allow VVM activation to be rerun if carrier sent STATUS SMS
Check for null subscription info list in TelecomUtil#getSubscriptionInfo.
Ignore "new" voicemails that are too old for notifications
Display the automatically detected home country in assisted dialing settings.
Add DATA_USAGE column to the annotated call log.
Temporarily disable PhoneHistoryRecorder.
Bubble v2 animation changes.
Refactor Assisted Dialing Settings into standalone activity.
Added PhoneLookupHistoryRecorder.
Added PhoneLookupSelector.
|
|
|
|
layout is inflated before adjustments are made.
Bug: 69665429
Test: DialpadFragmentIntegrationTest
PiperOrigin-RevId: 178031541
Change-Id: I8e8799fd26a151a5357cd0bf4e2d886c802a15a5
|
|
Enabled PhoneLookupHistoryRecorder.
Bug: 34672501
Test: manual
PiperOrigin-RevId: 178030404
Change-Id: I4626262ebed14a9478f5ac8fc89fc81655e98b70
|
|
There is the case that onDisconnect() is not called but InCallService is unbind. Currently we only hide bubble when call disconnected. We should also do it when InCallService is unbind.
Test: NewReturnToCallControllerTest, ReturnToCallControllerTest
PiperOrigin-RevId: 178029862
Change-Id: I6806c5c80adb06317f09019bdf3420b462225945
|
|
Bug: 70218437
Test: Existing tests
PiperOrigin-RevId: 178029820
Change-Id: I60afe7c6d61a61ce4aa2fd2e30fbd5d869072930
|
|
Carrier might send STATUS SMS actively if the account configuration has changed. Previously it will be discarded if the account is already activated. In this CL activation will be rerun if the messageData already exist since it is initiated by an STATUS SMS.
Bug: 69857261
Test: ActivationTaskTest
PiperOrigin-RevId: 178028542
Change-Id: I6d103569c2be4eeadc3a7877d160fff03ad8b40e
|
|
The javadoc for the method states that it can return null if the current state is unknown.
Bug: 70224613
Test: unit
PiperOrigin-RevId: 178020566
Change-Id: I4cd6f76b7c0572d1c9797eba4bf9c3981846468e
|
|
Bug: 68049435
Test: CallLogNotificationQueryHelperTest
PiperOrigin-RevId: 178016400
Change-Id: I6ddbebc9edce6830966072d42cf05eb21f26c8ac
|
|
Some degenerative cases are considered, like detected home countries that
are currently unavailable.
Bug: 68775522
Test: unit tests
PiperOrigin-RevId: 178007559
Change-Id: Id85d7a2af1aa67757450bbbc80fd3ee67790b21c
|
|
Data in this column are copied from the DATA_USAGE column in the system call log (android.provider.CallLog.Calls#DATA_USAGE).
Bug: 70218437
Test: AnnotatedCallLogDatabaseHelperTest, SystemCallLogDataSourceTest
PiperOrigin-RevId: 177999609
Change-Id: I64d70734e8e85767f1e93a4a22ce2aae6c2168a1
|
|
PhoneLookupHistory provider isn't correct overridden in GoogleDialer manifest. I'l fix that in a later CL.
Test: manual
PiperOrigin-RevId: 177988816
Change-Id: I42af03d22db50bd70219d52826294529462bae43
|
|
Including:
- expanded view expands/collapses from top of itself
- small icon on avatar shows on left side when bubble is on right side
- when expand on bottom, bubble move up a bit so that expanded view doesn't go off screen. It also go back to previous position when collapse.
- remove animation for collapse when move expanded bubble
This change should not enable bubble v2 for anyone.
Bug: 67605985
Test: manual
PiperOrigin-RevId: 177974562
Change-Id: Id83f3f744b717d51fbe58e58769ac2cd2810d2b5
|
|
This will enable easier porting back into the framework.
Test: existing tests
PiperOrigin-RevId: 177960274
Change-Id: I1aa18734758900a93b19f4bb87b7759f6f7ca370
|
|
When a call is added in InCallUi, it fetches the current PhoneLookupInfo for the call and writes it to PhoneLookupHistory.
Required updating PhoneLookupHistoryContentProvider#update to use "replace" to (presumably) atomically insert when a row is missing.
Bug: 34672501
Test: unit
PiperOrigin-RevId: 177896892
Change-Id: I43f9ded240a81156722be816a9635d586de642a1
|
|
This class is responsible for prioritizing and selecting data from a PhoneLookupInfo object, which contains information from many phone lookup sources.
Bug: 34672501
Test: unit
PiperOrigin-RevId: 177893924
Change-Id: Ib98a4656fe87141162a7ac53af4a0ad421196046
|
|
Also added onSuccessfulBulkUpdate method.
It is safer for each PhoneLookup to keep track of its own last processed time via shared prefs where the value saved is the actual last processed timestamp from the underlying data. This is because it is difficult or impossible to select a single time that spans lookups due to queries being run and processed at different times.
The onSuccessfulBulkUpdate method is provided as a hook for PhoneLookups to persist their shared pref once they know the result of bulkUpdate have been successfully saved.
Finally, removed usage of the lastModified timestamp from PhoneLookupHistory in PhoneLookupDataSource since I believe the cases it was originally intended to cover are now handled by populateInserts().
Bug: 34672501
Test: unit
PiperOrigin-RevId: 177891586
Change-Id: I072409fc217e4d7e36816548862e8b358aebf165
|
|
am: 7370d93ade
Change-Id: I6990c2449d6bef4621014dd6d7fe8f49b45c4fe2
|
|
|
|
The filtration logic will only show countries
in the country picker if the feature is enabled
for those countries.
This will not cover the regressive case where
a user has already selected a default option,
but then the option is later removed. This
behavior is currently undefined.
Bug: 69274259
Test: unit tests
PiperOrigin-RevId: 177881199
Change-Id: I113f6d25249c42c1bd98383fd6ee0bc6a8c0e615
|
|
am: 9ffe71da47
Change-Id: I350b28a94971f1169fb70373b1d1a6ecf37e8ae4
|
|
* changes:
Rollback the broadcast in-call UI changes since it breaks AOSP.
Rollback the rollback of broadcast in-call UI changes.
|
|
Test: none
PiperOrigin-RevId: 177596967
Change-Id: Iac15302aca9593bfd4d1cbe5a8336ed6fd71b21c
|
|
Test: none
PiperOrigin-RevId: 177530923
Change-Id: I228ce134b49065bd137296f5ab99375bac9e9fa3
|
|
am: 9acd105472
Change-Id: I2a7baeace7ad935ae8294345e829acc9ff7e271f
|
|
* changes:
Implemented new favorites list UI.
Action bar is no longer visible in dialpad search after configuartion change.
|
|
Bug: 36841782
Test: implemented
PiperOrigin-RevId: 177516412
Change-Id: If9478ce22c10fd17e352d5fdcc2c0bef5e14a6d8
|
|
If a user, for example, opened dialpad search then entered multiwindow mode,
the actionbar would be visible and search results maligned. This change
corrects that by updating it's state once possible.
Test: manual
PiperOrigin-RevId: 177497979
Change-Id: I41d4910b5bb92e29623960e7d4741a9a961e5b9e
|
|
am: 9db815f051
Change-Id: I8fdf785b6ac3c16b2d9ecabdbdcc3a7131124c10
|
|
* changes:
Rollback Broadcast in-call UI changes.
Fix NPE crash on video call.
|
|
Test: none
PiperOrigin-RevId: 177490090
Change-Id: Ide2ea08f89b8a8072913617e6ce4587abffc7df4
|
|
Bug: 69960961
Test: manual
PiperOrigin-RevId: 177486235
Change-Id: I241867456830e0a8479ed0652aac71abc77c86e3
|
|
am: 1d18e69c85
Change-Id: I19766bea103778f6502c3176d5460bd3ffa61eda
|
|
|
|
Copybara is fixed for AOSP export
Bug: 68665330
Test: rollback
PiperOrigin-RevId: 177480870
Change-Id: I0ba38e213bb840436fa6dafc4af0a79019ee93f4
|
|
am: 49842c4701
Change-Id: Ic0677c87716d8f4fbac9b2d3b6f010a153179870
|
|
* changes:
Implemented fill for PhoneLookupDataSource.
Search contacts now update when there are changes to the cp2 db.
|
|
Rewrote FakePhoneLookup to be more realistic.
Bug: 34672501
Test: unit
PiperOrigin-RevId: 177376374
Change-Id: Ifcd52b16b7046f39d1bfc0e8b8e76452a9daadd2
|
|
Since we close the original cursor we queried in the cursor loader,
we need to assign a new content observer to the cursor we build so
that our search results update when there are changes to the contacts
db.
Bug: 63830179
Test: manual
PiperOrigin-RevId: 177368459
Change-Id: I025ea70334265cb2fdc651ed7ea046b039738e94
|
|
am: b1e7530af2
Change-Id: I3812e62448d4851afcea7d35842c27dd28b00b0c
|
|
* changes:
Bump API ceiling for Assisted Dialing.
Add flag to control default assisted dialing state during precall flow.
|
|
Bug: 69857502
Test: TAP
PiperOrigin-RevId: 177367228
Change-Id: Id79546672fa8bf3bf85bbe569ef638970b1365d8
|
|
Currently, the only other client that is initiating
calls is Contacts, and we consider that to be a
non-idle-dial.
Bug: 69860859
Test: existing unit tests
PiperOrigin-RevId: 177367226
Change-Id: I22de38dc973f5a1eecfe42833110690744c317fd
|
|
am: 226b01b4fb
Change-Id: I45041d6564d53277b22209ccd7c0a2b337752fd1
|
|
|
|
"This phone's number: xxx" is shown for emergency call which replaces in call
timer. This change move it to under emergency location service so timer could
be shown again.
Bug: 69810801
Test: manual
PiperOrigin-RevId: 177363955
Change-Id: I543fbbee869923800ffd92a5799819b712f0b953
|
|
am: b33463c7cd
Change-Id: I89fc96f42158934dd10da45ec42ed88544b24f6a
|
|
|
|
am: 3fbdd1c482
Change-Id: I7283753d282b15fd2a76f76a3921ed692af3e117
|
|
|
|
am: b500efc0b0
Change-Id: I8b0ea80772d52457e38cf8b6ff617a05c3c52c87
|
|
am: 0e029e7f6d
Change-Id: I26a5a05e9288ddb952dad3eae973f7d31644be72
|
|
* changes:
Delete voicemails when disabling visual voicemail
Switching to alarms and exponential backoff while polling for transcription result
Format number for SIM selection
Disable phone number formatting on the dialpad when making domestic call to Argentina mobile numbers.
|
|
|
|
am: 38db0c78bf
Change-Id: I3857acc52182d915bef2ec6ab5e2e1479008da8d
|
|
* changes:
Prevent PreCallActivity from showing in lockscreen if it is not started in the lockscreen
Prevent change SIM icon from showing during a voicemail call
Expose user home country code as public method in Mediator Interface.
Update assisted dialing setting text.
Contact list no longer jumps to the top when the cp2 database updates.
Refactor DialpadFragment's DtmfKeyListener
Adjust strings for select SIM dialog
Add impressions for dual sim features
|
|
In a subsequent change, the assisted dialing settings
will be able to use the parsing logic to filter
the available countries listed in the settings.
Bug: 69274259
Test: existing tests
PiperOrigin-RevId: 177338864
Change-Id: I8ef76874d5f6d885b415174371225b738cc68716
|
|
Test: N/A
PiperOrigin-RevId: 177336359
Change-Id: Icec2eacef55ea6c1b3aad00fe10cde6284c89e25
|
|
For privacy reasons we now delete all voicemails and transcriptions when
the user disables visual voicemail, (after confirming that they want to do this
via a dialog).
Note: we only delete voicemails whose source package is the google dialer.
Note: the voicemails will be re-downloaded and re-transcribed if the user re-enables visual voicemail
Bug: 69323147
Test: manual and unit test
PiperOrigin-RevId: 177315139
Change-Id: Ie04496dc5960b485794733fbf74f7f704e806023
|
|
result
This cl switches the way asynchronous transcription tasks poll for their
results. it has been observed that sometimes the server side transcription
takes longer than expected (sometimes many minutes), so instead of blocking
a thread for all that time this cl schedules an alarm for the next time to
poll. it also uses an exponential backoff scheme to determine the poll times
and increases the maximum total polling time from 20 seconds to 20 minutes.
Bug: 66966157
Test: manual and unit tests
PiperOrigin-RevId: 177257577
Change-Id: Ib2998f03cc418d5241ccffec71ba3945c9fe4cbc
|
|
Bug: 69812286
Test: PhoneNumberHelperTest
PiperOrigin-RevId: 177227451
Change-Id: I6cf53e50d17860f4374cbd9a94451bc0731905a4
|
|
Argentina mobile numbers.
Bug: 30224215
Test: DialerPhoneNumberFormattingTextWatcherTest, DialpadFragmentIntegrationTest
PiperOrigin-RevId: 177218942
Change-Id: Id6eaaad2f6d81e591d59a1d8444f45fb06f3f8d5
|
|
newInstance() defaults setDefaultResId to 0 and if it is written into the args the real default ID will not be used.
Bug: 69804734
Test: SelectPhoneAccountDialogFragmentTest
PiperOrigin-RevId: 177194281
Change-Id: Ic2b50fa741d812fd464d5e81199b040ef4c07195
|
|
the lockscreen
Bug: 69812359
Test: PreCallActivityTest
PiperOrigin-RevId: 177193665
Change-Id: Ic61819b8456ee22c01228d6be2255b3f2c1e418a
|
|
Calling the VM other number is to complicated for this release.
Bug: 69803593
Test: CallButtonPresenterTest
PiperOrigin-RevId: 177193486
Change-Id: I4149abe1d6eea48bb5399e12b9ce43a8e1ef4b37
|
|
This will be used in a subsequent change to show the user
the default/predetected country code in the assisted dialing
settings.
Bug: 68775522
Test: unit tests
PiperOrigin-RevId: 177168946
Change-Id: Ic738a6ddde8766962a725668f6db5056ab0bcafd
|