diff options
Diffstat (limited to 'java/com/android/dialer/calllogutils/CallLogIntents.java')
-rw-r--r-- | java/com/android/dialer/calllogutils/CallLogIntents.java | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/java/com/android/dialer/calllogutils/CallLogIntents.java b/java/com/android/dialer/calllogutils/CallLogIntents.java index 05af8bfc7..227b15eed 100644 --- a/java/com/android/dialer/calllogutils/CallLogIntents.java +++ b/java/com/android/dialer/calllogutils/CallLogIntents.java @@ -19,10 +19,10 @@ import android.content.Context; import android.content.Intent; import android.provider.CallLog.Calls; import android.support.annotation.Nullable; -import android.text.TextUtils; import com.android.dialer.callintent.CallInitiationType; import com.android.dialer.callintent.CallIntentBuilder; import com.android.dialer.calllog.model.CoalescedRow; +import com.android.dialer.phonenumberutil.PhoneNumberHelper; import com.android.dialer.precall.PreCall; import com.android.dialer.telecom.TelecomUtil; @@ -39,18 +39,16 @@ public final class CallLogIntents { */ @Nullable public static Intent getCallBackIntent(Context context, CoalescedRow row) { - // TODO(zachh): Do something with parsed values to make more dialable? - String originalNumber = row.number().getRawInput().getNumber(); - // TODO(zachh): Make this more sophisticated, e.g. return null for non-dialable numbers? - if (TextUtils.isEmpty(originalNumber)) { + // TODO(zachh): Don't use raw input. + String normalizedNumber = row.number().getRawInput().getNumber(); + if (!PhoneNumberHelper.canPlaceCallsTo(normalizedNumber, row.numberPresentation())) { return null; } // TODO(zachh): More granular logging? - // TODO(zachh): Support assisted dialing. return PreCall.getIntent( context, - new CallIntentBuilder(originalNumber, CallInitiationType.Type.CALL_LOG) + new CallIntentBuilder(normalizedNumber, CallInitiationType.Type.CALL_LOG) .setPhoneAccountHandle( TelecomUtil.composePhoneAccountHandle( row.phoneAccountComponentName(), row.phoneAccountId())) |