summaryrefslogtreecommitdiff
path: root/java/com/android/dialer/assisteddialing
diff options
context:
space:
mode:
Diffstat (limited to 'java/com/android/dialer/assisteddialing')
-rw-r--r--java/com/android/dialer/assisteddialing/ConcreteCreator.java2
-rw-r--r--java/com/android/dialer/assisteddialing/Constraints.java8
-rw-r--r--java/com/android/dialer/assisteddialing/ui/res/xml/assisted_dialing_setting.xml4
3 files changed, 11 insertions, 3 deletions
diff --git a/java/com/android/dialer/assisteddialing/ConcreteCreator.java b/java/com/android/dialer/assisteddialing/ConcreteCreator.java
index 1790b8f3f..9dc197c89 100644
--- a/java/com/android/dialer/assisteddialing/ConcreteCreator.java
+++ b/java/com/android/dialer/assisteddialing/ConcreteCreator.java
@@ -71,7 +71,7 @@ public final class ConcreteCreator {
}
if (!PreferenceManager.getDefaultSharedPreferences(context)
- .getBoolean(context.getString(R.string.assisted_dialing_setting_toggle_key), false)) {
+ .getBoolean(context.getString(R.string.assisted_dialing_setting_toggle_key), true)) {
LogUtil.i("ConcreteCreator.createNewAssistedDialingMediator", "disabled by local setting");
return new AssistedDialingMediatorStub();
diff --git a/java/com/android/dialer/assisteddialing/Constraints.java b/java/com/android/dialer/assisteddialing/Constraints.java
index c4b5278cb..3766a6daa 100644
--- a/java/com/android/dialer/assisteddialing/Constraints.java
+++ b/java/com/android/dialer/assisteddialing/Constraints.java
@@ -25,6 +25,8 @@ import android.telephony.PhoneNumberUtils;
import android.text.TextUtils;
import android.util.ArraySet;
import com.android.dialer.common.LogUtil;
+import com.android.dialer.logging.DialerImpression;
+import com.android.dialer.logging.Logger;
import com.google.i18n.phonenumbers.NumberParseException;
import com.google.i18n.phonenumbers.PhoneNumberUtil;
import com.google.i18n.phonenumbers.Phonenumber.PhoneNumber;
@@ -216,6 +218,8 @@ final class Constraints {
// framework
return Optional.of(phoneNumberUtil.parseAndKeepRawInput(numberToParse, userHomeCountryCode));
} catch (NumberParseException e) {
+ Logger.get(context)
+ .logImpression(DialerImpression.Type.ASSISTED_DIALING_CONSTRAINT_PARSING_FAILURE);
LogUtil.i("Constraints.parsePhoneNumber", "could not parse the number");
return Optional.empty();
}
@@ -227,6 +231,8 @@ final class Constraints {
if (parsedPhoneNumber.get().hasCountryCode()
&& parsedPhoneNumber.get().getCountryCodeSource()
!= CountryCodeSource.FROM_DEFAULT_COUNTRY) {
+ Logger.get(context)
+ .logImpression(DialerImpression.Type.ASSISTED_DIALING_CONSTRAINT_NUMBER_HAS_COUNTRY_CODE);
LogUtil.i(
"Constraints.isNotInternationalNumber", "phone number already provided the country code");
return false;
@@ -244,6 +250,8 @@ final class Constraints {
if (parsedPhoneNumber.get().hasExtension()
&& !TextUtils.isEmpty(parsedPhoneNumber.get().getExtension())) {
+ Logger.get(context)
+ .logImpression(DialerImpression.Type.ASSISTED_DIALING_CONSTRAINT_NUMBER_HAS_EXTENSION);
LogUtil.i("Constraints.doesNotHaveExtension", "phone number has an extension");
return false;
}
diff --git a/java/com/android/dialer/assisteddialing/ui/res/xml/assisted_dialing_setting.xml b/java/com/android/dialer/assisteddialing/ui/res/xml/assisted_dialing_setting.xml
index 8e3c62dde..806edfcf9 100644
--- a/java/com/android/dialer/assisteddialing/ui/res/xml/assisted_dialing_setting.xml
+++ b/java/com/android/dialer/assisteddialing/ui/res/xml/assisted_dialing_setting.xml
@@ -18,9 +18,9 @@
xmlns:android="http://schemas.android.com/apk/res/android">
<SwitchPreference
- android:defaultValue="false"
+ android:defaultValue="true"
android:key="@string/assisted_dialing_setting_toggle_key"
android:title="@string/assisted_dialing_setting_title"
android:summary="@string/assisted_dialing_setting_summary" />
-</PreferenceScreen> \ No newline at end of file
+</PreferenceScreen>