summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorYorke Lee <yorkelee@google.com>2013-08-05 20:34:40 -0700
committerYorke Lee <yorkelee@google.com>2013-08-22 08:56:13 -0700
commitc36684277aa45085999284bfe71cb8be71b3a464 (patch)
treef5aab137e7bf3390dfb8e9007b9e289a550ee90d /tests
parent2c0ea3b35b9983619c12ab0a4f50e14cc70f801e (diff)
Rewrite animation logic
* Remove old animation-related code. In the past, animations would be applied to a view everytime getView was called. This is no longer the case so it fixes the issue of animations triggering everytime the list was scrolled, dialpad opened, etc. * Make PhoneFavoriteMergedAdapter (and PhoneFavoritesTileAdapter) return stable IDs, so that they can be used for animations. The ID schemes are described below: (N + 1) to -2: CallLogAdapterItems, where N is equal to the number of call log items -1: All contacts button 0 to (N -1): Rows of tiled contacts, where N is equal to the max rows of tiled contacts N to infinity: Rows of regular contacts. Their item id is calculated by N + contact_id, where contact_id is guaranteed to never be negative. * Perform animations by saving each view's offset before the data set changes, and then applying a translation animation to them based on their new offsets in the updated list view. This is the same method described by the framework team at : http://graphics-geek.blogspot.com/2013/06/devbytes-animating-listview-deletion.html In our case, we need to perform both horizontal and vertical animations because of the contact tile favorites. Bug: 10294203 Change-Id: I3ea4ff9995c539267410a264dbbea5ffa02bc6e3
Diffstat (limited to 'tests')
-rw-r--r--tests/src/com/android/dialer/list/PhoneFavoritesTileAdapterTest.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/src/com/android/dialer/list/PhoneFavoritesTileAdapterTest.java b/tests/src/com/android/dialer/list/PhoneFavoritesTileAdapterTest.java
index 40d171c8c..3e3cacd07 100644
--- a/tests/src/com/android/dialer/list/PhoneFavoritesTileAdapterTest.java
+++ b/tests/src/com/android/dialer/list/PhoneFavoritesTileAdapterTest.java
@@ -8,7 +8,7 @@ public class PhoneFavoritesTileAdapterTest extends AndroidTestCase {
@Override
protected void setUp() throws Exception {
super.setUp();
- mAdapter = new PhoneFavoritesTileAdapter(getContext(), null, 3, 1);
+ mAdapter = new PhoneFavoritesTileAdapter(getContext(), null, null, 3, 1);
}
/**