diff options
author | Andrew Lee <anwlee@google.com> | 2015-05-26 16:14:31 -0700 |
---|---|---|
committer | Andrew Lee <anwlee@google.com> | 2015-05-27 16:38:54 -0700 |
commit | 58eaabcc31e23fd4c071ad911b96da6eea4abc28 (patch) | |
tree | fcbfef6b072f8442432e39f1995ae18f2f34332e /tests | |
parent | a56893c156b997d796cd8343f99acd5d4198a280 (diff) |
Refactor Voicemail Playback into standalone view.
+ Substitutes the existing playback widget in CallDetailActivity,
although the plan is to move this to the call log shortly.
+ Convert the widget from a fragment into a layout. This allows us
to more easily create multiple instances of the voicemail widget in
the same view, as we intend to do in the call log.
+ Shift UI-related logic from Presenter to the Layout.
+ Fix janky seeking, so that it now works correctly consistently
rather than sporadically, and doesn't need to buffer again.
- Remove the VariableSpeed player formerly used in the Presenter. We
don't use this functionality anymore, and this allows us to directly
used the framework MediaPlayer (instead of a custom legacy proxy).
Bug: 21170557
Bug: 20693172
Change-Id: Ia34f459df10e43763b32fdb0954f83e882664231
Diffstat (limited to 'tests')
-rw-r--r-- | tests/src/com/android/dialer/CallDetailActivityTest.java | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/tests/src/com/android/dialer/CallDetailActivityTest.java b/tests/src/com/android/dialer/CallDetailActivityTest.java index aca8f2985..4dc9ebb81 100644 --- a/tests/src/com/android/dialer/CallDetailActivityTest.java +++ b/tests/src/com/android/dialer/CallDetailActivityTest.java @@ -18,7 +18,6 @@ package com.android.dialer; import static com.android.dialer.calllog.CallLogAsyncTaskUtil.Tasks.GET_CALL_DETAILS; import static com.android.dialer.voicemail.VoicemailPlaybackPresenter.Tasks.CHECK_FOR_CONTENT; -import static com.android.dialer.voicemail.VoicemailPlaybackPresenter.Tasks.PREPARE_MEDIA_PLAYER; import android.content.ContentResolver; import android.content.ContentUris; @@ -118,10 +117,8 @@ public class CallDetailActivityTest extends ActivityInstrumentationTestCase2<Cal setActivityIntentForTestVoicemailEntry(); startActivityUnderTest(); mFakeAsyncTaskExecutor.runTask(CHECK_FOR_CONTENT); - // There should be exactly one background task ready to prepare the media player. - // Preparing the media player will have thrown an IOException since the file doesn't exist. + // The media player will have thrown an IOException since the file doesn't exist. // This should have put a failed to play message on screen, buffering is gone. - mFakeAsyncTaskExecutor.runTask(PREPARE_MEDIA_PLAYER); assertHasOneTextViewContaining("Couldn't play voicemail"); assertZeroTextViewsContaining("Buffering"); } @@ -192,7 +189,6 @@ public class CallDetailActivityTest extends ActivityInstrumentationTestCase2<Cal setActivityIntentForRealFileVoicemailEntry(); startActivityUnderTest(); mFakeAsyncTaskExecutor.runTask(CHECK_FOR_CONTENT); - mFakeAsyncTaskExecutor.runTask(PREPARE_MEDIA_PLAYER); mTestUtils.clickButton(mActivityUnderTest, R.id.playback_speakerphone); mTestUtils.clickButton(mActivityUnderTest, R.id.playback_start_stop); Thread.sleep(2000); |