diff options
author | Yorke Lee <yorkelee@google.com> | 2013-11-20 15:02:49 -0800 |
---|---|---|
committer | Yorke Lee <yorkelee@google.com> | 2013-11-22 10:43:41 -0800 |
commit | 3671725b58a9768016e141c77424dedb5fd2c55a (patch) | |
tree | 8e2ba3a38e3cb942a1845e37fbdbbc6d1777387b /tests/src/com/android/dialer/dialpad/DialpadFragmentTest.java | |
parent | 3ff9c116afdda86f9af4e21a3dcc744a3231e1d0 (diff) |
Fix Dialer tests
* Empty geocode is now " " instead of "-" per UX request
* DialpadFragment now throws IllegalArgumentException instead
of Log.wtf so that it can be tested
* Added contact id column to contactsprovider query
* Modified PhoneNumberDisplayHelper to take an instance of
PhoneNumberUtilsWrapper so that it can be mocked out
Fix label-related tests that were failing due to a change in how we
treat empty labels
Bug: 9111164
Change-Id: If2244586b9d09fa2839fa0ddfc9f369f9dc66e51
Diffstat (limited to 'tests/src/com/android/dialer/dialpad/DialpadFragmentTest.java')
-rw-r--r-- | tests/src/com/android/dialer/dialpad/DialpadFragmentTest.java | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/tests/src/com/android/dialer/dialpad/DialpadFragmentTest.java b/tests/src/com/android/dialer/dialpad/DialpadFragmentTest.java index a123e745e..6f18fe69a 100644 --- a/tests/src/com/android/dialer/dialpad/DialpadFragmentTest.java +++ b/tests/src/com/android/dialer/dialpad/DialpadFragmentTest.java @@ -34,7 +34,11 @@ public class DialpadFragmentTest extends TestCase { public void testCanAddDigit_InvalidCharacter() { // only handles wait/pause - assertFalse(DialpadFragment.canAddDigit("123", 1, 1, '5')); + try { + DialpadFragment.canAddDigit("123", 1, 1, '5'); + fail("Calling canAddDigit with invalid character should throw an exception"); + } catch (IllegalArgumentException e) { + } } public void testCanAddDigit_BadOrNoSelection() { |