diff options
| author | Yorke Lee <yorkelee@google.com> | 2013-10-21 18:07:10 -0700 |
|---|---|---|
| committer | Yorke Lee <yorkelee@google.com> | 2013-10-21 18:08:28 -0700 |
| commit | 934d3ee3052cfdd994e31ab2bcf00747fd9776d8 (patch) | |
| tree | 659e9dd797db99360be3cd5cd574ccdf39ccfbef /src | |
| parent | 11162893f4bdc32e469ede5ae25ff91a94680abb (diff) | |
Fix call log jank
Restore previous jank-fix while ensuring that contacts with images
not in the ContactProvider are still updated
Bug: 11289654
Change-Id: I89723bd08c9dc83731b7a7555dc0364c74faa9a4
Diffstat (limited to 'src')
| -rw-r--r-- | src/com/android/dialer/calllog/CallLogAdapter.java | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/src/com/android/dialer/calllog/CallLogAdapter.java b/src/com/android/dialer/calllog/CallLogAdapter.java index 9392410d1..e4fd0d897 100644 --- a/src/com/android/dialer/calllog/CallLogAdapter.java +++ b/src/com/android/dialer/calllog/CallLogAdapter.java @@ -388,7 +388,16 @@ public class CallLogAdapter extends GroupingListAdapter NumberWithCountryIso numberCountryIso = new NumberWithCountryIso(number, countryIso); ContactInfo existingInfo = mContactInfoCache.getPossiblyExpired(numberCountryIso); - boolean updated = !info.equals(existingInfo); + final boolean isRemoteSource = info.sourceType != 0; + + // Don't force redraw if existing info in the cache is equal to {@link ContactInfo#EMPTY} + // to avoid updating the data set for every new row that is scrolled into view. + // see (https://googleplex-android-review.git.corp.google.com/#/c/166680/) + + // Exception: Photo uris for contacts from remote sources are not cached in the call log + // cache, so we have to force a redraw for these contacts regardless. + boolean updated = (existingInfo != ContactInfo.EMPTY || isRemoteSource) && + !info.equals(existingInfo); // Store the data in the cache so that the UI thread can use to display it. Store it // even if it has not changed so that it is marked as not expired. |