diff options
| author | Santos Cordon <santoscordon@google.com> | 2015-02-06 04:34:32 -0800 |
|---|---|---|
| committer | Santos Cordon <santoscordon@google.com> | 2015-02-19 22:46:01 -0800 |
| commit | a9a82f52cbcadd0b9a4aafa0c785c0d6af629f1c (patch) | |
| tree | 4d399f2124cc4a3aa6da2558392faf0d72f2a72e /src/com/android/dialer/calllog/CallLogAdapter.java | |
| parent | e65f03182eb76fabe8337a82fc3eef7230b669a1 (diff) | |
Add cache for isVoicemail check.
bindView() gets called many times at dialer startup and layout updates.
Besides being costly, it invokes cross-process TelecomManager methods.
This change addresses the cross-process issues by adding a short-lived
cache to isVoicemail() method invocations.
Change-Id: Ib69c0eb3969a1b7d77c9fd1a2aa6e578a31fb5e9
Diffstat (limited to 'src/com/android/dialer/calllog/CallLogAdapter.java')
| -rw-r--r-- | src/com/android/dialer/calllog/CallLogAdapter.java | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/com/android/dialer/calllog/CallLogAdapter.java b/src/com/android/dialer/calllog/CallLogAdapter.java index 9c50a3b73..b6f91e75b 100644 --- a/src/com/android/dialer/calllog/CallLogAdapter.java +++ b/src/com/android/dialer/calllog/CallLogAdapter.java @@ -631,6 +631,8 @@ public class CallLogAdapter extends GroupingListAdapter /** * Binds the views in the entry to the data in the call log. + * TODO: This gets called 20-30 times when Dialer starts up for a single call log entry and + * should not. It invokes cross-process methods and the repeat execution can get costly. * * @param callLogItemView the view corresponding to this entry * @param c the cursor pointing to the entry in the call log |