diff options
author | Andrew Lee <anwlee@google.com> | 2015-06-18 18:19:20 -0700 |
---|---|---|
committer | Andrew Lee <anwlee@google.com> | 2015-06-19 18:16:32 -0700 |
commit | 053b9c7a4b2662588706211fd8aa1f8a03ec2901 (patch) | |
tree | a9a933161af013c40bf64a9a457a86a86df3637e /src/com/android/dialer/calllog/CallLogAdapter.java | |
parent | b67f24eb6229ea10afb83f8ef2bf2bc6ba29a8f6 (diff) |
Rewrite of MediaPlayer logic.
+ Control MediaPlayer instance more tightly. Wait until
prepareContent to initialize instance. Release MediaPlayer when it
is no longer needed.
+ Instead of using isFinishing, check explicitly for orientation
change to know whether to release MediaPlayer.
+ Change Presenter to singleton, to address audio change wonkiness.
+ Only create a Presenter if the call log fragment shows voicemail.
+ ... fixing a variety of cases.
- Temporarily disable proximity sensor until blocking issue is fixed.
Bug: 21856243
Change-Id: Ic06e98bb5278467c3cce726a06b6cf3d855861a2
Diffstat (limited to 'src/com/android/dialer/calllog/CallLogAdapter.java')
-rw-r--r-- | src/com/android/dialer/calllog/CallLogAdapter.java | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/com/android/dialer/calllog/CallLogAdapter.java b/src/com/android/dialer/calllog/CallLogAdapter.java index 4304002da..bd478bd38 100644 --- a/src/com/android/dialer/calllog/CallLogAdapter.java +++ b/src/com/android/dialer/calllog/CallLogAdapter.java @@ -116,8 +116,10 @@ public class CallLogAdapter extends GroupingListAdapter return; } - // Always reset the voicemail playback state on expand or collapse. - mVoicemailPlaybackPresenter.reset(); + if (mVoicemailPlaybackPresenter != null) { + // Always reset the voicemail playback state on expand or collapse. + mVoicemailPlaybackPresenter.reset(); + } if (viewHolder.getAdapterPosition() == mCurrentlyExpandedPosition) { // Hide actions, if the clicked item is the expanded item. |