diff options
author | Andrew Lee <anwlee@google.com> | 2014-05-21 18:05:56 -0700 |
---|---|---|
committer | Andrew Lee <anwlee@google.com> | 2014-05-22 21:13:03 +0000 |
commit | 13f6fd048f0cdc26e9dc6b78a02515e72fff2e27 (patch) | |
tree | c6903644ce699283ac922dc0161fe4156bef25f3 /res/layout/call_log_list_item.xml | |
parent | 91b50b81967409ef25b3b1893f2a63c0c5355c53 (diff) |
DO NOT MERGE. Tidy up call log shadow/touch interactions.
- Constrain the recents list footer ripple to its dimensions.
- Eliminate bottom margin on the call log list items.
- Changed translationZ on expand to apply to the call log list item
instead of just its primary action view.
- Adjust the outline clipping so that a shadow doesn't appear under
the day group header, now that the translation is applied to the
entire list item.
- Instantiated a number of fixed property values in onCreate() in the
CallLogFragment, instead of whenever they're needed.
Bug: 15165669
Change-Id: I5ed81ae49fb0c3f6eed360f247c1fd67278a628c
(cherry picked from commit 6e765f9a71b450809c4916a5d5562cdc1372a39a)
Diffstat (limited to 'res/layout/call_log_list_item.xml')
-rw-r--r-- | res/layout/call_log_list_item.xml | 23 |
1 files changed, 10 insertions, 13 deletions
diff --git a/res/layout/call_log_list_item.xml b/res/layout/call_log_list_item.xml index 9182bd758..bdf14774e 100644 --- a/res/layout/call_log_list_item.xml +++ b/res/layout/call_log_list_item.xml @@ -14,16 +14,14 @@ limitations under the License. --> -<view - xmlns:android="http://schemas.android.com/apk/res/android" +<view xmlns:android="http://schemas.android.com/apk/res/android" class="com.android.dialer.calllog.CallLogListItemView" + android:id="@+id/call_log_list_item" android:layout_width="match_parent" android:layout_height="wrap_content" - android:paddingBottom="@dimen/call_log_outer_margin" - android:id="@+id/call_log_list_item" android:orientation="vertical" - android:clipChildren="false" -> + android:background="@color/background_dialer_list_items" > + <!-- Day group heading. Used to show a "today", "yesterday", "last week" or "other" heading above a group of call log entries. --> <TextView @@ -37,17 +35,16 @@ android:paddingTop="@dimen/call_log_day_group_padding" android:paddingBottom="0dp" /> + <!-- Linear layout to separate the primary area containing the contact badge and caller information and the secondary action (call details / play voicemail). --> <LinearLayout android:id="@+id/call_log_row" - android:background="@color/background_dialer_list_items" android:layout_width="match_parent" android:layout_height="wrap_content" android:baselineAligned="false" android:orientation="vertical" - android:gravity="center_vertical" - > + android:gravity="center_vertical" > <!-- Primary area containing the contact badge and caller information --> <LinearLayout @@ -55,15 +52,15 @@ android:background="@drawable/call_log_background" android:layout_width="match_parent" android:layout_height="wrap_content" - android:paddingLeft="@dimen/call_log_outer_margin" - android:paddingRight="@dimen/call_log_outer_margin" + android:paddingStart="@dimen/call_log_outer_margin" + android:paddingEnd="@dimen/call_log_outer_margin" android:paddingTop="@dimen/call_log_outer_margin" + android:paddingBottom="@dimen/call_log_outer_margin" android:orientation="horizontal" android:gravity="center_vertical" android:focusable="true" android:nextFocusRight="@+id/call_back_action" - android:nextFocusLeft="@+id/quick_contact_photo" - > + android:nextFocusLeft="@+id/quick_contact_photo" > <QuickContactBadge android:id="@+id/quick_contact_photo" android:layout_width="@dimen/call_log_list_contact_photo_size" |