diff options
| author | yueg <yueg@google.com> | 2018-01-10 11:30:30 -0800 |
|---|---|---|
| committer | Copybara-Service <copybara-piper@google.com> | 2018-01-10 12:18:11 -0800 |
| commit | 2f664038adf9750a263bdc52c0721cd5978f2a3a (patch) | |
| tree | 9734974c3b968e273ead53fc281646617bb45a9d /java | |
| parent | c2450479069d7c03ed295a62debea14ab7a95f1b (diff) | |
Log impression when bubble v2 appears.
Bug: 67605985
Test: NewBubbleTest
PiperOrigin-RevId: 181493569
Change-Id: I30f7204ad9c78693e2c9b054bd69307fb4768a0b
Diffstat (limited to 'java')
| -rw-r--r-- | java/com/android/dialer/logging/dialer_impression.proto | 5 | ||||
| -rw-r--r-- | java/com/android/newbubble/NewBubble.java | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/java/com/android/dialer/logging/dialer_impression.proto b/java/com/android/dialer/logging/dialer_impression.proto index 705420c3a..27135b35e 100644 --- a/java/com/android/dialer/logging/dialer_impression.proto +++ b/java/com/android/dialer/logging/dialer_impression.proto @@ -12,7 +12,7 @@ message DialerImpression { // Event enums to be used for Impression Logging in Dialer. // It's perfectly acceptable for this enum to be large // Values should be from 1000 to 100000. - // Next Tag: 1323 + // Next Tag: 1324 enum Type { UNKNOWN_AOSP_EVENT_TYPE = 1000; @@ -650,5 +650,8 @@ message DialerImpression { BUBBLE_V2_BOTTOM_ACTION_END_CALL = 1321; DUAL_SIM_SELECTION_SUGGESTION_AUTO_SELECTED = 1322; + + // Bubble appears + BUBBLE_V2_SHOW = 1323; } } diff --git a/java/com/android/newbubble/NewBubble.java b/java/com/android/newbubble/NewBubble.java index 202cfcd33..cb7a09469 100644 --- a/java/com/android/newbubble/NewBubble.java +++ b/java/com/android/newbubble/NewBubble.java @@ -381,6 +381,8 @@ public class NewBubble { return; } + logBasicOrCallImpression(DialerImpression.Type.BUBBLE_V2_SHOW); + boolean isRtl = TextUtils.getLayoutDirectionFromLocale(Locale.getDefault()) == View.LAYOUT_DIRECTION_RTL; if (windowParams == null) { |