summaryrefslogtreecommitdiff
path: root/java/com
diff options
context:
space:
mode:
authorTreehugger Robot <treehugger-gerrit@google.com>2018-06-09 02:15:46 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2018-06-09 02:15:46 +0000
commit128ecd2bcfd00cfb7c86a21874f7d0aa85b8127d (patch)
treed8114d34c5a4305460897f1587ddc303e80801d2 /java/com
parent1d3dbe88d986a315d98a1a7fd0350c248c182756 (diff)
parente332b103cacab1430bde7130dbfea1eebca30038 (diff)
Merge changes I4f4f66f5,I77e7ff75
* changes: Removed cast to DialtactsActivity. Fix incall icon arrow color
Diffstat (limited to 'java/com')
-rw-r--r--java/com/android/dialer/app/calllog/CallLogAdapter.java20
-rw-r--r--java/com/android/incallui/incall/impl/CheckableLabeledButton.java12
-rw-r--r--java/com/android/incallui/incall/impl/res/color/incall_button_icon.xml2
3 files changed, 18 insertions, 16 deletions
diff --git a/java/com/android/dialer/app/calllog/CallLogAdapter.java b/java/com/android/dialer/app/calllog/CallLogAdapter.java
index a4479da9e..d3fd36520 100644
--- a/java/com/android/dialer/app/calllog/CallLogAdapter.java
+++ b/java/com/android/dialer/app/calllog/CallLogAdapter.java
@@ -54,7 +54,6 @@ import android.view.View;
import android.view.ViewGroup;
import com.android.contacts.common.ContactsUtils;
import com.android.contacts.common.preference.ContactsPreferences;
-import com.android.dialer.app.DialtactsActivity;
import com.android.dialer.app.R;
import com.android.dialer.app.calllog.CallLogFragment.CallLogFragmentListener;
import com.android.dialer.app.calllog.CallLogGroupBuilder.GroupCreator;
@@ -395,16 +394,15 @@ public class CallLogAdapter extends GroupingListAdapter
if (viewHolder.callType == CallLog.Calls.MISSED_TYPE) {
CallLogAsyncTaskUtil.markCallAsRead(activity, viewHolder.callIds);
if (activityType == ACTIVITY_TYPE_DIALTACTS) {
- if (v.getContext() instanceof MainActivityPeer.PeerSupplier) {
- // This is really bad, but we must do this to prevent a dependency cycle, enforce
- // best practices in new code, and avoid refactoring DialtactsActivity.
- ((FragmentUtilListener)
- ((MainActivityPeer.PeerSupplier) v.getContext()).getPeer())
- .getImpl(CallLogFragmentListener.class)
- .updateTabUnreadCounts();
- } else {
- ((DialtactsActivity) v.getContext()).updateTabUnreadCounts();
- }
+ Assert.checkState(
+ v.getContext() instanceof MainActivityPeer.PeerSupplier,
+ "%s is not a PeerSupplier",
+ v.getContext().getClass());
+ // This is really bad, but we must do this to prevent a dependency cycle, enforce
+ // best practices in new code, and avoid refactoring DialtactsActivity.
+ ((FragmentUtilListener) ((MainActivityPeer.PeerSupplier) v.getContext()).getPeer())
+ .getImpl(CallLogFragmentListener.class)
+ .updateTabUnreadCounts();
}
}
expandViewHolderActions(viewHolder);
diff --git a/java/com/android/incallui/incall/impl/CheckableLabeledButton.java b/java/com/android/incallui/incall/impl/CheckableLabeledButton.java
index 03e6e3700..bfc2781a9 100644
--- a/java/com/android/incallui/incall/impl/CheckableLabeledButton.java
+++ b/java/com/android/incallui/incall/impl/CheckableLabeledButton.java
@@ -67,8 +67,10 @@ public class CheckableLabeledButton extends LinearLayout implements Checkable {
CharSequence labelText;
boolean enabled;
- backgroundMore = getResources().getDrawable(R.drawable.incall_button_background_more, null);
- background = getResources().getDrawable(R.drawable.incall_button_background, null);
+ backgroundMore =
+ getResources().getDrawable(R.drawable.incall_button_background_more, context.getTheme());
+ background =
+ getResources().getDrawable(R.drawable.incall_button_background, context.getTheme());
TypedArray typedArray =
context.obtainStyledAttributes(attrs, R.styleable.CheckableLabeledButton);
@@ -92,9 +94,11 @@ public class CheckableLabeledButton extends LinearLayout implements Checkable {
iconView.setPadding(iconPadding, iconPadding, iconPadding, iconPadding);
iconView.setImageDrawable(icon);
iconView.setImageTintMode(Mode.SRC_IN);
- iconView.setImageTintList(getResources().getColorStateList(R.color.incall_button_icon, null));
+ iconView.setImageTintList(
+ getResources().getColorStateList(R.color.incall_button_icon, context.getTheme()));
- iconView.setBackground(getResources().getDrawable(R.drawable.incall_button_background, null));
+ iconView.setBackground(
+ getResources().getDrawable(R.drawable.incall_button_background, context.getTheme()));
iconView.setDuplicateParentStateEnabled(true);
iconView.setElevation(getResources().getDimension(R.dimen.incall_button_elevation));
iconView.setStateListAnimator(
diff --git a/java/com/android/incallui/incall/impl/res/color/incall_button_icon.xml b/java/com/android/incallui/incall/impl/res/color/incall_button_icon.xml
index 68b34c89d..000525f5f 100644
--- a/java/com/android/incallui/incall/impl/res/color/incall_button_icon.xml
+++ b/java/com/android/incallui/incall/impl/res/color/incall_button_icon.xml
@@ -17,5 +17,5 @@
<selector xmlns:android="http://schemas.android.com/apk/res/android">
<item android:color="?android:attr/colorPrimaryDark" android:state_checked="true"/>
- <item android:color="?android:attr/colorBackgroundFloating"/>
+ <item android:color="?android:attr/textColorPrimary"/>
</selector>