summaryrefslogtreecommitdiff
path: root/java/com/android/voicemail
diff options
context:
space:
mode:
authorzachh <zachh@google.com>2018-05-31 17:30:46 -0700
committerCopybara-Service <copybara-piper@google.com>2018-06-01 18:18:51 -0700
commit190343ac560de1ff550e436acb176f17fd228fdc (patch)
tree9b7046b7bc4b576d8b6d5a53db711a52dbcb9265 /java/com/android/voicemail
parentb7321a9f80d6afd262e0ee8bbbbcc3a88c234f77 (diff)
Inlined ConfigProviderBindings.get() and removed ConfigProviderBindings.
It no longer provides any value, so just use dagger directly. Bug: 80441695 Test: tap PiperOrigin-RevId: 198806461 Change-Id: Id607abb65b77633bce511ad0c943ac19453a85d5
Diffstat (limited to 'java/com/android/voicemail')
-rw-r--r--java/com/android/voicemail/impl/DialerVvmConfigManager.java5
-rw-r--r--java/com/android/voicemail/impl/VoicemailClientImpl.java6
-rw-r--r--java/com/android/voicemail/impl/protocol/Vvm3Subscriber.java5
-rw-r--r--java/com/android/voicemail/impl/transcribe/TranscriptionConfigProvider.java35
4 files changed, 33 insertions, 18 deletions
diff --git a/java/com/android/voicemail/impl/DialerVvmConfigManager.java b/java/com/android/voicemail/impl/DialerVvmConfigManager.java
index 7fa960e34..99c95ddce 100644
--- a/java/com/android/voicemail/impl/DialerVvmConfigManager.java
+++ b/java/com/android/voicemail/impl/DialerVvmConfigManager.java
@@ -23,7 +23,7 @@ import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import android.support.annotation.VisibleForTesting;
import android.util.ArrayMap;
-import com.android.dialer.configprovider.ConfigProviderBindings;
+import com.android.dialer.configprovider.ConfigProviderComponent;
import com.android.voicemail.impl.utils.XmlUtils;
import com.google.common.collect.ComparisonChain;
import java.io.IOException;
@@ -133,7 +133,8 @@ public class DialerVvmConfigManager {
PersistableBundle bundle = (PersistableBundle) object;
if (bundle.containsKey(KEY_FEATURE_FLAG_NAME)
- && !ConfigProviderBindings.get(context)
+ && !ConfigProviderComponent.get(context)
+ .getConfigProvider()
.getBoolean(bundle.getString(KEY_FEATURE_FLAG_NAME), false)) {
continue;
}
diff --git a/java/com/android/voicemail/impl/VoicemailClientImpl.java b/java/com/android/voicemail/impl/VoicemailClientImpl.java
index 187ded932..36e5a6c58 100644
--- a/java/com/android/voicemail/impl/VoicemailClientImpl.java
+++ b/java/com/android/voicemail/impl/VoicemailClientImpl.java
@@ -30,7 +30,7 @@ import android.telecom.PhoneAccountHandle;
import android.telephony.TelephonyManager;
import com.android.dialer.common.Assert;
import com.android.dialer.common.LogUtil;
-import com.android.dialer.configprovider.ConfigProviderBindings;
+import com.android.dialer.configprovider.ConfigProviderComponent;
import com.android.voicemail.PinChanger;
import com.android.voicemail.VisualVoicemailTypeExtensions;
import com.android.voicemail.VoicemailClient;
@@ -105,7 +105,9 @@ public class VoicemailClientImpl implements VoicemailClient {
return false;
}
- if (!ConfigProviderBindings.get(context).getBoolean(ALLOW_VOICEMAIL_ARCHIVE, false)) {
+ if (!ConfigProviderComponent.get(context)
+ .getConfigProvider()
+ .getBoolean(ALLOW_VOICEMAIL_ARCHIVE, false)) {
LogUtil.i(
"VoicemailClientImpl.isVoicemailArchiveAllowed",
"feature disabled by config: %s",
diff --git a/java/com/android/voicemail/impl/protocol/Vvm3Subscriber.java b/java/com/android/voicemail/impl/protocol/Vvm3Subscriber.java
index ce5094f1a..6ac233729 100644
--- a/java/com/android/voicemail/impl/protocol/Vvm3Subscriber.java
+++ b/java/com/android/voicemail/impl/protocol/Vvm3Subscriber.java
@@ -31,7 +31,7 @@ import android.text.Html;
import android.text.Spanned;
import android.text.style.URLSpan;
import android.util.ArrayMap;
-import com.android.dialer.configprovider.ConfigProviderBindings;
+import com.android.dialer.configprovider.ConfigProviderComponent;
import com.android.voicemail.impl.ActivationTask;
import com.android.voicemail.impl.Assert;
import com.android.voicemail.impl.OmtpEvents;
@@ -312,7 +312,8 @@ public class Vvm3Subscriber {
@VisibleForTesting
static List<Pattern> getSubscribeLinkPatterns(Context context) {
String patternsJsonString =
- ConfigProviderBindings.get(context)
+ ConfigProviderComponent.get(context)
+ .getConfigProvider()
.getString(
VVM3_SUBSCRIBE_LINK_PATTERNS_JSON_ARRAY, VVM3_SUBSCRIBE_LINK_DEFAULT_PATTERNS);
List<Pattern> patterns = new ArrayList<>();
diff --git a/java/com/android/voicemail/impl/transcribe/TranscriptionConfigProvider.java b/java/com/android/voicemail/impl/transcribe/TranscriptionConfigProvider.java
index 54a1ae4d4..66bf16c24 100644
--- a/java/com/android/voicemail/impl/transcribe/TranscriptionConfigProvider.java
+++ b/java/com/android/voicemail/impl/transcribe/TranscriptionConfigProvider.java
@@ -17,7 +17,7 @@ package com.android.voicemail.impl.transcribe;
import android.content.Context;
import android.os.Build;
-import com.android.dialer.configprovider.ConfigProviderBindings;
+import com.android.dialer.configprovider.ConfigProviderComponent;
import java.util.concurrent.TimeUnit;
/** Provides configuration values needed to connect to the transcription server. */
@@ -30,20 +30,23 @@ public class TranscriptionConfigProvider {
public boolean isVoicemailTranscriptionAvailable() {
return Build.VERSION.SDK_INT >= Build.VERSION_CODES.O
- && ConfigProviderBindings.get(context)
+ && ConfigProviderComponent.get(context)
+ .getConfigProvider()
.getBoolean("voicemail_transcription_available", false);
}
public String getServerAddress() {
// Private voicemail transcription service
- return ConfigProviderBindings.get(context)
+ return ConfigProviderComponent.get(context)
+ .getConfigProvider()
.getString(
"voicemail_transcription_server_address", "voicemailtranscription-pa.googleapis.com");
}
public String getApiKey() {
// Android API key restricted to com.google.android.dialer
- return ConfigProviderBindings.get(context)
+ return ConfigProviderComponent.get(context)
+ .getConfigProvider()
.getString(
"voicemail_transcription_client_api_key", "AIzaSyAXdDnif6B7sBYxU8hzw9qAp3pRPVHs060");
}
@@ -53,47 +56,55 @@ public class TranscriptionConfigProvider {
}
public boolean shouldUsePlaintext() {
- return ConfigProviderBindings.get(context)
+ return ConfigProviderComponent.get(context)
+ .getConfigProvider()
.getBoolean("voicemail_transcription_server_use_plaintext", false);
}
public boolean shouldUseSyncApi() {
- return ConfigProviderBindings.get(context)
+ return ConfigProviderComponent.get(context)
+ .getConfigProvider()
.getBoolean("voicemail_transcription_server_use_sync_api", false);
}
public long getMaxTranscriptionRetries() {
- return ConfigProviderBindings.get(context)
+ return ConfigProviderComponent.get(context)
+ .getConfigProvider()
.getLong("voicemail_transcription_max_transcription_retries", 2L);
}
public int getMaxGetTranscriptPolls() {
return (int)
- ConfigProviderBindings.get(context)
+ ConfigProviderComponent.get(context)
+ .getConfigProvider()
.getLong("voicemail_transcription_max_get_transcript_polls", 20L);
}
public long getInitialGetTranscriptPollDelayMillis() {
- return ConfigProviderBindings.get(context)
+ return ConfigProviderComponent.get(context)
+ .getConfigProvider()
.getLong(
"voicemail_transcription_get_initial_transcript_poll_delay_millis",
TimeUnit.SECONDS.toMillis(1));
}
public long getMaxGetTranscriptPollTimeMillis() {
- return ConfigProviderBindings.get(context)
+ return ConfigProviderComponent.get(context)
+ .getConfigProvider()
.getLong(
"voicemail_transcription_get_max_transcript_poll_time_millis",
TimeUnit.MINUTES.toMillis(20));
}
public boolean isVoicemailDonationAvailable() {
- return ConfigProviderBindings.get(context)
+ return ConfigProviderComponent.get(context)
+ .getConfigProvider()
.getBoolean("voicemail_transcription_donation_available", false);
}
public boolean useClientGeneratedVoicemailIds() {
- return ConfigProviderBindings.get(context)
+ return ConfigProviderComponent.get(context)
+ .getConfigProvider()
.getBoolean("voicemail_transcription_client_generated_voicemail_ids", false);
}