summaryrefslogtreecommitdiff
path: root/java/com/android/incallui
diff options
context:
space:
mode:
authorTreehugger Robot <treehugger-gerrit@google.com>2018-03-27 06:54:01 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2018-03-27 06:54:01 +0000
commit70c86dac3c3b88a01fcc9a5bfe7fec1cc4964da1 (patch)
tree56f2c22826d1c932e04fde9cabf567a659bb0d9d /java/com/android/incallui
parent57170f415afacd6785c61e42ebe4bd7697faff79 (diff)
parent0a8163fde93716a0a7ae2d7b536851f59da15a38 (diff)
Merge changes If0de7526,I5fa9e123,I70f2e6db
* changes: Add 311910 to motorola sprint configs. Remove obsolete methods in CompatUtils and rename it as "LocaleUtils". Placing a call from a search action now closes the keyboard.
Diffstat (limited to 'java/com/android/incallui')
-rw-r--r--java/com/android/incallui/InCallActivity.java5
-rw-r--r--java/com/android/incallui/VideoCallPresenter.java33
2 files changed, 6 insertions, 32 deletions
diff --git a/java/com/android/incallui/InCallActivity.java b/java/com/android/incallui/InCallActivity.java
index 3236e160a..8144ddb10 100644
--- a/java/com/android/incallui/InCallActivity.java
+++ b/java/com/android/incallui/InCallActivity.java
@@ -60,7 +60,6 @@ import com.android.dialer.common.Assert;
import com.android.dialer.common.LogUtil;
import com.android.dialer.common.concurrent.DialerExecutorComponent;
import com.android.dialer.common.concurrent.ThreadUtil;
-import com.android.dialer.compat.CompatUtils;
import com.android.dialer.configprovider.ConfigProviderBindings;
import com.android.dialer.logging.DialerImpression.Type;
import com.android.dialer.logging.Logger;
@@ -321,9 +320,7 @@ public class InCallActivity extends TransactionSafeFragmentActivity
// InCallActivity is responsible for disconnecting a new outgoing call if there is no way of
// making it (i.e. no valid call capable accounts).
- // If the version is not MSIM compatible, ignore this code.
- if (CompatUtils.isMSIMCompatible()
- && InCallPresenter.isCallWithNoValidAccounts(outgoingCall)) {
+ if (InCallPresenter.isCallWithNoValidAccounts(outgoingCall)) {
LogUtil.i(
"InCallActivity.internalResolveIntent", "Call with no valid accounts, disconnecting");
outgoingCall.disconnect();
diff --git a/java/com/android/incallui/VideoCallPresenter.java b/java/com/android/incallui/VideoCallPresenter.java
index f5d681c74..050ce9859 100644
--- a/java/com/android/incallui/VideoCallPresenter.java
+++ b/java/com/android/incallui/VideoCallPresenter.java
@@ -29,7 +29,6 @@ import android.view.Surface;
import android.view.SurfaceView;
import com.android.dialer.common.Assert;
import com.android.dialer.common.LogUtil;
-import com.android.dialer.compat.CompatUtils;
import com.android.dialer.configprovider.ConfigProviderBindings;
import com.android.dialer.util.PermissionsUtil;
import com.android.incallui.InCallPresenter.InCallDetailsListener;
@@ -164,10 +163,7 @@ public class VideoCallPresenter
* @param callState The current call state.
* @return {@code true} if the incoming video surface should be shown, {@code false} otherwise.
*/
- public static boolean showIncomingVideo(int videoState, int callState) {
- if (!CompatUtils.isVideoCompatible()) {
- return false;
- }
+ static boolean showIncomingVideo(int videoState, int callState) {
boolean isPaused = VideoProfile.isPaused(videoState);
boolean isCallActive = callState == DialerCall.State.ACTIVE;
@@ -187,17 +183,13 @@ public class VideoCallPresenter
* @return {@code true} if the the outgoing video surface should be shown, {@code false}
* otherwise.
*/
- public static boolean showOutgoingVideo(
+ private static boolean showOutgoingVideo(
Context context, int videoState, int sessionModificationState) {
if (!VideoUtils.hasCameraPermissionAndShownPrivacyToast(context)) {
LogUtil.i("VideoCallPresenter.showOutgoingVideo", "Camera permission is disabled by user.");
return false;
}
- if (!CompatUtils.isVideoCompatible()) {
- return false;
- }
-
return VideoProfile.isTransmissionEnabled(videoState)
|| isVideoUpgrade(sessionModificationState);
}
@@ -309,12 +301,6 @@ public class VideoCallPresenter
LogUtil.v("VideoCallPresenter.onVideoCallScreenUiReady", "");
Assert.checkState(!isVideoCallScreenUiReady);
- // Do not register any listeners if video calling is not compatible to safeguard against
- // any accidental calls of video calling code.
- if (!CompatUtils.isVideoCompatible()) {
- return;
- }
-
deviceOrientation = InCallOrientationEventListener.getCurrentOrientation();
// Register for call state changes last
@@ -345,10 +331,6 @@ public class VideoCallPresenter
LogUtil.v("VideoCallPresenter.onVideoCallScreenUiUnready", "");
Assert.checkState(isVideoCallScreenUiReady);
- if (!CompatUtils.isVideoCompatible()) {
- return;
- }
-
cancelAutoFullScreen();
InCallPresenter.getInstance().removeListener(this);
@@ -1273,7 +1255,7 @@ public class VideoCallPresenter
}
private static boolean isBidirectionalVideoCall(DialerCall call) {
- return CompatUtils.isVideoCompatible() && VideoProfile.isBidirectional(call.getVideoState());
+ return VideoProfile.isBidirectional(call.getVideoState());
}
private static boolean isIncomingVideoCall(DialerCall call) {
@@ -1299,10 +1281,6 @@ public class VideoCallPresenter
}
private static boolean isAudioCall(DialerCall call) {
- if (!CompatUtils.isVideoCompatible()) {
- return true;
- }
-
return call != null && VideoProfile.isAudioOnly(call.getVideoState());
}
@@ -1311,8 +1289,7 @@ public class VideoCallPresenter
}
private static boolean isVideoCall(int videoState) {
- return CompatUtils.isVideoCompatible()
- && (VideoProfile.isTransmissionEnabled(videoState)
- || VideoProfile.isReceptionEnabled(videoState));
+ return VideoProfile.isTransmissionEnabled(videoState)
+ || VideoProfile.isReceptionEnabled(videoState);
}
}