diff options
| author | Treehugger Robot <treehugger-gerrit@google.com> | 2018-02-02 23:59:26 +0000 |
|---|---|---|
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2018-02-02 23:59:26 +0000 |
| commit | e885c6acb4910e45c2313c9715aff137c5ca9357 (patch) | |
| tree | 9460ddcf009afb0b4a9b9c65119cf1388d289493 /java/com/android/dialer | |
| parent | 056c1911137caad554cdfebb5a0b4a03e3df8c53 (diff) | |
| parent | 668b99f9d6eca8f6d53432cc9ceddc914be7cfb3 (diff) | |
Merge "Add assert check for INVALID NUMBERS in NUI Voicemail"
Diffstat (limited to 'java/com/android/dialer')
| -rw-r--r-- | java/com/android/dialer/voicemail/listui/VoicemailCursorLoader.java | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/java/com/android/dialer/voicemail/listui/VoicemailCursorLoader.java b/java/com/android/dialer/voicemail/listui/VoicemailCursorLoader.java index 7e0381871..74d1b6162 100644 --- a/java/com/android/dialer/voicemail/listui/VoicemailCursorLoader.java +++ b/java/com/android/dialer/voicemail/listui/VoicemailCursorLoader.java @@ -23,6 +23,8 @@ import android.support.v4.content.CursorLoader; import com.android.dialer.DialerPhoneNumber; import com.android.dialer.NumberAttributes; import com.android.dialer.calllog.database.contract.AnnotatedCallLogContract.AnnotatedCallLog; +import com.android.dialer.common.Assert; +import com.android.dialer.common.LogUtil; import com.android.dialer.voicemail.model.VoicemailEntry; import com.google.protobuf.InvalidProtocolBufferException; @@ -84,6 +86,13 @@ final class VoicemailCursorLoader extends CursorLoader { throw new IllegalStateException("Couldn't parse NumberAttributes bytes"); } + // Voicemail numbers should always be valid so the CP2 information should never be incomplete, + // and there should be no need to query PhoneLookup at render time. + Assert.checkArgument( + !numberAttributes.getIsCp2InfoIncomplete(), + "CP2 info incomplete for number: %s", + LogUtil.sanitizePii(number.getNormalizedNumber())); + return VoicemailEntry.builder() .setId(cursor.getInt(ID)) .setTimestamp(cursor.getLong(TIMESTAMP)) |