diff options
author | calderwoodra <calderwoodra@google.com> | 2017-06-21 16:32:28 -0700 |
---|---|---|
committer | Eric Erfanian <erfanian@google.com> | 2017-06-22 07:39:46 -0700 |
commit | 7e5a84d3ffde93313891e4769c88a1c9c03dc320 (patch) | |
tree | 5e305562ccd3fd735d2eb62a5bd61e24fff06740 /java/com/android/dialer | |
parent | feb011791578ebc431c1b3d2abaa2464778f0f98 (diff) |
Added logging to reporting caller id
Reports when a user sucesfully reports a number is inaccurate caller id and
when their report fails.
PiperOrigin-RevId: 159762210
Change-Id: I8507b4d2a3d4b6f3004e8145f4ba0f9e8065e5d7
Diffstat (limited to 'java/com/android/dialer')
-rw-r--r-- | java/com/android/dialer/calldetails/ReportDialogFragment.java | 4 | ||||
-rw-r--r-- | java/com/android/dialer/logging/dialer_impression.proto | 6 |
2 files changed, 9 insertions, 1 deletions
diff --git a/java/com/android/dialer/calldetails/ReportDialogFragment.java b/java/com/android/dialer/calldetails/ReportDialogFragment.java index c27bd611b..0861c9dbb 100644 --- a/java/com/android/dialer/calldetails/ReportDialogFragment.java +++ b/java/com/android/dialer/calldetails/ReportDialogFragment.java @@ -32,6 +32,8 @@ import com.android.dialer.common.LogUtil; import com.android.dialer.common.concurrent.DialerExecutor.SuccessListener; import com.android.dialer.common.concurrent.DialerExecutor.Worker; import com.android.dialer.common.concurrent.DialerExecutorComponent; +import com.android.dialer.logging.DialerImpression; +import com.android.dialer.logging.Logger; import com.android.dialer.phonenumbercache.CachedNumberLookupService; import com.android.dialer.phonenumbercache.CachedNumberLookupService.CachedContactInfo; import com.android.dialer.phonenumbercache.PhoneNumberCache; @@ -144,8 +146,10 @@ public class ReportDialogFragment extends DialogFragment { Context context = output.first; boolean wasReport = output.second; if (wasReport) { + Logger.get(context).logImpression(DialerImpression.Type.CALLER_ID_REPORTED); Toast.makeText(context, R.string.report_caller_id_toast, Toast.LENGTH_SHORT).show(); } else { + Logger.get(context).logImpression(DialerImpression.Type.CALLER_ID_REPORT_FAILED); Toast.makeText(context, R.string.report_caller_id_failed, Toast.LENGTH_SHORT).show(); } } diff --git a/java/com/android/dialer/logging/dialer_impression.proto b/java/com/android/dialer/logging/dialer_impression.proto index 465c0c318..cda4bd19c 100644 --- a/java/com/android/dialer/logging/dialer_impression.proto +++ b/java/com/android/dialer/logging/dialer_impression.proto @@ -12,7 +12,7 @@ message DialerImpression { // Event enums to be used for Impression Logging in Dialer. // It's perfectly acceptable for this enum to be large // Values should be from 1000 to 100000. - // Next Tag:1227 + // Next Tag:1229 enum Type { UNKNOWN_AOSP_EVENT_TYPE = 1000; @@ -462,5 +462,9 @@ message DialerImpression { ADD_TO_A_CONTACT_FROM_DIALPAD = 1224; ADD_TO_A_CONTACT_FROM_VOICEMAIL = 1225; ADD_TO_A_CONTACT_FROM_CALL_HISTORY = 1226; + + // Impressions for dialer reporting caller id as inaccurate + CALLER_ID_REPORTED = 1227; + CALLER_ID_REPORT_FAILED = 1228; } } |