diff options
author | TreeHugger Robot <treehugger-gerrit@google.com> | 2017-06-21 19:43:47 +0000 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2017-06-21 19:43:48 +0000 |
commit | 199d7d4011fd0112d34c405235afad7e5b7fd74d (patch) | |
tree | c14e042b758595259c7829bbf384a251cad27541 /java/com/android/dialer | |
parent | f54b84027640544b94895a05a4c564f9c4e88dfd (diff) | |
parent | 5b4becb8ca9cc6249d0cf0a074bf63d6999f3b5e (diff) |
Merge "Automated g4 rollback of changelist 158923709."
Diffstat (limited to 'java/com/android/dialer')
38 files changed, 58 insertions, 56 deletions
diff --git a/java/com/android/dialer/app/DialtactsActivity.java b/java/com/android/dialer/app/DialtactsActivity.java index 527dbff18..fd685816e 100644 --- a/java/com/android/dialer/app/DialtactsActivity.java +++ b/java/com/android/dialer/app/DialtactsActivity.java @@ -284,7 +284,7 @@ public class DialtactsActivity extends TransactionSafeActivity } mSearchQuery = newText; - // TODO: show p13n when newText is empty. + // TODO(calderwoodra): show p13n when newText is empty. // Show search fragment only when the query string is changed to non-empty text. if (!TextUtils.isEmpty(newText)) { // Call enterSearchUi only if we are switching search modes, or showing a search @@ -595,7 +595,7 @@ public class DialtactsActivity extends TransactionSafeActivity new P13nRefreshCompleteListener() { @Override public void onP13nRefreshComplete() { - // TODO: make zero-query search results visible + // TODO(strongarm): make zero-query search results visible } }); Trace.endSection(); @@ -1152,7 +1152,7 @@ public class DialtactsActivity extends TransactionSafeActivity } transaction.add(R.id.dialtacts_frame, fragment, tag); } else { - // TODO: if this is a transition from dialpad to searchbar, animate fragment + // TODO(calderwoodra): if this is a transition from dialpad to searchbar, animate fragment // down, and vice versa. Perhaps just add a coordinator behavior with the search bar. transaction.show(fragment); } @@ -1165,7 +1165,7 @@ public class DialtactsActivity extends TransactionSafeActivity ((SearchFragment) fragment) .setShowEmptyListForNullQuery(mP13nRanker.shouldShowEmptyListForNullQuery()); } else { - // TODO: add p13n ranker to new search. + // TODO(calderwoodra): add p13n ranker to new search. } if (!smartDialSearch && !useNewSearch) { diff --git a/java/com/android/dialer/app/calllog/CallLogAdapter.java b/java/com/android/dialer/app/calllog/CallLogAdapter.java index f1d051a8c..b0afec1a7 100644 --- a/java/com/android/dialer/app/calllog/CallLogAdapter.java +++ b/java/com/android/dialer/app/calllog/CallLogAdapter.java @@ -416,7 +416,7 @@ public class CallLogAdapter extends GroupingListAdapter * Holds a list of URIs that are pending deletion or undo. If the activity ends before the undo * timeout, all of the pending URIs will be deleted. * - * <p>TODO: move this and OnVoicemailDeletedListener to somewhere like {@link + * <p>TODO(twyen): move this and OnVoicemailDeletedListener to somewhere like {@link * VisualVoicemailCallLogFragment}. The CallLogAdapter does not need to know about what to do with * hidden item or what to hide. */ diff --git a/java/com/android/dialer/app/contactinfo/ContactInfoCache.java b/java/com/android/dialer/app/contactinfo/ContactInfoCache.java index 82fc229af..155a6a2eb 100644 --- a/java/com/android/dialer/app/contactinfo/ContactInfoCache.java +++ b/java/com/android/dialer/app/contactinfo/ContactInfoCache.java @@ -163,7 +163,7 @@ public class ContactInfoCache { if (request.isLocalRequest()) { info = mContactInfoHelper.lookupNumber(request.number, request.countryIso); if (info != null && !info.contactExists) { - // TODO: Maybe skip look up if it's already available in cached number lookup + // TODO(wangqi): Maybe skip look up if it's already available in cached number lookup // service. long start = SystemClock.elapsedRealtime(); mContactInfoHelper.updateFromCequintCallerId(mCequintCallerIdManager, info, request.number); diff --git a/java/com/android/dialer/app/voicemail/VoicemailErrorManager.java b/java/com/android/dialer/app/voicemail/VoicemailErrorManager.java index a0bae36cc..bc6ffb5a7 100644 --- a/java/com/android/dialer/app/voicemail/VoicemailErrorManager.java +++ b/java/com/android/dialer/app/voicemail/VoicemailErrorManager.java @@ -92,7 +92,7 @@ public class VoicemailErrorManager implements CallLogQueryHandler.Listener, Voic } } alertItem.updateStatus(statuses, this); - // TODO: b/30668323 support error from multiple sources. + // TODO(twyen): b/30668323 support error from multiple sources. return; } diff --git a/java/com/android/dialer/app/voicemail/VoicemailPlaybackLayout.java b/java/com/android/dialer/app/voicemail/VoicemailPlaybackLayout.java index f160e024e..9c1e446ab 100644 --- a/java/com/android/dialer/app/voicemail/VoicemailPlaybackLayout.java +++ b/java/com/android/dialer/app/voicemail/VoicemailPlaybackLayout.java @@ -85,7 +85,7 @@ public class VoicemailPlaybackLayout extends LinearLayout // When the undo button is pressed, the viewHolder we have is no longer valid because when // we hide the view it is binded to something else, and the layout is not updated for // hidden items. copy the adapter position so we can update the view upon undo. - // TODO: refactor this so the view holder will always be valid. + // TODO(twyen): refactor this so the view holder will always be valid. final int adapterPosition = mViewHolder.getAdapterPosition(); mPresenter.pausePlayback(); diff --git a/java/com/android/dialer/app/voicemail/error/VoicemailTosMessageCreator.java b/java/com/android/dialer/app/voicemail/error/VoicemailTosMessageCreator.java index 3f0ed1f58..cf6564a74 100644 --- a/java/com/android/dialer/app/voicemail/error/VoicemailTosMessageCreator.java +++ b/java/com/android/dialer/app/voicemail/error/VoicemailTosMessageCreator.java @@ -72,11 +72,11 @@ public class VoicemailTosMessageCreator { @Nullable VoicemailErrorMessage maybeCreateTosMessage() { - // TODO: add filtering based on carrier + // TODO(mdooley): add filtering based on carrier if (hasAcceptedTos()) { return null; } - // TODO: temporarily skip the terms of service for dogfood builds + // TODO(mdooley): temporarily skip the terms of service for dogfood builds if (BuildType.get() == BuildType.DOGFOOD) { LogUtil.i( "VoicemailTosMessageCreator.maybeCreateTosMessage", diff --git a/java/com/android/dialer/app/voicemail/error/Vvm3VoicemailMessageCreator.java b/java/com/android/dialer/app/voicemail/error/Vvm3VoicemailMessageCreator.java index e639eff23..d3024f4c5 100644 --- a/java/com/android/dialer/app/voicemail/error/Vvm3VoicemailMessageCreator.java +++ b/java/com/android/dialer/app/voicemail/error/Vvm3VoicemailMessageCreator.java @@ -259,7 +259,7 @@ public class Vvm3VoicemailMessageCreator { @NonNull private static CharSequence getCustomerSupportString(Context context, int id) { - // TODO: get number based on the country the user is currently in. + // TODO(twyen): get number based on the country the user is currently in. return ContactDisplayUtils.getTtsSpannedPhoneNumber( context.getResources(), id, diff --git a/java/com/android/dialer/blocking/FilteredNumberAsyncQueryHandler.java b/java/com/android/dialer/blocking/FilteredNumberAsyncQueryHandler.java index fa74850ba..d806a8303 100644 --- a/java/com/android/dialer/blocking/FilteredNumberAsyncQueryHandler.java +++ b/java/com/android/dialer/blocking/FilteredNumberAsyncQueryHandler.java @@ -262,7 +262,7 @@ public class FilteredNumberAsyncQueryHandler extends AsyncQueryHandler { } /* - * TODO: b/27779827, non-e164 numbers can be blocked in the new form of blocking. As a + * TODO(maxwelb): b/27779827, non-e164 numbers can be blocked in the new form of blocking. As a * temporary workaround, determine which column of the database to query based on whether the * number is e164 or not. */ diff --git a/java/com/android/dialer/blocking/FilteredNumberCompat.java b/java/com/android/dialer/blocking/FilteredNumberCompat.java index 9e0112762..e104c4f94 100644 --- a/java/com/android/dialer/blocking/FilteredNumberCompat.java +++ b/java/com/android/dialer/blocking/FilteredNumberCompat.java @@ -270,7 +270,7 @@ public class FilteredNumberCompat { } // Great Wall blocking, must be primary user and the default or system dialer - // TODO: check that we're the system Dialer + // TODO(maxwelb): check that we're the system Dialer return TelecomUtil.isDefaultDialer(context) && safeBlockedNumbersContractCanCurrentUserBlockNumbers(context); } diff --git a/java/com/android/dialer/callcomposer/CallComposerActivity.java b/java/com/android/dialer/callcomposer/CallComposerActivity.java index 63d29b514..3eeb42547 100644 --- a/java/com/android/dialer/callcomposer/CallComposerActivity.java +++ b/java/com/android/dialer/callcomposer/CallComposerActivity.java @@ -396,7 +396,7 @@ public class CallComposerActivity extends AppCompatActivity /** Give permission to Messenger to view our image for RCS purposes. */ private Uri grantUriPermission(Uri uri) { - // TODO: Move this to the enriched call manager. + // TODO(sail): Move this to the enriched call manager. grantUriPermission( "com.google.android.apps.messaging", uri, Intent.FLAG_GRANT_READ_URI_PERMISSION); return uri; diff --git a/java/com/android/dialer/callcomposer/camera/CameraManager.java b/java/com/android/dialer/callcomposer/camera/CameraManager.java index 5915ce331..783b57ec3 100644 --- a/java/com/android/dialer/callcomposer/camera/CameraManager.java +++ b/java/com/android/dialer/callcomposer/camera/CameraManager.java @@ -118,7 +118,7 @@ public class CameraManager implements FocusOverlayManager.Listener { /** * The task for opening the camera, so it doesn't block the UI thread Using AsyncTask rather than * SafeAsyncTask because the tasks need to be serialized, but don't need to be on the UI thread - * TODO: If we have other AyncTasks (not SafeAsyncTasks) this may contend and we may need + * TODO(blemmon): If we have other AyncTasks (not SafeAsyncTasks) this may contend and we may need * to create a dedicated thread, or synchronize the threads in the thread pool */ private AsyncTask<Integer, Void, Camera> mOpenCameraTask; diff --git a/java/com/android/dialer/callcomposer/camera/camerafocus/FocusOverlayManager.java b/java/com/android/dialer/callcomposer/camera/camerafocus/FocusOverlayManager.java index 1c5ac380c..a5edf3309 100644 --- a/java/com/android/dialer/callcomposer/camera/camerafocus/FocusOverlayManager.java +++ b/java/com/android/dialer/callcomposer/camera/camerafocus/FocusOverlayManager.java @@ -389,7 +389,7 @@ public class FocusOverlayManager { focusIndicator.showStart(); } else { if (Parameters.FOCUS_MODE_CONTINUOUS_PICTURE.equals(mFocusMode)) { - // TODO: check HAL behavior and decide if this can be removed. + // TODO(blemmon): check HAL behavior and decide if this can be removed. focusIndicator.showSuccess(false); } else if (mState == STATE_SUCCESS) { focusIndicator.showSuccess(false); diff --git a/java/com/android/dialer/callcomposer/camera/exif/ExifParser.java b/java/com/android/dialer/callcomposer/camera/exif/ExifParser.java index 23d748c17..c728845a1 100644 --- a/java/com/android/dialer/callcomposer/camera/exif/ExifParser.java +++ b/java/com/android/dialer/callcomposer/camera/exif/ExifParser.java @@ -499,7 +499,7 @@ public class ExifParser { mTiffStream.skip(4); return null; } - // TODO: handle numOfComp overflow + // TODO(blemmon): handle numOfComp overflow ExifTag tag = new ExifTag( tagId, diff --git a/java/com/android/dialer/callcomposer/camera/exif/ExifTag.java b/java/com/android/dialer/callcomposer/camera/exif/ExifTag.java index a254ae93b..9a03c103c 100644 --- a/java/com/android/dialer/callcomposer/camera/exif/ExifTag.java +++ b/java/com/android/dialer/callcomposer/camera/exif/ExifTag.java @@ -187,7 +187,7 @@ public class ExifTag { /** Gets the component count of this tag. */ - // TODO: fix integer overflows with this + // TODO(blemmon): fix integer overflows with this int getComponentCount() { return mComponentCountActual; } diff --git a/java/com/android/dialer/calldetails/CallDetailsEntryViewHolder.java b/java/com/android/dialer/calldetails/CallDetailsEntryViewHolder.java index bc989ea25..41c85215d 100644 --- a/java/com/android/dialer/calldetails/CallDetailsEntryViewHolder.java +++ b/java/com/android/dialer/calldetails/CallDetailsEntryViewHolder.java @@ -57,7 +57,7 @@ public class CallDetailsEntryViewHolder extends ViewHolder { private final ImageView multimediaImage; - // TODO: Display this when location is stored - b/36160042 + // TODO(maxwelb): Display this when location is stored - b/36160042 @SuppressWarnings("unused") private final TextView multimediaAttachmentsNumber; diff --git a/java/com/android/dialer/callintent/speed_dial_contact_type.proto b/java/com/android/dialer/callintent/speed_dial_contact_type.proto index 2d1fa3f3c..ecb1c3f28 100644 --- a/java/com/android/dialer/callintent/speed_dial_contact_type.proto +++ b/java/com/android/dialer/callintent/speed_dial_contact_type.proto @@ -4,9 +4,11 @@ option java_package = "com.android.dialer.callintent"; option java_multiple_files = true; option optimize_for = LITE_RUNTIME; + package com.android.dialer.callintent; + // The type of speed call contact (favorites). Applies to initiation type // SPEED_DIAL only. message SpeedDialContactType { diff --git a/java/com/android/dialer/calllog/database/AnnotatedCallLogDatabaseHelper.java b/java/com/android/dialer/calllog/database/AnnotatedCallLogDatabaseHelper.java index 887dfcbb6..5f48d7b1f 100644 --- a/java/com/android/dialer/calllog/database/AnnotatedCallLogDatabaseHelper.java +++ b/java/com/android/dialer/calllog/database/AnnotatedCallLogDatabaseHelper.java @@ -68,7 +68,7 @@ class AnnotatedCallLogDatabaseHelper extends SQLiteOpenHelper { long startTime = System.currentTimeMillis(); db.execSQL(CREATE_TABLE_SQL); db.execSQL(String.format(Locale.US, CREATE_TRIGGER_SQL, maxRows, maxRows)); - // TODO: Consider logging impression. + // TODO(zachh): Consider logging impression. LogUtil.i( "AnnotatedCallLogDatabaseHelper.onCreate", "took: %dms", diff --git a/java/com/android/dialer/calllog/database/Coalescer.java b/java/com/android/dialer/calllog/database/Coalescer.java index 5683687fd..23ddc9c21 100644 --- a/java/com/android/dialer/calllog/database/Coalescer.java +++ b/java/com/android/dialer/calllog/database/Coalescer.java @@ -129,7 +129,7 @@ public class Coalescer { */ private static boolean rowsShouldBeCombined( DialerPhoneNumberUtil dialerPhoneNumberUtil, ContentValues row1, ContentValues row2) { - // TODO: Real implementation. + // TODO(zachh): Real implementation. DialerPhoneNumber number1; DialerPhoneNumber number2; try { diff --git a/java/com/android/dialer/calllog/datasources/contacts/ContactsDataSource.java b/java/com/android/dialer/calllog/datasources/contacts/ContactsDataSource.java index 82a85235b..db7421515 100644 --- a/java/com/android/dialer/calllog/datasources/contacts/ContactsDataSource.java +++ b/java/com/android/dialer/calllog/datasources/contacts/ContactsDataSource.java @@ -39,7 +39,7 @@ public final class ContactsDataSource implements CallLogDataSource { public boolean isDirty(Context appContext) { Assert.isWorkerThread(); - // TODO: Implementation. + // TODO(zachh): Implementation. return false; } @@ -49,7 +49,7 @@ public final class ContactsDataSource implements CallLogDataSource { Context appContext, CallLogMutations mutations) { Assert.isWorkerThread(); - // TODO: Implementation. + // TODO(zachh): Implementation. for (ContentValues contentValues : mutations.getInserts().values()) { contentValues.put(AnnotatedCallLog.CONTACT_NAME, "Placeholder name"); } @@ -57,12 +57,12 @@ public final class ContactsDataSource implements CallLogDataSource { @Override public void onSuccessfulFill(Context appContext) { - // TODO: Implementation. + // TODO(zachh): Implementation. } @Override public ContentValues coalesce(List<ContentValues> individualRowsSortedByTimestampDesc) { - // TODO: Implementation. + // TODO(zachh): Implementation. return new RowCombiner(individualRowsSortedByTimestampDesc) .useSingleValueString(AnnotatedCallLog.CONTACT_NAME) .combine(); @@ -72,6 +72,6 @@ public final class ContactsDataSource implements CallLogDataSource { @Override public void registerContentObservers( Context appContext, ContentObserverCallbacks contentObserverCallbacks) { - // TODO: Guard against missing permissions during callback registration. + // TODO(zachh): Guard against missing permissions during callback registration. } } diff --git a/java/com/android/dialer/calllog/datasources/systemcalllog/SystemCallLogDataSource.java b/java/com/android/dialer/calllog/datasources/systemcalllog/SystemCallLogDataSource.java index f2063283f..86145a95b 100644 --- a/java/com/android/dialer/calllog/datasources/systemcalllog/SystemCallLogDataSource.java +++ b/java/com/android/dialer/calllog/datasources/systemcalllog/SystemCallLogDataSource.java @@ -143,7 +143,7 @@ public class SystemCallLogDataSource implements CallLogDataSource { @Override public ContentValues coalesce(List<ContentValues> individualRowsSortedByTimestampDesc) { - // TODO: Complete implementation. + // TODO(zachh): Complete implementation. ContentValues coalescedValues = new RowCombiner(individualRowsSortedByTimestampDesc) .useMostRecentLong(AnnotatedCallLog.TIMESTAMP) @@ -182,7 +182,7 @@ public class SystemCallLogDataSource implements CallLogDataSource { DialerPhoneNumberUtil dialerPhoneNumberUtil = new DialerPhoneNumberUtil(PhoneNumberUtil.getInstance()); - // TODO: Really should be getting last 1000 by timestamp, not by last modified. + // TODO(zachh): Really should be getting last 1000 by timestamp, not by last modified. try (Cursor cursor = appContext .getContentResolver() diff --git a/java/com/android/dialer/calllog/ui/NewCallLogFragment.java b/java/com/android/dialer/calllog/ui/NewCallLogFragment.java index 712f7cf25..17fcf1939 100644 --- a/java/com/android/dialer/calllog/ui/NewCallLogFragment.java +++ b/java/com/android/dialer/calllog/ui/NewCallLogFragment.java @@ -92,7 +92,7 @@ public final class NewCallLogFragment extends Fragment CallLogFramework callLogFramework = CallLogComponent.get(getContext()).callLogFramework(); callLogFramework.attachUi(this); - // TODO: Consider doing this when fragment becomes visible. + // TODO(zachh): Consider doing this when fragment becomes visible. checkAnnotatedCallLogDirtyAndRefreshIfNecessary(); } @@ -142,7 +142,7 @@ public final class NewCallLogFragment extends Fragment public void onLoadFinished(Loader<Cursor> loader, Cursor newCursor) { LogUtil.enterBlock("NewCallLogFragment.onLoadFinished"); - // TODO: Handle empty cursor by showing empty view. + // TODO(zachh): Handle empty cursor by showing empty view. recyclerView.setLayoutManager(new LinearLayoutManager(getContext())); recyclerView.setAdapter(new NewCallLogAdapter(newCursor)); } diff --git a/java/com/android/dialer/calllog/ui/NewCallLogViewHolder.java b/java/com/android/dialer/calllog/ui/NewCallLogViewHolder.java index 4c459e123..9521a032c 100644 --- a/java/com/android/dialer/calllog/ui/NewCallLogViewHolder.java +++ b/java/com/android/dialer/calllog/ui/NewCallLogViewHolder.java @@ -24,7 +24,7 @@ import java.util.Locale; /** {@link RecyclerView.ViewHolder} for the new call log. */ final class NewCallLogViewHolder extends RecyclerView.ViewHolder { - // TODO: Format correctly using current locale. + // TODO(zachh): Format correctly using current locale. private final SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd HH:mm", Locale.US); private final TextView contactNameView; diff --git a/java/com/android/dialer/contactactions/ContactActionBottomSheet.java b/java/com/android/dialer/contactactions/ContactActionBottomSheet.java index 4718ff036..56c8a9465 100644 --- a/java/com/android/dialer/contactactions/ContactActionBottomSheet.java +++ b/java/com/android/dialer/contactactions/ContactActionBottomSheet.java @@ -75,7 +75,7 @@ public class ContactActionBottomSheet extends BottomSheetDialog implements OnCli } } - // TODO: add on click action to contact. + // TODO(calderwoodra): add on click action to contact. private View getContactView(ViewGroup container) { LayoutInflater inflater = LayoutInflater.from(getContext()); View contactView = inflater.inflate(R.layout.contact_layout, container, false); diff --git a/java/com/android/dialer/database/VoicemailStatusQuery.java b/java/com/android/dialer/database/VoicemailStatusQuery.java index d9e1b721b..dbd88be1f 100644 --- a/java/com/android/dialer/database/VoicemailStatusQuery.java +++ b/java/com/android/dialer/database/VoicemailStatusQuery.java @@ -27,7 +27,7 @@ import java.util.List; /** The query for the call voicemail status table. */ public class VoicemailStatusQuery { - // TODO: Column indices should be removed in favor of Cursor#getColumnIndex + // TODO(maxwelb): Column indices should be removed in favor of Cursor#getColumnIndex public static final int SOURCE_PACKAGE_INDEX = 0; public static final int SETTINGS_URI_INDEX = 1; public static final int VOICEMAIL_ACCESS_URI_INDEX = 2; diff --git a/java/com/android/dialer/main/impl/MainActivity.java b/java/com/android/dialer/main/impl/MainActivity.java index 4b2bd2e05..6dced3db2 100644 --- a/java/com/android/dialer/main/impl/MainActivity.java +++ b/java/com/android/dialer/main/impl/MainActivity.java @@ -77,7 +77,7 @@ public final class MainActivity extends AppCompatActivity implements View.OnClic // open contacts return true; } else { - // TODO handle other menu items + // TODO(calderwoodra) handle other menu items return super.onOptionsItemSelected(item); } } diff --git a/java/com/android/dialer/main/impl/MainPagerAdapter.java b/java/com/android/dialer/main/impl/MainPagerAdapter.java index 19cf4e7b1..c669a620a 100644 --- a/java/com/android/dialer/main/impl/MainPagerAdapter.java +++ b/java/com/android/dialer/main/impl/MainPagerAdapter.java @@ -49,13 +49,13 @@ final class MainPagerAdapter extends FragmentStatePagerAdapter { @Override public int getCount() { - // TODO: add logic to hide/show voicemail tab + // TODO(calderwoodra): add logic to hide/show voicemail tab return 3; } @Override public Fragment getItem(int position) { - // TODO: implement tabs + // TODO(calderwoodra): implement tabs return new StubFragment(); } diff --git a/java/com/android/dialer/notification/VoicemailChannelUtils.java b/java/com/android/dialer/notification/VoicemailChannelUtils.java index dc74799ca..e2d0f3a21 100644 --- a/java/com/android/dialer/notification/VoicemailChannelUtils.java +++ b/java/com/android/dialer/notification/VoicemailChannelUtils.java @@ -193,7 +193,7 @@ import java.util.Set; private static NotificationChannel newChannel( @NonNull Context context, @NonNull String channelId, @Nullable CharSequence nameSuffix) { CharSequence name = context.getText(R.string.notification_channel_voicemail); - // TODO: Use a string resource template after v10. + // TODO(sail): Use a string resource template after v10. if (!TextUtils.isEmpty(nameSuffix)) { name = TextUtils.concat(name, ": ", nameSuffix); } diff --git a/java/com/android/dialer/oem/CequintCallerIdManager.java b/java/com/android/dialer/oem/CequintCallerIdManager.java index 86097c41a..7b6ddbc3a 100644 --- a/java/com/android/dialer/oem/CequintCallerIdManager.java +++ b/java/com/android/dialer/oem/CequintCallerIdManager.java @@ -74,7 +74,7 @@ public class CequintCallerIdManager { private static boolean hasAlreadyCheckedCequintCallerIdPackage; private static boolean isCequintCallerIdEnabled; - // TODO: Revisit it and maybe remove it if it's not necessary. + // TODO(wangqi): Revisit it and maybe remove it if it's not necessary. private final ConcurrentHashMap<String, CequintCallerIdContact> callLogCache; /** Cequint caller id contact information. */ diff --git a/java/com/android/dialer/persistentlog/PersistentLogger.java b/java/com/android/dialer/persistentlog/PersistentLogger.java index cf43b8ca8..7d82ec1a1 100644 --- a/java/com/android/dialer/persistentlog/PersistentLogger.java +++ b/java/com/android/dialer/persistentlog/PersistentLogger.java @@ -43,7 +43,7 @@ import java.util.concurrent.LinkedBlockingQueue; * com.google.android.apps.dialer.crashreporter.SilentCrashReporter} is expected to handle such * cases. * - * <p>{@link #logText(String, String)} should be used to log ad-hoc text logs. TODO: switch + * <p>{@link #logText(String, String)} should be used to log ad-hoc text logs. TODO(twyen): switch * to structured logging */ public final class PersistentLogger { diff --git a/java/com/android/dialer/phonenumberutil/PhoneNumberHelper.java b/java/com/android/dialer/phonenumberutil/PhoneNumberHelper.java index ea4396f02..cc4ec2da8 100644 --- a/java/com/android/dialer/phonenumberutil/PhoneNumberHelper.java +++ b/java/com/android/dialer/phonenumberutil/PhoneNumberHelper.java @@ -214,7 +214,7 @@ public class PhoneNumberHelper { private static boolean isVerizon(Context context) { // Verizon MCC/MNC codes copied from com/android/voicemailomtp/res/xml/vvm_config.xml. - // TODO: Need a better way to do per carrier and per OEM configurations. + // TODO(sail): Need a better way to do per carrier and per OEM configurations. switch (context.getSystemService(TelephonyManager.class).getSimOperator()) { case "310004": case "310010": diff --git a/java/com/android/dialer/searchfragment/README.md b/java/com/android/dialer/searchfragment/README.md index baeaa9caf..b3b9135e5 100644 --- a/java/com/android/dialer/searchfragment/README.md +++ b/java/com/android/dialer/searchfragment/README.md @@ -13,11 +13,11 @@ cp2 containing all of the relevant info needed to rendering. ### Business Search -// TODO +// TODO(calderwoodra) ### Google Directory Search -// TODO +// TODO(calderwoodra) ## Rendering diff --git a/java/com/android/dialer/searchfragment/common/QueryFilteringUtil.java b/java/com/android/dialer/searchfragment/common/QueryFilteringUtil.java index b23315b15..ee6e61c2e 100644 --- a/java/com/android/dialer/searchfragment/common/QueryFilteringUtil.java +++ b/java/com/android/dialer/searchfragment/common/QueryFilteringUtil.java @@ -42,7 +42,7 @@ public class QueryFilteringUtil { } // Check matches initials - // TODO investigate faster implementation + // TODO(calderwoodra) investigate faster implementation query = digitsOnly(query); int queryIndex = 0; diff --git a/java/com/android/dialer/searchfragment/cp2/SearchContactCursor.java b/java/com/android/dialer/searchfragment/cp2/SearchContactCursor.java index a2ef58c3c..51992646a 100644 --- a/java/com/android/dialer/searchfragment/cp2/SearchContactCursor.java +++ b/java/com/android/dialer/searchfragment/cp2/SearchContactCursor.java @@ -67,7 +67,7 @@ public final class SearchContactCursor implements Cursor { * @param query to filter cursor results. */ public SearchContactCursor(Cursor cursor, @Nullable String query) { - // TODO investigate copying this into a MatrixCursor and holding in memory + // TODO(calderwoodra) investigate copying this into a MatrixCursor and holding in memory this.cursor = cursor; filter(query); } diff --git a/java/com/android/dialer/searchfragment/cp2/SearchContactViewHolder.java b/java/com/android/dialer/searchfragment/cp2/SearchContactViewHolder.java index 5f06b5991..d3df02f79 100644 --- a/java/com/android/dialer/searchfragment/cp2/SearchContactViewHolder.java +++ b/java/com/android/dialer/searchfragment/cp2/SearchContactViewHolder.java @@ -127,8 +127,8 @@ public final class SearchContactViewHolder extends ViewHolder implements OnClick return Contacts.getLookupUri(contactId, lookupKey); } - // TODO: handle CNAP and cequint types. - // TODO: unify this into a utility method with CallLogAdapter#getNumberType + // TODO(calderwoodra): handle CNAP and cequint types. + // TODO(calderwoodra): unify this into a utility method with CallLogAdapter#getNumberType private static String getLabel(Resources resources, Cursor cursor) { int numberType = cursor.getInt(Projections.PHONE_TYPE); String numberLabel = cursor.getString(Projections.PHONE_LABEL); @@ -171,7 +171,7 @@ public final class SearchContactViewHolder extends ViewHolder implements OnClick return CallToAction.VIDEO_CALL; } - // TODO: enriched calling + // TODO(calderwoodra): enriched calling return CallToAction.NONE; } @@ -183,13 +183,13 @@ public final class SearchContactViewHolder extends ViewHolder implements OnClick callToActionView.setVisibility(View.VISIBLE); callToActionView.setImageDrawable( context.getDrawable(com.android.contacts.common.R.drawable.ic_phone_attach)); - // TODO: open call composer. + // TODO(calderwoodra): open call composer. break; case CallToAction.VIDEO_CALL: callToActionView.setVisibility(View.VISIBLE); callToActionView.setImageDrawable( context.getDrawable(R.drawable.quantum_ic_videocam_white_24)); - // TODO: place a video call + // TODO(calderwoodra): place a video call break; case CallToAction.NONE: default: @@ -197,7 +197,7 @@ public final class SearchContactViewHolder extends ViewHolder implements OnClick "Invalid Call to action type: " + currentAction); } } else { - // TODO: set the correct call initiation type. + // TODO(calderwoodra): set the correct call initiation type. TelecomUtil.placeCall(context, new CallIntentBuilder(number, Type.REGULAR_SEARCH).build()); } } diff --git a/java/com/android/dialer/searchfragment/list/NewSearchFragment.java b/java/com/android/dialer/searchfragment/list/NewSearchFragment.java index fcc87c386..d20bb1f8c 100644 --- a/java/com/android/dialer/searchfragment/list/NewSearchFragment.java +++ b/java/com/android/dialer/searchfragment/list/NewSearchFragment.java @@ -67,7 +67,7 @@ public final class NewSearchFragment extends Fragment implements LoaderCallbacks @Override public Loader<Cursor> onCreateLoader(int id, Bundle bundle) { - // TODO add enterprise loader + // TODO(calderwoodra) add enterprise loader if (id == CONTACTS_LOADER_ID) { return new SearchContactsCursorLoader(getContext()); } else if (id == NEARBY_PLACES_ID) { diff --git a/java/com/android/dialer/searchfragment/list/SearchAdapter.java b/java/com/android/dialer/searchfragment/list/SearchAdapter.java index 023513e47..faa80fe85 100644 --- a/java/com/android/dialer/searchfragment/list/SearchAdapter.java +++ b/java/com/android/dialer/searchfragment/list/SearchAdapter.java @@ -53,7 +53,7 @@ class SearchAdapter extends RecyclerView.Adapter<ViewHolder> { case RowType.NEARBY_PLACES_HEADER: return new HeaderViewHolder( LayoutInflater.from(context).inflate(R.layout.header_layout, root, false)); - case RowType.DIRECTORY_ROW: // TODO: add directory rows to search + case RowType.DIRECTORY_ROW: // TODO(calderwoodra): add directory rows to search case RowType.INVALID: default: throw Assert.createIllegalStateFailException("Invalid RowType: " + rowType); diff --git a/java/com/android/dialer/searchfragment/list/SearchCursorManager.java b/java/com/android/dialer/searchfragment/list/SearchCursorManager.java index 216a9ada9..45d66aab8 100644 --- a/java/com/android/dialer/searchfragment/list/SearchCursorManager.java +++ b/java/com/android/dialer/searchfragment/list/SearchCursorManager.java @@ -124,7 +124,7 @@ final class SearchCursorManager { void setQuery(String query) { if (contactsCursor != null) { - // TODO: abstract this + // TODO(calderwoodra): abstract this ((SearchContactCursor) contactsCursor).filter(query); } } @@ -242,7 +242,7 @@ final class SearchCursorManager { switch (rowType) { case RowType.NEARBY_PLACES_HEADER: return R.string.nearby_places; - case RowType.DIRECTORY_HEADER: // TODO + case RowType.DIRECTORY_HEADER: // TODO(calderwoodra) case RowType.DIRECTORY_ROW: case RowType.CONTACT_ROW: case RowType.NEARBY_PLACES_ROW: diff --git a/java/com/android/dialer/speeddial/SpeedDialFragment.java b/java/com/android/dialer/speeddial/SpeedDialFragment.java index 68ee3888b..c087439eb 100644 --- a/java/com/android/dialer/speeddial/SpeedDialFragment.java +++ b/java/com/android/dialer/speeddial/SpeedDialFragment.java @@ -23,7 +23,7 @@ import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; -/** Favorites fragment. Contents TBD. TODO */ +/** Favorites fragment. Contents TBD. TODO(calderwoodra) */ public class SpeedDialFragment extends Fragment { public static SpeedDialFragment newInstance() { @@ -38,7 +38,7 @@ public class SpeedDialFragment extends Fragment { } public boolean hasFrequents() { - // TODO + // TODO(calderwoodra) return false; } } |