summaryrefslogtreecommitdiff
path: root/java/com/android/dialer/voicemail
diff options
context:
space:
mode:
authormdooley <mdooley@google.com>2018-02-20 17:19:45 -0800
committerEric Erfanian <erfanian@google.com>2018-02-22 21:10:20 +0000
commitfa95b2d3c5696790d2b174b0d42984341dfc80f2 (patch)
tree19b8f8e9ae303db8b971271fbdb65eb9e0db4e95 /java/com/android/dialer/voicemail
parentf5326db368ba35faf861f690b09d0ea9c8d5080f (diff)
Adding information section to voicemail settings
this cl moves the TextViewPreference from dialer to third_party so it can be shared (sorry i meant to make that a separate cl, but forgot to switch branches). and it uses the TextViewPreference to add some informational text to the voicemail settings. screen shot: https://drive.google.com/open?id=0B9o_KvtLkcuIbENkeHRCSTUyOVpkM0JEZ0liMHphMnVzVHlN mock: https://drive.google.com/file/d/1gKt72pY-igXfphpamf8CqZV8HEmnOexj/view Bug: 37340510 Test: manual test PiperOrigin-RevId: 186388299 Change-Id: I2c142f1214a9424bec0bc7f12d841f0eeaef96f1
Diffstat (limited to 'java/com/android/dialer/voicemail')
-rw-r--r--java/com/android/dialer/voicemail/settings/VoicemailSettingsFragment.java23
-rw-r--r--java/com/android/dialer/voicemail/settings/res/values/strings.xml16
-rw-r--r--java/com/android/dialer/voicemail/settings/res/xml/voicemail_settings.xml4
3 files changed, 42 insertions, 1 deletions
diff --git a/java/com/android/dialer/voicemail/settings/VoicemailSettingsFragment.java b/java/com/android/dialer/voicemail/settings/VoicemailSettingsFragment.java
index 5ae26f5f7..7f5bb796a 100644
--- a/java/com/android/dialer/voicemail/settings/VoicemailSettingsFragment.java
+++ b/java/com/android/dialer/voicemail/settings/VoicemailSettingsFragment.java
@@ -32,12 +32,14 @@ import android.telecom.PhoneAccountHandle;
import android.telecom.TelecomManager;
import android.telephony.SubscriptionInfo;
import android.telephony.TelephonyManager;
+import android.text.Html;
import com.android.dialer.common.Assert;
import com.android.dialer.common.LogUtil;
import com.android.dialer.logging.DialerImpression;
import com.android.dialer.logging.Logger;
import com.android.dialer.notification.NotificationChannelManager;
import com.android.dialer.telecom.TelecomUtil;
+import com.android.dialer.widget.TextViewPreference;
import com.android.voicemail.VoicemailClient;
import com.android.voicemail.VoicemailClient.ActivationStateListener;
import com.android.voicemail.VoicemailComponent;
@@ -73,6 +75,7 @@ public class VoicemailSettingsFragment extends PreferenceFragment
private SwitchPreference donateVoicemailSwitchPreference;
private Preference voicemailChangePinPreference;
private PreferenceScreen advancedSettings;
+ private TextViewPreference voicemailTranscriptionInstructionText;
@Override
public void onCreate(Bundle icicle) {
@@ -209,6 +212,10 @@ public class VoicemailSettingsFragment extends PreferenceFragment
return false;
}
});
+
+ voicemailTranscriptionInstructionText =
+ (TextViewPreference) findPreference(getString(R.string.voicemail_transcription_text_key));
+ voicemailTranscriptionInstructionText.setTitle(getVoicemailTranscriptionInstructionsText());
}
@Override
@@ -348,4 +355,20 @@ public class VoicemailSettingsFragment extends PreferenceFragment
builder.setCancelable(true);
builder.show();
}
+
+ /**
+ * Builds a spannable string containing the voicemail transcription instructions text containing
+ * the appropriate "Learn More" urls.
+ *
+ * @return The voicemail transcription instructions text.
+ */
+ private CharSequence getVoicemailTranscriptionInstructionsText() {
+ String settingText =
+ getString(
+ R.string.voicemail_transcription_instruction_text,
+ getString(R.string.transcription_learn_more_url),
+ getString(R.string.donation_learn_more_url));
+ CharSequence settingSeq = Html.fromHtml(settingText);
+ return settingSeq;
+ }
}
diff --git a/java/com/android/dialer/voicemail/settings/res/values/strings.xml b/java/com/android/dialer/voicemail/settings/res/values/strings.xml
index 10fa459ff..47228b70b 100644
--- a/java/com/android/dialer/voicemail/settings/res/values/strings.xml
+++ b/java/com/android/dialer/voicemail/settings/res/values/strings.xml
@@ -44,7 +44,7 @@
<string name="voicemail_change_pin_key" translatable="false">voicemail_change_pin_key</string>
<!-- Visual voicemail on/off title [CHAR LIMIT=40] -->
- <string name="voicemail_visual_voicemail_switch_title">Visual Voicemail</string>
+ <string name="voicemail_visual_voicemail_switch_title">Visual voicemail</string>
<!-- Visual voicemail archive on/off title [CHAR LIMIT=40] -->
<string name="voicemail_visual_voicemail_auto_archive_switch_title">Extra backup and storage</string>
@@ -125,4 +125,18 @@
<!-- The label for the confirm-disable-voicemail button [CHAR LIMIT=16] -->
<string name="confirm_disable_voicemail_accept_dialog_label">TURN OFF</string>
+ <!-- Internal preferences key for static instruction text. -->
+ <string name="voicemail_transcription_text_key" translatable="false">voicemail_transcription_text_key</string>
+
+ <!-- Additional information text and links for visual voicemail and voicemail donation setting page
+ [CHAR LIMIT=NONE] -->
+ <string name="voicemail_transcription_instruction_text">
+ Visual voicemail allows you to check voicemail messages without having to call voicemail. Transcripts provided by Google. &lt;a href="<xliff:g example="http://www.google.com" id="url1">%1$s</xliff:g>">Learn&#160;more&lt;/a>
+ &lt;br>&lt;br>
+ For voicemail transcription analysis, your voicemail messages are stored anonymously. &lt;a href="<xliff:g example="http://www.google.com" id="url2">%2$s</xliff:g>">Learn&#160;more&lt;/a>
+ </string>
+
+ <string translatable="false" name="transcription_learn_more_url">https://support.google.com/phoneapp/answer/2811844?hl=en%26ref_topic=7539039</string>
+ <string translatable="false" name="donation_learn_more_url">https://support.google.com/phoneapp/answer/2811844#voicemail_transcript</string>
+
</resources>
diff --git a/java/com/android/dialer/voicemail/settings/res/xml/voicemail_settings.xml b/java/com/android/dialer/voicemail/settings/res/xml/voicemail_settings.xml
index 9b0391ad4..75c8cfe2b 100644
--- a/java/com/android/dialer/voicemail/settings/res/xml/voicemail_settings.xml
+++ b/java/com/android/dialer/voicemail/settings/res/xml/voicemail_settings.xml
@@ -43,4 +43,8 @@
android:key="@string/voicemail_advanced_settings_key"
android:title="@string/voicemail_advanced_settings_title">
</PreferenceScreen>
+
+ <com.android.dialer.widget.TextViewPreference
+ android:key="@string/voicemail_transcription_text_key"/>
+
</PreferenceScreen>